User Details
- User Since
- Jan 4 2016, 7:08 PM (485 w, 2 d)
Tue, Mar 25
Implement feedback from jhb.
Mar 24 2025
Mar 14 2025
Update with recent changes from Github PR: https://github.com/freebsd/freebsd-src/pull/1573
Mar 7 2025
Looks good to me. Unfortunately I don't have any EM HW to test it.
LGTM
Feb 10 2025
The one thing I think drivers would like to do is allocate additional MSI-X IRQs on the fly
Feb 7 2025
Ah, that makes sense. Thanks a lot for clarification!
Feb 4 2025
Feb 3 2025
I'm not sure why pci_msix_count returns incorrect number. pciconf output looks fine:
Jan 29 2025
TX filter for LLDP frames is added to prevent i.e. VFs from messing up with DCB config. My colleagues suggest using an override in TX path like it's done in the Linux driver: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ice/ice_txrx.c?h=v6.13#n2360 instead of removing this filter. I'm still digging in the docs to better understand if this is the only option when SR-IOV is in use. Could you please wait until ice(4): Add host SR-IOV support is ready?
Jan 28 2025
LGTM
Jan 17 2025
We're trying a different approach to make the work more transparent and enable receiving feedback earlier during development. This patch will be updated with bug fixes and missing features. There is also a pull request on Github if you'd like to see commits history: https://github.com/freebsd/freebsd-src/pull/1573
Jan 3 2025
LGTM but let me ask @bartosz.sobczak_intel.com to take a look at irdma changes.
Jan 2 2025
@kbowling Do you want me to make any additional changes in this patch?
Dec 6 2024
Prefix taskqueue name with 'if_'.
Nov 25 2024
Add forgotten task init for IFLIB_INTR_IOV soft irq type.
Oct 23 2024
Oct 21 2024
Oct 18 2024
Rebased on top of master.
Free taskqueue after releasing interrupts per jhb comment on Github.
Oct 1 2024
Aug 14 2024
@franco_opnsense.org Output from sysctl dev.ixl.<N>.debug.filter_list and ifmcstat may shed some light on the problem. IPv4/v6 addresses can be removed. I'd like to compare mcast-macaddr list and filters configured by driver. Could you please open also a PR on FreeBSD bugzilla?
Jul 22 2024
May 29 2024
May 14 2024
Jul 6 2023
Feb 6 2023
Jan 10 2023
Nov 21 2022
Jul 1 2022
Apr 19 2022
Fixed typo in device id, was 5G instead of 1G.
Apr 15 2022
Feb 8 2022
Update patch to apply on top of HEAD
Feb 7 2022
Update patch to apply on top of HEAD
Sep 13 2021
Aug 16 2021
Jul 23 2021
- Do not rely on information from link event
Jul 9 2021
I'm still not able to reproduce this issue with any of my switches. Could you, please, modify printf in the ixl_link_event function to dump hex values of status->link_info, status->an_info, hw->phy.link_info.link_info and hw->phy.link_info.an_info, and send me the log?
Jun 30 2021
Thank you Sai! Now I understand what I should be looking for.
Jun 23 2021
Jun 17 2021
Jun 14 2021
Actually using separate sysctl_ctx was necessary in non-iflib version of the driver to allow releasing and re-allocating queues while handling EMP reset. In this version Rx queues memory is managed by the iflib with IFDI interface so using separate syssctl context may be not required. Let me double check that.
Jun 11 2021
Jun 8 2021
May 18 2021
Mar 19 2021
Mar 3 2021
Fixed with D21924 by marius
Feb 16 2021
Jan 14 2021
Jan 13 2021
- Fix unqualified transceivers reporting
Jan 7 2021
Dec 16 2020
Dec 3 2020
Aug 26 2020
Fix PHY configuration parameters when enabling EEE
Aug 10 2020
@lwhsu: Could you, please, remove the declaration in line 610 instead? The first occurrence is in a group of other LED functions.
Aug 4 2020
- Add missing cases in ixl_if_media_status for 2.5 and 5G
Jul 2 2020
Jun 9 2020
- Replace 'if 1' with 'ifdef IXL_DEBUG' in ixl_pf.h to match with if_ixl.c
Jun 2 2020
- Fix sysctl ctx handling in IAVF
May 16 2020
Backported disable rings fix implemented by Eric Joyner in ixl-iflib version of the driver. It prevents queue hangs when interface is reconfigured while receiving heavy traffic.
May 12 2020
- Remove redundant PF reset after EMP reset
May 7 2020
- Don't process admin queue if its not configured
May 4 2020
- Fix receiving broadcast frames after reset
Apr 24 2020
Sep 23 2019
Sep 20 2019
Sep 19 2019
Sep 6 2019
Aug 12 2019
Jul 1 2019
Jun 5 2019
ixlv: Use old implementation of _msec_pause for reset flow to avoid panic.
May 24 2019
Changes in Netmap support for ixl caused that ixlv cannot be loaded when built as KLD. Move ixl specific Netmap includes from ixl_txrx.c file, which is shared by ixl and ixlv, to ixl_pf_main.c which is used only by ixl.
May 20 2019
May 17 2019
Feb 28 2019
Jan 28 2019
This limitation came from our out-of-tree driver, where we had to keep backwards compatibility, but there is no reason to keep it in the in-kernel version. Thanks Vincenzo for the patch. It looks good to me but let's wait for Eric to have a look too.