In D46062#1076736, @kbowling wrote:

Seems reasonable to me. If there is any work that depends or interacts with these changes it would be nice to see them linked/referenced so we can look at that too but I can't foresee any problems.

Rebased on top of master.
Free taskqueue after releasing interrupts per jhb comment on Github.

In D12142#1068558, @kbowling wrote:

In D12142#1068530, @krzysztof.galazka_intel.com wrote:

In D12142#1066726, @kbowling wrote:

@krzysztof.galazka_intel.com can you rebase this on main?

Did autocompletion tricked you, or am I really the target of your message? I'm not sure if @kmacy will be happy with me messing with his patch.

Sorry I was looking at another review and got the wires crossed, for some reason I thought this was an Intel patch but I was looking at something else.

In D12142#1066726, @kbowling wrote:

@krzysztof.galazka_intel.com can you rebase this on main?

@franco_opnsense.org Output from sysctl dev.ixl.<N>.debug.filter_list and ifmcstat may shed some light on the problem. IPv4/v6 addresses can be removed. I'd like to compare mcast-macaddr list and filters configured by driver. Could you please open also a PR on FreeBSD bugzilla?

Fixed typo in device id, was 5G instead of 1G.

Update patch to apply on top of HEAD

Update patch to apply on top of HEAD

In D30733#701137, @stallamr_netapp.com wrote:

• Do not rely on information from link event

I'm still not able to reproduce this issue with any of my switches. Could you, please, modify printf in the ixl_link_event function to dump hex values of status->link_info, status->an_info, hw->phy.link_info.link_info and hw->phy.link_info.an_info, and send me the log?

Thank you Sai! Now I understand what I should be looking for.

In D30733#693043, @stallamr_netapp.com wrote:

I have connected the cable back-to-back between two servers and rebooted them both at a time. During boot, on both the nodes, immediately after the driver is attached, receives link-event and notices MEDIA_AVAILABLE + IFF_UP + UNQUALIFIED + NO_LINK_UP.

In D30733#691657, @stallamr_netapp.com wrote:

So, thinking on this, my guess is that when you reboot the machine, we would be finding an "unqualified" for a qualified cable because FW see this as link down. Also, my guess, the cable will show up as unqualified when you shut the link on link-partner.

Actually using separate sysctl_ctx was necessary in non-iflib version of the driver to allow releasing and re-allocating queues while handling EMP reset. In this version Rx queues memory is managed by the iflib with IFDI interface so using separate syssctl context may be not required. Let me double check that.

In D30733#690739, @stallamr_netapp.com wrote:

Also, in original change, https://reviews.freebsd.org/D28028, I noticed that after executing ixl_set_link(pf, false), the PHY capabilities query for an_info has I40E_AQ_QUALIFIED_MODULE unset. So, the same supported/qualified module becomes unqualified.
I think the crux of the problem is with ixl_set_link() unsetting I40E_AQ_QUALIFIED_MODULE.

Fixed with D21924 by marius

• Fix unqualified transceivers reporting

In D27344#611363, @gallatin wrote:

At least on real hardware I've used with iflib, with both ix and ixl, one needs to adjust irq moderation manually in order to get a decent amount of packets per irq. I honestly think AIM might be the best path forward for less tuning knobs, if it were the default with a wider range of min and max irq rates.

Fix PHY configuration parameters when enabling EEE

@lwhsu: Could you, please, remove the declaration in line 610 instead? The first occurrence is in a group of other LED functions.

• Add missing cases in ixl_if_media_status for 2.5 and 5G

• Replace 'if 1' with 'ifdef IXL_DEBUG' in ixl_pf.h to match with if_ixl.c

• Fix sysctl ctx handling in IAVF

Backported disable rings fix implemented by Eric Joyner in ixl-iflib version of the driver. It prevents queue hangs when interface is reconfigured while receiving heavy traffic.

• Remove redundant PF reset after EMP reset

• Don't process admin queue if its not configured

• Fix receiving broadcast frames after reset

In D21712#473977, @gallatin wrote:

I'm not sure, but I think the only way this can happen is when the link is down. Is that the caee here?

ixlv: Use old implementation of _msec_pause for reset flow to avoid panic.

Changes in Netmap support for ixl caused that ixlv cannot be loaded when built as KLD. Move ixl specific Netmap includes from ixl_txrx.c file, which is shared by ixl and ixlv, to ixl_pf_main.c which is used only by ixl.

This limitation came from our out-of-tree driver, where we had to keep backwards compatibility, but there is no reason to keep it in the in-kernel version. Thanks Vincenzo for the patch. It looks good to me but let's wait for Eric to have a look too.

@shurd - Turns out you've been faster. We've been working one this bug too. Our plan was to do it this way:

@shurd Thanks! That makes more sense than my version. I can't reproduce the ixl panic on my machine but Iets wait for an official verification by Jeff's team.

• Add iflib_in_detach check to iflib_intr_iov_deferred as sugested by Stephen.

In D17404#375574, @shurd wrote:

My opinion is that mtx_owned() would just make this all more complex. Releasing a lock for a short period isn't a problem at all.

In D17404#373883, @shurd wrote:

iflib_admin_intr_deferred() called with STATE_LOCK() in a few places.

• STATE_UNLOCK moved to address Stephen's comment.

Adding dependency on D16428 didn't worked as planned :/ Changes are included in diff. I'll try to fix that later.

• Calling gtaskqueue_drain moved to taskqgroup_detach
• Added condition to iflib_admin_intr_deferred to prevent rescheduling task during detach

In D17404#371923, @shurd wrote:

Is there a reason not to do this in taskqgroup_detach()?

• ixl/ixlv: Reset head writeback value on TX ring init

• ixl(4): Re-add descriptor writeback TX completion as optionable tunable
• Merge branch 'master' into ixl-iflib
• Merge commit 'fa5413e897294cb6a74d75e7317c5dbeb42e185c' into ixl-iflib
• ixl(4): Remove unused variables, macros, and comments
• ixl(4): Replace some numbers with constants
• Merge upstream FreeBSD branch 'master' into ixl-iflib
• ixl(4): Fix typo in sysctl help message
• ixl(4): Edit whitespace and a function comment
• ixl(4): Remove a debug printf()
• ixl(4): Remove a couple old functions and prototypes
• ixl(4): Remove unused variables from PF struct
• ixl(4): Add two new I2C access methods
• ixl(4): Actually increment TSO stat counter
• ixl(4): Set some iflib flags and a fied to correct values
• ixl(4): Stop reading header length value from RX descriptor
• ixl(4): Fix and move an assert in the RX path
• ixl(4): Enhance add/remove macvlan error reporting
• ixl(4): Edit spacing and remove old comments
• ixl(4): Fix queue allocation bug
• ixl(4): Replace bsrl() with the architecture-independent fls()
• ixl(4): Remove redundant MAC type / FW version check
• ixl(4): Copy a couple things from Linux's RCTX setup
• Merge branch 'intel-wired-ethernet/master' into ixl-iflib
• iflib: Fix memory leak when TX packet defrag finally fails
• ixl(4): Move function to where VF driver can use it
• ixl(4): Remove unused function definitions and declarations
• ixl(4): Remove hard link check in ixl_if_media_status
• Merge freebsd/freebsd branch 'master' into ixl-iflib
• ixl(4): Change ixl_tso_detect_sparse()
• ixl(4): Edit debug i2c sysctl help messages
• ixl(4): Add debug sysctl to read some diagnostic data from i2c
• ixl(4): Remove unnecessary SYSCTL_OUT from previous commit
• ixl(4): Return an error when debug i2c diag sysctl encounters one
• ixl(4): Fix error handling during attach process
• Merge remote-tracking branch 'origin/master' into ixl-iflib
• ixl(4): Simplify ixl_find_filter()
• ixl(4): Temporarily stop initializing SR-IOV support
• ixl(4): Add driver version number to end of device description string
• ixl(4): Get rid of unused tunables.
• ixl(4): Initial implementation of driver private ioctl
• ixl(4): Fix driver setup after receiving reset interrupt from HW
• iflib: Add new shared flag to iflib IFLIB_ADMIN_ALWAYS_RUN
• ixl(4): Remove VSI allocation message after device reset
• ixl: Rename function to better reflect purpose
• Merge freebsd/freebsd branch 'master' into ixl-iflib
• Merge freebsd/freebsd branch 'master' into ixl-iflib (2018-05-30)

• Deduplicate queue hang detection code and use same method in PF and VF drivers. Fixes kernel panic on VF with TCP bi-directional traffic.

• Queue hang detection refactored to prevent kernel panic
• Version bumped to 1.9.9 to align with out-of-tree driver

In D14985#318249, @smh wrote:

Is there anything happening with this as head is still 1.7.12-k which is very far behind the latest intel download which is 1.9.7?

• Patch rebased on top of HEAD.
• Fixed panic reported for TCP BX traffic.

Hi Alexandre!

Rebased on top of HEAD with erj@ patch for ixv_if_init (r328365)