Page MenuHomeFreeBSD

krzysztof.galazka_intel.com (Krzysztof Galazka)
User

Projects

User Details

User Since
Jan 4 2016, 7:08 PM (154 w, 22 h)

Recent Activity

Tue, Dec 11

krzysztof.galazka_intel.com added a reviewer for D18469: ix: Fix accessing wrong register, improve WoL support recognition ix, ixv: Update link status with autonegotiated baudrate value: jeffrey.e.pieper_intel.com.
Tue, Dec 11, 2:03 PM
krzysztof.galazka_intel.com added a reviewer for D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled: jeffrey.e.pieper_intel.com.
Tue, Dec 11, 2:01 PM
krzysztof.galazka_intel.com added 1 blocking reviewer(s) for D18468: ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status: jeffrey.e.pieper_intel.com.
Tue, Dec 11, 2:00 PM
krzysztof.galazka_intel.com added a reviewer for D18468: ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status: jeffrey.e.pieper_intel.com.
Tue, Dec 11, 1:58 PM

Nov 7 2018

krzysztof.galazka_intel.com added a reviewer for D17881: Fix rxcsum issue introduced in r338838: Intel Networking.

@shurd - Turns out you've been faster. We've been working one this bug too. Our plan was to do it this way:

Nov 7 2018, 7:39 PM

Oct 24 2018

krzysztof.galazka_intel.com added a reviewer for D17674: Drain grouptaskqueue of the gtask before detaching it.: Intel Networking.

@shurd Thanks! That makes more sense than my version. I can't reproduce the ixl panic on my machine but Iets wait for an official verification by Jeff's team.

Oct 24 2018, 3:55 PM

Oct 19 2018

krzysztof.galazka_intel.com updated the diff for D17404: iflib: drain enqueued tasks before detaching from taskqgroup.
  • Add iflib_in_detach check to iflib_intr_iov_deferred as sugested by Stephen.
Oct 19 2018, 2:43 PM

Oct 17 2018

krzysztof.galazka_intel.com added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

My opinion is that mtx_owned() would just make this all more complex. Releasing a lock for a short period isn't a problem at all.

Oct 17 2018, 4:57 PM

Oct 16 2018

krzysztof.galazka_intel.com added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

iflib_admin_intr_deferred() called with STATE_LOCK() in a few places.

Oct 16 2018, 7:03 AM
krzysztof.galazka_intel.com updated the diff for D17404: iflib: drain enqueued tasks before detaching from taskqgroup.
  • STATE_UNLOCK moved to address Stephen's comment.
Oct 16 2018, 6:57 AM

Oct 11 2018

krzysztof.galazka_intel.com added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

Adding dependency on D16428 didn't worked as planned :/ Changes are included in diff. I'll try to fix that later.

Oct 11 2018, 9:01 AM
krzysztof.galazka_intel.com updated the diff for D17404: iflib: drain enqueued tasks before detaching from taskqgroup.
  • Calling gtaskqueue_drain moved to taskqgroup_detach
  • Added condition to iflib_admin_intr_deferred to prevent rescheduling task during detach
Oct 11 2018, 8:57 AM

Oct 8 2018

krzysztof.galazka_intel.com added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

Is there a reason not to do this in taskqgroup_detach()?

Oct 8 2018, 7:02 PM

Oct 4 2018

krzysztof.galazka_intel.com created D17404: iflib: drain enqueued tasks before detaching from taskqgroup.
Oct 4 2018, 12:33 PM

Jun 6 2018

krzysztof.galazka_intel.com updated the diff for D15577: Update ixl(4) to use iflib..
  • ixl/ixlv: Reset head writeback value on TX ring init
Jun 6 2018, 4:04 PM

May 30 2018

krzysztof.galazka_intel.com updated the diff for D15577: Update ixl(4) to use iflib..
  • ixl(4): Re-add descriptor writeback TX completion as optionable tunable
  • Merge branch 'master' into ixl-iflib
  • Merge commit 'fa5413e897294cb6a74d75e7317c5dbeb42e185c' into ixl-iflib
  • ixl(4): Remove unused variables, macros, and comments
  • ixl(4): Replace some numbers with constants
  • Merge upstream FreeBSD branch 'master' into ixl-iflib
  • ixl(4): Fix typo in sysctl help message
  • ixl(4): Edit whitespace and a function comment
  • ixl(4): Remove a debug printf()
  • ixl(4): Remove a couple old functions and prototypes
  • ixl(4): Remove unused variables from PF struct
  • ixl(4): Add two new I2C access methods
  • ixl(4): Actually increment TSO stat counter
  • ixl(4): Set some iflib flags and a fied to correct values
  • ixl(4): Stop reading header length value from RX descriptor
  • ixl(4): Fix and move an assert in the RX path
  • ixl(4): Enhance add/remove macvlan error reporting
  • ixl(4): Edit spacing and remove old comments
  • ixl(4): Fix queue allocation bug
  • ixl(4): Replace bsrl() with the architecture-independent fls()
  • ixl(4): Remove redundant MAC type / FW version check
  • ixl(4): Copy a couple things from Linux's RCTX setup
  • Merge branch 'intel-wired-ethernet/master' into ixl-iflib
  • iflib: Fix memory leak when TX packet defrag finally fails
  • ixl(4): Move function to where VF driver can use it
  • ixl(4): Remove unused function definitions and declarations
  • ixl(4): Remove hard link check in ixl_if_media_status
  • Merge freebsd/freebsd branch 'master' into ixl-iflib
  • ixl(4): Change ixl_tso_detect_sparse()
  • ixl(4): Edit debug i2c sysctl help messages
  • ixl(4): Add debug sysctl to read some diagnostic data from i2c
  • ixl(4): Remove unnecessary SYSCTL_OUT from previous commit
  • ixl(4): Return an error when debug i2c diag sysctl encounters one
  • ixl(4): Fix error handling during attach process
  • Merge remote-tracking branch 'origin/master' into ixl-iflib
  • ixl(4): Simplify ixl_find_filter()
  • ixl(4): Temporarily stop initializing SR-IOV support
  • ixl(4): Add driver version number to end of device description string
  • ixl(4): Get rid of unused tunables.
  • ixl(4): Initial implementation of driver private ioctl
  • ixl(4): Fix driver setup after receiving reset interrupt from HW
  • iflib: Add new shared flag to iflib IFLIB_ADMIN_ALWAYS_RUN
  • ixl(4): Remove VSI allocation message after device reset
  • ixl: Rename function to better reflect purpose
  • Merge freebsd/freebsd branch 'master' into ixl-iflib
  • Merge freebsd/freebsd branch 'master' into ixl-iflib (2018-05-30)
May 30 2018, 5:51 PM

Apr 27 2018

krzysztof.galazka_intel.com updated the diff for D14985: ixl(4): Update to 1.9.9-k.
  • Deduplicate queue hang detection code and use same method in PF and VF drivers. Fixes kernel panic on VF with TCP bi-directional traffic.
Apr 27 2018, 10:34 PM

Apr 24 2018

krzysztof.galazka_intel.com updated the diff for D14985: ixl(4): Update to 1.9.9-k.
  • Queue hang detection refactored to prevent kernel panic
  • Version bumped to 1.9.9 to align with out-of-tree driver
Apr 24 2018, 1:08 PM

Apr 20 2018

krzysztof.galazka_intel.com added a comment to D14985: ixl(4): Update to 1.9.9-k.
In D14985#318249, @smh wrote:

Is there anything happening with this as head is still 1.7.12-k which is very far behind the latest intel download which is 1.9.7?

Apr 20 2018, 1:27 PM

Apr 16 2018

krzysztof.galazka_intel.com updated the diff for D14985: ixl(4): Update to 1.9.9-k.
  • Patch rebased on top of HEAD.
  • Fixed panic reported for TCP BX traffic.
Apr 16 2018, 11:56 AM

Apr 6 2018

krzysztof.galazka_intel.com created D14985: ixl(4): Update to 1.9.9-k.
Apr 6 2018, 10:33 AM

Feb 9 2018

krzysztof.galazka_intel.com added a reviewer for D13980: Fix ixl driver performance issue: Intel Networking.
Feb 9 2018, 6:34 PM
krzysztof.galazka_intel.com added a comment to D13980: Fix ixl driver performance issue.

Hi Alexandre!

Feb 9 2018, 6:33 PM

Jan 23 2018

krzysztof.galazka_intel.com updated the diff for D13885: ixgbe(4): Update shared code, add support for X552, fix bug.

Rebased on top of HEAD with erj@ patch for ixv_if_init (r328365)

Jan 23 2018, 11:47 AM

Jan 12 2018

krzysztof.galazka_intel.com added a reviewer for D13885: ixgbe(4): Update shared code, add support for X552, fix bug: kbowling.
Jan 12 2018, 4:50 PM
krzysztof.galazka_intel.com created D13885: ixgbe(4): Update shared code, add support for X552, fix bug.
Jan 12 2018, 4:47 PM

Dec 5 2017

krzysztof.galazka_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.
  • Rebased on top of HEAD
  • ixgbe(4): Set proper max number of queues.
Dec 5 2017, 3:38 PM

Dec 1 2017

krzysztof.galazka_intel.com added a comment to D12446: Support attaching tx queues to cpus.

Without witness it panics too:

Fatal trap 9: general protection fault while in kernel mode
cpuid = 42; apic id = 38
instruction pointer     = 0x20:0xffffffff80cb4c31
stack pointer           = 0x28:0xfffffe010b7ed030
frame pointer           = 0x28:0xfffffe010b7ed050
code segment            = base 0x0, limit 0xfffff, type 0x1b
                        = DPL 0, pres 1, long 1, def32 0, gran 1
processor eflags        = interrupt enabled, resume, IOPL = 0
current process         = 1117 (kldload)
Dec 1 2017, 2:13 PM

Nov 30 2017

krzysztof.galazka_intel.com added a reviewer for D12142: Don't start grouptaskqueue threads for unused grouptaskqueues: Intel Networking.
Nov 30 2017, 6:22 PM

Nov 20 2017

krzysztof.galazka_intel.com added a comment to D12446: Support attaching tx queues to cpus.

How to dump a panic when the kernel crash during boot before loading disk controller drivers ?
Can I compile a kernel with .debug embedded into the kernel ?

Hrm... you could build a kernel without ix in it and kldload if_ix after the system is up... though that may cause the issue to not occur.

Nov 20 2017, 3:36 PM

Nov 13 2017

krzysztof.galazka_intel.com added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

Second, on a Dual CPU, Xeon_E5-2650 (12Cores), with Intel 82599ES 10Gigabit (using default 8 queues):

Hrm... is that two E5-2651s for 24 cores total, or two 6-core E5s for 12 cores total?

Yes: there are 2 CPU, with 12 cores each (HT is disabled), and by default the ixgbe drivers is using a maximum of 8 MSIX queues (I've kept the default because I don't want to fall into the NUMA trap).

Nov 13 2017, 8:11 PM

Oct 6 2017

krzysztof.galazka_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.
  • Rebased on top of D12496
  • Prevent attach to complete if legacy interrupts are configured

on devices which do not support this mode.

Oct 6 2017, 1:43 PM

Aug 14 2017

krzysztof.galazka_intel.com added a member for Intel Networking: piotr.pietruszewski_intel.com.
Aug 14 2017, 9:31 AM

Jul 27 2017

krzysztof.galazka_intel.com updated the diff for D11476: iflib - try m_defrag when m_collapse fails.

Proper fix for segments accounting in iflib_busdma_load_mbuf_sg.

Jul 27 2017, 10:21 AM
krzysztof.galazka_intel.com planned changes to D11476: iflib - try m_defrag when m_collapse fails.
Jul 27 2017, 10:17 AM

Jul 6 2017

krzysztof.galazka_intel.com added a comment to D11476: iflib - try m_defrag when m_collapse fails.

Thanks for your review.

Jul 6 2017, 11:58 AM

Jul 5 2017

krzysztof.galazka_intel.com added a comment to D11476: iflib - try m_defrag when m_collapse fails.

@olivier - Could you tell me what tools do you use? I'd like to check if forwarding performance on other HW is also affected.

Jul 5 2017, 6:19 PM

Jul 4 2017

krzysztof.galazka_intel.com created D11476: iflib - try m_defrag when m_collapse fails.
Jul 4 2017, 2:09 PM

Jun 29 2017

krzysztof.galazka_intel.com abandoned D11404: iflib - use proper max segment size for DMA.

First (failed) attempt to update diff with arc.

Jun 29 2017, 10:15 AM
krzysztof.galazka_intel.com updated the diff for D11403: iflib - use proper max segment size for DMA.

Proper size used for TSO.

Jun 29 2017, 10:05 AM
krzysztof.galazka_intel.com created D11404: iflib - use proper max segment size for DMA.
Jun 29 2017, 10:03 AM
krzysztof.galazka_intel.com added a reviewer for D11403: iflib - use proper max segment size for DMA: Intel Networking.
Jun 29 2017, 10:00 AM
krzysztof.galazka_intel.com created D11403: iflib - use proper max segment size for DMA.
Jun 29 2017, 9:59 AM

Jun 27 2017

krzysztof.galazka_intel.com added a member for Intel Networking: bartosz.sobczak_intel.com.
Jun 27 2017, 11:42 AM

Mar 22 2017

krzysztof.galazka_intel.com requested changes to D5213: convert ixgbe to iflib.

The function ixgbe_intr used in if_txrx struct filled in ix_txrx.c is defined in if_ix.c but ix_txrx.c is used in both ix and ixv drivers so ixv build as KLD cannot be loaded.

Mar 22 2017, 2:31 PM

Feb 2 2017

krzysztof.galazka_intel.com requested changes to D5213: convert ixgbe to iflib.

The ixv fails to build because there is no ifdi_if.h in SRCS. Could you update the Makefile?

Feb 2 2017, 8:04 AM