Page MenuHomeFreeBSD

krzysztof.galazka_intel.com (Krzysztof Galazka)
User

Projects

User Details

User Since
Jan 4 2016, 7:08 PM (284 w, 4 d)

Recent Activity

Yesterday

krzysztof.galazka_intel.com added a comment to D30733: ixl(4): Fix reporting of unqualified transceivers.

So, thinking on this, my guess is that when you reboot the machine, we would be finding an "unqualified" for a qualified cable because FW see this as link down. Also, my guess, the cable will show up as unqualified when you shut the link on link-partner.

Thu, Jun 17, 9:42 PM

Mon, Jun 14

krzysztof.galazka_intel.com added a reviewer for D30758: Check for non-empty sysctl_ctx before attempting free: Intel Networking.

Actually using separate sysctl_ctx was necessary in non-iflib version of the driver to allow releasing and re-allocating queues while handling EMP reset. In this version Rx queues memory is managed by the iflib with IFDI interface so using separate syssctl context may be not required. Let me double check that.

Mon, Jun 14, 4:50 PM
krzysztof.galazka_intel.com added a comment to D30733: ixl(4): Fix reporting of unqualified transceivers.

Also, in original change, https://reviews.freebsd.org/D28028, I noticed that after executing ixl_set_link(pf, false), the PHY capabilities query for an_info has I40E_AQ_QUALIFIED_MODULE unset. So, the same supported/qualified module becomes unqualified.
I think the crux of the problem is with ixl_set_link() unsetting I40E_AQ_QUALIFIED_MODULE.

Mon, Jun 14, 3:59 PM

Fri, Jun 11

krzysztof.galazka_intel.com requested review of D30733: ixl(4): Fix reporting of unqualified transceivers.
Fri, Jun 11, 4:28 PM

Tue, Jun 8

krzysztof.galazka_intel.com added reviewers for D30691: ixl(4): Add VxLAN HW offloads support: Intel Networking, stallamr_netapp.com.
Tue, Jun 8, 7:16 AM
krzysztof.galazka_intel.com requested review of D30691: ixl(4): Add VxLAN HW offloads support.
Tue, Jun 8, 7:13 AM

May 18 2021

krzysztof.galazka_intel.com added inline comments to D30178: ixgbe: Print NVM and Option ROM versions.
May 18 2021, 3:19 PM

Mar 19 2021

krzysztof.galazka_intel.com requested review of D29338: ixl(4): Add tunable to override Flow Control settings.
Mar 19 2021, 11:41 AM

Mar 3 2021

krzysztof.galazka_intel.com abandoned D21769: em/igb: Properly re-arm link interrupt.

Fixed with D21924 by marius

Mar 3 2021, 2:00 PM
krzysztof.galazka_intel.com added a reviewer for D29037: iflib: Add fields for tunneled packets in if_pkt_info: gallatin.
Mar 3 2021, 1:50 PM
krzysztof.galazka_intel.com requested review of D29037: iflib: Add fields for tunneled packets in if_pkt_info.
Mar 3 2021, 1:48 PM

Feb 16 2021

krzysztof.galazka_intel.com added a watcher for iflib: krzysztof.galazka_intel.com.
Feb 16 2021, 8:00 PM

Jan 14 2021

krzysztof.galazka_intel.com added a member for Intel Networking: gowtham.kumar.ks_intel.com.
Jan 14 2021, 11:50 AM

Jan 13 2021

krzysztof.galazka_intel.com requested review of D28137: ixl(4): Fix VLAN HW filtering.
Jan 13 2021, 3:42 PM
krzysztof.galazka_intel.com updated the diff for D28028: ixl(4): Add ability to control link state on ifconfig down.
  • Fix unqualified transceivers reporting
Jan 13 2021, 1:47 PM

Jan 7 2021

krzysztof.galazka_intel.com requested review of D28028: ixl(4): Add ability to control link state on ifconfig down.
Jan 7 2021, 8:38 PM

Dec 16 2020

krzysztof.galazka_intel.com requested review of D27639: ixl(4): Report RX errors as sum of all RX error counters.
Dec 16 2020, 7:39 PM

Dec 3 2020

krzysztof.galazka_intel.com removed a reviewer for D27344: Bring back AIM (Adaptive Interrupt Moderation) that was lost in IFLIB migration.: Intel Networking.

At least on real hardware I've used with iflib, with both ix and ixl, one needs to adjust irq moderation manually in order to get a decent amount of packets per irq. I honestly think AIM might be the best path forward for less tuning knobs, if it were the default with a wider range of min and max irq rates.

Dec 3 2020, 9:44 PM
krzysztof.galazka_intel.com requested review of D27465: iflib: Add rx_wait_irq configuration option.
Dec 3 2020, 8:07 PM

Aug 26 2020

krzysztof.galazka_intel.com updated the diff for D25549: ixl(4): Add support for X710-T*L devices.

Fix PHY configuration parameters when enabling EEE

Aug 26 2020, 11:47 AM

Aug 10 2020

krzysztof.galazka_intel.com added a comment to D25954: Remove redeclaration found by gcc build.

@lwhsu: Could you, please, remove the declaration in line 610 instead? The first occurrence is in a group of other LED functions.

Aug 10 2020, 7:23 PM

Aug 4 2020

krzysztof.galazka_intel.com updated the diff for D25549: ixl(4): Add support for X710-T*L devices.
  • Add missing cases in ixl_if_media_status for 2.5 and 5G
Aug 4 2020, 6:33 PM

Jul 2 2020

krzysztof.galazka_intel.com requested review of D25549: ixl(4): Add support for X710-T*L devices.
Jul 2 2020, 6:52 PM

Jun 9 2020

krzysztof.galazka_intel.com updated the diff for D24564: ixl(4): Add FW recovery mode support.
  • Replace 'if 1' with 'ifdef IXL_DEBUG' in ixl_pf.h to match with if_ixl.c
Jun 9 2020, 10:01 PM

Jun 2 2020

krzysztof.galazka_intel.com updated the diff for D24564: ixl(4): Add FW recovery mode support.
  • Fix sysctl ctx handling in IAVF
Jun 2 2020, 5:50 PM

May 16 2020

krzysztof.galazka_intel.com updated the diff for D21223: ixl(4): Fix issues with MTU change while passing traffic.

Backported disable rings fix implemented by Eric Joyner in ixl-iflib version of the driver. It prevents queue hangs when interface is reconfigured while receiving heavy traffic.

May 16 2020, 4:36 PM

May 12 2020

krzysztof.galazka_intel.com updated the diff for D24564: ixl(4): Add FW recovery mode support.
  • Remove redundant PF reset after EMP reset
May 12 2020, 7:33 PM

May 7 2020

krzysztof.galazka_intel.com updated the diff for D24564: ixl(4): Add FW recovery mode support.
  • Don't process admin queue if its not configured
May 7 2020, 10:26 PM

May 4 2020

krzysztof.galazka_intel.com updated the diff for D24564: ixl(4): Add FW recovery mode support.
  • Fix receiving broadcast frames after reset
May 4 2020, 1:14 PM

Apr 24 2020

krzysztof.galazka_intel.com created D24564: ixl(4): Add FW recovery mode support.
Apr 24 2020, 9:03 PM

Sep 23 2019

krzysztof.galazka_intel.com created D21769: em/igb: Properly re-arm link interrupt.
Sep 23 2019, 6:10 PM

Sep 20 2019

krzysztof.galazka_intel.com added a comment to D21712: iflib: Prevent watchdog from resetting idle queues.

I'm not sure, but I think the only way this can happen is when the link is down. Is that the caee here?

Sep 20 2019, 11:17 AM

Sep 19 2019

krzysztof.galazka_intel.com added a reviewer for D21705: if_ixv: disable RSS configuration on 82599 and X540 VFs: Intel Networking.
Sep 19 2019, 9:09 AM

Sep 6 2019

krzysztof.galazka_intel.com added reviewers for D21547: ix, ixv: Read msix_bar from device configuration: marius, shurd.
Sep 6 2019, 4:34 PM

Aug 12 2019

krzysztof.galazka_intel.com updated the summary of D21223: ixl(4): Fix issues with MTU change while passing traffic.
Aug 12 2019, 8:59 AM
krzysztof.galazka_intel.com created D21223: ixl(4): Fix issues with MTU change while passing traffic.
Aug 12 2019, 8:33 AM

Jul 1 2019

krzysztof.galazka_intel.com created D20826: ixgbe(4): Fix enabling/disabling and reconfiguration of queues.
Jul 1 2019, 5:21 PM

Jun 5 2019

krzysztof.galazka_intel.com updated the diff for D20290: Update Intel XL710 PF and VF drivers to version ixl-1.11.9 and ixlv-1.5.8.

ixlv: Use old implementation of _msec_pause for reset flow to avoid panic.

Jun 5 2019, 11:54 AM

May 24 2019

krzysztof.galazka_intel.com updated the diff for D20290: Update Intel XL710 PF and VF drivers to version ixl-1.11.9 and ixlv-1.5.8.

Changes in Netmap support for ixl caused that ixlv cannot be loaded when built as KLD. Move ixl specific Netmap includes from ixl_txrx.c file, which is shared by ixl and ixlv, to ixl_pf_main.c which is used only by ixl.

May 24 2019, 2:08 PM

May 20 2019

krzysztof.galazka_intel.com added reviewers for D20290: Update Intel XL710 PF and VF drivers to version ixl-1.11.9 and ixlv-1.5.8: shurd, marius.
May 20 2019, 11:16 AM

May 17 2019

krzysztof.galazka_intel.com created D20290: Update Intel XL710 PF and VF drivers to version ixl-1.11.9 and ixlv-1.5.8.
May 17 2019, 12:58 PM

Feb 28 2019

krzysztof.galazka_intel.com created D19402: ixv(4): Add missing IFLIB_IS_VF flag in iflib shared ctx.
Feb 28 2019, 11:43 AM

Jan 28 2019

krzysztof.galazka_intel.com added a reviewer for D18984: ixl: remove unnecessary limitations related to netmap: Intel Networking.

This limitation came from our out-of-tree driver, where we had to keep backwards compatibility, but there is no reason to keep it in the in-kernel version. Thanks Vincenzo for the patch. It looks good to me but let's wait for Eric to have a look too.

Jan 28 2019, 10:43 AM

Jan 11 2019

krzysztof.galazka_intel.com created D18817: ixl(4): Fix handling data passed with ioctl from NVM update tool.
Jan 11 2019, 8:57 AM

Dec 11 2018

krzysztof.galazka_intel.com added a reviewer for D18469: ix: Fix accessing wrong register, improve WoL support recognition ix, ixv: Update link status with autonegotiated baudrate value: jeffrey.e.pieper_intel.com.
Dec 11 2018, 2:03 PM
krzysztof.galazka_intel.com added a reviewer for D18470: ix(4),ixv(4): Fix TSO offloads when TXCSUM is disabled: jeffrey.e.pieper_intel.com.
Dec 11 2018, 2:01 PM
krzysztof.galazka_intel.com added 1 blocking reviewer(s) for D18468: ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status: jeffrey.e.pieper_intel.com.
Dec 11 2018, 2:00 PM
krzysztof.galazka_intel.com added a reviewer for D18468: ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status: jeffrey.e.pieper_intel.com.
Dec 11 2018, 1:58 PM

Nov 7 2018

krzysztof.galazka_intel.com added a reviewer for D17881: Fix rxcsum issue introduced in r338838: Intel Networking.

@shurd - Turns out you've been faster. We've been working one this bug too. Our plan was to do it this way:

Nov 7 2018, 7:39 PM

Oct 24 2018

krzysztof.galazka_intel.com added a reviewer for D17674: Drain grouptaskqueue of the gtask before detaching it.: Intel Networking.

@shurd Thanks! That makes more sense than my version. I can't reproduce the ixl panic on my machine but Iets wait for an official verification by Jeff's team.

Oct 24 2018, 3:55 PM

Oct 19 2018

krzysztof.galazka_intel.com updated the diff for D17404: iflib: drain enqueued tasks before detaching from taskqgroup.
  • Add iflib_in_detach check to iflib_intr_iov_deferred as sugested by Stephen.
Oct 19 2018, 2:43 PM

Oct 17 2018

krzysztof.galazka_intel.com added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

My opinion is that mtx_owned() would just make this all more complex. Releasing a lock for a short period isn't a problem at all.

Oct 17 2018, 4:57 PM

Oct 16 2018

krzysztof.galazka_intel.com added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

iflib_admin_intr_deferred() called with STATE_LOCK() in a few places.

Oct 16 2018, 7:03 AM
krzysztof.galazka_intel.com updated the diff for D17404: iflib: drain enqueued tasks before detaching from taskqgroup.
  • STATE_UNLOCK moved to address Stephen's comment.
Oct 16 2018, 6:57 AM

Oct 11 2018

krzysztof.galazka_intel.com added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

Adding dependency on D16428 didn't worked as planned :/ Changes are included in diff. I'll try to fix that later.

Oct 11 2018, 9:01 AM
krzysztof.galazka_intel.com updated the diff for D17404: iflib: drain enqueued tasks before detaching from taskqgroup.
  • Calling gtaskqueue_drain moved to taskqgroup_detach
  • Added condition to iflib_admin_intr_deferred to prevent rescheduling task during detach
Oct 11 2018, 8:57 AM

Oct 8 2018

krzysztof.galazka_intel.com added a comment to D17404: iflib: drain enqueued tasks before detaching from taskqgroup.

Is there a reason not to do this in taskqgroup_detach()?

Oct 8 2018, 7:02 PM

Oct 4 2018

krzysztof.galazka_intel.com created D17404: iflib: drain enqueued tasks before detaching from taskqgroup.
Oct 4 2018, 12:33 PM

Jun 6 2018

krzysztof.galazka_intel.com updated the diff for D15577: Update ixl(4) to use iflib..
  • ixl/ixlv: Reset head writeback value on TX ring init
Jun 6 2018, 4:04 PM

May 30 2018

krzysztof.galazka_intel.com updated the diff for D15577: Update ixl(4) to use iflib..
  • ixl(4): Re-add descriptor writeback TX completion as optionable tunable
  • Merge branch 'master' into ixl-iflib
  • Merge commit 'fa5413e897294cb6a74d75e7317c5dbeb42e185c' into ixl-iflib
  • ixl(4): Remove unused variables, macros, and comments
  • ixl(4): Replace some numbers with constants
  • Merge upstream FreeBSD branch 'master' into ixl-iflib
  • ixl(4): Fix typo in sysctl help message
  • ixl(4): Edit whitespace and a function comment
  • ixl(4): Remove a debug printf()
  • ixl(4): Remove a couple old functions and prototypes
  • ixl(4): Remove unused variables from PF struct
  • ixl(4): Add two new I2C access methods
  • ixl(4): Actually increment TSO stat counter
  • ixl(4): Set some iflib flags and a fied to correct values
  • ixl(4): Stop reading header length value from RX descriptor
  • ixl(4): Fix and move an assert in the RX path
  • ixl(4): Enhance add/remove macvlan error reporting
  • ixl(4): Edit spacing and remove old comments
  • ixl(4): Fix queue allocation bug
  • ixl(4): Replace bsrl() with the architecture-independent fls()
  • ixl(4): Remove redundant MAC type / FW version check
  • ixl(4): Copy a couple things from Linux's RCTX setup
  • Merge branch 'intel-wired-ethernet/master' into ixl-iflib
  • iflib: Fix memory leak when TX packet defrag finally fails
  • ixl(4): Move function to where VF driver can use it
  • ixl(4): Remove unused function definitions and declarations
  • ixl(4): Remove hard link check in ixl_if_media_status
  • Merge freebsd/freebsd branch 'master' into ixl-iflib
  • ixl(4): Change ixl_tso_detect_sparse()
  • ixl(4): Edit debug i2c sysctl help messages
  • ixl(4): Add debug sysctl to read some diagnostic data from i2c
  • ixl(4): Remove unnecessary SYSCTL_OUT from previous commit
  • ixl(4): Return an error when debug i2c diag sysctl encounters one
  • ixl(4): Fix error handling during attach process
  • Merge remote-tracking branch 'origin/master' into ixl-iflib
  • ixl(4): Simplify ixl_find_filter()
  • ixl(4): Temporarily stop initializing SR-IOV support
  • ixl(4): Add driver version number to end of device description string
  • ixl(4): Get rid of unused tunables.
  • ixl(4): Initial implementation of driver private ioctl
  • ixl(4): Fix driver setup after receiving reset interrupt from HW
  • iflib: Add new shared flag to iflib IFLIB_ADMIN_ALWAYS_RUN
  • ixl(4): Remove VSI allocation message after device reset
  • ixl: Rename function to better reflect purpose
  • Merge freebsd/freebsd branch 'master' into ixl-iflib
  • Merge freebsd/freebsd branch 'master' into ixl-iflib (2018-05-30)
May 30 2018, 5:51 PM

Apr 27 2018

krzysztof.galazka_intel.com updated the diff for D14985: ixl(4): Update to 1.9.9-k.
  • Deduplicate queue hang detection code and use same method in PF and VF drivers. Fixes kernel panic on VF with TCP bi-directional traffic.
Apr 27 2018, 10:34 PM

Apr 24 2018

krzysztof.galazka_intel.com updated the diff for D14985: ixl(4): Update to 1.9.9-k.
  • Queue hang detection refactored to prevent kernel panic
  • Version bumped to 1.9.9 to align with out-of-tree driver
Apr 24 2018, 1:08 PM

Apr 20 2018

krzysztof.galazka_intel.com added a comment to D14985: ixl(4): Update to 1.9.9-k.
In D14985#318249, @smh wrote:

Is there anything happening with this as head is still 1.7.12-k which is very far behind the latest intel download which is 1.9.7?

Apr 20 2018, 1:27 PM

Apr 16 2018

krzysztof.galazka_intel.com updated the diff for D14985: ixl(4): Update to 1.9.9-k.
  • Patch rebased on top of HEAD.
  • Fixed panic reported for TCP BX traffic.
Apr 16 2018, 11:56 AM

Apr 6 2018

krzysztof.galazka_intel.com created D14985: ixl(4): Update to 1.9.9-k.
Apr 6 2018, 10:33 AM

Feb 9 2018

krzysztof.galazka_intel.com added a reviewer for D13980: Fix ixl driver performance issue: Intel Networking.
Feb 9 2018, 6:34 PM
krzysztof.galazka_intel.com added a comment to D13980: Fix ixl driver performance issue.

Hi Alexandre!

Feb 9 2018, 6:33 PM

Jan 23 2018

krzysztof.galazka_intel.com updated the diff for D13885: ixgbe(4): Update shared code, add support for X552, fix bug.

Rebased on top of HEAD with erj@ patch for ixv_if_init (r328365)

Jan 23 2018, 11:47 AM

Jan 12 2018

krzysztof.galazka_intel.com added a reviewer for D13885: ixgbe(4): Update shared code, add support for X552, fix bug: kbowling.
Jan 12 2018, 4:50 PM
krzysztof.galazka_intel.com created D13885: ixgbe(4): Update shared code, add support for X552, fix bug.
Jan 12 2018, 4:47 PM

Dec 5 2017

krzysztof.galazka_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.
  • Rebased on top of HEAD
  • ixgbe(4): Set proper max number of queues.
Dec 5 2017, 3:38 PM

Dec 1 2017

krzysztof.galazka_intel.com added a comment to D12446: Support attaching tx queues to cpus.

Without witness it panics too:

Fatal trap 9: general protection fault while in kernel mode
cpuid = 42; apic id = 38
instruction pointer     = 0x20:0xffffffff80cb4c31
stack pointer           = 0x28:0xfffffe010b7ed030
frame pointer           = 0x28:0xfffffe010b7ed050
code segment            = base 0x0, limit 0xfffff, type 0x1b
                        = DPL 0, pres 1, long 1, def32 0, gran 1
processor eflags        = interrupt enabled, resume, IOPL = 0
current process         = 1117 (kldload)
Dec 1 2017, 2:13 PM

Nov 30 2017

krzysztof.galazka_intel.com added a reviewer for D12142: Don't start grouptaskqueue threads for unused grouptaskqueues: Intel Networking.
Nov 30 2017, 6:22 PM

Nov 20 2017

krzysztof.galazka_intel.com added a comment to D12446: Support attaching tx queues to cpus.

How to dump a panic when the kernel crash during boot before loading disk controller drivers ?
Can I compile a kernel with .debug embedded into the kernel ?

Hrm... you could build a kernel without ix in it and kldload if_ix after the system is up... though that may cause the issue to not occur.

Nov 20 2017, 3:36 PM

Nov 13 2017

krzysztof.galazka_intel.com added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

Second, on a Dual CPU, Xeon_E5-2650 (12Cores), with Intel 82599ES 10Gigabit (using default 8 queues):

Hrm... is that two E5-2651s for 24 cores total, or two 6-core E5s for 12 cores total?

Yes: there are 2 CPU, with 12 cores each (HT is disabled), and by default the ixgbe drivers is using a maximum of 8 MSIX queues (I've kept the default because I don't want to fall into the NUMA trap).

Nov 13 2017, 8:11 PM

Oct 6 2017

krzysztof.galazka_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.
  • Rebased on top of D12496
  • Prevent attach to complete if legacy interrupts are configured

on devices which do not support this mode.

Oct 6 2017, 1:43 PM

Aug 14 2017

krzysztof.galazka_intel.com added a member for Intel Networking: piotr.pietruszewski_intel.com.
Aug 14 2017, 9:31 AM

Jul 27 2017

krzysztof.galazka_intel.com updated the diff for D11476: iflib - try m_defrag when m_collapse fails.

Proper fix for segments accounting in iflib_busdma_load_mbuf_sg.

Jul 27 2017, 10:21 AM
krzysztof.galazka_intel.com planned changes to D11476: iflib - try m_defrag when m_collapse fails.
Jul 27 2017, 10:17 AM

Jul 6 2017

krzysztof.galazka_intel.com added a comment to D11476: iflib - try m_defrag when m_collapse fails.

Thanks for your review.

Jul 6 2017, 11:58 AM

Jul 5 2017

krzysztof.galazka_intel.com added a comment to D11476: iflib - try m_defrag when m_collapse fails.

@olivier - Could you tell me what tools do you use? I'd like to check if forwarding performance on other HW is also affected.

Jul 5 2017, 6:19 PM

Jul 4 2017

krzysztof.galazka_intel.com created D11476: iflib - try m_defrag when m_collapse fails.
Jul 4 2017, 2:09 PM

Jun 29 2017

krzysztof.galazka_intel.com abandoned D11404: iflib - use proper max segment size for DMA.

First (failed) attempt to update diff with arc.

Jun 29 2017, 10:15 AM
krzysztof.galazka_intel.com updated the diff for D11403: iflib - use proper max segment size for DMA.

Proper size used for TSO.

Jun 29 2017, 10:05 AM
krzysztof.galazka_intel.com created D11404: iflib - use proper max segment size for DMA.
Jun 29 2017, 10:03 AM
krzysztof.galazka_intel.com added a reviewer for D11403: iflib - use proper max segment size for DMA: Intel Networking.
Jun 29 2017, 10:00 AM
krzysztof.galazka_intel.com created D11403: iflib - use proper max segment size for DMA.
Jun 29 2017, 9:59 AM

Jun 27 2017

krzysztof.galazka_intel.com added a member for Intel Networking: bartosz.sobczak_intel.com.
Jun 27 2017, 11:42 AM

Mar 22 2017

krzysztof.galazka_intel.com requested changes to D5213: convert ixgbe to iflib.

The function ixgbe_intr used in if_txrx struct filled in ix_txrx.c is defined in if_ix.c but ix_txrx.c is used in both ix and ixv drivers so ixv build as KLD cannot be loaded.

Mar 22 2017, 2:31 PM

Feb 2 2017

krzysztof.galazka_intel.com requested changes to D5213: convert ixgbe to iflib.

The ixv fails to build because there is no ifdi_if.h in SRCS. Could you update the Makefile?

Feb 2 2017, 8:04 AM