Differential D20826

ixgbe(4): Fix enabling/disabling and reconfiguration of queues
ClosedPublic
Actions

Authored by kgalazka on Jul 1 2019, 5:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 29, 10:10 AM

	Unknown Object (File)
	Sun, Mar 29, 12:09 AM

	Unknown Object (File)
	Tue, Mar 24, 2:23 AM

	Unknown Object (File)
	Fri, Mar 20, 9:17 PM

	Unknown Object (File)
	Thu, Mar 19, 2:50 PM

	Unknown Object (File)
	Thu, Mar 19, 12:56 AM

	Unknown Object (File)
	Wed, Mar 18, 9:41 PM

	Unknown Object (File)
	Sat, Mar 14, 4:32 AM

Subscribers

lukasz.szczepaniak_intel.com

Details

Reviewers

shurd
lukasz.szczepaniak_intel.com
erj

Group Reviewers

Intel Networking

Commits

rGcfb3a1dee11c: ixgbe(4): Fix enabling/disabling and reconfiguration of queues
rS350253: ixgbe(4): Fix enabling/disabling and reconfiguration of queues

Summary

Wrong order of casting and bit shift caused that enabling and disabling queues didn't work properly for queues number larger than 32. Use literals with right suffix instead.
TX ring tail address was not updated during reinitiailzation of TX structures. It could block sending traffic.
Also remove unused variables 'eims' and 'active_queues'.

Test Plan

Respectfully requesting our Validation Team to perform a test pass before committing.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kgalazka created this revision.Jul 1 2019, 5:21 PM

Herald added subscribers: ae, imp. · View Herald TranscriptJul 1 2019, 5:21 PM

Harbormaster completed remote builds in B25160: Diff 59272.Jul 1 2019, 5:21 PM

Tests were successfully passed for D20826 patch.

This revision is now accepted and ready to land.Jul 10 2019, 2:10 PM

erj accepted this revision.Jul 23 2019, 6:13 PM

Closed by commit rS350253: ixgbe(4): Fix enabling/disabling and reconfiguration of queues (authored by erj). · Explain WhyJul 23 2019, 6:14 PM

This revision was automatically updated to reflect the committed changes.

erj added a commit: rS350253: ixgbe(4): Fix enabling/disabling and reconfiguration of queues.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGcfb3a1dee11c: ixgbe(4): Fix enabling/disabling and reconfiguration of queues.Oct 3 2021, 5:04 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ixgbe/

10 lines

3 lines

2 lines

Diff 60057

head/sys/dev/ixgbe/if_ix.c

Loading...

head/sys/dev/ixgbe/if_ixv.c

Loading...

head/sys/dev/ixgbe/ixgbe.h

Loading...