Page MenuHomeFreeBSD
Differential D20826

ixgbe(4): Fix enabling/disabling and reconfiguration of queues
ClosedPublic
Actions

Authored by kgalazka on Jul 1 2019, 5:21 PM.
Tags
None
Referenced Files
F166467463: D20826.id59272.diff
Thu, Aug 13, 6:08 PM
Unknown Object (File)
Wed, Aug 12, 10:49 AM
Unknown Object (File)
Sat, Aug 8, 5:46 PM
Unknown Object (File)
Sun, Aug 2, 5:10 AM
Unknown Object (File)
Sun, Aug 2, 2:07 AM
Unknown Object (File)
Sat, Aug 1, 7:49 AM
Unknown Object (File)
Sat, Jul 18, 5:42 PM
Unknown Object (File)
Thu, Jul 16, 9:36 PM
View All Files
Subscribers
ae
imp
lukasz.szczepaniak_intel.com

Details

Reviewers
shurd
lukasz.szczepaniak_intel.com
erj
Group Reviewers
Intel Networking
Commits
rGcfb3a1dee11c: ixgbe(4): Fix enabling/disabling and reconfiguration of queues
rS350253: ixgbe(4): Fix enabling/disabling and reconfiguration of queues
Summary
  • Wrong order of casting and bit shift caused that enabling and disabling queues didn't work properly for queues number larger than 32. Use literals with right suffix instead.
  • TX ring tail address was not updated during reinitiailzation of TX structures. It could block sending traffic.
  • Also remove unused variables 'eims' and 'active_queues'.
Test Plan

Respectfully requesting our Validation Team to perform a test pass before committing.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
ixgbe/
10 lines
3 lines
2 lines

Diff 60057

View Options

head/sys/dev/ixgbe/if_ix.c

Loading...
View Options

head/sys/dev/ixgbe/if_ixv.c

Loading...
View Options

head/sys/dev/ixgbe/ixgbe.h

Loading...