Page MenuHomeFreeBSD
Differential D20826

ixgbe(4): Fix enabling/disabling and reconfiguration of queues
ClosedPublic
Actions

Authored by kgalazka on Jul 1 2019, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 19, 2:14 AM
Unknown Object (File)
Sun, Aug 17, 8:25 PM
Unknown Object (File)
Fri, Aug 8, 2:06 PM
Unknown Object (File)
Thu, Aug 7, 7:55 AM
Unknown Object (File)
Tue, Jul 29, 7:29 AM
Unknown Object (File)
Tue, Jul 22, 12:51 PM
Unknown Object (File)
Tue, Jul 22, 9:49 AM
Unknown Object (File)
Jul 21 2025, 7:27 PM
View All 83 Files
Subscribers
ae
imp
lukasz.szczepaniak_intel.com

Details

Reviewers
shurd
lukasz.szczepaniak_intel.com
erj
Group Reviewers
Intel Networking
Commits
rGcfb3a1dee11c: ixgbe(4): Fix enabling/disabling and reconfiguration of queues
rS350253: ixgbe(4): Fix enabling/disabling and reconfiguration of queues
Summary
  • Wrong order of casting and bit shift caused that enabling and disabling queues didn't work properly for queues number larger than 32. Use literals with right suffix instead.
  • TX ring tail address was not updated during reinitiailzation of TX structures. It could block sending traffic.
  • Also remove unused variables 'eims' and 'active_queues'.
Test Plan

Respectfully requesting our Validation Team to perform a test pass before committing.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25160
Build 23854: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
dev/
ixgbe/
10 lines
3 lines
2 lines

Diff 59272

View Options

sys/dev/ixgbe/if_ix.c

Loading...
View Options

sys/dev/ixgbe/if_ixv.c

Loading...
View Options

sys/dev/ixgbe/ixgbe.h

Loading...