Intel NetworkingUmbrella
ActivePublic

Details

Description

This is a reviewers group for the Intel Ethernet drivers. Do not add users willy-nilly.

Recent Activity

Today

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue command completion
  • ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config message
Wed, Aug 22, 12:48 AM · Intel Networking

Yesterday

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Fix RX MDD event display
  • ixl/ixlv(4): Add more MPASS statements to TX path
Tue, Aug 21, 12:42 AM · Intel Networking

Fri, Aug 17

gallatin added inline comments to D16429: ixlv(4): Update to use iflib.
Fri, Aug 17, 7:35 PM · Intel Networking

Thu, Aug 16

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Enhance Malicious Driver Detection messages with VF information
  • ixl(4): Print out additional event information when a LAN Overflow Event occurs
  • ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path
Thu, Aug 16, 11:45 PM · Intel Networking

Tue, Aug 14

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV
  • ixlv(4): Fix a memory leak when interrupt setup fails
  • ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT
  • ixlv(4): Remove comments and commented out code
  • ixlv(4): Remove list of media types displayed in "ifconfig -m"
Tue, Aug 14, 12:03 AM · Intel Networking
erj updated the diff for D16428: iflib: Changes for ixlv(4) update.
  • iflib: Free remaining interrupt resources on failure in iflib_device_register()
  • iflib: Free RX queue TCP LRO memory on unload
Tue, Aug 14, 12:02 AM · Intel Networking

Fri, Aug 10

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic
Fri, Aug 10, 5:37 PM · Intel Networking
jeffrey.e.pieper_intel.com requested changes to D16429: ixlv(4): Update to use iflib.

Several outstanding issues:

Fri, Aug 10, 4:20 PM · Intel Networking
gallatin accepted D16429: ixlv(4): Update to use iflib.
Fri, Aug 10, 3:41 PM · Intel Networking

Thu, Aug 9

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Fix compile error when PCI_IOV isn't defined
Thu, Aug 9, 10:24 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.

Changes from D16428:

  • iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
  • iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()

New changes for D16429:

  • ixl(4): Add tunable to enable VF loopback; enable by default
  • ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing
Thu, Aug 9, 6:41 PM · Intel Networking
erj updated the diff for D16428: iflib: Changes for ixlv(4) update.
  • iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
  • iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()
Thu, Aug 9, 6:39 PM · Intel Networking

Fri, Aug 3

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to configure it
Fri, Aug 3, 6:33 PM · Intel Networking

Thu, Aug 2

erj added a comment to D16429: ixlv(4): Update to use iflib.

@gallatin, I address your specific comments, but I would need to look through ixlvc.c some more to find more code that can be shared. There is almost certainly some in there that can be shared between the PF/VF drivers.

Thu, Aug 2, 8:48 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one function.
  • Remove a space
Thu, Aug 2, 8:47 PM · Intel Networking
erj planned changes to D16428: iflib: Changes for ixlv(4) update.

I need to add the state lock to iflib_request_reset

Thu, Aug 2, 5:08 PM · Intel Networking

Mon, Jul 30

gallatin added a comment to D16429: ixlv(4): Update to use iflib.

In general, I looked around at ixlv.c, and it looks like there are many functions for the main pf which are identical, or nearly identical for the VF. Can we please work on collapsing them down to common code?

Mon, Jul 30, 4:32 PM · Intel Networking

Fri, Jul 27

kozlov.sergey.404_gmail.com added a member for Intel Networking: lukasz.szczepaniak_intel.com.
Fri, Jul 27, 8:22 AM

Thu, Jul 26

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixl(4): Fix module Makefile when PCI_IOV is enabled
Thu, Jul 26, 9:08 PM · Intel Networking

Wed, Jul 25

erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Use same TX DMA seg sizes as the ones in ixl(4)
  • ixl/ixlv(4): Preserve code removal done in r336313
Wed, Jul 25, 7:59 PM · Intel Networking
sbruno accepted D16428: iflib: Changes for ixlv(4) update.
Wed, Jul 25, 6:16 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Remove old/dead code
Wed, Jul 25, 6:02 PM · Intel Networking
erj added a reviewer for D16429: ixlv(4): Update to use iflib: gallatin.
Wed, Jul 25, 4:25 PM · Intel Networking
erj added a reviewer for D16428: iflib: Changes for ixlv(4) update: mmacy.
Wed, Jul 25, 4:25 PM · Intel Networking
erj updated the diff for D16429: ixlv(4): Update to use iflib.
  • ixlv(4): Re-add driver to GENERIC and build files
  • ixl/ixlv(4): Fix module Makefiles
Wed, Jul 25, 4:22 PM · Intel Networking

Tue, Jul 24

erj updated the summary of D16429: ixlv(4): Update to use iflib.
Tue, Jul 24, 6:38 PM · Intel Networking
erj created D16429: ixlv(4): Update to use iflib.
Tue, Jul 24, 6:37 PM · Intel Networking
erj created D16428: iflib: Changes for ixlv(4) update.
Tue, Jul 24, 6:34 PM · Intel Networking

Jun 18 2018

manu removed a watcher for Intel Networking: manu.
Jun 18 2018, 2:59 PM

Jun 14 2018

scott_freebsdfoundation.org removed a watcher for Intel Networking: scott_freebsdfoundation.org.
Jun 14 2018, 3:38 PM

Jun 7 2018

erj closed D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Jun 7 2018, 1:09 PM · Intel Networking

Jun 4 2018

gallatin accepted D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Sure.. Those checks for TCP in the TSO case should probably turn into asserts eventually..

Jun 4 2018, 8:13 PM · Intel Networking
erj added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

@gallatin I'm assuming you no longer have any objections to this patch?

Jun 4 2018, 5:55 PM · Intel Networking
prakashs0234_gmail.com added a watcher for Intel Networking: prakashs0234_gmail.com.
Jun 4 2018, 5:45 AM

May 29 2018

shurd accepted D15558: iflib: Record TCP checksum info in iflib for ixl(4).

lgtm

May 29 2018, 4:42 PM · Intel Networking

May 26 2018

erj added a child revision for D15558: iflib: Record TCP checksum info in iflib for ixl(4): D15577: Update ixl(4) to use iflib..
May 26 2018, 1:20 AM · Intel Networking

May 25 2018

erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Move stats increment in IPv6 case to match IPv4 case
May 25 2018, 11:18 PM · Intel Networking
erj added inline comments to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 25 2018, 11:17 PM · Intel Networking
erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Remove comment and restore/fix setting CSUM_IP6_TCP flag during TSO6
May 25 2018, 10:52 PM · Intel Networking
gallatin requested changes to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 25 2018, 8:27 PM · Intel Networking
gallatin added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Was this the patch that we discussed on our call? Does this fix your TX checksum problems on IXL?

Yes and Yes.

Unfortunately, I've now proceeded to the "entire box hangs" portion of the game. Even serial console break-to-debugger is ignored. I'm going to try NMIs next..

May 25 2018, 8:18 PM · Intel Networking
erj added inline comments to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 25 2018, 7:52 PM · Intel Networking
shurd added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Looks good, but not forcing CSUM_TCP_IPV6 for TSO6 may need a closer look.

May 25 2018, 7:34 PM · Intel Networking

May 24 2018

erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Fixup changes made to record TCP checksum info in iflib for ixl
May 24 2018, 9:27 PM · Intel Networking
jeffrey.e.pieper_intel.com added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Was this the patch that we discussed on our call? Does this fix your TX checksum problems on IXL?

Yes and Yes.

Unfortunately, I've now proceeded to the "entire box hangs" portion of the game. Even serial console break-to-debugger is ignored. I'm going to try NMIs next..

May 24 2018, 7:17 PM · Intel Networking
shurd added inline comments to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 24 2018, 7:13 PM · Intel Networking
erj updated the summary of D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 24 2018, 6:30 PM · Intel Networking
gallatin added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Was this the patch that we discussed on our call? Does this fix your TX checksum problems on IXL?

May 24 2018, 6:20 PM · Intel Networking
erj added 1 blocking reviewer(s) for D15558: iflib: Record TCP checksum info in iflib for ixl(4): shurd.
May 24 2018, 6:20 PM · Intel Networking
sbruno added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

Was this the patch that we discussed on our call? Does this fix your TX checksum problems on IXL?

May 24 2018, 6:17 PM · Intel Networking