Page MenuHomeFreeBSD

kbowling (Kevin Bowling)
User

Projects

User Details

User Since
Jun 6 2015, 10:46 PM (476 w, 1 d)

Recent Activity

May 25 2024

kbowling updated the diff for D45359: databases/postgis31: enforce pgsql limit.
May 25 2024, 6:22 AM
kbowling requested review of D45359: databases/postgis31: enforce pgsql limit.
May 25 2024, 5:48 AM

Sep 21 2023

kbowling accepted D41926: 14.0 relnotes: first cut.
Sep 21 2023, 6:40 PM
kbowling added inline comments to D41926: 14.0 relnotes: first cut.
Sep 21 2023, 6:25 PM
kbowling added inline comments to D41926: 14.0 relnotes: first cut.
Sep 21 2023, 6:16 PM
kbowling added inline comments to D41926: 14.0 relnotes: first cut.
Sep 21 2023, 5:11 PM
kbowling added inline comments to D41926: 14.0 relnotes: first cut.
Sep 21 2023, 7:41 AM

Aug 24 2023

kbowling added a comment to D41558: iflib: invert default restart on VLAN changes.

setting the ifdi_needs_restart default to false will alleviate the need to churn every driver if an odd event is added in the future for specific hardware.

Returning true by default seems like the safe default to me. Yes, unneeded reinits are annoying, but if we don't reinit when an event actually requires it, the result could be harder to debug.

Aug 24 2023, 3:19 PM
kbowling updated the diff for D41558: iflib: invert default restart on VLAN changes.

Don't toggle vmxnet3

Aug 24 2023, 3:16 PM
kbowling updated the summary of D41558: iflib: invert default restart on VLAN changes.
Aug 24 2023, 6:23 AM
kbowling updated the summary of D41558: iflib: invert default restart on VLAN changes.
Aug 24 2023, 6:20 AM
kbowling updated the summary of D41558: iflib: invert default restart on VLAN changes.
Aug 24 2023, 6:13 AM
kbowling updated the diff for D41558: iflib: invert default restart on VLAN changes.

Sweep the drivers

Aug 24 2023, 6:12 AM

Aug 23 2023

kbowling updated subscribers of D41558: iflib: invert default restart on VLAN changes.
Aug 23 2023, 12:58 AM

Aug 22 2023

kbowling requested review of D41558: iflib: invert default restart on VLAN changes.
Aug 22 2023, 11:59 PM

Aug 18 2023

kbowling accepted D41506: libcrypto: add rsa_depr.c to the build.

Makes sense to me to get these in and continue the audit/additions

Aug 18 2023, 7:52 PM
kbowling accepted D41505: libcrypto: add err_all_legacy.c to the build.

@bofh do you know if this was something you had to mark BROKEN or work around?

Aug 18 2023, 6:40 PM
kbowling accepted D41499: sys: Remove SND_DECLARE_FILE.
Aug 18 2023, 6:50 AM
kbowling accepted D41498: pcm: Turn SND_DECLARE_FILE into a no-op..
Aug 18 2023, 6:49 AM

Aug 16 2023

kbowling abandoned D41484: snd: simplify SND_DECLARE_FILE.
Aug 16 2023, 9:14 PM
kbowling added inline comments to D41484: snd: simplify SND_DECLARE_FILE.
Aug 16 2023, 9:11 PM
kbowling accepted D40168: x11/nvidia-driver: Add Makefile.version and patch for nvidia-drm.
Aug 16 2023, 7:23 PM
kbowling requested review of D41484: snd: simplify SND_DECLARE_FILE.
Aug 16 2023, 6:52 PM
kbowling requested changes to D41480: sys/net: only panic on unset tx_csum_flags if cap is disabled.

What is triggering this for you?

Aug 16 2023, 5:49 PM
kbowling added a comment to D40168: x11/nvidia-driver: Add Makefile.version and patch for nvidia-drm.

I see the optional assignment so I guess that part is fine. Ultimately it's not my port but if danfe is not going to comment I have no objections.

Aug 16 2023, 6:40 AM
kbowling added a comment to D40168: x11/nvidia-driver: Add Makefile.version and patch for nvidia-drm.

It is not necessary to do it like this. There is an implied version contract with this port and x11/linux-nvidia-libs as well. If it is centralized, it needs to accommodate the entire nvidia-driver situation because this will cause build failures.

Aug 16 2023, 6:36 AM
kbowling added a comment to D40168: x11/nvidia-driver: Add Makefile.version and patch for nvidia-drm.

I think you should remove the distversion thing, that will break the legacy ports and seems unnecessary.

Aug 16 2023, 3:36 AM

Aug 13 2023

kbowling added a comment to D39930: iflib: Add subinterface interrupt allocation function.

@erj can you post the draft driver update, I'd like to see how it intends to use this patch stack before commentary

Aug 13 2023, 4:56 PM

Aug 9 2023

kbowling abandoned D29878: e1000: Widen I218-I219 erratum.

Aside from some research notes there is nothing to do here.

Aug 9 2023, 4:11 AM

Aug 4 2023

kbowling accepted D41325: iflib: Remove redundant variable.
Aug 4 2023, 6:47 PM
kbowling accepted D41324: iflib: Fix white space and reduce some line lengths.
Aug 4 2023, 6:47 PM

Jul 31 2023

kbowling updated the diff for D41170: e1000: fixes for lem(4) and em(4) TSO.

rebase after committed changes

Jul 31 2023, 3:31 PM

Jul 29 2023

kbowling updated the diff for D41170: e1000: fixes for lem(4) and em(4) TSO.

@shurd updated automask to not require the iflib internal change.

Jul 29 2023, 5:25 AM
kbowling abandoned D41200: iflib: Move network stack capabilities after device driver init.

I've found a way to do this without modifying iflib.

Jul 29 2023, 5:23 AM
kbowling updated the diff for D41170: e1000: fixes for lem(4) and em(4) TSO.
Jul 29 2023, 1:21 AM

Jul 28 2023

kbowling updated the diff for D41170: e1000: fixes for lem(4) and em(4) TSO.
Jul 28 2023, 2:16 AM
kbowling added a comment to D41170: e1000: fixes for lem(4) and em(4) TSO.

@shurd I added some smarts to the TSO automask. Also added a sysctl for people that want to opt out of.

Jul 28 2023, 12:48 AM
kbowling updated the diff for D41170: e1000: fixes for lem(4) and em(4) TSO.
Jul 28 2023, 12:46 AM

Jul 27 2023

kbowling added a comment to D41200: iflib: Move network stack capabilities after device driver init.

Wouldn't it also whack TSO on a flap for 1G? It seems like if you want TSO, you'll have to explicitly re-enable it every time a 1G link is established.

Jul 27 2023, 10:15 AM
kbowling added a comment to D41200: iflib: Move network stack capabilities after device driver init.

Ah yes, makes more sense to enable then... not sure how you'll manage to keep the admin preferences though. It looks like if I have TSO enabled and unplug the cable then plug it back in, TSO will become disabled?

Jul 27 2023, 6:57 AM
kbowling added a comment to D41200: iflib: Move network stack capabilities after device driver init.

Oh wow, so TSO works at 100Mbbs, but fails at 1Gbps? Crazy. I would personally be inclined to just disable TSO unconditionally in attach_pre(), but if someone *really* wants TSO for their "Fast" Ethernet connections, you may as well give it to them.

Jul 27 2023, 12:23 AM

Jul 26 2023

kbowling added a comment to D41200: iflib: Move network stack capabilities after device driver init.

Curious why the driver would need to change it in init... can devices actually change their supported offloads after attach? Aside from the initial setup, I would expect control of which offloads to use would be under the control of the user, not the driver... I would be very surprised if taking an interface down then up changed the offload flags.

Jul 26 2023, 8:45 PM
kbowling updated the diff for D41170: e1000: fixes for lem(4) and em(4) TSO.

Don't try TSO on 10/100 for lem(4)/em(4)

Jul 26 2023, 7:36 PM
kbowling requested review of D41200: iflib: Move network stack capabilities after device driver init.
Jul 26 2023, 7:33 PM
kbowling accepted D41196: iflib(9): Remove support for cloning pseudo interfaces.
Jul 26 2023, 2:39 PM

Jul 25 2023

kbowling added inline comments to D41170: e1000: fixes for lem(4) and em(4) TSO.
Jul 25 2023, 3:39 AM
kbowling added inline comments to D41170: e1000: fixes for lem(4) and em(4) TSO.
Jul 25 2023, 3:38 AM
kbowling requested review of D41170: e1000: fixes for lem(4) and em(4) TSO.
Jul 25 2023, 3:35 AM

Jun 27 2023

kbowling planned changes to D30072: e1000: Clean up and bug fix em_txrx.
Jun 27 2023, 9:06 PM
kbowling reopened D30072: e1000: Clean up and bug fix em_txrx.
Jun 27 2023, 9:06 PM

Jun 9 2023

kbowling planned changes to D30072: e1000: Clean up and bug fix em_txrx.
Jun 9 2023, 2:12 AM
kbowling reopened D30072: e1000: Clean up and bug fix em_txrx.
Jun 9 2023, 2:12 AM

May 11 2023

kbowling accepted D40046: e1000: fix VLAN 0.

I think it's probably fine but can you elaborate situations where vlan 0 is "tagged"

May 11 2023, 12:04 AM

May 8 2023

kbowling accepted D39977: em: sync platform detection with Linux.
May 8 2023, 2:36 PM

Apr 29 2023

kbowling updated the diff for D39785: ixgbe: Warn once for unsupported SFPs.

Use a bool

Apr 29 2023, 12:45 AM

Apr 25 2023

kbowling requested review of D39785: ixgbe: Warn once for unsupported SFPs.
Apr 25 2023, 12:41 AM

Feb 9 2023

kbowling accepted D38471: ck: update interface for !_KERNEL_ builds.
Feb 9 2023, 11:30 PM

Dec 20 2022

kbowling accepted D37768: Convert iflib(4) and iflib-based drivers to the DrvAPI.
Dec 20 2022, 10:51 PM

Oct 17 2022

kbowling added a comment to D34449: Allow em(4) to particpate in auto-negotiation for fixed 100b or 10b configuration.

The problem is what you submitted is logically inconsistent in the e1000 code. Other consumers of this code (i.e. Linux, DPDK) have not plugged the holes either (for the record they do not implement this improvement). I've provided a starting pointer in the phy code. You will find at least one more issue in the lem(4) phy code. This is via ripgrep and code inspection, you don't need any hardware to see it.

Oct 17 2022, 3:46 AM

Oct 12 2022

kbowling added a comment to D34449: Allow em(4) to particpate in auto-negotiation for fixed 100b or 10b configuration.

I can see where the "shared code" (e1000 api) is not ready in general and for lem(4). For the submitter, if you want to try and chase that down e1000_setup_copper_link_generic() in e1000_phy.c.. maybe try modifying the conditional. I'm going to revert this.

Oct 12 2022, 12:00 PM

Oct 10 2022

kbowling updated the diff for D31979: igc: Fix up hw vlan ops.
Oct 10 2022, 10:53 PM
kbowling updated the diff for D31869: ixgbe: Check for fw_recovery.
Oct 10 2022, 8:53 PM
kbowling requested review of D36923: igc: remove unnecessary PHY ID checks.
Oct 10 2022, 6:39 AM

Jun 22 2022

kbowling accepted D35542: if_ix: Reset on an ECC error.
Jun 22 2022, 3:12 AM

May 15 2022

kbowling requested review of D35218: igc: PCI IDs.
May 15 2022, 9:43 PM
kbowling requested review of D35217: igc: Increase rx_buffer_size local variable to 32b.
May 15 2022, 5:10 PM

May 10 2022

kbowling requested review of D35167: e1000: Increase rx_buffer_size to 32b.
May 10 2022, 4:24 PM

May 4 2022

kbowling requested review of D35119: Disable VNET tests on CI temporarily.
May 4 2022, 2:43 AM

Apr 19 2022

kbowling accepted D34924: ixl(4): Add support for I710 devices and remove non-inclusive language.
Apr 19 2022, 4:18 PM

Apr 13 2022

kbowling closed D32603: ixgbe: Update mc filter before FCTRL flags.

Committed as 395cc55d8966

Apr 13 2022, 4:19 PM
kbowling closed D32602: e1000: Update mc filter before RCTL flags.

Committed as 07ede751612f

Apr 13 2022, 4:19 PM
kbowling accepted D34449: Allow em(4) to particpate in auto-negotiation for fixed 100b or 10b configuration.

I think hw->phy.autoneg_wait_to_complete is also set to false in the driver earlier in em_if_attach_pre() and never changes.

Apr 13 2022, 4:10 PM

Feb 3 2022

kbowling accepted D34160: tcp: fix typo in commit f026275e26d0071ac3dee98526e8b9bcad58f0fa.
Feb 3 2022, 8:19 PM
kbowling accepted D34148: Explicitly set IP ECN header codepoint properly.
Feb 3 2022, 1:50 AM

Dec 20 2021

kbowling accepted D33156: iflib: fix vlan offload processing across multiple drivers..
Dec 20 2021, 10:34 AM

Dec 18 2021

kbowling added a comment to D33156: iflib: fix vlan offload processing across multiple drivers..

I'm less optimistic about the ifp seeing the change required in all drivers, @gallatin odes anyone have any idea on the impact of the ifp pointer chase and fetch versus grabbing it from the already fetched scctx in these hot paths? How would we sync scctx_capenable with ifnet, that seems to be a critical missing implementation from the outset.

Dec 18 2021, 8:40 PM

Dec 14 2021

kbowling updated subscribers of D31485: iflib: Allow drivers to determine which queue to TX on.
In D31485#754650, @erj wrote:

Though, part of the problem with this patch is that I'm not entirely sure with what I want the parameters of ift_txq_select to be.

Right now it takes the mbuf pointer which is enough for what we want to do with it in an upcoming ice(4) patch, but in the future I'll need to use DSCP/IP ToS information in that function as well. I think I should be able to put that information inside the mbuf along with something like an M_DSCP flag. Though, one version I had before also had the if_pkt_info_t struct as well as having the headers (partially) parsed before this queue selection function was called in order to avoid having to modify mbufs like that.

Dec 14 2021, 8:48 PM

Dec 10 2021

kbowling accepted D31485: iflib: Allow drivers to determine which queue to TX on.
Dec 10 2021, 12:53 AM

Dec 1 2021

kbowling accepted D33155: em: skip rxcsum offload processing when disabled.

LGTM

Dec 1 2021, 5:25 PM
kbowling accepted D33157: e1000: remove unused ifp backpointer.
Dec 1 2021, 5:24 PM

Nov 1 2021

kbowling accepted D32772: igc: Use hardware routine for PHY reset.

LGTM

Nov 1 2021, 11:36 PM

Oct 27 2021

kbowling updated subscribers of D32585: SMR protection for inpcbs.
In D32585#737015, @np wrote:

Note. This change requires PCBGROUP to be retired.

Have you circulated this proposal in the wider -net and -vendor community? I know of one downstream that uses this feature.

Oct 27 2021, 3:46 PM

Oct 22 2021

kbowling retitled D32603: ixgbe: Update mc filter before FCTRL flags from ixgbe: Update mc filter before FCTL flags to ixgbe: Update mc filter before FCTRL flags.
Oct 22 2021, 3:09 PM
kbowling retitled D32603: ixgbe: Update mc filter before FCTRL flags from ixgbe: Update mc filter before RCTL flags to ixgbe: Update mc filter before FCTL flags.
Oct 22 2021, 3:09 PM
kbowling requested review of D32603: ixgbe: Update mc filter before FCTRL flags.
Oct 22 2021, 3:08 PM
kbowling updated the diff for D32602: e1000: Update mc filter before RCTL flags.
Oct 22 2021, 3:08 PM
kbowling updated the diff for D32602: e1000: Update mc filter before RCTL flags.
Oct 22 2021, 3:07 PM
kbowling requested review of D32602: e1000: Update mc filter before RCTL flags.
Oct 22 2021, 3:06 PM

Oct 20 2021

kbowling accepted D32574: Fix setting of RCTL register when modifying multicast filters..
Oct 20 2021, 3:56 PM

Oct 10 2021

kbowling planned changes to D32388: led: Eliminate sleepable mutex.

It was pointed out to me there is still an issue in that we pick up a new sx within the epoch, both in create and timeout with my patch as is For some reason the epoch _preempt variety doesn't produce a diagnostic so I will look into that code.

Oct 10 2021, 3:15 PM

Oct 9 2021

kbowling accepted D32402: databases/hbase: Update MASTER_SITES, deprecate and set expiration date to 2022-03-31.
Oct 9 2021, 8:49 PM
kbowling updated the diff for D32388: led: Eliminate sleepable mutex.

Thanks @markj what do you think of this approach using epoch?

Oct 9 2021, 8:14 PM
kbowling added a comment to D32388: led: Eliminate sleepable mutex.

Thank you!

Side note:

Also see: D31215

Oct 9 2021, 5:36 AM
kbowling added a comment to D32389: iflib: Create led(4) devices.

Jose submitted a variant where the driver (e1000 in this case) calls the iflib_led_create() function in its post attach. I am open to either approach if anyone has any thoughts one way or the other.

Oct 9 2021, 5:30 AM
kbowling requested review of D32389: iflib: Create led(4) devices.
Oct 9 2021, 3:15 AM
kbowling requested review of D32388: led: Eliminate sleepable mutex.
Oct 9 2021, 3:11 AM

Oct 7 2021

kbowling added a comment to D31621: ixgbe: Update shared code.

Ping. Awaiting approval

Oct 7 2021, 1:32 AM

Oct 6 2021

kbowling added inline comments to D31869: ixgbe: Check for fw_recovery.
Oct 6 2021, 11:43 PM
kbowling added a reviewer for D31869: ixgbe: Check for fw_recovery: gallatin.
Oct 6 2021, 11:42 PM
kbowling updated the test plan for D32333: e1000: print EEPROM/NVM/OROM versions.
Oct 6 2021, 8:43 PM