User Details
- User Since
- Jun 6 2015, 10:46 PM (407 w, 5 d)
Feb 9 2023
Dec 20 2022
Oct 17 2022
The problem is what you submitted is logically inconsistent in the e1000 code. Other consumers of this code (i.e. Linux, DPDK) have not plugged the holes either (for the record they do not implement this improvement). I've provided a starting pointer in the phy code. You will find at least one more issue in the lem(4) phy code. This is via ripgrep and code inspection, you don't need any hardware to see it.
Oct 12 2022
I can see where the "shared code" (e1000 api) is not ready in general and for lem(4). For the submitter, if you want to try and chase that down e1000_setup_copper_link_generic() in e1000_phy.c.. maybe try modifying the conditional. I'm going to revert this.
Oct 10 2022
Jun 22 2022
May 15 2022
May 10 2022
May 4 2022
Apr 19 2022
Apr 13 2022
Committed as 395cc55d8966
Committed as 07ede751612f
I think hw->phy.autoneg_wait_to_complete is also set to false in the driver earlier in em_if_attach_pre() and never changes.
Feb 3 2022
Dec 20 2021
Dec 18 2021
I'm less optimistic about the ifp seeing the change required in all drivers, @gallatin odes anyone have any idea on the impact of the ifp pointer chase and fetch versus grabbing it from the already fetched scctx in these hot paths? How would we sync scctx_capenable with ifnet, that seems to be a critical missing implementation from the outset.
Dec 14 2021
Dec 10 2021
Dec 1 2021
Nov 1 2021
Oct 27 2021
Oct 22 2021
Oct 20 2021
Oct 10 2021
It was pointed out to me there is still an issue in that we pick up a new sx within the epoch, both in create and timeout with my patch as is For some reason the epoch _preempt variety doesn't produce a diagnostic so I will look into that code.
Oct 9 2021
Thanks @markj what do you think of this approach using epoch?
Jose submitted a variant where the driver (e1000 in this case) calls the iflib_led_create() function in its post attach. I am open to either approach if anyone has any thoughts one way or the other.
Oct 7 2021
Ping. Awaiting approval
Oct 6 2021
@gallatin can you have another look? The locking model on the e1000 is tricky due to the HW so I stashed the info on attach. There's a separate KASSERT fix for em_print_nvm_info for review as well.
Oct 5 2021
Oct 1 2021
will look at this once remote access is available
Sep 30 2021
Sep 29 2021
Sep 28 2021
Sep 27 2021
Sep 25 2021
ts=8
I would like to commit this on the 27th if there is no feedback.
Need to fix ixv
Sep 24 2021
I'd like to commit this on the 27th (2 week feedback window) if there is no other discussion.
This may be a timing issue planning to check a few more things
Sep 23 2021
Concept ACK. I don't have anything to test it on at the moment.
Sep 17 2021
Sep 16 2021
Sep 14 2021
Sep 7 2021
Update with remaining catch-up diff