Page MenuHomeFreeBSD

kbowling (Kevin Bowling)
User

Projects

User Details

User Since
Jun 6 2015, 10:46 PM (320 w, 11 h)

Recent Activity

Wed, Jul 21

kbowling added a comment to D31244: arm: Bump KSTACK_PAGES default to match i386/amd64.

Are there any ABI or KBI concerns for stable/13?

Wed, Jul 21, 1:40 AM
kbowling updated subscribers of D31244: arm: Bump KSTACK_PAGES default to match i386/amd64.
In D31244#703721, @imp wrote:

ZFS is useful on these small memory beasts?

Wed, Jul 21, 12:55 AM
kbowling added a reviewer for D31244: arm: Bump KSTACK_PAGES default to match i386/amd64: cognet.
Wed, Jul 21, 12:33 AM

Tue, Jul 20

kbowling requested review of D31244: arm: Bump KSTACK_PAGES default to match i386/amd64.
Tue, Jul 20, 6:46 PM
kbowling updated the diff for D31227: igc: sync igc_txrx with igb.
Tue, Jul 20, 7:29 AM
kbowling requested review of D31227: igc: sync igc_txrx with igb.
Tue, Jul 20, 6:52 AM
kbowling added a comment to D30989: Use tuneable to create unique IRQ for TxQ in IXGBE.

How is this performing versus the combined IRQ in your testing? I can do some basic smoke tests and suspect we'd want to couple it with the TX AIM patch.

Tue, Jul 20, 6:13 AM

Sun, Jul 18

kbowling accepted D31138: pf: syncookie support.
Sun, Jul 18, 6:39 AM

Fri, Jul 16

kbowling created P513 pdns fixes.
Fri, Jul 16, 7:41 AM

Thu, Jul 15

kbowling accepted D31003: graphics/libdrm: Update to 2.4.107.
Thu, Jul 15, 4:50 PM
kbowling accepted D31165: mesa*: Update to 21.1.4.
Thu, Jul 15, 4:50 PM

Wed, Jul 14

kbowling abandoned D31172: iflib: Stop interface for media change.
Wed, Jul 14, 2:10 AM
kbowling added a comment to D31172: iflib: Stop interface for media change.

iflib_stop() is pretty heavy-weight -- is this needed for all devices? Maybe add a flag to do this only on devices where its needed, or have the device do the disabling itself?

I'm not super familiar with this area, is there something that would cause media changes to be "common" like EEE or something? I'm trying to imagine a situation where it wouldn't be as drastic as a link flap already which would justify spending more time thinking about this.

I'm not sure what EEE is.

My point was that there are NICs where the whole thing does not need to be shut down and re-started to change media types, and the iflib_stop() is pretty heavy (2 DELAY(1000), interrupt disable, callout disable, etc.

Now that I'm thinking about this, it came up before with vlans. See IFLIB_RESTART_VLAN_CONFIG. I think we should add an IFLIB_RESTART_MEDIA_CONFIG and wrap the restart in iflib_media_change() in IFDI_NEEDS_RESTART(ctx, IFLIB_RESTART_MEDIA_CONFIG) like in iflib_vlan_register()

Wed, Jul 14, 2:08 AM
kbowling abandoned D31157: zfs: Enable HAVE_LARGE_STACKS.

This will be handled completely by vendor imports

Wed, Jul 14, 1:37 AM
kbowling added a comment to D31172: iflib: Stop interface for media change.

iflib_stop() is pretty heavy-weight -- is this needed for all devices? Maybe add a flag to do this only on devices where its needed, or have the device do the disabling itself?

Wed, Jul 14, 1:35 AM
kbowling planned changes to D31157: zfs: Enable HAVE_LARGE_STACKS.

@mav @mm if the upstream PR is merged this won't be necessary. The only question I have is how to MFC the change to stable/13? Do I need to have it merged back upstream first?

Wed, Jul 14, 12:32 AM
kbowling requested review of D31172: iflib: Stop interface for media change.
Wed, Jul 14, 12:22 AM

Tue, Jul 13

kbowling added a comment to D30930: Mk/bsd.default-versions: Remove libglvnd optionality.

I've been sick and didn't make the x11 call, can this go in as planned?

Tue, Jul 13, 2:08 AM

Mon, Jul 12

kbowling updated the diff for D31157: zfs: Enable HAVE_LARGE_STACKS.
Mon, Jul 12, 9:51 PM
kbowling updated the summary of D31157: zfs: Enable HAVE_LARGE_STACKS.
Mon, Jul 12, 9:49 PM
kbowling added a reviewer for D31157: zfs: Enable HAVE_LARGE_STACKS: allanjude.
Mon, Jul 12, 9:48 PM
kbowling updated the summary of D31157: zfs: Enable HAVE_LARGE_STACKS.
Mon, Jul 12, 9:48 PM
kbowling requested review of D31157: zfs: Enable HAVE_LARGE_STACKS.
Mon, Jul 12, 9:45 PM

Sat, Jul 10

kbowling accepted D30668: Intel I225 Driver.
Sat, Jul 10, 4:04 AM

Fri, Jul 2

kbowling added inline comments to D30969: comitters-guide: clarify submitted and approved post git.
Fri, Jul 2, 9:00 PM

Thu, Jul 1

kbowling accepted D30959: mbuf: add m_free_raw to be used instead of directly calling uma_zfree.

LGTM (with iflib hat on)

Thu, Jul 1, 11:44 PM
kbowling added inline comments to D30969: comitters-guide: clarify submitted and approved post git.
Thu, Jul 1, 6:24 PM

Wed, Jun 30

kbowling updated the diff for D30969: comitters-guide: clarify submitted and approved post git.
Wed, Jun 30, 10:06 PM
kbowling requested review of D30969: comitters-guide: clarify submitted and approved post git.
Wed, Jun 30, 9:52 PM
kbowling accepted D30961: iflib: switch bare zone_mbuf use to m_free_raw.

The intent of this change looks fine to me after D30959 progresses.

Wed, Jun 30, 4:32 PM
kbowling requested changes to D30961: iflib: switch bare zone_mbuf use to m_free_raw.
Wed, Jun 30, 4:16 PM
kbowling accepted D30958: iflib: retire MB_DTOR_SKIP.
Wed, Jun 30, 4:10 PM
kbowling added a comment to D30930: Mk/bsd.default-versions: Remove libglvnd optionality.

There is a lack of transparency here.

Wed, Jun 30, 6:47 AM

Tue, Jun 29

kbowling added a comment to D30930: Mk/bsd.default-versions: Remove libglvnd optionality.

While monitoring the FreeBSD-x11@, FreeBSD-desktop@, FreeBSD-multimedia@ and the FreeBSDDesktop gitter, I didn't see anything like "let's remove the ability to build without libglvnd".
Seems like this was discussed somewhere else, mind providing links to these discussions?

Tue, Jun 29, 7:14 PM
kbowling accepted D30869: graphics/libGLU: Update to 9.0.2.

Commenting that zeising approved with the changes mentioned above on x11 call

Tue, Jun 29, 1:26 AM

Mon, Jun 28

kbowling added a comment to D30930: Mk/bsd.default-versions: Remove libglvnd optionality.

Per discussion with x11@ libglvnd will be the only GL provider supported by ports.

Context missing; is there a log of the discussion?

Mon, Jun 28, 11:13 PM
kbowling updated the diff for D30930: Mk/bsd.default-versions: Remove libglvnd optionality.
Mon, Jun 28, 8:38 PM
kbowling updated the diff for D30930: Mk/bsd.default-versions: Remove libglvnd optionality.
Mon, Jun 28, 8:13 PM
kbowling added inline comments to D30930: Mk/bsd.default-versions: Remove libglvnd optionality.
Mon, Jun 28, 7:18 PM
kbowling added a comment to D30930: Mk/bsd.default-versions: Remove libglvnd optionality.

I realize this all might be awkward for ancient nvidia-drivers (<=390, and it is awkward now with mesa-libs as the deps too), although we still do the hard link dance on them and should keep the weight of that complexity in those ports since they don't play nicely with multi-vendor setups. The ancient multi-vendor case should be handled by the nvidia-secondary-driver port for multi-vendor or the nvidia-driver-{304, 340, 390} hardlink icky for single vendor.

Mon, Jun 28, 6:46 PM
kbowling requested review of D30930: Mk/bsd.default-versions: Remove libglvnd optionality.
Mon, Jun 28, 6:35 PM
kbowling added a reviewer for D30929: Document libglvnd changes to USE_GL: imp.
Mon, Jun 28, 6:23 PM
kbowling requested review of D30929: Document libglvnd changes to USE_GL.
Mon, Jun 28, 5:57 PM
kbowling updated the diff for D30869: graphics/libGLU: Update to 9.0.2.
Mon, Jun 28, 5:45 PM
kbowling updated the diff for D30869: graphics/libGLU: Update to 9.0.2.
Mon, Jun 28, 5:41 PM
kbowling requested review of D30869: graphics/libGLU: Update to 9.0.2.

Is there some variant of this that can be checked in like dropping Mk/Uses/gl.mk changes or can someone else do it to their liking?

Mon, Jun 28, 6:46 AM

Fri, Jun 25

kbowling added inline comments to D30869: graphics/libGLU: Update to 9.0.2.
Fri, Jun 25, 5:26 PM

Jun 24 2021

kbowling retitled D30869: graphics/libGLU: Update to 9.0.2 from graphics/libGLU: Update to 9.0/2 to graphics/libGLU: Update to 9.0.2.
Jun 24 2021, 10:44 PM
kbowling updated the diff for D30869: graphics/libGLU: Update to 9.0.2.
Jun 24 2021, 10:40 PM
kbowling updated the diff for D30869: graphics/libGLU: Update to 9.0.2.
Jun 24 2021, 10:35 PM
kbowling accepted D30851: sysutils/openzfs*: Bump to fix build failures on HEAD.
Jun 24 2021, 2:03 AM

Jun 23 2021

kbowling added a comment to D30869: graphics/libGLU: Update to 9.0.2.

Upstream MR https://gitlab.freedesktop.org/mesa/glu/-/merge_requests/5

Jun 23 2021, 7:04 AM
kbowling planned changes to D30869: graphics/libGLU: Update to 9.0.2.

Matt's suggestion is what @jbeich suggested in PR241568, I'll get a patch to freedesktop and amend this PR if it passes his review:

Jun 23 2021, 3:22 AM

Jun 22 2021

kbowling updated the diff for D30869: graphics/libGLU: Update to 9.0.2.

Add a dep on egl so we get needed mesa headers.

Jun 22 2021, 9:50 PM
kbowling added a comment to D30869: graphics/libGLU: Update to 9.0.2.

Sent a mail to Matt Turner (gentoo/nvidia/mesa) to get some clarification.

Jun 22 2021, 9:32 PM
kbowling added a comment to D30869: graphics/libGLU: Update to 9.0.2.

Did you test runtime on Wayland[1] or plain KMS[2]? osmesa seems to be for headless.

[1] Consumers that use GLU + GLEW may need glew-wayland (see its pkg-message)
[2] Similar to kmscube but something with GLU

Jun 22 2021, 8:46 PM
kbowling updated the diff for D30869: graphics/libGLU: Update to 9.0.2.
Jun 22 2021, 8:38 PM
kbowling requested review of D30869: graphics/libGLU: Update to 9.0.2.
Jun 22 2021, 8:19 PM
kbowling closed D30824: graphics/mesa-libs: Bump reverse deps for default libglvnd.

https://cgit.freebsd.org/ports/commit/?id=da3162c7c9f01912ba1940e188b253f2b5c7ba77

Jun 22 2021, 7:39 PM

Jun 19 2021

kbowling requested review of D30824: graphics/mesa-libs: Bump reverse deps for default libglvnd.
Jun 19 2021, 7:51 PM

Jun 18 2021

kbowling added a reviewer for D30817: graphics/libglvnd: Update to 1.3.3: greg_unrelenting.technology.
Jun 18 2021, 11:37 PM
kbowling requested review of D30817: graphics/libglvnd: Update to 1.3.3.
Jun 18 2021, 11:36 PM

Jun 17 2021

kbowling accepted D30668: Intel I225 Driver.
Jun 17 2021, 12:33 AM

Jun 16 2021

kbowling added a comment to D25020: graphics/mesa-libs: enable libglvnd support.

@jbeich this should have gone in first, I was just doing the needful because portmgr had blessed the secondary driver work and it was still sitting unhandled. I am in progress on my own QA on the combination of this on top of that at the moment.

Jun 16 2021, 8:14 PM
kbowling accepted D25020: graphics/mesa-libs: enable libglvnd support.

Yeah I agree with @jbeich this is a straight forward patch in the grand scheme of this software stack, so I'll merge it with maintainer timeout to fortify the secondary driver work mentioned above.

Jun 16 2021, 3:36 PM

Jun 15 2021

kbowling added inline comments to D30002: e1000: Fix up HW vlan ops.
Jun 15 2021, 5:17 AM

Jun 1 2021

kbowling added a comment to D29788: kern: ether_gen_addr: randomize on default hostuuid, too.

LGTM still will you push it?

Jun 1 2021, 8:48 PM

May 31 2021

kbowling planned changes to D30072: e1000: Clean up and bug fix em_txrx.
May 31 2021, 4:29 PM
kbowling resigned from D30463: iflib:correct vlan register/unregister.

Yes I apologize for my own misunderstanding, I saw this patch in BZ and was confused previously and didn't see it helping the related e1000 issues. Upon seeing it here again, it seemed like the if statement WRT ctx and arg would be incorrect if receiving an event from the vlan handler, but I see that we control the argument with our EVENTHANDLER_REGISTER here so it is consistent. @kaho_elam.kais.kyoto-u.ac.jp I believe the problems you are pursuing are a combination of filter management in e1000 and a couple issues in the em_txrx.c. I have today off so I'll see if I can make some progress, I've found some bugs in testing so nothing is ready for commit yet but here's my works in progress: D30002 and D30072

May 31 2021, 4:27 PM · iflib

May 28 2021

kbowling accepted D30463: iflib:correct vlan register/unregister.

I see it clearly now, and agree. Thanks for the fix!

May 28 2021, 6:37 AM · iflib

May 11 2021

kbowling updated subscribers of D30155: ixgbe: Bring back accounting for tx in AIM.

@stallamr_netapp.com thanks, there is a variable here in that I am running in two VMs amongst other things. I'm also diving into this code for the first time in 3 years so this is new, I'm just trying to understand the problem in the drivers and hopefully fix it or find someone who can. @gnn is getting me access to the project's network lab, and I'll use that to see if I can take a look at the problem on other types of hardware.

May 11 2021, 3:31 AM

May 10 2021

kbowling updated the diff for D30073: e1000: Clean up igb_txrx.

Thanks for catching those mistakes. Can you take a look, I'm happy with this at the moment.

May 10 2021, 4:06 AM
kbowling updated the diff for D30074: ixgbe: Clean up ix_txrx.

Thanks for catching those mistakes. Can you take a look, I'm happy with this at the moment.

May 10 2021, 3:46 AM
kbowling updated subscribers of D30155: ixgbe: Bring back accounting for tx in AIM.

There are some optimizations in the iflib driver to decrease TX descriptor writeback txq_max_rs_deferred (I think @gallatin mentioned this earlier), I wonder if this is just a matter of the old AIM algorithm being too aggressive and needing to be tamped down a bit for this batching.

May 10 2021, 3:39 AM

May 9 2021

kbowling requested review of D30178: ixgbe: Print NVM and Option ROM versions.
May 9 2021, 11:08 PM

May 8 2021

kbowling updated the diff for D30155: ixgbe: Bring back accounting for tx in AIM.

I have good news and bad news to report.

May 8 2021, 8:23 PM

May 7 2021

kbowling added a comment to D30155: ixgbe: Bring back accounting for tx in AIM.

Ok I'll add that accounting and report my findings

May 7 2021, 3:30 PM
kbowling added a comment to D30094: ixgbe: Enable AIM by default.

@erj ok I agree with both of you about that change to the aim algorithm (See D30155). I just tested and by read it will be necessary but by testing it is not sufficient to fix the issue. We are still over-eager in iflib_fast_intr_rxtx with the change applied.

May 7 2021, 12:12 AM
kbowling requested review of D30155: ixgbe: Bring back accounting for tx in AIM.
May 7 2021, 12:04 AM

May 6 2021

kbowling added a comment to D30094: ixgbe: Enable AIM by default.

Some other random notes:

May 6 2021, 7:49 PM
kbowling updated subscribers of D30094: ixgbe: Enable AIM by default.

@stallamr_netapp.com @jeffrey.e.pieper_intel.com @erj I've looked pretty hard at the committed aim code for a couple days and haven't figured it out yet, just a bunch of false starts/dead ends. It's not really a problem with the committed aim code as far as I can tell, there seem to be a couple issues in iflib that somehow interact poorly with the driver, as it is re-arming way too frequently in iflib_fast_intr_rxtx with AIM enabled on the sender (DBG_COUNTER_INC(rx_intr_enables) captures this).

May 6 2021, 5:52 PM

May 5 2021

kbowling added a comment to D30094: ixgbe: Enable AIM by default.

When this was originally implemented, Limelight (sbruno) experienced issues with this feature, as it was conflicting with iflib in some way, so it was then set to off by default.

May 5 2021, 4:40 PM
kbowling added a comment to D30094: ixgbe: Enable AIM by default.

@stallamr_netapp.com Sai, do you see the high rate of interrupts on the sender? If we can figure that out (which I think is important for you too), this patch to enable it by default will be ok.

May 5 2021, 6:19 AM

May 4 2021

kbowling requested changes to D30094: ixgbe: Enable AIM by default.

Due to constraints with my testing environment (a xeon-d under my desk, with two bhyve VMs each with a passthru X552) I cannot provide great statistical results but I can do a basic functionality test.

May 4 2021, 12:30 AM

May 3 2021

kbowling added inline comments to D30074: ixgbe: Clean up ix_txrx.
May 3 2021, 9:53 PM

May 2 2021

kbowling updated the test plan for D30072: e1000: Clean up and bug fix em_txrx.
May 2 2021, 8:57 AM
kbowling added inline comments to D29878: e1000: Widen I218-I219 erratum.
May 2 2021, 5:15 AM
kbowling updated the test plan for D30072: e1000: Clean up and bug fix em_txrx.
May 2 2021, 4:50 AM
kbowling updated the test plan for D30072: e1000: Clean up and bug fix em_txrx.
May 2 2021, 4:44 AM

May 1 2021

kbowling requested review of D30074: ixgbe: Clean up ix_txrx.
May 1 2021, 11:44 PM
kbowling requested review of D30073: e1000: Clean up igb_txrx.
May 1 2021, 11:35 PM
kbowling requested review of D30072: e1000: Clean up and bug fix em_txrx.
May 1 2021, 11:28 PM

Apr 30 2021

kbowling planned changes to D30002: e1000: Fix up HW vlan ops.

This seems ok on I210 but I am having a link stability issue on I219 after I add a vlan. I will need to check out the txrx code.

Apr 30 2021, 7:27 AM
kbowling updated the diff for D30002: e1000: Fix up HW vlan ops.

Spotted one more error after the last

Apr 30 2021, 5:10 AM
kbowling updated the diff for D30002: e1000: Fix up HW vlan ops.

bugfix for em_if_vlan_filter_capable

Apr 30 2021, 4:50 AM
kbowling updated the diff for D30002: e1000: Fix up HW vlan ops.

Some improvements to SRRCTL related settings pointed out by Kaho Toshikazu <kaho@elam.kais.kyoto-u.ac.jp> in PR 230996

Apr 30 2021, 4:27 AM
kbowling updated the diff for D30002: e1000: Fix up HW vlan ops.

Enable the VME bit if IFCAP_VLAN_HWTAGGING. Some better logic around the VFE bit, disable it when promiscuous. Add some helper functions for filter stuff.

Apr 30 2021, 4:12 AM
kbowling added inline comments to D30002: e1000: Fix up HW vlan ops.
Apr 30 2021, 2:17 AM

Apr 29 2021

kbowling added inline comments to D30036: Update Rack and BBR to the latest from NF fixing LRO issues along the way..
Apr 29 2021, 8:56 PM
kbowling added inline comments to D29878: e1000: Widen I218-I219 erratum.
Apr 29 2021, 6:42 PM