Differential D37768

Convert iflib(4) and iflib-based drivers to the DrvAPI
ClosedPublic
Actions

Authored by jhibbits on Dec 20 2022, 10:01 PM.

Tags

None

Referenced Files

	F171664176: D37768.id114343.diff
	Sat, Sep 12, 12:56 PM

	Unknown Object (File)
	Thu, Sep 10, 5:59 PM

	Unknown Object (File)
	Thu, Sep 10, 9:58 AM

	Unknown Object (File)
	Sun, Sep 6, 4:56 AM

	Unknown Object (File)
	Sun, Sep 6, 3:44 AM

	Unknown Object (File)
	Sat, Sep 5, 10:21 PM

	Unknown Object (File)
	Sat, Sep 5, 6:41 PM

	Unknown Object (File)
	Fri, Sep 4, 6:07 PM

Subscribers

Details

Reviewers

gallatin
mmacy
kbowling
shurd

Group Reviewers

network
Restricted Owners Package	(Owns No Changed Paths)
iflib

Commits

rG402810d32e5f: Convert iflib(4) and iflib-based drivers to the DrvAPI

Summary

Convert iflib(4) and the following drivers:

axgbe
em
ice
ixl
vmxnet

Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Dec 20 2022, 10:01 PM

Owners added a reviewer: Restricted Owners Package.Dec 20 2022, 10:01 PM

Herald added a reviewer: shurd. · View Herald TranscriptDec 20 2022, 10:01 PM

Herald added a reviewer: iflib. · View Herald Transcript

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald Transcript

jhibbits requested review of this revision.Dec 20 2022, 10:01 PM

Harbormaster completed remote builds in B48782: Diff 114343.Dec 20 2022, 10:01 PM

kbowling accepted this revision.Dec 20 2022, 10:50 PM

erj added a subscriber: erj.Dec 21 2022, 7:09 PM

erj added inline comments.

sys/dev/ixl/ixl_iw.c
168	I think this needs to be adjusted
sys/dev/ixl/ixl_pf_main.c
621	Is it if_getname, or if_getxname? You use the former function in other places.

jhibbits added inline comments.Dec 21 2022, 7:17 PM

sys/dev/ixl/ixl_iw.c
168	How did this even pass the build? I see why now, because the file is not even compiled.
sys/dev/ixl/ixl_pf_main.c
621	It should be if_name() instead. That's the KPI @melifaro likes, and I thought my sed fixed all of them.

erj added inline comments.Dec 21 2022, 7:45 PM

sys/dev/ixl/ixl_iw.c
168	This file/functionality should probably be removed for 14, anyway.
sys/dev/ixl/ixl_pf_main.c
621	Ok, yeah, I see it's if_name() everywhere else; I think I just transposed the "get" there because most of these accessors use "get".

Hmm... this should've been closed already, but I can't close it without abandoning.

Was already pushed as 402810d32e5f7525c61ef70c6af24817227e1649.

jhb added a commit: rG402810d32e5f: Convert iflib(4) and iflib-based drivers to the DrvAPI.Dec 21 2022, 9:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 6 2023, 1:32 AM

Closed by commit rG402810d32e5f: Convert iflib(4) and iflib-based drivers to the DrvAPI (authored by jhibbits). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

axgbe/

44 lines

19 lines

2 lines

2 lines

8 lines

6 lines

e1000/

22 lines

ice/

2 lines

2 lines

8 lines

ixl/

12 lines

2 lines

2 lines

4 lines

10 lines

vmware/

vmxnet3/

18 lines

2 lines

net/

38 lines

Diff 114786

sys/dev/axgbe/if_axgbe.c

Loading...

sys/dev/axgbe/if_axgbe_pci.c

Loading...

sys/dev/axgbe/xgbe-dev.c

Loading...

sys/dev/axgbe/xgbe-drv.c

Loading...

sys/dev/axgbe/xgbe-phy-v2.c

Loading...

sys/dev/axgbe/xgbe.h

Loading...

sys/dev/e1000/if_em.c

Loading...

sys/dev/ice/ice_lib.c

Loading...

sys/dev/ice/ice_rdma.c

Loading...

sys/dev/ice/if_ice_iflib.c

Loading...

sys/dev/ixl/if_ixl.c

Loading...

sys/dev/ixl/ixl.h

Loading...

sys/dev/ixl/ixl_iw.c

Loading...

sys/dev/ixl/ixl_pf_iflib.c

Loading...

sys/dev/ixl/ixl_pf_main.c

Loading...

sys/dev/vmware/vmxnet3/if_vmx.c

Loading...

sys/dev/vmware/vmxnet3/if_vmxvar.h

Loading...

sys/net/iflib.c

Loading...