User Details
- User Since
- Jun 22 2015, 5:21 PM (232 w, 4 d)
Mon, Nov 18
Fri, Nov 15
Thu, Nov 7
This fixes GPFs for me when using hwpmc on AMD Rome. The GPFs were triggered out of MSR writes in the amd hwpmc interrupt handler.
Nov 4 2019
Nov 1 2019
This was fixed in r353483, however the wrong differential was tagged in that commit, so this differential was never closed.
Oct 31 2019
Thanks for fixing this. The NULL canaries were left over from when iflib had a separate code path which avoided busdma. When I removed this codepath, I neglected to remove those canaries.
Oct 25 2019
Oct 24 2019
Oct 23 2019
Works fine running on a Netflix cache.
Oct 22 2019
Oct 10 2019
I just looked for a short time.. more comments later..
Oct 9 2019
Oct 8 2019
Yes, I meant adding a KASSERT or at least a comment.
I like this a lot. Note that I only looked at mxge and a few iflib drivers.
Oct 7 2019
Oct 6 2019
Oct 3 2019
Oct 1 2019
Moved PORTREVISION down a line to fix portlint complaint as pointed out by jhb
Sep 29 2019
Sep 28 2019
In my tests of UDP transmit using N copies of netperf on a 14c/28t Xeon E5-2697 v3 (haswell) using a 40Gbe ixl, I see nearly a 100% performance improvement (eg, double the packet rate) as compared to using mp_ring. In fact, for a single-threaded test the packet rate is 4x what it is for mp_ring with tx-abdicate enabled.
Sep 27 2019
Applied suggested changes prior to committing.
Re-submit diff with -U999999 for full context.
Updated the port to handle TLS 1.3
Applied suggested changes in what I'm about to commit.
Sep 26 2019
- I've taken linimon's changes from bugzilla
- I've hooked the port to the Makefile in the parent
Updated to address feedback from Hans:
- add comment that record_type must be first in the union
- added a constant for the 1.3 GCM iv len and checked it where we check it for 1.2
I tested this, and it performed well and worked fine.
Sep 25 2019
Sep 20 2019
Would it make sense then to assert that the link is down?
I'm not sure, but I think the only way this can happen is when the link is down. Is that the caee here?
Sep 17 2019
Uncrappy is nice. But if we've got lock contention, it would be nice to know why.
Sep 16 2019
Sep 14 2019
Sep 13 2019
- Fixed line wrap issues pointed out by igor
Address bz's concerns:
- Shorten lines in man page
- Make numa_domain consistently uint8_t
- simplify logic in places
- fix some style errors
Sep 11 2019
Sep 10 2019
Aug 30 2019
Aug 27 2019
Aug 23 2019
Aug 21 2019
Aug 18 2019
Aug 16 2019
Aug 15 2019
Aug 2 2019
Jul 24 2019
Jul 23 2019
Oh, and in the documentation, it would be handy to note that BIOSes will sometimes disable this functionality and you may need to enable or disable certain common settings in the BIOS.
I just cherry picked this into my tree to try on some servers. As a *USER*, I have the following comments:
Jul 12 2019
Jul 3 2019
Jun 28 2019
Jun 24 2019
Jun 22 2019
Jun 12 2019
Jun 5 2019
Just wanted to chime in and say that this, in combination with https://reviews.freebsd.org/D20523, allows me to pass an add-in USB XHCI controller to a guest. Before this patch, bhyve would abort when passing through the problematic controller.
Just wanted to chime in that this, in combination with https://reviews.freebsd.org/D20525, allows me to pass through an add-in USB XHCI controller to a guest OS. Before this patch, bhyve would segv.
May 24 2019
I tend to think that neither of these is actually a problem, since in both cases, if the "if" is taken, we return or jump. But the fix seems harmless.