Page MenuHomeFreeBSD

glebius (Gleb Smirnoff)
User

Projects

User Details

User Since
May 28 2014, 2:27 PM (335 w, 1 d)

Recent Activity

Yesterday

glebius committed rS367150: Convert flags from int to bool. Some (compress) were already used in.
Convert flags from int to bool. Some (compress) were already used in
Thu, Oct 29, 11:15 PM

Tue, Oct 27

glebius accepted D26897: Improve ioctl() for listening TCP sockets.

Definitely my miss. Thanks for fixing!

Tue, Oct 27, 5:09 PM

Thu, Oct 22

glebius committed rS366945: Fix typo.
Fix typo
Thu, Oct 22, 6:00 PM

Sep 25 2020

glebius accepted D26548: ng_l2tp: Fix callout synchronization in the RACK timeout handler.
Sep 25 2020, 6:34 PM

Sep 23 2020

glebius accepted D26523: Enable multipath for outbound connections.
Sep 23 2020, 9:10 PM
glebius added inline comments to D26449: Stage 2: Introduce scalable route multipath.
Sep 23 2020, 9:07 PM

Sep 9 2020

glebius committed rS365504: In r354148 the goal was to check THREAD_CAN_SLEEP() only once for the.
In r354148 the goal was to check THREAD_CAN_SLEEP() only once for the
Sep 9 2020, 4:13 PM

Sep 3 2020

glebius accepted D26296: [unix(4) cleanup 3/8] Rename unp_pcb_lock2()..
Sep 3 2020, 4:48 AM
glebius accepted D26295: [unix(4) cleanup 2/8] Improve unix socket refcounting..
Sep 3 2020, 4:47 AM
glebius accepted D26294: [unix(4) cleanup 1/8] Update unix domain socket locking comments..
Sep 3 2020, 4:43 AM

Aug 31 2020

glebius accepted D26226: ng_ether: Enter NET_EPOCH where required.

This looks good to me. Thanks a lot! Please commit if it passes tests.

Aug 31 2020, 5:20 PM

Aug 30 2020

glebius committed rS364975: Followup on r364922. Old comment said that the only reason to put.
Followup on r364922. Old comment said that the only reason to put
Aug 30 2020, 5:13 PM
glebius accepted D26150: make m_getm2() resilient to zone_jumbop exhaustion.
Aug 30 2020, 4:38 PM
glebius added a comment to D23928: Add deprecation notices to ce,cp,mn sync serial drivers.

spl calls is not something that gives any maintenance burden. They have been defined to nop for years. Of course it makes sense to cleanup those that aren't mentioned anywhere just like rS364918 did. However, I don't think just removing these nop defines is a holy grail we should aim for.

Aug 30 2020, 4:33 PM
glebius added inline comments to D26226: ng_ether: Enter NET_EPOCH where required.
Aug 30 2020, 4:24 PM

Aug 20 2020

glebius committed rS364441: When we have a command returned by zfs_nextboot() that is longer.
When we have a command returned by zfs_nextboot() that is longer
Aug 20 2020, 8:31 PM
glebius accepted D26126: style: Fix function spacing for for icmp6type_match() and flow6id_match() in ip_fw2.c.
Aug 20 2020, 4:44 PM · network

Aug 19 2020

glebius accepted D26062: Make net.fibs growable.
Aug 19 2020, 7:44 PM
glebius accepted D25923: add a MSG_TLSAPPDATA flag that tells sorecieve() to return ENXIO for TLS non-application data records.
Aug 19 2020, 7:32 PM
glebius committed rP545267: Make it compilable with clang 11..
Make it compilable with clang 11.
Aug 19 2020, 12:29 AM

Aug 17 2020

glebius committed rS364310: With INVARIANTS panic immediately if M_WAITOK is requested in a.
With INVARIANTS panic immediately if M_WAITOK is requested in a
Aug 17 2020, 3:37 PM
glebius closed D26027: Catch illegal M_WAITOK immediately..
Aug 17 2020, 3:37 PM

Aug 11 2020

glebius added a comment to D26027: Catch illegal M_WAITOK immediately..
In D26027#577448, @mjg wrote:

I remember UMA warning about relevant allocations without even attempting to sleep, but maybe my memory is off here.

Aug 11 2020, 6:21 PM
glebius updated the diff for D26027: Catch illegal M_WAITOK immediately..

Add same check to UMA.

Aug 11 2020, 6:18 PM
glebius added a comment to D26027: Catch illegal M_WAITOK immediately..
In D26027#577390, @kib wrote:

Why it is not WITNESS_WARN() ? Perhaps witness_warn should take td_no_sleeping as arbitrary non-sleepable lock as well.

Aug 11 2020, 6:06 PM
glebius requested review of D26027: Catch illegal M_WAITOK immediately..
Aug 11 2020, 3:49 PM
glebius closed D26021: ipfw: improve matching on IPv4 fragments.
Aug 11 2020, 3:46 PM
glebius committed rS364117: ipfw: make the "frag" keyword accept additional options "mf",.
ipfw: make the "frag" keyword accept additional options "mf",
Aug 11 2020, 3:46 PM

Aug 10 2020

glebius requested review of D26021: ipfw: improve matching on IPv4 fragments.
Aug 10 2020, 9:17 PM

Jul 21 2020

glebius added a comment to D22691: ifnet: drain+halt ioctl operations on detach.

The resulting if_busy() / if_unbusy() / if_busy_wait() semantics looks very similar to sx locking. I'm wondering why not simply use sx locks as @glebius suggested?

I think, through the course of this, I became convinced that sx usage complicates some possible future busy'ers that would no longer be able to hold a mutex across calls here.

Jul 21 2020, 2:00 PM

Jul 15 2020

glebius added inline comments to D25512: WIP bootnext: Next Generation.
Jul 15 2020, 4:35 AM

Jul 13 2020

glebius added a comment to D24830: sendfile_test: Finish to implement linear probing to find a free port .

Why don't you just remove call to bind() and listen on unbound socket? Then you get its address with getsockname() and use it in the client side?

Jul 13 2020, 11:48 PM

Jul 7 2020

glebius committed rS362982: Fixup r362981: remove gzipped manual pages..
Fixup r362981: remove gzipped manual pages.
Jul 7 2020, 2:44 AM
glebius committed rS362981: Fixup for r360574: install new mlinks for sglist(9) and remove old ones..
Fixup for r360574: install new mlinks for sglist(9) and remove old ones.
Jul 7 2020, 2:42 AM

Jun 23 2020

glebius added a comment to D23928: Add deprecation notices to ce,cp,mn sync serial drivers.

I called Cronyx and here is information I got. All the devices from http://cronyx.ru/hardware/wan.html can be ordered and purchased, even the ISA ones. The FreeBSD drivers were discontinued back when rik@ quit them, and couple years later the Linux drivers were discontinued, too. Right now there are no driver developers at Cronyx at all. However, they got small but constant demand for all of the devices they produce. They can't disclose who buys them and what OS do they run. The tech support guy was responsive and nice to talk to. We discussed a hypothetical situation when someone buys for example Tau-PCI, runs FreeBSD and encounters a problem. If I would offer my help to this user, would Cronyx offer their help to me? The guy on the other side of the phone repeated that they don't have driver developers now, but they would be able to provide some information on hardware to a FreeBSD person who is maintaining the drivers.

Jun 23 2020, 12:04 PM

Jun 18 2020

glebius accepted D25312: Relax the rule against declaring variables in nested scopes..
Jun 18 2020, 9:18 AM

Jun 17 2020

glebius added a comment to D25285: fix kernel linking without FFS.

Why do these functions logically belong to ffs_subr? The ffs_load_inode() definitely belongs to ffs_vfsops since it is used only there and with the change it becomes static. Other moved functions are associated with unmounting, which IMHO also belongs to vfsops rather than to subr. What else outside of real FFS code is going to use them? AFAIU, the code that is ffs_subr is something that is shared between real FFS, non-kernel code and GEOM_LABEL.

Jun 17 2020, 2:02 AM

Jun 15 2020

glebius requested review of D25285: fix kernel linking without FFS.
Jun 15 2020, 6:05 PM

Jun 8 2020

glebius committed rS361931: Move MPASS() macros to systm.h. They are widely used all over.
Move MPASS() macros to systm.h. They are widely used all over
Jun 8 2020, 5:41 PM
glebius closed D23656: Move MPASS() macros to systm.h..
Jun 8 2020, 5:41 PM

May 27 2020

glebius accepted D24674: fix sosend() so that it can handle an mbuf list for KTLS.

This looks correct to me.

May 27 2020, 12:52 AM

May 19 2020

glebius closed D23674: Change smarter epoch support for NIC drivers to opt-in..
May 19 2020, 12:57 AM

May 10 2020

glebius committed rS360873: Merge r360138:.
Merge r360138:
May 10 2020, 2:47 PM

May 3 2020

glebius committed rS360583: Step 4.2: start divorce of M_EXT and M_EXTPG.
Step 4.2: start divorce of M_EXT and M_EXTPG
May 3 2020, 12:37 AM
glebius committed rS360582: Mechanically rename MBUF_EXT_PGS_ASSERT() to M_ASSERTEXTPG() to match.
Mechanically rename MBUF_EXT_PGS_ASSERT() to M_ASSERTEXTPG() to match
May 3 2020, 12:28 AM
glebius committed rS360581: Step 4.1: mechanically rename M_NOMAP to M_EXTPG.
Step 4.1: mechanically rename M_NOMAP to M_EXTPG
May 3 2020, 12:21 AM
glebius committed rS360579: Step 3: anonymize struct mbuf_ext_pgs and move all its fields into mbuf.
Step 3: anonymize struct mbuf_ext_pgs and move all its fields into mbuf
May 3 2020, 12:13 AM
glebius committed rS360578: Step 2.5: Stop using 'struct mbuf_ext_pgs' in the kernel itself..
Step 2.5: Stop using 'struct mbuf_ext_pgs' in the kernel itself.
May 3 2020, 12:08 AM
glebius committed rS360577: Make MBUF_EXT_PGS_ASSERT_SANITY() a macro, so that it prints file:line..
Make MBUF_EXT_PGS_ASSERT_SANITY() a macro, so that it prints file:line.
May 3 2020, 12:04 AM

May 2 2020

glebius committed rS360576: Step 2.4: Stop using 'struct mbuf_ext_pgs' in drivers..
Step 2.4: Stop using 'struct mbuf_ext_pgs' in drivers.
May 2 2020, 11:58 PM
glebius committed rS360575: Step 2.3: Rename mbuf_ext_pg_len() to m_epg_pagelen() that.
Step 2.3: Rename mbuf_ext_pg_len() to m_epg_pagelen() that
May 2 2020, 11:52 PM
glebius committed rS360574: Step 2.2:.
Step 2.2:
May 2 2020, 11:46 PM
glebius committed rS360573: Step 2.1: Build TLS workqueue from mbufs, not struct mbuf_ext_pgs..
Step 2.1: Build TLS workqueue from mbufs, not struct mbuf_ext_pgs.
May 2 2020, 11:38 PM
glebius committed rS360572: Get rid of the mbuf self-pointing pointer..
Get rid of the mbuf self-pointing pointer.
May 2 2020, 10:56 PM
glebius committed rS360571: Start moving into EPG_/epg_ namespace. There is only one flag, but.
Start moving into EPG_/epg_ namespace. There is only one flag, but
May 2 2020, 10:49 PM
glebius committed rS360570: In mb_unmapped_compress() we don't need mbuf structure to keep data,.
In mb_unmapped_compress() we don't need mbuf structure to keep data,
May 2 2020, 10:44 PM
glebius closed D24598: More re-working of multipage mbufs..
May 2 2020, 10:39 PM
glebius committed rS360569: Continuation of multi page mbuf redesign from r359919..
Continuation of multi page mbuf redesign from r359919.
May 2 2020, 10:39 PM

Apr 28 2020

glebius added inline comments to D24598: More re-working of multipage mbufs..
Apr 28 2020, 5:42 PM

Apr 27 2020

glebius requested review of D24598: More re-working of multipage mbufs..
Apr 27 2020, 6:26 PM

Apr 25 2020

glebius added a comment to D24552: Limit taskqueue/gtaskqueue executions in epoch.

Can we use a time-based expiry, like ticks?

Apr 25 2020, 7:57 PM

Apr 24 2020

glebius created D24552: Limit taskqueue/gtaskqueue executions in epoch.
Apr 24 2020, 2:04 AM

Apr 22 2020

glebius committed rP532444: Remove no longer valid URL..
Remove no longer valid URL.
Apr 22 2020, 3:48 AM
glebius committed rP532443: Re-do r530415 and other patches that skip certain defines in a more.
Re-do r530415 and other patches that skip certain defines in a more
Apr 22 2020, 3:47 AM

Apr 20 2020

glebius committed rS360138: Fix immediate crash when snmpd is bound to a specific IP address..
Fix immediate crash when snmpd is bound to a specific IP address.
Apr 20 2020, 11:32 PM

Apr 17 2020

glebius committed rS360037: Make ZFS depend on xdr.ko only. It doesn't need kernel RPC..
Make ZFS depend on xdr.ko only. It doesn't need kernel RPC.
Apr 17 2020, 6:05 AM
glebius committed rS360036: Split XDR into separate kernel module. Make krpc depend on xdr..
Split XDR into separate kernel module. Make krpc depend on xdr.
Apr 17 2020, 6:04 AM
glebius committed rS360035: Move M_RPC malloc type into XDR. Both RPC and XDR libraries use.
Move M_RPC malloc type into XDR. Both RPC and XDR libraries use
Apr 17 2020, 6:02 AM
glebius closed D24408: ZFS should depend on XDR, not full RPC.
Apr 17 2020, 6:02 AM
glebius committed rS360034: Don't initialize m->m_data to m->m_pktdat, this is already done by the.
Don't initialize m->m_data to m->m_pktdat, this is already done by the
Apr 17 2020, 6:00 AM

Apr 16 2020

glebius added a comment to D24408: ZFS should depend on XDR, not full RPC.

Oh, one other thing.
I can never remember without doing a build, but maybe a
MODULE_DEPEND(xxx, xdr, 1, 1, 1)
needs to be added to all the modules that currently have
MODULE_DEPEND(xxx, krpc, 1, 1, 1)?

Apr 16 2020, 5:12 PM
glebius added inline comments to D24408: ZFS should depend on XDR, not full RPC.
Apr 16 2020, 5:09 PM
glebius added a comment to D24408: ZFS should depend on XDR, not full RPC.

Out of curiosity, how does options XDR (in a kernel config) avoid a name collision with the XDR typedef?

Apr 16 2020, 5:08 PM
glebius updated the diff for D24408: ZFS should depend on XDR, not full RPC.

Since separating malloc types goes more and more complicated, follow
Rick's suggestion and abandon that idea. Move MALLOC_DECLARE(M_RPC)
into XDR. Three commits remain:

Apr 16 2020, 5:06 PM

Apr 15 2020

glebius added a comment to D24408: ZFS should depend on XDR, not full RPC.

I don't see anything wrong with this review, but FYI there is now a live upstream https://github.com/openzfs/zfs/commit/9f0a21e6411aa0bac23fba0ddb220342a48c7cc7 and the code in HEAD will some time later this year be replaced with vendor code. Most of the changes to ZFS in HEAD at this point will only live on through MFCs to stable/12 and stable/11.

Apr 15 2020, 12:00 AM

Apr 14 2020

glebius added a comment to D24408: ZFS should depend on XDR, not full RPC.

It seems that a lot of the complexity of this patch is a result of defining
a new malloc() type.
Is a new type really needed?
I'll leave it up to you, but I'd just stick with M_RPC everywhere and
that would keep the patch a lot simpler.

Apr 14 2020, 11:59 PM
glebius updated the diff for D24408: ZFS should depend on XDR, not full RPC.

Address Rick's comment and split into more commits.

Apr 14 2020, 7:19 PM
glebius added a comment to D24408: ZFS should depend on XDR, not full RPC.

My only concern is that there is a mem_free() call done
somewhere in the rpc code for one of these malloc()s,
but I couldn't find one.
If this happens, it will be easily spotted during testing
when "vmstat -m" generates crap for "rpc" and "xdr".

Apr 14 2020, 6:58 PM
glebius added a comment to D24408: ZFS should depend on XDR, not full RPC.

Oh, one other thing.
I can never remember without doing a build, but maybe a
MODULE_DEPEND(xxx, xdr, 1, 1, 1)
needs to be added to all the modules that currently have
MODULE_DEPEND(xxx, krpc, 1, 1, 1)?

Apr 14 2020, 5:24 PM
glebius added inline comments to D24408: ZFS should depend on XDR, not full RPC.
Apr 14 2020, 4:25 PM
glebius added a comment to D23928: Add deprecation notices to ce,cp,mn sync serial drivers.

Sorry, totally forgot about this. Will call them today/tomorrow.

Apr 14 2020, 1:55 AM

Apr 13 2020

glebius created D24408: ZFS should depend on XDR, not full RPC.
Apr 13 2020, 10:57 PM

Mar 30 2020

glebius accepted D24038: Fixes for sendfile..

Thanks a lot for the change! I'd really wish that scopes of local variables isn't increased. If it is possible to avoid doing that, I'd really appreciate.

Mar 30 2020, 5:35 PM
glebius added inline comments to D24038: Fixes for sendfile..
Mar 30 2020, 5:32 PM
glebius added a comment to D24038: Fixes for sendfile..

Just a general note, that I really dislike moving of local variables to a greater scope. Yes, I know that a document from the previous century named style(9) suggests to do that. But doing it this way makes code harder to read! Change my mind.

Mar 30 2020, 5:18 PM

Mar 5 2020

glebius committed rS358686: Align the buffer to the alignment of the structure we expect..
Align the buffer to the alignment of the structure we expect.
Mar 5 2020, 9:02 PM
glebius added a reviewer for D23928: Add deprecation notices to ce,cp,mn sync serial drivers: glebius.
Mar 5 2020, 12:48 AM
glebius added a comment to D23928: Add deprecation notices to ce,cp,mn sync serial drivers.

These cards seem to be still produced and sold http://cronyx.ru/hardware/wan.html

Mar 5 2020, 12:47 AM

Mar 4 2020

glebius committed rS358658: Add a missing bktr header..
Add a missing bktr header.
Mar 4 2020, 11:49 PM
glebius closed D23954: netgraph/ng_car: Fix spelling.
Mar 4 2020, 10:32 PM
glebius committed rS358657: Fix spelling of "dropped"..
Fix spelling of "dropped".
Mar 4 2020, 10:32 PM
glebius committed rS358656: Remove unused function..
Remove unused function.
Mar 4 2020, 10:31 PM
glebius committed rS358655: When a machine boots the NFS mounting script is executed after.
When a machine boots the NFS mounting script is executed after
Mar 4 2020, 10:27 PM
glebius closed D23934: mount_nfs: retry when interface state changes to IFF_UP and link up.
Mar 4 2020, 10:27 PM

Mar 3 2020

glebius added a reviewer for D23934: mount_nfs: retry when interface state changes to IFF_UP and link up: network.
Mar 3 2020, 12:19 AM
glebius added a comment to D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing.

I still get "ngctl: send msg: Invalid argument" errors with the commands in the Test Plan. Am I doing anything wrong?

Mar 3 2020, 12:17 AM · network
glebius added a comment to D23721: ng_one2many: Don't duplicate packets with m_dup() when receiving and re-transmitting.

This can make sense in certain setups. However, since originally node provided writable copies to each of "many" hooks, we can't change that. This can be configured as a node option, if sysadmin is sure that nodes downstream of "many" hooks are fine with read only mbufs.

Mar 3 2020, 12:09 AM
glebius created D23934: mount_nfs: retry when interface state changes to IFF_UP and link up.
Mar 3 2020, 12:02 AM

Mar 2 2020

glebius accepted D23886: ip6_output: use new routing KPI when not passed a cached route.
Mar 2 2020, 9:35 PM

Feb 25 2020

glebius committed rS358320: Generalize resources freeing in sendfile with different scenarios..
Generalize resources freeing in sendfile with different scenarios.
Feb 25 2020, 7:29 PM