Page MenuHomeFreeBSD

glebius (Gleb Smirnoff)
User

Projects

User Details

User Since
May 28 2014, 2:27 PM (392 w, 2 d)

Recent Activity

Yesterday

glebius updated subscribers of D33254: in_pcb: use jenkins hash over the entire IPv6 (or IPv4) address.

This has been running at Netflix for a while. Written by @gallatin and myself after a test case instrumented by @jtl .

Fri, Dec 3, 8:55 PM
glebius requested review of D33254: in_pcb: use jenkins hash over the entire IPv6 (or IPv4) address.
Fri, Dec 3, 8:55 PM
glebius committed R10:36f42c5ebf69: tcp_ccalgounload(): initialize the inpcb iterator when curvnet is set (authored by glebius).
tcp_ccalgounload(): initialize the inpcb iterator when curvnet is set
Fri, Dec 3, 8:41 PM
glebius committed R10:4c018b5aed41: in_pcb: limit the effect of wraparound in TCP random port allocation check (authored by peter.lei_ieee.org).
in_pcb: limit the effect of wraparound in TCP random port allocation check
Fri, Dec 3, 8:39 PM
glebius committed R10:13e3f3349f42: in_pcb: fix TCP local ephemeral port accounting (authored by peter.lei_ieee.org).
in_pcb: fix TCP local ephemeral port accounting
Fri, Dec 3, 8:33 PM
glebius committed R10:ae04d3045105: ng_l2tp: use callout_reset() instead of ng_callout() (authored by glebius).
ng_l2tp: use callout_reset() instead of ng_callout()
Fri, Dec 3, 4:59 PM
glebius accepted D33244: pfsync: fix incorrect enabling of defer mode.
Fri, Dec 3, 4:53 PM
glebius accepted D33243: pfsync: locking fixes.
Fri, Dec 3, 4:52 PM
glebius accepted D33242: pfsync: fix defer timeout.
Fri, Dec 3, 4:49 PM
glebius accepted D33241: pfsync: check IFF_DRV_RUNNING in the correct field.
Fri, Dec 3, 4:47 PM
glebius added a comment to D33240: pfsync: NULL check sc before using it.

If it go NULL spontaneously, it can go NULL right after this check before PFSYNC_LOCK(). The patch reduces panic chances significantly, of course.

Fri, Dec 3, 4:47 PM
glebius committed R10:12ae3476f35c: tcp_drain(): initialize the inpcb iterator when curvnet is set (authored by glebius).
tcp_drain(): initialize the inpcb iterator when curvnet is set
Fri, Dec 3, 5:10 AM
glebius committed R10:651a545143d2: udp_detach(): fix set but not used warning (authored by glebius).
udp_detach(): fix set but not used warning
Fri, Dec 3, 4:13 AM
glebius committed R10:bd1d0850452e: udp_multi_input(): the UDP header is only needed for probes (authored by glebius).
udp_multi_input(): the UDP header is only needed for probes
Fri, Dec 3, 4:13 AM
glebius committed R10:4b4cce02ac01: xhci: add PCI IDs for USB controllers found on Supermicro M12SWA-TF (authored by glebius).
xhci: add PCI IDs for USB controllers found on Supermicro M12SWA-TF
Fri, Dec 3, 4:13 AM

Thu, Dec 2

glebius closed D33025: tcp_hpts: rename input queue to drop queue and trim dead code.

Committed f971e791391d9f7ff6bfd7d7e0bed93267216329

Thu, Dec 2, 7:47 PM
glebius accepted D33025: tcp_hpts: rename input queue to drop queue and trim dead code.
Thu, Dec 2, 7:46 PM
glebius closed D33023: tcp_hpts: provide tcp_in_hpts()..

Committed 50f081ecb7a453213b15804c4b36903f1b248f8f

Thu, Dec 2, 7:46 PM
glebius accepted D33023: tcp_hpts: provide tcp_in_hpts()..
Thu, Dec 2, 7:46 PM
glebius closed D33022: SMR protection for inpcbs.

Committed de2d47842e880281da07f2589b9ec558b42c09c1

Thu, Dec 2, 7:45 PM
glebius accepted D33022: SMR protection for inpcbs.
Thu, Dec 2, 7:45 PM
glebius abandoned D33031: git-arc: with "create" allow to specify parent of the first commit.

Committed 964035c409b1b7229c7bc0220e7455e4a038ed4b

Thu, Dec 2, 7:44 PM
glebius committed R10:3cce6164ab9b: ip_input: remove pointless check in INP_RECVIF handling (authored by glebius).
ip_input: remove pointless check in INP_RECVIF handling
Thu, Dec 2, 7:16 PM
glebius committed R10:d96fccc50513: epoch: with EPOCH_TRACE add epoch_where_report() (authored by glebius).
epoch: with EPOCH_TRACE add epoch_where_report()
Thu, Dec 2, 7:07 PM
glebius committed R10:9e93d2b335a0: ifnet: enable & fix if_debug build (authored by glebius).
ifnet: enable & fix if_debug build
Thu, Dec 2, 7:07 PM
glebius committed R10:f971e791391d: tcp_hpts: rename input queue to drop queue and trim dead code (authored by glebius).
tcp_hpts: rename input queue to drop queue and trim dead code
Thu, Dec 2, 6:52 PM
glebius committed R10:2e27230ff932: tcp_hpts: rewrite inpcb synchronization (authored by glebius).
tcp_hpts: rewrite inpcb synchronization
Thu, Dec 2, 6:52 PM
glebius closed D33026: tcp_hpts: rewrite inpcb synchronization.
Thu, Dec 2, 6:52 PM
glebius committed R10:b0a7c008cbc6: tcp_hpts: make struct tcp_hpts_entry private to the module. (authored by glebius).
tcp_hpts: make struct tcp_hpts_entry private to the module.
Thu, Dec 2, 6:52 PM
glebius closed D33024: tcp_hpts: make struct tcp_hpts_entry private to the module..
Thu, Dec 2, 6:52 PM
glebius committed R10:50f081ecb7a4: tcp_hpts: provide tcp_in_hpts(). (authored by glebius).
tcp_hpts: provide tcp_in_hpts().
Thu, Dec 2, 6:51 PM
glebius committed R10:de2d47842e88: SMR protection for inpcbs (authored by glebius).
SMR protection for inpcbs
Thu, Dec 2, 6:51 PM
glebius closed D33021: inpcb: reduce some aliased functions after removal of PCBGROUP..
Thu, Dec 2, 6:50 PM
glebius committed R10:565655f4e33e: inpcb: reduce some aliased functions after removal of PCBGROUP. (authored by glebius).
inpcb: reduce some aliased functions after removal of PCBGROUP.
Thu, Dec 2, 6:50 PM
glebius closed D33020: Remove "options PCBGROUP".
Thu, Dec 2, 6:50 PM
glebius committed R10:93c67567e015: Remove "options PCBGROUP" (authored by glebius).
Remove "options PCBGROUP"
Thu, Dec 2, 6:50 PM
glebius closed D33019: Allow to compile RSS without PCBGROUP..
Thu, Dec 2, 6:49 PM
glebius committed R10:1cec1c5831b0: Allow to compile RSS without PCBGROUP. (authored by glebius).
Allow to compile RSS without PCBGROUP.
Thu, Dec 2, 6:49 PM
glebius added a comment to D33044: sshd: update the libwrap patch to drop connections early.

I expected some response from the secteam. If no response until Monday, I'm going to commit next week.

Thu, Dec 2, 5:56 PM
glebius added a reviewer for D33044: sshd: update the libwrap patch to drop connections early: gordon.
Thu, Dec 2, 5:55 PM
glebius added a comment to D32811: Add nd6_ifinfo() function to do basic checks to avoid NULL pointer dereference.

I think this problem also can be classified as queuing mbufs with pkthdr.rcvif pointer will allow ifnet pointer to outlive the epoch. I have a WIP that will post soon to provide API to serialize/restore the pkthdr.rcvif pointer and that should be used in all long term queuing of mbufs.

Thu, Dec 2, 4:46 PM

Tue, Nov 23

glebius accepted D33095: netinet: Deduplicate most in_cksum() implementations.
Tue, Nov 23, 8:31 PM
glebius accepted D33094: netinet: Remove in_cksum.c.
Tue, Nov 23, 8:30 PM
glebius accepted D33097: netinet: Remove unneeded mb_unmapped_to_ext() calls.
Tue, Nov 23, 8:29 PM
glebius accepted D33096: netinet: Implement in_cksum_skip() using m_apply().
Tue, Nov 23, 8:27 PM
glebius accepted D33093: netinet: Remove in_cksum_update().
Tue, Nov 23, 8:25 PM
glebius added a comment to D33092: os-release: Quote variables as documented in the manual.

Seems legit, but I'm not expert in this area.

Tue, Nov 23, 8:24 PM
glebius accepted D33098: tcp: don't upgrade a lock just for logging.
Tue, Nov 23, 6:19 PM
glebius committed R10:319e9fc642a1: ng_bridge: count item allocation failures as memory failures (authored by glebius).
ng_bridge: count item allocation failures as memory failures
Tue, Nov 23, 6:07 PM
glebius committed R10:3bc40f39fd86: if_free: add a comment explaining why ifindex_free() is performed here (authored by glebius).
if_free: add a comment explaining why ifindex_free() is performed here
Tue, Nov 23, 4:00 AM
glebius committed R10:fe499a8452cd: ifnet: merge if_destroy() and if_free_internal() into one (authored by glebius).
ifnet: merge if_destroy() and if_free_internal() into one
Tue, Nov 23, 4:00 AM
glebius committed R10:4787572d0580: ifnet: make if_alloc_domain() never fail (authored by glebius).
ifnet: make if_alloc_domain() never fail
Tue, Nov 23, 3:54 AM
glebius committed R10:1e3ca25d9296: ifnet: make if_alloc_domain() static (authored by glebius).
ifnet: make if_alloc_domain() static
Tue, Nov 23, 3:53 AM
glebius committed R10:ce40632a316c: ifnet: append if_debug.c to if.c (authored by glebius).
ifnet: append if_debug.c to if.c
Tue, Nov 23, 3:53 AM
glebius committed R10:8a6f38c8ac1b: ifnet: garbage collect drbr_*_drv(). (authored by glebius).
ifnet: garbage collect drbr_*_drv().
Tue, Nov 23, 3:53 AM
glebius accepted D33086: pf: align IPv6 dummynet handling with IPv4.
Tue, Nov 23, 3:41 AM
glebius accepted D33085: pf: remove unused variables.
Tue, Nov 23, 3:40 AM

Mon, Nov 22

glebius added a comment to D33064: dummynet: purge queued packets on interface destruction.
In D33064#747374, @jhb wrote:

So unlike the case of reassembly queues, these are transmitted packets, not received packets that have arrived at their destination. I don't know if such packets are eligible to be re-routed at this point (or if dummynet is "post" all routing decisions). If they can't be re-routed, then I think you would always want to drop them (there's no place to send them as the interface to send them on is gone). If they can be re-routed, then perhaps the ifnet departure event needs to re-route them instead? However, this isn't quite the same as fragments where you can just leave them around even with a NULL ifp.

Mon, Nov 22, 6:19 PM
glebius added a comment to D32846: ip_forward: store temporary mbuf on stack.

Have you considering using fast forwarding? The reason the feature exists is exactly to optimize this problem (and some others). It would allocate mcopy only in a case when receive interface == forward interface, which is not so common when you normally do forwarding.

Mon, Nov 22, 3:28 PM

Sun, Nov 21

glebius accepted D33065: netpfil tests: test removing interfaces with pending dummynet packets.
Sun, Nov 21, 3:51 AM

Sat, Nov 20

glebius closed D32966: Add tcp_freecb() - single place to free tcpcb..

Committed ff94500855c16d0d9cc18aa8b0ba73ea94020c56

Sat, Nov 20, 8:11 AM
glebius added a comment to D33044: sshd: update the libwrap patch to drop connections early.

We thought the same about OpenSSL, too.

Sat, Nov 20, 3:32 AM
glebius added a comment to D33064: dummynet: purge queued packets on interface destruction.

Phab put a big red cross in front on my name, but that's not what I really mean. I'll repeat myself. I won't fight against this change like crazy. If other developers have consensus that this is right way to solve the problem, go for it. Of course re-reading https://reviews.freebsd.org/D19622 makes sense to avoid repeating ourselves.

Sat, Nov 20, 2:45 AM
glebius requested changes to D33064: dummynet: purge queued packets on interface destruction.

I'm not going to block this change like a bully, but I again will iterate that this is wrong way of solving this problme. Same happened with IP reassembly queue https://reviews.freebsd.org/D19622 I rejected it, but it was still committed. Later more Very likely there are more mbuf queues subject to this problem. And we can play this whack a mole game endlessly, until we scan all of the network stack on an interface departure. This change is a 100% deja vu.

Sat, Nov 20, 2:42 AM

Fri, Nov 19

glebius added a comment to D33044: sshd: update the libwrap patch to drop connections early.

Also, libwrap is quite a seasoned open source software. Chances for a new vulnerability I would estimate as very low.

Fri, Nov 19, 7:21 PM
glebius added a comment to D33044: sshd: update the libwrap patch to drop connections early.

Does this then expose the main process to potential vulnerabilities in libwrap?

Fri, Nov 19, 7:20 PM
glebius updated the diff for D33026: tcp_hpts: rewrite inpcb synchronization.

Rebased on newer main.

Fri, Nov 19, 4:41 AM
glebius updated the diff for D33025: tcp_hpts: rename input queue to drop queue and trim dead code.

Rebased on newer main.

Fri, Nov 19, 4:41 AM
glebius updated the diff for D33024: tcp_hpts: make struct tcp_hpts_entry private to the module..

Rebased on newer main.

Fri, Nov 19, 4:39 AM
glebius updated the diff for D33023: tcp_hpts: provide tcp_in_hpts()..

Rebased on newer main.

Fri, Nov 19, 4:39 AM
glebius updated the diff for D33022: SMR protection for inpcbs.

Rebased on newer main.

Fri, Nov 19, 4:39 AM
glebius updated the diff for D33021: inpcb: reduce some aliased functions after removal of PCBGROUP..

Rebased on newer main.

Fri, Nov 19, 4:39 AM
glebius updated the diff for D33020: Remove "options PCBGROUP".

Rebased on newer main.

Fri, Nov 19, 4:38 AM
glebius updated the diff for D33019: Allow to compile RSS without PCBGROUP..

Rebased on newer main.

Fri, Nov 19, 4:38 AM
glebius committed R10:ff94500855c1: Add tcp_freecb() - single place to free tcpcb. (authored by glebius).
Add tcp_freecb() - single place to free tcpcb.
Fri, Nov 19, 4:29 AM
glebius committed R10:fb8588d2cb44: tcp_timewait: use on stack struct tcptw as last resort (authored by glebius).
tcp_timewait: use on stack struct tcptw as last resort
Fri, Nov 19, 4:28 AM
glebius closed D32965: tcp_timewait: use on stack struct tcptw as last resort.
Fri, Nov 19, 4:28 AM
glebius committed R10:964035c409b1: git-arc: with "create" allow to specify parent of the first commit (authored by glebius).
git-arc: with "create" allow to specify parent of the first commit
Fri, Nov 19, 2:51 AM
glebius committed R10:760be44702ba: git-arc: document "create" command options (authored by glebius).
git-arc: document "create" command options
Fri, Nov 19, 2:51 AM
glebius closed D33045: git-arc: document "create" command options.
Fri, Nov 19, 2:51 AM

Thu, Nov 18

glebius committed R10:0dff875fa9bc: ipfw: remove unnecessary TCP related includes (authored by glebius).
ipfw: remove unnecessary TCP related includes
Thu, Nov 18, 8:55 AM
glebius committed R10:3850d1837bf7: in6_rmx: remove unnecessary TCP includes (authored by glebius).
in6_rmx: remove unnecessary TCP includes
Thu, Nov 18, 8:55 AM
glebius updated the diff for D33031: git-arc: with "create" allow to specify parent of the first commit.

Address pauamma_gundo.com comment

Thu, Nov 18, 12:27 AM
glebius updated the diff for D33045: git-arc: document "create" command options.

fixup

Thu, Nov 18, 12:26 AM
glebius updated the diff for D33031: git-arc: with "create" allow to specify parent of the first commit.

Update previous patch

Thu, Nov 18, 12:15 AM
glebius updated the diff for D33045: git-arc: document "create" command options.

Address Mark's comment

Thu, Nov 18, 12:15 AM

Wed, Nov 17

glebius updated the diff for D33031: git-arc: with "create" allow to specify parent of the first commit.

Provide description for -p. Requires https://reviews.freebsd.org/D33045

Wed, Nov 17, 9:41 PM
glebius added reviewers for D33045: git-arc: document "create" command options: markj, imp.
Wed, Nov 17, 9:40 PM
glebius requested review of D33045: git-arc: document "create" command options.
Wed, Nov 17, 9:39 PM
glebius added inline comments to D33031: git-arc: with "create" allow to specify parent of the first commit.
Wed, Nov 17, 9:26 PM
glebius added reviewers for D33044: sshd: update the libwrap patch to drop connections early: secteam, emaste, des.
Wed, Nov 17, 9:15 PM
glebius requested review of D33044: sshd: update the libwrap patch to drop connections early.
Wed, Nov 17, 9:15 PM
glebius added a comment to D33020: Remove "options PCBGROUP".
In D33020#746171, @rrs wrote:

Only question I have Gleb, is does the removal of PCBGROUP have any performance impacts for a user
that was using it and now no longer can?

Wed, Nov 17, 7:48 PM
glebius requested review of D33031: git-arc: with "create" allow to specify parent of the first commit.
Wed, Nov 17, 6:28 AM

Tue, Nov 16

glebius added a comment to D33022: SMR protection for inpcbs.

inpcb garbage collector traffic in epoch context as seen under uperf -m connect.xml test.

Tue, Nov 16, 9:52 PM
glebius added a reviewer for D33020: Remove "options PCBGROUP": franco_opnsense.org.
Tue, Nov 16, 9:46 PM
glebius added a comment to D33022: SMR protection for inpcbs.
In D33022#745736, @bz wrote:

Given we don't seem to have a `man smr` could you at least expand SMR once in your title/description so people can find what they are looking for as it's virtually invisible to the world still (unless one finds the header file)?

Tue, Nov 16, 9:46 PM
glebius added reviewers for D33019: Allow to compile RSS without PCBGROUP.: network, transport, franco_opnsense.org.
Tue, Nov 16, 9:43 PM
glebius added reviewers for D33022: SMR protection for inpcbs: network, jeff, mjg, franco_opnsense.org.
Tue, Nov 16, 9:43 PM
glebius added a comment to D33022: SMR protection for inpcbs.

Note: due to my poor phab skills the previous version was abandoned. Tried to add it to the stack of reviews, but failed. Previous version: https://reviews.freebsd.org/D32585

Tue, Nov 16, 9:42 PM