Page MenuHomeFreeBSD

glebius (Gleb Smirnoff)
User

Projects

User Details

User Since
May 28 2014, 2:27 PM (367 w, 4 d)

Recent Activity

May 6 2021

glebius committed R10:be578b67b5a5: tcp_twcheck(): use correct unlock macro. (authored by glebius).
tcp_twcheck(): use correct unlock macro.
May 6 2021, 5:23 PM

Apr 22 2021

glebius accepted D29936: pf: Allow multiple labels to be set on a rule.
Apr 22 2021, 9:02 PM

Apr 20 2021

glebius committed R10:d554522f6e68: tcp_hostcache: use SMR for lookups, mutex(9) for updates. (authored by glebius).
tcp_hostcache: use SMR for lookups, mutex(9) for updates.
Apr 20 2021, 5:07 PM
glebius committed R10:1db08fbe3ffa: tcp_input: always request read-locking of PCB for any pure SYN segment. (authored by glebius).
tcp_input: always request read-locking of PCB for any pure SYN segment.
Apr 20 2021, 5:07 PM
glebius committed R10:7b5053ce2296: tcp_input: remove comments and assertions about tcpbinfo locking (authored by glebius).
tcp_input: remove comments and assertions about tcpbinfo locking
Apr 20 2021, 5:07 PM
glebius closed D29729: SMR for TCP hostcache..
Apr 20 2021, 5:06 PM
glebius committed R10:faa9ad8a9005: Fix off-by-one error in KASSERT from 02f26e98c7f4. (authored by glebius).
Fix off-by-one error in KASSERT from 02f26e98c7f4.
Apr 20 2021, 12:21 AM

Apr 16 2021

glebius committed R10:86046cf55f80: tcp_respond(): fix assertion, should have been done in 08d9c920275. (authored by glebius).
tcp_respond(): fix assertion, should have been done in 08d9c920275.
Apr 16 2021, 10:40 PM
glebius updated the diff for D29729: SMR for TCP hostcache..

Reduce copy-n-paste: macro for hash and tcp_hc_cmp().

Apr 16 2021, 4:31 PM
glebius added inline comments to D29729: SMR for TCP hostcache..
Apr 16 2021, 4:04 PM

Apr 15 2021

glebius committed R10:77a84a305e00: syncache.4: fix mandoc in cb8d7c44d6a (authored by glebius).
syncache.4: fix mandoc in cb8d7c44d6a
Apr 15 2021, 10:51 PM
glebius committed R10:cb8d7c44d6ac: tcp_syncache: add net.inet.tcp.syncache.see_other sysctl (authored by glebius).
tcp_syncache: add net.inet.tcp.syncache.see_other sysctl
Apr 15 2021, 10:28 PM
glebius updated the diff for D29729: SMR for TCP hostcache..

As Mark suggested split tcp_hc_lookup() into lookup-for-read and
lookup-for-write versions, and then inline the latter into tcp_hc_update().

Apr 15 2021, 10:20 PM
glebius updated the diff for D29729: SMR for TCP hostcache..

Use atomic loads when reading hostcache values, as suggested by Mark.

Apr 15 2021, 6:18 PM
glebius updated the diff for D29729: SMR for TCP hostcache..

Address markj@'s comments.

Apr 15 2021, 5:21 PM
glebius added inline comments to D29729: SMR for TCP hostcache..
Apr 15 2021, 5:19 PM

Apr 14 2021

glebius added inline comments to D29729: SMR for TCP hostcache..
Apr 14 2021, 9:23 PM
glebius updated the diff for D29729: SMR for TCP hostcache..

Converted hash buckets to CK_SLIST.

Apr 14 2021, 9:20 PM
glebius accepted D29755: Path MTU discovery hooks for offloaded TCP connections..
Apr 14 2021, 5:55 PM

Apr 13 2021

glebius accepted D29751: Remove reference to the pfctlinput2() from domain(9) after 237c1f932b..
Apr 13 2021, 5:23 PM
glebius added a comment to D29669: pf: Kill connections by schedule.

What are the downsides of using label for that purpose? Does it have any extra functionality except giving a human readable label? If so, killing states by this label is doable. Trying to imagine a situation where we require first label for just human readable label and second label (schedule) for deletion. Why can't the former be used for deletion as well?

Apr 13 2021, 5:22 PM
glebius accepted D29739: TOE: Use a read lock on the PCB for syncache_add()..

P.S. Sorry, always forgetting about Chelsio. :(

Apr 13 2021, 5:15 PM
glebius planned changes to D29729: SMR for TCP hostcache..
Apr 13 2021, 5:14 PM
glebius accepted D29751: Remove reference to the pfctlinput2() from domain(9) after 237c1f932b..

Thanks!

Apr 13 2021, 5:10 PM

Apr 12 2021

glebius added inline comments to D29729: SMR for TCP hostcache..
Apr 12 2021, 7:22 PM
glebius requested review of D29729: SMR for TCP hostcache..
Apr 12 2021, 4:56 PM
glebius committed R10:8d5719aa74f1: syncache: simplify syncache_add() KPI to return struct socket pointer (authored by glebius).
syncache: simplify syncache_add() KPI to return struct socket pointer
Apr 12 2021, 3:29 PM
glebius closed D29576: First take on syn-rlock..
Apr 12 2021, 3:29 PM
glebius committed R10:08d9c9202755: tcp_input/syncache: acquire only read lock on PCB for SYN,!ACK packets (authored by glebius).
tcp_input/syncache: acquire only read lock on PCB for SYN,!ACK packets
Apr 12 2021, 3:29 PM

Apr 11 2021

glebius added a comment to D29669: pf: Kill connections by schedule.

AFAIU, the goal is to distinguish states created by certain rule(s). And in this particular case to kill those states. However, states already reference rules, so internally we can always attribute them. The problem is that pf(4) doesn't have rule numbers and we thus can't specify a rule in pfctl. So this change introduces "rule labels" instead of rule numbers. Btw, why "schedule" and not just "label"? This all makes me think that in future you might want more functionality that would require pointing at particular rules from pfctl or other tool. So, may be this rule specifying functionality needs to be developed in a more generic way, and then provide a control to kill states by rule.

Apr 11 2021, 4:25 PM

Apr 9 2021

glebius committed R10:1a7fe55ab8ca: tcp_hostcache: make THC_LOCK/UNLOCK macros to work with hash head pointer. (authored by glebius).
tcp_hostcache: make THC_LOCK/UNLOCK macros to work with hash head pointer.
Apr 9 2021, 9:22 PM
glebius committed R10:4f49e3382f11: tcp_hostcache: style(9) (authored by glebius).
tcp_hostcache: style(9)
Apr 9 2021, 9:22 PM
glebius committed R10:7c71f3bd6ace: tcp_hostcache: remove extraneous check. (authored by glebius).
tcp_hostcache: remove extraneous check.
Apr 9 2021, 9:22 PM
glebius committed R10:0c25bf7e7c18: tcp_hostcache: implement tcp_hc_updatemtu() via tcp_hc_update. (authored by glebius).
tcp_hostcache: implement tcp_hc_updatemtu() via tcp_hc_update.
Apr 9 2021, 9:22 PM
glebius added a comment to D29663: De-prioritize network driver ithreads to mitigate livelock.

I think this change should be reviewed wider than just to close a problem with LACP. Why do we prioritize servicing interrupts that are triggered by remote agents higher than our own callout routines? Note that NICs, unlike disks, are source of "foreign" interrupts. Also, the nature of network is lossy, while callouts are supposed to be executed in time.

Apr 9 2021, 8:14 PM

Apr 8 2021

glebius requested review of D29576: First take on syn-rlock..
Apr 8 2021, 7:45 PM
glebius added a comment to D29576: First take on syn-rlock..
In D29576#663233, @ae wrote:

I think there is a small window after SCH_UNLOCK() and before syncache_insert() when another threads can do lookup, create entry and come to the same point when it ready to syncache_insert(). And there are no guaranties that they will not do that :)
I seen some strange cases, when packets were delayed for 3 seconds where this looks impossible. And this happened several times on different machines, so this highly depends on the scheduling :)
Another question how it is dangerous for us. I just say, that if we want to change INP_WLOCK to INP_RLOCK, we need to make syncache_lookup() again when we are ready to make syncache_insert() with SCH_LOCK() held. Or rework somehow locking in syncache to avoid this. Or we need to make sure, that syncache duplicates will not lead to worse things.

Apr 8 2021, 7:45 PM
glebius accepted D29644: libpfctl: Switch to pfctl_rule.
Apr 8 2021, 7:40 PM
glebius accepted D29645: libpfctl: Fix u_* counters.
Apr 8 2021, 7:37 PM
glebius accepted D29643: pf: Move prototypes for userspace functions to userspace header.
Apr 8 2021, 7:36 PM
glebius accepted D29641: (t)ftp-proxy: use libpfctl.
Apr 8 2021, 7:34 PM
glebius accepted D29642: bsnmp: Use libpfctl.
Apr 8 2021, 7:34 PM
glebius committed R10:373ffc62c158: tcp_hostcache.c: remove unneeded includes. (authored by glebius).
tcp_hostcache.c: remove unneeded includes.
Apr 8 2021, 5:59 PM
glebius committed R10:29acb543931e: tcp_hostcache: add bool argument for tcp_hc_lookup() to tell are we (authored by glebius).
tcp_hostcache: add bool argument for tcp_hc_lookup() to tell are we
Apr 8 2021, 5:59 PM
glebius committed R10:2cca4c0ee03d: Remove tcp_hostcache.h. Everything is private. (authored by glebius).
Remove tcp_hostcache.h. Everything is private.
Apr 8 2021, 5:59 PM
glebius committed R10:489bde5753d2: tcp_hostcache: hide rmx_hits/rmx_updates under ifdef. (authored by glebius).
tcp_hostcache: hide rmx_hits/rmx_updates under ifdef.
Apr 8 2021, 5:59 PM

Apr 5 2021

glebius planned changes to D29576: First take on syn-rlock..
Apr 5 2021, 11:03 PM
glebius added a comment to D29576: First take on syn-rlock..
In D29576#663233, @ae wrote:

I think there is a small window after SCH_UNLOCK() and before syncache_insert() when another threads can do lookup, create entry and come to the same point when it ready to syncache_insert(). And there are no guaranties that they will not do that :)

Apr 5 2021, 11:03 PM
glebius added inline comments to D29557: pf: Introduce nvlist variant of DIOCADDRULE.
Apr 5 2021, 3:31 PM
glebius added a comment to D29576: First take on syn-rlock..
In D29576#663187, @ae wrote:

Imagine, you have two or more identical SYNs, now you use INP_RLOCK(), this means they all can be handled in parallel "in the same time". This means, syncache_add() in some cases can determine that there are no corresponding entries yet - syncache_lookup() returns NULL, we still hold SCH_LOCK(), then we allocate syncache entry, populate all its fields and do SCH_UNLOCK(). Imagine, now the same things will be done by the another thread, and another. In the end we will have several the same entries added by the syncache_insert().
Is this impossible?

Apr 5 2021, 3:20 PM
glebius added a comment to D29576: First take on syn-rlock..
In D29576#663155, @ae wrote:

I doubt that it is enough to just do s/wlock/rlock/ in the syncache code. Usually we need to add the extra check that an entry was not already linked by another thread in such cases.

Apr 5 2021, 1:18 PM

Apr 4 2021

glebius requested review of D29576: First take on syn-rlock..
Apr 4 2021, 8:48 PM

Mar 19 2021

glebius committed R10:d76f6b8e7389: pfilctl: improve formatting of "hooks" and "heads" command output. (authored by glebius).
pfilctl: improve formatting of "hooks" and "heads" command output.
Mar 19 2021, 6:21 PM

Mar 15 2021

glebius added a comment to D29189: uma: allow uma_zfree_pcu(..., NULL).

They originally were pointers and counter_u64_free(NULL) worked. That was regressed with fb886947d97375ea9906fa1396f83573b6d0674b I think

Mar 15 2021, 8:08 PM
glebius accepted D29216: pf: pool/kpool conversion code.
Mar 15 2021, 8:03 PM
glebius added a comment to D29271: pfsync: Unconditionally push packets when requesting state updates.

I would suggest to change pfsync_request_update() to unconditionally make pfsync_push() on the bucket, regardless of request type (bulk or a single state). This will allow for some batching and shorten stuff executed from the callout context. After this change the call to pfsync_sendout() from the pfsync_request_update() can be changed to 0 in first arguemnt.

Mar 15 2021, 8:02 PM

Mar 9 2021

glebius accepted D29125: kern: malloc: fix panic on M_WAITOK during THREAD_NO_SLEEPING().
Mar 9 2021, 12:14 AM

Feb 26 2021

glebius requested changes to D28645: Remove classful masks from interface addition code..

IMHO, a good sysadmin should always specify mask. And good program should require mask. However, there was historical behavior to guess mask based on classes. Thus, my personal preference list is the following:

Feb 26 2021, 4:56 PM

Feb 8 2021

glebius committed R10:97ded49caef6: Catch up with 6edfd179c86: mechanically rename IFCAP_NOMAP to IFCAP_MEXTPG. (authored by glebius).
Catch up with 6edfd179c86: mechanically rename IFCAP_NOMAP to IFCAP_MEXTPG.
Feb 8 2021, 10:34 PM
glebius committed R10:0ace2cce386a: Catch up with 6edfd179c86: document M_EXTPG. While here sore flags (authored by glebius).
Catch up with 6edfd179c86: document M_EXTPG. While here sore flags
Feb 8 2021, 10:34 PM

Jan 29 2021

glebius committed R10:3f43ada98c89: Catch up with 6edfd179c86: mechanically rename IFCAP_NOMAP to IFCAP_MEXTPG. (authored by glebius).
Catch up with 6edfd179c86: mechanically rename IFCAP_NOMAP to IFCAP_MEXTPG.
Jan 29 2021, 8:10 PM
glebius committed R10:cf6ff85fe847: Catch up with 6edfd179c86: document M_EXTPG. While here sore flags (authored by glebius).
Catch up with 6edfd179c86: document M_EXTPG. While here sore flags
Jan 29 2021, 8:10 PM
glebius accepted D28407: netgraph/ng_source: Switch queuing framework.
Jan 29 2021, 5:33 AM

Jan 21 2021

glebius committed rP562242: Update to 0.2.4. This is a maintainance release to make it properly.
Update to 0.2.4. This is a maintainance release to make it properly
Jan 21 2021, 8:51 PM

Jan 18 2021

glebius added inline comments to D28209: Remove dependency of rc.d/tmp on grep.
Jan 18 2021, 4:34 PM
glebius accepted D28209: Remove dependency of rc.d/tmp on grep.

Stefan, thanks a lot of taking care of my fallout!

Jan 18 2021, 4:32 PM

Jan 15 2021

glebius committed R10:4f48fd7c5677: Add 'tmp' to the list of FILESYSTEMS dependencies. Some scripts that (authored by glebius).
Add 'tmp' to the list of FILESYSTEMS dependencies. Some scripts that
Jan 15 2021, 8:45 PM
glebius closed D28097: include tmpfs mount into FILESYSTEMS.
Jan 15 2021, 8:45 PM
glebius added a reverting change for R10:97ec6eba653a: Brooks pointed out a case where tmp needs to be run after: R10:7e4eca7136ea: Revert 97ec6eba653a07. There shouldn't be a dependency of 'tmp' on.
Jan 15 2021, 8:45 PM
glebius committed R10:7e4eca7136ea: Revert 97ec6eba653a07. There shouldn't be a dependency of 'tmp' on (authored by glebius).
Revert 97ec6eba653a07. There shouldn't be a dependency of 'tmp' on
Jan 15 2021, 8:45 PM

Jan 12 2021

glebius accepted D28074: Refactor if_purgeaddrs()..
Jan 12 2021, 4:32 PM
glebius accepted D28106: Remove redundant rtinit() calls from tuntap..
Jan 12 2021, 4:30 PM

Jan 11 2021

glebius added a reviewer for D28097: include tmpfs mount into FILESYSTEMS: brooks.
Jan 11 2021, 9:04 PM
glebius committed R10:425f68e6ce6f: Follow-up on 51da4b19be1. When booting a system with WITHOUT_IPFILTER (authored by glebius).
Follow-up on 51da4b19be1. When booting a system with WITHOUT_IPFILTER
Jan 11 2021, 8:39 PM
glebius updated the diff for D28097: include tmpfs mount into FILESYSTEMS.
  • Revert 97ec6eba653a07. There shouldn't be a dependency of 'tmp' on
  • Add 'tmp' to the list of FILESYSTEMS dependencies. Some scripts that
Jan 11 2021, 8:16 PM
glebius updated the summary of D28097: include tmpfs mount into FILESYSTEMS.
Jan 11 2021, 7:19 PM
glebius retitled D28097: include tmpfs mount into FILESYSTEMS from Add 'tmp' to the list of FILESYSTEMS dependencies. Some scripts that depend on FILESYSTEMS run mktemp(1). For systems that have read-only root this is broken until memory disk based /tmp is instantiated. At least 'os-release' and 'motd' are... to include tmpfs mount into FILESYSTEMS.
Jan 11 2021, 7:18 PM
glebius requested review of D28097: include tmpfs mount into FILESYSTEMS.
Jan 11 2021, 7:17 PM
glebius committed R10:2903606b6063: Add missing rcvar name for os-release. (authored by glebius).
Add missing rcvar name for os-release.
Jan 11 2021, 4:38 PM

Jan 8 2021

glebius committed R10:7edc1bd9dc17: When be_activate() turns on a new boot environment, it always deactivates (authored by glebius).
When be_activate() turns on a new boot environment, it always deactivates
Jan 8 2021, 5:26 PM

Jan 7 2021

glebius committed rP560726: Update to 1.3.0 with my patches rebased on top..
Update to 1.3.0 with my patches rebased on top.
Jan 7 2021, 7:22 PM

Dec 24 2020

glebius added a comment to D27751: Fix newvers.sh to no longer print an outdated SVN rev.

This may have a slight improvement when compiling from a non-branch point - a detached state. Now

Dec 24 2020, 5:13 PM

Dec 13 2020

glebius committed R9:f16c1075b5dd: Add my author entity. (authored by glebius).
Add my author entity.
Dec 13 2020, 6:44 PM
glebius committed R9:cb5709190750: Add my PGP key. (authored by glebius).
Add my PGP key.
Dec 13 2020, 6:44 PM
glebius committed R9:770cbf398896: Announce myself as a new committer. (authored by glebius).
Announce myself as a new committer.
Dec 13 2020, 6:44 PM
glebius committed R9:2b6d0fac50cc: Move myself from additional contributos to developers. (authored by glebius).
Move myself from additional contributos to developers.
Dec 13 2020, 6:44 PM
glebius committed R9:a28f652d90fb: Express my needs for some notebook parts, which will make my work more (authored by glebius).
Express my needs for some notebook parts, which will make my work more
Dec 13 2020, 6:37 PM
glebius committed R9:12b8dd937a93: Santa Daniel have sent me a new battery and HDD. Thanks! (authored by glebius).
Santa Daniel have sent me a new battery and HDD. Thanks!
Dec 13 2020, 6:35 PM
glebius committed R9:4b13b5d8195f: New Year presents: (authored by glebius).
New Year presents:
Dec 13 2020, 6:34 PM
glebius committed R9:3d25cbfdbd18: I'm seeking for an SMP platform. I don't want anyone to buy it, but I'd be (authored by glebius).
I'm seeking for an SMP platform. I don't want anyone to buy it, but I'd be
Dec 13 2020, 6:34 PM
glebius committed R9:a370fa2233ee: Add item for CARP. (authored by glebius).
Add item for CARP.
Dec 13 2020, 6:33 PM
glebius committed R9:052a576dc600: Add Roselyn Lee to list of additional contributors. Roselyn had sent (authored by glebius).
Add Roselyn Lee to list of additional contributors. Roselyn had sent
Dec 13 2020, 6:32 PM
glebius committed R9:6eb9414992c3: Document __FreeBSD_version 600027: libalias and ng_nat. (authored by glebius).
Document __FreeBSD_version 600027: libalias and ng_nat.
Dec 13 2020, 6:30 PM
glebius committed R9:def5983a378d: I have purchased a very nice SMP box myself. Remove wantlist entry. (authored by glebius).
I have purchased a very nice SMP box myself. Remove wantlist entry.
Dec 13 2020, 6:29 PM
glebius committed R9:9e8ca818520a: Mark branching as done. (authored by glebius).
Mark branching as done.
Dec 13 2020, 6:27 PM
glebius committed R9:7f599dfeb0c3: Since RELENG_6 branching is an important event, add it to news flash. (authored by glebius).
Since RELENG_6 branching is an important event, add it to news flash.
Dec 13 2020, 6:27 PM
glebius committed R9:523d6698b086: I am working on ARP race problem. (authored by glebius).
I am working on ARP race problem.
Dec 13 2020, 6:27 PM
glebius committed R9:08d26dfcaf94: Notice 6.0-BETA1 in news. (authored by glebius).
Notice 6.0-BETA1 in news.
Dec 13 2020, 6:27 PM
glebius committed R9:4e9ef6b33aac: Mark ARP problems as solved. (authored by glebius).
Mark ARP problems as solved.
Dec 13 2020, 6:25 PM
glebius committed R9:3861328c0bc2: Update after local key signing meeting. (authored by glebius).
Update after local key signing meeting.
Dec 13 2020, 6:18 PM