Page MenuHomeFreeBSD

glebius (Gleb Smirnoff)
User

Projects

User Details

User Since
May 28 2014, 2:27 PM (247 w, 14 h)

Recent Activity

Today

glebius updated the diff for D19111: Summary: widen net_epoch coverage up to all packet processing.
  • In pfi_initialize_vnet() rely on IFNET_RLOCK() which is sx(9) for stability of ifnet and ifgroup lists. First allocate enough pfi_kif structs, then enter epoch and attach them.
  • pfi_get_ifaces() NET_EPOCH_ENTER since pfi_skip_if() traverses ifgroup list.
Thu, Feb 21, 12:52 AM

Yesterday

glebius created D19276: Support struct ip_mreqn in IP_ADD_MEMBERSHIP..
Wed, Feb 20, 10:56 PM

Mon, Feb 18

glebius committed rS344269: With r343051 UMA switched from atomic counts to counter(9) and now kernel.
With r343051 UMA switched from atomic counts to counter(9) and now kernel
Mon, Feb 18, 9:27 PM

Fri, Feb 15

glebius committed rS344190: Imaginary cat jumped my keyboard!.
Imaginary cat jumped my keyboard!
Fri, Feb 15, 11:46 PM
glebius committed rS344188: For 32-bit machines rollback the default number of vnode pager pbufs.
For 32-bit machines rollback the default number of vnode pager pbufs
Fri, Feb 15, 11:36 PM
glebius committed rS344139: Merge r343895:.
Merge r343895:
Fri, Feb 15, 12:30 AM

Mon, Feb 11

glebius added a comment to D19111: Summary: widen net_epoch coverage up to all packet processing.

The plan is to not be in epoch during full ifattach/ifclone event since these events have many places that allocate memory. Needs to be more fine grained. I'll ponder more over that.

Mon, Feb 11, 10:39 PM
glebius updated the diff for D19111: Summary: widen net_epoch coverage up to all packet processing.
  • Enter epoch in DAD timer.
  • Revert entering epoch for setsockopt. This needs to be fine grained.
Mon, Feb 11, 8:06 PM

Sat, Feb 9

glebius committed rS343927: Remove remnants of byte order manipulation, back when FreeBSD stack.
Remove remnants of byte order manipulation, back when FreeBSD stack
Sat, Feb 9, 3:00 AM

Fri, Feb 8

glebius committed rS343895: Allow some nesting of ng_iface(4) interfaces and add a configuration knob..
Allow some nesting of ng_iface(4) interfaces and add a configuration knob.
Fri, Feb 8, 6:19 AM

Thu, Feb 7

glebius created D19111: Summary: widen net_epoch coverage up to all packet processing.
Thu, Feb 7, 10:40 PM
glebius accepted D19063: mlx5en: add pfil ethernet hook.
Thu, Feb 7, 10:26 PM
glebius committed rS343858: Now that there is only one way to allocate a slab, remove uz_slab method..
Now that there is only one way to allocate a slab, remove uz_slab method.
Thu, Feb 7, 3:55 AM
glebius committed rS343857: Report cache zones in UMA stats sysctl, that 'vmstat -z' uses. This.
Report cache zones in UMA stats sysctl, that 'vmstat -z' uses. This
Thu, Feb 7, 3:32 AM

Sun, Feb 3

glebius committed rS343707: Teach pfil_ioctl() about VIMAGE..
Teach pfil_ioctl() about VIMAGE.
Sun, Feb 3, 8:28 AM

Sat, Feb 2

glebius committed rS343678: Return PFIL_CONSUMED if packet was consumed. While here gather all.
Return PFIL_CONSUMED if packet was consumed. While here gather all
Sat, Feb 2, 5:49 AM

Fri, Feb 1

glebius committed rS343646: Repair siftr(4): PFIL_IN and PFIL_OUT are defines of some value, relying.
Repair siftr(4): PFIL_IN and PFIL_OUT are defines of some value, relying
Fri, Feb 1, 8:10 AM
glebius committed rS343645: Unbreak call to ipf_check(): it expects the out parameter to be 0 or 1..
Unbreak call to ipf_check(): it expects the out parameter to be 0 or 1.
Fri, Feb 1, 7:48 AM
glebius committed rS343636: Hopefully fix compilation by other compilers..
Hopefully fix compilation by other compilers.
Fri, Feb 1, 12:34 AM
glebius committed rS343635: Fix build without INET6..
Fix build without INET6.
Fri, Feb 1, 12:33 AM

Thu, Jan 31

glebius committed rS343627: Add new m_ext type for data for M_NOFREE mbufs, which doesn't actually do.
Add new m_ext type for data for M_NOFREE mbufs, which doesn't actually do
Thu, Jan 31, 10:37 PM
glebius updated the diff for D18951: New pfil(9).

Rebase on top of r343619.

Thu, Jan 31, 10:31 PM
glebius committed rS343619: Revert r316461: Remove "IPFW static rules" rmlock, and use pfil's global lock..
Revert r316461: Remove "IPFW static rules" rmlock, and use pfil's global lock.
Thu, Jan 31, 9:05 PM
glebius updated the diff for D18951: New pfil(9).
  • Remove "all rights reserved" from new files.
Thu, Jan 31, 8:57 PM
glebius added inline comments to D18951: New pfil(9).
Thu, Jan 31, 8:53 PM
glebius updated the diff for D18951: New pfil(9).
  • Obsolete MLINKS.
  • My copyrights.
Thu, Jan 31, 7:05 PM
glebius updated the diff for D18951: New pfil(9).

This is a rebase.

Thu, Jan 31, 6:23 PM
glebius committed rS343616: In zone_alloc_bucket() max argument was calculated based on uz_count..
In zone_alloc_bucket() max argument was calculated based on uz_count.
Thu, Jan 31, 5:52 PM
glebius updated the diff for D18951: New pfil(9).
  • Address ae@ review, fix multiple mismerges and bugs in ip_fw_pfil.
Thu, Jan 31, 5:22 PM
glebius added inline comments to D18951: New pfil(9).
Thu, Jan 31, 5:19 PM
glebius updated the diff for D18951: New pfil(9).
  • Set max names length to MAXPFILNAME equal to 64.
  • Go through all pfil_run_hooks() and properly compare against PFIL_PASS
Thu, Jan 31, 12:28 AM
glebius added inline comments to D18951: New pfil(9).
Thu, Jan 31, 12:27 AM

Tue, Jan 29

glebius added a comment to D18951: New pfil(9).

Did you happen to do any benchmarking on this? I'd have expected "Sync pfil hooks epoch(9)" to give us a (small) performance improvement, but my initial test shows a small reduction in forwarding performance (with pf loaded).

Tue, Jan 29, 10:45 PM
glebius updated the diff for D18951: New pfil(9).
  • Improve wording. [1]
  • Fix two .Nd present. Since mdoc(7) says that .Nd doesn't accept
Tue, Jan 29, 4:29 PM
glebius accepted D19006: ipfilter #ifdef cleanup.

Very happy to see this.

Tue, Jan 29, 4:28 PM
glebius updated the diff for D18951: New pfil(9).
  • Create /dev/pfil only for the default VNET.
  • Corrections from Mateusz.
  • mandoc -T lint
  • igor
Tue, Jan 29, 2:01 AM
glebius added a comment to D18951: New pfil(9).

This panics during the netipsec and pf regression tests:

Tue, Jan 29, 1:49 AM
glebius added inline comments to D18951: New pfil(9).
Tue, Jan 29, 1:48 AM
glebius added inline comments to D18951: New pfil(9).
Tue, Jan 29, 12:43 AM

Fri, Jan 25

glebius created D18951: New pfil(9).
Fri, Jan 25, 1:13 AM

Thu, Jan 24

glebius accepted D18949: Document that `sendfile` will return an invalid value for `sbytes` if provided an invalid address.
Thu, Jan 24, 11:18 PM
glebius added inline comments to D18949: Document that `sendfile` will return an invalid value for `sbytes` if provided an invalid address.
Thu, Jan 24, 10:33 PM
glebius added a comment to D18623: Address the fact that errors from `copyout(9)` are not properly percolated up on failure.
  1. Remove sbytes from the API.
Thu, Jan 24, 2:44 PM
glebius added a comment to D18623: Address the fact that errors from `copyout(9)` are not properly percolated up on failure.

To be clear, this approach induces a certain amount of pain, and it should not be undertaken unless the benefits are worth it. Some justification based on actual users of sendfile() is needed. If it's not worth it, then this problem is just a wart.

Thu, Jan 24, 2:40 PM

Jan 16 2019

glebius committed rS343101: Fix mistake in r343030: move nswbuf calculation back to.
Fix mistake in r343030: move nswbuf calculation back to
Jan 16 2019, 8:20 PM
glebius committed rS343100: Do not reserve KVA for paging bufs in vm_ksubmap_init(), since now.
Do not reserve KVA for paging bufs in vm_ksubmap_init(), since now
Jan 16 2019, 8:14 PM
glebius committed rS343080: Whitespace..
Whitespace.
Jan 16 2019, 4:02 AM

Jan 15 2019

glebius committed rS343058: Fix compilation failures on different arches that have vm_machdep.c not.
Fix compilation failures on different arches that have vm_machdep.c not
Jan 15 2019, 7:34 PM
glebius committed rS343055: style(9): break long line..
style(9): break long line.
Jan 15 2019, 6:50 PM
glebius committed rS343054: Remove harmless leftover from code that cycles over zone's kegs. Just use +.
Remove harmless leftover from code that cycles over zone's kegs. Just use +
Jan 15 2019, 6:49 PM
glebius committed rS343053: This was missed in r343051: make uz_allocs, uz_frees and uz_fails counter(9)..
This was missed in r343051: make uz_allocs, uz_frees and uz_fails counter(9).
Jan 15 2019, 6:47 PM
glebius committed rS343052: Only do uz_items accounting for zones that have a limit set in uz_max_items..
Only do uz_items accounting for zones that have a limit set in uz_max_items.
Jan 15 2019, 6:32 PM
glebius committed rS343051: Make uz_allocs, uz_frees and uz_fails counter(9). This removes some.
Make uz_allocs, uz_frees and uz_fails counter(9). This removes some
Jan 15 2019, 6:24 PM
glebius committed rS343037: Fix compilation on 32-bit..
Fix compilation on 32-bit.
Jan 15 2019, 3:44 AM
glebius committed rS343031: Remove pbuf(9) manual page that is now nearly 100% outdated..
Remove pbuf(9) manual page that is now nearly 100% outdated.
Jan 15 2019, 1:19 AM
glebius committed rS343030: Allocate pager bufs from UMA instead of 80-ish mutex protected linked list..
Allocate pager bufs from UMA instead of 80-ish mutex protected linked list.
Jan 15 2019, 1:02 AM
glebius committed rS343027: Add flag LK_NEW for lockinit() that is converted to LO_NEW and passed.
Add flag LK_NEW for lockinit() that is converted to LO_NEW and passed
Jan 15 2019, 12:35 AM
glebius committed rS343026: o Move zone limit from keg level up to zone level. This means that now.
o Move zone limit from keg level up to zone level. This means that now
Jan 15 2019, 12:02 AM
glebius closed D17773: UMA limits in zone & more.
Jan 15 2019, 12:02 AM

Jan 14 2019

glebius added inline comments to D17773: UMA limits in zone & more.
Jan 14 2019, 11:42 PM

Jan 11 2019

glebius committed rS342923: Remove recursive NET_EPOCH_ENTER() from sysctl_ifmalist(), missed in r342872..
Remove recursive NET_EPOCH_ENTER() from sysctl_ifmalist(), missed in r342872.
Jan 11 2019, 12:45 AM

Jan 10 2019

glebius committed rS342922: Remove support for FreeBSD 9 kernel, which used to change byte order.
Remove support for FreeBSD 9 kernel, which used to change byte order
Jan 10 2019, 11:27 PM
glebius committed rS342907: Remove unnecessary ifdef. With INVARIANTS all KASSERTs are empty statements,.
Remove unnecessary ifdef. With INVARIANTS all KASSERTs are empty statements,
Jan 10 2019, 12:52 AM
glebius committed rS342906: Bring the comment up to date..
Bring the comment up to date.
Jan 10 2019, 12:37 AM
glebius committed rS342905: Simplify sosetopt() so that function has single return point. No.
Simplify sosetopt() so that function has single return point. No
Jan 10 2019, 12:25 AM

Jan 9 2019

glebius committed rS342877: Timer interval is correctly counted in ticks (1/100 s) in.
Timer interval is correctly counted in ticks (1/100 s) in
Jan 9 2019, 5:54 AM
glebius committed rS342872: Mechanical cleanup of epoch(9) usage in network stack..
Mechanical cleanup of epoch(9) usage in network stack.
Jan 9 2019, 1:11 AM
glebius committed rS342870: Remove part of comment that doesn't match reality..
Remove part of comment that doesn't match reality.
Jan 9 2019, 12:38 AM

Jan 8 2019

glebius committed rP489747: Remove patch that I missed to add to commit index in r489641..
Remove patch that I missed to add to commit index in r489641.
Jan 8 2019, 11:35 PM
glebius committed rP489641: Upgrade minidlna to current snapshot in my repo..
Upgrade minidlna to current snapshot in my repo.
Jan 8 2019, 4:15 AM

Jan 7 2019

glebius committed rS342854: Fix regression in r331368, that broke dumping of UMA startup pages.
Fix regression in r331368, that broke dumping of UMA startup pages
Jan 7 2019, 11:17 PM

Dec 18 2018

glebius committed rS342197: Use mbufq instead of ifqueue to queue mbufs..
Use mbufq instead of ifqueue to queue mbufs.
Dec 18 2018, 7:38 PM

Dec 14 2018

glebius added inline comments to D17773: UMA limits in zone & more.
Dec 14 2018, 9:01 PM

Dec 13 2018

glebius accepted D18535: Allow ng_nat to be attached to a ethernet interface directly via ng_ether(4) and such.

I would like to see a generic code in netgraph that marks hooks with DLT. So, no special messages to be needed, nodes will autosense what's connected to them. However, this is just a wish not a blocker for this change.

Dec 13 2018, 6:55 PM · network
glebius added inline comments to D18535: Allow ng_nat to be attached to a ethernet interface directly via ng_ether(4) and such.
Dec 13 2018, 6:55 PM · network

Dec 7 2018

glebius updated the diff for D17773: UMA limits in zone & more.
  • Move the sleep into zone_alloc_item_locked() and put it into a loop.
Dec 7 2018, 11:04 PM
glebius added a comment to D18426: USE_SOURCEFORGE and first port to use it - net/minidlna.

As said, I'm not seeking for a review & approval so that I commit it. I'm not a ports committer. I'm seeking for a person who can finalize this ugly patch and commit. Thanks!

Dec 7 2018, 10:27 PM

Dec 5 2018

glebius updated the diff for D17773: UMA limits in zone & more.
  • Rewrite uma_zalloc_arg() so that there is a single sleeping point.
Dec 5 2018, 11:39 PM

Dec 4 2018

glebius accepted D17803: Clamp porthash_max to IPPORT_MAX..
Dec 4 2018, 10:08 PM
glebius added inline comments to D17773: UMA limits in zone & more.
Dec 4 2018, 12:37 AM
glebius updated the diff for D17773: UMA limits in zone & more.
  • Improve comment on why uk_lock needs to be first.
Dec 4 2018, 12:26 AM
glebius removed 1 blocking reviewer(s) for D18426: USE_SOURCEFORGE and first port to use it - net/minidlna: portmgr.
Dec 4 2018, 12:23 AM
glebius added inline comments to D17773: UMA limits in zone & more.
Dec 4 2018, 12:23 AM
glebius created D18426: USE_SOURCEFORGE and first port to use it - net/minidlna.
Dec 4 2018, 12:19 AM

Dec 3 2018

glebius updated the diff for D17773: UMA limits in zone & more.

Address Mark's review.

Dec 3 2018, 11:50 PM
glebius added inline comments to D17773: UMA limits in zone & more.
Dec 3 2018, 11:19 PM

Nov 28 2018

glebius accepted D18366: Limit option_len for the TCP_CCALGOOPT option.
Nov 28 2018, 8:08 PM
glebius committed rS341163: Fix yet another edge case in uma_startup_count(). If zone size fits into.
Fix yet another edge case in uma_startup_count(). If zone size fits into
Nov 28 2018, 7:54 PM
glebius committed rS341162: For not offpage zones the slab is placed at the end of page. Keg's uk_pgoff.
For not offpage zones the slab is placed at the end of page. Keg's uk_pgoff
Nov 28 2018, 7:20 PM

Nov 27 2018

glebius added inline comments to D17773: UMA limits in zone & more.
Nov 27 2018, 11:37 PM
glebius added inline comments to D17773: UMA limits in zone & more.
Nov 27 2018, 11:12 PM

Nov 26 2018

glebius updated the diff for D17773: UMA limits in zone & more.
  • Move assertion to beginning of the function.
  • Remove unlock avoidance in uma_zfree_arg(). Can't remember why it was
Nov 26 2018, 9:32 PM
glebius accepted D17994: pfsync: Insert static trace points.

P.S. In pf itself, the dtrace probing should just substitute existing printf(9) debugging.

Nov 26 2018, 8:57 PM
glebius abandoned D1887: Generic code for mbuf(9) queues..

Committed years ago.

Nov 26 2018, 5:01 PM

Nov 14 2018

glebius updated the diff for D17773: UMA limits in zone & more.

Merge remote-tracking branch 'FreeBSD/master' into pbuf to take
in and resolve with recent D16666 check-in.

Nov 14 2018, 8:35 PM
glebius committed rS340443: Initialize compatibility epoch tracker for thread0. Fixes.
Initialize compatibility epoch tracker for thread0. Fixes
Nov 14 2018, 7:10 PM
glebius committed rS340423: Fix build on some architectures after r340413. On amd64 epoch.h.
Fix build on some architectures after r340413. On amd64 epoch.h
Nov 14 2018, 12:33 AM

Nov 13 2018

glebius committed rS340419: style(9), mostly adjusting overly long lines..
style(9), mostly adjusting overly long lines.
Nov 13 2018, 11:57 PM
glebius committed rS340417: With epoch not inlined, there is no point in using _lite KPI. While here,.
With epoch not inlined, there is no point in using _lite KPI. While here,
Nov 13 2018, 11:45 PM
glebius committed rS340416: Plug build break after r340411..
Plug build break after r340411.
Nov 13 2018, 11:44 PM