- User Since
- May 28 2014, 2:27 PM (367 w, 4 d)
May 6 2021
Apr 22 2021
Apr 20 2021
Apr 16 2021
Reduce copy-n-paste: macro for hash and tcp_hc_cmp().
Apr 15 2021
As Mark suggested split tcp_hc_lookup() into lookup-for-read and
lookup-for-write versions, and then inline the latter into tcp_hc_update().
Use atomic loads when reading hostcache values, as suggested by Mark.
Address markj@'s comments.
Apr 14 2021
Converted hash buckets to CK_SLIST.
Apr 13 2021
What are the downsides of using label for that purpose? Does it have any extra functionality except giving a human readable label? If so, killing states by this label is doable. Trying to imagine a situation where we require first label for just human readable label and second label (schedule) for deletion. Why can't the former be used for deletion as well?
P.S. Sorry, always forgetting about Chelsio. :(
Apr 12 2021
Apr 11 2021
AFAIU, the goal is to distinguish states created by certain rule(s). And in this particular case to kill those states. However, states already reference rules, so internally we can always attribute them. The problem is that pf(4) doesn't have rule numbers and we thus can't specify a rule in pfctl. So this change introduces "rule labels" instead of rule numbers. Btw, why "schedule" and not just "label"? This all makes me think that in future you might want more functionality that would require pointing at particular rules from pfctl or other tool. So, may be this rule specifying functionality needs to be developed in a more generic way, and then provide a control to kill states by rule.
Apr 9 2021
I think this change should be reviewed wider than just to close a problem with LACP. Why do we prioritize servicing interrupts that are triggered by remote agents higher than our own callout routines? Note that NICs, unlike disks, are source of "foreign" interrupts. Also, the nature of network is lossy, while callouts are supposed to be executed in time.
Apr 8 2021
Apr 5 2021
Apr 4 2021
Mar 19 2021
Mar 15 2021
They originally were pointers and counter_u64_free(NULL) worked. That was regressed with fb886947d97375ea9906fa1396f83573b6d0674b I think
I would suggest to change pfsync_request_update() to unconditionally make pfsync_push() on the bucket, regardless of request type (bulk or a single state). This will allow for some batching and shorten stuff executed from the callout context. After this change the call to pfsync_sendout() from the pfsync_request_update() can be changed to 0 in first arguemnt.
Mar 9 2021
Feb 26 2021
IMHO, a good sysadmin should always specify mask. And good program should require mask. However, there was historical behavior to guess mask based on classes. Thus, my personal preference list is the following:
Feb 8 2021
Jan 29 2021
Jan 21 2021
Jan 18 2021
Stefan, thanks a lot of taking care of my fallout!
Jan 15 2021
Jan 12 2021
Jan 11 2021
- Revert 97ec6eba653a07. There shouldn't be a dependency of 'tmp' on
- Add 'tmp' to the list of FILESYSTEMS dependencies. Some scripts that
Jan 8 2021
Jan 7 2021
Dec 24 2020
This may have a slight improvement when compiling from a non-branch point - a detached state. Now