Page MenuHomeFreeBSD

glebius (Gleb Smirnoff)
User

Projects

User Details

User Since
May 28 2014, 2:27 PM (236 w, 4 d)

Recent Activity

Fri, Dec 7

glebius updated the diff for D17773: UMA limits in zone & more.
  • Move the sleep into zone_alloc_item_locked() and put it into a loop.
Fri, Dec 7, 11:04 PM
glebius added a comment to D18426: USE_SOURCEFORGE and first port to use it - net/minidlna.

As said, I'm not seeking for a review & approval so that I commit it. I'm not a ports committer. I'm seeking for a person who can finalize this ugly patch and commit. Thanks!

Fri, Dec 7, 10:27 PM

Wed, Dec 5

glebius updated the diff for D17773: UMA limits in zone & more.
  • Rewrite uma_zalloc_arg() so that there is a single sleeping point.
Wed, Dec 5, 11:39 PM

Tue, Dec 4

glebius accepted D17803: Clamp porthash_max to IPPORT_MAX..
Tue, Dec 4, 10:08 PM
glebius added inline comments to D17773: UMA limits in zone & more.
Tue, Dec 4, 12:37 AM
glebius updated the diff for D17773: UMA limits in zone & more.
  • Improve comment on why uk_lock needs to be first.
Tue, Dec 4, 12:26 AM
glebius removed 1 blocking reviewer(s) for D18426: USE_SOURCEFORGE and first port to use it - net/minidlna: portmgr.
Tue, Dec 4, 12:23 AM
glebius added inline comments to D17773: UMA limits in zone & more.
Tue, Dec 4, 12:23 AM
glebius created D18426: USE_SOURCEFORGE and first port to use it - net/minidlna.
Tue, Dec 4, 12:19 AM

Mon, Dec 3

glebius updated the diff for D17773: UMA limits in zone & more.

Address Mark's review.

Mon, Dec 3, 11:50 PM
glebius added inline comments to D17773: UMA limits in zone & more.
Mon, Dec 3, 11:19 PM

Wed, Nov 28

glebius accepted D18366: Limit option_len for the TCP_CCALGOOPT option.
Wed, Nov 28, 8:08 PM
glebius committed rS341163: Fix yet another edge case in uma_startup_count(). If zone size fits into.
Fix yet another edge case in uma_startup_count(). If zone size fits into
Wed, Nov 28, 7:54 PM
glebius committed rS341162: For not offpage zones the slab is placed at the end of page. Keg's uk_pgoff.
For not offpage zones the slab is placed at the end of page. Keg's uk_pgoff
Wed, Nov 28, 7:20 PM

Tue, Nov 27

glebius added inline comments to D17773: UMA limits in zone & more.
Tue, Nov 27, 11:37 PM
glebius added inline comments to D17773: UMA limits in zone & more.
Tue, Nov 27, 11:12 PM

Mon, Nov 26

glebius updated the diff for D17773: UMA limits in zone & more.
  • Move assertion to beginning of the function.
  • Remove unlock avoidance in uma_zfree_arg(). Can't remember why it was
Mon, Nov 26, 9:32 PM
glebius accepted D17994: pfsync: Insert static trace points.

P.S. In pf itself, the dtrace probing should just substitute existing printf(9) debugging.

Mon, Nov 26, 8:57 PM
glebius abandoned D1887: Generic code for mbuf(9) queues..

Committed years ago.

Mon, Nov 26, 5:01 PM

Wed, Nov 14

glebius updated the diff for D17773: UMA limits in zone & more.

Merge remote-tracking branch 'FreeBSD/master' into pbuf to take
in and resolve with recent D16666 check-in.

Wed, Nov 14, 8:35 PM
glebius committed rS340443: Initialize compatibility epoch tracker for thread0. Fixes.
Initialize compatibility epoch tracker for thread0. Fixes
Wed, Nov 14, 7:10 PM
glebius committed rS340423: Fix build on some architectures after r340413. On amd64 epoch.h.
Fix build on some architectures after r340413. On amd64 epoch.h
Wed, Nov 14, 12:33 AM

Tue, Nov 13

glebius committed rS340419: style(9), mostly adjusting overly long lines..
style(9), mostly adjusting overly long lines.
Tue, Nov 13, 11:57 PM
glebius committed rS340417: With epoch not inlined, there is no point in using _lite KPI. While here,.
With epoch not inlined, there is no point in using _lite KPI. While here,
Tue, Nov 13, 11:45 PM
glebius committed rS340416: Plug build break after r340411..
Plug build break after r340411.
Tue, Nov 13, 11:44 PM
glebius committed rS340415: The dualism between epoch_tracker and epoch_thread is fragile and.
The dualism between epoch_tracker and epoch_thread is fragile and
Tue, Nov 13, 11:21 PM
glebius committed rS340413: For compatibility KPI functions like if_addr_rlock() that used to have.
For compatibility KPI functions like if_addr_rlock() that used to have
Tue, Nov 13, 10:58 PM
glebius committed rS340404: Uninline epoch(9) entrance and exit. There is no proof that modern.
Uninline epoch(9) entrance and exit. There is no proof that modern
Tue, Nov 13, 7:02 PM
glebius closed D17879: First part of D17787:.
Tue, Nov 13, 7:02 PM
glebius accepted D17922: More IPv4 fragment checks.
Tue, Nov 13, 12:36 AM

Nov 7 2018

glebius added inline comments to D17879: First part of D17787:.
Nov 7 2018, 9:23 PM

Nov 6 2018

glebius created D17879: First part of D17787:.
Nov 6 2018, 11:17 PM

Oct 31 2018

glebius committed rS339976: MFhead r339643:.
MFhead r339643:
Oct 31 2018, 11:06 PM
glebius committed rS339975: MFhead r339643:.
MFhead r339643:
Oct 31 2018, 11:03 PM
glebius created D17787: While debugging some epoch related races at Netflix, we discoveredfew non fundamental, but annoying issues with epoch.First, the inlining makes it difficult to profile and trace epoch.At the same time, inlining doesn't effectively happens. In....
Oct 31 2018, 10:55 PM
glebius committed rS339970: Remove unnecessary include from libstand..
Remove unnecessary include from libstand.
Oct 31 2018, 7:59 PM
glebius committed rS339969: Define QMD_SAVELINK() only for QUEUE_MACRO_DEBUG_TRASH case. Otherwise.
Define QMD_SAVELINK() only for QUEUE_MACRO_DEBUG_TRASH case. Otherwise
Oct 31 2018, 7:37 PM
glebius committed rS339963: MFhead r339596:.
MFhead r339596:
Oct 31 2018, 6:01 PM

Oct 30 2018

glebius created D17773: UMA limits in zone & more.
Oct 30 2018, 11:56 PM
glebius added a comment to D16666: Add some accounting to the per-domain full bucket caches..

My current patchset for UMA has something similar. I also have zone_put_bucket() although named differently, to keep accounting of all items for a zone in buckets. So this change goes in line with my changes. At Netflix we also run the vm_page_cache zone with certain bucket limit, instead of no buckets at all.

Oct 30 2018, 8:16 PM
glebius added a comment to D17505: pfsync: Allow module to be unloaded.

I'm not absolutely sure that all possible races are fixed. There still could be dangling ifnet pointers. But that's up to your justification. If you are sure everything is covered, feel free to remove.

Oct 30 2018, 8:05 PM
glebius accepted D17502: pfsync: Handle syncdev going away.
Oct 30 2018, 8:02 PM
glebius requested changes to D16769: Remove AppleTalk protocols from services(5).

Doesn't make sense to remove it from services(5) database. It isn't a database of protocols FreeBSD supports. It is just database of port numbers that are well known.

Oct 30 2018, 7:59 PM
glebius requested changes to D17665: Ensure mbuf send tags don't trigger on ifnets.

This is extremely hacky. The only proper fix is to find situations when rcvif isn't cleared for a packet that is reused for transmit and fix them.

Oct 30 2018, 7:56 PM

Oct 29 2018

glebius committed rS339889: Add a note that epoch(9) may change, to untie our hands for any future MFCs..
Add a note that epoch(9) may change, to untie our hands for any future MFCs.
Oct 29 2018, 10:11 PM

Oct 24 2018

glebius committed rS339695: Remove code that is dead since r287197. Today wlan(4) interfaces aren't.
Remove code that is dead since r287197. Today wlan(4) interfaces aren't
Oct 24 2018, 8:50 PM

Oct 23 2018

glebius committed rS339643: Fix ipw_start(), where logic was reverted in r287197..
Fix ipw_start(), where logic was reverted in r287197.
Oct 23 2018, 12:53 PM

Oct 22 2018

glebius committed rS339596: If we lost race or were migrated during bucket allocation for the per-CPU.
If we lost race or were migrated during bucket allocation for the per-CPU
Oct 22 2018, 3:48 PM

Oct 21 2018

glebius committed rS339532: Fix exiting an epoch(9) we never entered. May happen only with MAC..
Fix exiting an epoch(9) we never entered. May happen only with MAC.
Oct 21 2018, 12:39 PM

Oct 18 2018

glebius accepted D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.
Oct 18 2018, 6:18 PM
glebius added a comment to D17595: Fix handling of RST segments in SYN-RCVD state via the syn cache code path.

syncache_chkrst() isn't a public function, so no worries on KBI.

Oct 18 2018, 6:14 PM

Oct 16 2018

glebius committed rS339379: Plug sendfile(2) on a listening socket with proper error code..
Plug sendfile(2) on a listening socket with proper error code.
Oct 16 2018, 3:57 PM

Oct 15 2018

glebius committed rS339370: Avoid OOB reads in memmem(3)..
Avoid OOB reads in memmem(3).
Oct 15 2018, 8:21 PM

Oct 3 2018

glebius committed rS339170: In PR 227259, a user is reporting that they have code which is using.
In PR 227259, a user is reporting that they have code which is using
Oct 3 2018, 5:40 PM
glebius closed D15019: Wakup applications with shutdown on listen sockets.
Oct 3 2018, 5:40 PM

Sep 6 2018

glebius added a comment to D17062: Cleanup unused inpcb fields/flags.

Since struct inpcb is no longer exported to the userland, the spare field can be removed.

Sep 6 2018, 11:29 PM

Aug 31 2018

glebius committed rP478606: Unbreak nVidia drivers on recent -CURRENT, after change to.
Unbreak nVidia drivers on recent -CURRENT, after change to
Aug 31 2018, 7:45 PM

Aug 24 2018

glebius committed rS338302: Either "free" or "allocated" is misleading here, since an item.
Either "free" or "allocated" is misleading here, since an item
Aug 24 2018, 6:48 PM

Aug 23 2018

glebius committed rS338284: Fix comment. The actual meaning of ub_cnt is the opposite..
Fix comment. The actual meaning of ub_cnt is the opposite.
Aug 23 2018, 11:24 PM

Aug 21 2018

glebius committed rP477761: Unbreak nVidia drivers on recent -CURRENT, after change to.
Unbreak nVidia drivers on recent -CURRENT, after change to
Aug 21 2018, 10:59 PM

Aug 4 2018

glebius committed rS337279: Now that after r335979 the kernel addresses in API structures are.
Now that after r335979 the kernel addresses in API structures are
Aug 4 2018, 12:03 AM

Aug 3 2018

glebius committed rS337278: Use if_tunnel_check_nesting() for ng_iface(4)..
Use if_tunnel_check_nesting() for ng_iface(4).
Aug 3 2018, 10:56 PM

Jun 27 2018

glebius committed rS335749: Check the inp_flags under inp lock. Looks like the race was hidden.
Check the inp_flags under inp lock. Looks like the race was hidden
Jun 27 2018, 10:02 PM
glebius committed rS335748: Correct r335242. Use unsigned cast instead of abs(). Using abs() gives.
Correct r335242. Use unsigned cast instead of abs(). Using abs() gives
Jun 27 2018, 10:01 PM

Jun 23 2018

glebius committed rS335577: Revert r334843, and partially revert r335180..
Revert r334843, and partially revert r335180.
Jun 23 2018, 6:54 AM

Jun 15 2018

glebius committed rS335242: Since 'ticks' is an int, it may wrap around and cr_ticks at a certain.
Since 'ticks' is an int, it may wrap around and cr_ticks at a certain
Jun 15 2018, 9:36 PM

Jun 14 2018

glebius committed rS335180: TCPOUTFLAGS no longer exists since r334843..
TCPOUTFLAGS no longer exists since r334843.
Jun 14 2018, 10:25 PM

Jun 8 2018

glebius committed rS334819: UMA memory debugging enabled with INVARIANTS consists of two things:.
UMA memory debugging enabled with INVARIANTS consists of two things:
Jun 8 2018, 12:15 AM
glebius closed D15199: Add possibility to disable or reduce amount of UMA debugging with INVARIANTS.
Jun 8 2018, 12:15 AM

Jun 7 2018

glebius committed rS334817: Add new functionality and syntax to cron(1) to allow to run jobs at a.
Add new functionality and syntax to cron(1) to allow to run jobs at a
Jun 7 2018, 10:38 PM
glebius committed rP471942: Fix the fetch URL..
Fix the fetch URL.
Jun 7 2018, 6:32 PM

May 29 2018

glebius committed rS334356: Revert second chunk of r333860. The warning from gcc is false positive. The.
Revert second chunk of r333860. The warning from gcc is false positive. The
May 29 2018, 9:45 PM

May 24 2018

glebius updated the diff for D14980: pathconf(_PC_MEDIA) - an API to tell the media at a given path.

Update patch wrt newer head.

May 24 2018, 8:31 PM

May 14 2018

glebius added a comment to D15019: Wakup applications with shutdown on listen sockets.

It is on my queue. The plan is to use so_error for this mark, instead of SS_ISDISCONNECTING.

May 14 2018, 4:11 PM
glebius added a comment to D15199: Add possibility to disable or reduce amount of UMA debugging with INVARIANTS.

Hey guys, I know that ifdefs suck, but still going to forward with checking this in. If you can suggest some change to ifdefs, I am open to that. E.g. keep them minimal, so there is no duplication between debug and !debug case. Or you may prefer to keep the maximal, so that code is more readable. I can do either, but I'd like to get forward with this change.

May 14 2018, 4:10 PM

May 1 2018

glebius added inline comments to D15199: Add possibility to disable or reduce amount of UMA debugging with INVARIANTS.
May 1 2018, 9:09 PM

Apr 27 2018

glebius added a comment to D15199: Add possibility to disable or reduce amount of UMA debugging with INVARIANTS.

I think all of these inline ifdefs make the code a lot harder to read. Could we instead introduce wrapper functions for the ctor and dtor and hide the logic there?

Apr 27 2018, 5:51 PM

Apr 26 2018

glebius added inline comments to D15199: Add possibility to disable or reduce amount of UMA debugging with INVARIANTS.
Apr 26 2018, 8:46 PM

Apr 25 2018

glebius created D15199: Add possibility to disable or reduce amount of UMA debugging with INVARIANTS.
Apr 25 2018, 5:03 PM

Apr 19 2018

glebius added a comment to D15112: In snmp_mibII module assume that virtual interfaces can work at maximum speed available in the system.

I did not do this in the past because it was not possible to add or increment 64-bit counters atomically. Did this change? Instead of providing bad values I decided to follow the words of the RFC.

Apr 19 2018, 9:32 PM
glebius updated the summary of D14980: pathconf(_PC_MEDIA) - an API to tell the media at a given path.
Apr 19 2018, 9:20 PM

Apr 16 2018

glebius committed rS332572: Merge r331871:.
Merge r331871:
Apr 16 2018, 3:07 PM

Apr 12 2018

glebius added a comment to D14980: pathconf(_PC_MEDIA) - an API to tell the media at a given path.
In D14980#316840, @mav wrote:

Is this API and device classification exist somewhere else, or being just designed? Differentiation between STRIPE, MIRROR and RAID sound somewhat odd to me, same as between SPINNING and CDROM. Besides it duplicates "GEOM::rotation_rate" attribute, we already have and use in some places (though obviously it is not passed through UFS).

Apr 12 2018, 9:18 PM
glebius accepted D15046: Make lagg creation more fault tolerant.
Apr 12 2018, 9:12 PM

Apr 11 2018

glebius updated the diff for D14980: pathconf(_PC_MEDIA) - an API to tell the media at a given path.
  • Support vnode backed md(4).
  • Bump disk version.
Apr 11 2018, 12:09 AM
glebius added inline comments to D14980: pathconf(_PC_MEDIA) - an API to tell the media at a given path.
Apr 11 2018, 12:01 AM

Apr 10 2018

glebius updated the diff for D14980: pathconf(_PC_MEDIA) - an API to tell the media at a given path.

Instead of using strcmp() augment struct disk with media info.

Apr 10 2018, 8:16 PM

Apr 5 2018

glebius added a comment to D14980: pathconf(_PC_MEDIA) - an API to tell the media at a given path.
# df
Filesystem        1K-blocks       Used     Avail Capacity  Mounted on
/dev/mirror/prim    3095920    1129672   1718576    40%    /
/dev/md5            5061628         24   5061604     0%    /var/svm
/dev/nda1p8      3585929296 3084809040 214245920    94%    /usr/local/www/2
/dev/mirror/logs   51581936    8159504  39295880    17%    /var/log
/dev/ada0p8       897802144  745401144  80576832    90%    /usr/local/www/a
/dev/da16p1      7691453560 6677369072 398768208    94%    /usr/local/www/12
# ./pathconf-media /usr/local/www/12
/usr/local/www/12=2001<SPINNING,SCSI>
# ./pathconf-media /usr/local/www/a
/usr/local/www/a=1002<SOLID,ATA>
# ./pathconf-media /var/log/
/var/log/=11002<SOLID,ATA,MIRROR>
# ./pathconf-media /usr/local/www/2
/usr/local/www/2=2<SOLID>
# ./pathconf-media /var/svm/
/var/svm/=8<MEMORY>
# ./pathconf-media /
/=10002<SOLID,MIRROR>
Apr 5 2018, 10:04 PM
glebius created D14980: pathconf(_PC_MEDIA) - an API to tell the media at a given path.
Apr 5 2018, 9:31 PM

Apr 4 2018

glebius added inline comments to D14893: VM page queue batching.
Apr 4 2018, 7:24 PM

Apr 3 2018

glebius committed rS331932: Indentation fixups. No functional changes..
Indentation fixups. No functional changes.
Apr 3 2018, 6:33 PM

Apr 2 2018

glebius committed rS331873: Use UMA_SLAB_SPACE macro. No functional change here..
Use UMA_SLAB_SPACE macro. No functional change here.
Apr 2 2018, 5:15 AM
glebius committed rS331872: In uma_startup_count() handle special case when zone will fit into.
In uma_startup_count() handle special case when zone will fit into
Apr 2 2018, 5:14 AM
glebius committed rS331871: Handle a special case when a slab can fit only one allocation,.
Handle a special case when a slab can fit only one allocation,
Apr 2 2018, 5:12 AM

Mar 22 2018

glebius committed rS331344: Redo r331328. We need to fix not only type but also format. While.
Redo r331328. We need to fix not only type but also format. While
Mar 22 2018, 5:26 AM
glebius committed rS331343: Fix LINT-NOINET build initializing local to false. This is.
Fix LINT-NOINET build initializing local to false. This is
Mar 22 2018, 5:08 AM

Mar 21 2018

glebius committed rS331328: Fix sysctl types broken in r329612..
Fix sysctl types broken in r329612.
Mar 21 2018, 11:21 PM
glebius committed rS331322: The net.inet.tcp.nolocaltimewait=1 optimization prevents local TCP connections.
The net.inet.tcp.nolocaltimewait=1 optimization prevents local TCP connections
Mar 21 2018, 8:59 PM
glebius closed D14697: Send a final ACK to local connections (version 2).
Mar 21 2018, 8:59 PM

Mar 20 2018

glebius committed rS331272: At this point iwmesg isn't initialized yet, so print pointer to lock.
At this point iwmesg isn't initialized yet, so print pointer to lock
Mar 20 2018, 10:05 PM