User Details
- User Since
- May 28 2014, 2:27 PM (581 w, 1 h)
Today
Yesterday
Mon, Jul 14
Please include the link to the exp-run bugzilla into the commit message.
Fri, Jul 11
Add missing 'break;'. We aren't using _SAFE iterator here, and we don't
expect any more matches.
As Alexander noted, a single label doesn't store information about the
entire pool, but only about one top-level vdev. Thus, we should blow
away only this part of the vdev tree, not entire tree.
Thu, Jul 10
All this hardware TLS assist is a crazy layer violation. But this is a wave a can't stand against.
Wed, Jul 9
I can't say that I am happy with this change, sorry. But looks like you need it, so let it be so.
Works as a panic prevention :)
Fri, Jun 27
Make mktemp+bind optional only for the SOCK_STREAM case.
Thanks! Didn't know this page exists.
Note: the binding is actually needed when we run in SOCK_DGRAM mode. So this isn't a final revision.
Thu, Jun 26
Note: 4 more reviews stacked on top of this one, if anyone interested.
We could also use SYSCTL_PROC() instead of SYSCTL_BOOL() and then add gone_in() to emphasis that the sysctl-variable is deprecated. Just let me know if this is wanted.
We will sort out how to correctly put #error later.
Wed, Jun 25
I am really puzzled how D34550 was created and how did it pass your review :)
Tue, Jun 24
Agreed, let's try 495 and see what CI reports after a week.
Mon, Jun 23
No objection from me. Thanks for the change and sorry for the delay. But please wait for the stabweek closure.
Thanks!
Thanks, @imp! What if instead of allowing the header but masking its internals, we want to eliminate any use of a header by userland applications? Some headers have #error no user serviceable parts inside and AFAIU all of them are listed in badfiles.inc. Is this the way to go?
Sat, Jun 21
What is the problem we are trying to fix here? What is the panic trace?
I clicked on "Accept", trusting your expertise. The change looks correct, with small comment nit. But I didn't test it. And to be fair the gist of the code already washed out of my L3 brain cache :)
Fri, Jun 20
Thu, Jun 19
Wed, Jun 18
There is no #warning or #error in case the header file is not included in the kernel context, since then this header file would need to be added to tools/build/test-includes/badfiles.inc, but that list should not grow.
Tue, Jun 17
Manual page counter.9 also needs to be updated.
I totally agree with the period feature. Thanks!
bsnmpd done. We can put the entire header under _KERNEL. We also can add #error in there to catch all incorrect inclusions of this header.
- Don't forget rack/bbr.
- Document the new sysctl and improve paragraph.