User Details
- User Since
- May 28 2014, 2:27 PM (651 w, 3 h)
Yesterday
Mon, Nov 16
Sat, Nov 14
Fri, Nov 13
I always assumed that this already happens for any LRO.
Thu, Nov 12
I would suggest to enable this by default. What are our potential pitfalls?
Thanks! I don't think such trivial changes need review process.
P.S. AFAIK the ubiquitous use of signed integers for unsigned entities that we inherited from 4.3BSD comes from late Bruce Evans. He always insisted that at machine level everything is signed, that's why. I never fully bought this point. It seems to me that by today standards all software development norms is that use unsigned types for unsigned entities. And even a very smart man can be wrong sometimes. Thus, we should do sweeping changes to get rid of this heritage. Any other opinions?
Provide hw.bus.devctl_maxrecord.
Tue, Nov 10
Use MSG_WAITALL. Not really important for this devd client, but just
follow the suggested practice.
Mon, Nov 9
- Rebase it over official #define for the socket path and sysconf() value
Fri, Nov 6
Please check if this fixes flakyness of tests/sys/net/bpf:inject in presence of RSS and if it does, please remove the check there.
Thanks! I would suggest to split into two commits, since two changes are related but actually different and they also live in different chunks. No reason to squash them.
Mon, Nov 2
- Limit size of iflib's if_rxd_info.
- Remove the test.
- Hide hash macros/functions from userland.
Thanks! I'm a bit lost in the branches there. What branches do include changes that you post here on reviews.f.o?
@inquire_JohnEricson.me do you have a public git repo with your changes? Checked out https://github.com/Ericson2314 already. Is that yours? But no freebsd clone repos found there.
Sat, Oct 31
I agree that of by one needs to be fixed. Suggesting both your fix and fix to sysctl handler, so that invalid range is refused.
Fri, Oct 30
Looks correct! Don't feel myself expert enough to approve.
Looks correct. Not an expert here, though.
Looks like this review was open for about 4 hours.
AFAIK, the random port allocation can't be really considered a security feature against connection forging these days. An attacker can just inject 50k packets in a millisecond. However, the random port allocation is still useful to avoid revealing information on how many connections a host makes. For the latter purpose a cheaper random is fine.
IMHO, it would be better to cover invalid sysctl setting in sysctl_net_ipport_check().
IMHO, more review is needed here. This is a system header that is installed in /usr/include. We should check if other common APIs exist or not for this operation. Does it match existing operations that we already define there?
Thu, Oct 29
- Implement M_HASHTYPE_ISHASH(m) macro with M_HASHTYPE_GET() macro
Fixups from Michael.
It doesn't apply cause it depends on D60968.
@inquire_JohnEricson.me can you please review my suggestions and update the change, or if you 100% agree just express your agreement to push the change together with my suggestions?
@markj can you please repost the review feedback you posted as reply to commit email?
The one thing I don't understand is the duality between M_HASHTYPE_OPAQUE and M_HASHTYPE_OPAQUE_HASH. I removed this duality as I don't see any sense in it.
Thu, Oct 22
Ok, migrating to github, given there is a history there and today PHP had a bad day :) In general, using reviews.freebsd.org is preferred over github.
Oops, screwed up. Thanks for the fix!
Tue, Oct 20
Mon, Oct 19
Is the VNET change related to the TCP changes? Are TCP changes related at all?
We are in the late testing stages of this patch. I'd like to push it before stabweek Monday. Tag @markj if you want to take an extra look.
