Page MenuHomeFreeBSD
Differential D57171

netlink: Check for NULL return from npt_alloc()
ClosedPublic
Actions

Authored by emaste on May 22 2026, 2:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 5, 1:13 AM
Unknown Object (File)
Sat, Jul 4, 3:20 AM
Unknown Object (File)
Thu, Jul 2, 1:28 AM
Unknown Object (File)
Wed, Jul 1, 7:57 PM
Unknown Object (File)
Thu, Jun 25, 6:21 PM
Unknown Object (File)
Tue, Jun 23, 4:23 PM
Unknown Object (File)
Jun 9 2026, 2:23 PM
Unknown Object (File)
Jun 9 2026, 2:19 PM
View All 28 Files
Subscribers
glebius
imp
melifaro

Details

Reviewers
melifaro
glebius
pouria
Group Reviewers
network
Commits
rGe22716b6cbfc: netlink: Check for NULL return from npt_alloc()
rG1dbc10414884: netlink: Check for NULL return from npt_alloc()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.May 22 2026, 2:42 PM
Herald added a reviewer: melifaro. · View Herald TranscriptMay 22 2026, 2:42 PM
Herald added subscribers: glebius, melifaro. · View Herald Transcript
emaste requested review of this revision.May 22 2026, 2:42 PM
emaste added a reviewer: network.May 22 2026, 2:46 PM

Not quite sure what we should do w/ the void fns (if we should make them return error)? nlmsg_report_cookie_u32() has no callers.

glebius accepted this revision as: glebius.May 22 2026, 6:21 PM
This revision is now accepted and ready to land.May 22 2026, 6:21 PM
pouria accepted this revision as: pouria.May 22 2026, 6:35 PM
Closed by commit rG1dbc10414884: netlink: Check for NULL return from npt_alloc() (authored by emaste). · Explain WhyMay 23 2026, 4:23 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG1dbc10414884: netlink: Check for NULL return from npt_alloc().
Herald added a subscriber: imp. · View Herald TranscriptMay 23 2026, 4:23 PM
pouria mentioned this in D56964: rtnetlink: Check for allocation failure in create_nexthop_from_attrs().Jun 5 2026, 11:21 AM
pouria mentioned this in D56965: rtnetlink: Check for allocation failure in _nl_store_ifp_cookie().
emaste added a commit: rGe22716b6cbfc: netlink: Check for NULL return from npt_alloc().Jun 9 2026, 2:10 PM

Revision Contents
Changeset List

PathSize
sys/
netlink/
2 lines
route/
3 lines
4 lines

Diff 178482

View Options

sys/netlink/netlink_message_parser.c

Loading...
View Options

sys/netlink/route/iface_drivers.c

Loading...
View Options

sys/netlink/route/rt.c

Loading...