rtnetlink: Check for allocation failure in _nl_store_ifp_cookie()
AbandonedPublic
Actions

Authored by pouria on May 12 2026, 12:40 PM.

Details

Reviewers

markj
glebius
melifaro

Group Reviewers

network

Summary

Almost impossible to happen, but if it does, just report nothing.

MFC after: 3 days

Test Plan

Follow up D56954

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 73013
Build 69896: arc lint + arc unit

Event Timeline

pouria created this revision.May 12 2026, 12:40 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 12 2026, 12:40 PM

pouria requested review of this revision.May 12 2026, 12:40 PM

Harbormaster completed remote builds in B73013: Diff 177636.May 12 2026, 12:40 PM

Hmm, if we think it's impossible, then probably it's better to just assume nla_cookie != NULL rather than silently doing nothing? Otherwise we should probably report the error back to create_link(), no?

In D56965#1305148, @markj wrote:

Hmm, if we think it's impossible, then probably it's better to just assume nla_cookie != NULL rather than silently doing nothing? Otherwise we should probably report the error back to create_link(), no?

It's absolutely safe to assume nla_cookie != NULL.
Unless someone else touches this code and forgets about the null check.
We can leave it as is.

D57171

Revision Contents
Changeset List

Path

Size

sys/

netlink/

route/

iface_drivers.c

2 lines

Diff 177636

View Options

sys/netlink/route/iface_drivers.c

rtnetlink: Check for allocation failure in _nl_store_ifp_cookie()AbandonedPublicActions