Page MenuHomeFreeBSD

pouria (Pouria Mousavizadeh Tehrani)
Pouria

Projects

User Details

User Since
Aug 26 2022, 6:24 PM (180 w, 2 d)

Recent Activity

Yesterday

pouria updated the diff for D54443: if_gre: Add netlink support with tests.

add nl_parsed_gre to test file.

Sun, Feb 8, 7:18 PM
pouria accepted D55138: Switch net.inet6.ip6.use_stableaddr to on by default.
Sun, Feb 8, 4:46 PM
pouria updated the diff for D54443: if_gre: Add netlink support with tests.

Make nl_parsed_gre private.
@zlei done.
After doing my research, If find out you were right.
Dictating netlink data structure to userland defeats
the purpose of using netlink in first place.

Sun, Feb 8, 4:42 PM
pouria updated the summary of D54172: Add Support for Geneve (RFC8926).
Sun, Feb 8, 4:25 PM
pouria updated the diff for D54172: Add Support for Geneve (RFC8926).

Rebase geneve to main and limit this revision kernel only.
ifconfig netlink helper: D55174
ifconfig geneve implementation (netlink): D55184
ifconfig geneve implementation (without netlink): D55185
ifconfig(8) manual for geneve: D55181
geneve(4) manual: D55182
geneve tests: D55183
update geneve to follow RFC 6040: D55186

Sun, Feb 8, 4:23 PM
pouria requested review of D55186: geneve: follow RFC 6040 and use ECN_COMPLETE.
Sun, Feb 8, 4:10 PM
pouria requested review of D55185: ifconfig: Add geneve support WITHOUT_NETLINK.
Sun, Feb 8, 4:01 PM
pouria requested review of D55184: ifconfig: Add support for geneve (netlink).
Sun, Feb 8, 3:52 PM
pouria updated the test plan for D55183: geneve: Add geneve tests.
Sun, Feb 8, 11:36 AM
pouria requested review of D55183: geneve: Add geneve tests.
Sun, Feb 8, 11:35 AM
pouria requested review of D55182: geneve(4): Add geneve manual.
Sun, Feb 8, 11:30 AM
pouria requested review of D55181: ifconfig(8): Add geneve parameters.
Sun, Feb 8, 11:25 AM
pouria requested review of D55174: ifconfig: Add netlink helper to create interface.
Sun, Feb 8, 9:41 AM
pouria added a comment to D54172: Add Support for Geneve (RFC8926).

I'm going to breakdown this revision to be easier to review.
So, sorry for noise in advance.

Sun, Feb 8, 9:23 AM
pouria added a comment to D54443: if_gre: Add netlink support with tests.

@zlei
Did my answer resolve you comments?
Do you have any other input?

Sun, Feb 8, 9:05 AM

Sat, Feb 7

pouria accepted D55171: net: Remove the IFF_RENAMING flag.

LGTM

Sat, Feb 7, 10:05 PM
pouria added a reviewer for D54172: Add Support for Geneve (RFC8926): zlei.
Sat, Feb 7, 8:53 PM
pouria updated the diff for D54443: if_gre: Add netlink support with tests.

Move netlink related functions to the end of file.
@zlei done.

Sat, Feb 7, 6:51 PM
pouria added inline comments to D54172: Add Support for Geneve (RFC8926).
Sat, Feb 7, 6:42 PM
pouria added inline comments to D54443: if_gre: Add netlink support with tests.
Sat, Feb 7, 6:42 PM

Fri, Feb 6

pouria added a comment to D54443: if_gre: Add netlink support with tests.

@zlei
Can I have your opinion on this review, too?
I'm ready to commit it, but I'd prefer to wait for your feedback as well.

Fri, Feb 6, 7:38 PM
pouria added a comment to D54443: if_gre: Add netlink support with tests.
In D54443#1259973, @ae wrote:

Can you take a look at this patch? Maybe you can reuse some pieces, it should fix 275474 and also make access to softc in a safer way.

Fri, Feb 6, 10:38 AM
pouria requested review of D55141: ndp: implement delayed anycast and proxy NA.
Fri, Feb 6, 8:43 AM
pouria updated the diff for D55015: ndp: Add support for Gratuitous Neighbor Discovery (GRAND).

rename nd6_queue to nd_queue to match the style of in6_ifextra
rebase from main to update parent commit

Fri, Feb 6, 8:25 AM

Thu, Feb 5

pouria updated the diff for D54443: if_gre: Add netlink support with tests.

Rollback. wrong revision. sorry for noise!

Thu, Feb 5, 10:14 PM
pouria updated the diff for D55015: ndp: Add support for Gratuitous Neighbor Discovery (GRAND).

Replace callout_init_mtx with callout_init_rw. (Oops!)
Interesting enough, I tested every part my code. everything works.
nobody complains that I used callout_init_rw and passed a mutex!

Thu, Feb 5, 10:13 PM
pouria updated the diff for D54443: if_gre: Add netlink support with tests.
Thu, Feb 5, 10:11 PM
pouria updated the diff for D55015: ndp: Add support for Gratuitous Neighbor Discovery (GRAND).

Move nd6_queue tailq to in6_ifextra.
initialize nd6_queue at nd6_ifattach.
Reuse IF_ADDR_WLOCK as wlock of tailq.
Use epoch(9) as rlock.

Thu, Feb 5, 9:52 PM
pouria accepted D55138: Switch net.inet6.ip6.use_stableaddr to on by default.

LGTM

Thu, Feb 5, 9:17 PM
pouria accepted D55136: Fix style issues in code I committed to support RFC 7217.
Thu, Feb 5, 9:11 PM
pouria added a comment to D54443: if_gre: Add netlink support with tests.
In D54443#1259973, @ae wrote:

Can you take a look at this patch? Maybe you can reuse some pieces, it should fix 275474 and also make access to softc in a safer way.

Thu, Feb 5, 2:10 PM
pouria updated the diff for D54443: if_gre: Add netlink support with tests.

Add break to MOD_LOAD to address @glebius comment.

Thu, Feb 5, 12:23 PM
pouria committed rG484bf5a664c4: ifconfig: fix gre(4) status (authored by pouria).
ifconfig: fix gre(4) status
Thu, Feb 5, 9:57 AM
pouria committed rG6fd6fa4de1fb: ifconfig: fix gre(4) status (authored by pouria).
ifconfig: fix gre(4) status
Thu, Feb 5, 9:51 AM

Wed, Feb 4

pouria added a comment to D55015: ndp: Add support for Gratuitous Neighbor Discovery (GRAND).

I didn't ask to de-virtualize the queue, only the lock.

I'm confused now, how can I initialize a single lock for each per-vnet queue?
If I use an static initializer I need to tell/assign which per-vnet queue:

VNET_DEFINE_STATIC(TAILQ_HEAD(, nd6_queue), nd6_queue);
#define V_nd6_queue             VNET(nd6_queue)
Wed, Feb 4, 6:24 PM
pouria added a comment to D55015: ndp: Add support for Gratuitous Neighbor Discovery (GRAND).

Sorry, I didn't ask to de-virtualize the queue, only the lock.

I misunderstood you message. I'll fix it right away!

Wed, Feb 4, 5:31 PM
pouria committed rGc2ba906fa639: ifconfig: fix gre(4) status (authored by pouria).
ifconfig: fix gre(4) status
Wed, Feb 4, 5:22 PM
pouria closed D55099: ifconfig: fix gre(4) status.
Wed, Feb 4, 5:22 PM
pouria updated the diff for D55015: ndp: Add support for Gratuitous Neighbor Discovery (GRAND).

rename nd6 queue flags from GRAND to QUEUE to reuse nd6_queue in future.

Wed, Feb 4, 4:27 PM
pouria added a comment to D55099: ifconfig: fix gre(4) status.

So, seems like 14.4-BETA1 checkout happens at February 6.
@glebius I need approval for MFC within 1 day.

Wed, Feb 4, 3:37 PM
pouria updated the diff for D55015: ndp: Add support for Gratuitous Neighbor Discovery (GRAND).

Don't virtualize nd6_queue.
@glebius Done.

Wed, Feb 4, 3:33 PM
pouria added a comment to D55099: ifconfig: fix gre(4) status.

Looks good to me.

@glebius can I MFC this into stable/15 within 3 days?

Do you actually want to MFC to stable/14 to catch up with 14.4-BETA1 ? I see no problems.

Wed, Feb 4, 2:54 PM
pouria added inline comments to D55015: ndp: Add support for Gratuitous Neighbor Discovery (GRAND).
Wed, Feb 4, 2:12 PM
pouria updated the diff for D54443: if_gre: Add netlink support with tests.
  • Add types in if_gre.h to fix world build
  • Add copyright to test_rtnl_gre.c
  • Rebase to main and fix cleanup in test_rtnl_gre.

@glebius done.

Wed, Feb 4, 11:39 AM
pouria added a comment to D55099: ifconfig: fix gre(4) status.

@glebius can I MFC this into stable/15 within 3 days?

Wed, Feb 4, 11:11 AM
pouria requested review of D55099: ifconfig: fix gre(4) status.
Wed, Feb 4, 11:10 AM

Tue, Feb 3

pouria committed rG79c748ed4343: bnxt: don't set media status if link is down (authored by anaelle.cazuc_stormshield.eu).
bnxt: don't set media status if link is down
Tue, Feb 3, 9:35 AM

Mon, Feb 2

pouria committed rG6d37c3db62ba: bcmp(3): update manpage to following the Posix Standard (authored by pouria).
bcmp(3): update manpage to following the Posix Standard
Mon, Feb 2, 7:02 AM
pouria closed D52980: Update bcmp(3) manpage to following the Posix Standard.
Mon, Feb 2, 7:02 AM

Sun, Feb 1

pouria added a comment to D54443: if_gre: Add netlink support with tests.

There're three tasks in this change,

  1. Migrate to new if_clone KPI
  2. Refactor some ioctls, say GRESKEY
  3. Add netlink support

The first two are simple and easy to review, I expect them can be landed quickly. I'd support you to split the change.

Sun, Feb 1, 9:18 PM
pouria added a comment to D54443: if_gre: Add netlink support with tests.

kind reminder
@glebius

Sun, Feb 1, 10:16 AM
pouria added a comment to D53516: Update ip_ecn to RFC 6040.

kind reminder.
@tuexen @rscheff

Sun, Feb 1, 10:15 AM
pouria added a comment to D54636: rtadvd: add multi pref64 support.

@bz I've fixed the c&p error to address your comments. Could you please take another look?

Sun, Feb 1, 9:51 AM

Sat, Jan 31

pouria updated the diff for D55015: ndp: Add support for Gratuitous Neighbor Discovery (GRAND).

Rename struct and function. no functional change.

Sat, Jan 31, 10:03 PM
pouria requested review of D55015: ndp: Add support for Gratuitous Neighbor Discovery (GRAND).
Sat, Jan 31, 6:43 PM

Wed, Jan 28

pouria accepted D54382: MFC sys/netinet6: Implement RFC 7217 (private stable addresses).

Please fixs those on CURRENT. For this MFC, LGTM.

Wed, Jan 28, 7:39 AM

Tue, Jan 27

pouria added inline comments to D54382: MFC sys/netinet6: Implement RFC 7217 (private stable addresses).
Tue, Jan 27, 10:32 PM
pouria added a comment to D54382: MFC sys/netinet6: Implement RFC 7217 (private stable addresses).

Fix manual style/warning nits

Tue, Jan 27, 10:11 PM
pouria added a comment to D54382: MFC sys/netinet6: Implement RFC 7217 (private stable addresses).

Fix some style(9) nits.

Tue, Jan 27, 9:56 PM
pouria accepted D54918: ifconfig: Report errors from failed FIB commands.

LGTM

Tue, Jan 27, 9:20 PM

Mon, Jan 26

pouria closed D54573: bnxt: don't set media status if link is down.
Mon, Jan 26, 11:25 PM
pouria committed rG69de2b4e9679: bnxt: don't set media status if link is down (authored by anaelle.cazuc_stormshield.eu).
bnxt: don't set media status if link is down
Mon, Jan 26, 11:24 PM
pouria accepted D54573: bnxt: don't set media status if link is down.

@glebius Can I commit it with a 1-week MFC?

Mon, Jan 26, 6:28 PM

Sun, Jan 25

pouria updated the diff for D54636: rtadvd: add multi pref64 support.

@bz Done. sorry, I missed that comment.

Sun, Jan 25, 3:10 PM
pouria added a comment to D54636: rtadvd: add multi pref64 support.
In D54636#1254216, @bz wrote:

There's still some c&p error in the man page.

Could you please specify which part of the man page you think contains c&p errors, so I can work on it?

Sun, Jan 25, 10:33 AM
pouria updated the diff for D54636: rtadvd: add multi pref64 support.

@bz done.

Sun, Jan 25, 9:59 AM

Sat, Jan 24

pouria added a comment to D54636: rtadvd: add multi pref64 support.

@bz I've made some changes to address your comments. Could you please take another look?

Sat, Jan 24, 7:36 PM
pouria committed rG04f6b99947d2: netlink: use caller's credentials in rtnl_handle_newlink (authored by pouria).
netlink: use caller's credentials in rtnl_handle_newlink
Sat, Jan 24, 9:52 AM
pouria closed D54109: netlink: use same cred as caller's cred similar to ifioctl.
Sat, Jan 24, 9:52 AM
pouria committed rG40c0d6735538: ng_netflow v9: fix template re-announcement using packet count (authored by zarychtam_plan-b.pwste.edu.pl).
ng_netflow v9: fix template re-announcement using packet count
Sat, Jan 24, 9:28 AM
pouria committed rGf51e0f5e69cf: ng_netflow v9: fix template re-announcement using packet count (authored by zarychtam_plan-b.pwste.edu.pl).
ng_netflow v9: fix template re-announcement using packet count
Sat, Jan 24, 9:18 AM

Thu, Jan 22

pouria updated the diff for D54109: netlink: use same cred as caller's cred similar to ifioctl.

Add a temporary comment to land this patch

Thu, Jan 22, 3:19 PM

Sun, Jan 18

pouria committed rG2f900cbc5fdf: ifconfig: Use strlcpy(3) instead of strncpy(3) for interface name (authored by amy.vargas_netapp.com).
ifconfig: Use strlcpy(3) instead of strncpy(3) for interface name
Sun, Jan 18, 8:29 AM
pouria closed D54752: ifconfig: Use strlcpy() instead of strncpy() for interface name copy.
Sun, Jan 18, 8:28 AM
pouria committed rGadb66ef8c6ff: netlink(4): Add snl(3) to See Also section (authored by pouria).
netlink(4): Add snl(3) to See Also section
Sun, Jan 18, 8:23 AM
pouria closed D53786: netlink(4): add snl(3) to See Also section.
Sun, Jan 18, 8:23 AM
pouria closed D54473: checkkey.sh: Add EDDSA algo (RFC8032).
Sun, Jan 18, 8:15 AM
pouria committed R9:169c613a70b8: checkkey.sh: Add EDDSA algo (RFC8032) (authored by pouria).
checkkey.sh: Add EDDSA algo (RFC8032)
Sun, Jan 18, 8:15 AM

Sat, Jan 17

pouria updated the diff for D54473: checkkey.sh: Add EDDSA algo (RFC8032).

Avoid returning badkey error for EDDSA.

Sat, Jan 17, 12:44 PM
pouria accepted D54752: ifconfig: Use strlcpy() instead of strncpy() for interface name copy.
Sat, Jan 17, 9:55 AM
pouria added a comment to D52980: Update bcmp(3) manpage to following the Posix Standard.

@ziaee
Thank you for reviewing the 53786 . I wanted to politely ping you on this revision, when you have a chance.

Sat, Jan 17, 9:02 AM
pouria updated subscribers of D53786: netlink(4): add snl(3) to See Also section.

@glebius can I commit this revision?

Sat, Jan 17, 8:53 AM

Fri, Jan 16

pouria added a reviewer for D53786: netlink(4): add snl(3) to See Also section: ziaee.
Fri, Jan 16, 8:53 PM
pouria committed rGd836dae9f0d8: ng_netflow v9: fix template re-announcement using packet count (authored by zarychtam_plan-b.pwste.edu.pl).
ng_netflow v9: fix template re-announcement using packet count
Fri, Jan 16, 6:40 PM
pouria accepted D54721: net: on interface detach purge all its routes before detaching protocols.

LGTM
I also tested interface creation and destruction to advertise/withdraw its routes with bird3 (ospf) and openbgpd8.

Fri, Jan 16, 3:01 PM
pouria accepted D54455: ip: improve deferred computation of checksums.

LGTM.
I also tested with the CSUM_IP patch applied to if_epair.c:447 and saw good results.

Fri, Jan 16, 10:19 AM

Thu, Jan 15

pouria added inline comments to D54636: rtadvd: add multi pref64 support.
Thu, Jan 15, 7:39 PM
pouria updated the diff for D54636: rtadvd: add multi pref64 support.

Address @ziaee comments

Thu, Jan 15, 7:33 PM
pouria added a comment to D54721: net: on interface detach purge all its routes before detaching protocols.

I will test it with openbgp and bird.
I suspect that removing routes before detaching the actual interface might cause unexpected behavior in them.

Thu, Jan 15, 12:37 PM
pouria added inline comments to D54636: rtadvd: add multi pref64 support.
Thu, Jan 15, 11:03 AM
pouria added inline comments to D54636: rtadvd: add multi pref64 support.
Thu, Jan 15, 11:01 AM
pouria updated the diff for D54636: rtadvd: add multi pref64 support.

Address @bz comment for manual.

Thu, Jan 15, 10:43 AM
pouria added inline comments to D54636: rtadvd: add multi pref64 support.
Thu, Jan 15, 10:42 AM
pouria updated the diff for D54636: rtadvd: add multi pref64 support.

Address @bz comments

Thu, Jan 15, 10:29 AM
pouria added inline comments to D54636: rtadvd: add multi pref64 support.
Thu, Jan 15, 10:21 AM
pouria added a comment to D54636: rtadvd: add multi pref64 support.
In D54636#1250365, @ivy wrote:

the only purpose that RFC8781 mentions for having multiple PREF64s advertised is renumbering, in which case the lifetime of the deprecated prefixes should be set to zero. iiuc, this diff allows that by setting pref64lifetime0, pref64lifetime1, etc. - can i check i have that right?

Thu, Jan 15, 10:06 AM
pouria added a comment to D54636: rtadvd: add multi pref64 support.

P.S. Love the KAME project, but honestly, most of their userland code is weird.
For instance, I also have a branch for mobile ipv6 implementation, where I made a fair amount of changes to rtadvd, rtsold, rtadvctl, and others.
I have to say the layer of indirection in KAME code makes adding a single floating point number almost impossible without refactor.
I don't like their style of coding in userland either. However, To see if I should use our own style or simply follow existing, I checked the other revisions for these toolset found other developers simply didn't touch KAME style.

Thu, Jan 15, 9:57 AM
pouria updated the diff for D54636: rtadvd: add multi pref64 support.

rebase to latest commit and cleanup unused var

Thu, Jan 15, 7:13 AM

Wed, Jan 14

pouria added a comment to D54636: rtadvd: add multi pref64 support.

Here is the output sample of rtadvctl:

% mdo rtadvctl -v show
bridge0: flags=<UP,TRANSITIVE,PERSIST> status=<RA_SEND> mtu 1500
DefaultLifetime: 10m
MinAdvInterval/MaxAdvInterval: 3m20s/10m
AdvLinkMTU: <none>, Flags: MO, Preference: low
ReachableTime: 0s, RetransTimer: 0s, CurHopLimit: 64
AdvIfPrefixes: yes
Next RA send: Thu Jan 15 00:58:25 2026
Last RA send: Thu Jan 15 00:58:06 2026
Prefixes (1):
2a01:e140:1234:5678::/64 (CONFIG, vltime=30d, pltime=7d, flags=LA)
DNSSL entries:
spmzt.net (ltime=15m)
PREF64:
2a01:e140:cafe:ff::/96 (ltime: 3m45s)
2a01:e140:dead:ff::/64 (ltime: 3m45s)
Wed, Jan 14, 10:18 PM
pouria retitled D54636: rtadvd: add multi pref64 support from rtadvctl: add pref64 support to rtadvd: add multi pref64 support.
Wed, Jan 14, 9:40 PM