User Details
- User Since
- Aug 26 2022, 6:24 PM (180 w, 2 d)
Yesterday
add nl_parsed_gre to test file.
Make nl_parsed_gre private.
@zlei done.
After doing my research, If find out you were right.
Dictating netlink data structure to userland defeats
the purpose of using netlink in first place.
Rebase geneve to main and limit this revision kernel only.
ifconfig netlink helper: D55174
ifconfig geneve implementation (netlink): D55184
ifconfig geneve implementation (without netlink): D55185
ifconfig(8) manual for geneve: D55181
geneve(4) manual: D55182
geneve tests: D55183
update geneve to follow RFC 6040: D55186
I'm going to breakdown this revision to be easier to review.
So, sorry for noise in advance.
@zlei
Did my answer resolve you comments?
Do you have any other input?
Sat, Feb 7
Move netlink related functions to the end of file.
@zlei done.
Fri, Feb 6
@zlei
Can I have your opinion on this review, too?
I'm ready to commit it, but I'd prefer to wait for your feedback as well.
rename nd6_queue to nd_queue to match the style of in6_ifextra
rebase from main to update parent commit
Thu, Feb 5
Rollback. wrong revision. sorry for noise!
Replace callout_init_mtx with callout_init_rw. (Oops!)
Interesting enough, I tested every part my code. everything works.
nobody complains that I used callout_init_rw and passed a mutex!
Move nd6_queue tailq to in6_ifextra.
initialize nd6_queue at nd6_ifattach.
Reuse IF_ADDR_WLOCK as wlock of tailq.
Use epoch(9) as rlock.
LGTM
Add break to MOD_LOAD to address @glebius comment.
Wed, Feb 4
I'm confused now, how can I initialize a single lock for each per-vnet queue?
If I use an static initializer I need to tell/assign which per-vnet queue:
VNET_DEFINE_STATIC(TAILQ_HEAD(, nd6_queue), nd6_queue); #define V_nd6_queue VNET(nd6_queue)
I misunderstood you message. I'll fix it right away!
rename nd6 queue flags from GRAND to QUEUE to reuse nd6_queue in future.
So, seems like 14.4-BETA1 checkout happens at February 6.
@glebius I need approval for MFC within 1 day.
Don't virtualize nd6_queue.
@glebius Done.
- Add types in if_gre.h to fix world build
- Add copyright to test_rtnl_gre.c
- Rebase to main and fix cleanup in test_rtnl_gre.
@glebius done.
@glebius can I MFC this into stable/15 within 3 days?
Tue, Feb 3
Mon, Feb 2
Sun, Feb 1
kind reminder
@glebius
@bz I've fixed the c&p error to address your comments. Could you please take another look?
Sat, Jan 31
Rename struct and function. no functional change.
Wed, Jan 28
Please fixs those on CURRENT. For this MFC, LGTM.
Tue, Jan 27
Fix manual style/warning nits
Fix some style(9) nits.
Mon, Jan 26
@glebius Can I commit it with a 1-week MFC?
Sun, Jan 25
@bz Done. sorry, I missed that comment.
Could you please specify which part of the man page you think contains c&p errors, so I can work on it?
Sat, Jan 24
@bz I've made some changes to address your comments. Could you please take another look?
Thu, Jan 22
Add a temporary comment to land this patch
Sun, Jan 18
Sat, Jan 17
Avoid returning badkey error for EDDSA.
@ziaee
Thank you for reviewing the 53786 . I wanted to politely ping you on this revision, when you have a chance.
@glebius can I commit this revision?
Fri, Jan 16
LGTM
I also tested interface creation and destruction to advertise/withdraw its routes with bird3 (ospf) and openbgpd8.
LGTM.
I also tested with the CSUM_IP patch applied to if_epair.c:447 and saw good results.
Thu, Jan 15
Address @ziaee comments
I will test it with openbgp and bird.
I suspect that removing routes before detaching the actual interface might cause unexpected behavior in them.
Address @bz comment for manual.
Address @bz comments
P.S. Love the KAME project, but honestly, most of their userland code is weird.
For instance, I also have a branch for mobile ipv6 implementation, where I made a fair amount of changes to rtadvd, rtsold, rtadvctl, and others.
I have to say the layer of indirection in KAME code makes adding a single floating point number almost impossible without refactor.
I don't like their style of coding in userland either. However, To see if I should use our own style or simply follow existing, I checked the other revisions for these toolset found other developers simply didn't touch KAME style.
rebase to latest commit and cleanup unused var
Wed, Jan 14
Here is the output sample of rtadvctl:
% mdo rtadvctl -v show bridge0: flags=<UP,TRANSITIVE,PERSIST> status=<RA_SEND> mtu 1500 DefaultLifetime: 10m MinAdvInterval/MaxAdvInterval: 3m20s/10m AdvLinkMTU: <none>, Flags: MO, Preference: low ReachableTime: 0s, RetransTimer: 0s, CurHopLimit: 64 AdvIfPrefixes: yes Next RA send: Thu Jan 15 00:58:25 2026 Last RA send: Thu Jan 15 00:58:06 2026 Prefixes (1): 2a01:e140:1234:5678::/64 (CONFIG, vltime=30d, pltime=7d, flags=LA) DNSSL entries: spmzt.net (ltime=15m) PREF64: 2a01:e140:cafe:ff::/96 (ltime: 3m45s) 2a01:e140:dead:ff::/64 (ltime: 3m45s)