Page MenuHomeFreeBSD

pouria (Pouria Mousavizadeh Tehrani)
Pouria

Projects (4)

User Details

User Since
Aug 26 2022, 6:24 PM (220 w, 6 d)

Recent Activity

Today

pouria added reviewers for D61504: netlink: Do not change interface flags on an empty ifinfomsg: saheed, obiwac, kp.
Thu, Nov 19, 2:25 PM
pouria updated the diff for D56089: domain.9: Extend to describe protosw prototypes.

Fix accuracy and grammar.

Thu, Nov 19, 11:11 AM
pouria added a comment to D56089: domain.9: Extend to describe protosw prototypes.

There are few things in the added text that, I hope, will disapper/change before 16.0-RELEASE. I would not document them at all to avoid any harvesting by LLMs and other robots. In the past reality I would be fine with documenting stuff as is and later changing it as the code changes. What do other people, especially doc committers think?

Thu, Nov 19, 10:44 AM
pouria added a comment to D53742: ip_ecn: don't touch the DSCP bits and flow_id.

gentle ping @glebius

Thu, Nov 19, 10:41 AM
pouria accepted D61726: tests/net/bpf: run the bpf:inject test with RSS again.
Thu, Nov 19, 9:49 AM
pouria added a reviewer for D61504: netlink: Do not change interface flags on an empty ifinfomsg: adrian.

Gentle ping: @emaste @markj

Thu, Nov 19, 8:38 AM
pouria accepted D61725: arp: Teach arp to attach and run itself in a jail.
Thu, Nov 19, 7:04 AM

Yesterday

pouria committed rGc15a606d2f44: route/fib_algo: Fix nexthop reference leak on FLM_BATCH.
Wed, Nov 18, 7:23 PM
pouria closed D61577: route/fib_algo: Fix nexthop reference leak on FLM_BATCH.
Wed, Nov 18, 7:23 PM
pouria added a comment to D51866: if_gif: Use the MTU on the gif interface for the outgoing packets.

@glebius @pouria Sorry for the long silence. I now have some time to focus on this again, and I'd like to get this moving so we can get the change into 16.0. I'll start working on the things you requested over the next few days.

Wed, Nov 18, 7:18 PM
pouria accepted D61041: netinet6: Send redirects from ip6_tryforward().
Wed, Nov 18, 7:17 PM
pouria accepted D61038: netinet6: Keep a pfil-chosen next hop in ip6_tryforward().

Thanks

Wed, Nov 18, 6:53 PM
pouria added a comment to D61039: netinet6: Decrement the hop limit before the outbound hooks in ip6_tryforward().

Approved on ip6_tryforward() only. I'm not expert on pf.

Wed, Nov 18, 6:49 PM
pouria accepted D61042: netinet6: Do not count a packet a hook consumed as discarded in ip6_tryforward().

LGTM

Wed, Nov 18, 6:20 PM
pouria accepted D61038: netinet6: Keep a pfil-chosen next hop in ip6_tryforward().

I prefer to use ifconfig -j instead of jexec ifconfig myself.

Wed, Nov 18, 6:02 PM
pouria accepted D61041: netinet6: Send redirects from ip6_tryforward().

LGTM

Wed, Nov 18, 5:17 PM

Mon, Nov 16

pouria updated the diff for D32920: IPv6: rc boot time improvements.

Address @dteske comments.

Mon, Nov 16, 8:23 PM
pouria commandeered D32920: IPv6: rc boot time improvements.
Mon, Nov 16, 8:10 PM
pouria published D61637: routing: Sort the nexthops of a group by metric for review.
Mon, Nov 16, 8:04 PM
pouria updated the diff for D61580: routing: Fix the size of nexthop groups with mixed metrics.

Reduce scope of the DR and split the changes to be stacked

Mon, Nov 16, 4:59 PM
pouria updated the summary of D61580: routing: Fix the size of nexthop groups with mixed metrics.
Mon, Nov 16, 4:58 PM
pouria accepted D61393: ip6_forward: Do not reference the nexthop.
Mon, Nov 16, 4:56 PM
pouria accepted D61393: ip6_forward: Do not reference the nexthop.

LGTM, Thanks!

Mon, Nov 16, 4:38 PM
pouria added a comment to D61393: ip6_forward: Do not reference the nexthop.

Please rebase it again on top of main (due to 3d88ee6af2961deefe7412b2e393aa0c05d4102c) I can't apply it cleanly.
Thanks!

Mon, Nov 16, 4:34 PM

Sun, Nov 15

pouria committed rGe24434f286fd: if_bridge: Use bridge's FIB for incoming unicasts.
Sun, Nov 15, 6:45 PM
pouria closed D61517: if_bridge: Use bridge's FIB for incoming unicasts.
Sun, Nov 15, 6:45 PM

Sat, Nov 14

pouria published D61580: routing: Fix the size of nexthop groups with mixed metrics for review.
Sat, Nov 14, 7:45 PM
pouria added a comment to D61462: net: traverse interface groups under the network epoch.

I don't if we can use epoch here, since ifgl is protected by IFNET_WLOCK...

Sat, Nov 14, 7:13 PM · network
pouria published D61577: route/fib_algo: Fix nexthop reference leak on FLM_BATCH for review.
Sat, Nov 14, 6:20 PM
pouria updated subscribers of D61504: netlink: Do not change interface flags on an empty ifinfomsg.

BTW, I need this fix in order to work on PR299448

Sat, Nov 14, 6:09 PM
pouria added a comment to D61517: if_bridge: Use bridge's FIB for incoming unicasts.

Emm, I guess the bridge members should inherit the default FIB number from bridge ?

Sat, Nov 14, 4:17 PM
pouria added a reviewer for D61517: if_bridge: Use bridge's FIB for incoming unicasts: zlei.
Sat, Nov 14, 4:09 PM
pouria added a reviewer for D61393: ip6_forward: Do not reference the nexthop: pouria.
Sat, Nov 14, 3:27 PM

Fri, Nov 13

pouria committed rG1db6e2c6c355: rtnetlink: Use default weight for unset weights in NHA_GROUP.
Fri, Nov 13, 9:51 PM
pouria requested review of D61517: if_bridge: Use bridge's FIB for incoming unicasts.
Fri, Nov 13, 6:30 PM
pouria removed a reviewer for D61504: netlink: Do not change interface flags on an empty ifinfomsg: transport.
Fri, Nov 13, 6:29 PM
pouria accepted D61509: ip6_forward: Free the ICMPv6 copy on all error paths.

LGTM

Fri, Nov 13, 5:25 PM
pouria committed rG503ecf5bf454: if_geneve: Read the outer IP header from the start of the packet.
Fri, Nov 13, 5:17 PM
pouria published D61504: netlink: Do not change interface flags on an empty ifinfomsg for review.
Fri, Nov 13, 12:43 PM
pouria committed rG39b97c10e6d0: if_geneve: Ignore reserved bits on receive.
Fri, Nov 13, 11:43 AM
pouria committed rG7ba9c38b703d: if_geneve: Do not byte-swap the option length (authored by Kevin Day <kevin@your.org>).
Fri, Nov 13, 11:43 AM

Thu, Nov 12

pouria committed rGefa14ab698fe: routing: Fix nhop double free in rib_copy_route().
Thu, Nov 12, 9:56 PM
pouria closed D59849: gre(4): Add full support for gre key.
Thu, Nov 12, 8:21 PM
pouria committed rG1555dff3bf56: gre(4): Add full support for gre key.
Thu, Nov 12, 8:21 PM
pouria added a comment to D59849: gre(4): Add full support for gre key.

I will commit this in 4 hours.

Thu, Nov 12, 4:35 PM
pouria added a reviewer for D61385: ip_forward: Take the nexthop reference only for ip_output(): pouria.

Two things:

Thu, Nov 12, 4:14 PM

Wed, Nov 11

pouria committed rG9d2cdb3fd574: routing: Fix buffer size in merge_nhgrps().
Wed, Nov 11, 10:53 PM

Sat, Nov 7

pouria committed R11:020e8ff33d04: misc/zeroclaw: Update to v0.8.5 (authored by arcade_b1t.name).
Sat, Nov 7, 8:30 PM

Fri, Nov 6

pouria added inline comments to D54749: netinet6: Periodically retry DAD for IPv6 addresses marked as duplicated.
Fri, Nov 6, 5:37 AM

Wed, Nov 4

pouria accepted D61158: ure: Initialize ifm_active in ure_ifmedia_sts.
Wed, Nov 4, 5:02 PM

Tue, Nov 3

pouria accepted D59474: jib, jng: Move to usr.sbin and add manuals.
Tue, Nov 3, 10:29 AM · Netgraph

Mon, Nov 2

pouria closed D58177: netinet6: use memcpy/memset/memcmp for consistency.
Mon, Nov 2, 8:36 PM
pouria committed rGede77280787a: netinet6: Use memcpy/memset/memcmp for consistency (authored by vinicius_ferrao.net.br).
Mon, Nov 2, 8:36 PM
pouria accepted D58177: netinet6: use memcpy/memset/memcmp for consistency.

I will commit it.

Mon, Nov 2, 8:08 PM

Sun, Nov 1

pouria updated the test plan for D59849: gre(4): Add full support for gre key.
Sun, Nov 1, 8:43 PM
pouria added inline comments to D59849: gre(4): Add full support for gre key.
Sun, Nov 1, 8:30 PM
pouria updated the diff for D59849: gre(4): Add full support for gre key.

Add support for gre incoming key by separating greikey and greokey, while using grekey sets keys in both directions. Dedup check only happens on greikey. @zlei done.

Sun, Nov 1, 8:29 PM

Sat, Oct 31

pouria committed rG55ac3c32b9dd: tests/if_geneve: Fix ether_ipv6_blind_options flakiness.
Sat, Oct 31, 6:04 PM

Thu, Oct 29

pouria closed D60938: sctp: Allow to Ignore iface type when determining address scope.
Thu, Oct 29, 5:22 PM
pouria added a reverting change for rG714433a6772b: bind_all_fibs: Disable bind_all_fibs by default: rG7b23b63edfe0: Revert "bind_all_fibs: Disable bind_all_fibs by default".
Thu, Oct 29, 4:22 PM
pouria committed rG7b23b63edfe0: Revert "bind_all_fibs: Disable bind_all_fibs by default".
Thu, Oct 29, 4:22 PM
pouria committed rG714433a6772b: bind_all_fibs: Disable bind_all_fibs by default.
Thu, Oct 29, 2:08 PM
pouria closed D60961: linux: Preserve partial results from recvmmsg().
Thu, Oct 29, 8:49 AM
pouria committed rGafeb885b4ae4: linux: Preserve partial results from recvmmsg() (authored by vova_fbsd.ru).
Thu, Oct 29, 8:44 AM
pouria committed rGad9ab26ab52a: smb(4): Add SMB Block Process Call command (authored by YannickV <Y.Vossen@beckhoff.com>).
Thu, Oct 29, 8:43 AM
pouria committed rG3200a274272d: sctp: Allow to ignore iface type when determining address scope.
Thu, Oct 29, 8:42 AM
pouria committed rG8328ca324c36: linux: Implement PTRACE_GETREGSET NT_PRFPREG and NT_X86_XSTATE (authored by rbranco_suse.com).
Thu, Oct 29, 8:40 AM
pouria committed rGd8f803192315: linux: Add linux_pt_fpregset and bsd_to_linux_fpregset() for amd64 (authored by rbranco_suse.com).
Thu, Oct 29, 8:40 AM
pouria committed rG29b79c586b20: linux: Ignore sigaction(2) flags SA_UNSUPPORTED and SA_EXPOSE_TAGBITS (authored by rbranco_suse.com).
Thu, Oct 29, 8:40 AM
pouria committed R11:71aaf20627e2: net/iodine: Update to 0.9.0 and cleanup.
Thu, Oct 29, 8:38 AM
pouria committed R11:8a5539b0d0ba: net/udpspeeder: Add new port.
Thu, Oct 29, 8:37 AM

Wed, Oct 21

pouria updated the diff for D60938: sctp: Allow to Ignore iface type when determining address scope.

Enable sysctl by default.

Wed, Oct 21, 5:50 PM
pouria added inline comments to D60938: sctp: Allow to Ignore iface type when determining address scope.
Wed, Oct 21, 5:37 PM
pouria added a comment to D60938: sctp: Allow to Ignore iface type when determining address scope.

I have this issue on my own infrastructure in two different cases:

Wed, Oct 21, 5:33 PM
pouria requested review of D60938: sctp: Allow to Ignore iface type when determining address scope.
Wed, Oct 21, 5:31 PM

Oct 19 2026

pouria accepted D60869: ipfw: hold sleepable "upper half lock" for periodic state expiry.

LGTM

Oct 19 2026, 6:18 PM

Oct 18 2026

pouria closed D60166: Status/2026Q3: Pouria reports.
Oct 18 2026, 9:17 PM
pouria committed R9:27cbba49b7b5: Status/2026Q3: Pouria reports.
Oct 18 2026, 9:17 PM

Oct 17 2026

pouria resigned from D60804: if: Wait for the network epoch after if_dead() on detach.

This function is quite fragile and sensitive.
The more time we spend fixing issues, the more fragile it seems to become.

Oct 17 2026, 5:00 PM

Oct 14 2026

pouria added a comment to D60736: mbuf: remove remnants of caddr_t.

We have developers that are twice younger than obsoletion of this type.

Looks like I'm not qualified to approve this one. 🚶

Oct 14 2026, 10:04 PM

Oct 13 2026

pouria committed rG84f790e5b6cc: ip_encap: Recompute flowid for packets received over tunnel.
Oct 13 2026, 9:02 PM
pouria closed D60552: ip_encap: Recompute flowid for packets received over tunnel.
Oct 13 2026, 9:01 PM
pouria added a comment to D60552: ip_encap: Recompute flowid for packets received over tunnel.

@gallatin
So, I can update this revision to:

Oct 13 2026, 7:34 PM
pouria accepted D60520: tests: Add SLAAC interface identifier cases to ndp.sh.
Oct 13 2026, 7:01 PM
pouria planned changes to D59849: gre(4): Add full support for gre key.

@zlei All the points you made are valid. I will work on it.

Oct 13 2026, 11:04 AM
pouria accepted D59450: loopback: set MTU to IF_MAXMTU.
Oct 13 2026, 10:48 AM
pouria added a comment to D60659: linux: Allow connect() on DGRAM sockets with port 0.

I also faced this problem yesterday.

Oct 13 2026, 10:45 AM
pouria added a comment to D60685: ipfw: cleanup SYSINIT(9)s.

I'm not expert enough to approve, but this LGTM.

Oct 13 2026, 10:02 AM
pouria added a comment to D60689: net*: use inlined m_pullup().

I also reviewed the code under sys/netinet6.

Oct 13 2026, 9:57 AM
pouria accepted D60689: net*: use inlined m_pullup().

I've reviewed the code under sys/net/

Oct 13 2026, 9:27 AM
pouria accepted D60688: mbuf: make m_pullup() an inline over most expected case.
Oct 13 2026, 9:16 AM

Oct 11 2026

pouria added a comment to D60552: ip_encap: Recompute flowid for packets received over tunnel.

I removed the m_len check because now the rss_mbuf_software_hash_v[46] function performs it.

Oct 11 2026, 4:21 PM
pouria updated the diff for D60552: ip_encap: Recompute flowid for packets received over tunnel.

Use rss_mbuf_software_hash_v* instead. Tested in production and it PERFECTLY works. @gallatin how it looks now?

Oct 11 2026, 4:17 PM
pouria added inline comments to D60552: ip_encap: Recompute flowid for packets received over tunnel.
Oct 11 2026, 8:05 AM

Oct 10 2026

pouria added a comment to D60589: netgraph/ng_ksocket: Enter epoch on NG_SEND_DATA_ONLY.

This is correct fix, thanks! The commit message should be like this:

The work queued by ng_send_fn() is intentionally processed outside of the epoch in ngthread().  It is ng_ksocket's responsibility to enter epoch if it decides to send data from such work.

Nothing to do with ng_ppp.

Oct 10 2026, 7:16 PM
pouria committed rG67be955f6bd5: netgraph/ng_ksocket: Enter epoch on NG_SEND_DATA_ONLY.
Oct 10 2026, 7:14 PM
pouria closed D60589: netgraph/ng_ksocket: Enter epoch on NG_SEND_DATA_ONLY.
Oct 10 2026, 7:14 PM
pouria added a comment to D59849: gre(4): Add full support for gre key.

This looks good to me. I'm glad we finally have this heh. :-)

Oct 10 2026, 5:17 PM
pouria added inline comments to D60552: ip_encap: Recompute flowid for packets received over tunnel.
Oct 10 2026, 4:43 PM
pouria requested review of D60589: netgraph/ng_ksocket: Enter epoch on NG_SEND_DATA_ONLY.
Oct 10 2026, 4:28 PM