Differential D60685

ipfw: cleanup SYSINIT(9)s
Needs ReviewPublic
Actions

Authored by glebius on Mon, Oct 12, 7:50 PM.

Tags

None

Referenced Files

	F175786468: D60685.id.diff
	Tue, Oct 13, 8:50 AM

	F175781096: D60685.diff
	Tue, Oct 13, 7:45 AM

	F175753939: D60685.diff
	Tue, Oct 13, 1:43 AM

	F175750628: D60685.id189672.diff
	Tue, Oct 13, 12:58 AM

	F175746558: D60685.diff
	Tue, Oct 13, 12:07 AM

	F175736424: D60685.id189672.diff
	Mon, Oct 12, 10:05 PM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

ae
lytboris_gmail.com

Group Reviewers

Summary

Make them all belong to SI_SUB_PROTO_FIREWALL and explicitly specify
order. Prefer SYSINIT() over modevent, for those subsystems that don't
have dependencies. All subsystems just depend on the main module and they
don't depend on each other, except dummynet which also has submodules.
Thus, keep DECLARE_MODULE() only for the main module and dummynet.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 78105
Build 74988: arc lint + arc unit

Event Timeline

glebius created this revision.Mon, Oct 12, 7:50 PM

Herald added subscribers: vegeta_tuxpowered.net, donner, melifaro, imp. · View Herald TranscriptMon, Oct 12, 7:50 PM

glebius requested review of this revision.Mon, Oct 12, 7:50 PM

Harbormaster completed remote builds in B78105: Diff 189672.Mon, Oct 12, 7:50 PM

glebius added a reviewer: lytboris_gmail.com.Mon, Oct 12, 7:50 PM

I'm not expert enough to approve, but this LGTM.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

2 lines

10 lines

60 lines

9 lines

44 lines

nat64/

36 lines

nptv6/

18 lines

Diff 189672

sys/netpfil/ipfw/dn_sched.h

Loading...

sys/netpfil/ipfw/ip_dummynet.c

Loading...

sys/netpfil/ipfw/ip_fw2.c

Loading...

sys/netpfil/ipfw/ip_fw_compat.c

Loading...

sys/netpfil/ipfw/ip_fw_nat.c

Loading...

sys/netpfil/ipfw/nat64/ip_fw_nat64.c

Loading...

sys/netpfil/ipfw/nptv6/ip_fw_nptv6.c

Loading...