Page MenuHomeFreeBSD

vegeta_tuxpowered.net (Kajetan Staszkiewicz)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2022, 11:10 AM (21 w, 6 d)

Recent Activity

Mon, Jan 30

vegeta_tuxpowered.net added a comment to D38126: netpfil tests: Add functions for testing routing scenarios.
In D38126#869129, @kp wrote:

I'm certainly seeing the argument for having setup_router_dummy_ipv6 and friends do the test setup.

Mon, Jan 30, 8:43 AM
vegeta_tuxpowered.net updated the diff for D38126: netpfil tests: Add functions for testing routing scenarios.

Re-add the missing part: the setup functions.

Mon, Jan 30, 8:43 AM

Thu, Jan 26

vegeta_tuxpowered.net updated the diff for D38126: netpfil tests: Add functions for testing routing scenarios.

I have updated the review to not only add functions for creating routing-based tests but also to make use of them by adding more tests for standard pf.conf syntax. This makes this review not related anymore to D38025.

Thu, Jan 26, 10:02 PM

Sun, Jan 22

vegeta_tuxpowered.net added a comment to D38126: netpfil tests: Add functions for testing routing scenarios.

! In D38126#866510, @kp wrote:

! In D38126#866296, @vegeta_tuxpowered.net wrote:

Sun, Jan 22, 11:27 AM

Fri, Jan 20

vegeta_tuxpowered.net added a comment to D38126: netpfil tests: Add functions for testing routing scenarios.
In D38126#866273, @kp wrote:

There's certainly a lot of repetition in many of the pf (and other firewall) tests.

So far I've chosen to not do anything about that, because it makes each individual test case much easier to understand. Each test case fully describes the setup it operates in, and when someone tries to debug it (or understand it for any other reason) there's no need to go look at other files to work out what the setup actually is.

Fri, Jan 20, 11:58 AM
vegeta_tuxpowered.net added a comment to D38122: netpfil tests: Improve pft_ping.py.
In D38122#866272, @kp wrote:

This seems mostly good, but I've had to add these changes to avoid a few test failures:

Fri, Jan 20, 11:39 AM
vegeta_tuxpowered.net updated the diff for D38122: netpfil tests: Improve pft_ping.py.

Split sniffer.correctPackets change into D38120.

Fri, Jan 20, 11:06 AM
vegeta_tuxpowered.net added a comment to D38120: netpfil tests: Improve sniffer.py.
In D38120#866233, @kp wrote:

I think we're missing a change of foundCorrectPacket to correctPackets in pft_ping.py here.

Fri, Jan 20, 11:01 AM
vegeta_tuxpowered.net updated the diff for D38120: netpfil tests: Improve sniffer.py.
Fri, Jan 20, 10:59 AM
vegeta_tuxpowered.net updated the summary of D38122: netpfil tests: Improve pft_ping.py.
Fri, Jan 20, 10:38 AM
vegeta_tuxpowered.net updated the summary of D38129: netpfil tests: Add tests for the new scrub syntax.
Fri, Jan 20, 10:24 AM
vegeta_tuxpowered.net updated the summary of D38126: netpfil tests: Add functions for testing routing scenarios.
Fri, Jan 20, 10:23 AM
vegeta_tuxpowered.net updated the summary of D38123: netpfil tests: Improve pfsync_defer.py .
Fri, Jan 20, 10:23 AM
vegeta_tuxpowered.net updated the summary of D38122: netpfil tests: Improve pft_ping.py.
Fri, Jan 20, 10:23 AM
vegeta_tuxpowered.net updated the summary of D38120: netpfil tests: Improve sniffer.py.
Fri, Jan 20, 10:23 AM

Thu, Jan 19

vegeta_tuxpowered.net updated the summary of D38129: netpfil tests: Add tests for the new scrub syntax.
Thu, Jan 19, 11:02 PM
vegeta_tuxpowered.net requested review of D38129: netpfil tests: Add tests for the new scrub syntax.
Thu, Jan 19, 11:00 PM
vegeta_tuxpowered.net requested review of D38126: netpfil tests: Add functions for testing routing scenarios.
Thu, Jan 19, 10:37 PM
vegeta_tuxpowered.net added a reviewer for D38123: netpfil tests: Improve pfsync_defer.py : kp.
Thu, Jan 19, 5:55 PM
vegeta_tuxpowered.net requested review of D38123: netpfil tests: Improve pfsync_defer.py .
Thu, Jan 19, 5:55 PM
vegeta_tuxpowered.net updated the diff for D38122: netpfil tests: Improve pft_ping.py.
Thu, Jan 19, 5:52 PM
vegeta_tuxpowered.net requested review of D38122: netpfil tests: Improve pft_ping.py.
Thu, Jan 19, 5:51 PM
vegeta_tuxpowered.net updated the summary of D38120: netpfil tests: Improve sniffer.py.
Thu, Jan 19, 4:58 PM
vegeta_tuxpowered.net requested review of D38120: netpfil tests: Improve sniffer.py.
Thu, Jan 19, 4:56 PM
vegeta_tuxpowered.net updated the diff for D38025: Add "match" rules like in upstream pf.
Thu, Jan 19, 4:01 PM

Fri, Jan 13

vegeta_tuxpowered.net updated the summary of D38024: Properly destroy renamed interfaces.
Fri, Jan 13, 7:28 PM
vegeta_tuxpowered.net updated the summary of D38024: Properly destroy renamed interfaces.
Fri, Jan 13, 7:28 PM
vegeta_tuxpowered.net updated the diff for D38024: Properly destroy renamed interfaces.
Fri, Jan 13, 7:25 PM
vegeta_tuxpowered.net added a comment to D38024: Properly destroy renamed interfaces.
In D38024#863922, @kp wrote:

I'm a little concerned about one end of an epair not getting destroyed if we destroy the other. That's not something I'd want the tests to cope with, that sounds like an issue with if_epair we should look at.

Fri, Jan 13, 4:26 PM

Thu, Jan 12

vegeta_tuxpowered.net added a comment to D38025: Add "match" rules like in upstream pf.

! In D38025#863920, @kp wrote:
Is this against a recent main? Because that has a (much more basic) "match" implementation already.

Thu, Jan 12, 12:52 PM
vegeta_tuxpowered.net updated the summary of D38025: Add "match" rules like in upstream pf.
Thu, Jan 12, 11:50 AM
vegeta_tuxpowered.net updated the summary of D38024: Properly destroy renamed interfaces.
Thu, Jan 12, 10:17 AM

Wed, Jan 11

vegeta_tuxpowered.net updated the summary of D38025: Add "match" rules like in upstream pf.
Wed, Jan 11, 10:32 PM
vegeta_tuxpowered.net requested review of D38025: Add "match" rules like in upstream pf.
Wed, Jan 11, 9:04 PM
vegeta_tuxpowered.net requested review of D38024: Properly destroy renamed interfaces.
Wed, Jan 11, 8:52 PM

Dec 5 2022

vegeta_tuxpowered.net requested review of D37601: Mark imported state as PFTM_UNLINKED before freeing it.
Dec 5 2022, 4:16 PM