pfsync: Remove deletion of states using the full pfsync_state struct
ClosedPublic
Actions

Authored by vegeta_tuxpowered.net on May 8 2023, 7:42 PM.

Details

Reviewers: None
Commits: rGcdc231bd4949: pfsync: Remove deletion of states using the full pfsync_state struct

Summary

State deletions are sent over pfsync using struct pfsync_del_c. Remove the code for receiving state deletions using struct pfsync_state as such deletions are never sent. Rename functions and constants so that only the "compressed" versions remain.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vegeta_tuxpowered.net created this revision.May 8 2023, 7:42 PM

Herald added subscribers: glebius, melifaro, farrokhi and 2 others. · View Herald TranscriptMay 8 2023, 7:42 PM

vegeta_tuxpowered.net requested review of this revision.May 8 2023, 7:42 PM

vegeta_tuxpowered.net edited the summary of this revision. (Show Details)May 8 2023, 7:56 PM

Remove support for printing the old state deletion messages from tcpdump.

vegeta_tuxpowered.net mentioned this in D39392: Make contents of struct pfsync_state configurable.May 8 2023, 8:49 PM

kp added a subscriber: kp.May 10 2023, 4:36 PM

kp added inline comments.

contrib/tcpdump/print-pfsync.c
120 ↗	(On Diff #121702)	I think we should keep this. tcpdump might have to look at (very) old pfsync traffic.
120 ↗	(On Diff #121702)	(Edit: Posted mostly to hear your thoughts. I can easily ignore this bit when I commit this, there's no need to update the review.)