Page MenuHomeFreeBSD

pf: Improve source node error handling
ClosedPublic

Authored by vegeta_tuxpowered.net on May 2 2023, 8:40 PM.
Tags
None
Referenced Files
F155016506: D39940.id121464.diff
Thu, Apr 30, 5:16 PM
Unknown Object (File)
Tue, Apr 21, 3:10 AM
Unknown Object (File)
Mon, Apr 20, 2:29 AM
Unknown Object (File)
Sat, Apr 11, 9:07 AM
Unknown Object (File)
Fri, Apr 10, 7:45 PM
Unknown Object (File)
Fri, Apr 10, 12:43 AM
Unknown Object (File)
Mar 29 2026, 1:28 PM
Unknown Object (File)
Mar 28 2026, 6:16 PM

Details

Summary

Functions manipulating source nodes can fail due to various reasons like memory allocation errors, hitting configured limits or lack of redirection targets. Ensure those errors are properly caught and propagated in the code. Increase the error counters not only when parsing the main ruleset but the NAT ruleset too.

Cherry-picked from development of D39880
Sponsored by: InnoGames GmbH

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 3 2023, 9:59 AM
This revision was automatically updated to reflect the committed changes.