move SEC_TO_NSEC() out of pf code
Needs ReviewPublic
Actions

Authored by vidwer_fbsdbugs_gmail.com on Thu, Oct 29, 5:36 PM.

Project Tags

None

Referenced Files

	F176824636: D60971.1793437493.diff
	Fri, Oct 30, 9:04 AM

	F176821926: D60971.1793432631.diff
	Fri, Oct 30, 7:43 AM

	F176817045: D60971.1793420640.diff
	Fri, Oct 30, 4:24 AM

	F176816994: D60971.1793420465.diff
	Fri, Oct 30, 4:21 AM

	F176813533: D60971.1793409734.diff
	Fri, Oct 30, 1:22 AM

	F176813523: D60971.1793409721.diff
	Fri, Oct 30, 1:22 AM

	F176804596: D60971.1793387714.diff
	Thu, Oct 29, 7:15 PM

	F176804594: D60971.1793387713.diff
	Thu, Oct 29, 7:15 PM

Subscribers

vegeta_tuxpowered.net

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

This change moves time conversion related code from pf to be available system-wide.
Once the function is available system-wide, it can be used in driver code.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 78565
Build 75448: arc lint + arc unit

Event Timeline

vidwer_fbsdbugs_gmail.com created this revision.Thu, Oct 29, 5:36 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 3 others. · View Herald TranscriptThu, Oct 29, 5:36 PM

vidwer_fbsdbugs_gmail.com requested review of this revision.Thu, Oct 29, 5:36 PM

Harbormaster completed remote builds in B78493: Diff 190739.Thu, Oct 29, 5:36 PM

vidwer_fbsdbugs_gmail.com added a child revision: D60972: introduce MSEC_TO_NSEC().Thu, Oct 29, 5:36 PM

Other than not removing the pfvar.h include I'm happy with the pf changes, but please try to get someone to okay the addition in sys/time.h too.

sys/netpfil/pf/pf.c
77	I don't think we should remove this one. It defines far more than just SEC_TO_NSEC(). It still builds without it, but that's because if_pfsync.h includes it too.
sys/netpfil/pf/pf_ioctl.c
77	Same here. Don't remove this.