Page MenuHomeFreeBSD

mjg (Mateusz Guzik)
nice guy

Projects

User Details

User Since
Jun 4 2014, 10:38 AM (381 w, 1 d)

Recent Activity

Yesterday

mjg requested review of D32084: crypto: hide crypto_destroyreq behind a tunable.
Thu, Sep 23, 7:22 PM
mjg accepted D32076: pf: fix pagefault in pf_getstatus().
Thu, Sep 23, 12:50 PM

Wed, Sep 22

mjg added a comment to D32025: hwpmc: fix performance issues.

yea

Wed, Sep 22, 12:25 PM

Tue, Sep 21

mjg committed R10:590d0715b348: ipsec: enter epoch before calling into ipsec_run_hhooks (authored by mjg).
ipsec: enter epoch before calling into ipsec_run_hhooks
Tue, Sep 21, 5:04 PM
mjg closed D32007: ipsec: enter epoch before calling into ipsec_run_hhooks.
Tue, Sep 21, 5:03 PM
mjg updated the diff for D32007: ipsec: enter epoch before calling into ipsec_run_hhooks.

huh, sorry for the lazy patch

Tue, Sep 21, 2:01 PM
mjg added inline comments to D32025: hwpmc: fix performance issues.
Tue, Sep 21, 9:10 AM

Mon, Sep 20

mjg committed R10:0f28c893a8b7: Remove unnecessary WITNESS check in x86 bus_dma (authored by jah).
Remove unnecessary WITNESS check in x86 bus_dma
Mon, Sep 20, 8:23 PM
mjg added a comment to D32025: hwpmc: fix performance issues.

You should always modify the conter, but only do branch on stuff depending on PMC_HOOK_INSTALLED_ANY

Mon, Sep 20, 11:26 AM

Sat, Sep 18

mjg committed R10:7b2ac8eb9be7: vfs: add missing VIRF_MOUNTPOINT in vfs_mountroot_shuffle (authored by mjg).
vfs: add missing VIRF_MOUNTPOINT in vfs_mountroot_shuffle
Sat, Sep 18, 7:16 PM
mjg committed R10:0d9e99ce3b10: vfs: add the missing vnode interlock in vfs_mountroot_shuffle (authored by mjg).
vfs: add the missing vnode interlock in vfs_mountroot_shuffle
Sat, Sep 18, 7:16 PM
mjg committed R10:f902e4bb04ad: lockmgr: fix lock profiling of face adaptive spinning (authored by mjg).
lockmgr: fix lock profiling of face adaptive spinning
Sat, Sep 18, 10:19 AM
mjg committed R10:a2cb65b8fe97: cache: count vnodes in cache_purgevfs (authored by mjg).
cache: count vnodes in cache_purgevfs
Sat, Sep 18, 10:19 AM
mjg committed R10:5d8e32a66c17: vfs: retire VNODE_REFCOUNT_FENCE_* macros (authored by mjg).
vfs: retire VNODE_REFCOUNT_FENCE_* macros
Sat, Sep 18, 10:19 AM

Fri, Sep 17

mjg updated the summary of D32007: ipsec: enter epoch before calling into ipsec_run_hhooks.
Fri, Sep 17, 3:34 PM
mjg requested review of D32007: ipsec: enter epoch before calling into ipsec_run_hhooks.
Fri, Sep 17, 3:33 PM
mjg abandoned D26586: ng_l2tp: Fix synchronization with node shutdown or reset.

D31476

Fri, Sep 17, 12:50 AM

Thu, Sep 16

mjg committed R10:bef0c20ec74e: Convert cryptostats to a counter_u64 array. (authored by markj).
Convert cryptostats to a counter_u64 array.
Thu, Sep 16, 11:23 AM
mjg committed R10:2ed47b49b822: Remove unused 32-bit compatibility structures from cryptodev. (authored by markj).
Remove unused 32-bit compatibility structures from cryptodev.
Thu, Sep 16, 11:23 AM
mjg committed R10:16ffd822c823: Remove CRYPTO_TIMING. (authored by markj).
Remove CRYPTO_TIMING.
Thu, Sep 16, 11:22 AM
mjg committed R10:2fc0550ec438: opencrypto: add kern.crypto sysctl node (authored by mjg).
opencrypto: add kern.crypto sysctl node
Thu, Sep 16, 11:21 AM

Thu, Sep 9

mjg accepted D31476: Summary: ng_l2tp race fix + ng_uncallout improvements.
Thu, Sep 9, 7:29 PM
mjg added inline comments to D31476: Summary: ng_l2tp race fix + ng_uncallout improvements.
Thu, Sep 9, 6:26 PM

Sun, Sep 5

mjg committed R10:007724cbca6f: hpen(4): removed leftover hpen_final_digi_cb declaration (authored by mjg).
hpen(4): removed leftover hpen_final_digi_cb declaration
Sun, Sep 5, 6:42 PM

Thu, Sep 2

mjg committed R10:6352bbf7be9b: vmem: disable debug.vmem_check by default (authored by mjg).
vmem: disable debug.vmem_check by default
Thu, Sep 2, 6:29 PM
mjg closed D31784: vmem: disable debug.vmem_check by default.
Thu, Sep 2, 6:29 PM
mjg added a comment to D31784: vmem: disable debug.vmem_check by default.

The workload at hand is poudriere and the goal is to make sure the kernel survives with debug.

Thu, Sep 2, 3:26 PM
mjg updated the summary of D31784: vmem: disable debug.vmem_check by default.
Thu, Sep 2, 9:51 AM
mjg requested review of D31784: vmem: disable debug.vmem_check by default.
Thu, Sep 2, 9:51 AM

Mon, Aug 30

mjg added a comment to D31244: arm: Bump KSTACK_PAGES default to match i386/amd64.

It's not deadlocks, it is the kernel getting into a state where stack allocation always fails. Workload pushes a lot of traffic through pf and some through ipsec, then forks + execs tons of processes (I don't know the exact count) -- rinse & repeat. The issue was showed up 3 times so far in less than 2 hours of doing this.

Mon, Aug 30, 10:19 PM

Sat, Aug 28

mjg accepted D31704: Update sysctl name in hwpmc.4 and pmcstat.
Sat, Aug 28, 8:48 AM

Fri, Aug 27

mjg added a comment to D31704: Update sysctl name in hwpmc.4 and pmcstat.
$ git grep kern.hwpmc.nbuffer
share/man/man4/hwpmc.4:.It Va kern.hwpmc.nbuffers Pq integer, read-only
sys/dev/hwpmc/hwpmc_logging.c: * kern.hwpmc.nbuffer -- number of global log buffers
usr.sbin/pmcstat/pmcstat.c:"Please consider tuning the \"kern.hwpmc.nbuffers\" tunable.",
Fri, Aug 27, 8:16 PM

Thu, Aug 26

mjg committed R10:f1e2cc1c667a: vfs: drop dedicated sysinit for mountlist_mtx (authored by mjg).
vfs: drop dedicated sysinit for mountlist_mtx
Thu, Aug 26, 6:53 PM
mjg committed R10:0d28d014c855: vfs: refactor kern_unmount (authored by mjg).
vfs: refactor kern_unmount
Thu, Aug 26, 12:03 PM
mjg committed R10:7b2561b46be6: vfs: stop open-coding vfs_getvfs in kern_unmount (authored by mjg).
vfs: stop open-coding vfs_getvfs in kern_unmount
Thu, Aug 26, 11:39 AM

Aug 24 2021

mjg committed R10:80b1995bb5d6: arm: export actlr as sysctl hw.cpu.quirks.actlr_value (authored by mjg).
arm: export actlr as sysctl hw.cpu.quirks.actlr_value
Aug 24 2021, 2:25 PM
mjg committed R10:36fc38301824: Remove bcopy declaration (authored by mjg).
Remove bcopy declaration
Aug 24 2021, 11:26 AM
mjg committed R10:7ec4365671e3: libkern: remove bcopy (authored by mjg).
libkern: remove bcopy
Aug 24 2021, 11:26 AM
mjg committed R10:9a1d562085cb: mips: retire ovbcopy (authored by mjg).
mips: retire ovbcopy
Aug 24 2021, 11:25 AM
mjg closed D31651: arm64: retire bcopy.

https://cgit.freebsd.org/src/commit/?id=d0bc029b4a1ec6522375a1db7d5fc73e3b0461f3

Aug 24 2021, 11:25 AM
mjg committed R10:d0bc029b4a1e: arm64: retire bcopy (authored by mjg).
arm64: retire bcopy
Aug 24 2021, 11:25 AM
mjg committed R10:38941f5993a1: i386: retire bcopy (authored by mjg).
i386: retire bcopy
Aug 24 2021, 11:25 AM

Aug 23 2021

mjg updated the summary of D31651: arm64: retire bcopy.
Aug 23 2021, 7:56 PM
mjg requested review of D31651: arm64: retire bcopy.
Aug 23 2021, 7:56 PM
mjg committed R10:e72e16c55df4: Remove bzero declaration (authored by mjg).
Remove bzero declaration
Aug 23 2021, 6:39 PM
mjg committed R10:a4c33d65f2f3: mips: retire bzero (authored by mjg).
mips: retire bzero
Aug 23 2021, 6:39 PM
mjg committed R10:11cb9a096c50: powerpc: retire bzero (authored by mjg).
powerpc: retire bzero
Aug 23 2021, 6:39 PM
mjg committed R10:c69cc8d10180: riscv: retire bzero (authored by mjg).
riscv: retire bzero
Aug 23 2021, 6:39 PM
mjg committed R10:e0545190ef5c: i386: retire bzero (authored by mjg).
i386: retire bzero
Aug 23 2021, 6:39 PM
mjg committed R10:8e4f67f17ff2: i386: retire bcmp (authored by mjg).
i386: retire bcmp
Aug 23 2021, 6:38 PM
mjg committed R10:ebc52eabdcc5: mips: retire bcmp (authored by mjg).
mips: retire bcmp
Aug 23 2021, 6:38 PM
mjg added a comment to D31642: altq: Fix panics on rmc_restart().

the assumption in the patch is that vnet is not set, but i'm not going to insist on the assert

Aug 23 2021, 4:23 PM
mjg accepted D31642: altq: Fix panics on rmc_restart().
Aug 23 2021, 4:23 PM
mjg committed R10:362c5920da56: Remove libkern/bcmp.c (authored by mjg).
Remove libkern/bcmp.c
Aug 23 2021, 4:13 PM
mjg committed R10:451756d1baa8: powerpc: retire bcmp (authored by mjg).
powerpc: retire bcmp
Aug 23 2021, 4:13 PM
mjg committed R10:44056f9a7278: riscv: retire bcmp (authored by mjg).
riscv: retire bcmp
Aug 23 2021, 4:13 PM
mjg committed R10:ba32d146077e: arm: hide busdma statistics behind ifdef ARM_BUSDMA_MAPLOAD_STATS (authored by mjg).
arm: hide busdma statistics behind ifdef ARM_BUSDMA_MAPLOAD_STATS
Aug 23 2021, 1:57 PM
mjg committed R10:bf530621e401: pf: save on branching in the common case in pf_test (authored by mjg).
pf: save on branching in the common case in pf_test
Aug 23 2021, 1:52 PM
mjg committed R10:f978fe565e61: pf: assert dir state on pf_test{,6} (authored by mjg).
pf: assert dir state on pf_test{,6}
Aug 23 2021, 1:52 PM
mjg added a comment to D31642: altq: Fix panics on rmc_restart().

I think it would future-proof it to assert curvnet is not set and only set it after taking the lock.

Aug 23 2021, 1:42 PM
mjg committed R10:b65ad70195d8: cache: retire cache_fast_revlookup sysctl (authored by mjg).
cache: retire cache_fast_revlookup sysctl
Aug 23 2021, 1:35 PM
mjg committed R10:7fd856ba07b1: vfs: s/__unused/__diagused in crossmp_* (authored by mjg).
vfs: s/__unused/__diagused in crossmp_*
Aug 23 2021, 1:35 PM
mjg committed R10:a12111562116: arm: retire bzero (authored by mjg).
arm: retire bzero
Aug 23 2021, 1:26 PM
mjg committed R10:1652d2ff09ea: arm64: retire bcmp (authored by mjg).
arm64: retire bcmp
Aug 23 2021, 1:26 PM
mjg committed R10:b2d2a5903518: arm: flip memclr to use memset (authored by mjg).
arm: flip memclr to use memset
Aug 23 2021, 1:26 PM
mjg committed R10:766a7c73e92a: arm64: add read_frequently, read_mostluy and exclusive_cache_line to linker… (authored by mjg).
arm64: add read_frequently, read_mostluy and exclusive_cache_line to linker…
Aug 23 2021, 1:26 PM
mjg committed R10:d47afcb2039f: arm64: retire bzero (authored by mjg).
arm64: retire bzero
Aug 23 2021, 1:26 PM
mjg closed D31217: arm: flip memclr to use memset.
Aug 23 2021, 1:26 PM
mjg closed D31645: arm64: retire bcmp.
Aug 23 2021, 1:26 PM
mjg closed D31644: arm64: retire bzero.
Aug 23 2021, 1:25 PM
mjg closed D31643: arm64: add read_frequently, read_mostluy and exclusive_cache_line to linker script.
Aug 23 2021, 1:25 PM
mjg committed R10:9fc5596c036e: arm: hide busdma statistics behind ifdef ARM_BUSDMA_MAPLOAD_STATS (authored by mjg).
arm: hide busdma statistics behind ifdef ARM_BUSDMA_MAPLOAD_STATS
Aug 23 2021, 12:38 PM
mjg committed R10:43151ddbae85: pf: assert dir state on pf_test{,6} (authored by mjg).
pf: assert dir state on pf_test{,6}
Aug 23 2021, 12:38 PM
mjg committed R10:3a2f9cf487f7: pf: save on branching in the common case in pf_test (authored by mjg).
pf: save on branching in the common case in pf_test
Aug 23 2021, 12:37 PM
mjg committed R10:9134711fb5b7: uipc: avoid circular pr_{slow,fast}timos (authored by kevans).
uipc: avoid circular pr_{slow,fast}timos
Aug 23 2021, 12:35 PM
mjg committed R10:187ea09fbbdd: uipc: create dedicated lists for fast and slow timeout callbacks (authored by mjg).
uipc: create dedicated lists for fast and slow timeout callbacks
Aug 23 2021, 12:35 PM
mjg added a comment to D31476: Summary: ng_l2tp race fix + ng_uncallout improvements.

ping?

Aug 23 2021, 12:08 PM
mjg added a comment to D31126: vget(9): update after r364271.

I think most vfs manpages are drastically outdated and I'm not convinced updating them while maintaining the current setup is worthwhile.

Aug 23 2021, 11:56 AM
mjg added inline comments to D31643: arm64: add read_frequently, read_mostluy and exclusive_cache_line to linker script.
Aug 23 2021, 11:35 AM
mjg updated the diff for D31643: arm64: add read_frequently, read_mostluy and exclusive_cache_line to linker script.
  • flip to 128
Aug 23 2021, 11:35 AM
mjg requested review of D31645: arm64: retire bcmp.
Aug 23 2021, 11:14 AM
mjg requested review of D31644: arm64: retire bzero.
Aug 23 2021, 11:13 AM
mjg requested review of D31643: arm64: add read_frequently, read_mostluy and exclusive_cache_line to linker script.
Aug 23 2021, 11:12 AM
mjg added a comment to D24927: Fix panic in sched_setup_smp when some apics are disabled.

is this getting anywhere?

Aug 23 2021, 10:56 AM

Aug 22 2021

mjg committed R10:614faa32691b: vfs: fix cache-relatecd LOR introduced in the previous change (authored by mjg).
vfs: fix cache-relatecd LOR introduced in the previous change
Aug 22 2021, 4:21 PM

Aug 20 2021

mjg committed R10:5d75ffdd0c67: vfs: remove an unused variable from nameicap_tracker_add (authored by mjg).
vfs: remove an unused variable from nameicap_tracker_add
Aug 20 2021, 5:53 PM
mjg committed R10:dbc689cdef0c: vfs: use vn_lock_pair to avoid establishing an ordering on mount (authored by mjg).
vfs: use vn_lock_pair to avoid establishing an ordering on mount
Aug 20 2021, 5:53 PM
mjg closed D31611: vfs: use vn_lock_pair to avoid establishing an ordering on mount.
Aug 20 2021, 5:52 PM
mjg updated the diff for D31611: vfs: use vn_lock_pair to avoid establishing an ordering on mount.
  • handle some of the stuff earlier
Aug 20 2021, 12:01 PM

Aug 19 2021

mjg requested review of D31611: vfs: use vn_lock_pair to avoid establishing an ordering on mount.
Aug 19 2021, 8:19 AM

Aug 18 2021

mjg accepted D31605: pseudofs: Destroy vncache hashtbl on pseudofs module unload..
Aug 18 2021, 9:24 PM
mjg closed D31592: arm: hide busdma statistics behind ifdef ARM_BUSDMA_MAPLOAD_STATS.

https://cgit.FreeBSD.org/src/commit/?id=aec8ad8a9e6aba2d73c98bd41f2994744aae3d01

Aug 18 2021, 3:39 PM
mjg committed R10:aec8ad8a9e6a: arm: hide busdma statistics behind ifdef ARM_BUSDMA_MAPLOAD_STATS (authored by mjg).
arm: hide busdma statistics behind ifdef ARM_BUSDMA_MAPLOAD_STATS
Aug 18 2021, 3:27 PM
mjg committed R10:2da4005188ce: frag6: do less work in frag6_slowtimo if possible (authored by mjg).
frag6: do less work in frag6_slowtimo if possible
Aug 18 2021, 9:51 AM
mjg committed R10:3fdd170c5825: frag6: drop the volatile keyword from frag6_nfrags and mark with… (authored by mjg).
frag6: drop the volatile keyword from frag6_nfrags and mark with…
Aug 18 2021, 9:51 AM
mjg committed R10:2666f081bac0: ip_reass: do less work in ipreass_slowtimo if possible (authored by mjg).
ip_reass: do less work in ipreass_slowtimo if possible
Aug 18 2021, 9:51 AM
mjg committed R10:8d9f1e9f2be1: ip_reass: drop the volatile keyword from nfrags and mark with… (authored by mjg).
ip_reass: drop the volatile keyword from nfrags and mark with…
Aug 18 2021, 9:51 AM
mjg committed R10:990e592daeb3: ip_reass: do less work in ipreass_slowtimo if possible (authored by mjg).
ip_reass: do less work in ipreass_slowtimo if possible
Aug 18 2021, 9:47 AM
mjg committed R10:86a96281df03: frag6: do less work in frag6_slowtimo if possible (authored by mjg).
frag6: do less work in frag6_slowtimo if possible
Aug 18 2021, 9:47 AM
mjg committed R10:ad9671955a40: ip_reass: drop the volatile keyword from nfrags and mark with… (authored by mjg).
ip_reass: drop the volatile keyword from nfrags and mark with…
Aug 18 2021, 9:47 AM