- User Since
- Jun 4 2014, 10:38 AM (246 w, 17 h)
Tue, Feb 5
Lock acquisition can be moved few lines later, after branching on data. Similarly, unlock can be done earlier.
Fri, Feb 1
That's an error-prone approach. You should always have separate references for both ucred and pucred.
Wed, Jan 30
I don't have an opinion about the userspace API. It does seem a little bit fishy that there is no tight control from that end. I would expect a fully-privileged daemon to get create a credfd an allow certain uids/gids to be switched to. Then it can drop privs. But again, I did not think this through.
Tue, Jan 29
Dec 28 2018
Oops, indeed. Thanks for the fix.
Dec 27 2018
Dec 20 2018
See this review https://reviews.freebsd.org/D27
I have a machine where I reliably fail to git clone postgres repository, it always gets stuck at about 20%. This patch fixes it.
Dec 19 2018
This already landed in r342237, I see I forgot to add the line.
Dec 14 2018
Dec 13 2018
Yea, 1 week.
Dec 11 2018
Dec 8 2018
Dec 7 2018
Dec 5 2018
can you grab a flamegraph from such a test? also, can you compare this against https://reviews.freebsd.org/D17992 ?
Dec 1 2018
I did basic tests with changing the alignment of src and slowdowns were very small compared to similarly misaligned dst, at least on EPYC. I may take a closer look later.
Nov 30 2018
Nov 29 2018
Nov 28 2018
once more i don't have a full picture so can't give a proper review.
Nov 23 2018
Nov 22 2018
- remove now spurious cv_broadcast(&p->p_pwait);
Nov 21 2018
- fix fork