Page MenuHomeFreeBSD

mjg (Mateusz Guzik)
nice guy

Projects

User Details

User Since
Jun 4 2014, 10:38 AM (246 w, 17 h)

Recent Activity

Tue, Feb 5

mjg accepted D19083: extattr_list_vp: Narrow locked section somewhat.
Tue, Feb 5, 3:36 AM
mjg accepted D19082: extattr_list_vp: Only take shared vnode lock.

Lock acquisition can be moved few lines later, after branching on data. Similarly, unlock can be done earlier.

Tue, Feb 5, 3:27 AM

Fri, Feb 1

mjg added a comment to D18930: Per-thread credentials.

That's an error-prone approach. You should always have separate references for both ucred and pucred.

Fri, Feb 1, 4:34 PM

Wed, Jan 30

mjg added a comment to D18930: Per-thread credentials.

I don't have an opinion about the userspace API. It does seem a little bit fishy that there is no tight control from that end. I would expect a fully-privileged daemon to get create a credfd an allow certain uids/gids to be switched to. Then it can drop privs. But again, I did not think this through.

Wed, Jan 30, 4:43 PM

Tue, Jan 29

mjg added inline comments to D18930: Per-thread credentials.
Tue, Jan 29, 12:58 AM

Dec 28 2018

mjg accepted D18665: pfind, pfind_any: Correct zombie logic.

Oops, indeed. Thanks for the fix.

Dec 28 2018, 12:40 AM

Dec 27 2018

mjg added inline comments to D18658: top: fix PID sorting after r340742; add process birth time sorting.
Dec 27 2018, 9:03 PM
mjg added inline comments to D18658: top: fix PID sorting after r340742; add process birth time sorting.
Dec 27 2018, 9:01 PM

Dec 20 2018

mjg added a comment to D18618: Make kernel print jail ID when logging a process exit..

See this review https://reviews.freebsd.org/D27

Dec 20 2018, 11:29 AM
mjg added a comment to D18580: Accept always TCP segment with SEG.SEQ==RCV.NXT.

I have a machine where I reliably fail to git clone postgres repository, it always gets stuck at about 20%. This patch fixes it.

Dec 20 2018, 1:48 AM

Dec 19 2018

mjg committed rS342267: MFC r342053.
MFC r342053
Dec 19 2018, 11:29 PM
mjg committed rS342264: Check for probes enabled in priv_check_cred before evaluting the error..
Check for probes enabled in priv_check_cred before evaluting the error.
Dec 19 2018, 11:28 PM
mjg committed rS342262: Provide SDT_PROBES_ENABLED for kernels without KDTRACE..
Provide SDT_PROBES_ENABLED for kernels without KDTRACE.
Dec 19 2018, 11:19 PM
mjg committed rS342250: MFC r340676,r340677,r340679,r340747,r340749,r341682.
MFC r340676,r340677,r340679,r340747,r340749,r341682
Dec 19 2018, 10:42 PM
mjg committed rS342249: MFC r340482,r341724.
MFC r340482,r341724
Dec 19 2018, 10:38 PM
mjg committed rS342248: MFC r340410.
MFC r340410
Dec 19 2018, 10:31 PM
mjg committed rS342247: mac: reduce pessimization of sdt probe handling.
mac: reduce pessimization of sdt probe handling
Dec 19 2018, 10:30 PM
mjg committed rS342245: Remove iBCS2: plug a wart missed in r342242.
Remove iBCS2: plug a wart missed in r342242
Dec 19 2018, 10:09 PM
mjg committed rS342244: Remove iBCS2, part3: the implementation.
Remove iBCS2, part3: the implementation
Dec 19 2018, 10:03 PM
mjg committed rS342243: Remove iBCS2, part2: general kernel.
Remove iBCS2, part2: general kernel
Dec 19 2018, 9:58 PM
mjg committed rS342242: Remove iBCS2, part1: userspace.
Remove iBCS2, part1: userspace
Dec 19 2018, 9:57 PM
mjg closed D18435: Manage process-related IDs with bitmaps.

This already landed in r342237, I see I forgot to add the line.

Dec 19 2018, 9:29 PM
mjg committed rS342240: MFC r341272,r341273,r341351.
MFC r341272,r341273,r341351
Dec 19 2018, 9:26 PM
mjg committed rS342239: MFC r341719.
MFC r341719
Dec 19 2018, 9:04 PM
mjg committed rS342238: MFC r341364.
MFC r341364
Dec 19 2018, 9:03 PM
mjg committed rS342237: Microoptimize corner case of ID bitmap handling..
Microoptimize corner case of ID bitmap handling.
Dec 19 2018, 8:30 PM
mjg committed rS342236: Deinline vfork handling out of the syscall return path..
Deinline vfork handling out of the syscall return path.
Dec 19 2018, 8:27 PM
mjg committed rS342235: Update priv(9) after r341827.
Update priv(9) after r341827
Dec 19 2018, 8:26 PM

Dec 14 2018

mjg committed rS342058: vfs: mostly depessimize NDINIT_ALL.
vfs: mostly depessimize NDINIT_ALL
Dec 14 2018, 3:55 AM

Dec 13 2018

mjg committed rS342053: dtrace: fix userspace access on boxes with SMAP.
dtrace: fix userspace access on boxes with SMAP
Dec 13 2018, 8:12 PM
mjg closed D18542: dtrace: fix userspace access on boxes with SMAP.
Dec 13 2018, 8:12 PM
mjg added a comment to D18542: dtrace: fix userspace access on boxes with SMAP.

Yea, 1 week.

Dec 13 2018, 7:54 PM
mjg updated the summary of D18542: dtrace: fix userspace access on boxes with SMAP.
Dec 13 2018, 7:33 PM
mjg created D18542: dtrace: fix userspace access on boxes with SMAP.
Dec 13 2018, 7:33 PM

Dec 11 2018

mjg committed rS341827: Remove unused argument to priv_check_cred..
Remove unused argument to priv_check_cred.
Dec 11 2018, 7:32 PM
mjg committed rS341822: audi: replace open-coded TDP_AUDITREC checks with the macro.
audi: replace open-coded TDP_AUDITREC checks with the macro
Dec 11 2018, 5:14 PM
mjg committed rS341819: fd: dedup code in sys_getdtablesize.
fd: dedup code in sys_getdtablesize
Dec 11 2018, 12:08 PM
mjg committed rS341818: Make lim_cur inline if possible..
Make lim_cur inline if possible.
Dec 11 2018, 12:01 PM
mjg committed rS341817: fd: tidy up closing a fd.
fd: tidy up closing a fd
Dec 11 2018, 11:59 AM
mjg committed rS341816: fd: stop looking for exact freefile after allocation.
fd: stop looking for exact freefile after allocation
Dec 11 2018, 11:57 AM

Dec 8 2018

mjg committed rS341727: umtx: avoid umtxshm locking on object termination if possible.
umtx: avoid umtxshm locking on object termination if possible
Dec 8 2018, 2:05 PM
mjg committed rS341724: Remove proctree acquire from note_procstat_proc.
Remove proctree acquire from note_procstat_proc
Dec 8 2018, 11:39 AM
mjg committed rS341723: Fix a corner case in ID bitmap management..
Fix a corner case in ID bitmap management.
Dec 8 2018, 10:22 AM
mjg committed rS341722: proc: postpone proc unlock until after reporting with kqueue.
proc: postpone proc unlock until after reporting with kqueue
Dec 8 2018, 6:34 AM
mjg committed rS341721: proc: handle sdt exit probe before taking the proc lock.
proc: handle sdt exit probe before taking the proc lock
Dec 8 2018, 6:32 AM
mjg committed rS341720: Provide SDT_PROBES_ENABLED macro..
Provide SDT_PROBES_ENABLED macro.
Dec 8 2018, 6:31 AM
mjg committed rS341719: amd64: stop re-reading curpc on subyte/suword.
amd64: stop re-reading curpc on subyte/suword
Dec 8 2018, 4:53 AM

Dec 7 2018

mjg committed rS341702: fd: use racct_set_unlocked.
fd: use racct_set_unlocked
Dec 7 2018, 4:51 PM
mjg committed rS341701: racct: add RACCT_ENABLED macro and racct_set_unlocked.
racct: add RACCT_ENABLED macro and racct_set_unlocked
Dec 7 2018, 4:48 PM
mjg committed rS341700: fd: try do less work with the lock in dup.
fd: try do less work with the lock in dup
Dec 7 2018, 4:45 PM
mjg committed rS341699: vm: use fcmpset for vmspace reference counting.
vm: use fcmpset for vmspace reference counting
Dec 7 2018, 4:25 PM
mjg committed rS341698: Replace hand-rolled unrefs if > 1 with refcount_release_if_not_last.
Replace hand-rolled unrefs if > 1 with refcount_release_if_not_last
Dec 7 2018, 4:11 PM
mjg committed rS341697: refcount: remove a stale comment about conditional ref/unref routines.
refcount: remove a stale comment about conditional ref/unref routines
Dec 7 2018, 4:11 PM
mjg committed rS341685: proc: when exiting move to zombproc before taking proctree.
proc: when exiting move to zombproc before taking proctree
Dec 7 2018, 12:33 PM
mjg committed rS341684: Manage process-related IDs with bitmaps.
Manage process-related IDs with bitmaps
Dec 7 2018, 12:22 PM
mjg committed rS341683: Annotate Giant drop/pickup macros with __predict_false.
Annotate Giant drop/pickup macros with __predict_false
Dec 7 2018, 12:08 PM
mjg committed rS341682: unr64: use locked variant if not __LP64__.
unr64: use locked variant if not __LP64__
Dec 7 2018, 12:08 PM

Dec 5 2018

mjg committed rS341593: sx: retire SX_NOADAPTIVE.
sx: retire SX_NOADAPTIVE
Dec 5 2018, 4:44 PM
mjg created D18435: Manage process-related IDs with bitmaps.
Dec 5 2018, 3:31 PM
mjg added a comment to D18373: pfsync: Performance improvement.

can you grab a flamegraph from such a test? also, can you compare this against https://reviews.freebsd.org/D17992 ?

Dec 5 2018, 10:49 AM

Dec 1 2018

mjg added a comment to D18401: amd64: align memmove buffers to 16 bytes before using rep movs.

I did basic tests with changing the alignment of src and slowdowns were very small compared to similarly misaligned dst, at least on EPYC. I may take a closer look later.

Dec 1 2018, 2:22 PM
mjg committed rS341364: amd64: align target memmove buffer to 16 bytes before using rep movs.
amd64: align target memmove buffer to 16 bytes before using rep movs
Dec 1 2018, 2:20 PM
mjg closed D18401: amd64: align memmove buffers to 16 bytes before using rep movs.
Dec 1 2018, 2:20 PM
mjg created D18401: amd64: align memmove buffers to 16 bytes before using rep movs.
Dec 1 2018, 1:10 PM

Nov 30 2018

mjg committed rS341351: amd64: handle small memmove buffers with overlapping stores.
amd64: handle small memmove buffers with overlapping stores
Nov 30 2018, 8:59 PM
mjg closed D18387: amd64: handle small memmove buffers with overlapping stores.
Nov 30 2018, 8:59 PM
mjg created D18387: amd64: handle small memmove buffers with overlapping stores.
Nov 30 2018, 9:03 AM
mjg committed rS341273: amd64: remove stale attribution for memmove work.
amd64: remove stale attribution for memmove work
Nov 30 2018, 12:48 AM
mjg committed rS341272: amd64: tidy up copying backwards in memmove.
amd64: tidy up copying backwards in memmove
Nov 30 2018, 12:48 AM

Nov 29 2018

mjg committed rS341223: vfs: fix i386 build after r341220.
vfs: fix i386 build after r341220
Nov 29 2018, 9:54 AM
mjg committed rS341222: cache: retire cache_enter compat schim.
cache: retire cache_enter compat schim
Nov 29 2018, 9:33 AM
mjg committed rS341221: audit: predict AUDITING_TD as false.
audit: predict AUDITING_TD as false
Nov 29 2018, 9:22 AM
mjg committed rS341220: vfs: drop spurious memcpy in stat.
vfs: drop spurious memcpy in stat
Nov 29 2018, 9:04 AM
mjg committed rS341219: fd: unify fd range check across the routines.
fd: unify fd range check across the routines
Nov 29 2018, 8:54 AM
mjg committed rS341218: audit: change audit_syscalls_enabled type to bool.
audit: change audit_syscalls_enabled type to bool
Nov 29 2018, 8:40 AM
mjg committed rS341182: Convert racct_enable to bool and annotate as __read_frequently.
Convert racct_enable to bool and annotate as __read_frequently
Nov 29 2018, 5:18 AM
mjg committed rS341181: Deinline racct throttling out of syscall exit path..
Deinline racct throttling out of syscall exit path.
Nov 29 2018, 5:10 AM
mjg committed rS341180: Annotate td_cowgen check as unlikely..
Annotate td_cowgen check as unlikely.
Nov 29 2018, 4:48 AM
mjg committed rS341178: Tidy up hardclock..
Tidy up hardclock.
Nov 29 2018, 3:46 AM
mjg committed rS341176: proc: create a dedicated lock for zombproc to ligthen the load on allproc_lock.
proc: create a dedicated lock for zombproc to ligthen the load on allproc_lock
Nov 29 2018, 2:52 AM
mjg abandoned D17774: Create a dedicated lock for zombproc to ligthen the load on allproc_lock.

https://svnweb.freebsd.org/changeset/base/341176

Nov 29 2018, 2:52 AM

Nov 28 2018

mjg added a comment to D18373: pfsync: Performance improvement.

once more i don't have a full picture so can't give a proper review.

Nov 28 2018, 11:01 PM

Nov 23 2018

mjg committed rS340793: Revert "fork: fix use-after-free with vfork".
Revert "fork: fix use-after-free with vfork"
Nov 23 2018, 4:39 AM

Nov 22 2018

mjg committed rS340786: Annotate TDP_RFPPWAIT as unlikely..
Annotate TDP_RFPPWAIT as unlikely.
Nov 22 2018, 9:38 PM
mjg committed rS340785: fork: remove avoidable proc lock/unlock pair.
fork: remove avoidable proc lock/unlock pair
Nov 22 2018, 9:29 PM
mjg committed rS340784: fork: fix use-after-free with vfork.
fork: fix use-after-free with vfork
Nov 22 2018, 9:08 PM
mjg closed D18295: fork: fix use-after-free with vfork.
Nov 22 2018, 9:08 PM
mjg updated the diff for D18295: fork: fix use-after-free with vfork.
Nov 22 2018, 8:42 PM
mjg updated the diff for D18295: fork: fix use-after-free with vfork.
  • remove now spurious cv_broadcast(&p->p_pwait);
Nov 22 2018, 8:12 PM
mjg added inline comments to D18295: fork: fix use-after-free with vfork.
Nov 22 2018, 6:24 PM
mjg added a comment to D17992: pfsync: Reduce contention on PFSYNC_LOCK().

Adding more rings won't really help any more than making this one ring larger. That merely increases the queue length between the multiple pf threads, and the pfsync processing code (which is still single-threaded) in pfsync_msg_intr() and pfsyncintr().

Nov 22 2018, 5:00 AM
mjg updated the summary of D18295: fork: fix use-after-free with vfork.
Nov 22 2018, 1:03 AM
mjg created D18295: fork: fix use-after-free with vfork.
Nov 22 2018, 1:02 AM

Nov 21 2018

mjg updated the diff for D17774: Create a dedicated lock for zombproc to ligthen the load on allproc_lock.
  • rebase
  • fix fork
Nov 21 2018, 11:54 PM
mjg committed rS340750: strings: unbreak the build after r340746.
strings: unbreak the build after r340746
Nov 21 2018, 10:37 PM
mjg committed rS340749: uipc_usrreq: fix inode number assignment.
uipc_usrreq: fix inode number assignment
Nov 21 2018, 10:25 PM
mjg committed rS340748: proc: update list manipulation comment on process exit.
proc: update list manipulation comment on process exit
Nov 21 2018, 10:16 PM
mjg committed rS340747: uipc_shm: use unr64 for inode numbers.
uipc_shm: use unr64 for inode numbers
Nov 21 2018, 10:01 PM
mjg committed rS340744: proc: convert pfind & friends to use pidhash locks and other cleanup.
proc: convert pfind & friends to use pidhash locks and other cleanup
Nov 21 2018, 8:16 PM
mjg committed rS340742: proc: implement pid hash locks and an iterator.
proc: implement pid hash locks and an iterator
Nov 21 2018, 6:56 PM