User Details
User Details
- User Since
- Jun 4 2014, 10:38 AM (485 w, 4 d)
Yesterday
Yesterday
mjg committed rGaaeaba324335: vfs: fix reference counting/locking on LK_UPGRADE error (authored by olce.freebsd_certner.fr).
vfs: fix reference counting/locking on LK_UPGRADE error
mjg committed rGba4d4882ce72: vfs: count how many times vnlru got woken up due to vnode shortage (authored by mjg).
vfs: count how many times vnlru got woken up due to vnode shortage
vfs: stabilize freevnodes_old
vfs: s/u_long vstir/bool vstir/
vfs: group vnode-related sysctls under vfs.vnode
vfs: retire kern.minvnodes
vfs: retire vnlru_under_unlocked
mjg committed rG4e5833d9aeb9: vfs: use vnlru_read_freevnodes for the freevnodes sysctl (authored by mjg).
vfs: use vnlru_read_freevnodes for the freevnodes sysctl
vfs: fix stale comment about freevnodes management
mjg committed rGdc804471fa88: vfs cache: garbage collect the fullpathfail2 counter (authored by mjg).
vfs cache: garbage collect the fullpathfail2 counter
vfs: don't kick vnlru if it is already running
mjg committed rGaeb0da3771a5: vfs: drop one vnode list lock trip during vnlru free recycle (authored by mjg).
vfs: drop one vnode list lock trip during vnlru free recycle
ufs: restore name cache fast path lookup
mjg committed rG2701cbf16165: vfs cache: fix a hang when bumping vnode limit too high (authored by mjg).
vfs cache: fix a hang when bumping vnode limit too high
drm2: whack set-but-not-used warns
mjg committed rGc76dfb929e70: vfs: fix reference counting/locking on LK_UPGRADE error (authored by olce.freebsd_certner.fr).
vfs: fix reference counting/locking on LK_UPGRADE error
Sat, Sep 23
Sat, Sep 23
mjg added inline comments to D41936: libc: Add memory barriers to quick_exit() and at_quick_exit()..
mjg added inline comments to D41936: libc: Add memory barriers to quick_exit() and at_quick_exit()..
vfs cache: retire dothits and dotdothits counters
Fri, Sep 22
Fri, Sep 22
mjg committed rGe5114cc203a6: vfs: count how many times vnlru got woken up due to vnode shortage (authored by mjg).
vfs: count how many times vnlru got woken up due to vnode shortage
vfs: stabilize freevnodes_old
vfs: s/u_long vstir/bool vstir/
vfs: group vnode-related sysctls under vfs.vnode
vfs: retire kern.minvnodes
mjg committed rG07c081e59232: vfs: use vnlru_read_freevnodes for the freevnodes sysctl (authored by mjg).
vfs: use vnlru_read_freevnodes for the freevnodes sysctl
vfs: retire vnlru_under_unlocked
vfs: fix stale comment about freevnodes management
ufs: restore name cache fast path lookup
mjg committed rG8e4a043bad75: vfs cache: garbage collect the fullpathfail2 counter (authored by mjg).
vfs cache: garbage collect the fullpathfail2 counter
mjg committed rG206dd9d1a82d: vfs: drop one vnode list lock trip during vnlru free recycle (authored by mjg).
vfs: drop one vnode list lock trip during vnlru free recycle
vfs: don't kick vnlru if it is already running
mjg committed rG41fad6503c1e: vfs cache: fix a hang when bumping vnode limit too high (authored by mjg).
vfs cache: fix a hang when bumping vnode limit too high
mjg added a comment to D41764: VFS cache: Make changes to 'ncsize' update 'neg_min'.
Looking at this more it was clearly a bug to have it RW to begin with, fixed here: https://cgit.FreeBSD.org/src/commit/?id=33fdf1afaea931eaa5dd14e6c097d7ffafe2fb1a
vfs cache: mark vfs.cache.param.size as read-only
mjg committed rG02ef039c284b: vfs cache: Drop known argument of internal cache_recalc_neg_min() (authored by olce.freebsd_certner.fr).
vfs cache: Drop known argument of internal cache_recalc_neg_min()
mjg requested changes to D41764: VFS cache: Make changes to 'ncsize' update 'neg_min'.
handling of this sysctl is already broken, it needs to be combined with cache_changesize
Given the above I'm closing this.
mjg committed rG02cbc029dac9: vfs: fix reference counting/locking on LK_UPGRADE error (authored by olce.freebsd_certner.fr).
vfs: fix reference counting/locking on LK_UPGRADE error
mjg added a comment to D41936: libc: Add memory barriers to quick_exit() and at_quick_exit()..
What is supposed to happen when this is a multithreaded program and multiple threads call quick_exit at the same time? While it is silly for such a setup to exist, I had the misfortune of encountering it (albeit with full-blown exit(3)).
Wed, Sep 20
Wed, Sep 20
mjg added a comment to D41806: vfs cache: Fallback to namei to resolve symlinks with leading / in target for non-native ABI.
what is stopping having the same fallback as locked lookup?
Mon, Sep 18
Mon, Sep 18
kern: Globally define abs64
drm2: whack set-but-not-used warns
drm2: whack set-but-not-used warns
drm2: fix build after abs64 became global
Sat, Sep 16
Sat, Sep 16
mjg committed rG9080190b970c: vfs: count how many times vnlru got woken up due to vnode shortage (authored by mjg).
vfs: count how many times vnlru got woken up due to vnode shortage
vfs: stabilize freevnodes_old
zfs: retire z_nr_znodes
vfs: s/u_long vstir/bool vstir/
vfs: group vnode-related sysctls under vfs.vnode
vfs: retire kern.minvnodes
Fri, Sep 15
Fri, Sep 15
mjg committed rG03bfee175269: vfs: use vnlru_read_freevnodes for the freevnodes sysctl (authored by mjg).
vfs: use vnlru_read_freevnodes for the freevnodes sysctl
Thu, Sep 14
Thu, Sep 14
vfs: retire vnlru_under_unlocked
mjg committed rG07f52c4b5a4f: vfs cache: garbage collect the fullpathfail2 counter (authored by mjg).
vfs cache: garbage collect the fullpathfail2 counter
vfs: fix stale comment about freevnodes management
vfs: don't kick vnlru if it is already running
mjg committed rG74be676d8774: vfs: drop one vnode list lock trip during vnlru free recycle (authored by mjg).
vfs: drop one vnode list lock trip during vnlru free recycle
Tue, Sep 12
Tue, Sep 12
mjg added a comment to D41823: Fix geom build with clang 17 and KTR enabled.
is this the only occurence of this "error" in the tree?
Mon, Sep 11
Mon, Sep 11
mjg added a comment to D41806: vfs cache: Fallback to namei to resolve symlinks with leading / in target for non-native ABI.
this would mean lookups of any absolute symlinks for linux emul would be guaranteed to start from scratch, wasting a lot of work
Sat, Sep 9
Sat, Sep 9
ufs: restore name cache fast path lookup
drm2: fix build after abs64 became global
Fri, Sep 8
Fri, Sep 8
mjg added a comment to D41731: vfs_lookup_cross_mount(): Fix reference counting/locking on LK_UPGRADE error.
I found the bug around hte next day after introducing it, it must have slipped through the cracks afterwards.
Sat, Sep 2
Sat, Sep 2
mjg committed rG32988c1499f8: vfs cache: fix a hang when bumping vnode limit too high (authored by mjg).
vfs cache: fix a hang when bumping vnode limit too high
timerfd: convert timerfd_list_lock from sx to mtx
Fri, Sep 1
Fri, Sep 1
pf: retire pf_krule_to_rule and pf_kpool_to_pool
Thu, Aug 31
Thu, Aug 31
mjg added a comment to D41647: pf (t)ftp-proxy: use libpfctl instead of DIOCGETSTATUS.
same comment as for snmp
mjg added a comment to D41650: snmp_pf: use libpfctl's pfctl_get_status() rather than DIOCGETSTATUS.
i don't think there is anyone to review this, just commit
Sun, Aug 27
Sun, Aug 27
vfs: retried++ -> retried = true for the boolean
vfs: trylock vnode requeue
vfs: try harder to find free vnodes when recycling
I'm all for reducing tech debt and complexity in the area.
Aug 25 2023
Aug 25 2023
mjg committed rG35f36c3ee64f: vfs: track how many times vn_alloc blocked on hitting the vnode limit (authored by mjg).
vfs: track how many times vn_alloc blocked on hitting the vnode limit
vfs: flip deferred_inact to atomic
vfs: decouple freevnodes from vnode batching
timerfd: compute fflags before calling falloc
timerfd: fix up a memory leak and missing locking
Aug 24 2023
Aug 24 2023
ufs: try to elide the interlock in ufs_itimes
ufs: always call ufs_itimes on close
mjg added inline comments to D38459: timerfd: Add native support for Linux's timerfd.
vfs: retried++ -> retried = true for the boolean
vfs: try harder to find free vnodes when recycling
Aug 21 2023
Aug 21 2023
I only have cosmetics remarks vs the code, which I'm going to spare this time
it's all fine with me
mjg added a comment to D41349: lib/libc/amd64/string: add baseline implementation of stpcpy.S.
tests can be moved to a different review which will land at a different date if that helps
Aug 20 2023
Aug 20 2023
I thought kib had possibly unresolved concerns.
mjg added a comment to D41349: lib/libc/amd64/string: add baseline implementation of stpcpy.S.
I have no further comments
Aug 18 2023
Aug 18 2023
mjg committed rG64e881f2db96: vfs: track how many times vn_alloc blocked on hitting the vnode limit (authored by mjg).
vfs: track how many times vn_alloc blocked on hitting the vnode limit
Aug 11 2023
Aug 11 2023
mjg added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.
ok, fair. in that case i have no opinion about the posted patch and will defer to other people
mjg added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.
but this is only trying to paper over part of the problem and flush_autofs still does not work?
mjg added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.
So the fsid thing has a problem of being tied to NFS from security standpoint and is not even exported for unprivileged users.
mjg added a comment to D41349: lib/libc/amd64/string: add baseline implementation of stpcpy.S.
there are weird whitespace issues, past that lgtm from asm standpoint
Aug 10 2023
Aug 10 2023
mjg added a comment to D40961: Fix for automount -c inappropriately clearing important mount flags.
The mount update path should grow support for FSID, which would close the problem.
Aug 9 2023
Aug 9 2023
mjg added a comment to D41337: vfs: Validate the vop vectors after the default vops applied.
vfs: retire NAMEI_DIAGNOSTIC