- User Since
- Jun 4 2014, 10:38 AM (181 w, 2 d)
Thu, Nov 23
Wed, Nov 22
Tue, Nov 21
while here can you add 'tested by' and 'discussed with'?
Fri, Nov 17
Does this patch really make sense to go in?
Sun, Nov 12
Sat, Nov 11
Tue, Nov 7
For consistency this should also remove SLOCK/SUNLOCK in the lookup case, otherwise LGTM.
Mon, Nov 6
Sun, Nov 5
Fri, Nov 3
As the name suggests CPUCLOCK_WHICH_PID only wants to match pids. Thus the _NOTID flag is passed to avoid the corner case.
I would say scratch optimising for the _NOTID case. There is only one in-tree user of the flag and it is not expected to receive any tids.
I think checking if pfind may need a similar treatment would be nice.
Wed, Nov 1
Sat, Oct 28
Oct 23 2017
Oct 22 2017
Oct 21 2017
Oct 20 2017
I think the first iteration of the patch should avoid realpath if there is nothing in the target directory.
Oct 19 2017
Oct 18 2017
Oct 14 2017
Oct 13 2017
the idea is half-crap - this code still remains in the hot path, even though it can be eliminated. this can be accomplished by providing a extra system call table and a proxy handler installed in the regular one. the proxy handler will inspect regs and whatnot and will get the syscall number + args from there. it can then proceed to do the crappery to safely call the syscall.
Oct 12 2017
Oct 6 2017
Oct 5 2017
Sep 30 2017
Sep 27 2017
Sep 10 2017
- u_int v_free_count; /* (f) pages free */ u_int v_inactive_target; /* (c) pages desired inactive */ u_int v_pageout_free_min; /* (c) min pages reserved for kernel */ u_int v_interrupt_free_min; /* (c) reserved pages for int code */ u_int v_free_severe; /* (c) severe page depletion point */ + u_int v_free_count VMMETER_ALIGNED; /* (f) pages free */ u_int v_wire_count VMMETER_ALIGNED; /* (a) pages wired down */
Updated the diff to only move counters to the end + pad them.
Sep 9 2017
Annotating mid-struct has 2 problems:
- creates unnecessary holes between stuff prior to and after the counter, i.e. the cacheline preceeding the padded field can have free space which is now unused. extreme case in point, v_inactive_target is getting sandwiched between 2 annotated fields (see below)
- the annotation sets the alignment of the field itself, but does not prevent following fields from being placed immediately afterwards. once more case in point with v_inactive_target