HomeFreeBSD

vfs offset: fix assertion failure in face of racing ffofset and setfl locking

Description

vfs offset: fix assertion failure in face of racing ffofset and setfl locking

Both use the same 16 bit var to store their locked and waiters bits,
then this in file_v_unlock:

state = atomic_load_16(flagsp);
if ((state & lock_wait_bit) == 0 &&
    atomic_cmpset_rel_16(flagsp, state, state & ~lock_bit))
        return;

can fail if for example foffset is being unlocked while setfl is getting
locked.

Afterwards the code assumes there are blocked waiters on foffset.

Reviewed by: kib, markj
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D52915

Details

Provenance
mjgAuthored on Sun, Oct 5, 5:03 PM
Reviewer
kib
Differential Revision
D52915: fix file_v_unlock
Parents
rGf16178e0bba8: vfs foffset: drop weird commentary about offset protection
Branches
Unknown
Tags
Unknown