Page MenuHomeFreeBSD

olce (Olivier Certner)
User

Projects

User Details

User Since
Feb 26 2021, 3:47 PM (282 w, 5 d)

Recent Activity

Sun, Jul 26

olce requested changes to D44456: intelhfi - Intel TD/HFI driver - Part4: Add intelhfi driver's source-code & Makefile..

A quite quick review, which I'll complete later, but unfortunately only after a while since I'm about to be almost completely AFK for ~4 weeks.

Sun, Jul 26, 3:05 PM · Contributor Reviews (src)
olce requested changes to D57940: intelhfi - Intel TD/HFI driver - Part4b: Modifications due to hmp(4) interface change.

Please merge this into D44456.

Sun, Jul 26, 2:24 PM
olce requested changes to D56547: hmp(4): add provider interface.

Please see D56546's herald comment.

Sun, Jul 26, 1:55 PM
olce requested changes to D56546: hmp(4): introduce Heterogeneous MultiProcessing support.

You should probably merge this revision with D56547. I have reviewed the merged result of this one, that one and D57939 (Koine Yuusuke's). Inline comments have been put in the relevant reviews as much as possible, but general comments are all listed below.

Sun, Jul 26, 1:49 PM

Fri, Jul 24

olce committed rG5b5a10e35914: .git-blame-ignore-revs: Fix hash for sys/kern/kern_cpu.c whitespace changes (authored by olce).
.git-blame-ignore-revs: Fix hash for sys/kern/kern_cpu.c whitespace changes
Fri, Jul 24, 4:47 AM
olce committed rG815c4396c74b: .git-blame-ignore-revs: Fix hash for sys/kern/kern_cpu.c whitespace changes (authored by olce).
.git-blame-ignore-revs: Fix hash for sys/kern/kern_cpu.c whitespace changes
Fri, Jul 24, 4:43 AM
olce committed rGf02f552ad788: i386: provide PCPU pc_small_core for amd64 compat (authored by rlibby).
i386: provide PCPU pc_small_core for amd64 compat
Fri, Jul 24, 4:36 AM
olce committed rG49f19f3fab6e: i386: supply thermal interrupt handler (authored by rlibby).
i386: supply thermal interrupt handler
Fri, Jul 24, 4:36 AM
olce committed rG952eb3db7f5c: ps.1: Fix broken comment line (authored by temcbun_gmail.com).
ps.1: Fix broken comment line
Fri, Jul 24, 4:36 AM
olce committed rG272c6a3c0af4: x86/local_apic.c: Add support for installing a thermal interrupt handler (authored by koinec_yahoo.co.jp).
x86/local_apic.c: Add support for installing a thermal interrupt handler
Fri, Jul 24, 4:36 AM
olce committed rGf594f06fa983: acpi_cpu(4): Call ACPI_GET_FEATURES() on a reset 'features' variable (authored by olce).
acpi_cpu(4): Call ACPI_GET_FEATURES() on a reset 'features' variable
Fri, Jul 24, 4:36 AM
olce committed rG93dbde154260: x86/local_apic.c: Factor out version read and max LVT slot computation (authored by olce).
x86/local_apic.c: Factor out version read and max LVT slot computation
Fri, Jul 24, 4:36 AM
olce committed rG45254c2df093: x86/local_apic.c: Fiddle with thermal LVT slot only if supported (authored by olce).
x86/local_apic.c: Fiddle with thermal LVT slot only if supported
Fri, Jul 24, 4:36 AM
olce committed rGde695c62190f: x86/local_apic.c: Thermal interrupt support: Additional style fixes (authored by olce).
x86/local_apic.c: Thermal interrupt support: Additional style fixes
Fri, Jul 24, 4:35 AM
olce committed rG22f80045a186: cpufreq: Fix the incorrect format (authored by aokblast).
cpufreq: Fix the incorrect format
Fri, Jul 24, 4:35 AM
olce committed rG387646c15b6f: files: riscv, arm64: Remove redundant 'ofw_cpu.c' (authored by olce).
files: riscv, arm64: Remove redundant 'ofw_cpu.c'
Fri, Jul 24, 4:35 AM
olce committed rGf7b8a6f156c3: acpi_hpet(4): Remove unused 'acpi_hpet_disabled' boolean (authored by olce).
acpi_hpet(4): Remove unused 'acpi_hpet_disabled' boolean
Fri, Jul 24, 4:35 AM
olce committed rGec59a50a60a3: acpi_cpu(4): Remove unused 'acpi_cpu_disabled' boolean (authored by olce).
acpi_cpu(4): Remove unused 'acpi_cpu_disabled' boolean
Fri, Jul 24, 4:35 AM
olce committed rGf58b90f17ecb: acpi_timer(4): Remove unused 'acpi_timer_disabled' boolean (authored by olce).
acpi_timer(4): Remove unused 'acpi_timer_disabled' boolean
Fri, Jul 24, 4:35 AM
olce committed rGd0fc89b3ba93: sched_ule: Fix off by one in preempt_thresh definition (authored by olce).
sched_ule: Fix off by one in preempt_thresh definition
Fri, Jul 24, 4:35 AM
olce committed rGbd13516d400b: .git-blame-ignore-revs: sys/kern/kern_cpu.c whitespace changes (authored by olce).
.git-blame-ignore-revs: sys/kern/kern_cpu.c whitespace changes
Fri, Jul 24, 4:35 AM
olce committed rG0fc121a6c13e: sched_ule: sched_priority(): More accurate __unused annotation (authored by olce).
sched_ule: sched_priority(): More accurate __unused annotation
Fri, Jul 24, 4:35 AM
olce committed rG87b46f92268b: sched_ule: sched_clock(): Remove a superfluous space (authored by olce).
sched_ule: sched_clock(): Remove a superfluous space
Fri, Jul 24, 4:35 AM
olce committed rG490d561de6da: acpi: Constify thanks to AcpiGetHandle() taking a constant pathname (authored by olce).
acpi: Constify thanks to AcpiGetHandle() taking a constant pathname
Fri, Jul 24, 4:35 AM
olce committed rG13db1010fd22: acpi: Suffix acpi_sleep_enable() with '_locked' (authored by olce).
acpi: Suffix acpi_sleep_enable() with '_locked'
Fri, Jul 24, 4:35 AM

Thu, Jul 23

olce committed rG8b2546469323: x86_msr_op(9): consistently return the value read from MSR (authored by kib).
x86_msr_op(9): consistently return the value read from MSR
Thu, Jul 23, 10:07 AM
olce committed rG2974506cd067: MAC/do: Tests: Fix copyrights (authored by olce).
MAC/do: Tests: Fix copyrights
Thu, Jul 23, 10:07 AM
olce committed rG90f53c300ac9: style.9: Encourage style changes when doing significant modifications (authored by olce).
style.9: Encourage style changes when doing significant modifications
Thu, Jul 23, 10:07 AM
olce committed rG185d7d4a39f9: x86/local_apic.c: Properly calculate the number of LVT entries (authored by kib).
x86/local_apic.c: Properly calculate the number of LVT entries
Thu, Jul 23, 10:03 AM
olce committed rG60d7891a52cd: x86 lapic: Dump LVTs from the ddb show lapic command (authored by kib).
x86 lapic: Dump LVTs from the ddb show lapic command
Thu, Jul 23, 10:03 AM
olce committed rG73e58edc7caa: x86: mask all LAPIC vectors early, before BSP interrupts are enabled (authored by kib).
x86: mask all LAPIC vectors early, before BSP interrupts are enabled
Thu, Jul 23, 10:03 AM
olce committed rGa9e4131375f8: x86/local_apic.c: add lapic_maxlvt() helper (authored by kib).
x86/local_apic.c: add lapic_maxlvt() helper
Thu, Jul 23, 10:03 AM
olce committed rG847c60455a9e: x86/local_apic.c: convert lvts[] and elvts[] arrays to designated initializers (authored by kib).
x86/local_apic.c: convert lvts[] and elvts[] arrays to designated initializers
Thu, Jul 23, 10:03 AM
olce committed rG6ea0ce113c50: i386: supply thermal interrupt handler (authored by rlibby).
i386: supply thermal interrupt handler
Thu, Jul 23, 10:03 AM
olce committed rGb26cf7b48230: x88/local_apic.c: for each lvt element, add LVT register index (authored by kib).
x88/local_apic.c: for each lvt element, add LVT register index
Thu, Jul 23, 10:03 AM
olce committed rGfc759cca5090: acpi_cpu(4): Call ACPI_GET_FEATURES() on a reset 'features' variable (authored by olce).
acpi_cpu(4): Call ACPI_GET_FEATURES() on a reset 'features' variable
Thu, Jul 23, 10:03 AM
olce committed rG94ec0a9c183e: intr/x86: add ioapic_drv_t to reduce number of casts in IO-APIC implementation (authored by ehem_freebsd_m5p.com).
intr/x86: add ioapic_drv_t to reduce number of casts in IO-APIC implementation
Thu, Jul 23, 10:03 AM
olce committed rG7b675fe7306d: x86/local_apic.c: Add support for installing a thermal interrupt handler (authored by koinec_yahoo.co.jp).
x86/local_apic.c: Add support for installing a thermal interrupt handler
Thu, Jul 23, 10:03 AM
olce committed rGde606fe4fd1c: x86/local_apic.c: Factor out version read and max LVT slot computation (authored by olce).
x86/local_apic.c: Factor out version read and max LVT slot computation
Thu, Jul 23, 10:03 AM
olce committed rG2a3374d999fc: x86/local_apic.c: Fiddle with thermal LVT slot only if supported (authored by olce).
x86/local_apic.c: Fiddle with thermal LVT slot only if supported
Thu, Jul 23, 10:03 AM
olce committed rGafd579619956: ps.1: Fix broken comment line (authored by temcbun_gmail.com).
ps.1: Fix broken comment line
Thu, Jul 23, 10:03 AM
olce committed rG55e2f70f6ae1: cpufreq: Fix the incorrect format (authored by aokblast).
cpufreq: Fix the incorrect format
Thu, Jul 23, 10:03 AM
olce committed rG019f643bc0a7: x86/local_apic.c: Thermal interrupt support: Additional style fixes (authored by olce).
x86/local_apic.c: Thermal interrupt support: Additional style fixes
Thu, Jul 23, 10:02 AM
olce committed rG0e4008992fc5: files: riscv, arm64: Remove redundant 'ofw_cpu.c' (authored by olce).
files: riscv, arm64: Remove redundant 'ofw_cpu.c'
Thu, Jul 23, 10:02 AM
olce committed rGcd289575964e: acpi_timer(4): Remove unused 'acpi_timer_disabled' boolean (authored by olce).
acpi_timer(4): Remove unused 'acpi_timer_disabled' boolean
Thu, Jul 23, 10:02 AM
olce committed rG34c289ede0d8: acpi_hpet(4): Remove unused 'acpi_hpet_disabled' boolean (authored by olce).
acpi_hpet(4): Remove unused 'acpi_hpet_disabled' boolean
Thu, Jul 23, 10:02 AM
olce committed rG83e087e0ea21: .git-blame-ignore-revs: sys/kern/kern_cpu.c whitespace changes (authored by olce).
.git-blame-ignore-revs: sys/kern/kern_cpu.c whitespace changes
Thu, Jul 23, 10:02 AM
olce committed rG22b653332451: sched_ule: Fix off by one in preempt_thresh definition (authored by olce).
sched_ule: Fix off by one in preempt_thresh definition
Thu, Jul 23, 10:02 AM
olce committed rG0841ba990d08: acpi_cpu(4): Remove unused 'acpi_cpu_disabled' boolean (authored by olce).
acpi_cpu(4): Remove unused 'acpi_cpu_disabled' boolean
Thu, Jul 23, 10:02 AM
olce committed rG905b6396644d: sched_ule: sched_clock(): Remove a superfluous space (authored by olce).
sched_ule: sched_clock(): Remove a superfluous space
Thu, Jul 23, 10:02 AM
olce committed rGef7f806e511f: sched_ule: sched_priority(): More accurate __unused annotation (authored by olce).
sched_ule: sched_priority(): More accurate __unused annotation
Thu, Jul 23, 10:02 AM
olce committed rG16bab3443331: acpi: Suffix acpi_sleep_enable() with '_locked' (authored by olce).
acpi: Suffix acpi_sleep_enable() with '_locked'
Thu, Jul 23, 10:02 AM
olce committed rG5850343763cb: MAC/do: Clarify comments about flags attached per-ID or per-ID-type (authored by olce).
MAC/do: Clarify comments about flags attached per-ID or per-ID-type
Thu, Jul 23, 10:02 AM
olce committed rGb68849a93253: MAC/do: Tests: Quote the source directory (authored by olce).
MAC/do: Tests: Quote the source directory
Thu, Jul 23, 10:02 AM
olce committed rGf2d42bc8bf12: kern_prot.c: Belatedly add copyright (authored by olce).
kern_prot.c: Belatedly add copyright
Thu, Jul 23, 10:02 AM
olce committed rG3a9e6cc05ae3: MAC/do: Tests: Declare required programs closer to use (authored by olce).
MAC/do: Tests: Declare required programs closer to use
Thu, Jul 23, 10:02 AM
olce committed rG0543d619743d: MAC/do: Tests: Remove shebang lines (authored by olce).
MAC/do: Tests: Remove shebang lines
Thu, Jul 23, 10:02 AM
olce committed rG8b8b4695197f: BSD.tests.dist: Add the new sys/mac/do directory (authored by olce).
BSD.tests.dist: Add the new sys/mac/do directory
Thu, Jul 23, 10:02 AM
olce committed rG330833d8c8bb: MAC/do: Add basic tests on setting rules (authored by olce).
MAC/do: Add basic tests on setting rules
Thu, Jul 23, 10:02 AM
olce committed rG5af7d6930bf3: acpi: On /dev/power suspend, trigger userspace notifications (authored by olce).
acpi: On /dev/power suspend, trigger userspace notifications
Thu, Jul 23, 10:02 AM
olce committed rG9798fb6f3b34: style.9: Fix "parantheses" typos in the new C++ section (authored by trond.endrestol_ximalas.info).
style.9: Fix "parantheses" typos in the new C++ section
Thu, Jul 23, 10:02 AM
olce committed rG8b242548a69e: style.9: Fix two typos in the manual page (authored by gbe).
style.9: Fix two typos in the manual page
Thu, Jul 23, 10:02 AM
olce committed rGa00d53218a09: style.9: relax "return (value)" requirement for C++ (authored by ivy).
style.9: relax "return (value)" requirement for C++
Thu, Jul 23, 10:02 AM
olce committed rG58a0b5d61996: netstat(1): '-w': Banners to appear before a new statistics line, not after (authored by olce).
netstat(1): '-w': Banners to appear before a new statistics line, not after
Thu, Jul 23, 10:02 AM
olce committed rGe1f055c6517e: mac_do.4: Jail parameter takes 'new', not 'enable'; uid_t/gid_t are 32-bit (authored by olce).
mac_do.4: Jail parameter takes 'new', not 'enable'; uid_t/gid_t are 32-bit
Thu, Jul 23, 10:02 AM
olce committed rGe886baa0f124: chroot.2: "filedescriptors" => "file descriptors" (authored by olce).
chroot.2: "filedescriptors" => "file descriptors"
Thu, Jul 23, 10:02 AM
olce committed rG9356619327e7: vfs: Simplify vfs_write_resume()/vn_start_write_refed() (authored by olce).
vfs: Simplify vfs_write_resume()/vn_start_write_refed()
Thu, Jul 23, 10:02 AM
olce committed rG0b81ce7bcbb3: DEVICE_IDENTIFY.9: Fix function call to detect driver in example code (authored by olce).
DEVICE_IDENTIFY.9: Fix function call to detect driver in example code
Thu, Jul 23, 10:02 AM
olce committed rG045b82909cb3: MAC/do: Comments: Rephrase one, fix a typo in another (authored by olce).
MAC/do: Comments: Rephrase one, fix a typo in another
Thu, Jul 23, 10:01 AM
olce committed rG188d88389919: style.9: Fix a typo (missing word) (authored by olce).
style.9: Fix a typo (missing word)
Thu, Jul 23, 10:01 AM
olce committed rGc4b7e6e3b7f4: x86: provide extended description for x86_msr_op(9) (authored by kib).
x86: provide extended description for x86_msr_op(9)
Thu, Jul 23, 10:01 AM
olce committed rG7ad1f88f6f5d: x86: add a safe variant of MSR_OP_SCHED* operations for x86_msr_op(9) (authored by kib).
x86: add a safe variant of MSR_OP_SCHED* operations for x86_msr_op(9)
Thu, Jul 23, 10:01 AM
olce committed rG304d7fcdf48a: kernel dump: dumpsys_gen_pa_next(): Fix "no more chunks" condition detection (authored by olce).
kernel dump: dumpsys_gen_pa_next(): Fix "no more chunks" condition detection
Thu, Jul 23, 10:01 AM
olce committed rGb6bbc04fcd0b: cpufreq(4): cpufreq_levels_sysctl(): Remove always false NULL test (authored by olce).
cpufreq(4): cpufreq_levels_sysctl(): Remove always false NULL test
Thu, Jul 23, 10:01 AM
olce committed rG3d20f69bdaac: sys/sysctl.h: Make it self-contained when included from the kernel (authored by olce).
sys/sysctl.h: Make it self-contained when included from the kernel
Thu, Jul 23, 10:01 AM
olce committed rG1129fecbb722: sys/sysctl.h: Add missing <sys/kassert.h> include (authored by olce).
sys/sysctl.h: Add missing <sys/kassert.h> include
Thu, Jul 23, 10:01 AM
olce committed rGc48111822e54: i386 minidump: Remove unused macros (authored by olce).
i386 minidump: Remove unused macros
Thu, Jul 23, 10:01 AM
olce committed rG4018a762498a: sysctl(9): Booleans: Accept integers to ease knob conversion (authored by olce).
sysctl(9): Booleans: Accept integers to ease knob conversion
Thu, Jul 23, 10:01 AM
olce committed rGfbe6a98490f9: amd64: parse_memmap(): Move comment about size at proper place (authored by olce).
amd64: parse_memmap(): Move comment about size at proper place
Thu, Jul 23, 10:01 AM
olce committed rG3f511fa41b3b: x86: x86_msr_op(): MSR_OP_LOCAL: Disable interrupts on atomic ops (authored by olce).
x86: x86_msr_op(): MSR_OP_LOCAL: Disable interrupts on atomic ops
Thu, Jul 23, 10:01 AM
olce committed rG3e6bdd3acecb: x86: x86_msr_op(): Simplify assertions (authored by olce).
x86: x86_msr_op(): Simplify assertions
Thu, Jul 23, 10:01 AM
olce committed rGeea360993be8: ps(1): Sort headers (authored by olce).
ps(1): Sort headers
Thu, Jul 23, 10:01 AM
olce committed rG370314d0946e: x86: x86_msr_op(): Move setting mode up, delineate logical blocks (authored by olce).
x86: x86_msr_op(): Move setting mode up, delineate logical blocks
Thu, Jul 23, 10:01 AM
olce added a comment to D58336: hwpstate_intel(4): use CPU_FOREACH instead of an IPI.

Nothing planned. I was only trying to clean this up related to the build break, which is now solved. If you'll be cleaning this up soon anyway, I'll be happy to either push this now as-is or drop it entirely and leave it to you. LMK, or, if you don't have a preference, I'll commit tomorrow to clear it off my patch stack.

Thu, Jul 23, 9:29 AM
olce requested changes to D58014: MAC/do: cleanups for the exec_paths objects.

Please integrate this into D58012, having this separate does not make sense, and D58012 does not compile without it.

Thu, Jul 23, 3:22 AM
olce requested changes to D58012: MAC/do: add exec whitelist/blacklist support for mac_do consumers.
Thu, Jul 23, 3:22 AM
olce added a comment to D58012: MAC/do: add exec whitelist/blacklist support for mac_do consumers.

I like the idea presented here, it goes further than some initial thoughts I had. It looks like it could be made to work. However, the implications of this new feature appear not to have been explored thoroughly, and more work remains for the change here to be consistent.

Thu, Jul 23, 3:21 AM

Tue, Jul 21

olce committed rGdeddfa3db956: sched_4bsd: Allocate runqueues only for present CPUs (authored by Minsoo Choo <minsoo@minsoo.io>).
sched_4bsd: Allocate runqueues only for present CPUs
Tue, Jul 21, 2:27 AM
olce committed rG26ef66653448: sched_4bsd: Rename the global runqueue (authored by Minsoo Choo <minsoo@minsoo.io>).
sched_4bsd: Rename the global runqueue
Tue, Jul 21, 2:27 AM
olce committed rG5217b4a728dc: sched_4bsd: Remove obsolete SMP scaling for ticks per priority level (authored by olce).
sched_4bsd: Remove obsolete SMP scaling for ticks per priority level
Tue, Jul 21, 2:27 AM
olce committed rGe8dec0038bd9: sched_4bsd: Fix conflating priority of differently-niced CPU-bound threads (authored by olce).
sched_4bsd: Fix conflating priority of differently-niced CPU-bound threads
Tue, Jul 21, 2:27 AM
olce closed D58000: sched_4bsd: use DPCPU for runq.
Tue, Jul 21, 2:27 AM
olce closed D58065: sched_4bsd: rename runq to runq_global.
Tue, Jul 21, 2:27 AM
olce closed D57827: sched_4bsd: Remove obsolete SMP scaling for ticks per priority level.
Tue, Jul 21, 2:27 AM
olce closed D57826: sched_4bsd: Fix conflating priority of differently-niced CPU-bound threads.
Tue, Jul 21, 2:27 AM

Mon, Jul 20

olce committed rGa6587ae0f46d: sched_ule: Fix selecting lowest priority thread early in corner case (authored by olce).
sched_ule: Fix selecting lowest priority thread early in corner case
Mon, Jul 20, 2:19 AM
olce closed D57829: sched_ule: Fix selecting lowest priority thread early in corner case.
Mon, Jul 20, 2:19 AM
olce added a comment to D57829: sched_ule: Fix selecting lowest priority thread early in corner case.
In D57829#1330701, @minsoochoo0122_proton.me wrote:

Forget what I said above, we cannot do that under current design. I think clamping is fine if 1) it only happens to a few lowest priorities and 2) this situation doesn't happen often.

Mon, Jul 20, 2:15 AM
olce accepted D58336: hwpstate_intel(4): use CPU_FOREACH instead of an IPI.

Fine, though please note I have a lot of rework of hwpstate_intel(4) incoming, in particular dropping this hybrid core detection code, so if you plan more/significant work in this area please liaise with me.

Mon, Jul 20, 12:20 AM

Sun, Jul 19

olce accepted D58332: i386: supply thermal interrupt handler.

Yes, that makes sense.

Sun, Jul 19, 2:36 AM