Page MenuHomeFreeBSD

mchoo (Minsoo Choo)
Minsoo

Projects (7)

User Details

User Since
May 6 2021, 12:00 AM (283 w, 6 d)

Recent Activity

Yesterday

mchoo updated subscribers of D58004: usb_quirk: implement bad remote wakeup and add ASM1074 SS.

ping @jhb and @olce for mentor approval

Tue, Oct 13, 7:51 PM
mchoo committed rG0571d8a0cc60: powerpc: Avoid deadlock when CPUs exchange threads (authored by mchoo).
powerpc: Avoid deadlock when CPUs exchange threads
Tue, Oct 13, 7:51 PM
mchoo closed D59742: powerpc: Avoid deadlock when CPUs exchange threads.
Tue, Oct 13, 7:50 PM
mchoo updated the diff for D58004: usb_quirk: implement bad remote wakeup and add ASM1074 SS.

Add check to usb_handle_remote_wakeup()

Tue, Oct 13, 7:24 PM

Mon, Oct 12

mchoo added inline comments to D58004: usb_quirk: implement bad remote wakeup and add ASM1074 SS.
Mon, Oct 12, 7:01 PM
mchoo updated the diff for D58004: usb_quirk: implement bad remote wakeup and add ASM1074 SS.

Fix indent

Mon, Oct 12, 7:00 PM
mchoo updated the diff for D58004: usb_quirk: implement bad remote wakeup and add ASM1074 SS.
  • Fix indent, conditional, and typo
  • Add ASM2 vendor
Mon, Oct 12, 6:56 PM
mchoo added a comment to D60671: Remove the i386 kernel and i386-only device drivers.

I opened a PR that moves i386 to EXTRA_ARCHES a while ago: https://github.com/freebsd/freebsd-src/pull/2052

Mon, Oct 12, 6:39 PM
mchoo added a comment to D60644: sched: Automatically namespace schedulers' implementation functions.

If we use preprocessors instead of handwriting the scheduler-specific namespacing (e.g. sched_foo), how will it affect the following:

Mon, Oct 12, 4:24 PM
mchoo committed rG9d7269c6b726: Fix build failure after 904efcc64398 (authored by mchoo).
Fix build failure after 904efcc64398
Mon, Oct 12, 4:05 PM
mchoo committed rG975bdb89ecdd: Fix build failure after f02a5391295e (authored by mchoo).
Fix build failure after f02a5391295e
Mon, Oct 12, 4:01 PM
mchoo committed rGbf1a46ffa8af: libkvm: support powerpc64 radix minidumps (authored by mchoo).
libkvm: support powerpc64 radix minidumps
Mon, Oct 12, 4:01 AM
mchoo committed rG904efcc64398: powerpc/radix: include page tables in minidumps (authored by mchoo).
powerpc/radix: include page tables in minidumps
Mon, Oct 12, 4:01 AM
mchoo committed rG344557b3796b: arm: pad minidump page table (authored by mchoo).
arm: pad minidump page table
Mon, Oct 12, 4:01 AM
mchoo committed rG951671e79a3b: ci: Remove Cirrus CI files (authored by mchoo).
ci: Remove Cirrus CI files
Mon, Oct 12, 4:01 AM
mchoo committed rG4017abda6551: powerpc/radix: synchronize temporary kernel mappings (authored by mchoo).
powerpc/radix: synchronize temporary kernel mappings
Mon, Oct 12, 4:01 AM
mchoo committed rG382f26f264bd: libkvm: route powerpc64 minidumps to minidump backend (authored by mchoo).
libkvm: route powerpc64 minidumps to minidump backend
Mon, Oct 12, 4:01 AM
mchoo committed rG281b3c767815: ixl: fix big-endian hardware interface handling (authored by mchoo).
ixl: fix big-endian hardware interface handling
Mon, Oct 12, 4:01 AM
mchoo committed rGea3004b24770: libkvm: support little-endian powerpc64 minidumps (authored by mchoo).
libkvm: support little-endian powerpc64 minidumps
Mon, Oct 12, 4:01 AM
mchoo committed rGb85a27b796c7: libkvm: support powerpc64 radix minidumps (authored by mchoo).
libkvm: support powerpc64 radix minidumps
Mon, Oct 12, 4:00 AM
mchoo committed rGf02a5391295e: powerpc/radix: include page tables in minidumps (authored by mchoo).
powerpc/radix: include page tables in minidumps
Mon, Oct 12, 4:00 AM
mchoo committed rGff904d783889: arm: pad minidump page table (authored by mchoo).
arm: pad minidump page table
Mon, Oct 12, 4:00 AM
mchoo committed rG64060ae4af71: ci: Remove Cirrus CI files (authored by mchoo).
ci: Remove Cirrus CI files
Mon, Oct 12, 4:00 AM
mchoo committed rG2465e78aeca2: powerpc/radix: synchronize temporary kernel mappings (authored by mchoo).
powerpc/radix: synchronize temporary kernel mappings
Mon, Oct 12, 4:00 AM
mchoo committed rGa73e8c4f2663: libkvm: route powerpc64 minidumps to minidump backend (authored by mchoo).
libkvm: route powerpc64 minidumps to minidump backend
Mon, Oct 12, 4:00 AM
mchoo committed rG0687bcb51caa: ixl: fix big-endian hardware interface handling (authored by mchoo).
ixl: fix big-endian hardware interface handling
Mon, Oct 12, 4:00 AM
mchoo committed rG8135c7e49f39: libkvm: support little-endian powerpc64 minidumps (authored by mchoo).
libkvm: support little-endian powerpc64 minidumps
Mon, Oct 12, 4:00 AM

Sat, Oct 10

mchoo accepted D60558: Status/2026Q3/scheduler.adoc: Add report.
Sat, Oct 10, 2:37 AM

Mon, Oct 5

mchoo added a comment to D59620: ldscript.powerpc*: Keep .data.rel.ro out of PT_DYNAMIC.

@jhb Is this ready for commit?

Mon, Oct 5, 2:33 PM
mchoo added a comment to D59742: powerpc: Avoid deadlock when CPUs exchange threads.

@jhb Is this ready to commit?

Mon, Oct 5, 2:15 PM
mchoo updated subscribers of D60034: Add kernel crash dump debugging with lldb.

Ping @jhb and @olce for mentor approval

Mon, Oct 5, 1:38 PM
mchoo added a comment to D60031: runqueue.9: rewrite.

@olce Would you review this as scheduler?

Mon, Oct 5, 1:38 PM
mchoo added a comment to D60002: scheduler.4, sched_{4bsd,ule}.4: sync current scheduler sysctls.

@olce Would you review this as scheduler?

Mon, Oct 5, 1:38 PM
mchoo added a comment to D59651: trap_cfi(9): introduce powerpc implemenation.

Ping @jhb for mentor approval

Mon, Oct 5, 1:37 PM
mchoo added a comment to D59649: trap_cfi(9): introduce amd64 implementation.

@jhb Is this ready for commit?

Mon, Oct 5, 1:37 PM

Fri, Oct 2

mchoo updated subscribers of D44456: intelhfi - Intel TD/HFI driver - Part4: Add intelhfi driver's source-code & Makefile..

Sorry for delaying updating hmp(4). Currently my university lab is preparing to design a new thread replacement policy model for FreeBSD. I want to reflect that design to hmp(4) in advance so we can avoid major overhaul to the subsystem later. Right now we are preparing workload samples for benchmarks and I will notify you in this thread as soon as the design draft is completed.

Thank you for the update on the situation.

Regarding the "new thread replacement policy model for FreeBSD," are you intending to develop a new scheduler? If so, I look forward to it and would like to cooperate as much as possible.

Fri, Oct 2, 4:21 PM · Contributor Reviews (src)
mchoo added a comment to D59988: sched: New scheduler interface definition scheme.

Also, do you have plan to MFC this to stable/15? I don't see this being a breaking change to users and KPI/KBI.

Fri, Oct 2, 4:00 PM
mchoo accepted D59988: sched: New scheduler interface definition scheme.

LGTM, there are many small changes that would be in separate commits in normal cases, but since we are refactoring them anyways, I think they all can be squashed into this one commit.

Fri, Oct 2, 3:56 PM
mchoo committed rG0facbd5a1d1a: sched_ule: fix typo in comment (authored by mchoo).
sched_ule: fix typo in comment
Fri, Oct 2, 3:56 PM
mchoo committed rGabed4cb15735: sched: factor out hogticks calculation into sched_update_hogticks() (authored by mchoo).
sched: factor out hogticks calculation into sched_update_hogticks()
Fri, Oct 2, 3:51 PM
mchoo committed rGa7cedda69532: sched_ule: fix invalid tdq_slice() and sched_slice_min (authored by mchoo).
sched_ule: fix invalid tdq_slice() and sched_slice_min
Fri, Oct 2, 3:51 PM
mchoo committed rG8ef613e6ee9c: sched_ule: fix comment on ts_slice (authored by mchoo).
sched_ule: fix comment on ts_slice
Fri, Oct 2, 3:50 PM
mchoo committed rG8ad706ea6eef: sched_4bsd: fix vague comment (authored by mchoo).
sched_4bsd: fix vague comment
Fri, Oct 2, 3:50 PM
mchoo committed rGf11c5eb89b6b: sched_4bsd: remove obsolete comment (authored by mchoo).
sched_4bsd: remove obsolete comment
Fri, Oct 2, 3:50 PM
mchoo committed rGa4f40ac17dfe: sched_4bsd: move comment to correct location (authored by mchoo).
sched_4bsd: move comment to correct location
Fri, Oct 2, 3:50 PM
mchoo committed rGefd9712ed3a1: sched_4bsd: fix comment in maybe_preempt() (authored by mchoo).
sched_4bsd: fix comment in maybe_preempt()
Fri, Oct 2, 3:50 PM
mchoo committed rGc087ee05b525: sched: fix kern.sched.{4bsd,ule}.slice (authored by mchoo).
sched: fix kern.sched.{4bsd,ule}.slice
Fri, Oct 2, 3:50 PM
mchoo committed rG069c6f651352: sched_ule: fix typo goup to group (authored by mchoo).
sched_ule: fix typo goup to group
Fri, Oct 2, 3:50 PM
mchoo committed rG188234ac6e1c: sched_ule: remove unused KTR_ULE (authored by mchoo).
sched_ule: remove unused KTR_ULE
Fri, Oct 2, 3:50 PM
mchoo committed rGbe9536d3c4d2: sched_4bsd: remove obsolete comment (authored by mchoo).
sched_4bsd: remove obsolete comment
Fri, Oct 2, 3:50 PM
mchoo committed rGe3c943851a9c: sched_4bsd: update function name in comment (authored by mchoo).
sched_4bsd: update function name in comment
Fri, Oct 2, 3:50 PM
mchoo committed rGc0e358871703: sched_4bsd: add static assertion for nice weight (authored by mchoo).
sched_4bsd: add static assertion for nice weight
Fri, Oct 2, 3:50 PM
mchoo committed rGf6bbf7b80e75: sched_4bsd: remove dumping from maybe_preempt() (authored by mchoo).
sched_4bsd: remove dumping from maybe_preempt()
Fri, Oct 2, 3:50 PM
mchoo committed rGc7c6e744ad43: sched_4bsd: remove kern.sched.4bsd.followon (authored by mchoo).
sched_4bsd: remove kern.sched.4bsd.followon
Fri, Oct 2, 3:50 PM
mchoo committed rGf1f19d09d062: sched: rename sched_schedcpu() to sched_sysinit() (authored by mchoo).
sched: rename sched_schedcpu() to sched_sysinit()
Fri, Oct 2, 3:36 PM
mchoo committed rGb406f4ad382d: sched: factor out hogticks calculation into sched_update_hogticks() (authored by mchoo).
sched: factor out hogticks calculation into sched_update_hogticks()
Fri, Oct 2, 3:36 PM
mchoo committed rG3d1b8451da98: sched_ule: fix typo in comment (authored by mchoo).
sched_ule: fix typo in comment
Fri, Oct 2, 3:36 PM
mchoo committed rGbd7d81dedd0b: sched_ule: fix invalid tdq_slice() and sched_slice_min (authored by mchoo).
sched_ule: fix invalid tdq_slice() and sched_slice_min
Fri, Oct 2, 3:36 PM
mchoo committed rG3d898485e707: sched_ule: fix comment on ts_slice (authored by mchoo).
sched_ule: fix comment on ts_slice
Fri, Oct 2, 3:36 PM
mchoo committed rGb74d31398a24: sched_4bsd: fix vague comment (authored by mchoo).
sched_4bsd: fix vague comment
Fri, Oct 2, 3:36 PM
mchoo committed rG78deebb555ac: sched_4bsd: remove obsolete comment (authored by mchoo).
sched_4bsd: remove obsolete comment
Fri, Oct 2, 3:36 PM
mchoo committed rGb47f52ca4197: sched_4bsd: move comment to correct location (authored by mchoo).
sched_4bsd: move comment to correct location
Fri, Oct 2, 3:35 PM
mchoo committed rG48cef9960769: sched_4bsd: fix comment in maybe_preempt() (authored by mchoo).
sched_4bsd: fix comment in maybe_preempt()
Fri, Oct 2, 3:35 PM
mchoo committed rGa97fea97e351: sched: fix kern.sched.{4bsd,ule}.slice (authored by mchoo).
sched: fix kern.sched.{4bsd,ule}.slice
Fri, Oct 2, 3:35 PM
mchoo committed rG99c0a5258540: sched_ule: fix typo goup to group (authored by mchoo).
sched_ule: fix typo goup to group
Fri, Oct 2, 3:35 PM
mchoo committed rG7507347e15d2: sched_ule: remove unused KTR_ULE (authored by mchoo).
sched_ule: remove unused KTR_ULE
Fri, Oct 2, 3:35 PM
mchoo committed rGd6cf09d417b2: sched_4bsd: remove obsolete comment (authored by mchoo).
sched_4bsd: remove obsolete comment
Fri, Oct 2, 3:35 PM
mchoo committed rG27d07865c9f2: sched_4bsd: update function name in comment (authored by mchoo).
sched_4bsd: update function name in comment
Fri, Oct 2, 3:35 PM
mchoo committed rG8e83ca27529c: sched_4bsd: add static assertion for nice weight (authored by mchoo).
sched_4bsd: add static assertion for nice weight
Fri, Oct 2, 3:35 PM
mchoo committed rG9314b1afd302: sched_4bsd: remove dumping from maybe_preempt() (authored by mchoo).
sched_4bsd: remove dumping from maybe_preempt()
Fri, Oct 2, 3:35 PM
mchoo committed rGd33c9cbc3e6e: sched_4bsd: remove kern.sched.4bsd.followon (authored by mchoo).
sched_4bsd: remove kern.sched.4bsd.followon
Fri, Oct 2, 3:35 PM

Mon, Sep 28

mchoo updated the summary of D59742: powerpc: Avoid deadlock when CPUs exchange threads.
Mon, Sep 28, 7:05 PM
mchoo updated the diff for D59742: powerpc: Avoid deadlock when CPUs exchange threads.

update commit message

Mon, Sep 28, 7:05 PM
mchoo added inline comments to D59742: powerpc: Avoid deadlock when CPUs exchange threads.
Mon, Sep 28, 7:01 PM
mchoo updated the summary of D60034: Add kernel crash dump debugging with lldb.
Mon, Sep 28, 4:42 PM
mchoo updated subscribers of D60031: runqueue.9: rewrite.

ping @jhb and @olce (scheduler) for mentor approval

Mon, Sep 28, 4:03 PM
mchoo updated subscribers of D60002: scheduler.4, sched_{4bsd,ule}.4: sync current scheduler sysctls.

ping @jhb and @olce (scheduler) for mentor approval

Mon, Sep 28, 4:03 PM
mchoo added a comment to D59649: trap_cfi(9): introduce amd64 implementation.
In D59649#1378673, @jhb wrote:

Did you modify KGDB to handle fork_trampoline_kthread in its custom unwinder or was it able to use the CFI info?

Mon, Sep 28, 4:01 PM
mchoo committed rG592ede65bd48: libkvm: support powerpc64 radix minidumps (authored by mchoo).
libkvm: support powerpc64 radix minidumps
Mon, Sep 28, 3:55 PM
mchoo committed rGa38a698704b0: powerpc/radix: include page tables in minidumps (authored by mchoo).
powerpc/radix: include page tables in minidumps
Mon, Sep 28, 3:55 PM
mchoo closed D59743: powerpc/radix: add minidump support.
Mon, Sep 28, 3:55 PM
mchoo committed rG4cb357c61c00: arm: pad minidump page table (authored by mchoo).
arm: pad minidump page table
Mon, Sep 28, 3:49 PM
mchoo closed D59716: arm: pad minidump page table.
Mon, Sep 28, 3:49 PM
mchoo committed rG8d31b7856f77: ci: Remove Cirrus CI files (authored by mchoo).
ci: Remove Cirrus CI files
Mon, Sep 28, 3:47 PM
mchoo closed D59858: ci: Remove Cirrus CI files.
Mon, Sep 28, 3:46 PM
mchoo closed D59728: powerpc/radix: synchronize temporary kernel mappings.
Mon, Sep 28, 3:44 PM
mchoo committed rG8970a9f2ef78: powerpc/radix: synchronize temporary kernel mappings (authored by mchoo).
powerpc/radix: synchronize temporary kernel mappings
Mon, Sep 28, 3:44 PM
mchoo committed rG51b1272fca66: libkvm: route powerpc64 minidumps to minidump backend (authored by mchoo).
libkvm: route powerpc64 minidumps to minidump backend
Mon, Sep 28, 3:40 PM
mchoo committed rG7b8f3db50cc9: libkvm: support little-endian powerpc64 minidumps (authored by mchoo).
libkvm: support little-endian powerpc64 minidumps
Mon, Sep 28, 3:40 PM
mchoo closed D59719: libkvm: fix reading ppc64(le) minidumps.
Mon, Sep 28, 3:40 PM
mchoo added inline comments to D59620: ldscript.powerpc*: Keep .data.rel.ro out of PT_DYNAMIC.
Mon, Sep 28, 3:36 PM
mchoo updated the diff for D59620: ldscript.powerpc*: Keep .data.rel.ro out of PT_DYNAMIC.

Update comment

Mon, Sep 28, 3:36 PM
mchoo committed rGbf8c4eaee6ad: ixl: fix big-endian hardware interface handling (authored by mchoo).
ixl: fix big-endian hardware interface handling
Mon, Sep 28, 2:09 PM

Sun, Sep 27

mchoo added inline comments to D60034: Add kernel crash dump debugging with lldb.
Sun, Sep 27, 4:33 PM

Fri, Sep 25

mchoo added reviewers for D60034: Add kernel crash dump debugging with lldb: ziaee, emaste, aokblast.
Fri, Sep 25, 11:40 PM
mchoo requested review of D60034: Add kernel crash dump debugging with lldb.
Fri, Sep 25, 11:40 PM
mchoo added a comment to D59988: sched: New scheduler interface definition scheme.

Syntactically, my preferred way of dealing with this kind of situation is device driver-like declaration where you put required function pointers in a structure and call DECLARE_SCHEDULER. During startup after the scheduler is selected, the kernel can check whether all function pointer members aren't null and panic if there is any null pointer. Although this is weaker than compile-time check, the implementation is clean in a sense of "textbook C".

Fri, Sep 25, 6:36 PM
mchoo requested review of D60031: runqueue.9: rewrite.
Fri, Sep 25, 6:15 PM
mchoo retitled D60002: scheduler.4, sched_{4bsd,ule}.4: sync current scheduler sysctls from sched_{4bsd,ule}.4: sync current scheduler sysctls to scheduler.4, sched_{4bsd,ule}.4: sync current scheduler sysctls.
Fri, Sep 25, 3:51 PM
mchoo updated the diff for D60002: scheduler.4, sched_{4bsd,ule}.4: sync current scheduler sysctls.

Add scheduler.4 as first commit

Fri, Sep 25, 3:51 PM