Page MenuHomeFreeBSD
Feed Advanced Search

Aug 16 2025

minsoochoo0122_proton.me abandoned D41421: Update jemalloc to version 5.3.0.

Closed by https://github.com/freebsd/freebsd-src/pull/1811

Aug 16 2025, 2:42 AM · Contributor Reviews (src)

Jun 16 2025

minsoochoo0122_proton.me abandoned D43624: [2/2] [WIP] Import heimdal 7.8.0.

MIT krb5 has been adopted in CURRENT.

Jun 16 2025, 4:29 AM · Contributor Reviews (src)
minsoochoo0122_proton.me abandoned D43625: [1/2] [WIP] Import Heimdal 7.8.0.

MIT krb5 has been adopted in CURRENT.

Jun 16 2025, 4:29 AM · Contributor Reviews (src)

Jun 12 2025

minsoochoo0122_proton.me updated the summary of D43082: Add .rb files to .gitattributes.
Jun 12 2025, 2:20 PM · docs
minsoochoo0122_proton.me updated the summary of D43082: Add .rb files to .gitattributes.
Jun 12 2025, 2:19 PM · docs
minsoochoo0122_proton.me updated the diff for D43082: Add .rb files to .gitattributes.

Add attributes for image files

Jun 12 2025, 2:16 PM · docs
minsoochoo0122_proton.me updated the diff for D43082: Add .rb files to .gitattributes.

Expand .gitattributes to HTML, CSS, and Perl as well.

Jun 12 2025, 2:13 PM · docs

Feb 22 2025

minsoochoo0122_proton.me abandoned D44769: mysql81-*: Fix mysql80 legacy lines.

Closing as mysql81-{server, client} is not in ports anymore

Feb 22 2025, 4:30 PM

Jan 9 2025

minsoochoo0122_proton.me updated the diff for D43237: Use gnu17 for buildworld.

Fix double empty lines. make buildword success

Jan 9 2025, 10:42 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43237: Use gnu17 for buildworld.

Remove CSTD= c99 from openzfs

Jan 9 2025, 10:41 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D43237: Use gnu17 for buildworld.

Turned out that FreeBSD uses c99 while the upstream uses gnu99. I think it is safe to go for gnu17.

Jan 9 2025, 10:21 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43239: Use gnu17 for buildkernel.

Restore sys/conf/kern.mk
Build success on amd64

Jan 9 2025, 10:13 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D43237: Use gnu17 for buildworld.
In D43237#1103894, @jhb wrote:

Also, the only contrib things I could find that are using c99 explicitly is ZFS. I wonder if those can use c17?

Jan 9 2025, 7:53 PM · Contributor Reviews (src)

Jan 4 2025

minsoochoo0122_proton.me added a comment to D43239: Use gnu17 for buildkernel.

Individual revisions splited from b662ca1d6cd82044c6cb79075e1830b97594bef3 are also on Github. D43236, D43237, and D43239

Jan 4 2025, 6:25 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D43239: Use gnu17 for buildkernel.
In D43239#1101984, @jhb wrote:

Do you have a branch pushed somewhere with these commits split out already?

Jan 4 2025, 6:20 PM · Contributor Reviews (src)

Dec 14 2024

minsoochoo0122_proton.me added inline comments to D41421: Update jemalloc to version 5.3.0.
Dec 14 2024, 2:26 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added inline comments to D41421: Update jemalloc to version 5.3.0.
Dec 14 2024, 2:22 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D41421: Update jemalloc to version 5.3.0.

Fix indent

Dec 14 2024, 2:18 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D41421: Update jemalloc to version 5.3.0.

Rebasing main

Dec 14 2024, 2:01 AM · Contributor Reviews (src)

Dec 13 2024

minsoochoo0122_proton.me added a comment to D43239: Use gnu17 for buildkernel.
In D43239#1095174, @jhb wrote:

So the static_assert() change needs to go in first I think which is all but the CSTD change as a commit.

Dec 13 2024, 3:57 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43239: Use gnu17 for buildkernel.
  • Add static_assert for kernel
  • Use gnu17 for buildkernel
Dec 13 2024, 3:57 AM · Contributor Reviews (src)

Dec 8 2024

minsoochoo0122_proton.me added a comment to D43239: Use gnu17 for buildkernel.

Are there any blocking issues for this pr? If not, can we commit the patch to the repo?

Dec 8 2024, 4:08 PM · Contributor Reviews (src)

Sep 12 2024

minsoochoo0122_proton.me closed D44145: Disable C standards under C99 from kernel build.

This revision has landed

Sep 12 2024, 9:28 PM · Contributor Reviews (src)

Apr 13 2024

minsoochoo0122_proton.me updated the diff for D44769: mysql81-*: Fix mysql80 legacy lines.

update

Apr 13 2024, 3:53 AM
minsoochoo0122_proton.me updated the diff for D44769: mysql81-*: Fix mysql80 legacy lines.

Fix commit log and pkg-descr

Apr 13 2024, 2:37 AM
minsoochoo0122_proton.me added a reviewer for D44769: mysql81-*: Fix mysql80 legacy lines: Contributor Reviewers (ports).
Apr 13 2024, 2:26 AM
minsoochoo0122_proton.me requested review of D44769: mysql81-*: Fix mysql80 legacy lines.
Apr 13 2024, 2:25 AM

Apr 12 2024

minsoochoo0122_proton.me added inline comments to D44145: Disable C standards under C99 from kernel build.
Apr 12 2024, 11:03 PM · Contributor Reviews (src)

Apr 9 2024

minsoochoo0122_proton.me added a comment to D41421: Update jemalloc to version 5.3.0.

Build Success

Apr 9 2024, 11:33 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the test plan for D41421: Update jemalloc to version 5.3.0.
Apr 9 2024, 11:30 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D41421: Update jemalloc to version 5.3.0.

git rebase main

Apr 9 2024, 10:13 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44665: stddef.h: Update for C23.
Apr 9 2024, 8:49 PM · Contributor Reviews (src)

Apr 7 2024

minsoochoo0122_proton.me added a comment to D44667: vm_reserv_reclaim_contig: Return NULL not false.

I'm not completely familar with FreeBSD's virtual memory system. But it seems the comment still doesn't match the code. Doesn't it return m_ret when the reclaim is successful and null when failed?

Apr 7 2024, 5:51 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the test plan for D44667: vm_reserv_reclaim_contig: Return NULL not false.
Apr 7 2024, 5:45 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44667: vm_reserv_reclaim_contig: Return NULL not false.
Apr 7 2024, 5:44 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D44664: stdbool.h: Update for C23.

Removed redundant macros

Apr 7 2024, 4:27 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added inline comments to D44664: stdbool.h: Update for C23.
Apr 7 2024, 4:23 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added inline comments to D44665: stddef.h: Update for C23.
Apr 7 2024, 4:20 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44666: sys/types.h: Do not define bool macros for C23 and later: Contributor Reviews (src).
Apr 7 2024, 3:15 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44666: sys/types.h: Do not define bool macros for C23 and later.
Apr 7 2024, 3:15 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44665: stddef.h: Update for C23: Contributor Reviews (src).
Apr 7 2024, 3:10 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44665: stddef.h: Update for C23.
Apr 7 2024, 3:09 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D44664: stdbool.h: Update for C23.

Add __STDC_VERSION_STDBOOL_H__ as the header file now conforms C23.

Apr 7 2024, 2:21 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44664: stdbool.h: Update for C23: Contributor Reviews (src).
Apr 7 2024, 2:11 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44664: stdbool.h: Update for C23.
Apr 7 2024, 2:11 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D44663: stdalign.h: Disable for C23.

Fix grammar in the commit message

Apr 7 2024, 1:02 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44663: stdalign.h: Disable for C23: Contributor Reviews (src).
Apr 7 2024, 1:01 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44663: stdalign.h: Disable for C23.
Apr 7 2024, 1:01 AM · Contributor Reviews (src)

Apr 6 2024

minsoochoo0122_proton.me abandoned D44660: llvm-project: Fix build on devel/llvm18.

Fixed by 5f757f3ff9144b609b3c433dfd370cc6bdc191ad and cb14a3fe5122c879eae1fb480ed7ce82a699ddb6

Apr 6 2024, 11:29 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D44660: llvm-project: Fix build on devel/llvm18.

When will we merge the upstream llvm-project to freebsd-src? Are there any issues blocking the merge?

Apr 6 2024, 9:54 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D44660: llvm-project: Fix build on devel/llvm18.
Apr 6 2024, 7:56 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44660: llvm-project: Fix build on devel/llvm18: Contributor Reviews (src).
Apr 6 2024, 7:55 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44660: llvm-project: Fix build on devel/llvm18.
Apr 6 2024, 7:54 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43239: Use gnu17 for buildkernel.

Fixed macro

Apr 6 2024, 3:16 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D43254: libc: Remove support for pre-C11 C standards.

@jrtc27 Can you review the changes?

Apr 6 2024, 12:40 AM · Contributor Reviews (src)

Mar 29 2024

minsoochoo0122_proton.me abandoned D43274: devel/autoconf-archive: update to 2023.02.20.

Closed by 51738fb7bd8f8f28abeeac6e4630f92822e2af42

Mar 29 2024, 6:51 PM

Mar 11 2024

minsoochoo0122_proton.me added a comment to D43239: Use gnu17 for buildkernel.

Are there any more changes required?

Mar 11 2024, 5:42 AM · Contributor Reviews (src)

Feb 28 2024

minsoochoo0122_proton.me added inline comments to D43254: libc: Remove support for pre-C11 C standards.
Feb 28 2024, 11:46 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D44145: Disable C standards under C99 from kernel build.
Feb 28 2024, 11:46 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44145: Disable C standards under C99 from kernel build.
Feb 28 2024, 11:45 PM · Contributor Reviews (src)
minsoochoo0122_proton.me retitled D43254: libc: Remove support for pre-C11 C standards from Remove support for pre-C11 C standards to libc: Remove support for pre-C11 C standards.
Feb 28 2024, 11:43 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43254: libc: Remove support for pre-C11 C standards.

Separate commit

Feb 28 2024, 11:43 PM · Contributor Reviews (src)

Feb 18 2024

minsoochoo0122_proton.me removed a watcher for linuxkpi: minsoochoo0122_proton.me.
Feb 18 2024, 11:54 PM

Feb 4 2024

minsoochoo0122_proton.me added a reviewer for D43730: vm: Convert boolean_t to bool: Contributor Reviews (src).
Feb 4 2024, 9:50 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D43742: rpcsvc/yp_prot.h: remove redundant definition of bool: Contributor Reviews (src).
Feb 4 2024, 9:49 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43742: rpcsvc/yp_prot.h: remove redundant definition of bool.
Feb 4 2024, 9:49 PM · Contributor Reviews (src)

Feb 3 2024

minsoochoo0122_proton.me retitled D43726: libc: Specify parameter types for function pointer from libc: Specify paremeter types for function pointer to libc: Specify parameter types for function pointer.
Feb 3 2024, 11:49 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43726: libc: Specify parameter types for function pointer.

Fixed typo in commit message

Feb 3 2024, 11:49 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43730: vm: Convert boolean_t to bool.

Convert vm_reserv_t->inpartpopq from char to bool

Feb 3 2024, 11:46 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the test plan for D43730: vm: Convert boolean_t to bool.
Feb 3 2024, 11:28 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43730: vm: Convert boolean_t to bool.
Feb 3 2024, 11:26 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43729: pmap: Reflect 1f1b228 in man page.
Feb 3 2024, 11:24 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43729: pmap: Reflect 1f1b228 in man page.
Feb 3 2024, 11:24 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D43726: libc: Specify parameter types for function pointer: Contributor Reviews (src).
Feb 3 2024, 9:55 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43726: libc: Specify parameter types for function pointer.
Feb 3 2024, 9:55 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43722: pmap: Reflect 1f1b228 in man page.
Feb 3 2024, 6:07 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43722: pmap: Reflect 1f1b228 in man page.
Feb 3 2024, 6:06 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43715: ctfmerge: remove function cast of strcompare() for qsort().

Updated commit message

Feb 3 2024, 2:57 AM · Contributor Reviews (src)
minsoochoo0122_proton.me retitled D43715: ctfmerge: remove function cast of strcompare() for qsort() from ctfmerge: specify parameter types of strcompare() for qsort() to ctfmerge: remove function cast of strcompare() for qsort().
Feb 3 2024, 2:55 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43715: ctfmerge: remove function cast of strcompare() for qsort().

Remove cast to function pointer

Feb 3 2024, 2:51 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D43715: ctfmerge: remove function cast of strcompare() for qsort(): Contributor Reviews (src).
Feb 3 2024, 2:13 AM · Contributor Reviews (src)

Feb 2 2024

minsoochoo0122_proton.me updated the summary of D43715: ctfmerge: remove function cast of strcompare() for qsort().
Feb 2 2024, 10:12 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43715: ctfmerge: remove function cast of strcompare() for qsort().
Feb 2 2024, 10:12 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43239: Use gnu17 for buildkernel.
Feb 2 2024, 5:58 AM · Contributor Reviews (src)

Jan 30 2024

minsoochoo0122_proton.me planned changes to D43624: [2/2] [WIP] Import heimdal 7.8.0.
Jan 30 2024, 1:34 PM · Contributor Reviews (src)
minsoochoo0122_proton.me abandoned D43660: Replace boolean_t with bool.
Jan 30 2024, 6:13 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43660: Replace boolean_t with bool.
Jan 30 2024, 5:12 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43660: Replace boolean_t with bool.
Jan 30 2024, 5:10 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the test plan for D43660: Replace boolean_t with bool.
Jan 30 2024, 5:10 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43660: Replace boolean_t with bool.
Jan 30 2024, 5:09 AM · Contributor Reviews (src)
minsoochoo0122_proton.me planned changes to D43660: Replace boolean_t with bool.
Jan 30 2024, 5:02 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43660: Replace boolean_t with bool.
Jan 30 2024, 5:02 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43237: Use gnu17 for buildworld.
Jan 30 2024, 12:48 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D43254: libc: Remove support for pre-C11 C standards.

Commit message should probably be qualified with "for kernel compilation"?

Jan 30 2024, 12:46 AM · Contributor Reviews (src)

Jan 29 2024

minsoochoo0122_proton.me updated the diff for D43254: libc: Remove support for pre-C11 C standards.

Restored changes in usr.bin/lex

Jan 29 2024, 9:19 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D43641: style(9): Remove subversion keyword.

Do I need to update the date of this man page?

Jan 29 2024, 9:03 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43239: Use gnu17 for buildkernel.

Move the definition of static_assert in <sys/systm.h>
Previous definition for linux compatibility is removed due to type definition conflict

Jan 29 2024, 8:31 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D43641: style(9): Remove subversion keyword: Contributor Reviews (src).
Jan 29 2024, 2:31 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43641: style(9): Remove subversion keyword.
Jan 29 2024, 2:31 AM · Contributor Reviews (src)

Jan 28 2024

minsoochoo0122_proton.me retitled D43624: [2/2] [WIP] Import heimdal 7.8.0 from [WIP] Import heimdal 7.8.0 to [2/2] [WIP] Import heimdal 7.8.0.
Jan 28 2024, 5:33 AM · Contributor Reviews (src)