Paths

Table of Contentst

Replace boolean_t with bool
AbandonedPublic
Actions

Authored by minsoochoo0122_proton.me on Jan 30 2024, 5:02 AM.

Details

Reviewers

andrew
slm
manu
jrtc27

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Contributor Reviews (src)

Summary

This might not be a right way to fix types since style(9) does not accept syntax changes.

bool (or _Bool) is C standard whereas boolean_t is not. This can cause problems in both userland and kernel.

An exemple of this is ioat.c, where intrdelay_supported and is_submitter_processing are supposed to be 0/1 bool values, but they are actually int behind the hood.
This means values other than 0/1 can be accepted, which is not a intended behaviour of bool type.

cddl/, contrib/, sys/contrib/, and crypto/ are excluded.

ZFS related code is also excluded such as bectl(8) since boolean_t is still used in OpenZFS.

Test Plan

make buildworld && make buildkernel

I tested by building UFS raw vm image and running it on bhyve.

regression tests might be needed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 55705
Build 52594: arc lint + arc unit

Event Timeline

minsoochoo0122_proton.me created this revision.Jan 30 2024, 5:02 AM

Owners added a reviewer: Restricted Owners Package.Jan 30 2024, 5:02 AM

Herald added a reviewer: andrew. · View Herald TranscriptJan 30 2024, 5:02 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: slm. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, glebius, ehem_freebsd_m5p.com and 5 others. · View Herald Transcript

minsoochoo0122_proton.me requested review of this revision.Jan 30 2024, 5:02 AM

Harbormaster completed remote builds in B55705: Diff 133560.Jan 30 2024, 5:02 AM

minsoochoo0122_proton.me planned changes to this revision.Jan 30 2024, 5:02 AM

minsoochoo0122_proton.me requested review of this revision.Jan 30 2024, 5:09 AM

minsoochoo0122_proton.me edited the summary of this revision. (Show Details)

minsoochoo0122_proton.me edited the test plan for this revision. (Show Details)

minsoochoo0122_proton.me added a reviewer: Contributor Reviews (src).

minsoochoo0122_proton.me added a project: Contributor Reviews (src).

minsoochoo0122_proton.me edited the test plan for this revision. (Show Details)

minsoochoo0122_proton.me added a subscriber: Contributor Reviews (src).

minsoochoo0122_proton.me edited the summary of this revision. (Show Details)Jan 30 2024, 5:12 AM

This kind of diff is way too big to review, it needs to be broken up. It's easy to mass rename like this but a lot harder to verify that you've actually done the right thing. The second file I picked to look at the diff at was clearly not correct (see the comment linked to this), so that doesn't bode well for the rest of the diff. Also some of the NIC drivers in the tree are really vendor imports, so any changes like this that get made to them should make their way upstream, otherwise there is a risk they got lost. I have not checked if that applies here or not.

sys/dev/cxgbe/osdep.h
79	Clearly not what you want here

This revision now requires changes to proceed.Jan 30 2024, 5:22 AM

minsoochoo0122_proton.me abandoned this revision.Jan 30 2024, 6:13 AM

Large Diff

This large diff affects 224 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

share/

man/

man9/

pmap_is_modified.9

2 lines

pmap_is_prefaultable.9

2 lines

pmap_page_exists_quick.9

2 lines

vm_map_check_protection.9

2 lines

vm_map_lookup.9

2 lines

vm_map_sync.9

4 lines

vm_page_bits.9

2 lines

sys/

amd64/

db_disasm.c

2 lines

db_trace.c

2 lines

pmap.c

76 lines

include/

pmap.h

6 lines

arm/

22 lines

2 lines

64 lines

2 lines

broadcom/

bcm2835/

bcm2835_mbox.c

2 lines

bcm2835_mbox_prop.h

2 lines

freescale/

imx/

imx6_anatop.c

6 lines

include/

2 lines

2 lines

2 lines

20 lines

2 lines

mv/

a37x0_iic.c

2 lines

armada/

10 lines

4 lines

2 lines

2 lines

nvidia/

drm2/

tegra_hdmi.c

2 lines

ti/

ti_sdhci.c

6 lines

arm64/

gic_v3_var.h

2 lines

pmap.c

32 lines

coresight/

coresight.h

4 lines

coresight_tmc.h

2 lines

iommu/

iommu_pmap.c

4 lines

dev/

beri/

virtio/

network/

if_vtbe.c

2 lines

cxgbe/

osdep.h

2 lines

fdt/

fdt_clock.c

4 lines

ffec/

if_ffec.c

12 lines

glxiic/

glxiic.c

2 lines

hyperv/

storvsc/

hv_storvsc_drv_freebsd.c

14 lines

utilities/

hv_kvp.c

10 lines

hv_snapshot.c

4 lines

vmbus/

vmbus_br.c

14 lines

vmbus_brvar.h

10 lines

vmbus_chan.c

16 lines

iicbus/

controller/

rockchip/

rk_i2c.c

2 lines

ioat/

ioat.c

16 lines

ioat_internal.h

22 lines

iwm/

16 lines

2 lines

12 lines

4 lines

2 lines

2 lines

6 lines

6 lines

2 lines

2 lines

4 lines

4 lines

10 lines

ixgbe/

if_sriov.c

4 lines

ixgbe_osdep.h

2 lines

mpr/

mpr_user.c

2 lines

mps/

mps_user.c

2 lines

mrsas/

mrsas.h

24 lines

mrsas.c

4 lines

mrsas_cam.c

8 lines

neta/

if_mvneta.c

12 lines

if_mvneta_fdt.c

8 lines

if_mvnetavar.h

16 lines

netmap/

netmap_freebsd.c

2 lines

oce/

10 lines

10 lines

4 lines

8 lines

ofw/

4 lines

2 lines

4 lines

2 lines

4 lines

sdhci/

fsl_sdhci.c

4 lines

sfxge/

common/

50 lines

46 lines

44 lines

4 lines

6 lines

4 lines

2 lines

10 lines

8 lines

12 lines

8 lines

2 lines

144 lines

4 lines

42 lines

28 lines

70 lines

16 lines

42 lines

28 lines

18 lines

34 lines

12 lines

2 lines

2 lines

8 lines

12 lines

12 lines

10 lines

6 lines

2 lines

12 lines

2 lines

4 lines

4 lines

6 lines

2 lines

4 lines

26 lines

4 lines

2 lines

2 lines

4 lines

2 lines

6 lines

2 lines

smartpqi/

2 lines

8 lines

2 lines

8 lines

14 lines

2 lines

smartpqi_prototypes.h

32 lines

smartpqi_queue.c

2 lines

smartpqi_request.c

58 lines

smartpqi_response.c

6 lines

smartpqi_structures.h

68 lines

usb/

input/

atp.c

52 lines

serial/

uftdi.c

4 lines

vnic/

30 lines

6 lines

2 lines

20 lines

18 lines

2 lines

4 lines

4 lines

4 lines

vt/

hw/

vga/

vt_vga.c

2 lines

xen/

gntdev/

gntdev.c

2 lines

privcmd/

privcmd.c

4 lines

xilinx/

if_xaevar.h

6 lines

fs/

tarfs/

tarfs_subr.c

2 lines

tarfs_vfsops.c

8 lines

tmpfs/

tmpfs.h

2 lines

tmpfs_subr.c

10 lines

geom/

cache/

g_cache.c

4 lines

concat/

g_concat.c

4 lines

eli/

g_eli.h

8 lines

g_eli.c

2 lines

g_eli_privacy.c

2 lines

gate/

g_gate.c

2 lines

label/

g_label.c

4 lines

mountver/

g_mountver.c

4 lines

nop/

g_nop.c

4 lines

raid3/

g_raid3.c

4 lines

shsec/

g_shsec.c

4 lines

stripe/

g_stripe.c

4 lines

virstor/

g_virstor.c

12 lines

i386/

pmap.c

64 lines

pmap_base.c

14 lines

vm_machdep.c

2 lines

include/

pmap.h

4 lines

pmap_base.h

14 lines

sf_buf.h

2 lines

kern/

4 lines

4 lines

2 lines

2 lines

4 lines

2 lines

net/

ieee8023ad_lacp.h

4 lines

ieee8023ad_lacp.c

10 lines

powerpc/

aim/

mmu_oea.c

34 lines

mmu_oea64.c

32 lines

mmu_radix.c

64 lines

booke/

pmap.c

28 lines

pmap_32.c

8 lines

pmap_64.c

4 lines

include/

mmuvar.h

10 lines

ofw_machdep.h

2 lines

pmap.h

4 lines

ofw/

ofw_machdep.c

4 lines

powerpc/

db_trace.c

4 lines

pmap_dispatch.c

14 lines

riscv/

pmap.c

24 lines

sys/

conf.h

2 lines

sf_buf.h

2 lines

vm/

4 lines

6 lines

14 lines

4 lines

4 lines

4 lines

4 lines

4 lines

10 lines

20 lines

6 lines

14 lines

34 lines

2 lines

4 lines

2 lines

2 lines

2 lines

10 lines

4 lines

2 lines

8 lines

4 lines

Replace boolean_t with boolAbandonedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 133560

share/man/man9/pmap_is_modified.9

share/man/man9/pmap_is_prefaultable.9

share/man/man9/pmap_page_exists_quick.9

share/man/man9/vm_map_check_protection.9

share/man/man9/vm_map_lookup.9

share/man/man9/vm_map_sync.9

share/man/man9/vm_page_bits.9

sys/amd64/amd64/db_disasm.c

sys/amd64/amd64/db_trace.c

sys/amd64/amd64/pmap.c

sys/amd64/include/pmap.h

sys/arm/arm/debug_monitor.c

sys/arm/arm/mpcore_timer.c

sys/arm/arm/pmap-v6.c

sys/arm/arm/vfp.c

sys/arm/broadcom/bcm2835/bcm2835_mbox.c

sys/arm/broadcom/bcm2835/bcm2835_mbox_prop.h

sys/arm/freescale/imx/imx6_anatop.c

sys/arm/include/kdb.h

sys/arm/include/pl310.h

sys/arm/include/pmap.h

sys/arm/include/pmap_var.h

sys/arm/include/vfp.h

sys/arm/mv/a37x0_iic.c

sys/arm/mv/armada/thermal.c

sys/arm/mv/mpic.c

sys/arm/mv/mv_common.c

sys/arm/mv/timer.c

sys/arm/nvidia/drm2/tegra_hdmi.c

sys/arm/ti/ti_sdhci.c

sys/arm64/arm64/gic_v3_var.h

sys/arm64/arm64/pmap.c

sys/arm64/coresight/coresight.h

sys/arm64/coresight/coresight_tmc.h

sys/arm64/iommu/iommu_pmap.c

sys/dev/beri/virtio/network/if_vtbe.c

sys/dev/cxgbe/osdep.h

sys/dev/fdt/fdt_clock.c

sys/dev/ffec/if_ffec.c

sys/dev/glxiic/glxiic.c

sys/dev/hyperv/storvsc/hv_storvsc_drv_freebsd.c

sys/dev/hyperv/utilities/hv_kvp.c

sys/dev/hyperv/utilities/hv_snapshot.c

sys/dev/hyperv/vmbus/vmbus_br.c

sys/dev/hyperv/vmbus/vmbus_brvar.h

sys/dev/hyperv/vmbus/vmbus_chan.c

sys/dev/iicbus/controller/rockchip/rk_i2c.c

sys/dev/ioat/ioat.c

sys/dev/ioat/ioat_internal.h

sys/dev/iwm/if_iwm.c

sys/dev/iwm/if_iwm_binding.c

sys/dev/iwm/if_iwm_power.c

sys/dev/iwm/if_iwm_scan.c

sys/dev/iwm/if_iwm_sf.h

sys/dev/iwm/if_iwm_sf.c

sys/dev/iwm/if_iwm_sta.h

sys/dev/iwm/if_iwm_sta.c

sys/dev/iwm/if_iwm_time_event.h

sys/dev/iwm/if_iwm_time_event.c

sys/dev/iwm/if_iwm_util.h

sys/dev/iwm/if_iwm_util.c

sys/dev/iwm/if_iwmvar.h

sys/dev/ixgbe/if_sriov.c

sys/dev/ixgbe/ixgbe_osdep.h

sys/dev/mpr/mpr_user.c

sys/dev/mps/mps_user.c

sys/dev/mrsas/mrsas.h

sys/dev/mrsas/mrsas.c

sys/dev/mrsas/mrsas_cam.c

sys/dev/neta/if_mvneta.c

sys/dev/neta/if_mvneta_fdt.c

sys/dev/neta/if_mvnetavar.h

sys/dev/netmap/netmap_freebsd.c

Replace boolean_t with bool
AbandonedPublic
Actions

Revision Contents
Changeset List