Page MenuHomeFreeBSD

intr: rename "machine/intr_machdep.h" headers to "machine/intr.h"
Needs ReviewPublic

Authored by on Jun 23 2022, 1:27 AM.
Referenced Files
Unknown Object (File)
Tue, May 23, 7:30 PM
Unknown Object (File)
Mon, May 8, 5:33 AM
Unknown Object (File)
Apr 28 2023, 8:57 AM
Unknown Object (File)
Mar 13 2023, 4:30 AM
Unknown Object (File)
Feb 28 2023, 7:05 PM
Unknown Object (File)
Feb 17 2023, 3:06 AM
Unknown Object (File)
Jan 8 2023, 3:07 PM
Unknown Object (File)
Jan 5 2023, 11:25 AM



Being in the "machine/" directory already indicates these headers differ
from machine to machine. As such the shorter name "intr.h" is
appropriate. This also matches the INTRNG machines for the header name.

Diff Detail

rS FreeBSD src repository - subversion
Lint Passed
No Test Coverage
Build Status
Buildable 46072
Build 42961: arc lint + arc unit

Event Timeline

So the theory is to continue pushing the various interrupt handling implementations closer together. I suspect the INTRNG team may have thought "intr.h" would distinguish their system as being potentially machine-independent, but I think this simply serves to inhibit merging.

As such a case of choosing "intr.h" versus "intr_machdep.h". I think "machine/intr.h" is better as "machine/" already marks them as potentially having architecture quirks. Ideally their similarity will increase, but this will take a while.

If it is felt __FreeBSD_version should be incremented and then check for header name, I've got that prepared. Simply an issue of need a reviewer to request that be done.

I was under the impression D35559 has the right reviewers, but no action has been observed. This is meant as a precursor to the updated D32504. This can improve several places, but does need someone to okay (and commit to the main tree). Then there are the child commits.

Ping for D35559. This will be in the way of most attempts to further merge the interrupt interfaces, so deciding the direction would be helpful.