jhibbits (Justin Hibbits)
User

Projects

User Details

User Since
May 16 2014, 7:29 PM (191 w, 5 d)

Recent Activity

Tue, Jan 16

jhibbits committed rS328040: Make fsl_sata driver work on P1022.
Make fsl_sata driver work on P1022
Tue, Jan 16, 4:50 AM

Sat, Jan 13

jhibbits committed rS327943: Include only the headers needed.
Include only the headers needed
Sat, Jan 13, 9:11 PM
jhibbits committed rS327928: Add SPDX identifier to header.
Add SPDX identifier to header
Sat, Jan 13, 5:26 PM
jhibbits committed rS327911: Replace the PMC class struct copy with an explicit memcpy().
Replace the PMC class struct copy with an explicit memcpy()
Sat, Jan 13, 4:53 AM
jhibbits committed rS327907: Remove fdt fixups for powerpc, they are no longer needed..
Remove fdt fixups for powerpc, they are no longer needed.
Sat, Jan 13, 2:56 AM
jhibbits committed rS327906: Enable L2 cache on supported PowerQUICC and QorIQ platforms.
Enable L2 cache on supported PowerQUICC and QorIQ platforms
Sat, Jan 13, 1:36 AM

Fri, Jan 12

jhibbits added a comment to D13880: www/node can be built by gcc now.

Testing further, on my powerpcspe machine, It looks like node.js needs a little work for the configure script to build on powerpc, powerpcspe, and possibly mips. So I'll just add powerpc64 to the ONLY_FOR_ARCHS line instead.

Fri, Jan 12, 4:01 PM
jhibbits added a comment to D13880: www/node can be built by gcc now.

What about MIPS?

Fri, Jan 12, 3:45 PM
jhibbits requested changes to D13883: Use appropriate alternative to -msoft-float for clang-built PowerPC kernels..

Clang has supported -msoft-float since at least 4.0. I referred a similar change a few months ago. Did you test building with recent clang?

Fri, Jan 12, 1:04 PM
jhibbits created D13880: www/node can be built by gcc now.
Fri, Jan 12, 2:30 AM

Thu, Jan 11

jhibbits created D13854: Fix libgcrypt build for powerpcspe.
Thu, Jan 11, 4:48 AM

Wed, Jan 10

jhibbits accepted D13839: Fix minor locking issues in the PowerMac Uninorth PCI driver.
Wed, Jan 10, 9:41 PM
jhibbits added a comment to D13836: Include required ofw_gpiobus.c when building gpiobus module for OFW/FDT targets..

Already done, in r327681.

Wed, Jan 10, 8:50 PM
jhibbits committed rP458595: Drop PIE for cups, it's not supported on powerpc, so fails the build.
Drop PIE for cups, it's not supported on powerpc, so fails the build
Wed, Jan 10, 3:54 AM
jhibbits closed D10613: Drop PIE for cups, it's not supported on powerpc, so fails the build.
Wed, Jan 10, 3:54 AM
jhibbits closed D13804: Add support for GCC-based targets to luajit.
Wed, Jan 10, 3:51 AM
jhibbits committed rP458594: Add support for GCC-based targets to luajit.
Add support for GCC-based targets to luajit
Wed, Jan 10, 3:51 AM

Tue, Jan 9

jhibbits added inline comments to D13804: Add support for GCC-based targets to luajit.
Tue, Jan 9, 3:39 PM
jhibbits updated the diff for D13804: Add support for GCC-based targets to luajit.

Update given mat's feedback. Tested with powerpc and powerpc64

Tue, Jan 9, 3:28 PM
jhibbits added inline comments to D13804: Add support for GCC-based targets to luajit.
Tue, Jan 9, 3:17 PM
jhibbits added inline comments to D13804: Add support for GCC-based targets to luajit.
Tue, Jan 9, 3:06 PM
jhibbits added inline comments to D13804: Add support for GCC-based targets to luajit.
Tue, Jan 9, 2:59 PM
jhibbits created D13804: Add support for GCC-based targets to luajit.
Tue, Jan 9, 4:49 AM

Mon, Jan 8

jhibbits added a reviewer for D13128: Add powerpcspe support for devel/binutils: andreast.
Mon, Jan 8, 11:02 PM
jhibbits updated the diff for D10613: Drop PIE for cups, it's not supported on powerpc, so fails the build.

Wrap the sed

Mon, Jan 8, 11:00 PM
jhibbits edited reviewers for D10613: Drop PIE for cups, it's not supported on powerpc, so fails the build, added: tijl; removed: swills.
Mon, Jan 8, 10:58 PM

Sun, Jan 7

jhibbits committed rS327681: Add missing file to gpiobus module.
Add missing file to gpiobus module
Sun, Jan 7, 8:28 PM

Wed, Jan 3

jhibbits accepted D13753: Bump MAXSSIZ and create a proper fix-up for MAXDSIZ/MAXSSIZ on powerpc64 running 32-bit binaries .

Looks good. Sorry for the breakage!

Wed, Jan 3, 8:04 PM · PowerPC

Wed, Dec 20

jhibbits committed rS327028: Increase default MAXDSIZ to 32G on powerpc64.
Increase default MAXDSIZ to 32G on powerpc64
Wed, Dec 20, 4:50 PM

Dec 17 2017

jhibbits added a comment to D13126: Add powerpc.powerpcspe support for lang/gcc compilers.

And can we leave out lang/gcc5 now that lang/gcc6 is the default (and GCC 5 is
end of life)?

Dec 17 2017, 4:37 AM
jhibbits added a comment to D13126: Add powerpc.powerpcspe support for lang/gcc compilers.

Btw, does powerpcspe have multilib directions?

Dec 17 2017, 4:36 AM

Dec 15 2017

jhibbits committed rS326870: Handle the Facility Unavailable exception as a SIGILL.
Handle the Facility Unavailable exception as a SIGILL
Dec 15 2017, 4:11 AM

Dec 14 2017

jhibbits committed rS326859: Add identifier for POWER9 CPU to CPU list.
Add identifier for POWER9 CPU to CPU list
Dec 14 2017, 8:01 PM
jhibbits committed rS326840: Allow bman-portals and qman-portals to attach to simple-bus.
Allow bman-portals and qman-portals to attach to simple-bus
Dec 14 2017, 4:41 AM

Dec 13 2017

jhibbits added a comment to D13126: Add powerpc.powerpcspe support for lang/gcc compilers.

I've build-tested gcc5 and gcc6, and patch tested the others so far. It takes a very long time to build these on this board.

Dec 13 2017, 4:33 AM
jhibbits updated the diff for D13126: Add powerpc.powerpcspe support for lang/gcc compilers.

Missed one more line

Dec 13 2017, 4:19 AM
jhibbits updated the diff for D13126: Add powerpc.powerpcspe support for lang/gcc compilers.

Fix the diff

Dec 13 2017, 4:18 AM
jhibbits retitled D13126: Add powerpc.powerpcspe support for lang/gcc compilers from Add powerpc.powerpcspe support for lang/gcc5 to Add powerpc.powerpcspe support for lang/gcc compilers.
Dec 13 2017, 4:13 AM
jhibbits updated the diff for D13126: Add powerpc.powerpcspe support for lang/gcc compilers.

Address all comments.

Dec 13 2017, 4:12 AM

Dec 12 2017

jhibbits committed rS326789: Decode some PowerPC trap registers.
Decode some PowerPC trap registers
Dec 12 2017, 3:16 AM

Dec 10 2017

jhibbits committed rS326739: Retrieve the page outside of holding locks.
Retrieve the page outside of holding locks
Dec 10 2017, 4:43 AM

Dec 8 2017

jhibbits committed rS326675: Remove PTE VA mappings for tracked pages in 64-bit mode.
Remove PTE VA mappings for tracked pages in 64-bit mode
Dec 8 2017, 3:50 AM

Dec 6 2017

jhibbits closed D13331: Allow custom overrides of mmap attribute for VT framebuffer.
Dec 6 2017, 2:06 AM
jhibbits committed rS326612: Allow custom overrides of mmap attribute for VT framebuffer.
Allow custom overrides of mmap attribute for VT framebuffer
Dec 6 2017, 2:06 AM
jhibbits committed rS326611: Use unsigned intptr_t type for framebuffer addresses.
Use unsigned intptr_t type for framebuffer addresses
Dec 6 2017, 2:05 AM
jhibbits closed D13332: Use unsigned intptr_t type for framebuffer addresses.
Dec 6 2017, 2:05 AM

Dec 2 2017

jhibbits created D13332: Use unsigned intptr_t type for framebuffer addresses.
Dec 2 2017, 1:48 AM
jhibbits created D13331: Allow custom overrides of mmap attribute for VT framebuffer.
Dec 2 2017, 1:44 AM
jhibbits committed rS326453: Override memattr for mmap on the Freescale DIU driver.
Override memattr for mmap on the Freescale DIU driver
Dec 2 2017, 1:42 AM

Nov 29 2017

jhibbits committed rS326354: Only check the page tables if within the KVA..
Only check the page tables if within the KVA.
Nov 29 2017, 1:26 AM

Nov 26 2017

jhibbits committed rS326236: Synchronize TLB1 mappings when created.
Synchronize TLB1 mappings when created
Nov 26 2017, 8:30 PM

Nov 22 2017

jhibbits committed rS326083: PowerPC has 12 artificial frames for the profiler.
PowerPC has 12 artificial frames for the profiler
Nov 22 2017, 1:54 AM

Nov 21 2017

jhibbits accepted D13180: Don't let cpu_set_syscall_retval() clobber exec_setregs()..

LGTM

Nov 21 2017, 3:46 PM
jhibbits committed rS326045: Check the page table before TLB1 in pmap_kextract().
Check the page table before TLB1 in pmap_kextract()
Nov 21 2017, 3:12 AM

Nov 20 2017

jhibbits abandoned D12984: Compute priority with an intermediate widening to prevent overflow.

Cast the tick difference to uintmax_t earlier on, instead of in the roundup() argument list.

Taking a step back, the problem occurs when roundup(SCHED_TICK_TOTAL(ts), SCHED_PRI_RANGE) ends up in the interval (-SCHED_PRI_RANGE, SCHED_PRI_RANGE), right? SCHED_TICK_TOTAL(ts) is max(ts->ts_ltick - ts->ts_ftick, hz); note that max()'s return value is an unsigned int. So, to hit the bug, that difference needs to be quite large, i.e., close to INT_MAX.

ftick and ltick are the boundaries of the %CPU sliding window for the thread, and are updated in sched_pctcpu_update(). In particular, that difference ltick - ftick is supposed to be no larger than SCHED_TICK_MAX = 11 * hz. In r314625 I fixed a bug which caused us to stop updating ts_ftick for a thread if it had not run in a long time. So how else are we getting that large difference? Is it possible that your bug is already fixed by the above-mentioned revision?

Nov 20 2017, 6:51 PM
jhibbits committed rS326004: Eliminate 1 XX_VirtToPhys() and 2 XX_PhysToVirt() calls from if_dtsec(4).
Eliminate 1 XX_VirtToPhys() and 2 XX_PhysToVirt() calls from if_dtsec(4)
Nov 20 2017, 4:32 AM

Nov 18 2017

jhibbits added a comment to D13126: Add powerpc.powerpcspe support for lang/gcc compilers.

I forgot to ask: how have you tested this?

Nov 18 2017, 4:03 PM

Nov 17 2017

jhibbits committed rS325927: Add jumbo frame support to dtsec(4).
Add jumbo frame support to dtsec(4)
Nov 17 2017, 4:29 AM
jhibbits created D13129: Add powerpcspe support for devel/libffi.
Nov 17 2017, 4:26 AM
jhibbits created D13128: Add powerpcspe support for devel/binutils.
Nov 17 2017, 4:24 AM
jhibbits created D13127: Add powerpcspe support for math/gmp.
Nov 17 2017, 4:22 AM
jhibbits created D13126: Add powerpc.powerpcspe support for lang/gcc compilers.
Nov 17 2017, 4:16 AM
jhibbits committed rS325926: Stop special casing 32-bit AIM in memory parsing.
Stop special casing 32-bit AIM in memory parsing
Nov 17 2017, 4:11 AM

Nov 14 2017

jhibbits updated the diff for D12984: Compute priority with an intermediate widening to prevent overflow.

Cast the tick difference to uintmax_t earlier on, instead of in the roundup() argument list.

Nov 14 2017, 7:16 PM
jhibbits committed rS325791: Expand the Freescale PCIe root complex driver with the ofw_pcib_pci.
Expand the Freescale PCIe root complex driver with the ofw_pcib_pci
Nov 14 2017, 3:53 AM
jhibbits closed D12962: Convert BERI to use ofw_parse_bootargs().
Nov 14 2017, 3:24 AM
jhibbits committed rS325790: Convert BERI to use ofw_parse_bootargs().
Convert BERI to use ofw_parse_bootargs()
Nov 14 2017, 3:24 AM
jhibbits committed rS325789: Use the correct board name for the Ubiquiti Unifi Security Gateway.
Use the correct board name for the Ubiquiti Unifi Security Gateway
Nov 14 2017, 3:22 AM

Nov 10 2017

jhibbits committed rS325629: Properly initialize the full md_page structure.
Properly initialize the full md_page structure
Nov 10 2017, 4:24 AM
jhibbits committed rS325628: Book-E pmap_mapdev_attr() improvements.
Book-E pmap_mapdev_attr() improvements
Nov 10 2017, 4:15 AM

Nov 8 2017

jhibbits abandoned D6154: Convert fdt_data_to_res() to use rman_res_t instead of u_long.
Nov 8 2017, 8:26 PM
jhibbits added a comment to D12984: Compute priority with an intermediate widening to prevent overflow.
In D12984#270029, @kib wrote:

Perhaps s/33/32/ in the message ? Or am I missing something ?

Nov 8 2017, 2:58 PM
jhibbits added inline comments to D12984: Compute priority with an intermediate widening to prevent overflow.
Nov 8 2017, 1:38 AM
jhibbits updated the diff for D12984: Compute priority with an intermediate widening to prevent overflow.

The cast to int should be of the full result, not just the roundup().

Nov 8 2017, 1:37 AM
jhibbits committed rS325527: DS1307: Add the mcp7941x enable bit.
DS1307: Add the mcp7941x enable bit
Nov 8 2017, 1:33 AM
jhibbits committed rS325526: Add the ISEL feature macro for those powerpc cores that have it.
Add the ISEL feature macro for those powerpc cores that have it
Nov 8 2017, 1:33 AM
jhibbits closed D12961: DS1307: Add the mcp7941x enable bit.
Nov 8 2017, 1:33 AM
jhibbits committed rS325525: Clear the WE bit in C code rather than the asm.
Clear the WE bit in C code rather than the asm
Nov 8 2017, 1:26 AM

Nov 7 2017

jhibbits created D12984: Compute priority with an intermediate widening to prevent overflow.
Nov 7 2017, 10:34 PM

Nov 6 2017

jhibbits committed rS325468: Set the PRD extension list base address in little endian.
Set the PRD extension list base address in little endian
Nov 6 2017, 5:09 AM

Nov 5 2017

jhibbits retitled D12961: DS1307: Add the mcp7941x enable bit from DS1307: Attempt to enable the oscillator to DS1307: Add the mcp7941x enable bit.
Nov 5 2017, 10:17 PM
jhibbits updated the diff for D12961: DS1307: Add the mcp7941x enable bit.

Drop the enable part, it doesn't make sense. This changes the revision to instead just add the mcp7941x enable bit.

Nov 5 2017, 10:16 PM
jhibbits committed rS325453: Fix an off-by-one error missed in the initial commit of this driver.
Fix an off-by-one error missed in the initial commit of this driver
Nov 5 2017, 10:10 PM
jhibbits created D12962: Convert BERI to use ofw_parse_bootargs().
Nov 5 2017, 3:39 AM
jhibbits created D12961: DS1307: Add the mcp7941x enable bit.
Nov 5 2017, 3:25 AM
jhibbits committed rS325421: Add Freescale QorIQ SATA controller support..
Add Freescale QorIQ SATA controller support.
Nov 5 2017, 2:48 AM
jhibbits closed D6071: Add Freescale QorIQ SATA controller support..
Nov 5 2017, 2:48 AM

Nov 4 2017

jhibbits committed rS325375: Stop passing -me500 to the assembler for Book-E kernels.
Stop passing -me500 to the assembler for Book-E kernels
Nov 4 2017, 12:47 AM

Nov 3 2017

jhibbits committed rS325352: Fix integer type and format in debug print.
Fix integer type and format in debug print
Nov 3 2017, 3:13 AM

Nov 2 2017

jhibbits committed rS325306: Actually add the dtsec(4) man page to the build.
Actually add the dtsec(4) man page to the build
Nov 2 2017, 4:17 AM
jhibbits committed rS325305: Fix interrupt handling for dtsec.
Fix interrupt handling for dtsec
Nov 2 2017, 4:08 AM

Nov 1 2017

jhibbits committed rS325262: Enable a bunch more options in the QORIQ64 kernel.
Enable a bunch more options in the QORIQ64 kernel
Nov 1 2017, 3:54 AM
jhibbits committed rS325260: Rename a couple files to not conflict with ZFS filenames.
Rename a couple files to not conflict with ZFS filenames
Nov 1 2017, 3:09 AM
jhibbits committed rS325259: Add Guest State (GS) bit to MSR bits.
Add Guest State (GS) bit to MSR bits
Nov 1 2017, 2:55 AM
jhibbits committed rS325258: Fix debug interrupts on 64-bit Book-E.
Fix debug interrupts on 64-bit Book-E
Nov 1 2017, 2:40 AM
jhibbits committed rS325255: Remove a singleton in the DPAA driver, to allow multiple fman instances.
Remove a singleton in the DPAA driver, to allow multiple fman instances
Nov 1 2017, 12:47 AM

Oct 31 2017

jhibbits committed rS325204: Make DPAA work in 64-bit mode.
Make DPAA work in 64-bit mode
Oct 31 2017, 2:54 AM
jhibbits committed rS325199: Add a file to unbreak the build.
Add a file to unbreak the build
Oct 31 2017, 2:36 AM

Oct 30 2017

jhibbits committed rS325118: Update DPAA SDK to SDK 2.0.
Update DPAA SDK to SDK 2.0
Oct 30 2017, 3:41 AM
jhibbits committed rS325113: Add Microchip 1-MBit SPI flash ID.
Add Microchip 1-MBit SPI flash ID
Oct 30 2017, 2:31 AM