Page MenuHomeFreeBSD

jhibbits (Justin Hibbits)
User

Projects

User Details

User Since
May 16 2014, 7:29 PM (265 w, 2 d)

Recent Activity

Fri, Jun 14

jhibbits updated the diff for D20598: powerpc: Transition to Secure-PLT, like most other OSs.

Fix _ctx_start relocation for abort() call.

Fri, Jun 14, 6:58 PM

Wed, Jun 12

jhibbits accepted D20608: Fix PPC970 boot after r348783.
Wed, Jun 12, 3:18 AM · PowerPC
jhibbits added a reviewer for D20598: powerpc: Transition to Secure-PLT, like most other OSs: dim.

Add @dim, for the clang part. The clang part will be upstreamed once this is all done and stable.

Wed, Jun 12, 1:23 AM
jhibbits updated the diff for D20598: powerpc: Transition to Secure-PLT, like most other OSs.

Address feedback, fix a crash of syncicache() too big for the PLT.

Wed, Jun 12, 1:21 AM

Tue, Jun 11

jhibbits added inline comments to D20608: Fix PPC970 boot after r348783.
Tue, Jun 11, 6:20 PM · PowerPC
jhibbits added inline comments to D20598: powerpc: Transition to Secure-PLT, like most other OSs.
Tue, Jun 11, 3:45 AM
jhibbits created D20598: powerpc: Transition to Secure-PLT, like most other OSs.
Tue, Jun 11, 3:37 AM

Mon, Jun 10

jhibbits committed rS348845: powernv: Port HMI handler to use the message framework.
powernv: Port HMI handler to use the message framework
Mon, Jun 10, 3:24 AM
jhibbits committed rS348844: powerpc/powernv: Reduce the scope of the sensor guarding mutex.
powerpc/powernv: Reduce the scope of the sensor guarding mutex
Mon, Jun 10, 3:17 AM

Sat, Jun 8

jhibbits committed rS348795: powerpc/pmap: Move the SLB spill handlers to a better place.
powerpc/pmap: Move the SLB spill handlers to a better place
Sat, Jun 8, 3:07 AM
jhibbits committed rS348794: powerpc/aim: Use nitems() for calculating size of phys_avail in AIM pmaps.
powerpc/aim: Use nitems() for calculating size of phys_avail in AIM pmaps
Sat, Jun 8, 2:36 AM

Fri, Jun 7

jhibbits accepted D20553: [PPC64] Fix ofw_initrd.

Good catch. We should probably consider adding !hw_direct_map support sometime in the future, too, for use in Qemu/KVM.

Fri, Jun 7, 6:24 PM
jhibbits accepted D20522: [PPC64] Support QEMU/KVM pseries without hugepages.

Thanks for the explanation. It looks fine either way. I just recommend making the change for consistency, but it's not required if it's not needed.

Fri, Jun 7, 2:59 PM

Thu, Jun 6

jhibbits added a comment to D20522: [PPC64] Support QEMU/KVM pseries without hugepages.

Overall looks good, just one question.

Thu, Jun 6, 8:36 PM

Sat, Jun 1

jhibbits committed rS348490: powerpc/moea: Fix moea64 native VA invalidation.
powerpc/moea: Fix moea64 native VA invalidation
Sat, Jun 1, 1:40 AM
jhibbits closed D20467: powerpc/moea: Fix moea64 native VA invalidation.
Sat, Jun 1, 1:40 AM
jhibbits committed rS348488: Welcome Brandon Bergren (bdragon) as a src committer.
Welcome Brandon Bergren (bdragon) as a src committer
Sat, Jun 1, 1:08 AM

Thu, May 30

jhibbits added a comment to D20461: [PowerPC64] Don't mark module data as static on PowerPC64 - Fixes panic when loading ipfw.ko and if_epair.ko built with modern compiler..

This change will probably also be needed for DPCPU. Can that be tested as well?

Thu, May 30, 2:52 PM
jhibbits updated the diff for D20467: powerpc/moea: Fix moea64 native VA invalidation.

Use the right VPN mask.

Thu, May 30, 3:33 AM

Wed, May 29

jhibbits added inline comments to D20467: powerpc/moea: Fix moea64 native VA invalidation.
Wed, May 29, 10:46 PM
jhibbits created D20467: powerpc/moea: Fix moea64 native VA invalidation.
Wed, May 29, 10:36 PM
jhibbits committed rS348350: Update __FreeBSD_version and Makefile check for r348347.
Update __FreeBSD_version and Makefile check for r348347
Wed, May 29, 2:26 AM
jhibbits committed rS348347: Add missing powerpc64 relocation support to libdwarf.
Add missing powerpc64 relocation support to libdwarf
Wed, May 29, 2:03 AM
jhibbits closed D20367: Add missing powerpc64 relocation support to libdwarf.
Wed, May 29, 2:03 AM · PowerPC

Mon, May 27

jhibbits committed rS348299: kern/CTF: link_elf_ctf_get() on big endian platforms.
kern/CTF: link_elf_ctf_get() on big endian platforms
Mon, May 27, 4:20 AM
jhibbits closed D20413: Fix link_elf_ctf_get() on big endian platforms.
Mon, May 27, 4:20 AM · PowerPC
jhibbits committed rS348298: powerpc/dtrace: Fix fbt function probing for ELFv2.
powerpc/dtrace: Fix fbt function probing for ELFv2
Mon, May 27, 3:19 AM
jhibbits closed D20346: Fix fbt blacklisting all functions on ELFv2 kernels.
Mon, May 27, 3:19 AM · PowerPC
jhibbits accepted D20413: Fix link_elf_ctf_get() on big endian platforms.

Looks good. A trivial fix.

Mon, May 27, 3:00 AM · PowerPC
jhibbits accepted D20346: Fix fbt blacklisting all functions on ELFv2 kernels.
Mon, May 27, 2:59 AM · PowerPC

Sat, May 25

jhibbits committed rS348267: powerpc64/pmap: Reapply r334235 to OEA64 pmap, clearing HID0_RADIX.
powerpc64/pmap: Reapply r334235 to OEA64 pmap, clearing HID0_RADIX
Sat, May 25, 4:56 AM

Fri, May 24

jhibbits committed rS348218: MFC r347463:.
MFC r347463:
Fri, May 24, 1:52 AM

Thu, May 23

jhibbits committed rS348147: powerpc/mpc85xx: Use the proper (EREF) form of writing to DBCR0.
powerpc/mpc85xx: Use the proper (EREF) form of writing to DBCR0
Thu, May 23, 3:47 AM
jhibbits committed rS348146: powerpc/booke: It helps to set variables before using them.
powerpc/booke: It helps to set variables before using them
Thu, May 23, 3:41 AM

Wed, May 22

jhibbits accepted D19352: Fix PPC64 kernel build with clang8 + lld8.

Looks good now!

Wed, May 22, 2:09 PM
jhibbits committed rS348079: powerpc/booke: Use wrtee instead of msr to restore EE bit.
powerpc/booke: Use wrtee instead of msr to restore EE bit
Wed, May 22, 2:43 AM

Tue, May 21

jhibbits committed rS348040: stand: TARGET_ARCH is spelled MACHINE_ARCH in Makefiles.
stand: TARGET_ARCH is spelled MACHINE_ARCH in Makefiles
Tue, May 21, 3:05 AM
jhibbits committed rS348028: stand/powerpc: Only build loader.kboot for powerpc64.
stand/powerpc: Only build loader.kboot for powerpc64
Tue, May 21, 1:43 AM

Mon, May 20

jhibbits removed a member for DTrace: jhibbits.
Mon, May 20, 7:51 PM
jhibbits added a reviewer for D20261: [PowerPC64] Adds support for using ld.bfd on LIB32 and STAND, when default linker is ld.lld: bdrewery.

@bdrewery knows the Makefiles much better than probably anybody else on the project.

Mon, May 20, 6:20 PM
jhibbits accepted D20026: [PowerPC64] stand: fix build using clang 8 as compiler.

Looks fine to me now. Good work!

Mon, May 20, 4:20 PM
jhibbits accepted D20259: [PPC] Enable build/install of ld.bfd on base.

This looks fine to me. Hoping we can obliterate GNU ld before too long, even on 32-bit.

Mon, May 20, 3:58 PM
jhibbits added inline comments to D19352: Fix PPC64 kernel build with clang8 + lld8.
Mon, May 20, 3:03 PM
jhibbits committed rS347986: Update loader size on powerpc isos.
Update loader size on powerpc isos
Mon, May 20, 3:35 AM
jhibbits closed D20301: Update loader size on powerpc isos.
Mon, May 20, 3:35 AM · PowerPC
jhibbits closed D20316: ksyms: Fixup symbols for powerpc in the kernel, not just modules.
Mon, May 20, 2:41 AM
jhibbits committed rS347985: ksyms: Fixup symbols for powerpc in the kernel, not just modules.
ksyms: Fixup symbols for powerpc in the kernel, not just modules
Mon, May 20, 2:41 AM
jhibbits added inline comments to D20316: ksyms: Fixup symbols for powerpc in the kernel, not just modules.
Mon, May 20, 2:30 AM

Sun, May 19

jhibbits updated the diff for D20316: ksyms: Fixup symbols for powerpc in the kernel, not just modules.

Third time's a charm.

Sun, May 19, 5:32 PM
jhibbits added a comment to D20316: ksyms: Fixup symbols for powerpc in the kernel, not just modules.

Makes sense. Should've thought of that when I made this change.

Sun, May 19, 4:06 PM
jhibbits updated the diff for D20316: ksyms: Fixup symbols for powerpc in the kernel, not just modules.

Address feedback from markj.

Sun, May 19, 3:18 PM
jhibbits added inline comments to D20316: ksyms: Fixup symbols for powerpc in the kernel, not just modules.
Sun, May 19, 3:17 PM
jhibbits created D20316: ksyms: Fixup symbols for powerpc in the kernel, not just modules.
Sun, May 19, 3:04 PM

May 18 2019

jhibbits committed rS347956: powerpc: Fix moea64 pmap from 347952.
powerpc: Fix moea64 pmap from 347952
May 18 2019, 2:56 PM
jhibbits committed rS347952: powerpc64/pmap: NUMA-ize the page pv lock pool to reduce contention.
powerpc64/pmap: NUMA-ize the page pv lock pool to reduce contention
May 18 2019, 11:14 AM

May 17 2019

jhibbits committed rS347943: powerpc/dtrace: Actually fix stack traces.
powerpc/dtrace: Actually fix stack traces
May 17 2019, 7:57 PM

May 16 2019

jhibbits committed rS347795: arm64: Add the rename interpreter path for compat32 ld-elf.
arm64: Add the rename interpreter path for compat32 ld-elf
May 16 2019, 5:04 PM

May 13 2019

jhibbits commandeered D15243: Powerpc64: Enable Hardware Transactional Memory.

Will take this to completion.

May 13 2019, 1:22 AM

May 11 2019

jhibbits committed rS347496: MFC r345829, r345831.
MFC r345829, r345831
May 11 2019, 6:31 PM
jhibbits committed rS347495: MFC r345435:.
MFC r345435:
May 11 2019, 6:25 PM
jhibbits committed rS347492: revert r346588 for now.
revert r346588 for now
May 11 2019, 3:17 PM

May 10 2019

jhibbits committed rS347463: powerpc: Initialize the Hardware Interrupt Offset Register (HIOR) earlier for….
powerpc: Initialize the Hardware Interrupt Offset Register (HIOR) earlier for…
May 10 2019, 7:36 PM

May 8 2019

jhibbits committed rS347354: powerpc/booke: Rewrite pmap_sync_icache() a bit.
powerpc/booke: Rewrite pmap_sync_icache() a bit
May 8 2019, 4:15 PM
jhibbits committed rS347350: powerpc/booke: Do as much work outside of TLB locks as possible.
powerpc/booke: Do as much work outside of TLB locks as possible
May 8 2019, 4:05 PM
jhibbits committed rS347242: powerpc: hide innocuous printf behind bootverbose.
powerpc: hide innocuous printf behind bootverbose
May 8 2019, 3:15 AM

May 6 2019

jhibbits committed rS347177: MFC r344871:.
MFC r344871:
May 6 2019, 3:39 AM
jhibbits committed rS347176: MFC r344613:.
MFC r344613:
May 6 2019, 3:36 AM
jhibbits committed rS347175: MFC r340262,344730.
MFC r340262,344730
May 6 2019, 3:31 AM
jhibbits committed rS347173: MFC r339559,344083,344202,344203,344204.
MFC r339559,344083,344202,344203,344204
May 6 2019, 3:15 AM

May 5 2019

jhibbits committed rS347167: powerpc/booke: Use #ifdef __powerpc64__ instead of hw_direct_map in places.
powerpc/booke: Use #ifdef __powerpc64__ instead of hw_direct_map in places
May 5 2019, 8:23 PM
jhibbits committed rS347164: powerpc/booke: Fix size check for phys_avail in pmap bootstrap.
powerpc/booke: Fix size check for phys_avail in pmap bootstrap
May 5 2019, 8:06 PM

May 4 2019

jhibbits committed rS347127: powerpc/mpc85xx: Attach MPC85xx PCI bus and root complex at the right pass.
powerpc/mpc85xx: Attach MPC85xx PCI bus and root complex at the right pass
May 4 2019, 4:24 PM
jhibbits committed rS347079: powerpc: Optimize padding in bus_dma_tag.
powerpc: Optimize padding in bus_dma_tag
May 4 2019, 2:45 AM
jhibbits closed D20121: Optimize padding in powerpc busdma_machdep.c.
May 4 2019, 2:45 AM · PowerPC
jhibbits committed rS347078: powerpc: Merge all pmap struct definitions.
powerpc: Merge all pmap struct definitions
May 4 2019, 2:34 AM
jhibbits closed D20119: powerpc: Merge all pmap struct definitions.
May 4 2019, 2:34 AM

May 3 2019

jhibbits requested changes to D19373: Silence irrelevant warning on 32 bit platforms..

See above comment. It shouldn't be gated on LP64

May 3 2019, 8:22 PM
jhibbits added inline comments to D20026: [PowerPC64] stand: fix build using clang 8 as compiler.
May 3 2019, 8:20 PM

May 2 2019

jhibbits added a comment to D20119: powerpc: Merge all pmap struct definitions.

The 64-bit Book-E pmap overhead is around 32kB (12 bits worth of PP2D_NENTRIES, so 4096 8-byte entries), and 4kB on 32-bit. This is not small by any stretch, and I do want to rework it, and plan to over the next couple months. For now I can #ifdef within the union (I do want to keep it a union, so that we can eventually have a GENERIC that boots on both AIM and Book-E).

May 2 2019, 7:25 PM
jhibbits abandoned D15690: Make java/eclipse build for powerpc64.
May 2 2019, 2:17 PM
jhibbits committed rS347013: powerpc: Drop OPAL_HANDLE_HMI2 for now, to avoid panicking.
powerpc: Drop OPAL_HANDLE_HMI2 for now, to avoid panicking
May 2 2019, 3:39 AM

May 1 2019

jhibbits accepted D20121: Optimize padding in powerpc busdma_machdep.c.

From my count it saves 8 bytes, not 64. I don't think it's a significant issue, given the size of the structure already, but it's not a bad change, and does allow for better packing.

May 1 2019, 2:10 PM · PowerPC
jhibbits created D20119: powerpc: Merge all pmap struct definitions.
May 1 2019, 3:03 AM

Apr 30 2019

jhibbits committed rS346941: powerpc: Stop pretending we run on e500v1 cores.
powerpc: Stop pretending we run on e500v1 cores
Apr 30 2019, 3:46 AM

Apr 29 2019

jhibbits committed rS346935: powerpc64: Fix switch panic from cpu_throw().
powerpc64: Fix switch panic from cpu_throw()
Apr 29 2019, 10:37 PM
jhibbits accepted D20098: [PPC64] Turn opal_flash.c into a device.

We might want to do this with other devices as well.

Apr 29 2019, 4:42 PM
jhibbits committed rS346865: powerpc: Make OPAL root node probe at bus pass.
powerpc: Make OPAL root node probe at bus pass
Apr 29 2019, 1:11 AM

Apr 27 2019

jhibbits committed rS346796: powerpc: Add support for additional FSCR-managed facilities.
powerpc: Add support for additional FSCR-managed facilities
Apr 27 2019, 10:30 PM
jhibbits committed rS346791: powerpc: Add SPR definitions for additional POWER8/POWER9 facilities.
powerpc: Add SPR definitions for additional POWER8/POWER9 facilities
Apr 27 2019, 7:32 PM
jhibbits committed rS346790: powerpc64: Add the DSCR facility on POWER8 and later.
powerpc64: Add the DSCR facility on POWER8 and later
Apr 27 2019, 4:28 PM
jhibbits committed rS346777: powerpc: Add POWER8NVL definition.
powerpc: Add POWER8NVL definition
Apr 27 2019, 2:34 AM
jhibbits committed rS346771: powerpc: micro-optimize cpu_switch().
powerpc: micro-optimize cpu_switch()
Apr 27 2019, 12:53 AM

Apr 26 2019

jhibbits accepted D19993: Don't symlink fusefs.ko to fuse.ko on PPC.

That idea sounds fine to me. After the MFC, just remove the whole aliasing thing entirely. I have a feeling the number of PowerNV users (the only ones who would see msdosfs /boot) running 12 will be very small compared to those running head.

Apr 26 2019, 3:27 PM
jhibbits added a comment to D19993: Don't symlink fusefs.ko to fuse.ko on PPC.

As @rgrimes mentioned on the email thread, can the symlink just summarily be jettisoned, since it was a compat shim within 12? Or am I mistaken, and it's a compat shim in 13?

Apr 26 2019, 3:06 PM
jhibbits committed rS346730: powerpc64: Clear FSCR SPR, so that it's in a known state.
powerpc64: Clear FSCR SPR, so that it's in a known state
Apr 26 2019, 3:18 AM
jhibbits committed rS346729: powerpc: Fix whitespace in SPR header..
powerpc: Fix whitespace in SPR header.
Apr 26 2019, 3:13 AM
jhibbits committed rS346728: powerpc: Add another feature2 flag, and update power9 definition.
powerpc: Add another feature2 flag, and update power9 definition
Apr 26 2019, 2:30 AM

Apr 24 2019

jhibbits added a comment to D15368: strcpy optimization for PowerPC64.

I need to think about this more. According to the PowerISA reference, 'cmpb' is 'new' with PowerISA 2.05, which means this will break the PowerPC 970 and POWER5 and earlier. I already broke it last night with the commit of the strcmp optimization, so don't want to break it further now, until we better reason this.

Apr 24 2019, 3:26 AM · PowerPC
jhibbits committed rS346619: powerpc: Add a couple missing isyncs.
powerpc: Add a couple missing isyncs
Apr 24 2019, 2:52 AM

Apr 23 2019

jhibbits added a comment to D15368: strcpy optimization for PowerPC64.

I guess now this revision is waiting only for @gromero_br.ibm.com approval, right?

Apr 23 2019, 6:51 PM · PowerPC