Page MenuHomeFreeBSD

jhibbits (Justin Hibbits)
User

Projects

User Details

User Since
May 16 2014, 7:29 PM (282 w, 2 d)

Recent Activity

Today

jhibbits committed rS353481: powerpc/pmap: Tighten condition for removing tracked pages in Book-E pmap.
powerpc/pmap: Tighten condition for removing tracked pages in Book-E pmap
Sun, Oct 13, 7:33 PM
jhibbits created D22014: powerpc/mpc85xx: Add MSI support for Freescale PowerPC SoCs.
Sun, Oct 13, 7:14 PM

Yesterday

jhibbits updated the diff for D21829: powerpc: Add AmigaOne platform, a subclass of MPC85xx.

Fix the diff

Sat, Oct 12, 10:53 PM
jhibbits updated the diff for D21829: powerpc: Add AmigaOne platform, a subclass of MPC85xx.

Don't use config_intrhook_establish(), the mutex isn't initialized yet.

Sat, Oct 12, 10:46 PM
jhibbits accepted D21551: [PPC64] Initial kernel minidump implementation.
Sat, Oct 12, 9:03 PM
jhibbits closed D21834: Fix nondeterministic load of fdt_slicer.

@kevans committed this in r352863 2 weeks ago.

Sat, Oct 12, 8:57 PM
jhibbits committed rS353455: [PowerPC] force applications linked with lib CSU to have .got.
[PowerPC] force applications linked with lib CSU to have .got
Sat, Oct 12, 8:54 PM
jhibbits closed D21476: [PowerPC] force applications linked with lib CSU to have .got.
Sat, Oct 12, 8:54 PM
jhibbits added a comment to D21999: [PowerPC] Book-E clang support.

I really like that you took the time to annotate the existing code. It's tough to read and understand it the first several times through.

Sat, Oct 12, 8:46 PM · PowerPC
jhibbits accepted D21988: [PowerPC] [BookE] Fix read past end of struct.

Looks good for what we can do for now. I really should clean up the whole DPAA interface bits, so we don't need to do that loop. But since it's only executed on bootup, it's not a very high priority task.

Sat, Oct 12, 8:29 PM · PowerPC

Fri, Oct 11

jhibbits committed rS353437: gcore: Add powerpc64 32-bit gcore support.
gcore: Add powerpc64 32-bit gcore support
Fri, Oct 11, 2:17 PM
jhibbits closed D21954: gcore: Add powerpc64 32-bit gcore support.
Fri, Oct 11, 2:17 PM
jhibbits committed rS353436: gcore: Add aarch64 32-bit core support.
gcore: Add aarch64 32-bit core support
Fri, Oct 11, 2:16 PM
jhibbits closed D21947: gcore: Add aarch64 32-bit core support.
Fri, Oct 11, 2:16 PM

Wed, Oct 9

jhibbits accepted D21476: [PowerPC] force applications linked with lib CSU to have .got.
Wed, Oct 9, 9:21 PM
jhibbits updated the diff for D21947: gcore: Add aarch64 32-bit core support.

Address @emaste's comments

Wed, Oct 9, 5:26 PM
jhibbits updated the diff for D21947: gcore: Add aarch64 32-bit core support.

Address andrew's feedback. Thanks!

Wed, Oct 9, 3:43 PM
jhibbits created D21954: gcore: Add powerpc64 32-bit gcore support.
Wed, Oct 9, 3:21 AM

Tue, Oct 8

jhibbits retitled D21947: gcore: Add aarch64 32-bit core support from gcore: Add aarch64 support to gcore: Add aarch64 32-bit core support.
Tue, Oct 8, 9:33 PM
jhibbits created D21947: gcore: Add aarch64 32-bit core support.
Tue, Oct 8, 9:30 PM
jhibbits committed rS353297: loader/powerpc64: Include generic PVR values in CAS architecture list.
loader/powerpc64: Include generic PVR values in CAS architecture list
Tue, Oct 8, 2:37 AM
jhibbits closed D21682: powerpc: Implement atomic_(f)cmpset_ for short and char.
Tue, Oct 8, 1:36 AM
jhibbits committed rS353296: powerpc: Implement atomic_(f)cmpset_ for short and char.
powerpc: Implement atomic_(f)cmpset_ for short and char
Tue, Oct 8, 1:36 AM

Mon, Oct 7

jhibbits committed rS353160: loader/powerpc64: Fix HV check for CAS usage.
loader/powerpc64: Fix HV check for CAS usage
Mon, Oct 7, 3:05 AM
jhibbits committed rS353158: powerpc64/pmap: Fix release order to match lock order in moea64_enter().
powerpc64/pmap: Fix release order to match lock order in moea64_enter()
Mon, Oct 7, 2:37 AM

Sun, Oct 6

jhibbits committed rS353147: powerpc/pmap64: Properly parenthesize PV_LOCK_COUNT macros.
powerpc/pmap64: Properly parenthesize PV_LOCK_COUNT macros
Sun, Oct 6, 7:11 PM

Tue, Oct 1

jhibbits accepted D21822: Provide generic sub-word atomic *cmpset.

This will simplify D21682 a bit, as well. PowerPC has sub-word atomics since PowerISA 2.06, so we'll need dual personality there.

Tue, Oct 1, 3:45 PM

Mon, Sep 30

jhibbits committed rS352899: MF stable/12 r352685:.
MF stable/12 r352685:
Mon, Sep 30, 2:12 PM

Sat, Sep 28

jhibbits created D21829: powerpc: Add AmigaOne platform, a subclass of MPC85xx.
Sat, Sep 28, 3:57 AM
jhibbits accepted D21476: [PowerPC] force applications linked with lib CSU to have .got.
Sat, Sep 28, 3:50 AM
jhibbits committed rS352832: powerpc/booke64: Align initial stack setting to match that of aim64's.
powerpc/booke64: Align initial stack setting to match that of aim64's
Sat, Sep 28, 3:33 AM
jhibbits committed rS352831: dpaa(4): Fix memcpy size for threshold copy in NCSW contrib.
dpaa(4): Fix memcpy size for threshold copy in NCSW contrib
Sat, Sep 28, 2:49 AM

Wed, Sep 25

jhibbits committed rS352685: MFC r342563:.
MFC r342563:
Wed, Sep 25, 2:33 PM
jhibbits added a comment to D21551: [PPC64] Initial kernel minidump implementation.

Can you add a key/sentinel into the dump structure to say what pmap it's using? libkvm will need it for properly decoding addresses, and that differential will also need to be updated to use the key and select a backend.

Wed, Sep 25, 1:57 AM
jhibbits committed rS352667: powerpc/atomic: Follow recommendations on atomic primitive comparisons.
powerpc/atomic: Follow recommendations on atomic primitive comparisons
Wed, Sep 25, 1:40 AM
jhibbits committed rS352666: powerpc: Allocate DPCPU block from domain-local memory.
powerpc: Allocate DPCPU block from domain-local memory
Wed, Sep 25, 1:23 AM

Fri, Sep 20

jhibbits closed D21725: powerpc/loader: Install ubldr without stripping.
Fri, Sep 20, 1:35 PM
jhibbits committed rS352557: powerpc/loader: Install ubldr without stripping.
powerpc/loader: Install ubldr without stripping
Fri, Sep 20, 1:35 PM
jhibbits created D21725: powerpc/loader: Install ubldr without stripping.
Fri, Sep 20, 3:30 AM

Wed, Sep 18

jhibbits added a comment to D21555: [PPC64] Initial libkvm minidump implementation.

This is very specific to AIM64 HPT. Can you rename it to kvm_..._hpt.c, or something, and add another key to the header to probe against for the particular pmap implementation? I'll want to add Book-E support, as well as AIM Radix when we do finally get radix stabilized.

Wed, Sep 18, 3:27 AM
jhibbits added a reviewer for D21682: powerpc: Implement atomic_(f)cmpset_ for short and char: PowerPC.
Wed, Sep 18, 3:21 AM

Tue, Sep 17

jhibbits created D21682: powerpc: Implement atomic_(f)cmpset_ for short and char.
Tue, Sep 17, 3:14 AM

Sat, Sep 14

jhibbits accepted D21656: Fix aux_info corruption in rtld direct execution mode.
Sat, Sep 14, 2:31 PM
jhibbits closed D21631: powerpc/powernv: Add OPAL NVRAM driver.

r352313

Sat, Sep 14, 4:06 AM
jhibbits committed rS352313: powerpc64/powernv: Add opal NVRAM driver for PowerNV systems.
powerpc64/powernv: Add opal NVRAM driver for PowerNV systems
Sat, Sep 14, 3:31 AM

Sep 13 2019

jhibbits added inline comments to D21631: powerpc/powernv: Add OPAL NVRAM driver.
Sep 13 2019, 8:22 PM
jhibbits created D21631: powerpc/powernv: Add OPAL NVRAM driver.
Sep 13 2019, 3:11 AM

Sep 12 2019

jhibbits accepted D21070: [PPC64] Add ifunc support in libcsu.

This should be able to go in before flag day, there's nothing preventing it from working (we don't need linker support just for this, it's all in code).

Sep 12 2019, 3:03 PM

Sep 10 2019

jhibbits accepted D21583: Add powerpc support to libkvm probe function.
Sep 10 2019, 6:35 PM
jhibbits accepted D21587: Add R_PPC_IRELATIVE relocation.
Sep 10 2019, 4:05 PM

Sep 9 2019

jhibbits added inline comments to D21555: [PPC64] Initial libkvm minidump implementation.
Sep 9 2019, 7:57 PM

Sep 6 2019

jhibbits added a comment to D21551: [PPC64] Initial kernel minidump implementation.

Only a trivial review so far.

Sep 6 2019, 4:28 PM
jhibbits added a comment to D21476: [PowerPC] force applications linked with lib CSU to have .got.

I like it, except for the typo :)

Sep 6 2019, 2:35 PM
jhibbits added a comment to D21476: [PowerPC] force applications linked with lib CSU to have .got.

@i_maskray.me, you're right. It should just be

Sep 6 2019, 2:09 PM
jhibbits committed rS351923: powerpc64/pmap: Fix a WITNESS error in alloc_pvo_entry().
powerpc64/pmap: Fix a WITNESS error in alloc_pvo_entry()
Sep 6 2019, 3:02 AM
jhibbits committed rS351921: powerpc64/pmap: Simplify the code path for moea64_pte_replace_native().
powerpc64/pmap: Simplify the code path for moea64_pte_replace_native()
Sep 6 2019, 2:46 AM
jhibbits closed D21515: powerpc64/pmap: Simplify the code path for moea64_pte_replace_native().
Sep 6 2019, 2:46 AM
jhibbits committed rS351920: Loader: Add load offset to powerpc kernel entry point.
Loader: Add load offset to powerpc kernel entry point
Sep 6 2019, 2:28 AM
jhibbits closed D21286: Loader: Add load offset to powerpc kernel entry point.
Sep 6 2019, 2:28 AM

Sep 5 2019

jhibbits added inline comments to D21070: [PPC64] Add ifunc support in libcsu.
Sep 5 2019, 9:55 PM
jhibbits added a comment to D21476: [PowerPC] force applications linked with lib CSU to have .got.

Can you instead add something like the following to crt1.c?

Sep 5 2019, 9:51 PM
jhibbits updated the diff for D21515: powerpc64/pmap: Simplify the code path for moea64_pte_replace_native().

Address luporl's comments.

Sep 5 2019, 3:42 AM

Sep 4 2019

jhibbits created D21515: powerpc64/pmap: Simplify the code path for moea64_pte_replace_native().
Sep 4 2019, 3:17 AM

Sep 2 2019

jhibbits added a comment to D21449: powerpc/pmap: NUMA-ize vm_page_array on powerpc.

On Book-E it's already allocated out of KVA, as part of the bootstrap carving. Looks like on AIM I could just adjust virtual_avail as you mention in your comment in D21491, there would be up to 32MB (less 2 pages) slop, (15MB less 1 page on either side) which is probably fine on NUMA machines. But we do only have 32GB KVA available currently, and if the vm_page_array is ~3% of total memory, on a 256GB machine that's ~8GB, which is pretty big. I think I'd rather hold off on it until we either increase KVA or get actual working dump support.

Sep 2 2019, 8:19 PM
jhibbits added a comment to D21206: libc: add fdwalk.

@mjg glib does use fdwalk() if available, and emulates it where needed. This work I started specifically because I saw this same code flow in multiple ports.

Sep 2 2019, 3:04 AM

Sep 1 2019

jhibbits added inline comments to D21286: Loader: Add load offset to powerpc kernel entry point.
Sep 1 2019, 12:45 AM
jhibbits added a comment to D21286: Loader: Add load offset to powerpc kernel entry point.

Address feedback. I think this is better overall, simplifies things.

Sep 1 2019, 12:26 AM

Aug 31 2019

jhibbits added a comment to D21449: powerpc/pmap: NUMA-ize vm_page_array on powerpc.

This change appears to give me a 15-20% improvement with building llvm on my Talos (144 thread POWER9). No change at all with buildworld.

Aug 31 2019, 4:05 AM

Aug 28 2019

jhibbits created D21449: powerpc/pmap: NUMA-ize vm_page_array on powerpc.
Aug 28 2019, 3:34 AM

Aug 27 2019

jhibbits committed rS351546: Revert a part of r350883 that should never have gone in.
Revert a part of r350883 that should never have gone in
Aug 27 2019, 2:04 PM

Aug 26 2019

jhibbits added a comment to D21414: Make vm_page_array setting dynamic in the PMAP_HAS_PAGE_ARRAY case.

You're right, I don't know what I was thinking. The page_range change is the only thing needed from this diff.

Aug 26 2019, 8:24 PM
jhibbits created D21414: Make vm_page_array setting dynamic in the PMAP_HAS_PAGE_ARRAY case.
Aug 26 2019, 2:41 AM

Aug 25 2019

jhibbits committed rS351487: powerpc/booke: Clean up pmap a little for 64-bit.
powerpc/booke: Clean up pmap a little for 64-bit
Aug 25 2019, 8:11 PM
jhibbits committed rS351486: powerpc/booke: Use the DMAP if possible in pmap_map().
powerpc/booke: Use the DMAP if possible in pmap_map()
Aug 25 2019, 8:09 PM

Aug 21 2019

jhibbits committed rS351322: dpaa: Fix warnings in dtsec(4) found by clang.
dpaa: Fix warnings in dtsec(4) found by clang
Aug 21 2019, 2:26 AM

Aug 20 2019

jhibbits committed rS351250: Unbreak USB ethernet module builds.
Unbreak USB ethernet module builds
Aug 20 2019, 3:14 PM
jhibbits committed rS351245: powerpc: Link Book-E kernels at the same address as AIM kernels.
powerpc: Link Book-E kernels at the same address as AIM kernels
Aug 20 2019, 1:26 AM
jhibbits closed D21301: powerpc: Link Book-E kernels at the same address as AIM kernels.
Aug 20 2019, 1:26 AM

Aug 18 2019

jhibbits added a comment to D21301: powerpc: Link Book-E kernels at the same address as AIM kernels.

Fix 32-bit build.

Aug 18 2019, 2:26 AM

Aug 17 2019

jhibbits created D21301: powerpc: Link Book-E kernels at the same address as AIM kernels.
Aug 17 2019, 3:44 AM
jhibbits added a comment to D21297: Fix loader on powerpc32.

It shouldn't be built for powerpc32, only powerpc64. However, it doesn't hurt anything, and is a good belt-and-suspenders change.

Aug 17 2019, 2:13 AM · PowerPC

Aug 16 2019

jhibbits added inline comments to D21286: Loader: Add load offset to powerpc kernel entry point.
Aug 16 2019, 2:15 PM
jhibbits created D21286: Loader: Add load offset to powerpc kernel entry point.
Aug 16 2019, 3:40 AM

Aug 15 2019

jhibbits added a comment to D21206: libc: add fdwalk.

Address @kib's feedback. The man page will probably need more iterating, but I
think the code is correct. It may not be optimal, though.

Aug 15 2019, 3:44 AM
jhibbits committed rS351065: powerpc/pmap: Enable UMA_MD_SMALL_ALLOC for 64-bit booke.
powerpc/pmap: Enable UMA_MD_SMALL_ALLOC for 64-bit booke
Aug 15 2019, 3:42 AM

Aug 14 2019

jhibbits added a comment to D21206: libc: add fdwalk.

Don't call getpid(), we can pass 0 now.

Aug 14 2019, 1:50 AM
jhibbits added a comment to D21206: libc: add fdwalk.

Incorporate mjg's changes.

Aug 14 2019, 1:46 AM

Aug 13 2019

jhibbits added a comment to D21206: libc: add fdwalk.

Add a new sysctl, kern.proc.fdmap.<proc>, to provide the bitmap. Walk the bitmap instead of the file descriptor list.

Aug 13 2019, 3:18 AM

Aug 12 2019

D21233: Move sc out of the global file is now accepted and ready to land.
Aug 12 2019, 9:02 PM
D21231: [ppc] avoid empty mdproc struct is now accepted and ready to land.
Aug 12 2019, 5:10 PM
jhibbits committed rS350883: powerpc: Unify pmap definitions between AIM and Book-E.
powerpc: Unify pmap definitions between AIM and Book-E
Aug 12 2019, 3:04 AM

Aug 11 2019

jhibbits added a comment to D21206: libc: add fdwalk.
In D21206#461101, @mjg wrote:

It's not hard to add such a sysctl. If you want I can hack it up for you. I think it should just export the fd bitmap, then iteration over it is trivial.

Aug 11 2019, 3:41 AM

Aug 10 2019

jhibbits added a comment to D21206: libc: add fdwalk.

Address @kib's feedback. Man page will probably require several iterations
to get right. It's still a little muddy.

Aug 10 2019, 8:10 PM
D21207: Move screen saver stuff to x86 NOTES is now accepted and ready to land.
Aug 10 2019, 4:28 PM
D21208: Floppy driver really only works on x86 is now accepted and ready to land.
Aug 10 2019, 4:26 PM
jhibbits created D21206: libc: add fdwalk.
Aug 10 2019, 2:53 AM

Aug 9 2019

jhibbits committed rS350814: autofs: Fix autounmountd's printing of mount time..
autofs: Fix autounmountd's printing of mount time.
Aug 9 2019, 2:20 AM

Aug 8 2019

jhibbits added a comment to D15118: memcpy optimization for powerpc64.

Looks fine overall, just the one question. I just want to be sure this is thoroughly tested before it goes in, on the corner cases.

Aug 8 2019, 9:46 PM · PowerPC
D20946: Bypass errno handling in _umtx_op_err on powerpc is now accepted and ready to land.

Looks good now.

Aug 8 2019, 7:40 PM · PowerPC
jhibbits committed rS350756: mips: Fix register target for SP setting in libproc.
mips: Fix register target for SP setting in libproc
Aug 8 2019, 4:37 PM