Page MenuHomeFreeBSD

jhibbits (Justin Hibbits)
User

Projects

User Details

User Since
May 16 2014, 7:29 PM (227 w, 1 d)

Recent Activity

Mon, Sep 17

jhibbits added a reviewer for D17183: Fix random DMA failure on powernv: nwhitehorn.
Mon, Sep 17, 6:22 PM · PowerPC
jhibbits created D17197: Minor update to audio/pithos.
Mon, Sep 17, 1:57 PM

Fri, Sep 14

jhibbits accepted D17165: enable pmcstat / pmccontrol for gcc4.

Thanks for bringing these back for me.

Fri, Sep 14, 12:37 AM

Thu, Sep 6

jhibbits created D17044: Fix build of lang/spidermonkey52 for GCC-based targets.
Thu, Sep 6, 12:24 PM

Mon, Sep 3

jhibbits accepted D16889: powerpc64: Add initial support for HTM.

Double check that there aren't any other registers needed saving for HTM, too.

Mon, Sep 3, 3:07 AM

Fri, Aug 24

jhibbits added a comment to D15243: Powerpc64: Enable Hardware Transactional Memory.

@breno.leitao_gmail.com Can you pull out the pcb.h and pcpu.h changes into a separate diff? That way we can get that in before the KBI freeze, and wait until 12.1 to get the actual code in. Once KBI is frozen it's frozen for the full 12.0 life, and any KBI breakage we want to perform will have to wait for 13.0.

Fri, Aug 24, 5:04 PM

Aug 23 2018

jhibbits resigned from D16721: Touchscreen support for Touchscreens on amd64 and i386 platforms.
Aug 23 2018, 8:42 PM

Aug 19 2018

jhibbits committed rS338073: powerpc conf: Add PRINTF_BUFR_SIZE option to Book-E configs.
powerpc conf: Add PRINTF_BUFR_SIZE option to Book-E configs
Aug 19 2018, 7:08 PM
jhibbits committed rS338072: Sort SPR_SPEFSCR in the SPR list.
Sort SPR_SPEFSCR in the SPR list
Aug 19 2018, 7:04 PM
jhibbits committed rS338071: powerpc64: Align frequently used/exclusive data on cacheline boundaries.
powerpc64: Align frequently used/exclusive data on cacheline boundaries
Aug 19 2018, 7:00 PM
jhibbits committed rS338069: booke pmap: hide debug-ish printf behind bootverbose.
booke pmap: hide debug-ish printf behind bootverbose
Aug 19 2018, 6:54 PM

Aug 17 2018

jhibbits committed rS337953: random: Add PowerPC 'darn' instruction entropy source.
random: Add PowerPC 'darn' instruction entropy source
Aug 17 2018, 3:49 AM
jhibbits closed D16552: random: Add PowerPC 'darn' instruction entropy source.
Aug 17 2018, 3:49 AM

Aug 16 2018

jhibbits accepted D16756: Add INVARIANTS-only fences to synchronize lockless refcount updates..

Survives a buildworld, something it couldn't do before.

Aug 16 2018, 10:13 PM

Aug 12 2018

jhibbits committed rS337689: ipmi/opal: Enable polled mode and proper callback.
ipmi/opal: Enable polled mode and proper callback
Aug 12 2018, 8:34 PM

Aug 10 2018

jhibbits committed rS337562: powerpc: Add lwsync and ptesync 'sync' opcode variants to ddb disassembler.
powerpc: Add lwsync and ptesync 'sync' opcode variants to ddb disassembler
Aug 10 2018, 3:29 AM

Aug 9 2018

jhibbits added a comment to D16404: nvme: Alternate approach to restoring API.

I like this. It cleans things up, and drops some ugly macros.

Aug 9 2018, 2:47 PM

Aug 8 2018

jhibbits accepted D16633: [powerpc] Fix kernel panic when using "options BOOTP_NFSROOT".

Approved. A cleaner solution might be to add another SI_SUB_ node, or reuse an existing one for all cases. But this unblocks us, and is sufficient. SI_SUB_INIT_IF looks like a good one (no need to do it now).

Aug 8 2018, 8:00 PM
jhibbits accepted D16617: powerpc64/powernv: re-read RTC after polling.

Looks good

Aug 8 2018, 7:55 PM

Aug 3 2018

jhibbits committed rS337273: nvme(4): Add bus_dmamap_sync() at the end of the request path.
nvme(4): Add bus_dmamap_sync() at the end of the request path
Aug 3 2018, 8:04 PM
jhibbits closed D16570: nvme(4): Add bus_dmamap_sync() at the end of the request path.
Aug 3 2018, 8:04 PM
jhibbits added a comment to D16570: nvme(4): Add bus_dmamap_sync() at the end of the request path.

@jimharris is this good to commit as-is now, or should I look at more changes?

Aug 3 2018, 4:51 PM
jhibbits added a comment to D16570: nvme(4): Add bus_dmamap_sync() at the end of the request path.

I just created https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230334 for adding a bus_dmamap_sync_range() KPI.

Aug 3 2018, 4:25 PM
jhibbits added a comment to D16570: nvme(4): Add bus_dmamap_sync() at the end of the request path.

There is no prp_dma_map. The prp_bus_addr exists in the qpair->queuemem_map, so does get synced. Or am I reading it wrong?

Aug 3 2018, 4:00 PM
jhibbits added a comment to D16570: nvme(4): Add bus_dmamap_sync() at the end of the request path.

I just reverted this patch to test as well. I ran 2 'make buildworld -j72 -s' and 1 'make buildworld buildkernel -j72 -s'. The performance difference I saw was not as great as I originally wrote, something else had improved performance elsewhere in the last couple weeks. I did, however, see a 5-10% improvement, so it's not entirely insignificant. I also did see "Missing interrupt" messages with the patch, they just did not occur as frequently as previously without.

Aug 3 2018, 3:50 PM

Aug 2 2018

jhibbits updated the diff for D16570: nvme(4): Add bus_dmamap_sync() at the end of the request path.

Bring back the wmb() for !powerpc. powerpc's bus_dmamap_sync already includes
an explicit hwsync, but other archs do not.

Aug 2 2018, 7:58 PM
jhibbits added inline comments to D16570: nvme(4): Add bus_dmamap_sync() at the end of the request path.
Aug 2 2018, 7:51 PM
jhibbits updated the diff for D16570: nvme(4): Add bus_dmamap_sync() at the end of the request path.

Address jimharris's comments.

Aug 2 2018, 7:43 PM
jhibbits added a comment to D16570: nvme(4): Add bus_dmamap_sync() at the end of the request path.

Hi Jim,

Aug 2 2018, 6:59 PM
jhibbits created D16570: nvme(4): Add bus_dmamap_sync() at the end of the request path.
Aug 2 2018, 4:56 PM
jhibbits added inline comments to D16552: random: Add PowerPC 'darn' instruction entropy source.
Aug 2 2018, 2:35 PM

Aug 1 2018

jhibbits updated the diff for D16552: random: Add PowerPC 'darn' instruction entropy source.

Remove x86 names (rdrand, ivy) from the function names. No other changes.

Aug 1 2018, 8:41 PM
jhibbits added a comment to D16552: random: Add PowerPC 'darn' instruction entropy source.

I should add, from the ISA reference:

Aug 1 2018, 8:34 PM
jhibbits created D16552: random: Add PowerPC 'darn' instruction entropy source.
Aug 1 2018, 8:29 PM
jhibbits committed rS337043: snd_hda: Synchronize DMA buffers for the control path.
snd_hda: Synchronize DMA buffers for the control path
Aug 1 2018, 2:50 PM
jhibbits closed D16517: snd_hda: Enable bus_dmamap_sync operations, both new and uncommented.
Aug 1 2018, 2:50 PM

Jul 31 2018

jhibbits committed rS336983: snd_hda: Byteswap the buffer descriptor entries as needed.
snd_hda: Byteswap the buffer descriptor entries as needed
Jul 31 2018, 5:19 PM

Jul 30 2018

jhibbits created D16517: snd_hda: Enable bus_dmamap_sync operations, both new and uncommented.
Jul 30 2018, 8:12 PM
jhibbits committed rS336931: snd_hda: Make codec control path endian safe.
snd_hda: Make codec control path endian safe
Jul 30 2018, 8:01 PM
jhibbits committed rS336925: Add ofw_bus_if.h to the SRCS list for ipmi module on powerpc64.
Add ofw_bus_if.h to the SRCS list for ipmi module on powerpc64
Jul 30 2018, 6:29 PM
jhibbits committed rS336918: powerpcspe: Unconditionally save an restore SPEFSCR on task switch.
powerpcspe: Unconditionally save an restore SPEFSCR on task switch
Jul 30 2018, 5:03 PM
jhibbits committed rS336912: snd_hda: Print error codes in decimal, rather than hex.
snd_hda: Print error codes in decimal, rather than hex
Jul 30 2018, 3:20 PM
jhibbits committed rS336911: snd_hda: Only free streams DMA maps if the streams list has been created.
snd_hda: Only free streams DMA maps if the streams list has been created
Jul 30 2018, 3:15 PM

Jul 29 2018

jhibbits created D16502: Force 32-bit powerpc to use sync instead of lwsync in CK.
Jul 29 2018, 8:07 PM

Jul 26 2018

jhibbits added inline comments to D16351: Create devel/powerpcspe-xtoolchain-gcc and supporting ports.
Jul 26 2018, 3:09 PM
jhibbits committed rS336739: Fix fabs(3) for powerpcspe, this time for real.
Fix fabs(3) for powerpcspe, this time for real
Jul 26 2018, 2:42 PM

Jul 25 2018

jhibbits committed rS336725: Only build ipmi_linux on x86.
Only build ipmi_linux on x86
Jul 25 2018, 7:31 PM
jhibbits committed rS336724: Support building IPMI as a module on powerpc64.
Support building IPMI as a module on powerpc64
Jul 25 2018, 6:59 PM

Jul 24 2018

jhibbits committed rS336689: Fix register usage in fabs(3) for powerpcspe.
Fix register usage in fabs(3) for powerpcspe
Jul 24 2018, 10:06 PM
jhibbits committed rS336688: Fix floating point exception definitions for powerpcspe.
Fix floating point exception definitions for powerpcspe
Jul 24 2018, 10:05 PM

Jul 23 2018

jhibbits added a comment to D16351: Create devel/powerpcspe-xtoolchain-gcc and supporting ports.
In D16351#348390, @jhb wrote:

This looks ok to me, but I'm not a ports committer. Did you use poudriere testport or 'make check-plist' to verify the packing lists?

Jul 23 2018, 8:59 PM

Jul 20 2018

jhibbits committed rS336555: vt/ofwfb: Fix brain-o from r336514, use the correct form of /chosen/stdout-path.
vt/ofwfb: Fix brain-o from r336514, use the correct form of /chosen/stdout-path
Jul 20 2018, 4:18 PM
jhibbits committed rS336554: vt/ofwfb: Check that /chosen/stdout is valid before using it in initialization.
vt/ofwfb: Check that /chosen/stdout is valid before using it in initialization
Jul 20 2018, 4:08 PM

Jul 19 2018

jhibbits committed rS336517: Revert r336509. Fails buildworld..
Revert r336509. Fails buildworld.
Jul 19 2018, 9:07 PM
jhibbits committed rS336514: ofwfb: Check for /chosen/stdout-path in addition to /chosen/stdout.
ofwfb: Check for /chosen/stdout-path in addition to /chosen/stdout
Jul 19 2018, 8:23 PM
jhibbits committed rS336509: Merge the md_page structs for AIM and Book-E into a single unioned struct.
Merge the md_page structs for AIM and Book-E into a single unioned struct
Jul 19 2018, 8:13 PM
jhibbits closed D16232: Merge the md_page structs for AIM and Book-E into a single unioned struct.
Jul 19 2018, 8:13 PM
jhibbits created D16351: Create devel/powerpcspe-xtoolchain-gcc and supporting ports.
Jul 19 2018, 5:35 PM

Jul 16 2018

jhibbits committed rS336355: dtrace/powerpc: Correct register indices for non-indexed registers in the….
dtrace/powerpc: Correct register indices for non-indexed registers in the…
Jul 16 2018, 7:47 PM

Jul 11 2018

jhibbits created D16232: Merge the md_page structs for AIM and Book-E into a single unioned struct.
Jul 11 2018, 10:22 PM

Jul 10 2018

jhibbits committed rS336173: Correct the identifier for the Unifi Security Gateway.
Correct the identifier for the Unifi Security Gateway
Jul 10 2018, 5:01 PM

Jul 9 2018

jhibbits committed rS336144: powerpc/powernv: Make opal_i2c driver work with attached i2c drivers.
powerpc/powernv: Make opal_i2c driver work with attached i2c drivers
Jul 9 2018, 8:33 PM

Jul 7 2018

jhibbits committed rS336056: Let ofw_iicbus work its magic on OPAL i2c buses..
Let ofw_iicbus work its magic on OPAL i2c buses.
Jul 7 2018, 1:58 AM

Jul 5 2018

jhibbits added a comment to D16131: Sprinkle bits around to make ports build on tier2/gcc targets.

Thanks for the review, guys. It's quite obvious now that my patch is more WIP than complete and ready, but I think the bulk is still good.

Jul 5 2018, 5:24 PM
jhibbits updated the diff for D16131: Sprinkle bits around to make ports build on tier2/gcc targets.

Revert a no-longer-necessary diff against libvpx. There may be more, as I did
the work on one tree and submitted the diff from another tree.

Jul 5 2018, 2:01 AM
jhibbits added inline comments to D16131: Sprinkle bits around to make ports build on tier2/gcc targets.
Jul 5 2018, 1:58 AM
jhibbits added inline comments to D15118: memcpy optimization for powerpc64.
Jul 5 2018, 1:40 AM · PowerPC
jhibbits created D16131: Sprinkle bits around to make ports build on tier2/gcc targets.
Jul 5 2018, 1:27 AM

Jun 29 2018

jhibbits committed rS335801: Support multiple OPAL consoles, and don't crash if uart is not stdout.
Support multiple OPAL consoles, and don't crash if uart is not stdout
Jun 29 2018, 7:35 PM
jhibbits closed D16071: Support multiple OPAL consoles, and don't crash if uart is not stdout.
Jun 29 2018, 7:35 PM
jhibbits created D16071: Support multiple OPAL consoles, and don't crash if uart is not stdout.
Jun 29 2018, 7:15 PM

Jun 27 2018

jhibbits accepted D15705: ofw: Load initrd file.

Just one minor nit, but otherwise good to go.

Jun 27 2018, 12:50 AM

Jun 25 2018

jhibbits committed rS335648: Expose stopped cpu contexts to ddb on PowerPC.
Expose stopped cpu contexts to ddb on PowerPC
Jun 25 2018, 10:05 PM
jhibbits closed D15986: Expose stopped cpu contexts to ddb on PowerPC.
Jun 25 2018, 10:05 PM · PowerPC
jhibbits accepted D15986: Expose stopped cpu contexts to ddb on PowerPC.
Jun 25 2018, 9:47 PM · PowerPC

Jun 23 2018

jhibbits committed rS335574: powerpc64: Fix stack setup in dbtrap.
powerpc64: Fix stack setup in dbtrap
Jun 23 2018, 1:42 AM
jhibbits closed D15973: Fix debug trap on Talos II (and all of ppc64?).
Jun 23 2018, 1:42 AM · PowerPC
jhibbits accepted D15973: Fix debug trap on Talos II (and all of ppc64?).

Great work tracking this down!

Jun 23 2018, 1:33 AM · PowerPC

Jun 21 2018

jhibbits committed rS335491: Fix the build post-PMCR addition..
Fix the build post-PMCR addition.
Jun 21 2018, 3:59 PM
jhibbits committed rS335483: Add the rest of the files for r335481.
Add the rest of the files for r335481
Jun 21 2018, 2:30 PM
jhibbits committed rS335481: Introduce PMCR-based cpufreq(4) driver, for IBM POWER8 and POWER9 systems.
Introduce PMCR-based cpufreq(4) driver, for IBM POWER8 and POWER9 systems
Jun 21 2018, 2:26 PM
jhibbits closed D15932: Introduce PMCR-based cpufreq(4) driver, for IBM POWER9 systems.
Jun 21 2018, 2:26 PM
jhibbits abandoned D15835: Set the console sc if it's not already set..

This approach is wrong. The problem I was trying to solve is the interrupt handler accessing a bad sc. The proper fix will be to instead make the interrupt handler use a sc, instead of a consdev, and move more state data into the sc.

Jun 21 2018, 1:53 PM
jhibbits added inline comments to D15932: Introduce PMCR-based cpufreq(4) driver, for IBM POWER9 systems.
Jun 21 2018, 1:41 PM

Jun 20 2018

jhibbits created D15932: Introduce PMCR-based cpufreq(4) driver, for IBM POWER9 systems.
Jun 20 2018, 7:08 PM
jhibbits committed rS335442: Attach dev.cpu nodes on powerpc SMT cores, using only the first found thread.
Attach dev.cpu nodes on powerpc SMT cores, using only the first found thread
Jun 20 2018, 1:30 PM
jhibbits closed D15921: Attach dev.cpu nodes on SMT cores, using only the first found thread.
Jun 20 2018, 1:30 PM
jhibbits added inline comments to D15921: Attach dev.cpu nodes on SMT cores, using only the first found thread.
Jun 20 2018, 1:23 PM
jhibbits created D15921: Attach dev.cpu nodes on SMT cores, using only the first found thread.
Jun 20 2018, 4:53 AM

Jun 15 2018

jhibbits created D15835: Set the console sc if it's not already set..
Jun 15 2018, 9:17 PM
jhibbits updated the diff for D15818: Add a delayed VT attachment for ofwfb.

Reduce the diff, by sharing the same VT driver between the early attach and delayed attach. This required moving some config setting into the probe routine, but that should be fine.

Jun 15 2018, 9:11 PM
jhibbits added inline comments to D15818: Add a delayed VT attachment for ofwfb.
Jun 15 2018, 7:15 PM
jhibbits committed rS335226: Check for a 'pci' prefix rather than a full match in get_addr_props.
Check for a 'pci' prefix rather than a full match in get_addr_props
Jun 15 2018, 6:55 PM
jhibbits closed D15817: Check for a 'pci' prefix rather than a full match in get_addr_props.
Jun 15 2018, 6:55 PM
jhibbits updated the diff for D15817: Check for a 'pci' prefix rather than a full match in get_addr_props.

I should probably caffeinate before making such trivial changes.

Jun 15 2018, 6:28 PM
jhibbits updated the diff for D15817: Check for a 'pci' prefix rather than a full match in get_addr_props.

Change to nwhitehorn's preference. Either is fine with me.

Jun 15 2018, 2:15 PM
jhibbits created D15818: Add a delayed VT attachment for ofwfb.
Jun 15 2018, 3:57 AM
jhibbits created D15817: Check for a 'pci' prefix rather than a full match in get_addr_props.
Jun 15 2018, 3:45 AM
jhibbits committed rS335187: ofw_reg_to_paddr(): Fix minor typo in KASSERT message.
ofw_reg_to_paddr(): Fix minor typo in KASSERT message
Jun 15 2018, 3:28 AM

Jun 14 2018

jhibbits committed rS335160: Split the PowerISA 3.0 HPT implementation from historic.
Split the PowerISA 3.0 HPT implementation from historic
Jun 14 2018, 5:24 PM