- User Since
- May 16 2014, 7:29 PM (213 w, 3 d)
Fri, Jun 15
Reduce the diff, by sharing the same VT driver between the early attach and delayed attach. This required moving some config setting into the probe routine, but that should be fine.
I should probably caffeinate before making such trivial changes.
Change to nwhitehorn's preference. Either is fine with me.
Thu, Jun 14
Tue, Jun 12
Mon, Jun 11
This can be simplified to just "if (count < (int)sizeof(cell_t))"
Sun, Jun 10
Fri, Jun 8
Bump PORTREVISION on print/qpdf and games/qqwing. They're dependencies for
packages that need c++11, and themselves, on their own, don't really need c++11,
but their dependent ports won't link otherwise.
Expand to all ZFS uses found.
Thu, Jun 7
The code looks fine to me. Can you include a test for it? You showed me the torture test, so that'd be good to include in tools/tools. With a test, I'll approve it.
Drop mail/evolution. It failed the jenkins build for unrelated reasons.
Wed, Jun 6
Tue, Jun 5
Mon, Jun 4
Eliminate an extraneous parenthesis pair, add the mpc85xx check to create a
512MB boot partition.
Sun, Jun 3
Sat, Jun 2
Overall I like the optimization here. I think memmove()/memcpy() are used often for relatively large block copies, so I really like the savings it offers. Just a few comments to address.
Fri, Jun 1
Thu, May 31
Wed, May 30
Tue, May 29
Mon, May 28
Sun, May 27
Sat, May 26
Ping? With this and two other reviews, I can now boot FreeBSD on POWER9 to multiuser, so want to get these in soon.
Fri, May 25
No need to comment out the OPAL_PCI_MAP_PE_MMIO_WINDOW. It likely was already
mapped as such by Opal.
Thu, May 24
Tue, May 22
Mon, May 21
Sun, May 20
Add a small delay, and a timeout, if a sensor needs extra time
Abandoned in favor of D15492