Page MenuHomeFreeBSD

jhibbits (Justin Hibbits)
User

Projects

User Details

User Since
May 16 2014, 7:29 PM (517 w, 5 d)

Recent Activity

Mon, Apr 15

jhibbits updated the diff for D42899: arm64: Make SMP `spin-table` boot method work for more than Apple Silicon.

Address feedback.

Mon, Apr 15, 7:31 PM

Thu, Apr 11

jhibbits committed rGf03a2e7b59d9: macio: Set resource map size (authored by jhibbits).
macio: Set resource map size
Thu, Apr 11, 2:09 AM

Tue, Apr 9

jhibbits added a comment to D44274: ossl: Add GCM support on powerpc64/powerpc64le (POWER8+).

Hi all, sorry for the ping. If anybody had time to review this, it would be greatly appreciated. We've deployed this patch internally on some of our production systems and in addition to the massive performance improvement, it has proven stable under various workloads.

Tue, Apr 9, 5:51 PM

Fri, Apr 5

jhibbits abandoned D32804: Add a CPU reset hook to arm64.

Committed by @stevek in 3bbe8ed1a7 (D44535)

Fri, Apr 5, 11:15 PM · arm64

Thu, Apr 4

jhibbits committed rGfcace5ab088e: powerpc/booke: Reserve KVA for minidump working area (authored by jhibbits).
powerpc/booke: Reserve KVA for minidump working area
Thu, Apr 4, 11:07 PM

Tue, Apr 2

jhibbits accepted D44598: bge(4): Add WOL support.

IfAPI looks fine.

Tue, Apr 2, 7:50 PM
jhibbits committed rG44aac9115f75: powerpc: Bump maximum number of FDT reserved mem entries (authored by sanastasio_raptorengineering.com).
powerpc: Bump maximum number of FDT reserved mem entries
Tue, Apr 2, 2:20 AM

Wed, Mar 27

jhibbits committed rG280085ef0c9d: tools/git: ensure git-arc is more platform indepdendent (authored by freebsd_igalic.co).
tools/git: ensure git-arc is more platform indepdendent
Wed, Mar 27, 1:59 PM
jhibbits closed D39975: tools/git: ensure git-arc is more platform indepdendent.
Wed, Mar 27, 1:58 PM

Tue, Mar 26

jhibbits accepted D39975: tools/git: ensure git-arc is more platform indepdendent.
Tue, Mar 26, 8:11 PM

Mon, Mar 25

jhibbits accepted D44498: amd64: initialize td_frame stack area for init(8) main thread.
Mon, Mar 25, 3:22 PM
jhibbits added a comment to D44498: amd64: initialize td_frame stack area for init(8) main thread.
In D44498#1014893, @kib wrote:
In D44498#1014883, @kib wrote:

Would it be excessive to just zero td_frame in MI code?

I am not sure that this is the correct state of the registers file for all arches.

Does it not go through exec_setregs() at some point through kern_execve()? That should set all the registers.

Please read the summary which specifically mentions %rflags.PSL_T as the cause of this patch.

Mon, Mar 25, 2:31 PM
jhibbits added a comment to D44498: amd64: initialize td_frame stack area for init(8) main thread.
In D44498#1014883, @kib wrote:

Would it be excessive to just zero td_frame in MI code?

I am not sure that this is the correct state of the registers file for all arches.

Mon, Mar 25, 2:13 PM

Mar 13 2024

jhibbits accepted D44327: libc/softfloat: we don't export _fp[gs]et* symbols.
Mar 13 2024, 8:23 PM

Mar 11 2024

jhibbits added inline comments to D42899: arm64: Make SMP `spin-table` boot method work for more than Apple Silicon.
Mar 11 2024, 3:41 PM

Mar 7 2024

jhibbits accepted D41837: ossl: Add support for powerpc64/powerpc64le.
Mar 7 2024, 2:33 AM

Mar 1 2024

jhibbits added a comment to D44015: powerpc: Bump maximum number of FDT reserved mem entries.

I'll MFC it in the next couple weeks, so it'll be in 14.1.

Mar 1 2024, 7:02 PM

Feb 29 2024

jhibbits committed rGb52dceb83811: powerpc: Bump maximum number of FDT reserved mem entries (authored by sanastasio_raptorengineering.com).
powerpc: Bump maximum number of FDT reserved mem entries
Feb 29 2024, 3:06 AM
jhibbits closed D44015: powerpc: Bump maximum number of FDT reserved mem entries.
Feb 29 2024, 3:05 AM

Feb 21 2024

jhibbits accepted D44015: powerpc: Bump maximum number of FDT reserved mem entries.

This means the function now uses more than 1kB stack space. We should be careful bumping it again in the future. It's called early enough that stack space shouldn't be an issue, but something to keep in mind, definitely.

Feb 21 2024, 8:42 PM
jhibbits committed rGcd6e526e268e: loader/libofw: Fix disk size truncation (authored by jhibbits).
loader/libofw: Fix disk size truncation
Feb 21 2024, 3:19 AM

Jan 23 2024

jhibbits accepted D43553: powerpc: Add RF_LITTLEENDIAN resource flag.
Jan 23 2024, 4:56 PM
jhibbits accepted D43434: powerpc mpc85xx: Use bus_generic_rman_*.
Jan 23 2024, 4:56 PM

Jan 22 2024

jhibbits abandoned D43495: arm64: Add socdev_va symbol when SOCDEV_PA is defined.

Addressed by D43359

Jan 22 2024, 9:03 PM

Jan 19 2024

jhibbits added inline comments to D42920: Fix clock source in the API safe_pause_*() in e1000 driver.
Jan 19 2024, 2:55 AM
jhibbits accepted D43433: powerpc psim: Use bus_generic_rman_*.

Does psim even still work?

Jan 19 2024, 2:53 AM
jhibbits accepted D43435: powerpc powermac: Use bus_generic_rman_*.
Jan 19 2024, 2:51 AM
jhibbits accepted D43436: powerpc nexus: Use bus_generic_rman_*.

Looks fine to me.

Jan 19 2024, 2:48 AM
jhibbits added a comment to D43432: powerpc ps3bus: Use bus_generic_rman_*.
In D43432#991924, @imp wrote:

I wonder if the PS3 option might be past its prime and time to retire.
I couldn't figure out how to run it for my kboot work, for example.

Jan 19 2024, 2:47 AM
jhibbits accepted D43440: powerpc: Fix bus_space_unmap.
Jan 19 2024, 2:42 AM
jhibbits requested changes to D43434: powerpc mpc85xx: Use bus_generic_rman_*.

I like the approach of the RF_LITTLEENDIAN, but fsl_sata hangs off simple-bus, not the lbc, so it's stuck with manually setting the bus tag. I can test the lbc changes later.

Jan 19 2024, 2:39 AM
jhibbits accepted D43432: powerpc ps3bus: Use bus_generic_rman_*.

Looks fine. I have no way to test, though.

Jan 19 2024, 2:35 AM

Jan 18 2024

jhibbits requested review of D43495: arm64: Add socdev_va symbol when SOCDEV_PA is defined.
Jan 18 2024, 3:27 PM

Jan 6 2024

jhibbits accepted D43322: powerpc64/SYS.h: implement _SYSCALL_BODY() macro.
Jan 6 2024, 7:29 PM
jhibbits accepted D43323: powerpc/SYS.h: implement _SYSCALL_BODY() macro.
Jan 6 2024, 7:28 PM

Dec 23 2023

jhibbits accepted D43105: powerpc: Avoid ignoring copyin()'s return value.
Dec 23 2023, 9:18 PM
jhibbits accepted D43066: ldscript.powerpc*: Only put .dynamic in PT_DYNAMIC.
Dec 23 2023, 9:17 PM

Dec 19 2023

jhibbits added a comment to D40338: powerpc*: add cryptodev to GENERIC*.

I don't disagree with the change, but I'm not sure it's needed. We could simply remove cryptodev from the Book-E kernels; I think it was added for the sec device in MPC85XX (MPC85XXSPE and QORIQ64 are copied from that), but I don't even know how complete the sec driver really is, and it's definitely *not* supported on QORIQ64 (DPAA-based SEC driver is missing, and I have no hardware with it to develop).

Dec 19 2023, 2:49 AM
jhibbits accepted D43056: power*/SYS.h: implement _SYSCALL_BODY() macro.

Looks right to me.

Dec 19 2023, 2:44 AM

Dec 17 2023

jhibbits added a comment to D42988: inet6: Use IfAPI helper in in6_ifstat_inc.
In D42988#981874, @kp wrote:
In D42988#980277, @ae wrote:

Do you plan to rework access to if_afdata? There are still several panics related to access to already freed if_afdata[AF_INET6].

Can you please assign those PRs to me? Or send links to information if there is no PR.

We see this issue on pfSense as well: https://redmine.pfsense.org/issues/14431 . There are a few different backtraces, but I believe they're all the same root problem.
The short version of the story is that there's outbound traffic, which does a route lookup (often to get an IPv6 hop limit), only to be returned a netxhop with a struct ifnet that has a NULL afdata[AF_INET6].
I believe it to correlated with said struct ifnet going away (in the case of pfSense users often because they're PPPoE users).

In addition to the pfSense bug report there's also a summary e-mail on net@: https://lists.freebsd.org/archives/freebsd-net/2023-October/004104.html

I still have both core dump and debug kernel for at least one occurrence of this issue (on a pfsense kernel, roughly equivalent to main from August).

There is definitely lots of place for improvement & simplification here. For example, dom_ifdetach should be retired in favor of eventhandler(9), just like I did for other original 4.3BSD domain/proto stuff.

Looks like we got a lot of evidence about the problem. Can we have a single place to track it? Be it pfsense redmine, FreeBSD bugzilla, phabricator?

Dec 17 2023, 6:44 PM

Dec 11 2023

jhibbits accepted D42996: libc/*/SYS.h: remove SYCALL macro.

I love the smell of deleted cruft.

Dec 11 2023, 9:20 PM
jhibbits added inline comments to D42982: powerpc: Add first Linuxulator support (ELFv1, BE, powerpc64).
Dec 11 2023, 3:11 PM
jhibbits requested review of D42992: linuxulator: Add ELFv2 and powerpc64le support.
Dec 11 2023, 3:01 AM

Dec 10 2023

jhibbits added a comment to D42972: netlink: Don't directly access ifnet members.

Got it. Looks like there is also an assumption here that the first address is always the link level address. Maybe we just need to provide KPI if_getlladdr? May I ask to wait for Alexander melifaro@ to reappear before we proceed forward with that?

P.S. I'm also waiting for him on my netlink reviews.

Dec 10 2023, 2:21 AM

Dec 9 2023

jhibbits added a comment to D42972: netlink: Don't directly access ifnet members.

I don't understand the change. The epoch protection is already right here. We can safely use CK_STAILQ_FIRST.

Dec 9 2023, 10:07 PM
jhibbits requested review of D42988: inet6: Use IfAPI helper in in6_ifstat_inc.
Dec 9 2023, 10:00 PM
jhibbits updated the diff for D42972: netlink: Don't directly access ifnet members.

Address @kp's feedback.

Dec 9 2023, 9:12 PM
jhibbits added inline comments to D42972: netlink: Don't directly access ifnet members.
Dec 9 2023, 9:03 PM
jhibbits requested review of D42982: powerpc: Add first Linuxulator support (ELFv1, BE, powerpc64).
Dec 9 2023, 2:57 AM

Dec 8 2023

jhibbits requested review of D42972: netlink: Don't directly access ifnet members.
Dec 8 2023, 9:18 PM

Dec 4 2023

jhibbits added inline comments to D42899: arm64: Make SMP `spin-table` boot method work for more than Apple Silicon.
Dec 4 2023, 6:52 PM
jhibbits retitled D42899: arm64: Make SMP `spin-table` boot method work for more than Apple Silicon from arm64: Make SMP `spin-table` boot method work to arm64: Make SMP `spin-table` boot method work for more than Apple Silicon.
Dec 4 2023, 6:45 PM
jhibbits requested review of D42899: arm64: Make SMP `spin-table` boot method work for more than Apple Silicon.
Dec 4 2023, 6:44 PM

Nov 14 2023

jhibbits committed rG8ef8939fd458: bcm2835/spi: Support SPI_FLAG_KEEP_CS (authored by jhibbits).
bcm2835/spi: Support SPI_FLAG_KEEP_CS
Nov 14 2023, 9:49 PM
jhibbits closed D42599: bcm2835/spi: Support SPI_FLAG_KEEP_CS.
Nov 14 2023, 9:48 PM
jhibbits requested review of D42599: bcm2835/spi: Support SPI_FLAG_KEEP_CS.
Nov 14 2023, 6:37 PM

Nov 9 2023

jhibbits added a comment to D42453: ibcore: Add dependency on "netstack".
In D42453#970257, @zlei wrote:

There's no "netstack" module in the FreeBSD kernel. I think a DECLARE_MODULE needs added, probably to sys/net/if.c, before this works.

The "netstack" is built into kernel. Maybe the following one?

MODULE_DEPEND(ibcore, kernel, __FreeBSD_version, __FreeBSD_version, maxver);
Nov 9 2023, 2:43 PM

Nov 3 2023

jhibbits accepted D42339: powerpc: better handling of shutdown flags.
Nov 3 2023, 8:05 PM
jhibbits added a comment to D42453: ibcore: Add dependency on "netstack".

There's no "netstack" module in the FreeBSD kernel. I think a DECLARE_MODULE needs added, probably to sys/net/if.c, before this works.

Nov 3 2023, 2:17 PM

Oct 23 2023

jhibbits added inline comments to D42339: powerpc: better handling of shutdown flags.
Oct 23 2023, 8:46 PM

Oct 18 2023

jhibbits accepted D42274: pmap: Prefer consistent naming for loader tunable.
Oct 18 2023, 2:37 PM

Oct 13 2023

jhibbits committed rG8f31b879ecaf: bpf: Add IfAPI analogue for bpf_peers_present() (authored by jhibbits).
bpf: Add IfAPI analogue for bpf_peers_present()
Oct 13 2023, 6:30 PM
jhibbits added a reverting change for rGc81dd8e5fe72: bpf: Add IfAPI analogue for bpf_peers_present(): rG5e444deec055: Revert "bpf: Add IfAPI analogue for bpf_peers_present()".
Oct 13 2023, 6:29 PM
jhibbits committed rG5e444deec055: Revert "bpf: Add IfAPI analogue for bpf_peers_present()" (authored by jhibbits).
Revert "bpf: Add IfAPI analogue for bpf_peers_present()"
Oct 13 2023, 6:29 PM
jhibbits closed D42082: bpf: Add IfAPI analogue for bpf_peers_present().

Committed as c81dd8e5f.

Oct 13 2023, 5:33 PM
jhibbits committed rGc81dd8e5fe72: bpf: Add IfAPI analogue for bpf_peers_present() (authored by jhibbits).
bpf: Add IfAPI analogue for bpf_peers_present()
Oct 13 2023, 5:23 PM
jhibbits added inline comments to D42082: bpf: Add IfAPI analogue for bpf_peers_present().
Oct 13 2023, 3:53 PM

Oct 12 2023

jhibbits updated the diff for D42082: bpf: Add IfAPI analogue for bpf_peers_present().

Address further comments from @zlei.

Oct 12 2023, 5:51 PM
jhibbits added inline comments to D42082: bpf: Add IfAPI analogue for bpf_peers_present().
Oct 12 2023, 4:51 PM
jhibbits retitled D42082: bpf: Add IfAPI analogue for bpf_peers_present() from bpf: Add seatbelt check for NULL bpf to bpf: Add IfAPI analogue for bpf_peers_present().
Oct 12 2023, 2:42 PM
jhibbits updated the diff for D42082: bpf: Add IfAPI analogue for bpf_peers_present().

Address @zlei's feedback and make an IfAPI.

Oct 12 2023, 2:41 PM

Oct 10 2023

jhibbits added inline comments to D42117: Website - Hardware archetypes upgrade.
Oct 10 2023, 6:18 PM
jhibbits added inline comments to D42082: bpf: Add IfAPI analogue for bpf_peers_present().
Oct 10 2023, 2:43 PM

Oct 9 2023

jhibbits added inline comments to D41837: ossl: Add support for powerpc64/powerpc64le.
Oct 9 2023, 3:36 PM

Oct 4 2023

jhibbits requested review of D42082: bpf: Add IfAPI analogue for bpf_peers_present().
Oct 4 2023, 8:57 PM

Sep 30 2023

jhibbits accepted D42027: netlink: fix accessing freed memory.
Sep 30 2023, 3:24 PM

Sep 19 2023

jhibbits accepted D39200: ifnet: add iterator functions for the if/ifa/ifma..
Sep 19 2023, 2:41 AM
jhibbits added inline comments to D41905: ObsoleteFiles.inc: do not remove ofwdump.8 on powerpc64le.
Sep 19 2023, 2:37 AM

Sep 17 2023

jhibbits committed rGa6662c37b6ff: powerpc: Implement fpu_kern_enter/fpu_kern_leave (authored by sanastasio_raptorengineering.com).
powerpc: Implement fpu_kern_enter/fpu_kern_leave
Sep 17 2023, 5:22 PM
jhibbits added a reverting change for rG6a47fa697ace: powerpc: Implement fpu_kern_enter/fpu_kern_leave: rG67a27733d1f4: Revert "powerpc: Implement fpu_kern_enter/fpu_kern_leave".
Sep 17 2023, 5:22 PM
jhibbits committed rG67a27733d1f4: Revert "powerpc: Implement fpu_kern_enter/fpu_kern_leave" (authored by jhibbits).
Revert "powerpc: Implement fpu_kern_enter/fpu_kern_leave"
Sep 17 2023, 5:22 PM
jhibbits added a reverting change for D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave: rG67a27733d1f4: Revert "powerpc: Implement fpu_kern_enter/fpu_kern_leave".
Sep 17 2023, 5:22 PM
jhibbits committed rG6a47fa697ace: powerpc: Implement fpu_kern_enter/fpu_kern_leave (authored by jhibbits).
powerpc: Implement fpu_kern_enter/fpu_kern_leave
Sep 17 2023, 3:45 PM
jhibbits closed D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.
Sep 17 2023, 3:44 PM

Sep 15 2023

jhibbits closed D41146: IfAPI: Retire if_etherbpfmtap() and if_bpfmtap().

Closed by 2a3716432d

Sep 15 2023, 7:50 PM

Sep 14 2023

jhibbits added a comment to D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.

Also, thank you @jhibbits for approving the patch. I'm not super familiar with the FreeBSD contribution work flow yet, so excuse the question, but is there anything that I need to do at this point to have this patch committed? I presume the patch must now be merged by someone other than me with commit privileges.

Sep 14 2023, 1:39 PM

Sep 13 2023

jhibbits accepted D41846: powerpc pmap: initialize kernel pmap radix trie.
Sep 13 2023, 5:59 PM

Sep 12 2023

jhibbits accepted D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.

As long as it doesn't require VSX (able to run on PowerMac G5), I think it's good.

Sep 12 2023, 4:54 PM

Sep 7 2023

Herald added a reviewer for D38046: ifnet/API: Move struct ifnet definition to a <net/if_private.h>: melifaro.
Sep 7 2023, 12:35 PM

Sep 2 2023

jhibbits committed rGac77837ca758: dtsec(4): Restore IFCAP_JUMBO_MTU lost in IfAPI conversion (authored by jhibbits).
dtsec(4): Restore IFCAP_JUMBO_MTU lost in IfAPI conversion
Sep 2 2023, 8:58 PM

Aug 31 2023

jhibbits added a comment to D41540: powerpc: Implement fpu_kern_enter/fpu_kern_leave.

Overall this looks good, just the one comment on SPE. Can you also test with powerpc64 BE to avoid surprises?

Aug 31 2023, 3:31 AM

Aug 28 2023

jhibbits committed rG570688f0a5c2: spibus: Make ofw_spibus probe just a little more favored (authored by jhibbits).
spibus: Make ofw_spibus probe just a little more favored
Aug 28 2023, 11:33 PM

Aug 26 2023

jhibbits committed rGdb5505172906: dtsec: Support multicast receive. (authored by jhibbits).
dtsec: Support multicast receive.
Aug 26 2023, 2:33 PM

Aug 25 2023

jhibbits committed rGb820820ece09: mac_ipacl: Use IfAPI (authored by jhibbits).
mac_ipacl: Use IfAPI
Aug 25 2023, 4:53 PM
jhibbits committed rG2a3716432d20: IfAPI: Retire if_etherbpfmtap() and if_bpfmtap() (authored by jhibbits).
IfAPI: Retire if_etherbpfmtap() and if_bpfmtap()
Aug 25 2023, 4:53 PM

Aug 17 2023

jhibbits resigned from D41425: irdma(4): upgrade to 1.2.17-k.

I'm not familiar enough to comment at all. My only role was mechanically converting to IfAPI.

Aug 17 2023, 3:58 PM

Aug 11 2023

jhibbits accepted D41426: ofed: fix roce gid insertion for vlan interfaces.

Big "Oops", sorry.

Aug 11 2023, 1:19 PM

Aug 2 2023

jhibbits committed rG0c783a37d5d5: mii: Add the Broadcom BCM54616S ID to the list (authored by jhibbits).
mii: Add the Broadcom BCM54616S ID to the list
Aug 2 2023, 2:48 PM

Jul 21 2023

jhibbits requested review of D41146: IfAPI: Retire if_etherbpfmtap() and if_bpfmtap().
Jul 21 2023, 6:18 PM

Jun 24 2023

jhibbits accepted D40589: share/mk/bsd.cpu.mk: drop -mno-powerpc64.
Jun 24 2023, 8:00 PM