jhibbits (Justin Hibbits)
User

Projects

User Details

User Since
May 16 2014, 7:29 PM (213 w, 3 d)

Recent Activity

Fri, Jun 15

jhibbits created D15835: Set the console sc if it's not already set..
Fri, Jun 15, 9:17 PM
jhibbits updated the diff for D15818: Add a delayed VT attachment for ofwfb.

Reduce the diff, by sharing the same VT driver between the early attach and delayed attach. This required moving some config setting into the probe routine, but that should be fine.

Fri, Jun 15, 9:11 PM
jhibbits added inline comments to D15818: Add a delayed VT attachment for ofwfb.
Fri, Jun 15, 7:15 PM
jhibbits committed rS335226: Check for a 'pci' prefix rather than a full match in get_addr_props.
Check for a 'pci' prefix rather than a full match in get_addr_props
Fri, Jun 15, 6:55 PM
jhibbits closed D15817: Check for a 'pci' prefix rather than a full match in get_addr_props.
Fri, Jun 15, 6:55 PM
jhibbits updated the diff for D15817: Check for a 'pci' prefix rather than a full match in get_addr_props.

I should probably caffeinate before making such trivial changes.

Fri, Jun 15, 6:28 PM
jhibbits updated the diff for D15817: Check for a 'pci' prefix rather than a full match in get_addr_props.

Change to nwhitehorn's preference. Either is fine with me.

Fri, Jun 15, 2:15 PM
jhibbits created D15818: Add a delayed VT attachment for ofwfb.
Fri, Jun 15, 3:57 AM
jhibbits created D15817: Check for a 'pci' prefix rather than a full match in get_addr_props.
Fri, Jun 15, 3:45 AM
jhibbits committed rS335187: ofw_reg_to_paddr(): Fix minor typo in KASSERT message.
ofw_reg_to_paddr(): Fix minor typo in KASSERT message
Fri, Jun 15, 3:28 AM

Thu, Jun 14

jhibbits committed rS335160: Split the PowerISA 3.0 HPT implementation from historic.
Split the PowerISA 3.0 HPT implementation from historic
Thu, Jun 14, 5:24 PM
jhibbits committed rS335146: Fix CTR formatting for moea64_native bootstrap.
Fix CTR formatting for moea64_native bootstrap
Thu, Jun 14, 4:01 PM

Tue, Jun 12

jhibbits added inline comments to D15705: ofw: Load initrd file.
Tue, Jun 12, 6:53 PM
jhibbits accepted D15763: powerpc64: Avoid type promotion.
Tue, Jun 12, 6:45 PM

Mon, Jun 11

jhibbits added a comment to D15763: powerpc64: Avoid type promotion.

This can be simplified to just "if (count < (int)sizeof(cell_t))"

Mon, Jun 11, 9:10 PM

Sun, Jun 10

jhibbits retitled D15696: Use int instead of char to take the result of getopt() in ZFS utilities. from Use int instead of char to take the result of getopt() in zstreamdump. to Use int instead of char to take the result of getopt() in ZFS utilities..
Sun, Jun 10, 5:28 PM

Fri, Jun 8

jhibbits updated the diff for D15685: Sprinkle new compiler USES around ports to build on gcc archs.

Bump PORTREVISION on print/qpdf and games/qqwing. They're dependencies for
packages that need c++11, and themselves, on their own, don't really need c++11,
but their dependent ports won't link otherwise.

Fri, Jun 8, 7:39 PM
jhibbits added a comment to D15696: Use int instead of char to take the result of getopt() in ZFS utilities..
In D15696#331834, @avg wrote:

LGTM.
Please consider opening an issue at https://www.illumos.org/projects/illumos-gate/issues even though illumos does not support PowerPC.

Fri, Jun 8, 3:44 PM
jhibbits updated the diff for D15696: Use int instead of char to take the result of getopt() in ZFS utilities..

Expand to all ZFS uses found.

Fri, Jun 8, 3:42 PM

Thu, Jun 7

jhibbits accepted D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Thu, Jun 7, 8:48 PM · PowerPC
jhibbits accepted D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Thu, Jun 7, 8:43 PM · PowerPC
jhibbits created D15696: Use int instead of char to take the result of getopt() in ZFS utilities..
Thu, Jun 7, 6:17 PM
jhibbits added a comment to D15243: Powerpc64: Enable Hardware Transactional Memory.

The code looks fine to me. Can you include a test for it? You showed me the torture test, so that'd be good to include in tools/tools. With a test, I'll approve it.

Thu, Jun 7, 4:22 PM
jhibbits added a comment to D15685: Sprinkle new compiler USES around ports to build on gcc archs.
In D15685#331736, @brd wrote:

Some of these need PORTREVISION bumps IIRC..

Thu, Jun 7, 4:19 PM
jhibbits created D15690: Make eclipse build for powerpc64.
Thu, Jun 7, 2:53 PM
jhibbits updated the diff for D15685: Sprinkle new compiler USES around ports to build on gcc archs.

Drop mail/evolution. It failed the jenkins build for unrelated reasons.

Thu, Jun 7, 2:24 PM
jhibbits accepted D15625: md: use prestaged mfs_root.
Thu, Jun 7, 1:32 PM
jhibbits committed rS334773: Build nvme modules for powerpc, and install man pages.
Build nvme modules for powerpc, and install man pages
Thu, Jun 7, 11:25 AM
jhibbits committed rS334755: Build nvmecontrol on powerpc64.
Build nvmecontrol on powerpc64
Thu, Jun 7, 4:08 AM
jhibbits committed rS334754: Print Maximum Data Transfer Size as a long rather than int.
Print Maximum Data Transfer Size as a long rather than int
Thu, Jun 7, 4:03 AM
jhibbits closed D15653: Print Maximum Data Transfer Size as a long rather than int.
Thu, Jun 7, 4:03 AM
jhibbits committed rS334745: Add partition scheme for mpc85xx devices.
Add partition scheme for mpc85xx devices
Thu, Jun 7, 12:24 AM
jhibbits closed D15664: Add partition scheme for mpc85xx devices.
Thu, Jun 7, 12:24 AM

Wed, Jun 6

jhibbits accepted D15680: Have ofw_fdt_getprop() return the actual size of the value on success.
Wed, Jun 6, 11:52 PM
jhibbits created D15685: Sprinkle new compiler USES around ports to build on gcc archs.
Wed, Jun 6, 11:19 PM
jhibbits added inline comments to D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Wed, Jun 6, 8:11 PM · PowerPC
jhibbits added inline comments to D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Wed, Jun 6, 6:47 PM · PowerPC
jhibbits committed rS334716: Revert r334708.
Revert r334708
Wed, Jun 6, 3:12 PM
jhibbits added inline comments to D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Wed, Jun 6, 2:44 PM · PowerPC
jhibbits committed rS334708: Add a memory barrier after taking a reference on the vnode holdcnt in _vhold.
Add a memory barrier after taking a reference on the vnode holdcnt in _vhold
Wed, Jun 6, 12:57 PM

Tue, Jun 5

jhibbits requested changes to D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.
Tue, Jun 5, 9:16 PM · PowerPC
jhibbits added a comment to D15667: Changed excise_initrd_region to support both 32- and 64-bit values for linux,initrd-start and linux,initrd-end.

After further investigation, linux,initrd-start/end are always 32-bit values

Tue, Jun 5, 2:02 PM · PowerPC

Mon, Jun 4

jhibbits updated the diff for D15664: Add partition scheme for mpc85xx devices.

Eliminate an extraneous parenthesis pair, add the mpc85xx check to create a
512MB boot partition.

Mon, Jun 4, 3:56 PM
jhibbits created D15664: Add partition scheme for mpc85xx devices.
Mon, Jun 4, 3:51 PM
jhibbits committed rS334618: Align UMA data to 128 byte cacheline size.
Align UMA data to 128 byte cacheline size
Mon, Jun 4, 3:44 PM
jhibbits committed rS334615: Set kernelname in bootconfig to the kernel file.
Set kernelname in bootconfig to the kernel file
Mon, Jun 4, 2:42 PM
jhibbits closed D15660: Set kernelname in bootconfig to the kernel file.
Mon, Jun 4, 2:42 PM
jhibbits created D15660: Set kernelname in bootconfig to the kernel file.
Mon, Jun 4, 3:47 AM
jhibbits created D15659: Use acquire and release semantics in refcount.
Mon, Jun 4, 3:36 AM

Sun, Jun 3

jhibbits committed rS334550: Revert r326083, it doesn't behave as expected..
Revert r326083, it doesn't behave as expected.
Sun, Jun 3, 3:53 AM
jhibbits created D15653: Print Maximum Data Transfer Size as a long rather than int.
Sun, Jun 3, 3:01 AM

Sat, Jun 2

jhibbits added a comment to D15118: memcpy optimization for powerpc64.

Overall I like the optimization here. I think memmove()/memcpy() are used often for relatively large block copies, so I really like the savings it offers. Just a few comments to address.

Sat, Jun 2, 9:05 PM · PowerPC
jhibbits committed rS334538: Included VSX registers in powerpc core dumps.
Included VSX registers in powerpc core dumps
Sat, Jun 2, 8:29 PM
jhibbits closed D15512: Included VSX registers in powerpc core dumps.
Sat, Jun 2, 8:29 PM · PowerPC
jhibbits committed rS334535: Added ptrace support for reading/writing powerpc VSX registers.
Added ptrace support for reading/writing powerpc VSX registers
Sat, Jun 2, 7:17 PM
jhibbits closed D15458: Added ptrace support for reading/writing powerpc VSX registers.
Sat, Jun 2, 7:17 PM · PowerPC

Fri, Jun 1

jhibbits committed rS334498: Increase powerpc64 KVA from ~7.25GB to 32GB.
Increase powerpc64 KVA from ~7.25GB to 32GB
Fri, Jun 1, 9:37 PM
jhibbits committed rS334488: Unbreak 32-bit binaries on powerpc64.
Unbreak 32-bit binaries on powerpc64
Fri, Jun 1, 4:31 PM

Thu, May 31

jhibbits accepted D15512: Included VSX registers in powerpc core dumps.
Thu, May 31, 4:48 AM · PowerPC
jhibbits accepted D15458: Added ptrace support for reading/writing powerpc VSX registers.
Thu, May 31, 4:47 AM · PowerPC
jhibbits accepted D15610: powerpc64: Avoid overwriting initrd area.

Looks good

Thu, May 31, 4:46 AM
jhibbits committed rS334417: Remove a debug printf from opal_pci driver.
Remove a debug printf from opal_pci driver
Thu, May 31, 4:11 AM

Wed, May 30

jhibbits committed rS334407: Only conform to PCIe spec of 1 device per bus on !x86.
Only conform to PCIe spec of 1 device per bus on !x86
Wed, May 30, 10:39 PM
jhibbits committed rS334370: Protect dtrace_getpcstack() from a NULL stack pointer in a trap frame.
Protect dtrace_getpcstack() from a NULL stack pointer in a trap frame
Wed, May 30, 3:48 AM
jhibbits committed rS334367: Make opal_pci driver work with POWER9.
Make opal_pci driver work with POWER9
Wed, May 30, 3:01 AM
jhibbits closed D15566: Make opal_pci driver work with POWER9.
Wed, May 30, 3:01 AM
jhibbits committed rS334366: Cache the phandle of the PCI node in opal_pci_attach.
Cache the phandle of the PCI node in opal_pci_attach
Wed, May 30, 2:47 AM
jhibbits committed rS334365: Restrict PCIe maxslots to 0, instead of PCI_SLOTMAX.
Restrict PCIe maxslots to 0, instead of PCI_SLOTMAX
Wed, May 30, 2:42 AM
jhibbits closed D15461: Restrict PCIe maxslots to 0, instead of PCI_SLOTMAX.
Wed, May 30, 2:42 AM
jhibbits accepted D15611: Remove mlx5(4) from LINT kernel config for 32-bit PPC.
Wed, May 30, 2:23 AM

Tue, May 29

jhibbits added inline comments to D15566: Make opal_pci driver work with POWER9.
Tue, May 29, 7:09 PM

Mon, May 28

jhibbits committed rS334266: Make ALT_BREAK_TO_DEBUGGER work with OPAL console.
Make ALT_BREAK_TO_DEBUGGER work with OPAL console
Mon, May 28, 2:00 AM
jhibbits committed rS334264: Print the full-width pointer values in hex..
Print the full-width pointer values in hex.
Mon, May 28, 12:19 AM

Sun, May 27

jhibbits committed rS334260: Match style of the other prototypes, and don't name the argument..
Match style of the other prototypes, and don't name the argument.
Sun, May 27, 8:36 PM
jhibbits committed rS334259: Stop idle threads on power9 in the idle task until an interrupt..
Stop idle threads on power9 in the idle task until an interrupt.
Sun, May 27, 8:24 PM

Sat, May 26

jhibbits committed rS334235: On POWER9 clear the HID0_RADIX before enabling the page tables.
On POWER9 clear the HID0_RADIX before enabling the page tables
Sat, May 26, 4:33 AM
jhibbits committed rS334234: Fix a typo missed in r334232.
Fix a typo missed in r334232
Sat, May 26, 4:24 AM
jhibbits committed rS334232: Correct a typo for opal temperature sensor type constant.
Correct a typo for opal temperature sensor type constant
Sat, May 26, 2:45 AM
jhibbits added inline comments to D15512: Included VSX registers in powerpc core dumps.
Sat, May 26, 1:57 AM · PowerPC
jhibbits committed rS334230: Only crop the VPN on POWER4 and derivatives for TLBIE operations.
Only crop the VPN on POWER4 and derivatives for TLBIE operations
Sat, May 26, 12:42 AM
jhibbits closed D15581: Only crop the VPN on POWER4 and derivatives for TLBIE operations.
Sat, May 26, 12:42 AM
jhibbits added a comment to D15581: Only crop the VPN on POWER4 and derivatives for TLBIE operations.

On POWER9, I think the lock is unnecessary (the ISA spec doesn't mention it).

Sat, May 26, 12:39 AM
jhibbits added a comment to D15461: Restrict PCIe maxslots to 0, instead of PCI_SLOTMAX.

Ping? With this and two other reviews, I can now boot FreeBSD on POWER9 to multiuser, so want to get these in soon.

Sat, May 26, 12:32 AM
jhibbits created D15581: Only crop the VPN on POWER4 and derivatives for TLBIE operations.
Sat, May 26, 12:28 AM

Fri, May 25

jhibbits added inline comments to D15566: Make opal_pci driver work with POWER9.
Fri, May 25, 1:48 PM
jhibbits updated the diff for D15566: Make opal_pci driver work with POWER9.

No need to comment out the OPAL_PCI_MAP_PE_MMIO_WINDOW. It likely was already
mapped as such by Opal.

Fri, May 25, 4:27 AM
jhibbits added inline comments to D15566: Make opal_pci driver work with POWER9.
Fri, May 25, 4:21 AM
jhibbits created D15566: Make opal_pci driver work with POWER9.
Fri, May 25, 3:13 AM

Thu, May 24

jhibbits added a comment to D15220: strcmp optimization for powerpc64.

Hi. Could someone review my patch please?
Basically, this code loads and compares the chars by byte until their addresses are aligned.
After, we load and compare the chars by double word until a \0 or a difference in the chars is found.
Finally, we compute the differences between the chars.

Thu, May 24, 5:08 PM · PowerPC

Tue, May 22

jhibbits committed rS334015: Add an IPMI attachment for PowerNV systems.
Add an IPMI attachment for PowerNV systems
Tue, May 22, 3:57 AM
jhibbits committed rS334014: Add a comment explaining the need of a global temporary variable.
Add a comment explaining the need of a global temporary variable
Tue, May 22, 3:24 AM
jhibbits committed rS334013: Welcome Leandro Lupori (luporl@) to the ranks of src committers.
Welcome Leandro Lupori (luporl@) to the ranks of src committers
Tue, May 22, 3:22 AM
jhibbits committed rS334012: Welcome Breno Leitao (leitao@) to the ranks of src committers..
Welcome Breno Leitao (leitao@) to the ranks of src committers.
Tue, May 22, 3:16 AM
jhibbits committed rS334011: Basic OPAL sensor support for POWER9 platforms.
Basic OPAL sensor support for POWER9 platforms
Tue, May 22, 2:43 AM
jhibbits closed D15362: Basic OPAL sensor support for POWER9 platforms.
Tue, May 22, 2:43 AM

Mon, May 21

jhibbits added inline comments to D15362: Basic OPAL sensor support for POWER9 platforms.
Mon, May 21, 2:42 PM

Sun, May 20

jhibbits updated the diff for D15362: Basic OPAL sensor support for POWER9 platforms.

Add a small delay, and a timeout, if a sensor needs extra time
(OPAL_ASYNC_COMPLETION/OPAL_BUSY).

Sun, May 20, 4:24 AM
jhibbits abandoned D15331: Enable XIVE XICS emulation mode for POWER9 interrupt controller.

Abandoned in favor of D15492

Sun, May 20, 4:01 AM
jhibbits committed rS333912: Add support for the XIVE XICS emulation mode for POWER9 systems.
Add support for the XIVE XICS emulation mode for POWER9 systems
Sun, May 20, 3:23 AM
jhibbits closed D15492: Add support for the XIVE XICS emulation mode for POWER9 systems.
Sun, May 20, 3:23 AM