Page MenuHomeFreeBSD

jhibbits (Justin Hibbits)
User

Projects

User Details

User Since
May 16 2014, 7:29 PM (290 w, 3 d)

Recent Activity

Yesterday

jhibbits accepted D20640: Enable use of ofwcons for early debug.
Sun, Dec 8, 9:07 PM · PowerPC
jhibbits accepted D21555: [PPC64] Initial libkvm minidump implementation.
Sun, Dec 8, 4:50 AM · PowerPC
jhibbits accepted D22649: [PPC64] Enable opal console use as a GDB DBGPORT.
Sun, Dec 8, 4:47 AM · PowerPC
jhibbits committed rS355521: powerpc: Use builtins for fls/flsl.
powerpc: Use builtins for fls/flsl
Sun, Dec 8, 4:37 AM
jhibbits closed D22340: powerpc: Use builtins for fls/flsl.
Sun, Dec 8, 4:37 AM
jhibbits committed rS355519: powerpc64/pmap: micro-optimize some PVO-PTE logic.
powerpc64/pmap: micro-optimize some PVO-PTE logic
Sun, Dec 8, 4:17 AM
jhibbits closed D22341: powerpc64/pmap: micro-optimize some PVO-PTE logic.
Sun, Dec 8, 4:17 AM

Sat, Dec 7

jhibbits committed rS355481: powerpc/pmap: NUMA-ize vm_page_array on powerpc.
powerpc/pmap: NUMA-ize vm_page_array on powerpc
Sat, Dec 7, 3:34 AM
jhibbits closed D21449: powerpc/pmap: NUMA-ize vm_page_array on powerpc.
Sat, Dec 7, 3:34 AM

Thu, Dec 5

jhibbits added inline comments to D22549: [PowerPC] enable atomic.c in compiler_rt and makes clang do not emit a call to an external __atomic_is_lock_free.
Thu, Dec 5, 6:00 PM · PowerPC

Wed, Dec 4

jhibbits added a comment to D22649: [PPC64] Enable opal console use as a GDB DBGPORT.

Yes, at least use the existing environment variable that others already use. That keeps it more uniform. uart_cpu_getdev() looks a bit clunky in its implementation, I'd love it if we could eventually make it support the OPAL console without needing even more cases.

Wed, Dec 4, 3:25 PM · PowerPC
jhibbits committed rS355380: powerpc/booke: Fix some formatting errors in debug printfs.
powerpc/booke: Fix some formatting errors in debug printfs
Wed, Dec 4, 3:51 AM
jhibbits committed rS355378: powerpc/booke: Fix 32-bit Book-E SMP AP bringup.
powerpc/booke: Fix 32-bit Book-E SMP AP bringup
Wed, Dec 4, 3:42 AM

Tue, Dec 3

jhibbits added a comment to D22649: [PPC64] Enable opal console use as a GDB DBGPORT.

Overall looks fine.

Tue, Dec 3, 9:45 PM · PowerPC

Mon, Dec 2

jhibbits committed rS355289: revert r354714 "Boot arm64 kernel using booti command from U-boot.".
revert r354714 "Boot arm64 kernel using booti command from U-boot."
Mon, Dec 2, 3:07 PM

Sun, Dec 1

jhibbits added a comment to D15818: Add a delayed VT attachment for ofwfb.

@tuexen this needs revisited to clean up a bit. As @nwhitehorn mentioned, it looks a little strange in how it attaches, so I need to rethink it. Right now the patch exists to help those who have a Talos or Blackbird and want to boot from serial, but output to the onboard VGA/HDMI.

Sun, Dec 1, 9:35 PM
jhibbits committed rS355275: powerpc: Add 'show frame <addr>' to show an arbitrary trap frame.
powerpc: Add 'show frame <addr>' to show an arbitrary trap frame
Sun, Dec 1, 9:29 PM
jhibbits updated the diff for D21449: powerpc/pmap: NUMA-ize vm_page_array on powerpc.

Address comments. Update diff.

Sun, Dec 1, 4:04 AM
jhibbits added inline comments to D21449: powerpc/pmap: NUMA-ize vm_page_array on powerpc.
Sun, Dec 1, 3:33 AM
jhibbits added inline comments to D22549: [PowerPC] enable atomic.c in compiler_rt and makes clang do not emit a call to an external __atomic_is_lock_free.
Sun, Dec 1, 3:29 AM · PowerPC

Thu, Nov 28

jhibbits accepted D22171: [PPC] Remove extra \0 char inserted on vty by QEMU.
Thu, Nov 28, 11:17 PM

Tue, Nov 26

jhibbits added inline comments to D22549: [PowerPC] enable atomic.c in compiler_rt and makes clang do not emit a call to an external __atomic_is_lock_free.
Tue, Nov 26, 1:27 AM · PowerPC

Mon, Nov 25

jhibbits added inline comments to D22549: [PowerPC] enable atomic.c in compiler_rt and makes clang do not emit a call to an external __atomic_is_lock_free.
Mon, Nov 25, 6:38 PM · PowerPC

Sun, Nov 24

jhibbits closed D22520: rtld/powerpc: Fix _rtld_bind_start for powerpcspe.
Sun, Nov 24, 4:35 AM
jhibbits committed rS355045: rtld/powerpc: Fix _rtld_bind_start for powerpcspe.
rtld/powerpc: Fix _rtld_bind_start for powerpcspe
Sun, Nov 24, 4:35 AM
jhibbits added a comment to D22520: rtld/powerpc: Fix _rtld_bind_start for powerpcspe.

I just confirmed it still works on powerpc, nothing broke.

Sun, Nov 24, 1:08 AM
jhibbits added a comment to D22526: [PowerPC] Fix floating point environment manipulation.

You found the bugs with the kyua tests, did you retest post-changes?

Sun, Nov 24, 1:00 AM · PowerPC

Sat, Nov 23

jhibbits added inline comments to D22520: rtld/powerpc: Fix _rtld_bind_start for powerpcspe.
Sat, Nov 23, 7:19 PM
jhibbits updated the diff for D22520: rtld/powerpc: Fix _rtld_bind_start for powerpcspe.

Fix stack space comment.

Sat, Nov 23, 7:18 PM
jhibbits committed rS355033: Let bdragon run free. He knows the drill..
Let bdragon run free. He knows the drill.
Sat, Nov 23, 5:25 PM
jhibbits created D22520: rtld/powerpc: Fix _rtld_bind_start for powerpcspe.
Sat, Nov 23, 5:22 PM

Fri, Nov 22

jhibbits committed rS354990: powerpc/ptrace: Give ptrace(2) access to SPE registers when available.
powerpc/ptrace: Give ptrace(2) access to SPE registers when available
Fri, Nov 22, 4:35 AM

Thu, Nov 21

jhibbits added a comment to D22425: libclang_rt: enable on powerpc*.

My understanding is you need both mentor approval and src approval. Consider it src approved by me.

Thu, Nov 21, 4:32 PM

Wed, Nov 20

jhibbits accepted D15368: strcpy optimization for PowerPC64.
Wed, Nov 20, 5:43 PM · PowerPC
jhibbits added a comment to D21449: powerpc/pmap: NUMA-ize vm_page_array on powerpc.

Please take a look at D21491, which moves the page array into KVA on amd64. It looks like you're doing that already, but I don't see what's preventing the vm_page address range from being allocated from the kernel map's vmem arena(s).

Wed, Nov 20, 5:16 PM
jhibbits added a comment to D20640: Enable use of ofwcons for early debug.

I like the concept overall. A couple nits. Also, can you document this somewhere, maybe in of_real.c?

Wed, Nov 20, 5:10 PM · PowerPC

Tue, Nov 19

jhibbits accepted D22425: libclang_rt: enable on powerpc*.
Tue, Nov 19, 1:28 PM
jhibbits added inline comments to D22425: libclang_rt: enable on powerpc*.
Tue, Nov 19, 2:35 AM
jhibbits committed rS354842: ELF toolchain: Add PowerPC VMX and VSX note decode to readelf.
ELF toolchain: Add PowerPC VMX and VSX note decode to readelf
Tue, Nov 19, 2:11 AM
jhibbits closed D22404: ELF toolchain: Add PowerPC VMX and VSX note decode to readelf.
Tue, Nov 19, 2:11 AM
jhibbits committed rS354839: powerpc/pmap: Remove an unused error from moea64_pvo_enter().
powerpc/pmap: Remove an unused error from moea64_pvo_enter()
Tue, Nov 19, 2:00 AM
jhibbits committed rS354838: powerpc/booke pmap: Use the right 'tlbilx' form to invalidate TIDs.
powerpc/booke pmap: Use the right 'tlbilx' form to invalidate TIDs
Tue, Nov 19, 1:28 AM

Mon, Nov 18

jhibbits closed D22427: bsnmp: Fix operator precedence in error check in table_check_response.
Mon, Nov 18, 11:24 PM
jhibbits committed rS354834: bsnmp: Fix operator precedence in error check in table_check_response.
bsnmp: Fix operator precedence in error check in table_check_response
Mon, Nov 18, 11:23 PM
jhibbits accepted D22403: [PowerPC] ELFv2 libdtrace support (userland side).
Mon, Nov 18, 3:53 PM · DTrace, PowerPC

Sun, Nov 17

jhibbits committed rS354797: powerpc: Re-add -Wno-redundant-decls to DPAA build flags.
powerpc: Re-add -Wno-redundant-decls to DPAA build flags
Sun, Nov 17, 8:49 PM
jhibbits created D22427: bsnmp: Fix operator precedence in error check in table_check_response.
Sun, Nov 17, 5:00 AM
jhibbits added inline comments to D22403: [PowerPC] ELFv2 libdtrace support (userland side).
Sun, Nov 17, 4:52 AM · DTrace, PowerPC
jhibbits committed rS354783: powerpc: Return SIGILL if DSCR does not exist in m{f,t}spr emulation.
powerpc: Return SIGILL if DSCR does not exist in m{f,t}spr emulation
Sun, Nov 17, 1:01 AM

Sat, Nov 16

jhibbits accepted D22421: [PowerPC] Fix *context on ELFv2.
Sat, Nov 16, 8:17 PM · PowerPC
jhibbits committed rS354778: gcore: Don't add VSX notes on powerpcspe.
gcore: Don't add VSX notes on powerpcspe
Sat, Nov 16, 6:24 PM
jhibbits committed rS354776: powerpcspe: Don't leak kernel registers in SPE dumps.
powerpcspe: Don't leak kernel registers in SPE dumps
Sat, Nov 16, 4:36 PM
jhibbits committed rS354775: powerpcspe: Mark asm statement in spe_save_reg_high as clobbering memory.
powerpcspe: Mark asm statement in spe_save_reg_high as clobbering memory
Sat, Nov 16, 4:27 PM
jhibbits created D22404: ELF toolchain: Add PowerPC VMX and VSX note decode to readelf.
Sat, Nov 16, 5:02 AM

Fri, Nov 15

jhibbits added inline comments to D22255: Boot arm64 kernel using booti command from U-boot. .
Fri, Nov 15, 3:14 PM · arm64
jhibbits committed rS354723: atomic: Add atomic_cmpset_masked to powerpc and use it.
atomic: Add atomic_cmpset_masked to powerpc and use it
Fri, Nov 15, 4:33 AM
jhibbits closed D22359: atomic: Add atomic_cmpset_masked to powerpc and use it.
Fri, Nov 15, 4:33 AM

Thu, Nov 14

jhibbits committed rS354714: Boot arm64 kernel using booti command from U-boot..
Boot arm64 kernel using booti command from U-boot.
Thu, Nov 14, 9:59 PM
jhibbits closed D22255: Boot arm64 kernel using booti command from U-boot. .
Thu, Nov 14, 9:59 PM · arm64
jhibbits accepted D22317: [PowerPC64] Fix broken kernel modules due to LLD 9+ TOC optimization.

Thanks for testing the alternative.

Thu, Nov 14, 2:49 PM
jhibbits created D22359: atomic: Add atomic_cmpset_masked to powerpc and use it.
Thu, Nov 14, 4:35 AM

Wed, Nov 13

jhibbits added inline comments to D22317: [PowerPC64] Fix broken kernel modules due to LLD 9+ TOC optimization.
Wed, Nov 13, 9:13 PM
jhibbits accepted D22349: [PowerPC] Kernel fixes for ppc32 lld.
Wed, Nov 13, 6:35 PM · PowerPC
jhibbits committed rS354671: powerpc64: Don't guard ISA 3.0 partition table setup with hw_direct_map.
powerpc64: Don't guard ISA 3.0 partition table setup with hw_direct_map
Wed, Nov 13, 2:22 AM
jhibbits committed rS354670: powerpc: Don't savectx() twice in IPI_STOP handler.
powerpc: Don't savectx() twice in IPI_STOP handler
Wed, Nov 13, 2:16 AM
jhibbits created D22341: powerpc64/pmap: micro-optimize some PVO-PTE logic.
Wed, Nov 13, 2:02 AM
jhibbits created D22340: powerpc: Use builtins for fls/flsl.
Wed, Nov 13, 2:01 AM

Sun, Nov 10

jhibbits committed rS354601: Consolidate powerpcspe CFLAGS.
Consolidate powerpcspe CFLAGS
Sun, Nov 10, 10:08 PM
jhibbits committed rS354600: powerpcspe: use -mspe instead of -mspe=yes to enable SPE.
powerpcspe: use -mspe instead of -mspe=yes to enable SPE
Sun, Nov 10, 8:36 PM
jhibbits committed rS354584: powerpc64/powernv: Use OPAL call for non-POWER8 PCI TCE reset.
powerpc64/powernv: Use OPAL call for non-POWER8 PCI TCE reset
Sun, Nov 10, 4:24 AM

Nov 8 2019

jhibbits accepted D22271: Create /etc/os-release file..
Nov 8 2019, 7:47 PM
jhibbits added a comment to D20261: [PowerPC64] Use ld.bfd to build LIB32 and STAND - when using llvm.

That's the goal, yes. There are still bugs with powerpc, that we hope to iron out beforehand. However, if consensus says, we can punt on that for a little bit, but that would also delay a lot of other things I want to get in once we have lld (like ifuncs for pmap, etc).

Nov 8 2019, 7:30 PM · PowerPC
jhibbits added a reviewer for D22255: Boot arm64 kernel using booti command from U-boot. : andrew.
Nov 8 2019, 3:03 PM · arm64
jhibbits closed D22014: powerpc/mpc85xx: Add MSI support for Freescale PowerPC SoCs.

Committed in r354525.

Nov 8 2019, 3:01 PM
jhibbits accepted D22014: powerpc/mpc85xx: Add MSI support for Freescale PowerPC SoCs.
Nov 8 2019, 3:01 PM
jhibbits committed rS354527: powerpc/booke: Only handle kernel page faults in KVA range.
powerpc/booke: Only handle kernel page faults in KVA range
Nov 8 2019, 4:26 AM
jhibbits committed rS354526: powerpc/booke: Make the TLB save area and mask match.
powerpc/booke: Make the TLB save area and mask match
Nov 8 2019, 3:45 AM
jhibbits committed rS354525: powerpc/mpc85xx: Add MSI support for Freescale PowerPC SoCs.
powerpc/mpc85xx: Add MSI support for Freescale PowerPC SoCs
Nov 8 2019, 3:36 AM

Nov 6 2019

jhibbits committed rS354369: powerpc/booke: Fix pmap_mapdev_attr() for multi-TLB1 entry mappings.
powerpc/booke: Fix pmap_mapdev_attr() for multi-TLB1 entry mappings
Nov 6 2019, 4:40 AM

Nov 4 2019

jhibbits committed rS354326: powerpc/pmap: Make use of tlb1_mapin_region in pmap_mapdev_attr().
powerpc/pmap: Make use of tlb1_mapin_region in pmap_mapdev_attr()
Nov 4 2019, 12:36 AM

Nov 3 2019

jhibbits accepted D22223: [PowerPC] Add opcode dumping format character to ddb.
Nov 3 2019, 12:32 AM · PowerPC
jhibbits accepted D22121: [PowerPC] fix cntlzw opcode disassembly.
Nov 3 2019, 12:30 AM · PowerPC

Nov 2 2019

jhibbits added inline comments to D22171: [PPC] Remove extra \0 char inserted on vty by QEMU.
Nov 2 2019, 9:00 PM
jhibbits accepted D22205: [PPC64] Enable phyp vty use as a GDB DBGPORT.
Nov 2 2019, 8:58 PM
jhibbits accepted D21999: [PowerPC] Book-E clang support.

Looks good.

Nov 2 2019, 8:47 PM · PowerPC
jhibbits committed rS354243: powerpc/mpc85xx: Set description for the MPC85xx RC bridge.
powerpc/mpc85xx: Set description for the MPC85xx RC bridge
Nov 2 2019, 2:25 AM

Nov 1 2019

jhibbits committed rS354235: powerpc/booke: Fix TLB1 entry accounting.
powerpc/booke: Fix TLB1 entry accounting
Nov 1 2019, 2:56 AM

Oct 31 2019

jhibbits accepted D22199: Avoid wrong sigtramp detection on ppc64.
Oct 31 2019, 7:05 PM

Oct 30 2019

jhibbits accepted D20799: Eliminate the last MI difference in AT_* definitions (for powerpc)..
Oct 30 2019, 9:51 PM
jhibbits accepted D22201: Fix GDB machdep code for PPC/PPC64.
Oct 30 2019, 9:46 PM
jhibbits accepted D22200: [PPC64] Fix trapstk overflow.
Oct 30 2019, 9:35 PM
jhibbits added a comment to D22199: Avoid wrong sigtramp detection on ppc64.

The trampoline for ppc64 is at 0x3ffffffffffe000 + offset, in the shared page.

Oct 30 2019, 9:12 PM
jhibbits committed rS354182: ARM64: Treat alignment faults as bus errors.
ARM64: Treat alignment faults as bus errors
Oct 30 2019, 3:30 PM
jhibbits closed D22133: ARM64: Treat alignment faults as bus errors.
Oct 30 2019, 3:30 PM

Oct 28 2019

jhibbits updated the diff for D22133: ARM64: Treat alignment faults as bus errors.

Rebase on top of D22170

Oct 28 2019, 5:28 PM
jhibbits accepted D22170: Use an array of handlers in the data and instruction aborts.
Oct 28 2019, 5:20 PM

Oct 24 2019

jhibbits updated the diff for D22133: ARM64: Treat alignment faults as bus errors.

Address @andrew's feedback. Use the right sub-mask to get the DFSC bits.

Oct 24 2019, 6:39 PM
jhibbits added inline comments to D22133: ARM64: Treat alignment faults as bus errors.
Oct 24 2019, 6:30 PM
jhibbits updated the diff for D22014: powerpc/mpc85xx: Add MSI support for Freescale PowerPC SoCs.

Address @bdragon's feedback.

Oct 24 2019, 4:33 PM
jhibbits added inline comments to D22014: powerpc/mpc85xx: Add MSI support for Freescale PowerPC SoCs.
Oct 24 2019, 4:32 PM