Page MenuHomeFreeBSD

arm64: Add a CPU reset hook instead of expecting PSCI
ClosedPublic

Authored by stevek on Mar 27 2024, 9:18 PM.
Tags
None
Referenced Files
F163986906: D44535.id136282.diff
Mon, Jul 27, 4:26 PM
Unknown Object (File)
Mon, Jul 27, 10:15 AM
Unknown Object (File)
Sun, Jul 26, 3:46 PM
Unknown Object (File)
Sun, Jul 26, 9:18 AM
Unknown Object (File)
Sat, Jul 25, 11:05 PM
Unknown Object (File)
Sat, Jul 25, 5:04 PM
Unknown Object (File)
Sat, Jul 25, 2:35 PM
Unknown Object (File)
Mon, Jul 20, 3:16 PM
Subscribers

Details

Summary

Some SoCs do not include a PSCI for power management and defer it to
something else instead. Add a CPU reset hook to account for this, and
use it in the psci driver.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?

Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?

Given that psci.c is "standard" on arm64 and it will not do anything until/unless it probes/attaches (and thus psci_softc is non-NULL), yes, I believe it could just default to psci_reset (maybe with a comment stating the reasons why?)

Updated based on review comments

This revision is now accepted and ready to land.Apr 4 2024, 11:10 AM