Page MenuHomeFreeBSD

arm64: Add a CPU reset hook instead of expecting PSCI
ClosedPublic

Authored by stevek on Mar 27 2024, 9:18 PM.
Tags
None
Referenced Files
F107393862: D44535.id136585.diff
Mon, Jan 13, 1:18 PM
Unknown Object (File)
Sun, Jan 12, 5:06 AM
Unknown Object (File)
Tue, Dec 24, 1:59 PM
Unknown Object (File)
Dec 9 2024, 6:59 AM
Unknown Object (File)
Nov 21 2024, 6:46 AM
Unknown Object (File)
Nov 15 2024, 8:28 PM
Unknown Object (File)
Nov 9 2024, 8:01 AM
Unknown Object (File)
Nov 6 2024, 5:24 AM
Subscribers

Details

Summary

Some SoCs do not include a PSCI for power management and defer it to
something else instead. Add a CPU reset hook to account for this, and
use it in the psci driver.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56810
Build 53698: arc lint + arc unit

Event Timeline

Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?

Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?

Given that psci.c is "standard" on arm64 and it will not do anything until/unless it probes/attaches (and thus psci_softc is non-NULL), yes, I believe it could just default to psci_reset (maybe with a comment stating the reasons why?)

Updated based on review comments

This revision is now accepted and ready to land.Apr 4 2024, 11:10 AM