Page MenuHomeFreeBSD

arm64: Add a CPU reset hook instead of expecting PSCI
ClosedPublic

Authored by stevek on Mar 27 2024, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 11:50 AM
Unknown Object (File)
Sun, Apr 28, 12:59 AM
Unknown Object (File)
Fri, Apr 26, 4:32 AM
Unknown Object (File)
Mon, Apr 22, 6:42 AM
Unknown Object (File)
Fri, Apr 19, 12:56 PM
Unknown Object (File)
Apr 5 2024, 10:19 PM
Unknown Object (File)
Apr 3 2024, 12:39 PM
Unknown Object (File)
Apr 3 2024, 12:39 PM
Subscribers

Details

Summary

Some SoCs do not include a PSCI for power management and defer it to
something else instead. Add a CPU reset hook to account for this, and
use it in the psci driver.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56823
Build 53711: arc lint + arc unit

Event Timeline

Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?

Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?

Given that psci.c is "standard" on arm64 and it will not do anything until/unless it probes/attaches (and thus psci_softc is non-NULL), yes, I believe it could just default to psci_reset (maybe with a comment stating the reasons why?)

Updated based on review comments

This revision is now accepted and ready to land.Apr 4 2024, 11:10 AM