User Details
- User Since
- Jun 13 2015, 3:41 PM (596 w, 1 d)
Oct 16 2026
True, the original code would be a race potentially if there was any deregister that would happen.
The main point for old_get_unlocked() was more of a peek at the value to see if something is there without needing to take the lock.
For example, at work we had a case where code was setting the value in the slot only when it needed it (which was a pointer to a structure which itself contains a sxlock.) The code would check the slot to see if there was actually something assigned and only use it when set. The code also only ever sets the value once, therefore if it's non-NULL, then that value should be stable for that object. Also, where it was used, the object must be valid through the whole code path, so there was no risk of the thing it was pointing to going away. However, the overhead of taking the lock (also given the type of lock that OSD uses) was causing unnecessary complications.
Jun 21 2026
Jun 19 2026
Minor things in the python found by pep8, but the rest looks good.
May 18 2026
May 3 2026
May 1 2026
Updated the big and little lists, since some MACHINE_ARCH settings have been removed since the original review.
Apr 30 2026
Apr 16 2026
Dec 9 2025
Looks reasonable. Just one minor nit.
Dec 1 2025
Nov 14 2025
Oct 30 2025
Looks reasonable.
Jul 21 2025
Makes sense to me.
Jun 4 2025
Jun 3 2025
May 15 2025
Feb 11 2025
Feb 10 2025
Jan 15 2025
Oct 29 2024
Updated to use ${M_ListToSkip}
Oct 15 2024
I was okay with not having the mask have an effect on the suid/sgid because there's already the mount option for nosuid (which disables suid and sgid both), so there's not really a need for the mask to alter it.
Oct 11 2024
Oct 10 2024
Oct 9 2024
Oct 8 2024
Adjusted little endian list
Oct 4 2024
Sep 19 2024
Sep 18 2024
Sep 10 2024
Sep 6 2024
Aug 23 2024
Aug 2 2024
Jun 26 2024
May 22 2024
May 15 2024
Use atomic to read OSD slot data
May 8 2024
May 7 2024
Using atomics for fetching/modifying the decode function pointer
Replaced by review D45072, will address the review comments from this review in the newer one.
Updated based on review comments
May 3 2024
May 1 2024
Apr 30 2024
Apr 26 2024
Apr 24 2024
Updated according to review comments
Added parenthesis based on comments.
Changed from _nolock to _unlocked in naming and updated commit log message.
Apr 16 2024
Apr 15 2024
Apr 12 2024
Apr 10 2024
Apr 9 2024
Do you want me to just switch things to use __unused instead of the macros to conditionally add it?