Page MenuHomeFreeBSD
Differential D39636

config.mk: Add MK_VIMAGE knob
ClosedPublic
Actions

Authored by stevek on Apr 18 2023, 3:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 2:32 AM
Unknown Object (File)
Fri, Apr 19, 1:01 PM
Unknown Object (File)
Tue, Apr 9, 8:38 PM
Unknown Object (File)
Dec 23 2023, 1:55 AM
Unknown Object (File)
Nov 8 2023, 6:08 AM
Unknown Object (File)
Oct 7 2023, 4:56 AM
Unknown Object (File)
Jun 19 2023, 8:28 PM
Unknown Object (File)
Jun 16 2023, 3:52 AM
View All 12 Files
Subscribers
bdrewery
brooks
emaste

Details

Reviewers
imp
Commits
rG22ca6db50f4e: config.mk: Add MK_VIMAGE knob
Summary

Default to VIMAGE as yes.
Add VIMAGE to __DEFAULT_DEPENDENT_OPTIONS (to define VIMAGE_SUPPORT)

Only output VIMAGE to opt_global.h when VIMAGE support is wanted.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

stevek created this revision.Apr 18 2023, 3:28 AM
Herald added subscribers: emaste, bdrewery. · View Herald TranscriptApr 18 2023, 3:28 AM
stevek requested review of this revision.Apr 18 2023, 3:28 AM
Harbormaster completed remote builds in B50983: Diff 120530.Apr 18 2023, 3:28 AM
stevek edited the summary of this revision. (Show Details)Apr 18 2023, 3:28 AM
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Apr 9, 5:08 PM
Closed by commit rG22ca6db50f4e: config.mk: Add MK_VIMAGE knob (authored by stevek). · Explain Why
This revision was automatically updated to reflect the committed changes.
stevek added a commit: rG22ca6db50f4e: config.mk: Add MK_VIMAGE knob.
brooks added a subscriber: brooks.Mon, Apr 22, 8:26 PM

What is the value of MK_VIMAGE_SUPPORT over MK_VIMAGE? We now have an unused MK_VIMAGE. What will it control?

This commit is missing an addition of tools/build/options/WITHOUT_VIMAGE and WITHOUT_VIMAGE_SUPPORT and breaks GitHub CI because makeman spots the missing files.

imp added inline comments.Mon, Apr 22, 8:53 PM
sys/conf/kern.opts.mk
187

This can't possibly work. There's no opt_vimage.h, so this just throws errors.

brooks added a reverting change: rG68cbb072fd1c: Revert "config.mk: Add MK_VIMAGE knob".Thu, Apr 25, 9:44 PM
stevek added a comment.Fri, Apr 26, 3:01 PM
In D39636#1023799, @brooks wrote:

What is the value of MK_VIMAGE_SUPPORT over MK_VIMAGE? We now have an unused MK_VIMAGE. What will it control?

This commit is missing an addition of tools/build/options/WITHOUT_VIMAGE and WITHOUT_VIMAGE_SUPPORT and breaks GitHub CI because makeman spots the missing files.

Good point. I think just having a MK_VIMAGE would be sufficient to control the VIMAGE define in the opt_global.h

Revision Contents
Changeset List

PathSize
share/
mk/
2 lines
sys/
conf/
2 lines
4 lines

Diff 136784

View Options

share/mk/src.opts.mk

Loading...
View Options

sys/conf/config.mk

Loading...
View Options

sys/conf/kern.opts.mk

Loading...