Differential D39636

config.mk: Add MK_VIMAGE knob
ClosedPublic
Actions

Authored by stevek on Apr 18 2023, 3:28 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 1, 10:04 PM

	Unknown Object (File)
	Sun, Dec 1, 10:03 PM

	Unknown Object (File)
	Sun, Dec 1, 7:04 PM

	Unknown Object (File)
	Sun, Dec 1, 6:59 PM

	Unknown Object (File)
	Nov 12 2024, 11:57 AM

	Unknown Object (File)
	Oct 24 2024, 7:54 AM

	Unknown Object (File)
	Oct 4 2024, 10:07 AM

	Unknown Object (File)
	Oct 4 2024, 5:20 AM

View All 40 Files

Subscribers

Details

Reviewers

Commits

rG22ca6db50f4e: config.mk: Add MK_VIMAGE knob

Summary

Default to VIMAGE as yes.
Add VIMAGE to __DEFAULT_DEPENDENT_OPTIONS (to define VIMAGE_SUPPORT)

Only output VIMAGE to opt_global.h when VIMAGE support is wanted.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 50983
Build 47874: arc lint + arc unit

Event Timeline

stevek created this revision.Apr 18 2023, 3:28 AM

Herald added subscribers: emaste, bdrewery. · View Herald TranscriptApr 18 2023, 3:28 AM

stevek requested review of this revision.Apr 18 2023, 3:28 AM

Harbormaster completed remote builds in B50983: Diff 120530.Apr 18 2023, 3:28 AM

stevek edited the summary of this revision. (Show Details)Apr 18 2023, 3:28 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2024, 5:08 PM

Closed by commit rG22ca6db50f4e: config.mk: Add MK_VIMAGE knob (authored by stevek). · Explain Why

This revision was automatically updated to reflect the committed changes.

stevek added a commit: rG22ca6db50f4e: config.mk: Add MK_VIMAGE knob.

What is the value of MK_VIMAGE_SUPPORT over MK_VIMAGE? We now have an unused MK_VIMAGE. What will it control?

This commit is missing an addition of tools/build/options/WITHOUT_VIMAGE and WITHOUT_VIMAGE_SUPPORT and breaks GitHub CI because makeman spots the missing files.

imp added inline comments.Apr 22 2024, 8:53 PM

sys/conf/kern.opts.mk
155	This can't possibly work. There's no opt_vimage.h, so this just throws errors.

brooks added a reverting change: rG68cbb072fd1c: Revert "config.mk: Add MK_VIMAGE knob".Apr 25 2024, 9:44 PM

In D39636#1023799, @brooks wrote:

What is the value of MK_VIMAGE_SUPPORT over MK_VIMAGE? We now have an unused MK_VIMAGE. What will it control?

This commit is missing an addition of tools/build/options/WITHOUT_VIMAGE and WITHOUT_VIMAGE_SUPPORT and breaks GitHub CI because makeman spots the missing files.

Good point. I think just having a MK_VIMAGE would be sufficient to control the VIMAGE define in the opt_global.h

Revision Contents
Changeset List

Path

Size

share/

mk/

2 lines

sys/

conf/

2 lines

4 lines

Diff 120530

share/mk/src.opts.mk

Loading...

sys/conf/config.mk

Loading...

sys/conf/kern.opts.mk

Loading...