Page MenuHomeFreeBSD

bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (297 w, 2 d)

Recent Activity

Fri, Jan 17

bdrewery committed rS356827: META_MODE: Allow 'make all install' to work with filemon..
META_MODE: Allow 'make all install' to work with filemon.
Fri, Jan 17, 2:30 PM

Mon, Jan 13

bdrewery committed rS356699: Regen src.conf.5.
Regen src.conf.5
Mon, Jan 13, 7:34 PM
bdrewery committed rS356698: MFC r355379,r355381:.
MFC r355379,r355381:
Mon, Jan 13, 7:33 PM
bdrewery committed rS356697: MFC r355379,r355381:.
MFC r355379,r355381:
Mon, Jan 13, 7:30 PM
bdrewery committed rS356696: MFC r355588:.
MFC r355588:
Mon, Jan 13, 7:23 PM

Thu, Jan 9

bdrewery committed rS356533: MFC r352261,r352262,r352265:.
MFC r352261,r352262,r352265:
Thu, Jan 9, 1:17 AM
bdrewery committed rS356532: MFC r352261,r352262,r352265:.
MFC r352261,r352262,r352265:
Thu, Jan 9, 1:14 AM

Sat, Jan 4

bdrewery committed rS356352: lio_listio_empty_nowait_thread sometimes does *not* hang..
lio_listio_empty_nowait_thread sometimes does *not* hang.
Sat, Jan 4, 7:00 PM

Sun, Dec 22

bdrewery committed rP520603: Update to 8.1p1.
Update to 8.1p1
Sun, Dec 22, 2:55 AM

Dec 13 2019

bdrewery added a reviewer for D21800: fix emulation name passed to linker when cross compiling: sjg.
Dec 13 2019, 5:43 PM · PowerPC
bdrewery updated subscribers of D21800: fix emulation name passed to linker when cross compiling.

FYI This fixes *DIRDEPS* not *META*. The file is misnamed.
I suggest adding @sjg to the review

Dec 13 2019, 5:43 PM · PowerPC

Dec 11 2019

bdrewery abandoned D22756: Have builtins use ck* malloc functions..

Thanks for looking.

Dec 11 2019, 7:46 PM

Dec 10 2019

bdrewery accepted D22495: Update dirdeps.mk and gendirdeps.mk.

I may disappear so I'll approve for now; my questions aren't blockers but I think there is an unrelated change that should be fixed first.

Dec 10 2019, 10:34 PM
bdrewery accepted D22494: Update depends.

I spot checked a few and they looked fine.

Dec 10 2019, 10:33 PM
bdrewery accepted D22469: Add Makefile.depend.options.

I don't like that we have auto generated and manual maintained outside of Makefile as it will get stale fast.

Dec 10 2019, 10:31 PM
bdrewery added inline comments to D22495: Update dirdeps.mk and gendirdeps.mk.
Dec 10 2019, 10:27 PM
bdrewery created D22756: Have builtins use ck* malloc functions..
Dec 10 2019, 10:01 PM
bdrewery committed rS355588: Fix WITHOUT_CLANG build..
Fix WITHOUT_CLANG build.
Dec 10 2019, 6:51 PM
bdrewery committed rP519773: - Update to 3.3.3.
- Update to 3.3.3
Dec 10 2019, 6:02 PM
bdrewery committed rP519770: - Update to 3.3.0-229-gce2011f23.
- Update to 3.3.0-229-gce2011f23
Dec 10 2019, 5:58 PM

Dec 4 2019

bdrewery committed rS355381: Use full path to sysctl(8) since /sbin is not in PATH..
Use full path to sysctl(8) since /sbin is not in PATH.
Dec 4 2019, 4:02 AM
bdrewery committed rS355379: Run make in parallel..
Run make in parallel.
Dec 4 2019, 3:45 AM

Nov 21 2019

bdrewery added a comment to D22469: Add Makefile.depend.options.

I think the comment from targets/ should be added in too.

# This file is not autogenerated - take care!
Nov 21 2019, 9:23 PM
bdrewery accepted D22486: devel/mdb: Use clang 7 as compiler on 11.x and 12.x to fix build..
Nov 21 2019, 7:31 PM

Nov 19 2019

bdrewery committed rS354859: WITH_SYSTEM_LINKER: Fix rebuilding lld every time..
WITH_SYSTEM_LINKER: Fix rebuilding lld every time.
Nov 19 2019, 4:40 PM

Nov 15 2019

bdrewery added a comment to D17002: Fix compilation with upstream clang builtin headers.

What case does this fix exactly?

Nov 15 2019, 7:30 PM

Nov 7 2019

bdrewery committed rP517011: generate-symbols: Need @dir entries if PREFIX!=LOCALBASE..
generate-symbols: Need @dir entries if PREFIX!=LOCALBASE.
Nov 7 2019, 8:49 PM

Oct 29 2019

bdrewery added inline comments to D22174: WIP: check for REINPLACE_CMD usage that doesn't do anything.
Oct 29 2019, 10:56 PM
bdrewery added inline comments to D22174: WIP: check for REINPLACE_CMD usage that doesn't do anything.
Oct 29 2019, 10:55 PM

Oct 25 2019

bdrewery added a comment to D22144: Introduce bsd.sysdir.mk to consolidate looking for the kernel..
In D22144#484006, @jhb wrote:

I guess the extra directories don't hurt. I'm less certain about the implications of the missing checks for an empty KERNBUILDDIR.

Oct 25 2019, 5:25 PM

Oct 21 2019

bdrewery committed rP515139: Drop maintainership.
Drop maintainership
Oct 21 2019, 9:57 PM
bdrewery committed rP515138: Pass maintainership to author.
Pass maintainership to author
Oct 21 2019, 9:55 PM
bdrewery committed rP515134: Drop and deprecate.
Drop and deprecate
Oct 21 2019, 9:50 PM
bdrewery committed rP515132: This port really belongs to re@.
This port really belongs to re@
Oct 21 2019, 9:46 PM

Oct 19 2019

bdrewery added inline comments to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Oct 19 2019, 10:03 PM
bdrewery committed rS353771: Fix spelling of DPSRCS..
Fix spelling of DPSRCS.
Oct 19 2019, 9:44 PM
bdrewery added inline comments to D22069: Add support for hypervisor check on x86.
Oct 19 2019, 12:28 AM

Oct 18 2019

bdrewery accepted D22069: Add support for hypervisor check on x86.

I only reviewed defs.mk. Looks fine.

Oct 18 2019, 10:41 PM
bdrewery added a comment to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
In D21654#482501, @ngie wrote:
Oct 18 2019, 9:47 PM

Oct 17 2019

bdrewery committed rP514688: LICENSE check: Respect DISABLE_LICENSES..
LICENSE check: Respect DISABLE_LICENSES.
Oct 17 2019, 9:12 PM
bdrewery added a comment to D22059: Allow bsd.compat.mk to be reliably included outside Makefile.inc1..
In D22059#482035, @imp wrote:

The question is, do we need them to be TARGET_* in this makefile.inc1 usage?
I kinda think it does. Checking into *that* detail...

Oct 17 2019, 7:57 PM
bdrewery accepted D22057: always add standard kernel configuration include path.
Oct 17 2019, 7:55 PM
bdrewery added a comment to D22057: always add standard kernel configuration include path.

I'd be inclined to explicitly spell it as -I ${KRNLCONFDIR} instead of -I., and then we later rename KRNLCONFDIR to make it more clear. We can't quickly change the cd, at least, because:

Oct 17 2019, 12:42 AM

Oct 16 2019

bdrewery added a comment to D22057: always add standard kernel configuration include path.
In D22057#481900, @avg wrote:

I don't have answers to your questions, sorry.
And I did not intend for the review to center around KRNLCONFDIR vs KERNCONFDIR.
I just want to be able to do what this change allows me to do.
That is, I want to be able to include files from both directories.

Oct 16 2019, 10:22 PM
bdrewery added a comment to D22057: always add standard kernel configuration include path.
In D22057#481764, @avg wrote:

Just a note, KRNLCONFDIR is the standard location (derived from TARGET) and KERNCONFDIR is the actual, possibly overridden, location.

Sigh. Why. These appear to be the same at quick glance.

Oct 16 2019, 7:40 PM
bdrewery added a comment to D22057: always add standard kernel configuration include path.
In D22057#481764, @avg wrote:

Just a note, KRNLCONFDIR is the standard location (derived from TARGET) and KERNCONFDIR is the actual, possibly overridden, location.

Oct 16 2019, 7:34 PM
bdrewery accepted D22059: Allow bsd.compat.mk to be reliably included outside Makefile.inc1..

Oops sorry for missing this before. TARGET_ are only useful in Makefile.inc1.

Oct 16 2019, 7:26 PM

Oct 15 2019

bdrewery added a comment to D22023: Optionally build/link programs against the compat ABI..

We have use for this at work as well for FreeBSD amd64/32 ABI compat testing since we have our own ABI. Though we just use FreeBSD 10 dist files for the purpose this feature is still nice.

Oct 15 2019, 6:10 PM
bdrewery accepted D22023: Optionally build/link programs against the compat ABI..

This is great!

Oct 15 2019, 6:07 PM

Oct 10 2019

bdrewery committed rP514247: - Add compat for NOCCACHE -> NO_CCACHE.
- Add compat for NOCCACHE -> NO_CCACHE
Oct 10 2019, 8:10 PM
bdrewery committed rP514246: - Add a CCACHE_BIN variable for simplified use where needed..
- Add a CCACHE_BIN variable for simplified use where needed.
Oct 10 2019, 8:06 PM
bdrewery committed rP514245: - Respect NOCCACHE.
- Respect NOCCACHE
Oct 10 2019, 8:04 PM

Oct 9 2019

bdrewery added a comment to D21775: (WIP) Rewrite makesyscalls.sh in Lua.

I don't know lua yet so cannot review most of this. But I'm OK with expanding lua usage. One "regression" I see is that move from a heredoc to a ton of write_line lines. Can lua not continue a string on the next line? Or maybe we should have some kind of template file instead.

Oct 9 2019, 4:28 PM

Sep 25 2019

bdrewery added inline comments to D21775: (WIP) Rewrite makesyscalls.sh in Lua.
Sep 25 2019, 10:27 PM
bdrewery added a comment to D21775: (WIP) Rewrite makesyscalls.sh in Lua.

I'm planning to make the syscall files generate *during the build*. It will need to happen quite early. Is lua already an early bootstrap tool?

Sep 25 2019, 10:21 PM

Sep 19 2019

bdrewery accepted D21717: Make it clear that a port's dependencies should not be minimal..

I like it. But it still comes down to a bikeshed/opinion. Anyway it's a good guidance.

Sep 19 2019, 4:46 PM

Sep 16 2019

bdrewery added a comment to D21468: Overlay support for the ports tree.
Sep 16 2019, 7:47 PM
bdrewery added a comment to D21468: Overlay support for the ports tree.
~/svn/ports/databases/mysql56-client # grep MASTERDIR Makefile
MASTERDIR=      ${.CURDIR}/../mysql56-server
EXTRA_PATCHES+= ${MASTERDIR}/files/patch-PR225888.diff
.include "${MASTERDIR}/Makefile"
Sep 16 2019, 7:39 PM
bdrewery added inline comments to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 16 2019, 7:17 PM

Sep 12 2019

bdrewery committed rS352265: mtree -O: Fix not descending on hash collisions.
mtree -O: Fix not descending on hash collisions
Sep 12 2019, 8:46 PM
bdrewery committed rS352262: mtree -c: Fix username logic when getlogin(3) fails..
mtree -c: Fix username logic when getlogin(3) fails.
Sep 12 2019, 6:52 PM
bdrewery committed rS352261: mtree: Fix -f -f not considering type changes..
mtree: Fix -f -f not considering type changes.
Sep 12 2019, 6:45 PM
bdrewery closed D21623: mtree: Fix -f -f not considering type changes..
Sep 12 2019, 6:45 PM
bdrewery created D21623: mtree: Fix -f -f not considering type changes..
Sep 12 2019, 6:42 PM

Sep 5 2019

bdrewery committed rS351895: MFC r349005:.
MFC r349005:
Sep 5 2019, 8:39 PM
bdrewery committed rS351894: MFC r349005:.
MFC r349005:
Sep 5 2019, 8:39 PM
bdrewery committed rS351893: MFC r347458:.
MFC r347458:
Sep 5 2019, 8:38 PM
bdrewery committed rS351892: MFC r347458,r348975,r348976:.
MFC r347458,r348975,r348976:
Sep 5 2019, 8:31 PM
bdrewery committed rS351891: MFC r339635,r350301,r350327,r351151:.
MFC r339635,r350301,r350327,r351151:
Sep 5 2019, 8:28 PM
bdrewery committed rS351890: MFC r339635,r350301,r350327,r351151:.
MFC r339635,r350301,r350327,r351151:
Sep 5 2019, 8:26 PM
bdrewery committed rS351876: MFC r348979:.
MFC r348979:
Sep 5 2019, 5:20 PM
bdrewery committed rS351875: MFC r348979:.
MFC r348979:
Sep 5 2019, 5:20 PM
bdrewery committed rS351873: MFC r346255:.
MFC r346255:
Sep 5 2019, 4:53 PM
bdrewery committed rS351872: MFC r346255:.
MFC r346255:
Sep 5 2019, 4:53 PM

Sep 4 2019

bdrewery committed rS351823: PROGS: Build common sources before recursed PROGS_TARGETS as well when building..
PROGS: Build common sources before recursed PROGS_TARGETS as well when building.
Sep 4 2019, 6:32 PM

Sep 3 2019

bdrewery accepted D21283: Use file destdir for stage_as sets.

If buildworld and installworld work then it seems fine.

Sep 3 2019, 3:29 AM

Aug 28 2019

bdrewery committed rP510098: - Update to 3.3.0-164-g122329edc.
- Update to 3.3.0-164-g122329edc
Aug 28 2019, 8:20 PM

Aug 16 2019

bdrewery committed rS351151: Rework r339635 to fix .depend.tables.h handling..
Rework r339635 to fix .depend.tables.h handling.
Aug 16 2019, 10:34 PM
bdrewery closed D21295: Rework r339635 to fix .depend.tables.h handling..
Aug 16 2019, 10:34 PM
bdrewery added a comment to D21295: Rework r339635 to fix .depend.tables.h handling..

Review findings

Aug 16 2019, 9:32 PM
bdrewery added a comment to D21069: libsysdecode: automate tables.h dependency generation.

My change is at D21295

Aug 16 2019, 8:00 PM
bdrewery created D21295: Rework r339635 to fix .depend.tables.h handling..
Aug 16 2019, 8:00 PM
bdrewery added a comment to D21069: libsysdecode: automate tables.h dependency generation.

Something like this is probably needed instead

~/git/freebsd2/lib/libsysdecode # git diff
diff --git lib/libsysdecode/Makefile lib/libsysdecode/Makefile
index 2be244a6da46..9edfe067063c 100644
--- lib/libsysdecode/Makefile
+++ lib/libsysdecode/Makefile
@@ -127,7 +127,8 @@ incdir=${SYSROOT:U${DESTDIR}}${INCLUDEDIR}
 tables.h: mktables ${incdir}/netinet/in.h ${incdir}/netinet/tcp.h \
     ${incdir}/netinet6/in6.h
        sh ${.CURDIR}/mktables ${incdir} ${.TARGET}.tmp && \
-           mv -f ${.TARGET}.tmp ${.TARGET}
+           mv -f ${.TARGET}.tmp ${.TARGET} && \
+           mv -f .depend.${.TARGET}.tmp .depend.${.TARGET}
Aug 16 2019, 7:47 PM
bdrewery added a comment to D21069: libsysdecode: automate tables.h dependency generation.

The hacks to using tables.h.tmp is probably what broke my work.

Aug 16 2019, 7:45 PM
D21069: libsysdecode: automate tables.h dependency generation now requires changes to proceed.

This already has .depend file support. Why is this needed?

Aug 16 2019, 7:43 PM
bdrewery added inline comments to D21069: libsysdecode: automate tables.h dependency generation.
Aug 16 2019, 7:43 PM

Aug 15 2019

bdrewery committed rP509046: - Update to 3.3.0-126-g12112ee57.
- Update to 3.3.0-126-g12112ee57
Aug 15 2019, 7:58 PM
bdrewery added a comment to D21060: Stop installing clang, clang++, and clang-cpp hardlinks in /usr/bin..

Which package provides clang? I don't have a /usr/local/bin/clang on my system.

Aug 15 2019, 6:22 PM

Aug 3 2019

bdrewery committed rP507975: - Update to 3.3.0-125-g0a50192f8.
- Update to 3.3.0-125-g0a50192f8
Aug 3 2019, 5:41 PM

Jul 31 2019

bdrewery added a comment to D21124: Make umtxq_check_susp() to correctly handle thread exit requests..

This doesn't seem to fix the SIGKILL issue.

~ # procstat -kk 19680
  PID    TID COMM                TDNAME              KSTACK
19680 101200 python2.7           -                   __mtx_lock_sleep+0x118 __mtx_lock_flags+0x102 _sleep+0x334 umtxq_busy+0xb7 do_sem_wait+0x150 __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
19680 101634 python2.7           -                   mi_switch+0x174 sleepq_switch+0x110 sleepq_catch_signals+0x417 sleepq_wait_sig+0xf _sleep+0x2d0 umtxq_sleep+0x153 do_sem_wait+0x41c __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
19680 101635 python2.7           -                   _mtx_lock_spin_cookie+0x231 __mtx_lock_spin_flags+0xf8 wakeup_one+0xf do_sem_wait+0x26f __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
~ # kill -9 19680
~ # procstat -kk 19680
  PID    TID COMM                TDNAME              KSTACK
19680 101200 python2.7           -                   __mtx_lock_flags+0xc1 do_sem_wait+0x218 __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
19680 101634 python2.7           -                   mi_switch+0x174 sleepq_switch+0x110 sleepq_catch_signals+0x417 sleepq_wait_sig+0xf _sleep+0x2d0 umtxq_sleep+0x153 do_sem_wait+0x41c __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
19680 101635 python2.7           -                   __mtx_lock_sleep+0x118 __mtx_lock_flags+0x102 do_sem_wait+0x148 __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
~ # procstat -i 19680|grep -v -- ---|grep KILL
19680 python2.7        KILL     P--
Jul 31 2019, 8:20 PM

Jul 30 2019

bdrewery committed rP507681: Grammar nit.
Grammar nit
Jul 30 2019, 9:09 PM
bdrewery added inline comments to rS350446: Handle refcount(9) wraparound..
Jul 30 2019, 6:53 PM
bdrewery added inline comments to rS350446: Handle refcount(9) wraparound..
Jul 30 2019, 6:33 PM
bdrewery added inline comments to rS350446: Handle refcount(9) wraparound..
Jul 30 2019, 6:18 PM

Jul 28 2019

bdrewery committed rP507530: NOCCACHE also disables setting CCACHE_WRAPPER_PATH which can break the build..
NOCCACHE also disables setting CCACHE_WRAPPER_PATH which can break the build.
Jul 28 2019, 8:28 PM

Jul 26 2019

bdrewery added a comment to D17906: rm(1): Formalize non-functional status of -P flag.

This is a massive POLA violation. What the hell. You took a flag that was intended to make <some effort> to overwrite data and made it SILENTLY DO NOTHING. That's insane.

Jul 26 2019, 7:23 AM

Jul 24 2019

bdrewery committed rP507274: - Update to 3.3.0-90-gd6f021339.
- Update to 3.3.0-90-gd6f021339
Jul 24 2019, 4:21 PM

Jul 19 2019

bdrewery committed rP506960: Update to 1.3.0..
Update to 1.3.0.
Jul 19 2019, 7:29 PM
bdrewery committed rP506959: - Update gssapi patch for 8.0.
- Update gssapi patch for 8.0
Jul 19 2019, 7:18 PM
bdrewery committed rS350119: Rework some multi-output target dependency handling..
Rework some multi-output target dependency handling.
Jul 19 2019, 12:15 AM