bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (206 w, 2 d)

Recent Activity

Thu, Apr 19

bdrewery requested changes to D15130: Switch installing share/examples to FILES.

You've got 2 distinct changes here, one is shares/examples and the other is adding a DIRS thing to bsd.files.mk. They should really be separate commits.

Thu, Apr 19, 9:29 PM

Tue, Apr 17

bdrewery added a comment to D15110: lld: add a __FreeBSD_version-style identifier to version.

Thanks, I'll get this added into my patch.

Tue, Apr 17, 6:46 PM

Mon, Apr 16

bdrewery abandoned D14921: lang/rust: Update to 1.25.

Committed in rP467538

Mon, Apr 16, 9:38 PM
bdrewery commandeered D14921: lang/rust: Update to 1.25.
Mon, Apr 16, 9:38 PM
bdrewery committed rP467539: MFH: r467538.
MFH: r467538
Mon, Apr 16, 9:37 PM
bdrewery committed rP467538: Update to 1.25.0..
Update to 1.25.0.
Mon, Apr 16, 9:35 PM

Thu, Apr 12

bdrewery added a comment to D15053: security/openssh-portable: Regenerate broken patch and fix ssh SSHFP support for non-canonical hostnames.

Also "reviewed" by me.

Thu, Apr 12, 8:48 PM
bdrewery accepted D15053: security/openssh-portable: Regenerate broken patch and fix ssh SSHFP support for non-canonical hostnames.

Thank you!
Approved by me but I think you'll need mentor approval still.

Thu, Apr 12, 8:48 PM
bdrewery committed rS332455: Use known SRCTOP if possible to determine SYSDIR..
Use known SRCTOP if possible to determine SYSDIR.
Thu, Apr 12, 8:48 PM
bdrewery requested changes to D15053: security/openssh-portable: Regenerate broken patch and fix ssh SSHFP support for non-canonical hostnames.

Also you need to bump PORTREVISION too

Thu, Apr 12, 8:34 PM
bdrewery added a comment to D15053: security/openssh-portable: Regenerate broken patch and fix ssh SSHFP support for non-canonical hostnames.

Looks good but could you add the header back in from the des commit please? It lets me know I took it from the base patches. Anything above the --- ssh.c.orig line is ignored.

Thu, Apr 12, 8:34 PM
bdrewery committed rS332453: Fix using wrong SYSDIR after r331683..
Fix using wrong SYSDIR after r331683.
Thu, Apr 12, 8:28 PM

Wed, Apr 11

bdrewery accepted D15039: Try and prevent people from adding github archive urls..
Wed, Apr 11, 8:09 PM
bdrewery accepted D15045: Update netdumpd to 20180411..
Wed, Apr 11, 7:32 PM
bdrewery added a comment to D15039: Try and prevent people from adding github archive urls..

But why?

Wed, Apr 11, 6:23 PM

Mon, Apr 9

bdrewery added a comment to D14787: Bring over some fixes from the other external GCC toolchain ports..

+1

Mon, Apr 9, 4:10 PM

Fri, Apr 6

bdrewery accepted D14925: Fix two more issues with r465416..
Fri, Apr 6, 6:54 PM

Thu, Apr 5

bdrewery committed rP466595: Make BROKEN lines more clear.
Make BROKEN lines more clear
Thu, Apr 5, 7:57 PM
bdrewery committed rP466577: Update to 7.7p1.
Update to 7.7p1
Thu, Apr 5, 6:21 PM

Wed, Apr 4

bdrewery accepted D14185: Don't change directory owner to root when building with -DNO_ROOT.

@bdrewery does this look okay?

Wed, Apr 4, 10:00 PM

Tue, Apr 3

bdrewery committed rP466385: libressl support was fixed in r452358.
libressl support was fixed in r452358
Tue, Apr 3, 11:14 PM
bdrewery committed rP466378: Update to 2018-04-03.
Update to 2018-04-03
Tue, Apr 3, 8:49 PM

Mon, Apr 2

bdrewery added inline comments to D4385: Prepare the ports tree for reproducible builds.
Mon, Apr 2, 8:29 PM
bdrewery added inline comments to D14921: lang/rust: Update to 1.25.
Mon, Apr 2, 5:36 PM
bdrewery added inline comments to D14921: lang/rust: Update to 1.25.
Mon, Apr 2, 5:33 PM
bdrewery requested changes to D14921: lang/rust: Update to 1.25.
Mon, Apr 2, 5:31 PM
bdrewery added a comment to D14921: lang/rust: Update to 1.25.

Looking

Mon, Apr 2, 4:59 PM

Sat, Mar 31

bdrewery added inline comments to D10018: Summary:.
Sat, Mar 31, 2:34 AM

Fri, Mar 30

bdrewery committed rP465999: MFH: r465998.
MFH: r465998
Fri, Mar 30, 8:20 PM
bdrewery committed rP465998: - Update to 3.2.6.
- Update to 3.2.6
Fri, Mar 30, 8:18 PM
bdrewery accepted D14143: Remove MK_AUTO_OBJ from env passed to PORTS_MODULES.
Fri, Mar 30, 7:52 PM

Thu, Mar 29

bdrewery committed rP465910: Update to 2018-03-28.
Update to 2018-03-28
Thu, Mar 29, 6:45 PM

Wed, Mar 28

bdrewery accepted D14888: ports-mgmt/poudriere-devel: Fix plist issue with completion options.
Wed, Mar 28, 6:36 PM
bdrewery committed rP465832: - Update to 3.2.5-363-g9c2944629.
- Update to 3.2.5-363-g9c2944629
Wed, Mar 28, 5:57 PM
bdrewery accepted D14882: Remove CONFIGURE_ENV to set C++ include path..
Wed, Mar 28, 5:25 PM
bdrewery committed rS331682: Avoid upwards directory walk in kernel build for finding known SYSDIR..
Avoid upwards directory walk in kernel build for finding known SYSDIR.
Wed, Mar 28, 4:28 PM
bdrewery committed rS331683: Avoid looping if SYSDIR already known..
Avoid looping if SYSDIR already known.
Wed, Mar 28, 4:28 PM

Mar 23 2018

bdrewery added a comment to D12163: [RFC]: decrement needfree by the amount of evicted cache.

On head there seems to be very little backpressure on the ARC lately to the point of needing extreme swap support. On my 78GB ram system with ARC limited to 40GB, I can have the ARC pegged at 40GB but swap in the 50GB range for package builds in tmpfs. The ARC never seems to shrink at all. This commit was partially implicated in the thread on current: https://lists.freebsd.org/pipermail/freebsd-current/2018-March/068888.html. Could it be a problem?

Mar 23 2018, 11:18 PM
bdrewery accepted D14780: Don't hardcode the TOOLS_PREFIX for the startfiles directories..

I think this is fine but we'll need to keep some of the flags to handle the SYSTEM_COMPILER CC=/usr/bin/cc case until we can fix --sysroot fully.

Mar 23 2018, 10:19 PM
bdrewery added a comment to D14780: Don't hardcode the TOOLS_PREFIX for the startfiles directories..

Discussed on IRC, there's 3 cases for the compiler. External (for which you fixed the port to respect --sysroot properly). Interal (bootstrap) from contrib/gcc which you've modified here to respect --sysroot (Except headers which will just work from WORLDTMP). But there's a 3rd case of the installed /usr/bin/cc which is used for WITH_SYSTEM_COMPILER which won't work without the -isystem, etc, flags or a fixed --sysroot.

Mar 23 2018, 10:17 PM
bdrewery added inline comments to D14780: Don't hardcode the TOOLS_PREFIX for the startfiles directories..
Mar 23 2018, 9:29 PM

Mar 21 2018

bdrewery committed rP465189: Update rust-nightly to 2018-03-21..
Update rust-nightly to 2018-03-21.
Mar 21 2018, 4:21 PM
bdrewery committed rP465145: Fix CCACHE_BUILD support..
Fix CCACHE_BUILD support.
Mar 21 2018, 3:46 AM

Mar 20 2018

bdrewery committed rP465109: MFH: r459882.
MFH: r459882
Mar 20 2018, 9:09 PM

Mar 19 2018

bdrewery committed rP465036: MFH: r465035.
MFH: r465035
Mar 19 2018, 9:40 PM
bdrewery committed rP465035: Fix some recursive targets using the wrong FLAVOR..
Fix some recursive targets using the wrong FLAVOR.
Mar 19 2018, 9:39 PM

Mar 16 2018

bdrewery committed rP464743: No reason to try removing /usr as it is in the base mtree.
No reason to try removing /usr as it is in the base mtree
Mar 16 2018, 10:09 PM
bdrewery committed rP464730: Remove net/freebsd-tftp..
Remove net/freebsd-tftp.
Mar 16 2018, 8:50 PM
bdrewery committed rP464728: Remove sysutils/py-zfs..
Remove sysutils/py-zfs.
Mar 16 2018, 8:36 PM
bdrewery committed rP464727: Remove OVERWRITE_BASE compat - it was marked IGNORE in 2015.
Remove OVERWRITE_BASE compat - it was marked IGNORE in 2015
Mar 16 2018, 8:20 PM
bdrewery committed rP464726: Fix plist.
Fix plist
Mar 16 2018, 8:01 PM
bdrewery committed rP464725: Don't add 'yes' onto the end of errored std output lookups..
Don't add 'yes' onto the end of errored std output lookups.
Mar 16 2018, 7:31 PM
bdrewery committed rP464716: Revert libm functions..
Revert libm functions.
Mar 16 2018, 5:41 PM
bdrewery committed rP464713: Fix plist.
Fix plist
Mar 16 2018, 5:06 PM

Mar 15 2018

bdrewery committed rP464643: Fix orphaned libraries error for slave binding ports..
Fix orphaned libraries error for slave binding ports.
Mar 15 2018, 10:18 PM
bdrewery committed rP464642: Stop touching the filesystem during build..
Stop touching the filesystem during build.
Mar 15 2018, 9:50 PM
bdrewery committed rP464641: Fix plist.
Fix plist
Mar 15 2018, 9:36 PM
bdrewery committed rP464635: Correct comment.
Correct comment
Mar 15 2018, 9:15 PM
bdrewery committed rP464632: Fix plist and orphaned items.
Fix plist and orphaned items
Mar 15 2018, 8:59 PM
bdrewery committed rP464631: Add more random items.
Add more random items
Mar 15 2018, 8:53 PM
bdrewery committed rP464630: Support config.site cache.
Support config.site cache
Mar 15 2018, 8:37 PM
bdrewery committed rP464629: Support config.site cache.
Support config.site cache
Mar 15 2018, 8:26 PM
bdrewery committed rP464628: Fix WITH_CCACHE_BUILD support.
Fix WITH_CCACHE_BUILD support
Mar 15 2018, 8:01 PM
bdrewery committed rP464627: Fix installation of init_cov_core.pth to be in the package rather than the….
Fix installation of init_cov_core.pth to be in the package rather than the…
Mar 15 2018, 7:54 PM
bdrewery committed rP464625: Fix recursive STAGEDIR referencing..
Fix recursive STAGEDIR referencing.
Mar 15 2018, 7:31 PM
bdrewery committed rP464624: Fix build without TOOLBOX option.
Fix build without TOOLBOX option
Mar 15 2018, 7:19 PM
bdrewery committed rP464623: Fix plist.
Fix plist
Mar 15 2018, 6:55 PM
bdrewery committed rP464621: Add missing SHEBANG_FILES.
Add missing SHEBANG_FILES
Mar 15 2018, 6:27 PM
bdrewery committed rP464620: Add missing SHEBANG_FILES.
Add missing SHEBANG_FILES
Mar 15 2018, 6:23 PM
bdrewery committed rP464619: Fix plist.
Fix plist
Mar 15 2018, 6:13 PM
bdrewery committed rP464618: MFH: r464504.
MFH: r464504
Mar 15 2018, 5:54 PM
bdrewery committed rP464617: MFH: r459464.
MFH: r459464
Mar 15 2018, 5:53 PM
bdrewery committed rP464616: MFH: r459266.
MFH: r459266
Mar 15 2018, 5:53 PM
bdrewery committed rP464602: Add some more random functions in all releases..
Add some more random functions in all releases.
Mar 15 2018, 4:48 PM
bdrewery committed rP464551: Pass CONFIG_SITE down to configure.
Pass CONFIG_SITE down to configure
Mar 15 2018, 2:37 AM
bdrewery committed rP464550: Define CONFIG_SITE even without GNU_CONFIGURE as some ports still benefit from….
Define CONFIG_SITE even without GNU_CONFIGURE as some ports still benefit from…
Mar 15 2018, 2:37 AM

Mar 14 2018

bdrewery committed rP464540: PORTS_ENV: Reorder CC hash and std hash so CC's comes first..
PORTS_ENV: Reorder CC hash and std hash so CC's comes first.
Mar 14 2018, 11:21 PM
bdrewery committed rP464538: PORTS_ENV: Rename OUTPUT_* to CC_OUTPUT_* to be more clearly related to….
PORTS_ENV: Rename OUTPUT_* to CC_OUTPUT_* to be more clearly related to…
Mar 14 2018, 11:10 PM

Mar 13 2018

bdrewery committed rP464442: Don't define FLAVORS if EMACS_NO_DEPENDS is set..
Don't define FLAVORS if EMACS_NO_DEPENDS is set.
Mar 13 2018, 11:46 PM
bdrewery committed rP464435: Add PORTS_ENV_VARS caching support to USES=objc..
Add PORTS_ENV_VARS caching support to USES=objc.
Mar 13 2018, 9:43 PM
bdrewery committed rP464393: - Update to 3.2.5-303-g3a844af55.
- Update to 3.2.5-303-g3a844af55
Mar 13 2018, 5:23 PM

Mar 12 2018

bdrewery committed rP464274: MFH: r464273.
MFH: r464273
Mar 12 2018, 7:05 PM
bdrewery committed rP464273: FLAVORS: Reorder so the default is first..
FLAVORS: Reorder so the default is first.
Mar 12 2018, 7:05 PM
bdrewery added a comment to D14627: Fix --sysroot for cross-toolchain GCC packages.

One caveat is that the built GCC does look for headers in /usr/local/include
(under the sysroot) before /usr/include, but I think that is an existing
problem in the native GCC ports as well and whatever solution is used for
that would be applicable here.

And libs. See rS297435

Mar 12 2018, 6:44 PM
bdrewery added a comment to D14627: Fix --sysroot for cross-toolchain GCC packages.

One caveat is that the built GCC does look for headers in /usr/local/include
(under the sysroot) before /usr/include, but I think that is an existing
problem in the native GCC ports as well and whatever solution is used for
that would be applicable here.

Mar 12 2018, 6:43 PM
bdrewery committed rP464271: Fix build on systems without a proper C++11 toolchain..
Fix build on systems without a proper C++11 toolchain.
Mar 12 2018, 6:38 PM
bdrewery committed rP464270: MFH: r463997.
MFH: r463997
Mar 12 2018, 6:30 PM
bdrewery committed rP464269: MFH: r464267.
MFH: r464267
Mar 12 2018, 6:30 PM
bdrewery committed rP464267: FLAVORS: Fix several 'make *recursive' targets not passing along FLAVOR….
FLAVORS: Fix several 'make *recursive' targets not passing along FLAVOR…
Mar 12 2018, 6:19 PM
bdrewery committed rP464262: Use proper PY_FLAVOR.
Use proper PY_FLAVOR
Mar 12 2018, 5:03 PM

Mar 10 2018

bdrewery committed rS330725: Fix rebase mismerge in r330724..
Fix rebase mismerge in r330724.
Mar 10 2018, 2:14 AM
bdrewery committed rS330724: Don't skip reading depend for 'make obj' unless it is alone..
Don't skip reading depend for 'make obj' unless it is alone.
Mar 10 2018, 2:10 AM
bdrewery committed rS330723: Skip reading depend files with -V unless looking up a depend variable..
Skip reading depend files with -V unless looking up a depend variable.
Mar 10 2018, 2:10 AM
bdrewery committed rS330722: Reduce overhead for simple 'make -V' lookups by avoiding 'find sys/'..
Reduce overhead for simple 'make -V' lookups by avoiding 'find sys/'.
Mar 10 2018, 2:09 AM
bdrewery closed D14455: Avoid a sysctl for every file loaded..

Committed in rS330260

Mar 10 2018, 12:09 AM

Mar 9 2018

bdrewery committed rP464035: MFH: r463857.
MFH: r463857
Mar 9 2018, 10:21 PM
bdrewery committed rP464010: Fix WITH_CCACHE_BUILD when using Poudriere's ccache-memcached support..
Fix WITH_CCACHE_BUILD when using Poudriere's ccache-memcached support.
Mar 9 2018, 9:35 PM
bdrewery committed rP463998: - Update to 3.2.5-300-g71e9aeef4.
- Update to 3.2.5-300-g71e9aeef4
Mar 9 2018, 7:53 PM
bdrewery committed rP463997: Update to 3.2.5.
Update to 3.2.5
Mar 9 2018, 7:46 PM
bdrewery committed rP463994: Update to 2.4.16..
Update to 2.4.16.
Mar 9 2018, 7:32 PM