bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (175 w, 3 d)

Recent Activity

Fri, Sep 15

bdrewery committed rS323620: Fix the raise tests..
Fix the raise tests.
Fri, Sep 15, 7:49 PM
bdrewery accepted D12218: OBJS_SRCS_FILTER.
Fri, Sep 15, 3:11 PM
bdrewery accepted D11934: Ensure .CURDIR contains the absolute pathname without a trailing slash, otherwise a port may fail to build.
Fri, Sep 15, 3:10 PM
bdrewery accepted D12218: OBJS_SRCS_FILTER.

I'm curious what you need this for?

Fri, Sep 15, 2:52 AM

Tue, Sep 12

bdrewery committed rP449704: MFH: r446704.
MFH: r446704
Tue, Sep 12, 7:14 PM

Fri, Sep 8

bdrewery committed rS323323: Tweak comment for install -S usage since it does not impact the build..
Tweak comment for install -S usage since it does not impact the build.
Fri, Sep 8, 7:21 PM
bdrewery committed rP449458: Update to 0.5.9.1.
Update to 0.5.9.1
Fri, Sep 8, 5:55 PM

Wed, Sep 6

bdrewery accepted D12068: Add py3-* packages for toposort and pyPEG2..
Wed, Sep 6, 6:28 PM
bdrewery accepted D12239: Makefile.inc1: bump elf tool chain version check after PR 215350 fix.

We might want to keep the old comment too or someone might trim this away if GCC no longer has the problem, or they may try making the condition specific to GCC when it is also supporting <11 upgrades.

Wed, Sep 6, 1:16 AM

Fri, Sep 1

bdrewery accepted D12208: Remove redundant source, object files..
Fri, Sep 1, 6:14 PM
bdrewery committed rP449089: Update to 3.0-2513-gaf851838.
Update to 3.0-2513-gaf851838
Fri, Sep 1, 4:47 PM
bdrewery accepted D12197: Add textproc/py3-feedparser.
Fri, Sep 1, 4:27 PM

Mon, Aug 28

bdrewery committed rS322978: Allow vdrop() of a vnode not yet on the per-mount list after r306512..
Allow vdrop() of a vnode not yet on the per-mount list after r306512.
Mon, Aug 28, 7:30 PM
bdrewery closed D12126: Allow vdrop() of a vnode not yet on the per-mount list after r306512. by committing rS322978: Allow vdrop() of a vnode not yet on the per-mount list after r306512..
Mon, Aug 28, 7:30 PM

Sat, Aug 26

bdrewery added inline comments to D12126: Allow vdrop() of a vnode not yet on the per-mount list after r306512..
Sat, Aug 26, 4:22 PM

Fri, Aug 25

bdrewery created D12126: Allow vdrop() of a vnode not yet on the per-mount list after r306512..
Fri, Aug 25, 11:59 PM

Aug 16 2017

bdrewery accepted D12053: Add SI_SUB_TASKQ after SI_SUB_INTR and move taskqueue initialization there for EARLY_AP_STARTUP.
Aug 16 2017, 9:35 PM
bdrewery committed rS322585: Quote ${MAKE} when passing in env in case it contains spaces..
Quote ${MAKE} when passing in env in case it contains spaces.
Aug 16 2017, 5:54 PM
bdrewery accepted D12044: remove debug files in delete-old* for WITHOUT_DEBUG_FILES.
Aug 16 2017, 4:18 PM
bdrewery committed rS322565: Use -S for library installations except for -DNO_ROOT builds..
Use -S for library installations except for -DNO_ROOT builds.
Aug 16 2017, 5:02 AM

Aug 11 2017

bdrewery added a comment to D11986: One copy to make CPUARCH from ARCH..
In D11986#248646, @imp wrote:

My initial attempts were rS302670 and rS302671 but I reverted it in rS302690 with reasoning:

MACHINE_CPUARCH smells like MACHINE except for arm64/aarch64 which
has it backwards.

This reasoning is sadly wrong. MACHINE_CPUARCH has nothing to do with MACHINE. The former is a userland construct while the latter is a kernel construct. The names are only accidentally related.

Aug 11 2017, 8:00 PM
bdrewery added a comment to D11986: One copy to make CPUARCH from ARCH..

My initial attempts were rS302670 and rS302671 but I reverted it in rS302690 with reasoning:

MACHINE_CPUARCH smells like MACHINE except for arm64/aarch64 which
has it backwards.
Aug 11 2017, 7:54 PM
bdrewery requested changes to D11986: One copy to make CPUARCH from ARCH..
Aug 11 2017, 7:48 PM
bdrewery added inline comments to D11986: One copy to make CPUARCH from ARCH..
Aug 11 2017, 7:48 PM
bdrewery added a comment to D11986: One copy to make CPUARCH from ARCH..

My initial attempts were rS302670 and rS302671 but I reverted it in rS302690 with reasoning:

MACHINE_CPUARCH smells like MACHINE except for arm64/aarch64 which
has it backwards.
Aug 11 2017, 7:41 PM
bdrewery added a comment to D11986: One copy to make CPUARCH from ARCH..

I did something like this before and ran into a bug and reverted it. Hang on, looking it up.

Aug 11 2017, 7:41 PM
bdrewery committed rP447785: MFH: r447784.
MFH: r447784
Aug 11 2017, 6:34 PM
bdrewery committed rP447784: - Fix sudo sending a 2nd SIGINFO on ^T to processes, which is already.
- Fix sudo sending a 2nd SIGINFO on ^T to processes, which is already
Aug 11 2017, 6:33 PM

Aug 9 2017

bdrewery updated the summary of D11476: iflib - try m_defrag when m_collapse fails.
Aug 9 2017, 7:54 PM
bdrewery requested changes to D11934: Ensure .CURDIR contains the absolute pathname without a trailing slash, otherwise a port may fail to build.

This may cause problems for symlinked ${PORTSDIR} checkouts (I am merely guessing and haven't thought about it heavily).

Aug 9 2017, 5:52 PM

Aug 8 2017

bdrewery added inline comments to D11395: bsdgrep(1): Switch src.opts.mk .include to .sinclude for out-of-tree builds.
Aug 8 2017, 10:13 PM
bdrewery requested changes to D11395: bsdgrep(1): Switch src.opts.mk .include to .sinclude for out-of-tree builds.

I'm not fond of this because the base svn version of this file will never actually be built by ports. The port has to have a copy of this file elsewhere that will be used to build. So these modifications could be made to that instead of polluting this with logic that won't ever be used directly. So it easily bitrots or people use this file as a template and create usr.bin/newtool with these patterns that are not needed.

Aug 8 2017, 10:11 PM

Aug 7 2017

bdrewery added a comment to D11903: Convert NO_SHARED to MK_SHARED and make a first class bsd.opts.mk consumer.

MK_PROFILE feels similar to the NO_SHARED discussion to me. I'm not sure what I think either way overall here.

Aug 7 2017, 8:18 PM
bdrewery committed rP447499: Fix resurrected ports not being warned about if they have a new dest entry..
Fix resurrected ports not being warned about if they have a new dest entry.
Aug 7 2017, 5:32 PM

Aug 3 2017

bdrewery committed rP447232: Update to 3.0-2483-gb25e919d.
Update to 3.0-2483-gb25e919d
Aug 3 2017, 3:33 PM

Aug 1 2017

bdrewery committed rS321887: CCACHE_BUILD: Follow-up r321880: Fix some PATH issues with buildworld..
CCACHE_BUILD: Follow-up r321880: Fix some PATH issues with buildworld.
Aug 1 2017, 6:26 PM
bdrewery committed rS321882: NO_CLEAN: No need to run delete-old if the directories don't exist..
NO_CLEAN: No need to run delete-old if the directories don't exist.
Aug 1 2017, 4:41 PM
bdrewery committed rS321880: CCACHE_BUILD: Allow setting CCACHE_BUILD_TYPE=wrapper..
CCACHE_BUILD: Allow setting CCACHE_BUILD_TYPE=wrapper.
Aug 1 2017, 4:15 PM

Jul 31 2017

bdrewery committed rS321824: Allow changing the test PORT at compile-time..
Allow changing the test PORT at compile-time.
Jul 31 2017, 10:00 PM
bdrewery accepted D11795: Add devel/py3-verboselogs a dependency for py3-iocage..
Jul 31 2017, 4:46 PM
bdrewery committed rP446986: Allow portmgr overrides for py3- under some (uncodified) conditions:.
Allow portmgr overrides for py3- under some (uncodified) conditions:
Jul 31 2017, 4:32 PM

Jul 29 2017

bdrewery added a comment to D11776: Don't use libc++ when cross-building for gcc arches.

The same logic is in Makefile.libcompat and may need to be handled as well.

Jul 29 2017, 5:25 PM

Jul 28 2017

bdrewery committed rP446850: Exec less rm(1) for existing files..
Exec less rm(1) for existing files.
Jul 28 2017, 8:31 PM

Jul 27 2017

bdrewery committed rP446778: MFH: r446777.
MFH: r446777
Jul 27 2017, 8:44 PM
bdrewery committed rP446777: MEMCACHED+STATIC: Fix not having HAVE_LIBMEMCACHED defined..
MEMCACHED+STATIC: Fix not having HAVE_LIBMEMCACHED defined.
Jul 27 2017, 8:43 PM

Jul 25 2017

bdrewery committed rS321493: NO_CLEAN: Hide delete-old output..
NO_CLEAN: Hide delete-old output.
Jul 25 2017, 8:51 PM
bdrewery committed rS321492: Only build libzfs_core in 'make libraries' if needed..
Only build libzfs_core in 'make libraries' if needed.
Jul 25 2017, 8:43 PM
bdrewery committed rS321491: Remove unneeded dependency for libzfs..
Remove unneeded dependency for libzfs.
Jul 25 2017, 8:43 PM
bdrewery committed rS321485: Allow -DNO_SKIP_DEPEND to override the _SKIP_DEPEND logic..
Allow -DNO_SKIP_DEPEND to override the _SKIP_DEPEND logic.
Jul 25 2017, 4:46 PM
bdrewery committed rP446551: MFH: r446550.
MFH: r446550
Jul 25 2017, 12:38 AM
bdrewery committed rP446550: Properly add needed libsasl2 libs after r440469, fixing build with….
Properly add needed libsasl2 libs after r440469, fixing build with…
Jul 25 2017, 12:38 AM
bdrewery committed rS321445: cleandir: Fix ESTALE errors from parallel removals..
cleandir: Fix ESTALE errors from parallel removals.
Jul 25 2017, 12:13 AM

Jul 24 2017

bdrewery committed rS321443: NO_CLEAN: Utilize delete-old to remove old orphaned libraries/headers in….
NO_CLEAN: Utilize delete-old to remove old orphaned libraries/headers in…
Jul 24 2017, 11:32 PM
bdrewery committed rS321442: The .depend.obj cleanup hacks are only needed with -DNO_CLEAN..
The .depend.obj cleanup hacks are only needed with -DNO_CLEAN.
Jul 24 2017, 11:32 PM
bdrewery committed rS321441: Allow disabling dependency tracking if DEPEND_CFLAGS is empty..
Allow disabling dependency tracking if DEPEND_CFLAGS is empty.
Jul 24 2017, 11:32 PM
bdrewery committed rS321440: Slightly simplify logic for which depend file is expected..
Slightly simplify logic for which depend file is expected.
Jul 24 2017, 11:32 PM
bdrewery committed rS321439: Move llvm Options.inc hack from r321433 for NO_CLEAN to lib/clang/libllvm..
Move llvm Options.inc hack from r321433 for NO_CLEAN to lib/clang/libllvm.
Jul 24 2017, 11:32 PM
bdrewery committed rS321434: Add some .ORDER for distrib-dirs, distribute, distribution and distributeworld..
Add some .ORDER for distrib-dirs, distribute, distribution and distributeworld.
Jul 24 2017, 6:55 PM
bdrewery committed rS321427: PROGS: Fix ESTALE errors on NFS while cleaning in directories with PROGS..
PROGS: Fix ESTALE errors on NFS while cleaning in directories with PROGS.
Jul 24 2017, 5:54 PM
bdrewery committed rS321426: cleanobj: Unhide removal of directory..
cleanobj: Unhide removal of directory.
Jul 24 2017, 5:53 PM
bdrewery committed rP446537: MFH: r445062 r446536.
MFH: r445062 r446536
Jul 24 2017, 5:01 PM
bdrewery committed rP446536: Fix ccache-memcached-static to actually build statically..
Fix ccache-memcached-static to actually build statically.
Jul 24 2017, 5:00 PM

Jul 21 2017

bdrewery committed rS321341: MFC r320273:.
MFC r320273:
Jul 21 2017, 5:58 PM
bdrewery committed rS321340: MFC r320273:.
MFC r320273:
Jul 21 2017, 5:58 PM
bdrewery committed rS321339: MFC r320292:.
MFC r320292:
Jul 21 2017, 5:57 PM
bdrewery committed rS321338: MFC r320883:.
MFC r320883:
Jul 21 2017, 5:56 PM
bdrewery committed rS321337: MFC r320806:.
MFC r320806:
Jul 21 2017, 5:56 PM
bdrewery committed rP446321: Update to 3.0-2457-g286a1577.
Update to 3.0-2457-g286a1577
Jul 21 2017, 5:12 PM
bdrewery committed rS321334: Respect INSTALL_AS_USER for FILES..
Respect INSTALL_AS_USER for FILES.
Jul 21 2017, 4:14 PM
bdrewery committed rS321333: Properly set userid for truncate_test..
Properly set userid for truncate_test.
Jul 21 2017, 4:14 PM

Jul 20 2017

bdrewery requested changes to D11677: New port: devel/py-cdg.
Jul 20 2017, 10:41 PM
bdrewery edited reviewers for D11677: New port: devel/py-cdg, added: Python; removed: portmgr.
Jul 20 2017, 10:41 PM

Jul 17 2017

bdrewery added a comment to D11507: Add LLVM's OpenMP 4.0.0 library to the base system.

This might fix the lib32 issue: http://people.freebsd.org/~bdrewery/patches/libcompat-target-arch-src-opts.diff

Jul 17 2017, 8:54 PM
bdrewery committed rP446107: Update to 3.0-2455-g5e3f50f8.
Update to 3.0-2455-g5e3f50f8
Jul 17 2017, 7:37 PM
bdrewery added a comment to D11628: Add SUBDIR_SORTED, a generic mechanism for ordering subdirectories and apply option to *bin/Makefile.

Summary has SUBDIR_ORDERED code has SUBDIR_SORTED

Jul 17 2017, 6:30 PM

Jul 13 2017

bdrewery committed rS320973: Fix kldload of if_ixl without PCI_IOV kernel option..
Fix kldload of if_ixl without PCI_IOV kernel option.
Jul 13 2017, 10:45 PM
bdrewery closed D11573: Fix kldload of if_ixl without PCI_IOV kernel option. by committing rS320973: Fix kldload of if_ixl without PCI_IOV kernel option..
Jul 13 2017, 10:45 PM

Jul 12 2017

bdrewery retitled D11573: Fix kldload of if_ixl without PCI_IOV kernel option. from Fix kldload of if_ixl without PCI_IOV kernel option. This also avoids compiling in pci_iov support into the kernel if_ixo if the PCI_IOV option is disabled. to Fix kldload of if_ixl without PCI_IOV kernel option..
Jul 12 2017, 10:04 PM
bdrewery created D11573: Fix kldload of if_ixl without PCI_IOV kernel option..
Jul 12 2017, 10:03 PM
bdrewery committed rS320919: META_MODE: Fix not writing .meta files in the kernel build..
META_MODE: Fix not writing .meta files in the kernel build.
Jul 12 2017, 7:01 PM

Jul 11 2017

bdrewery committed rS320884: DIRDEPS_BUILD: Connect more libraries..
DIRDEPS_BUILD: Connect more libraries.
Jul 11 2017, 12:32 AM

Jul 10 2017

bdrewery committed rS320882: DIRDEPS_BUILD: Update dependencies..
DIRDEPS_BUILD: Update dependencies.
Jul 10 2017, 11:52 PM
bdrewery committed rS320883: Fix INSTALL_AS_USER after r319020..
Fix INSTALL_AS_USER after r319020.
Jul 10 2017, 11:52 PM
bdrewery committed rS320881: Follow-up r318881: Disconnect groff documents..
Follow-up r318881: Disconnect groff documents.
Jul 10 2017, 11:52 PM
bdrewery added inline comments to D10810: Fix INSTALL_AS_USER.
Jul 10 2017, 11:50 PM
bdrewery added inline comments to D10810: Fix INSTALL_AS_USER.
Jul 10 2017, 5:03 PM
bdrewery added inline comments to D10810: Fix INSTALL_AS_USER.
Jul 10 2017, 4:57 PM

Jul 8 2017

bdrewery committed rS320809: makeman: Don't show META_MODE ABI rebuild warnings..
makeman: Don't show META_MODE ABI rebuild warnings.
Jul 8 2017, 5:53 PM
bdrewery committed rP445340: Unbreak 'beadm list'..
Unbreak 'beadm list'.
Jul 8 2017, 4:47 PM
bdrewery committed rS320806: SYSTEM_COMPILER: Ensure there is not a stale compiler in WORLDTMP..
SYSTEM_COMPILER: Ensure there is not a stale compiler in WORLDTMP.
Jul 8 2017, 4:40 PM

Jul 7 2017

bdrewery committed rP445192: Update to 3.0-2440-gf6f4014f.
Update to 3.0-2440-gf6f4014f
Jul 7 2017, 12:44 AM

Jul 6 2017

bdrewery accepted D11504: Provide libdl..
Jul 6 2017, 6:44 PM
bdrewery requested changes to D11504: Provide libdl..
Jul 6 2017, 5:54 PM

Jul 5 2017

bdrewery committed rP445095: Restore /boot/entropy handling incorrectly lost in upstream 1.2.7 tag..
Restore /boot/entropy handling incorrectly lost in upstream 1.2.7 tag.
Jul 5 2017, 8:03 PM
bdrewery committed rS320695: Fix out-of-tree kernel builds after r320275 when bsd.linker.mk not yet….
Fix out-of-tree kernel builds after r320275 when bsd.linker.mk not yet…
Jul 5 2017, 7:43 PM
bdrewery accepted D11369: Update netdumpd to 20170623.

Approved

Jul 5 2017, 7:34 PM
bdrewery accepted D11398: Remove SUBDIR ordering/uniquifying in *bin/Makefile.

Seems reasonable to me to respect the ordering of SUBDIR - and we are not ordering in the SUBDIR.yes entries so the current code is not doing much.

Jul 5 2017, 7:33 PM
bdrewery accepted D11376: Formalize LEAPSECONDS and OLDTIMEZONES in share/zoneinfo/... as....
Jul 5 2017, 7:27 PM
bdrewery committed rS320692: Fix create-kernel-packages with multiple BUILDKERNELS after r320284.
Fix create-kernel-packages with multiple BUILDKERNELS after r320284
Jul 5 2017, 7:24 PM
bdrewery committed rS320691: MFC r289861:.
MFC r289861:
Jul 5 2017, 7:06 PM