Page MenuHomeFreeBSD

bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (349 w, 1 d)

Recent Activity

Fri, Jan 8

bdrewery closed D27671: dtrace: Fix /"string" == NULL/ comparisons using an uninitialized value..
Fri, Jan 8, 10:39 PM
bdrewery committed R10:f222a6b88614: dtrace: Fix /"string" == NULL/ comparisons using an uninitialized value. (authored by bdrewery).
dtrace: Fix /"string" == NULL/ comparisons using an uninitialized value.
Fri, Jan 8, 10:39 PM
bdrewery closed D27648: bsd.compat.mk: Allow finding non-internal libraries.
Fri, Jan 8, 10:39 PM
bdrewery committed R10:556fcdce5b44: bsd.compat.mk: Allow finding non-internal libraries (authored by bdrewery).
bsd.compat.mk: Allow finding non-internal libraries
Fri, Jan 8, 10:39 PM
bdrewery closed D27643: Makefile.inc1: Avoid using release/Makefile for VERSION..
Fri, Jan 8, 10:38 PM
bdrewery committed R10:44b8b2a00d7e: Makefile.inc1: Avoid using release/Makefile for VERSION. (authored by bdrewery).
Makefile.inc1: Avoid using release/Makefile for VERSION.
Fri, Jan 8, 10:38 PM

Sat, Dec 19

bdrewery added inline comments to D27671: dtrace: Fix /"string" == NULL/ comparisons using an uninitialized value..
Sat, Dec 19, 8:58 PM

Dec 18 2020

bdrewery added inline comments to D27671: dtrace: Fix /"string" == NULL/ comparisons using an uninitialized value..
Dec 18 2020, 6:11 PM
bdrewery requested review of D27671: dtrace: Fix /"string" == NULL/ comparisons using an uninitialized value..
Dec 18 2020, 6:10 PM
bdrewery accepted D27663: rtld-libc: fix incremental build.
Dec 18 2020, 12:02 AM

Dec 16 2020

bdrewery added a comment to D27643: Makefile.inc1: Avoid using release/Makefile for VERSION..

For reference, originally introduced in rS257079

Dec 16 2020, 10:56 PM
bdrewery added a comment to D27643: Makefile.inc1: Avoid using release/Makefile for VERSION..

I'm not an expert in the build, but it LGTM. I only wonder if there ought to be a common makefile for this and release/Makefile both to include.

Dec 16 2020, 10:55 PM
bdrewery requested review of D27648: bsd.compat.mk: Allow finding non-internal libraries.
Dec 16 2020, 10:17 PM
bdrewery added inline comments to D27622: include: Delete stale symlinks using find(1) instead of a shell loop..
Dec 16 2020, 10:05 PM
bdrewery requested changes to D27622: include: Delete stale symlinks using find(1) instead of a shell loop..
Dec 16 2020, 10:03 PM
bdrewery accepted D27646: newvers.sh: Speed up git_tree_modified.
Dec 16 2020, 9:28 PM
bdrewery added inline comments to D27643: Makefile.inc1: Avoid using release/Makefile for VERSION..
Dec 16 2020, 8:56 PM
bdrewery requested review of D27643: Makefile.inc1: Avoid using release/Makefile for VERSION..
Dec 16 2020, 8:36 PM

Dec 15 2020

bdrewery committed rS368673: Revert r368523 which fixed contig allocs waiting forever..
Revert r368523 which fixed contig allocs waiting forever.
Dec 15 2020, 7:38 PM

Dec 10 2020

bdrewery closed D27508: linux_dma: Ensure proper flags pass to allocators..
Dec 10 2020, 8:45 PM
bdrewery committed rS368524: linux_dma: Ensure proper flags pass to allocators..
linux_dma: Ensure proper flags pass to allocators.
Dec 10 2020, 8:45 PM
bdrewery closed D27507: contig allocs: Don't retry forever on M_WAITOK..
Dec 10 2020, 8:45 PM
bdrewery committed rS368523: contig allocs: Don't retry forever on M_WAITOK..
contig allocs: Don't retry forever on M_WAITOK.
Dec 10 2020, 8:45 PM
bdrewery added a comment to D27507: contig allocs: Don't retry forever on M_WAITOK..

I think a dedicated iterator would be reasonable. I just wanted to avoid polluting the common case with checks needed to handle rare contig allocations.

Dec 10 2020, 5:28 PM

Dec 9 2020

bdrewery added a comment to D27508: linux_dma: Ensure proper flags pass to allocators..

Hi,

Can you explain this change a bit more?

gfp_t may contain bits which are not supported by the M_XXX flags and should be filtered away?

If you need to pass additional flags you need to update GFP_NATIVE_MASK .

--HPS

Dec 9 2020, 6:08 PM
bdrewery added a comment to D27507: contig allocs: Don't retry forever on M_WAITOK..
In D27507#615134, @kib wrote:

I wonder if it is better to move the retry policy into iterators instead.

Dec 9 2020, 6:01 PM

Dec 8 2020

bdrewery closed D27184: fts_read: Handle error from a NULL return better..
Dec 8 2020, 11:39 PM
bdrewery committed rS368467: fts_read: Handle error from a NULL return better..
fts_read: Handle error from a NULL return better.
Dec 8 2020, 11:39 PM
bdrewery retitled D27507: contig allocs: Don't retry forever on M_WAITOK. from contig allocs: Don't sleep forever on M_WAITOK. to contig allocs: Don't retry forever on M_WAITOK..
Dec 8 2020, 11:34 PM
bdrewery added a reviewer for D27508: linux_dma: Ensure proper flags pass to allocators.: hselasky.
Dec 8 2020, 11:14 PM
bdrewery updated the diff for D27507: contig allocs: Don't retry forever on M_WAITOK..
  • Take Mark's comment
Dec 8 2020, 11:11 PM
bdrewery added inline comments to D27507: contig allocs: Don't retry forever on M_WAITOK..
Dec 8 2020, 8:28 PM
bdrewery added inline comments to D27507: contig allocs: Don't retry forever on M_WAITOK..
Dec 8 2020, 7:15 PM
bdrewery updated the diff for D27507: contig allocs: Don't retry forever on M_WAITOK..
  • Move the fix out of the iterator.
Dec 8 2020, 5:41 PM
bdrewery added inline comments to D27507: contig allocs: Don't retry forever on M_WAITOK..
Dec 8 2020, 5:12 PM
bdrewery updated the summary of D27508: linux_dma: Ensure proper flags pass to allocators..
Dec 8 2020, 5:53 AM
bdrewery requested review of D27508: linux_dma: Ensure proper flags pass to allocators..
Dec 8 2020, 5:45 AM
bdrewery updated the diff for D27507: contig allocs: Don't retry forever on M_WAITOK..
  • Set di_flags|=M_NOWAIT consistently
Dec 8 2020, 5:40 AM
bdrewery added inline comments to D27507: contig allocs: Don't retry forever on M_WAITOK..
Dec 8 2020, 5:37 AM
bdrewery requested review of D27507: contig allocs: Don't retry forever on M_WAITOK..
Dec 8 2020, 5:35 AM

Dec 1 2020

bdrewery added a comment to D27393: Upgrade devel/ccache to v4.1.

Thanks for working on this. I'll review+test soon.

Dec 1 2020, 11:46 PM

Nov 24 2020

bdrewery accepted D27300: Update dirdeps.mk et al to latest.
Nov 24 2020, 9:01 PM
bdrewery committed rP556185: - Fix KERB_GSSAPI build; missing prototypes for DH openssl-compat..
- Fix KERB_GSSAPI build; missing prototypes for DH openssl-compat.
Nov 24 2020, 8:47 PM

Nov 20 2020

bdrewery requested changes to D27300: Update dirdeps.mk et al to latest.
Nov 20 2020, 10:41 PM
bdrewery abandoned D27287: Look for drti.o in WORLDTMP when building dtrace probes..

The whole story for this is very longwinded. I'll just say that using lazyloading for the probe avoids the need for linking drti.o and is a better solution for libthr.
It's also all reliant on being an incremental build from before the recent incremental fixes to libdtrace. I still need the libdtrace bootstrapping in my work situation but makes no sense for FreeBSD yet.
All in all this change is incomplete and would make more sense to come in with most of the summary patch as well if it is ever needed.

Nov 20 2020, 10:19 PM
bdrewery abandoned D27299: legacy: Use -isystem for system header overrides..

The whole premise here is wrong. CCACHE_NODIRECT=1 avoids my problem. I'm not going to fix what's not broken. Sorry for the noise.

Nov 20 2020, 10:03 PM
bdrewery added a comment to D27299: legacy: Use -isystem for system header overrides..
There is a catch with the direct mode: header files that were used by the compiler are recorded, but header files that were not used, but would have been used if they existed, are not. So, when ccache checks if a result can be taken from the cache, it currently can't check if the existence of a new header file
should invalidate the result. In practice, the direct mode is safe to use in the absolute majority of cases.

Yeah it seems to be ccache causing my problems and this change just forced a rebuild. META_MODE+filemon has the same flaw :-(.
So my reasoning is wrong.

Nov 20 2020, 9:16 PM
bdrewery added a comment to D27299: legacy: Use -isystem for system header overrides..

I am perplexed why it finds libelf.h but not libproc.h.

Nov 20 2020, 8:59 PM
bdrewery requested review of D27299: legacy: Use -isystem for system header overrides..
Nov 20 2020, 8:54 PM
bdrewery closed D27200: Add lists for customizing legacy and bootstrap-tools..
Nov 20 2020, 8:12 PM
bdrewery committed rS367910: Add lists for customizing legacy and bootstrap-tools..
Add lists for customizing legacy and bootstrap-tools.
Nov 20 2020, 8:12 PM
bdrewery committed rP555734: - Add pkg-config dependency which avoids some maintainer testing errors.
- Add pkg-config dependency which avoids some maintainer testing errors
Nov 20 2020, 3:42 AM

Nov 19 2020

bdrewery updated the test plan for D27287: Look for drti.o in WORLDTMP when building dtrace probes..
Nov 19 2020, 8:24 PM
bdrewery requested review of D27289: security/libfido2: Don't require libcrypto.pc for base ssl.
Nov 19 2020, 8:04 PM
bdrewery requested review of D27287: Look for drti.o in WORLDTMP when building dtrace probes..
Nov 19 2020, 6:47 PM

Nov 17 2020

bdrewery added a comment to D17128: [sshd 7.8p1] avoid to violate capability mode.
In D17128#371823, @des wrote:

I would strongly recommend submitting the sshbuf_{get,put,free}_passwd() part of this patch upstream.

Nov 17 2020, 2:22 AM · capsicum
bdrewery committed rP555531: - Add blacklistd(8) support..
- Add blacklistd(8) support.
Nov 17 2020, 1:45 AM

Nov 16 2020

bdrewery committed rP555524: - Add and enable FIDO/U2F support for security keys by default..
- Add and enable FIDO/U2F support for security keys by default.
Nov 16 2020, 11:37 PM
bdrewery committed rP555518: - Slightly reduce diff with base.
- Slightly reduce diff with base
Nov 16 2020, 10:25 PM
bdrewery committed rP555516: - bindresvport support hasn't been used since 7.8.
- bindresvport support hasn't been used since 7.8
Nov 16 2020, 8:39 PM
bdrewery committed rP555514: - Remove sctp patch missed in r466577.
- Remove sctp patch missed in r466577
Nov 16 2020, 8:36 PM
bdrewery committed rP555512: - Update to 8.4p1 (skipped 8.3).
- Update to 8.4p1 (skipped 8.3)
Nov 16 2020, 7:39 PM

Nov 13 2020

bdrewery accepted D27211: Add a guard for broken SUBDIR.${MK_FOO} use.

Brilliant!

Nov 13 2020, 10:57 PM
bdrewery accepted D27210: Add missing src.opts.mk include.
Nov 13 2020, 10:57 PM
bdrewery committed rP555042: Fix bsdgrep support for jail version.
Fix bsdgrep support for jail version
Nov 13 2020, 7:13 PM
bdrewery committed rP555041: - Update to 3.3.6.
- Update to 3.3.6
Nov 13 2020, 7:12 PM

Nov 12 2020

bdrewery added a comment to D27022: Introduce getlocalbase.3.

The problem I see is that not everything will use this or the sysctl. Ports, Poudriere, nearly everything, are doing getenv("LOCALBASE"). Other places have things like LOCALBASE?= /usr/local. So then I wonder what the usefulness of it being configured in the kernel in the first place is as a user setting it won't achieve much.

Nov 12 2020, 9:48 PM
bdrewery requested review of D27200: Add lists for customizing legacy and bootstrap-tools..
Nov 12 2020, 9:23 PM
bdrewery added inline comments to D25992: Add necessary Makefile.inc1 infrastructure for building on non-FreeBSD.
Nov 12 2020, 9:16 PM

Nov 11 2020

bdrewery accepted D27133: security/openssh-portable: Set LICENSE.
Nov 11 2020, 11:44 PM
bdrewery requested review of D27184: fts_read: Handle error from a NULL return better..
Nov 11 2020, 11:42 PM
bdrewery added inline comments to D19237: Fix TARGET_TRIPLE assembly and retrieve OS version automatically.
Nov 11 2020, 11:41 PM · PowerPC
bdrewery accepted D27102: bsd.lib.mk: Work around build system raciness.

This was just an optimization in rS322565 so there's no harm in losing it until we find a way to make it work. I found it was related to MK_PROFILE flipping back then.

Nov 11 2020, 11:12 PM
bdrewery added a comment to D26453: Hack to install symlinks atomically..

Nice find!
I missed that the symlink installs didn't use $SHLINSTALLFLAGS back in rS322565. I banged my head on this problem for a long time with dhw@ hitting it daily.

Nov 11 2020, 11:05 PM
bdrewery added a comment to D26776: Skip make includes for (most) directories without includes.

Sorry about that. I didn't communicate my concerns in a proper way. (As noted in private email).
Here I am worried about quietly not installing headers leading to silent bugs like a downstream compilation using a header it finds in another directory instead.
I missed the build time assertion in bsd.incs.mk. That helps a lot to mitigate my concerns as it yells at people to fix it. Having taken a second look I support this and think the implementation is good too.
We have a similar problem with CONFS that causes make installconfig to take forever for mergemaster and etcupdate. It would be nice if that was worked into this too.

Nov 11 2020, 10:51 PM
bdrewery committed rP554917: - Fix jail creation for 12.2+ seeing sys/param.h error..
- Fix jail creation for 12.2+ seeing sys/param.h error.
Nov 11 2020, 10:21 PM
bdrewery committed rP554916: - Update to 3.3.5.
- Update to 3.3.5
Nov 11 2020, 10:20 PM

Nov 10 2020

bdrewery abandoned D27163: mtree -c { -O | -X }: Avoid silently ignoring errors from fts(3).

In all cases in fts.c, NULL is returned when FTS_STOP is set. The downstream fts is the problem, not FreeBSD or mtree.

Nov 10 2020, 11:48 PM
bdrewery updated the summary of D27163: mtree -c { -O | -X }: Avoid silently ignoring errors from fts(3).
Nov 10 2020, 6:29 PM
bdrewery requested review of D27163: mtree -c { -O | -X }: Avoid silently ignoring errors from fts(3).
Nov 10 2020, 6:18 PM
bdrewery closed D27134: makeman: Don't require filemon with MK_DIRDEPS_BUILD..
Nov 10 2020, 6:05 PM
bdrewery committed rS367570: makeman: Don't require filemon with MK_DIRDEPS_BUILD..
makeman: Don't require filemon with MK_DIRDEPS_BUILD.
Nov 10 2020, 6:05 PM

Nov 9 2020

bdrewery updated the diff for D27134: makeman: Don't require filemon with MK_DIRDEPS_BUILD..

Add comment

Nov 9 2020, 8:22 PM
bdrewery updated the diff for D27134: makeman: Don't require filemon with MK_DIRDEPS_BUILD..

Move to local.meta.sys.mk

Nov 9 2020, 8:21 PM

Nov 7 2020

bdrewery committed rS367455: syslogd: Stop trying to send remote messages through special sockets.
syslogd: Stop trying to send remote messages through special sockets
Nov 7 2020, 5:19 PM
bdrewery requested review of D27134: makeman: Don't require filemon with MK_DIRDEPS_BUILD..
Nov 7 2020, 5:15 PM

Oct 16 2020

bdrewery committed rD54604: Update my key.
Update my key
Oct 16 2020, 6:20 PM

Oct 15 2020

bdrewery added a comment to D26618: Don't use install(1) for the library symlinks in the build directory.
Oct 15 2020, 12:40 AM
bdrewery requested changes to D26776: Skip make includes for (most) directories without includes.
Oct 15 2020, 12:39 AM
bdrewery added a comment to D26776: Skip make includes for (most) directories without includes.

Please don't. This is such a huge niche micro optimization. -j1 isn't normal and I don't see this being worth the maintenance cost.

Oct 15 2020, 12:37 AM

Oct 9 2020

bdrewery closed D26653: Use unlocked page lookup for inmem() to avoid object lock contention.
Oct 9 2020, 11:50 PM
bdrewery committed rS366594: Use unlocked page lookup for inmem() to avoid object lock contention.
Use unlocked page lookup for inmem() to avoid object lock contention
Oct 9 2020, 11:50 PM

Oct 1 2020

bdrewery committed rS366343: Revert r366340..
Revert r366340.
Oct 1 2020, 8:52 PM
bdrewery committed rS366340: Use unlocked page lookup for inmem() to avoid object lock contention.
Use unlocked page lookup for inmem() to avoid object lock contention
Oct 1 2020, 8:26 PM
bdrewery closed D26597: Use unlocked page lookup for inmem() to avoid object lock contention.
Oct 1 2020, 8:25 PM
bdrewery added inline comments to D26597: Use unlocked page lookup for inmem() to avoid object lock contention.
Oct 1 2020, 8:24 PM
bdrewery requested changes to D26597: Use unlocked page lookup for inmem() to avoid object lock contention.
Oct 1 2020, 8:24 PM
bdrewery added inline comments to D26597: Use unlocked page lookup for inmem() to avoid object lock contention.
Oct 1 2020, 8:24 PM
bdrewery added a comment to D26597: Use unlocked page lookup for inmem() to avoid object lock contention.

I had committed this prematurely and now reverted.

Building /usr/obj/usr/src/i386.i386/sys/SARAH/vfs_bio.o
--- vfs_bio.o ---
/usr/src/sys/kern/vfs_bio.c:3614:7: error: implicit declaration of function 'vm_page_lookup_unlocked' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                m = vm_page_lookup_unlocked(obj, OFF_TO_IDX(off + toff));
                    ^
/usr/src/sys/kern/vfs_bio.c:3614:7: note: did you mean 'vm_map_lookup_locked'?
/usr/src/sys/vm/vm_map.h:480:5: note: 'vm_map_lookup_locked' declared here
int vm_map_lookup_locked(vm_map_t *, vm_offset_t, vm_prot_t, vm_map_entry_t *, vm_object_t *,
    ^
/usr/src/sys/kern/vfs_bio.c:3614:5: error: incompatible integer to pointer conversion assigning to 'vm_page_t' (aka 'struct vm_page *') from 'int' [-Werror,-Wint-conversion]
                m = vm_page_lookup_unlocked(obj, OFF_TO_IDX(off + toff));
                  ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/src/sys/kern/vfs_bio.c:3624:5: error: incompatible integer to pointer conversion assigning to 'vm_page_t' (aka 'struct vm_page *') from 'int' [-Werror,-Wint-conversion]
                n = vm_page_lookup_unlocked(obj, OFF_TO_IDX(off + toff));
                  ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
3 errors generated.
*** [vfs_bio.o] Error code 1
Oct 1 2020, 8:24 PM

Sep 15 2020

bdrewery accepted D26445: fix setitimer test for returned it_value.
Sep 15 2020, 8:10 PM