Page MenuHomeFreeBSD

bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (283 w, 5 d)

Recent Activity

Yesterday

bdrewery committed rP514688: LICENSE check: Respect DISABLE_LICENSES..
LICENSE check: Respect DISABLE_LICENSES.
Thu, Oct 17, 9:12 PM
bdrewery added a comment to D22059: Allow bsd.compat.mk to be reliably included outside Makefile.inc1..
In D22059#482035, @imp wrote:

The question is, do we need them to be TARGET_* in this makefile.inc1 usage?
I kinda think it does. Checking into *that* detail...

Thu, Oct 17, 7:57 PM
bdrewery accepted D22057: always add standard kernel configuration include path.
Thu, Oct 17, 7:55 PM
bdrewery added a comment to D22057: always add standard kernel configuration include path.

I'd be inclined to explicitly spell it as -I ${KRNLCONFDIR} instead of -I., and then we later rename KRNLCONFDIR to make it more clear. We can't quickly change the cd, at least, because:

Thu, Oct 17, 12:42 AM

Wed, Oct 16

bdrewery added a comment to D22057: always add standard kernel configuration include path.
In D22057#481900, @avg wrote:

I don't have answers to your questions, sorry.
And I did not intend for the review to center around KRNLCONFDIR vs KERNCONFDIR.
I just want to be able to do what this change allows me to do.
That is, I want to be able to include files from both directories.

Wed, Oct 16, 10:22 PM
bdrewery added a comment to D22057: always add standard kernel configuration include path.
In D22057#481764, @avg wrote:

Just a note, KRNLCONFDIR is the standard location (derived from TARGET) and KERNCONFDIR is the actual, possibly overridden, location.

Sigh. Why. These appear to be the same at quick glance.

Wed, Oct 16, 7:40 PM
bdrewery added a comment to D22057: always add standard kernel configuration include path.
In D22057#481764, @avg wrote:

Just a note, KRNLCONFDIR is the standard location (derived from TARGET) and KERNCONFDIR is the actual, possibly overridden, location.

Wed, Oct 16, 7:34 PM
bdrewery accepted D22059: Allow bsd.compat.mk to be reliably included outside Makefile.inc1..

Oops sorry for missing this before. TARGET_ are only useful in Makefile.inc1.

Wed, Oct 16, 7:26 PM

Tue, Oct 15

bdrewery added a comment to D22023: Optionally build/link programs against the compat ABI..

We have use for this at work as well for FreeBSD amd64/32 ABI compat testing since we have our own ABI. Though we just use FreeBSD 10 dist files for the purpose this feature is still nice.

Tue, Oct 15, 6:10 PM
bdrewery accepted D22023: Optionally build/link programs against the compat ABI..

This is great!

Tue, Oct 15, 6:07 PM

Thu, Oct 10

bdrewery committed rP514247: - Add compat for NOCCACHE -> NO_CCACHE.
- Add compat for NOCCACHE -> NO_CCACHE
Thu, Oct 10, 8:10 PM
bdrewery committed rP514246: - Add a CCACHE_BIN variable for simplified use where needed..
- Add a CCACHE_BIN variable for simplified use where needed.
Thu, Oct 10, 8:06 PM
bdrewery committed rP514245: - Respect NOCCACHE.
- Respect NOCCACHE
Thu, Oct 10, 8:04 PM

Wed, Oct 9

bdrewery added a comment to D21775: (WIP) Rewrite makesyscalls.sh in Lua.

I don't know lua yet so cannot review most of this. But I'm OK with expanding lua usage. One "regression" I see is that move from a heredoc to a ton of write_line lines. Can lua not continue a string on the next line? Or may we should have some kind of template file instead.

Wed, Oct 9, 4:28 PM

Wed, Sep 25

bdrewery added inline comments to D21775: (WIP) Rewrite makesyscalls.sh in Lua.
Wed, Sep 25, 10:27 PM
bdrewery added a comment to D21775: (WIP) Rewrite makesyscalls.sh in Lua.

I'm planning to make the syscall files generate *during the build*. It will need to happen quite early. Is lua already an early bootstrap tool?

Wed, Sep 25, 10:21 PM

Thu, Sep 19

bdrewery accepted D21717: Make it clear that a port's dependencies should not be minimal..

I like it. But it still comes down to a bikeshed/opinion. Anyway it's a good guidance.

Thu, Sep 19, 4:46 PM

Sep 16 2019

bdrewery added a comment to D21468: Overlay support for the ports tree.
Sep 16 2019, 7:47 PM
bdrewery added a comment to D21468: Overlay support for the ports tree.
~/svn/ports/databases/mysql56-client # grep MASTERDIR Makefile
MASTERDIR=      ${.CURDIR}/../mysql56-server
EXTRA_PATCHES+= ${MASTERDIR}/files/patch-PR225888.diff
.include "${MASTERDIR}/Makefile"
Sep 16 2019, 7:39 PM
bdrewery added inline comments to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 16 2019, 7:17 PM

Sep 12 2019

bdrewery committed rS352265: mtree -O: Fix not descending on hash collisions.
mtree -O: Fix not descending on hash collisions
Sep 12 2019, 8:46 PM
bdrewery committed rS352262: mtree -c: Fix username logic when getlogin(3) fails..
mtree -c: Fix username logic when getlogin(3) fails.
Sep 12 2019, 6:52 PM
bdrewery committed rS352261: mtree: Fix -f -f not considering type changes..
mtree: Fix -f -f not considering type changes.
Sep 12 2019, 6:45 PM
bdrewery closed D21623: mtree: Fix -f -f not considering type changes..
Sep 12 2019, 6:45 PM
bdrewery created D21623: mtree: Fix -f -f not considering type changes..
Sep 12 2019, 6:42 PM

Sep 5 2019

bdrewery committed rS351895: MFC r349005:.
MFC r349005:
Sep 5 2019, 8:39 PM
bdrewery committed rS351894: MFC r349005:.
MFC r349005:
Sep 5 2019, 8:39 PM
bdrewery committed rS351893: MFC r347458:.
MFC r347458:
Sep 5 2019, 8:38 PM
bdrewery committed rS351892: MFC r347458,r348975,r348976:.
MFC r347458,r348975,r348976:
Sep 5 2019, 8:31 PM
bdrewery committed rS351891: MFC r339635,r350301,r350327,r351151:.
MFC r339635,r350301,r350327,r351151:
Sep 5 2019, 8:28 PM
bdrewery committed rS351890: MFC r339635,r350301,r350327,r351151:.
MFC r339635,r350301,r350327,r351151:
Sep 5 2019, 8:26 PM
bdrewery committed rS351876: MFC r348979:.
MFC r348979:
Sep 5 2019, 5:20 PM
bdrewery committed rS351875: MFC r348979:.
MFC r348979:
Sep 5 2019, 5:20 PM
bdrewery committed rS351873: MFC r346255:.
MFC r346255:
Sep 5 2019, 4:53 PM
bdrewery committed rS351872: MFC r346255:.
MFC r346255:
Sep 5 2019, 4:53 PM

Sep 4 2019

bdrewery committed rS351823: PROGS: Build common sources before recursed PROGS_TARGETS as well when building..
PROGS: Build common sources before recursed PROGS_TARGETS as well when building.
Sep 4 2019, 6:32 PM

Sep 3 2019

bdrewery accepted D21283: Use file destdir for stage_as sets.

If buildworld and installworld work then it seems fine.

Sep 3 2019, 3:29 AM

Aug 28 2019

bdrewery committed rP510098: - Update to 3.3.0-164-g122329edc.
- Update to 3.3.0-164-g122329edc
Aug 28 2019, 8:20 PM

Aug 16 2019

bdrewery committed rS351151: Rework r339635 to fix .depend.tables.h handling..
Rework r339635 to fix .depend.tables.h handling.
Aug 16 2019, 10:34 PM
bdrewery closed D21295: Rework r339635 to fix .depend.tables.h handling..
Aug 16 2019, 10:34 PM
bdrewery added a comment to D21295: Rework r339635 to fix .depend.tables.h handling..

Review findings

Aug 16 2019, 9:32 PM
bdrewery added a comment to D21069: libsysdecode: automate tables.h dependency generation.

My change is at D21295

Aug 16 2019, 8:00 PM
bdrewery created D21295: Rework r339635 to fix .depend.tables.h handling..
Aug 16 2019, 8:00 PM
bdrewery added a comment to D21069: libsysdecode: automate tables.h dependency generation.

Something like this is probably needed instead

~/git/freebsd2/lib/libsysdecode # git diff
diff --git lib/libsysdecode/Makefile lib/libsysdecode/Makefile
index 2be244a6da46..9edfe067063c 100644
--- lib/libsysdecode/Makefile
+++ lib/libsysdecode/Makefile
@@ -127,7 +127,8 @@ incdir=${SYSROOT:U${DESTDIR}}${INCLUDEDIR}
 tables.h: mktables ${incdir}/netinet/in.h ${incdir}/netinet/tcp.h \
     ${incdir}/netinet6/in6.h
        sh ${.CURDIR}/mktables ${incdir} ${.TARGET}.tmp && \
-           mv -f ${.TARGET}.tmp ${.TARGET}
+           mv -f ${.TARGET}.tmp ${.TARGET} && \
+           mv -f .depend.${.TARGET}.tmp .depend.${.TARGET}
Aug 16 2019, 7:47 PM
bdrewery added a comment to D21069: libsysdecode: automate tables.h dependency generation.

The hacks to using tables.h.tmp is probably what broke my work.

Aug 16 2019, 7:45 PM
D21069: libsysdecode: automate tables.h dependency generation now requires changes to proceed.

This already has .depend file support. Why is this needed?

Aug 16 2019, 7:43 PM
bdrewery added inline comments to D21069: libsysdecode: automate tables.h dependency generation.
Aug 16 2019, 7:43 PM

Aug 15 2019

bdrewery committed rP509046: - Update to 3.3.0-126-g12112ee57.
- Update to 3.3.0-126-g12112ee57
Aug 15 2019, 7:58 PM
bdrewery added a comment to D21060: Stop installing clang, clang++, and clang-cpp hardlinks in /usr/bin..

Which package provides clang? I don't have a /usr/local/bin/clang on my system.

Aug 15 2019, 6:22 PM

Aug 3 2019

bdrewery committed rP507975: - Update to 3.3.0-125-g0a50192f8.
- Update to 3.3.0-125-g0a50192f8
Aug 3 2019, 5:41 PM

Jul 31 2019

bdrewery added a comment to D21124: Make umtxq_check_susp() to correctly handle thread exit requests..

This doesn't seem to fix the SIGKILL issue.

~ # procstat -kk 19680
  PID    TID COMM                TDNAME              KSTACK
19680 101200 python2.7           -                   __mtx_lock_sleep+0x118 __mtx_lock_flags+0x102 _sleep+0x334 umtxq_busy+0xb7 do_sem_wait+0x150 __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
19680 101634 python2.7           -                   mi_switch+0x174 sleepq_switch+0x110 sleepq_catch_signals+0x417 sleepq_wait_sig+0xf _sleep+0x2d0 umtxq_sleep+0x153 do_sem_wait+0x41c __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
19680 101635 python2.7           -                   _mtx_lock_spin_cookie+0x231 __mtx_lock_spin_flags+0xf8 wakeup_one+0xf do_sem_wait+0x26f __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
~ # kill -9 19680
~ # procstat -kk 19680
  PID    TID COMM                TDNAME              KSTACK
19680 101200 python2.7           -                   __mtx_lock_flags+0xc1 do_sem_wait+0x218 __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
19680 101634 python2.7           -                   mi_switch+0x174 sleepq_switch+0x110 sleepq_catch_signals+0x417 sleepq_wait_sig+0xf _sleep+0x2d0 umtxq_sleep+0x153 do_sem_wait+0x41c __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
19680 101635 python2.7           -                   __mtx_lock_sleep+0x118 __mtx_lock_flags+0x102 do_sem_wait+0x148 __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
~ # procstat -i 19680|grep -v -- ---|grep KILL
19680 python2.7        KILL     P--
Jul 31 2019, 8:20 PM

Jul 30 2019

bdrewery committed rP507681: Grammar nit.
Grammar nit
Jul 30 2019, 9:09 PM
bdrewery added inline comments to rS350446: Handle refcount(9) wraparound..
Jul 30 2019, 6:53 PM
bdrewery added inline comments to rS350446: Handle refcount(9) wraparound..
Jul 30 2019, 6:33 PM
bdrewery added inline comments to rS350446: Handle refcount(9) wraparound..
Jul 30 2019, 6:18 PM

Jul 28 2019

bdrewery committed rP507530: NOCCACHE also disables setting CCACHE_WRAPPER_PATH which can break the build..
NOCCACHE also disables setting CCACHE_WRAPPER_PATH which can break the build.
Jul 28 2019, 8:28 PM

Jul 26 2019

bdrewery added a comment to D17906: rm(1): Formalize non-functional status of -P flag.

This is a massive POLA violation. What the hell. You took a flag that was intended to make <some effort> to overwrite data and made it SILENTLY DO NOTHING. That's insane.

Jul 26 2019, 7:23 AM

Jul 24 2019

bdrewery committed rP507274: - Update to 3.3.0-90-gd6f021339.
- Update to 3.3.0-90-gd6f021339
Jul 24 2019, 4:21 PM

Jul 19 2019

bdrewery committed rP506960: Update to 1.3.0..
Update to 1.3.0.
Jul 19 2019, 7:29 PM
bdrewery committed rP506959: - Update gssapi patch for 8.0.
- Update gssapi patch for 8.0
Jul 19 2019, 7:18 PM
bdrewery committed rS350119: Rework some multi-output target dependency handling..
Rework some multi-output target dependency handling.
Jul 19 2019, 12:15 AM

Jul 18 2019

bdrewery committed rP506878: Fix BROKEN handling for x509/gssapi FLAVORS.
Fix BROKEN handling for x509/gssapi FLAVORS
Jul 18 2019, 8:10 PM

Jul 13 2019

bdrewery committed rP506548: Don't try splitting symbols out of .a archives..
Don't try splitting symbols out of .a archives.
Jul 13 2019, 5:32 PM

Jul 12 2019

bdrewery added inline comments to D20261: [PowerPC64] Adds support for using ld.bfd on LIB32 and STAND, when default linker is ld.lld.
Jul 12 2019, 5:00 PM
bdrewery committed rP506433: Update to 8.0p1.
Update to 8.0p1
Jul 12 2019, 3:49 AM

Jul 10 2019

bdrewery committed rP506358: Fix handling of ports with *1* file..
Fix handling of ports with *1* file.
Jul 10 2019, 4:18 PM

Jul 4 2019

bdrewery committed rS349729: Consider *clean targets as non-build targets as well..
Consider *clean targets as non-build targets as well.
Jul 4 2019, 2:51 PM

Jun 30 2019

bdrewery committed rP505522: Reduce code duplication from r504140..
Reduce code duplication from r504140.
Jun 30 2019, 11:03 PM

Jun 26 2019

bdrewery committed rP505131: generate-symbols: Commit a working version..
generate-symbols: Commit a working version.
Jun 26 2019, 1:19 AM
bdrewery committed rP505130: Revert r505129: I still have the wrong version..
Revert r505129: I still have the wrong version.
Jun 26 2019, 1:07 AM
bdrewery committed rP505129: Allow generate-symbols.sh to actually work..
Allow generate-symbols.sh to actually work.
Jun 26 2019, 12:45 AM

Jun 19 2019

bdrewery committed rS349202: Follow-up r349065: Fix .TARGET flag ambiguity with PROGS which broke MK_TESTS..
Follow-up r349065: Fix .TARGET flag ambiguity with PROGS which broke MK_TESTS.
Jun 19 2019, 7:19 PM

Jun 18 2019

bdrewery committed rS349179: Rework r349061: Don't apply guessed dependencies if there is a custom target..
Rework r349061: Don't apply guessed dependencies if there is a custom target.
Jun 18 2019, 10:00 PM

Jun 16 2019

bdrewery committed rS349099: symlinkat(2) is not covered..
symlinkat(2) is not covered.
Jun 16 2019, 5:12 AM

Jun 15 2019

bdrewery committed rS349067: Support reading in .depend files..
Support reading in .depend files.
Jun 15 2019, 5:08 PM
bdrewery committed rS349068: Allow DEPENDOBJS/DEPENDSRCS to work with only OBJS set and no SRCS..
Allow DEPENDOBJS/DEPENDSRCS to work with only OBJS set and no SRCS.
Jun 15 2019, 5:08 PM
bdrewery committed rS349069: csu: Add proper .depend tracking for each object..
csu: Add proper .depend tracking for each object.
Jun 15 2019, 5:08 PM
bdrewery committed rS349066: META_MODE: Delete build targets that fail..
META_MODE: Delete build targets that fail.
Jun 15 2019, 5:08 PM
bdrewery committed rS349065: Add various CFLAGS/LDADD overrides for the output target file..
Add various CFLAGS/LDADD overrides for the output target file.
Jun 15 2019, 5:08 PM
bdrewery committed rS349064: Avoid generating DEPENDFILES='.depend.' when there's no DEPENDOBJS..
Avoid generating DEPENDFILES='.depend.' when there's no DEPENDOBJS.
Jun 15 2019, 5:08 PM
bdrewery committed rS349063: Similar to r335710 avoid ccache when linking a .cc file directly..
Similar to r335710 avoid ccache when linking a .cc file directly.
Jun 15 2019, 5:08 PM
bdrewery committed rS349062: Fix .depend files to work for build tools..
Fix .depend files to work for build tools.
Jun 15 2019, 5:08 PM
bdrewery committed rS349061: Don't force OBJS_DEPEND_GUESS headers onto all objects..
Don't force OBJS_DEPEND_GUESS headers onto all objects.
Jun 15 2019, 5:08 PM

Jun 13 2019

bdrewery committed rP504140: parse_plist: Avoid excess fork+exec inside the loop for stripping (mode) lines..
parse_plist: Avoid excess fork+exec inside the loop for stripping (mode) lines.
Jun 13 2019, 10:22 PM
bdrewery committed rP504139: Remove the .error as it is causing unintended side effects..
Remove the .error as it is causing unintended side effects.
Jun 13 2019, 10:14 PM

Jun 12 2019

bdrewery committed rS349005: Don't delete .depend files outside of cleandepend..
Don't delete .depend files outside of cleandepend.
Jun 12 2019, 11:09 PM
bdrewery committed rS348979: Stop using .OODATE for extracting firmware..
Stop using .OODATE for extracting firmware.
Jun 12 2019, 12:03 AM

Jun 11 2019

bdrewery committed rS348976: Add missing DPSRCS entry for assym.inc..
Add missing DPSRCS entry for assym.inc.
Jun 11 2019, 11:35 PM
bdrewery committed rS348975: Restore genassym.o to CLEANFILES..
Restore genassym.o to CLEANFILES.
Jun 11 2019, 11:35 PM
bdrewery committed rP503998: Speedup ELF file detection almost 100%..
Speedup ELF file detection almost 100%.
Jun 11 2019, 10:56 PM
bdrewery committed rP503996: Fix MAKE_JOBS support..
Fix MAKE_JOBS support.
Jun 11 2019, 10:30 PM

Jun 10 2019

bdrewery committed rP503929: Add debug for BUILD_DEPENDS .error.
Add debug for BUILD_DEPENDS .error
Jun 10 2019, 10:49 PM
bdrewery committed rS348877: DPSRCS need to be built before recursing..
DPSRCS need to be built before recursing.
Jun 10 2019, 7:38 PM

May 30 2019

bdrewery accepted D20476: makesyscalls.sh: always use absolute path for syscalls.conf.
May 30 2019, 8:50 PM
bdrewery requested changes to D20476: makesyscalls.sh: always use absolute path for syscalls.conf.
May 30 2019, 8:43 PM

May 20 2019

bdrewery committed rP502126: Fix recursive dependency issue with gmake..
Fix recursive dependency issue with gmake.
May 20 2019, 5:06 PM

May 18 2019

bdrewery committed rP501985: Update ccache to 3.7.1.
Update ccache to 3.7.1
May 18 2019, 9:53 PM

May 10 2019

bdrewery committed rS347458: Fix build race with machine links and genoffset.o..
Fix build race with machine links and genoffset.o.
May 10 2019, 6:09 PM

Apr 19 2019

bdrewery accepted D19853: [security/nist-kat]: Add AES-CCM and plain SHA digest test vectors..

Ports approved

Apr 19 2019, 10:55 PM

Apr 16 2019

bdrewery committed rS346255: Fix 'jot -r 0 start end' to work..
Fix 'jot -r 0 start end' to work.
Apr 16 2019, 12:41 AM