Page MenuHomeFreeBSD

bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (308 w, 1 d)

Recent Activity

Sat, Apr 4

bdrewery updated the diff for D24286: Restore local kernel "prog" filtering lost in r332099..

Fix handling of no LOG_PID on older releases. It is force enabled on head...

Sat, Apr 4, 3:42 PM

Fri, Apr 3

bdrewery updated the test plan for D24286: Restore local kernel "prog" filtering lost in r332099..
Fri, Apr 3, 11:39 PM
bdrewery created D24286: Restore local kernel "prog" filtering lost in r332099..
Fri, Apr 3, 11:38 PM

Tue, Mar 31

bdrewery committed rP529997: MFH: r529993.
MFH: r529993
Tue, Mar 31, 5:46 PM
bdrewery committed rP529995: MFH: r529134.
MFH: r529134
Tue, Mar 31, 5:43 PM
bdrewery committed rP529994: MFH: r529125.
MFH: r529125
Tue, Mar 31, 5:42 PM
bdrewery committed rP529993: - Fix runtime for gcc rpath. [1].
- Fix runtime for gcc rpath. [1]
Tue, Mar 31, 5:41 PM
bdrewery accepted D24212: Various universe fixes.
Tue, Mar 31, 5:35 PM
bdrewery committed rS359475: Remove dead code leftover from r331018..
Remove dead code leftover from r331018.
Tue, Mar 31, 1:13 AM
bdrewery accepted D24101: Allow for per directory local.init.mk.
Tue, Mar 31, 12:42 AM

Mon, Mar 30

bdrewery added a comment to D24101: Allow for per directory local.init.mk.

Can you still make -C share/mk with this?

Mon, Mar 30, 11:56 PM

Thu, Mar 26

bdrewery committed rP529219: - Update to 3.3.0-253-g531ee09f6.
- Update to 3.3.0-253-g531ee09f6
Thu, Mar 26, 8:47 PM
bdrewery committed rP529218: - Update to 3.3.4.
- Update to 3.3.4
Thu, Mar 26, 8:47 PM

Wed, Mar 25

bdrewery committed rP529136: Bump for GIDs fix in r529135.
Bump for GIDs fix in r529135
Wed, Mar 25, 10:53 PM
bdrewery committed rP529135: Add missing :.
Add missing :
Wed, Mar 25, 10:52 PM
bdrewery committed rP529134: - Unbreak by using new upstream.
- Unbreak by using new upstream
Wed, Mar 25, 10:12 PM
bdrewery added inline comments to D24183: Introduce (build|install)sysroot targets..
Wed, Mar 25, 9:38 PM
bdrewery added inline comments to D24183: Introduce (build|install)sysroot targets..
Wed, Mar 25, 9:03 PM
bdrewery added inline comments to D24183: Introduce (build|install)sysroot targets..
Wed, Mar 25, 8:50 PM
bdrewery committed rP529125: - Unbreak.
- Unbreak
Wed, Mar 25, 8:45 PM

Tue, Mar 24

bdrewery accepted D23838: Makefile.inc1: override MACHINE for native-xtools.
Tue, Mar 24, 9:47 PM
bdrewery committed rP529059: - Update to 3.3.0-253-g531ee09f6.
- Update to 3.3.0-253-g531ee09f6
Tue, Mar 24, 6:29 PM

Mon, Mar 23

bdrewery committed rP529015: - Simplify and refactor login.conf environment handling..
- Simplify and refactor login.conf environment handling.
Mon, Mar 23, 11:15 PM
bdrewery committed rP529010: Fix build without PAM option.
Fix build without PAM option
Mon, Mar 23, 9:56 PM
bdrewery committed rP528982: Remove long broken X509 patch..
Remove long broken X509 patch.
Mon, Mar 23, 5:07 PM
bdrewery committed rP528981: Fix plist for 8.2p1.
Fix plist for 8.2p1
Mon, Mar 23, 5:05 PM
bdrewery committed rP528979: - Update to 8.2p1.
- Update to 8.2p1
Mon, Mar 23, 4:54 PM

Fri, Mar 20

bdrewery accepted D22762: Add WITH_/WITHOUT_CLEAN option to replace NO_CLEAN.
Fri, Mar 20, 9:54 PM

Jan 31 2020

bdrewery committed rS357353: make all is needed to generate .depend.*.
make all is needed to generate .depend.*
Jan 31 2020, 9:08 PM
bdrewery added a comment to D23327: add mergemaster(8) deprecation notice.

Why though? Plenty of users still use it. What's the argument for forcing etcupdate over mergemaster? IMHO it's a large burden to users to convert things that use mergemaster fine to etcupdate.

Jan 31 2020, 9:04 PM

Jan 21 2020

bdrewery committed rP523738: find(1) doesn't need a glob to search for patches..
find(1) doesn't need a glob to search for patches.
Jan 21 2020, 8:36 PM

Jan 17 2020

bdrewery committed rS356827: META_MODE: Allow 'make all install' to work with filemon..
META_MODE: Allow 'make all install' to work with filemon.
Jan 17 2020, 2:30 PM

Jan 13 2020

bdrewery committed rS356699: Regen src.conf.5.
Regen src.conf.5
Jan 13 2020, 7:34 PM
bdrewery committed rS356698: MFC r355379,r355381:.
MFC r355379,r355381:
Jan 13 2020, 7:33 PM
bdrewery committed rS356697: MFC r355379,r355381:.
MFC r355379,r355381:
Jan 13 2020, 7:30 PM
bdrewery committed rS356696: MFC r355588:.
MFC r355588:
Jan 13 2020, 7:23 PM

Jan 9 2020

bdrewery committed rS356533: MFC r352261,r352262,r352265:.
MFC r352261,r352262,r352265:
Jan 9 2020, 1:17 AM
bdrewery committed rS356532: MFC r352261,r352262,r352265:.
MFC r352261,r352262,r352265:
Jan 9 2020, 1:14 AM

Jan 4 2020

bdrewery committed rS356352: lio_listio_empty_nowait_thread sometimes does *not* hang..
lio_listio_empty_nowait_thread sometimes does *not* hang.
Jan 4 2020, 7:00 PM

Dec 22 2019

bdrewery committed rP520603: Update to 8.1p1.
Update to 8.1p1
Dec 22 2019, 2:55 AM

Dec 13 2019

bdrewery added a reviewer for D21800: fix emulation name passed to linker when cross compiling: sjg.
Dec 13 2019, 5:43 PM · PowerPC
bdrewery updated subscribers of D21800: fix emulation name passed to linker when cross compiling.

FYI This fixes *DIRDEPS* not *META*. The file is misnamed.
I suggest adding @sjg to the review

Dec 13 2019, 5:43 PM · PowerPC

Dec 11 2019

bdrewery abandoned D22756: Have builtins use ck* malloc functions..

Thanks for looking.

Dec 11 2019, 7:46 PM

Dec 10 2019

bdrewery accepted D22495: Update dirdeps.mk and gendirdeps.mk.

I may disappear so I'll approve for now; my questions aren't blockers but I think there is an unrelated change that should be fixed first.

Dec 10 2019, 10:34 PM
bdrewery accepted D22494: Update depends.

I spot checked a few and they looked fine.

Dec 10 2019, 10:33 PM
bdrewery accepted D22469: Add Makefile.depend.options.

I don't like that we have auto generated and manual maintained outside of Makefile as it will get stale fast.

Dec 10 2019, 10:31 PM
bdrewery added inline comments to D22495: Update dirdeps.mk and gendirdeps.mk.
Dec 10 2019, 10:27 PM
bdrewery created D22756: Have builtins use ck* malloc functions..
Dec 10 2019, 10:01 PM
bdrewery committed rS355588: Fix WITHOUT_CLANG build..
Fix WITHOUT_CLANG build.
Dec 10 2019, 6:51 PM
bdrewery committed rP519773: - Update to 3.3.3.
- Update to 3.3.3
Dec 10 2019, 6:02 PM
bdrewery committed rP519770: - Update to 3.3.0-229-gce2011f23.
- Update to 3.3.0-229-gce2011f23
Dec 10 2019, 5:58 PM

Dec 4 2019

bdrewery committed rS355381: Use full path to sysctl(8) since /sbin is not in PATH..
Use full path to sysctl(8) since /sbin is not in PATH.
Dec 4 2019, 4:02 AM
bdrewery committed rS355379: Run make in parallel..
Run make in parallel.
Dec 4 2019, 3:45 AM

Nov 21 2019

bdrewery added a comment to D22469: Add Makefile.depend.options.

I think the comment from targets/ should be added in too.

# This file is not autogenerated - take care!
Nov 21 2019, 9:23 PM
bdrewery accepted D22486: devel/mdb: Use clang 7 as compiler on 11.x and 12.x to fix build..
Nov 21 2019, 7:31 PM

Nov 19 2019

bdrewery committed rS354859: WITH_SYSTEM_LINKER: Fix rebuilding lld every time..
WITH_SYSTEM_LINKER: Fix rebuilding lld every time.
Nov 19 2019, 4:40 PM

Nov 15 2019

bdrewery added a comment to D17002: Fix compilation with upstream clang builtin headers.

What case does this fix exactly?

Nov 15 2019, 7:30 PM

Nov 7 2019

bdrewery committed rP517011: generate-symbols: Need @dir entries if PREFIX!=LOCALBASE..
generate-symbols: Need @dir entries if PREFIX!=LOCALBASE.
Nov 7 2019, 8:49 PM

Oct 29 2019

bdrewery added inline comments to D22174: WIP: check for REINPLACE_CMD usage that doesn't do anything.
Oct 29 2019, 10:56 PM
bdrewery added inline comments to D22174: WIP: check for REINPLACE_CMD usage that doesn't do anything.
Oct 29 2019, 10:55 PM

Oct 25 2019

bdrewery added a comment to D22144: Introduce bsd.sysdir.mk to consolidate looking for the kernel..
In D22144#484006, @jhb wrote:

I guess the extra directories don't hurt. I'm less certain about the implications of the missing checks for an empty KERNBUILDDIR.

Oct 25 2019, 5:25 PM

Oct 21 2019

bdrewery committed rP515139: Drop maintainership.
Drop maintainership
Oct 21 2019, 9:57 PM
bdrewery committed rP515138: Pass maintainership to author.
Pass maintainership to author
Oct 21 2019, 9:55 PM
bdrewery committed rP515134: Drop and deprecate.
Drop and deprecate
Oct 21 2019, 9:50 PM
bdrewery committed rP515132: This port really belongs to re@.
This port really belongs to re@
Oct 21 2019, 9:46 PM

Oct 19 2019

bdrewery added inline comments to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Oct 19 2019, 10:03 PM
bdrewery committed rS353771: Fix spelling of DPSRCS..
Fix spelling of DPSRCS.
Oct 19 2019, 9:44 PM
bdrewery added inline comments to D22069: Add support for hypervisor check on x86.
Oct 19 2019, 12:28 AM

Oct 18 2019

bdrewery accepted D22069: Add support for hypervisor check on x86.

I only reviewed defs.mk. Looks fine.

Oct 18 2019, 10:41 PM
bdrewery added a comment to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
In D21654#482501, @ngie wrote:
Oct 18 2019, 9:47 PM

Oct 17 2019

bdrewery committed rP514688: LICENSE check: Respect DISABLE_LICENSES..
LICENSE check: Respect DISABLE_LICENSES.
Oct 17 2019, 9:12 PM
bdrewery added a comment to D22059: Allow bsd.compat.mk to be reliably included outside Makefile.inc1..
In D22059#482035, @imp wrote:

The question is, do we need them to be TARGET_* in this makefile.inc1 usage?
I kinda think it does. Checking into *that* detail...

Oct 17 2019, 7:57 PM
bdrewery accepted D22057: always add standard kernel configuration include path.
Oct 17 2019, 7:55 PM
bdrewery added a comment to D22057: always add standard kernel configuration include path.

I'd be inclined to explicitly spell it as -I ${KRNLCONFDIR} instead of -I., and then we later rename KRNLCONFDIR to make it more clear. We can't quickly change the cd, at least, because:

Oct 17 2019, 12:42 AM

Oct 16 2019

bdrewery added a comment to D22057: always add standard kernel configuration include path.
In D22057#481900, @avg wrote:

I don't have answers to your questions, sorry.
And I did not intend for the review to center around KRNLCONFDIR vs KERNCONFDIR.
I just want to be able to do what this change allows me to do.
That is, I want to be able to include files from both directories.

Oct 16 2019, 10:22 PM
bdrewery added a comment to D22057: always add standard kernel configuration include path.
In D22057#481764, @avg wrote:

Just a note, KRNLCONFDIR is the standard location (derived from TARGET) and KERNCONFDIR is the actual, possibly overridden, location.

Sigh. Why. These appear to be the same at quick glance.

Oct 16 2019, 7:40 PM
bdrewery added a comment to D22057: always add standard kernel configuration include path.
In D22057#481764, @avg wrote:

Just a note, KRNLCONFDIR is the standard location (derived from TARGET) and KERNCONFDIR is the actual, possibly overridden, location.

Oct 16 2019, 7:34 PM
bdrewery accepted D22059: Allow bsd.compat.mk to be reliably included outside Makefile.inc1..

Oops sorry for missing this before. TARGET_ are only useful in Makefile.inc1.

Oct 16 2019, 7:26 PM

Oct 15 2019

bdrewery added a comment to D22023: Optionally build/link programs against the compat ABI..

We have use for this at work as well for FreeBSD amd64/32 ABI compat testing since we have our own ABI. Though we just use FreeBSD 10 dist files for the purpose this feature is still nice.

Oct 15 2019, 6:10 PM
bdrewery accepted D22023: Optionally build/link programs against the compat ABI..

This is great!

Oct 15 2019, 6:07 PM

Oct 10 2019

bdrewery committed rP514247: - Add compat for NOCCACHE -> NO_CCACHE.
- Add compat for NOCCACHE -> NO_CCACHE
Oct 10 2019, 8:10 PM
bdrewery committed rP514246: - Add a CCACHE_BIN variable for simplified use where needed..
- Add a CCACHE_BIN variable for simplified use where needed.
Oct 10 2019, 8:06 PM
bdrewery committed rP514245: - Respect NOCCACHE.
- Respect NOCCACHE
Oct 10 2019, 8:04 PM

Oct 9 2019

bdrewery added a comment to D21775: (WIP) Rewrite makesyscalls.sh in Lua.

I don't know lua yet so cannot review most of this. But I'm OK with expanding lua usage. One "regression" I see is that move from a heredoc to a ton of write_line lines. Can lua not continue a string on the next line? Or maybe we should have some kind of template file instead.

Oct 9 2019, 4:28 PM

Sep 25 2019

bdrewery added inline comments to D21775: (WIP) Rewrite makesyscalls.sh in Lua.
Sep 25 2019, 10:27 PM
bdrewery added a comment to D21775: (WIP) Rewrite makesyscalls.sh in Lua.

I'm planning to make the syscall files generate *during the build*. It will need to happen quite early. Is lua already an early bootstrap tool?

Sep 25 2019, 10:21 PM

Sep 19 2019

bdrewery accepted D21717: Make it clear that a port's dependencies should not be minimal..

I like it. But it still comes down to a bikeshed/opinion. Anyway it's a good guidance.

Sep 19 2019, 4:46 PM

Sep 16 2019

bdrewery added a comment to D21468: Overlay support for the ports tree.
Sep 16 2019, 7:47 PM
bdrewery added a comment to D21468: Overlay support for the ports tree.
~/svn/ports/databases/mysql56-client # grep MASTERDIR Makefile
MASTERDIR=      ${.CURDIR}/../mysql56-server
EXTRA_PATCHES+= ${MASTERDIR}/files/patch-PR225888.diff
.include "${MASTERDIR}/Makefile"
Sep 16 2019, 7:39 PM
bdrewery added inline comments to D21654: Upgrade devel/py-mock from 2.0.0 to 3.0.5 and fix "make test" target.
Sep 16 2019, 7:17 PM

Sep 12 2019

bdrewery committed rS352265: mtree -O: Fix not descending on hash collisions.
mtree -O: Fix not descending on hash collisions
Sep 12 2019, 8:46 PM
bdrewery committed rS352262: mtree -c: Fix username logic when getlogin(3) fails..
mtree -c: Fix username logic when getlogin(3) fails.
Sep 12 2019, 6:52 PM
bdrewery committed rS352261: mtree: Fix -f -f not considering type changes..
mtree: Fix -f -f not considering type changes.
Sep 12 2019, 6:45 PM
bdrewery closed D21623: mtree: Fix -f -f not considering type changes..
Sep 12 2019, 6:45 PM
bdrewery created D21623: mtree: Fix -f -f not considering type changes..
Sep 12 2019, 6:42 PM

Sep 5 2019

bdrewery committed rS351895: MFC r349005:.
MFC r349005:
Sep 5 2019, 8:39 PM
bdrewery committed rS351894: MFC r349005:.
MFC r349005:
Sep 5 2019, 8:39 PM
bdrewery committed rS351893: MFC r347458:.
MFC r347458:
Sep 5 2019, 8:38 PM
bdrewery committed rS351892: MFC r347458,r348975,r348976:.
MFC r347458,r348975,r348976:
Sep 5 2019, 8:31 PM
bdrewery committed rS351891: MFC r339635,r350301,r350327,r351151:.
MFC r339635,r350301,r350327,r351151:
Sep 5 2019, 8:28 PM