Very nice. Thank you!

The here-document shall be treated as a single word that begins after the next <newline>

https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_07_04

Looks good.

• test feedback
• avoid races in read11.0 test

• add braces around ungetc loop

In D31687#714822, @kib wrote:

I believe stdio is not supposed to work (correctly) with non-blocking file descriptors. I do not object against attempts to make part of it work regardless, but I am not sure it is possible without making it all functional.

Address feedback

• Reset errno before __srefill as it may return EOF without setting it.
• Destaircase
• Handle (malloc failing) EOF error from __ungetc

• Make failure of the partner process less prominent in kyua output

By the way it does not build with -DNO_HISTORY.

/usr/src/bin/sh/histedit.c:703:13: error: unknown type name 'EditLine'
sh_complete(EditLine *sel, int ch __unused)
            ^
/usr/src/bin/sh/histedit.c:705:24: error: implicit declaration of function 'fn_complete2' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        return (unsigned char)fn_complete2(sel, NULL, sh_matches,
                              ^
/usr/src/bin/sh/histedit.c:705:24: note: did you mean 'sh_complete'?
/usr/src/bin/sh/histedit.c:703:1: note: 'sh_complete' declared here
sh_complete(EditLine *sel, int ch __unused)
^
/usr/src/bin/sh/histedit.c:707:35: error: use of undeclared identifier 'FN_QUOTE_MATCH'
                NULL, &((int) {0}), NULL, NULL, FN_QUOTE_MATCH);
                                                ^
3 errors generated.
*** [histedit.o] Error code 1

3 months later I realized why my zsh history file keeps being truncated. Simply running sh and exiting does it. How am I supposed to avoid sh blowing away $HISTFILE when zsh uses that same var name along with HISTSIZE?

In D30239#710984, @gjb wrote:

I understand that people want to just chroot /some/path make -C myport but that's not a sufficient build environment setup for ports where there are 30k+ random 3rd party things that may run uname. Yes your port may be special but the common case is not your port.

I've added a foot shooter in https://cgit.freebsd.org/ports/commit/?id=154492dd1f1d8c9a8f9c283f830a737c96e64a10

Doh. Thanks for testing and fixing.

In D31327#705894, @cem wrote:

This would only happen if you have multiple competing dhcp servers on a subnet, right? Edit: not dhcp, oops. Still, kind of surprising we’re getting multiple ARP responses?

• initialize buf

• Handle dumpon /dev/null as well.

• Address feedback

• Switch to using fork rather than casper

In D31266#704377, @markj wrote:

I really wish we had a sysctlfd which allowed one to pre-"open" a sysctl like we are doing here with /dev/netdump...

• capcas isn't needed unless -v is given

• Fix -v without -k
• Properly load casper
• Fallback to proper capability mode if casper is not present