bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (197 w, 6 d)

Recent Activity

Today

bdrewery committed rP462750: Newer versions (rust-nightly 2018-02-19) pack multiple .o files into.
Newer versions (rust-nightly 2018-02-19) pack multiple .o files into
Fri, Feb 23, 10:14 PM

Yesterday

bdrewery committed rP462560: Fix jail cleanup waiting too long on HTML JSON process to exit.
Fix jail cleanup waiting too long on HTML JSON process to exit
Thu, Feb 22, 5:53 AM

Wed, Feb 21

bdrewery committed rP462548: Use https for fetching bootstrap packages.
Use https for fetching bootstrap packages
Wed, Feb 21, 11:27 PM
bdrewery committed rP462546: PORT_LLVM was removed in lang/rust.
PORT_LLVM was removed in lang/rust
Wed, Feb 21, 9:58 PM
bdrewery committed rP462544: Remove leftover debugging.
Remove leftover debugging
Wed, Feb 21, 9:27 PM

Tue, Feb 20

bdrewery committed rP462464: Fix RANDOMIZE_MASTER_SITES..
Fix RANDOMIZE_MASTER_SITES.
Tue, Feb 20, 10:58 PM
bdrewery committed rP462462: Reduce fstat(2) calls for SCRIPTDIR/* scripts..
Reduce fstat(2) calls for SCRIPTDIR/* scripts.
Tue, Feb 20, 10:45 PM
bdrewery committed rP462459: Remove debugging.
Remove debugging
Tue, Feb 20, 10:26 PM
bdrewery committed rP462458: Rework r462455: soeliminate never made it to a release, was only in 11-CURRENT..
Rework r462455: soeliminate never made it to a release, was only in 11-CURRENT.
Tue, Feb 20, 10:25 PM
bdrewery committed rP462455: Avoid fstat(/usr/bin/soeliminate) for every port when building INDEX..
Avoid fstat(/usr/bin/soeliminate) for every port when building INDEX.
Tue, Feb 20, 10:10 PM
bdrewery created D14455: Avoid a sysctl for every file loaded..
Tue, Feb 20, 10:05 PM
bdrewery committed rS329679: Properly lookup values if they were empty..
Properly lookup values if they were empty.
Tue, Feb 20, 10:03 PM
bdrewery committed rS329678: Only lookup SVN once and rename to SVN_CMD..
Only lookup SVN once and rename to SVN_CMD.
Tue, Feb 20, 10:03 PM
bdrewery committed rS329677: Avoid looking up VCS_REVISION for every sub-make call to Makefile.inc1..
Avoid looking up VCS_REVISION for every sub-make call to Makefile.inc1.
Tue, Feb 20, 9:53 PM
bdrewery committed rS329676: Move SVNVERSION_CMD into the one place that uses it..
Move SVNVERSION_CMD into the one place that uses it.
Tue, Feb 20, 9:48 PM

Wed, Feb 14

bdrewery committed rS329271: nanosleep(2): Fix bogus incrementing of rmtp by tc_tick_sbt on [EINTR]..
nanosleep(2): Fix bogus incrementing of rmtp by tc_tick_sbt on [EINTR].
Wed, Feb 14, 6:44 PM
bdrewery closed D14362: nanosleep(2): Fix bogus incrementing of rmtp by tc_tick_sbt on [EINTR]..
Wed, Feb 14, 6:44 PM
bdrewery added inline comments to D14362: nanosleep(2): Fix bogus incrementing of rmtp by tc_tick_sbt on [EINTR]..
Wed, Feb 14, 5:15 PM

Tue, Feb 13

bdrewery updated the test plan for D14362: nanosleep(2): Fix bogus incrementing of rmtp by tc_tick_sbt on [EINTR]..
Tue, Feb 13, 10:34 PM
bdrewery updated the diff for D14362: nanosleep(2): Fix bogus incrementing of rmtp by tc_tick_sbt on [EINTR]..

Remove unneeded leftover debugging

Tue, Feb 13, 10:32 PM
bdrewery created D14362: nanosleep(2): Fix bogus incrementing of rmtp by tc_tick_sbt on [EINTR]..
Tue, Feb 13, 10:30 PM
bdrewery added a comment to D14143: Build PORTS_MODULES against staged system makefiles, remove MK_AUTO_OBJ/MKOBJDIR.

I fixed the problem differently in r329232

Tue, Feb 13, 5:58 PM
bdrewery committed rS329232: ports modules: Don't leak AUTO_OBJ changes into the port builds..
ports modules: Don't leak AUTO_OBJ changes into the port builds.
Tue, Feb 13, 5:51 PM
bdrewery committed rS329221: Allow overriding VTABSIZE at compile-time..
Allow overriding VTABSIZE at compile-time.
Tue, Feb 13, 4:49 PM
bdrewery closed D14339: Allow overriding VTABSIZE at compile-time..
Tue, Feb 13, 4:49 PM
bdrewery committed rP461685: HTML: Hide harmless shared lock failures.
HTML: Hide harmless shared lock failures
Tue, Feb 13, 4:57 AM

Mon, Feb 12

bdrewery created D14339: Allow overriding VTABSIZE at compile-time..
Mon, Feb 12, 11:02 PM

Fri, Feb 9

bdrewery added a comment to D14143: Build PORTS_MODULES against staged system makefiles, remove MK_AUTO_OBJ/MKOBJDIR.

Which port inspired the need for D13053 due to the LDADD/LIBADD problem?
I cannot recreate the issue being reported on current@. I'm still not fond of staging file like this as it is a ~4th way of system files being read. I'd rather go the other direction and always install everything.
Anyway, since I cannot recreate the newly reported issue I want to look at the port you ran into a problem with and see if I can rework D13053.

Fri, Feb 9, 11:38 PM

Thu, Feb 8

bdrewery committed rP461196: Fix editors/vim-tiny hanging on reading stdin during generate-plist..
Fix editors/vim-tiny hanging on reading stdin during generate-plist.
Thu, Feb 8, 5:52 AM

Wed, Feb 7

bdrewery accepted D14242: Enable kernel retpoline support.
Wed, Feb 7, 11:07 PM

Tue, Feb 6

bdrewery committed rP461108: MFH: r461107.
MFH: r461107
Tue, Feb 6, 9:06 PM
bdrewery committed rP461107: Remove blank CATEGORIES which yields a leading space ' www'..
Remove blank CATEGORIES which yields a leading space ' www'.
Tue, Feb 6, 9:06 PM
bdrewery committed rP461104: MFH: r461103.
MFH: r461103
Tue, Feb 6, 8:49 PM
bdrewery committed rP461103: Remove leading newline to FLAVORS..
Remove leading newline to FLAVORS.
Tue, Feb 6, 8:49 PM

Mon, Feb 5

bdrewery accepted D14207: Update ftp/netdumpd to 20180205..
Mon, Feb 5, 6:42 PM

Sun, Feb 4

bdrewery added a comment to D14194: Mk/bsd.sites.mk should use HTTPS whenever possible.

One problem with a change like this is that it prevents most proxies from being able to cache the files for 'privacy'. It's still obvious a connection is made to these mirrors, just not which file is being fetched. Does that really matter?

Sun, Feb 4, 8:53 PM

Fri, Feb 2

bdrewery committed rS328807: MFC r322894:.
MFC r322894:
Fri, Feb 2, 9:00 PM
bdrewery requested changes to D14170: Initial changes to Makefile.inc1 to allow crossbuilding on Linux and Mac.

Give me some time to look over this please. It conflicts majorly with some work I've been doing to build the toolchain *once* for make universe.

Fri, Feb 2, 6:38 PM
bdrewery requested changes to D14166: crossbuild: handle bmake and uname reporting x86_64 instead of amd64.
Fri, Feb 2, 6:33 PM
bdrewery committed rP460723: - bulk: Fix skipping failed packages..
- bulk: Fix skipping failed packages.
Fri, Feb 2, 6:25 PM
bdrewery committed rP460721: Minor bug with skipped packages found that is being fixed.
Minor bug with skipped packages found that is being fixed
Fri, Feb 2, 6:09 PM
bdrewery committed rP460720: - Update to 3.2.4-148-g1f555127.
- Update to 3.2.4-148-g1f555127
Fri, Feb 2, 6:05 PM

Thu, Feb 1

bdrewery committed rP460634: MFH: r459203.
MFH: r459203
Thu, Feb 1, 9:01 PM

Wed, Jan 31

bdrewery committed rP460548: MFH: r459752.
MFH: r459752
Wed, Jan 31, 11:44 PM
bdrewery committed rP460547: MFH: r459855 r460136 r460317.
MFH: r459855 r460136 r460317
Wed, Jan 31, 11:33 PM
bdrewery added a comment to D14143: Build PORTS_MODULES against staged system makefiles, remove MK_AUTO_OBJ/MKOBJDIR.

Is this fixing something? It's adding more complexity.

Wed, Jan 31, 11:23 PM

Tue, Jan 30

bdrewery accepted D14064: Change the installer default to not install ports.

+1 ports -1 lib32

Tue, Jan 30, 2:03 AM

Mon, Jan 29

bdrewery committed rP460327: Update to 3.2.4-119-g0da10c68.
Update to 3.2.4-119-g0da10c68
Mon, Jan 29, 7:39 PM
bdrewery committed rS328560: Don't use an .OBJDIR for 'make sysent'..
Don't use an .OBJDIR for 'make sysent'.
Mon, Jan 29, 7:14 PM

Sat, Jan 27

bdrewery committed rP460065: Try to fix with Clang 6.
Try to fix with Clang 6
Sat, Jan 27, 12:34 AM

Thu, Jan 25

bdrewery committed rP459961: MFH: r459958 r459959 r459960.
MFH: r459958 r459959 r459960
Thu, Jan 25, 9:13 PM
bdrewery committed rP459960: Fix some other lint findings.
Fix some other lint findings
Thu, Jan 25, 9:12 PM
bdrewery committed rP459959: Remove duplicate entries found by updated MOVEDlint.awk in r459958.
Remove duplicate entries found by updated MOVEDlint.awk in r459958
Thu, Jan 25, 9:04 PM
bdrewery committed rP459958: Show errors for duplicate source entries..
Show errors for duplicate source entries.
Thu, Jan 25, 8:56 PM
bdrewery committed rP459952: Attempt to fix with clang 6.
Attempt to fix with clang 6
Thu, Jan 25, 5:41 PM
bdrewery committed rP459907: MFH: r459906.
MFH: r459906
Thu, Jan 25, 6:11 AM
bdrewery committed rP459906: Restore DTraceToolkit from r454702..
Restore DTraceToolkit from r454702.
Thu, Jan 25, 6:08 AM
bdrewery added a comment to D13798: Delete the leftover ${WRKSRC}/.metadir directory when 'make install' fails for any reason.

I've run into this bug many times before. Thank you for bringing this up Yuri.

In D13798#294776, @yuri wrote:

These files do not need root permissions. I suggest we fix THAT.

Once the make install command runs as root, it creates them with root credentials.

This begs the question if create-manifest really needs to be in _INSTALL_SUSEQ (as part of fake-pkg) or if it can simply be in _INSTALL_SEQ?

Thu, Jan 25, 2:02 AM

Jan 24 2018

bdrewery committed rP459889: - Provide a compatibility cppunit-config..
- Provide a compatibility cppunit-config.
Jan 24 2018, 8:59 PM
bdrewery accepted D13053: Remove MAKEFLAGS and MAKESYSPATH from env passed to PORTS_MODULES.
Jan 24 2018, 8:45 PM
bdrewery added a comment to D13953: Do not enable options that do not exist..

I'd only be ok with this after proof is posted that nothing is referring to ${PORT_OPTIONS:MDOCS} or <target>-DOCS-* without the _DOCS_ option in the list.

Jan 24 2018, 8:41 PM
bdrewery accepted D13940: Bug 225159 - `make installkernel’ should display a “completed” message if done.

Looks fine, but what about installworld?

Jan 24 2018, 8:38 PM
bdrewery accepted D13937: Don't hardcode /usr/bin as the path for mktemp in build tools.
Jan 24 2018, 8:34 PM
bdrewery committed rP459887: Update to 3.3.5.
Update to 3.3.5
Jan 24 2018, 8:16 PM
bdrewery added a comment to D13798: Delete the leftover ${WRKSRC}/.metadir directory when 'make install' fails for any reason.

These files do not need root permissions. I suggest we fix THAT.

Jan 24 2018, 7:25 PM
bdrewery committed rP459886: Drop maintainership.
Drop maintainership
Jan 24 2018, 7:23 PM
bdrewery committed rP459885: - Update to 0.12.
- Update to 0.12
Jan 24 2018, 7:23 PM
bdrewery committed rP459884: - Update to 2.0.2..
- Update to 2.0.2.
Jan 24 2018, 7:10 PM
bdrewery added a comment to D13622: Allow use of .WAIT in the LOCAL_DIRS and LOCAL_LIB_DIRS lists..

Nice one, thanks.

Jan 24 2018, 7:00 PM
bdrewery committed rP459883: Fix build with clang 6..
Fix build with clang 6.
Jan 24 2018, 6:58 PM
bdrewery abandoned D13535: Add flavor support to depends.sh and make use in *-depends-list targets..
Jan 24 2018, 6:55 PM
bdrewery commandeered D13535: Add flavor support to depends.sh and make use in *-depends-list targets..

I committed something like this in Pr459882. You can pass -DDEPENDS_SHOW_FLAVOR to make *-depends* to get the flavor output as well.

Jan 24 2018, 6:55 PM
bdrewery committed rP459882: Allow passing -DDEPENDS_SHOW_FLAVOR to list flavors for dependency lists..
Allow passing -DDEPENDS_SHOW_FLAVOR to list flavors for dependency lists.
Jan 24 2018, 6:55 PM
bdrewery accepted D10855: Add support to passing directories to EXTRA_PATCHES..
Jan 24 2018, 6:38 PM
bdrewery committed rP459852: Update to 1.14.0.
Update to 1.14.0
Jan 24 2018, 6:29 PM
bdrewery committed rS328348: test-system-compiler: Display X_ variants for compiler/linker..
test-system-compiler: Display X_ variants for compiler/linker.
Jan 24 2018, 6:09 PM
bdrewery committed rS328347: X_COMPILER_* may not be defined..
X_COMPILER_* may not be defined.
Jan 24 2018, 6:08 PM
bdrewery abandoned D13317: Fix make package-depends-list.
Jan 24 2018, 6:01 PM
bdrewery commandeered D13317: Fix make package-depends-list.

Fixed in rP458041. Sorry I had missed this.

Jan 24 2018, 6:01 PM
bdrewery committed rP459807: This apparently links libunwind directly..
This apparently links libunwind directly.
Jan 24 2018, 12:55 AM

Jan 22 2018

bdrewery committed rP459702: Fix conflict line.
Fix conflict line
Jan 22 2018, 9:12 PM
bdrewery committed rP459701: Update to latest e55f535b589fb2df4e65e51482e29337b564b756 which fixes.
Update to latest e55f535b589fb2df4e65e51482e29337b564b756 which fixes
Jan 22 2018, 9:12 PM

Jan 19 2018

bdrewery accepted D13976: Update mdb port with various fixes..
Jan 19 2018, 1:21 AM

Jan 18 2018

bdrewery committed rP459380: - Properly support selecting BE from boot menu..
- Properly support selecting BE from boot menu.
Jan 18 2018, 9:12 PM
bdrewery committed rP459373: Bring in upstream fix 25a066def7cddd0f for manpage indentation.
Bring in upstream fix 25a066def7cddd0f for manpage indentation
Jan 18 2018, 8:22 PM

Jan 17 2018

bdrewery added a comment to D13911: `make buildworld' should display the build time in seconds.

You can also just record the time the build starts with something like this:

.if !defined(_BUILDWORLD_START)
_BUILDWORLD_START!= date +%s
.export _BUILDWORLD_START
.endif

Then compare its value in buildworld_epilogue, no tmpfile needed.

Jan 17 2018, 6:17 PM · Contributor Reviews (base)

Jan 16 2018

bdrewery committed rP459203: Upgrade to 3.2.4.
Upgrade to 3.2.4
Jan 16 2018, 7:11 PM

Jan 12 2018

bdrewery committed rS327892: Ensure MK_LDD for bootstrap-tools matches MK_LLD_BOOTSTRAP..
Ensure MK_LDD for bootstrap-tools matches MK_LLD_BOOTSTRAP.
Jan 12 2018, 8:40 PM
bdrewery added a comment to D7338: Disconnect objdump from the build.

I really like this tool but you're right, we can just use the package.

Jan 12 2018, 5:24 AM
bdrewery added a comment to D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Hello! I post here because in the forums they say I should report here.

Yesterday I tried microcode update oneshot. It just put out an meaningless message about microcode updated. There was no message in /var/log/messages.

x86info hangs when run as root.
When run as user, it gives incorrect information, stating the processor (X5680) being a 3-core processor with hyperthreading. But, it is a 6core, and hyperthreading is turned off via HP Z800 BIOS (to avoid thrashing).

Did devcpu-data fsck up my cpu?

Jan 12 2018, 1:28 AM
bdrewery committed rS327858: Add a hack to disable AUTO_OBJ for 'old style' kernel builds..
Add a hack to disable AUTO_OBJ for 'old style' kernel builds.
Jan 12 2018, 1:10 AM
bdrewery committed rS327857: Cache LINKER_FEATURES to fix the wrong ones being used..
Cache LINKER_FEATURES to fix the wrong ones being used.
Jan 12 2018, 1:09 AM

Jan 11 2018

bdrewery committed rS327847: MFC r284406:.
MFC r284406:
Jan 11 2018, 9:31 PM

Jan 10 2018

bdrewery committed rS327797: MFC r289410:.
MFC r289410:
Jan 10 2018, 9:59 PM
bdrewery accepted D13832: sysutils/devcpu-data Steal ubuntu's AMD microcode update file..

Approved for commit and skipping maintainer

Jan 10 2018, 8:20 PM

Jan 9 2018

bdrewery added inline comments to D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Jan 9 2018, 9:14 PM
bdrewery requested changes to D13815: sysutils/devcpu-data Update Intel Microcode release to 20180108.
Jan 9 2018, 9:13 PM
bdrewery committed rS327740: Bump version for r327597 adding cpucontrol -e support.
Bump version for r327597 adding cpucontrol -e support
Jan 9 2018, 9:13 PM

Jan 8 2018

bdrewery added a comment to D13797: PTI for amd64..
In D13797#289001, @imp wrote:

PTI means what?
Also, looks like this is unconditionally enabled unless the tunable is false. There's talk of doing things automatically based on CPU type and vendor elsewhere.

Jan 8 2018, 9:23 PM
bdrewery committed rP458395: MFH: r458394.
MFH: r458394
Jan 8 2018, 12:25 AM