bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (184 w, 4 d)

Recent Activity

Sat, Nov 18

bdrewery committed rS325986: Remove unneeded special case for .OBJDIR=.CURDIR..
Remove unneeded special case for .OBJDIR=.CURDIR.
Sat, Nov 18, 9:27 PM
bdrewery committed rS325975: Evaluate options after including src-env.conf and before Makefile.sys.inc..
Evaluate options after including src-env.conf and before Makefile.sys.inc.
Sat, Nov 18, 8:11 PM
bdrewery committed rS325974: Fix top-level targets with read-only OBJDIR..
Fix top-level targets with read-only OBJDIR.
Sat, Nov 18, 8:01 PM
bdrewery committed rS325973: Move top-level AUTO_OBJ logic to Makefile.sys.inc..
Move top-level AUTO_OBJ logic to Makefile.sys.inc.
Sat, Nov 18, 8:01 PM
bdrewery committed rS325971: Fix PORTS_MODULES+'make reinstallkernel' trying to run bogus 'make redeinstall'..
Fix PORTS_MODULES+'make reinstallkernel' trying to run bogus 'make redeinstall'.
Sat, Nov 18, 8:01 PM
bdrewery committed rS325972: Include Makefile.sys.inc if possible for top-level only..
Include Makefile.sys.inc if possible for top-level only.
Sat, Nov 18, 8:01 PM
bdrewery committed rS325970: Fix 'make -n' for {reinstall,distribute}kernel..
Fix 'make -n' for {reinstall,distribute}kernel.
Sat, Nov 18, 8:01 PM

Fri, Nov 17

bdrewery committed rS325955: Fix 'local' to not look in the source tree for the file..
Fix 'local' to not look in the source tree for the file.
Fri, Nov 17, 6:34 PM
bdrewery closed D13125: Fix 'local' to not look in the source tree for the file..
Fri, Nov 17, 6:34 PM
bdrewery accepted D13124: Remove build system support for lint..

Next task may be removing -DLINT support in source files like:

usr.sbin/cron/cron/cron.c:#if !defined(lint) && !defined(LINT)
usr.sbin/cron/cron/cron.h:# if !defined(LINT) && !defined(lint)
usr.sbin/cron/cron/database.c:#if !defined(lint) && !defined(LINT)
Fri, Nov 17, 4:56 AM
bdrewery added a comment to D13125: Fix 'local' to not look in the source tree for the file..

This has a minor conflict with your D13124 change.

Fri, Nov 17, 3:25 AM
bdrewery created D13125: Fix 'local' to not look in the source tree for the file..
Fri, Nov 17, 3:24 AM
bdrewery requested changes to D13124: Remove build system support for lint..

These are still here too:

share/mk/bsd.subdir.mk:         installfiles installincludes print-dir realinstall lint \
share/mk/bsd.sys.mk:            installincludes lint obj objlink objs objwarn \
Fri, Nov 17, 12:25 AM

Thu, Nov 16

bdrewery committed rP454336: MFH: r454266 r454332.
MFH: r454266 r454332
Thu, Nov 16, 8:21 PM
bdrewery committed rP454332: Follow-up r454266: Sort and remove duplicates for [DE]SELECTED_OPTIONS..
Follow-up r454266: Sort and remove duplicates for [DE]SELECTED_OPTIONS.
Thu, Nov 16, 7:41 PM

Wed, Nov 15

bdrewery committed rP454266: Fix [DE]SELECTED_OPTIONS to lazily evaluate as late as possible..
Fix [DE]SELECTED_OPTIONS to lazily evaluate as late as possible.
Wed, Nov 15, 7:14 PM
bdrewery closed D13092: Fix [DE]SELECTED_OPTIONS to lazily evaluate..
Wed, Nov 15, 7:14 PM
bdrewery added a comment to D13092: Fix [DE]SELECTED_OPTIONS to lazily evaluate..
In D13092#272310, @sjg wrote:

:@ rocks

Wed, Nov 15, 12:36 AM

Tue, Nov 14

bdrewery committed rP454220: Note poudriere-options -p issue..
Note poudriere-options -p issue.
Tue, Nov 14, 11:14 PM
bdrewery created D13092: Fix [DE]SELECTED_OPTIONS to lazily evaluate..
Tue, Nov 14, 7:37 PM

Mon, Nov 13

bdrewery added a comment to D13053: Remove MAKEFLAGS and MAKESYSPATH from env passed to PORTS_MODULES.

I think removing MAKEFLAGS may be too much. I think we can just add MAKESYSPATH=/usr/share/mk to the environment and should also set _WITHOUT_SRCCONF=yes.

Mon, Nov 13, 8:59 PM
bdrewery committed rS325776: Rework r325568 so all 'make LINT' targets work..
Rework r325568 so all 'make LINT' targets work.
Mon, Nov 13, 8:49 PM

Sat, Nov 11

bdrewery committed rP453981: Release 3.2.0..
Release 3.2.0.
Sat, Nov 11, 5:19 PM
bdrewery committed rP453949: Update to 3.0-2600-g5d5671f7.
Update to 3.0-2600-g5d5671f7
Sat, Nov 11, 1:45 AM
bdrewery committed rS325700: DIRDEPS_BUILD: Fix after r325417..
DIRDEPS_BUILD: Fix after r325417.
Sat, Nov 11, 1:11 AM
bdrewery committed rS325699: Don't work out of a TARGET. directory if TARGET_ARCH is not defined..
Don't work out of a TARGET. directory if TARGET_ARCH is not defined.
Sat, Nov 11, 1:11 AM
bdrewery committed rS325697: AUTO_OBJ: Disable in non-build targets..
AUTO_OBJ: Disable in non-build targets.
Sat, Nov 11, 1:11 AM
bdrewery committed rS325698: META_MODE: Avoid some logic if disabled and allow enabling with make argument..
META_MODE: Avoid some logic if disabled and allow enabling with make argument.
Sat, Nov 11, 1:11 AM
bdrewery committed rS325696: Handle MAKEOBJDIRPREFIX when already inside of .OBJDIR..
Handle MAKEOBJDIRPREFIX when already inside of .OBJDIR.
Sat, Nov 11, 1:10 AM
bdrewery committed rS325695: cleanworld only needs a tree walk if the expected .OBJDIR is .CURDIR..
cleanworld only needs a tree walk if the expected .OBJDIR is .CURDIR.
Sat, Nov 11, 1:10 AM

Fri, Nov 10

bdrewery added a comment to D13015: Axe xlint..
In D13015#270901, @imp wrote:

What about all of the make lint support and LINT references in Makefiles?

I'd be more careful about them. Again, that's support for running a linter over the tree vs removing THIS linter from the tree. Orthogonal, but related, problems.

OTOH, it would save a few hundred lines of code in the Makefiles, so what's not to love? I'm sure you'd love that. :)

So Great Idea, but I'm cool with that being a followup commit.

Fri, Nov 10, 11:03 PM
bdrewery committed rS325682: Remove rerelease target that was added in r38978..
Remove rerelease target that was added in r38978.
Fri, Nov 10, 9:52 PM
bdrewery added a comment to D13015: Axe xlint..

What about all of the make lint support and LINT references in Makefiles?

share/mk/bsd.README:    lint:
share/mk/bsd.README:            run lint on the source files
share/mk/bsd.README:cleandir, depend, install, lint, and tags.  For all of the directories
share/mk/bsd.README:install, lint, and tags.  It has a limited number of suffixes, consistent
share/mk/bsd.README:LINTLIBDIR  Target directory for lint libraries.
share/mk/bsd.README:    lint:
share/mk/bsd.README:            run lint on the source files.
share/mk/bsd.lib.mk:    @${ECHO} building lint library ${.TARGET}
share/mk/bsd.lib.mk:.if !target(lint)
share/mk/bsd.lib.mk:lint: ${SRCS:M*.c}
share/mk/bsd.man.mk:manlint: ${__page}lint
share/mk/bsd.man.mk:${__page}lint: ${__page}
share/mk/bsd.own.mk:# LINTLIBDIR        Base path for lint libraries. [/usr/libdata/lint]
share/mk/bsd.own.mk:LINTLIBDIR?=        /usr/libdata/lint
share/mk/bsd.prog.mk:.if !target(lint)
share/mk/bsd.prog.mk:lint: ${SRCS:M*.c}
share/mk/bsd.subdir.mk:         installfiles installincludes print-dir realinstall lint \
share/mk/bsd.sys.mk:            installincludes lint obj objlink objs objwarn \
share/mk/sys.mk:LINT            ?=      lint
Fri, Nov 10, 9:23 PM
bdrewery committed rP453930: Release brad from mentorship..
Release brad from mentorship.
Fri, Nov 10, 9:16 PM
bdrewery committed rS325679: AUTO_OBJ: Don't create .OBJDIR with 'make -n'..
AUTO_OBJ: Don't create .OBJDIR with 'make -n'.
Fri, Nov 10, 8:10 PM
bdrewery committed rS325678: Tell bsd.dep.mk which depend files to dinclude..
Tell bsd.dep.mk which depend files to dinclude.
Fri, Nov 10, 8:09 PM
bdrewery committed rS325677: Allow consuming Makefiles to add to DEPENDFILES..
Allow consuming Makefiles to add to DEPENDFILES.
Fri, Nov 10, 8:09 PM
bdrewery committed rS325676: No need to run 'make depend' with FAST_DEPEND logic in-tree..
No need to run 'make depend' with FAST_DEPEND logic in-tree.
Fri, Nov 10, 7:53 PM
bdrewery committed rS325675: AUTO_OBJ: No need to tree-walk with 'make obj' here..
AUTO_OBJ: No need to tree-walk with 'make obj' here.
Fri, Nov 10, 7:53 PM
bdrewery committed rS325674: Pass down any PROG-specific buildopts for forwarded targets..
Pass down any PROG-specific buildopts for forwarded targets.
Fri, Nov 10, 7:53 PM
bdrewery committed rS325673: native-xtools: Fix for GCC archs..
native-xtools: Fix for GCC archs.
Fri, Nov 10, 7:53 PM
bdrewery committed rS325672: Don't append TARGET.TARGET_ARCH if OBJTOP is already set..
Don't append TARGET.TARGET_ARCH if OBJTOP is already set.
Fri, Nov 10, 7:52 PM
bdrewery committed rS325634: Add some missed OBJS_SRCS_FILTER from r323637..
Add some missed OBJS_SRCS_FILTER from r323637.
Fri, Nov 10, 8:00 AM
bdrewery committed rS325633: Avoid referencing private lib names directly..
Avoid referencing private lib names directly.
Fri, Nov 10, 7:53 AM
bdrewery committed rS325632: rescue ipf: Remove hacks and link in libipf directly..
rescue ipf: Remove hacks and link in libipf directly.
Fri, Nov 10, 7:53 AM
bdrewery committed rS325631: Add support for CRUNCH_LIBS_ for specifying a lib only for 1 prog..
Add support for CRUNCH_LIBS_ for specifying a lib only for 1 prog.
Fri, Nov 10, 7:53 AM
bdrewery added a comment to D12924: Remove mailaddr(7).

I learned a lot reading this just now.

Fri, Nov 10, 7:51 AM
bdrewery committed rP453884: Update to 3.0-2592-gba53cb5b.
Update to 3.0-2592-gba53cb5b
Fri, Nov 10, 6:39 AM
bdrewery committed rP453882: Avoid running git and finding PORTSDIR/.git..
Avoid running git and finding PORTSDIR/.git.
Fri, Nov 10, 6:28 AM
bdrewery committed rS325626: Handle some .OBJDIR == .CURDIR cases..
Handle some .OBJDIR == .CURDIR cases.
Fri, Nov 10, 2:09 AM
bdrewery committed rS325627: Deal with src.conf for top-level MAKEOBJDIRPREFIX guard..
Deal with src.conf for top-level MAKEOBJDIRPREFIX guard.
Fri, Nov 10, 2:09 AM

Thu, Nov 9

bdrewery committed rS325619: Mark targets .PHONY..
Mark targets .PHONY.
Thu, Nov 9, 10:08 PM
bdrewery accepted D13019: Fix problem with "make -C /usr/ports/ search name=text".
[/usr/src] # make -C bin/sh/ -V .CURDIR
/usr/src/bin/sh
[/usr/src] # fmake -C bin/sh/ -V .CURDIR
/usr/src/bin/sh
[/usr/src] # fmake -C bin/sh//// -V .CURDIR
/usr/src/bin/sh
[/usr/src] # bmake -C bin/sh//// -V .CURDIR
/usr/src/bin/sh
Thu, Nov 9, 8:53 PM
bdrewery added a comment to D13015: Axe xlint..
In D13015#270388, @kib wrote:

Aren't they automatically re-generated by somebody else ? I did found them by grepping, and decided not to update because they are not human-editable. Am I wrong ?

Paging @sjg or @bdrewery

Looking at the history in targets/pseudo I see commits to manually chase up previously-removed components.

Thu, Nov 9, 3:50 PM
bdrewery closed D12989: AUTO_OBJ: Fix 'old style' kernel builds using wrong .OBJDIR..
Thu, Nov 9, 2:38 AM
bdrewery committed rS325570: AUTO_OBJ: Fix 'old style' kernel builds using wrong .OBJDIR..
AUTO_OBJ: Fix 'old style' kernel builds using wrong .OBJDIR.
Thu, Nov 9, 2:38 AM

Wed, Nov 8

bdrewery committed rS325568: universe: Fix creating LINT files with AUTO_OBJ..
universe: Fix creating LINT files with AUTO_OBJ.
Wed, Nov 8, 11:41 PM
bdrewery committed rS325560: META_MODE: Bmake 20171028 in r325340 simplifies the meta filename..
META_MODE: Bmake 20171028 in r325340 simplifies the meta filename.
Wed, Nov 8, 6:02 PM
bdrewery accepted D13000: Add py3-* stub ports required for the upcoming finance/electrum update to 3.0.1.

Approved by: portmgr (bdrewery)

Wed, Nov 8, 5:39 PM
bdrewery committed rS325557: AUTO_OBJ: Hide 'creating dirs' output with 'make -s'..
AUTO_OBJ: Hide 'creating dirs' output with 'make -s'.
Wed, Nov 8, 4:04 PM
bdrewery committed rS325529: AUTO_OBJ: Don't create TARGET. directories during 'make universe'..
AUTO_OBJ: Don't create TARGET. directories during 'make universe'.
Wed, Nov 8, 2:40 AM
bdrewery added a comment to D12989: AUTO_OBJ: Fix 'old style' kernel builds using wrong .OBJDIR..

Perhaps config could create a .no_obj file that we check for in src.sys.obj.mk ?

Wed, Nov 8, 2:28 AM
bdrewery created D12989: AUTO_OBJ: Fix 'old style' kernel builds using wrong .OBJDIR..
Wed, Nov 8, 2:27 AM

Tue, Nov 7

bdrewery added inline comments to D12981: Document MACHINE, MACHINE_ARCH, TARGET and TARGET_ARCH historical use and general philosphy..
Tue, Nov 7, 9:28 PM
bdrewery committed rS325520: Reenable AUTO_OBJ by default..
Reenable AUTO_OBJ by default.
Tue, Nov 7, 6:46 PM
bdrewery committed rS325493: Reapply r295227: Stop hiding link install commands..
Reapply r295227: Stop hiding link install commands.
Tue, Nov 7, 3:52 PM

Sun, Nov 5

bdrewery committed rS325457: Rework r325076: Just use the pre-existing OBJDIR..
Rework r325076: Just use the pre-existing OBJDIR.
Sun, Nov 5, 10:29 PM
bdrewery committed rS325437: Follow-up r325405: Fix assertion still for kernel module builds..
Follow-up r325405: Fix assertion still for kernel module builds.
Sun, Nov 5, 4:28 PM
bdrewery committed rS325419: Avoid trying to remove a fullpath directory in CLEANDIRS..
Avoid trying to remove a fullpath directory in CLEANDIRS.
Sun, Nov 5, 12:26 AM
bdrewery committed rS325418: AUTO_OBJ: Allow 'make cleandir obj all' combinations..
AUTO_OBJ: Allow 'make cleandir obj all' combinations.
Sun, Nov 5, 12:12 AM
bdrewery committed rS325417: Set the expected __objdir for auto.obj.mk to try..
Set the expected __objdir for auto.obj.mk to try.
Sun, Nov 5, 12:12 AM
bdrewery committed rS325416: Always try to set .OBJDIR, even if AUTO_OBJ is enabled, and fallback to .CURDIR..
Always try to set .OBJDIR, even if AUTO_OBJ is enabled, and fallback to .CURDIR.
Sun, Nov 5, 12:12 AM
bdrewery committed rS325415: Validate MAKEOBJDIR after the MAKEOBJDIRPREFIX override..
Validate MAKEOBJDIR after the MAKEOBJDIRPREFIX override.
Sun, Nov 5, 12:12 AM
bdrewery committed rS325414: AUTO_OBJ: Set .OBJDIR=.CURDIR earlier for NO_OBJ Makefiles..
AUTO_OBJ: Set .OBJDIR=.CURDIR earlier for NO_OBJ Makefiles.
Sun, Nov 5, 12:12 AM
bdrewery committed rS325413: Simplify location of bootstrap make..
Simplify location of bootstrap make.
Sun, Nov 5, 12:12 AM
bdrewery committed rS325412: Fix nested MAKEOBJDIRPREFIX breaking various release/buildworld/toolchain….
Fix nested MAKEOBJDIRPREFIX breaking various release/buildworld/toolchain…
Sun, Nov 5, 12:12 AM
bdrewery committed rS325411: Set OBJROOT/OBJTOP as make arguments. Missed in r325329..
Set OBJROOT/OBJTOP as make arguments. Missed in r325329.
Sun, Nov 5, 12:12 AM

Sat, Nov 4

bdrewery committed rS325409: MFC r318432:.
MFC r318432:
Sat, Nov 4, 10:23 PM
bdrewery committed rS325408: Follow-up r325405: Only enable assertion for in-tree src builds..
Follow-up r325405: Only enable assertion for in-tree src builds.
Sat, Nov 4, 10:00 PM
bdrewery committed rS325406: AUTO_OBJ: Revert r325351 now that the fix is in auto.obj.mk in r325404..
AUTO_OBJ: Revert r325351 now that the fix is in auto.obj.mk in r325404.
Sat, Nov 4, 9:06 PM
bdrewery committed rS325405: Add an assertion to avoid the 'rm -rf /etc' case from cleanobj fixed in r325404..
Add an assertion to avoid the 'rm -rf /etc' case from cleanobj fixed in r325404.
Sat, Nov 4, 9:05 PM
bdrewery abandoned D12952: Fallback to .OBJDIR=.CURDIR if unable to use the wanted OBJDIR..

Going to rework this a bit and trim the commit log

Sat, Nov 4, 8:30 PM
bdrewery added inline comments to D12952: Fallback to .OBJDIR=.CURDIR if unable to use the wanted OBJDIR..
Sat, Nov 4, 7:58 PM
bdrewery added inline comments to D12952: Fallback to .OBJDIR=.CURDIR if unable to use the wanted OBJDIR..
Sat, Nov 4, 7:41 PM
bdrewery created D12952: Fallback to .OBJDIR=.CURDIR if unable to use the wanted OBJDIR..
Sat, Nov 4, 7:12 PM

Fri, Nov 3

bdrewery committed rS325374: Follow-up r318105: Don't use NO_OBJ at top-level, use NO_OBJWALK..
Follow-up r318105: Don't use NO_OBJ at top-level, use NO_OBJWALK.
Fri, Nov 3, 11:22 PM
bdrewery added inline comments to D12918: Install libcasper and libcasper_random under the /lib directory..
Fri, Nov 3, 7:05 PM
bdrewery accepted D12918: Install libcasper and libcasper_random under the /lib directory..
Fri, Nov 3, 7:03 PM
bdrewery committed rS325351: AUTO_OBJ: If the wanted .OBJDIR was not used then disable the feature..
AUTO_OBJ: If the wanted .OBJDIR was not used then disable the feature.
Fri, Nov 3, 1:09 AM
bdrewery committed rS325350: Follow-up r325329: Store all WORLDTMP objects back in the same directory..
Follow-up r325329: Store all WORLDTMP objects back in the same directory.
Fri, Nov 3, 12:30 AM

Thu, Nov 2

bdrewery committed rS325348: AUTO_OBJ is unsafe at the moment as it is for some reason removing /etc with….
AUTO_OBJ is unsafe at the moment as it is for some reason removing /etc with…
Thu, Nov 2, 11:00 PM
bdrewery committed rS325347: Something is very wrong.
Something is very wrong
Thu, Nov 2, 10:23 PM
bdrewery committed rS325346: Follow-up r325342: Always ensure WORLDTMP exists..
Follow-up r325342: Always ensure WORLDTMP exists.
Thu, Nov 2, 9:58 PM
bdrewery committed rS325342: DIRDEPS_BUILD: Cleanup leftover WORLDTMP files..
DIRDEPS_BUILD: Cleanup leftover WORLDTMP files.
Thu, Nov 2, 8:45 PM
bdrewery accepted D12814: Introduce EVENTHANDLER_LIST_* and some users..
Thu, Nov 2, 8:17 PM
bdrewery accepted D12917: Casper work's only as shared library - disable building static ones..
Thu, Nov 2, 8:09 PM
bdrewery committed rS325331: Regenerate for AUTO_OBJ..
Regenerate for AUTO_OBJ.
Thu, Nov 2, 6:09 PM
bdrewery committed rS325330: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds.
Thu, Nov 2, 6:09 PM
bdrewery closed D12841: Enable AUTO_OBJ by default if the OBJDIR is writable, only for in-tree builds..
Thu, Nov 2, 6:09 PM
bdrewery committed rS325329: Reduce MAKEOBJDIRPREFIX path spam by specifying a direct objdir to use..
Reduce MAKEOBJDIRPREFIX path spam by specifying a direct objdir to use.
Thu, Nov 2, 6:09 PM