Page MenuHomeFreeBSD

bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (370 w, 6 d)

Recent Activity

Yesterday

bdrewery committed R11:25060b919809: ports-mgmt/poudriere-devel: Update to 3.3.0-738-g9839954fb (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-738-g9839954fb
Thu, Jun 17, 10:01 PM

Thu, Jun 10

bdrewery added a comment to D30239: Add ALLOW_OSVERSION_MISMATCH flag to bsd.ports.mk.

This isn't simply about host not matching the jail. It's more nuanced. The jail may not match the jail.

Does this change anything about the patch though (which in the end implements a force flag, which isn't nuanced at all)? Would you prefer a different name of the flag that emphasizes that you think this error shouldn't be ignored?

If people don't understand that I am strongly against anything like this going in. But what do I care if you shoot yourselves in the foot?

That's the very nature of providing force/override/ignore warning flags, people using them are on their own. This was raised by a couple of experienced engineers, who have their workflows disrupted by the current state of affairs.

Thu, Jun 10, 5:58 PM

Wed, Jun 9

bdrewery added inline comments to D30702: pf: use M_WAITOK where possible.
Wed, Jun 9, 5:06 PM
bdrewery accepted D30684: mk: WITH_FOO=no now generates a warning.
Wed, Jun 9, 4:39 PM
bdrewery committed R11:cc0cc8940fcf: games/py-pychess: Fix dependency lines (authored by bdrewery).
games/py-pychess: Fix dependency lines
Wed, Jun 9, 4:36 PM

Mon, Jun 7

bdrewery committed R11:9a34ad5a4907: category/port: Package name dependencies do not support globbing. (authored by bdrewery).
category/port: Package name dependencies do not support globbing.
Mon, Jun 7, 10:40 PM
bdrewery added inline comments to D30684: mk: WITH_FOO=no now generates a warning.
Mon, Jun 7, 9:30 PM

Fri, May 28

bdrewery added inline comments to D16050: Automatically run ntpd as non-root when possible..
Fri, May 28, 11:35 PM
bdrewery committed R10:55baee8cdbd9: Correct location for KTR masks. (authored by bdrewery).
Correct location for KTR masks.
Fri, May 28, 11:30 PM

Mon, May 24

bdrewery committed R11:9501a687f6e1: irc/irssi: Update to 1.2.3 (authored by lcook).
irc/irssi: Update to 1.2.3
Mon, May 24, 11:44 PM

Fri, May 21

bdrewery committed R11:4f7a0060c2ab: ports-mgmt/poudriere-devel: - Update to 3.3.0-704-g8c78cfb24 (authored by bdrewery).
ports-mgmt/poudriere-devel: - Update to 3.3.0-704-g8c78cfb24
Fri, May 21, 6:44 PM

May 13 2021

bdrewery added a comment to D30239: Add ALLOW_OSVERSION_MISMATCH flag to bsd.ports.mk.

This isn't simply about host not matching the jail. It's more nuanced. The jail may not match the jail. If people don't understand that I am strongly against anything like this going in. But what do I care if you shoot yourselves in the foot?

May 13 2021, 3:00 PM

Apr 29 2021

bdrewery accepted D29993: EFI secure boot VECTX related changes.
Apr 29 2021, 4:24 PM
bdrewery committed R11:de9fffcec89b: security/openssh-portable: Update to 8.6p1 (authored by bdrewery).
security/openssh-portable: Update to 8.6p1
Apr 29 2021, 4:07 PM

Apr 27 2021

bdrewery accepted D29993: EFI secure boot VECTX related changes.
Apr 27 2021, 7:43 PM

Apr 20 2021

bdrewery committed R11:c55e97c0f341: Another openssh version fix for CVE-2021-28041. (authored by bdrewery).
Another openssh version fix for CVE-2021-28041.
Apr 20 2021, 7:28 PM
bdrewery committed R11:50b224190720: Another openssh version fix for CVE-2021-28041. (authored by bdrewery).
Another openssh version fix for CVE-2021-28041.
Apr 20 2021, 7:28 PM
bdrewery committed R11:b93b57f8a2e1: Fix openssh version in entry for CVE-2021-28041 (authored by bdrewery).
Fix openssh version in entry for CVE-2021-28041
Apr 20 2021, 3:39 PM
bdrewery committed R11:da89336b8dd8: Fix openssh version in entry for CVE-2021-28041 (authored by bdrewery).
Fix openssh version in entry for CVE-2021-28041
Apr 20 2021, 3:39 PM

Apr 15 2021

bdrewery committed R11:6e8c572eb490: - Fix new jail and ports creation. (authored by bdrewery).
- Fix new jail and ports creation.
Apr 15 2021, 8:31 PM
bdrewery committed R11:b42828e7fd3e: - Fix new jail and ports creation. (authored by bdrewery).
- Fix new jail and ports creation.
Apr 15 2021, 3:38 PM

Mar 29 2021

bdrewery added inline comments to D10482: freebsd-update: regenerate man page database after update.
Mar 29 2021, 6:28 PM
bdrewery added inline comments to D10482: freebsd-update: regenerate man page database after update.
Mar 29 2021, 6:03 PM

Mar 19 2021

bdrewery added inline comments to D11984: Add vm_page_alloc_after().
Mar 19 2021, 4:24 PM
bdrewery committed rP568762: OpenSSH CVE-2021-28041 fixed in 8.4.p1_4,1..
OpenSSH CVE-2021-28041 fixed in 8.4.p1_4,1.
Mar 19 2021, 12:57 AM
bdrewery committed rP568761: Add limited patch for CVE-2021-28041 from upstream..
Add limited patch for CVE-2021-28041 from upstream.
Mar 19 2021, 12:57 AM

Mar 18 2021

bdrewery committed rP568757: Document OpenSSH CVE-2021-28041.
Document OpenSSH CVE-2021-28041
Mar 18 2021, 7:30 PM

Mar 17 2021

bdrewery committed R10:a771bf748f94: Remove unused obj variable missed in r354870. (authored by bdrewery).
Remove unused obj variable missed in r354870.
Mar 17 2021, 10:30 PM

Mar 11 2021

bdrewery committed R9:1a388b141def: Update my subkey signature (authored by bdrewery).
Update my subkey signature
Mar 11 2021, 5:58 AM

Mar 6 2021

bdrewery committed R10:eb8bf6bb4204: Fix 'make bmake' top-level bootstrapping. (authored by bdrewery).
Fix 'make bmake' top-level bootstrapping.
Mar 6 2021, 5:46 PM

Mar 5 2021

bdrewery accepted D29094: Only set delayed inval for procs using PTI.
Mar 5 2021, 7:06 PM

Mar 4 2021

bdrewery added inline comments to D27588: amd64 pmap: fix pcid invalidations.
Mar 4 2021, 4:32 PM

Mar 3 2021

bdrewery committed rP567257: - Update to 3.3.0-542-g8bf6e594a.
- Update to 3.3.0-542-g8bf6e594a
Mar 3 2021, 8:30 PM

Mar 1 2021

bdrewery committed rP566827: - Update to 3.3.0-540-g9f9007eb8.
- Update to 3.3.0-540-g9f9007eb8
Mar 1 2021, 8:52 AM

Feb 25 2021

bdrewery accepted D28926: Close races in vm object chain traversal for unlock.
Feb 25 2021, 6:37 PM

Feb 23 2021

bdrewery accepted D28901: buf: Fix the dirtybufthresh check.
Feb 23 2021, 6:50 PM

Feb 10 2021

bdrewery added a comment to D28564: openssh: port upgrade doc and script to git.

Ah I see D25708 now. Sorry for the spam.

Feb 10 2021, 5:58 PM
bdrewery added a comment to D28564: openssh: port upgrade doc and script to git.

I enable some stuff in the port that base wouldn't want, but I wouldn't push that stuff base.

Feb 10 2021, 5:50 PM
bdrewery added a comment to D28564: openssh: port upgrade doc and script to git.

Do you need me to help maintain the base openssh?

Feb 10 2021, 5:48 PM
bdrewery accepted D28573: fmtree: prepare for removal.

Also a Relnotes: yes somewhere noting the deprecation.

Feb 10 2021, 5:08 PM

Feb 9 2021

bdrewery added inline comments to D22770: Start implementing queue state updates using fcmpset loops. [1/5].
Feb 9 2021, 12:18 AM

Feb 8 2021

bdrewery added inline comments to D22770: Start implementing queue state updates using fcmpset loops. [1/5].
Feb 8 2021, 11:44 PM

Jan 28 2021

bdrewery closed D28375: Fix getblk() with GB_NOCREAT returning false-negatives..
Jan 28 2021, 7:25 PM
bdrewery committed R10:c926114f2ff2: Fix getblk() with GB_NOCREAT returning false-negatives. (authored by bdrewery).
Fix getblk() with GB_NOCREAT returning false-negatives.
Jan 28 2021, 7:25 PM
bdrewery added a comment to D28375: Fix getblk() with GB_NOCREAT returning false-negatives..

To be clear, everyone is ok with this being committed for now and improvements being worked on and tested for later?

Jan 28 2021, 7:10 PM

Jan 27 2021

bdrewery added inline comments to D25782: Add unlocked/SMR fast path to getblk().
Jan 27 2021, 6:06 PM
bdrewery requested review of D28375: Fix getblk() with GB_NOCREAT returning false-negatives..
Jan 27 2021, 6:06 PM

Jan 25 2021

bdrewery added a comment to D28306: nfs client: block vnode_pager_setsize() calls from nfscl_loadattrcache in nfs_write.

Thanks!

Jan 25 2021, 11:49 PM

Jan 23 2021

bdrewery added inline comments to D25782: Add unlocked/SMR fast path to getblk().
Jan 23 2021, 3:24 AM

Jan 22 2021

bdrewery added inline comments to D25782: Add unlocked/SMR fast path to getblk().
Jan 22 2021, 11:47 PM
bdrewery added a comment to D21883: Fix interface between nfsclient and vnode pager..

I think I ran into this same thing on a write (with nfs code being r358252). Do we need a similar fix in ncl_write to apply TDP2_SBPAGES? This thread has an exclusive lock on the vp.

`
#0  sched_switch (td=0xfffffea88567bb00, newtd=0xfffffe850e552b00, flags=<optimized out>) at /b/mnt/src/sys/kern/sched_ule.c:2423
#1  0xffffffff8070761b in mi_switch (flags=<optimized out>, newtd=0x0) at /b/mnt/src/sys/kern/kern_synch.c:605
#2  0xffffffff8075cd2c in sleepq_wait (wchan=<unavailable>, pri=<unavailable>) at /b/mnt/src/sys/kern/subr_sleepqueue.c:691
#3  0xffffffff80a7066a in _vm_page_busy_sleep (obj=<optimized out>, m=0xfffffe81ab46a250, pindex=<optimized out>, wmesg=0xffffffff81534b90 "vmopar", allocflags=<optimized out>, locked=<optimized out>) at /b/mnt/src/sys/vm/vm_page.c:1150
#4  0xffffffff80a710ce in vm_page_sleep_if_busy (m=<optimized out>, wmesg=<unavailable>) at /b/mnt/src/sys/vm/vm_page.c:1453
#5  0xffffffff80a6bcef in vm_object_page_remove (object=0xfffff8795dbbe990, start=<optimized out>, end=<optimized out>, options=0) at /b/mnt/src/sys/vm/vm_object.c:2140
#6  0xffffffff80a87163 in vnode_pager_setsize (vp=<optimized out>, nsize=0) at /b/mnt/src/sys/vm/vnode_pager.c:469
#7  0xffffffff80611583 in ncl_pager_setsize (vp=0xfffff8794c197b40, nsizep=<optimized out>) at /b/mnt/src/sys/fs/nfsclient/nfs_clport.c:609
#8  0xffffffff8061143d in nfscl_loadattrcache (vpp=<optimized out>, nap=<optimized out>, nvaper=0x1, stuff=<optimized out>, writeattr=<optimized out>, dontshrink=1) at /b/mnt/src/sys/fs/nfsclient/nfs_clport.c:567
#9  0xffffffff80608102 in ncl_writerpc (vp=0xfffff8794c197b40, uiop=0xfffffea889635ad8, cred=<optimized out>, iomode=0xfffffea889635b08, must_commit=0xfffffea889635b0c, called_from_strategy=1) at /b/mnt/src/sys/fs/nfsclient/nfs_clvnops.c:1498
#10 0xffffffff80615043 in ncl_doio (vp=0xfffff8794c197b40, bp=0xfffffe86f65db148, cr=<optimized out>, td=<optimized out>, called_from_strategy=-135768792) at /b/mnt/src/sys/fs/nfsclient/nfs_clbio.c:1755
#11 0xffffffff80606ec9 in nfs_strategy (ap=<optimized out>) at /b/mnt/src/sys/fs/nfsclient/nfs_clvnops.c:2735
#12 0xffffffff813665c4 in VOP_STRATEGY_APV (vop=<optimized out>, a=0xfffffea889635bc8) at vnode_if.c:2985
#13 0xffffffff807b56ac in VOP_STRATEGY (vp=<optimized out>, bp=<optimized out>) at ./vnode_if.h:1301
#14 bufstrategy (bo=<optimized out>, bp=<optimized out>) at /b/mnt/src/sys/kern/vfs_bio.c:6155
#15 0xffffffff80609e49 in bstrategy (bp=0xfffffe86f65db148) at /b/mnt/src/sys/sys/buf.h:598
#16 ncl_writebp (bp=0xfffffe86f65db148, force=<optimized out>, td=<optimized out>) at /b/mnt/src/sys/fs/nfsclient/nfs_clvnops.c:3327
#17 0xffffffff8061679b in ncl_write (ap=<optimized out>) at /b/mnt/src/sys/fs/nfsclient/nfs_clbio.c:1264
Jan 22 2021, 8:59 PM

Jan 21 2021

bdrewery added inline comments to D28254: Remove the build-tools phase from buildworld.
Jan 21 2021, 6:25 PM
bdrewery added inline comments to D28253: Remove all current uses of build-tools during buildworld.
Jan 21 2021, 6:12 PM
bdrewery requested changes to D28254: Remove the build-tools phase from buildworld.
Jan 21 2021, 5:53 PM
bdrewery requested changes to D28181: Remove mkcsmapper_static and mkesdb_static from build-tools.
Jan 21 2021, 5:49 PM
bdrewery added inline comments to D28254: Remove the build-tools phase from buildworld.
Jan 21 2021, 5:44 PM
bdrewery requested changes to D28253: Remove all current uses of build-tools during buildworld.

Please test this with WITH_META_MODE=yes and kldload filemon. make buildworld -j and make buildworld -j -DNO_CLEAN. If any .meta: lines appear about these files then it's broken. A key point of build-tools was also using *different cflags*.

Jan 21 2021, 5:32 PM

Jan 8 2021

bdrewery closed D27671: dtrace: Fix /"string" == NULL/ comparisons using an uninitialized value..
Jan 8 2021, 10:39 PM
bdrewery committed R10:f222a6b88614: dtrace: Fix /"string" == NULL/ comparisons using an uninitialized value. (authored by bdrewery).
dtrace: Fix /"string" == NULL/ comparisons using an uninitialized value.
Jan 8 2021, 10:39 PM
bdrewery closed D27648: bsd.compat.mk: Allow finding non-internal libraries.
Jan 8 2021, 10:39 PM
bdrewery committed R10:556fcdce5b44: bsd.compat.mk: Allow finding non-internal libraries (authored by bdrewery).
bsd.compat.mk: Allow finding non-internal libraries
Jan 8 2021, 10:39 PM
bdrewery closed D27643: Makefile.inc1: Avoid using release/Makefile for VERSION..
Jan 8 2021, 10:38 PM
bdrewery committed R10:44b8b2a00d7e: Makefile.inc1: Avoid using release/Makefile for VERSION. (authored by bdrewery).
Makefile.inc1: Avoid using release/Makefile for VERSION.
Jan 8 2021, 10:38 PM

Dec 19 2020

bdrewery added inline comments to D27671: dtrace: Fix /"string" == NULL/ comparisons using an uninitialized value..
Dec 19 2020, 8:58 PM

Dec 18 2020

bdrewery added inline comments to D27671: dtrace: Fix /"string" == NULL/ comparisons using an uninitialized value..
Dec 18 2020, 6:11 PM
bdrewery requested review of D27671: dtrace: Fix /"string" == NULL/ comparisons using an uninitialized value..
Dec 18 2020, 6:10 PM
bdrewery accepted D27663: rtld-libc: fix incremental build.
Dec 18 2020, 12:02 AM

Dec 16 2020

bdrewery added a comment to D27643: Makefile.inc1: Avoid using release/Makefile for VERSION..

For reference, originally introduced in rS257079

Dec 16 2020, 10:56 PM
bdrewery added a comment to D27643: Makefile.inc1: Avoid using release/Makefile for VERSION..

I'm not an expert in the build, but it LGTM. I only wonder if there ought to be a common makefile for this and release/Makefile both to include.

Dec 16 2020, 10:55 PM
bdrewery requested review of D27648: bsd.compat.mk: Allow finding non-internal libraries.
Dec 16 2020, 10:17 PM
bdrewery added inline comments to D27622: include: Delete stale symlinks using find(1) instead of a shell loop..
Dec 16 2020, 10:05 PM
bdrewery requested changes to D27622: include: Delete stale symlinks using find(1) instead of a shell loop..
Dec 16 2020, 10:03 PM
bdrewery accepted D27646: newvers.sh: Speed up git_tree_modified.
Dec 16 2020, 9:28 PM
bdrewery added inline comments to D27643: Makefile.inc1: Avoid using release/Makefile for VERSION..
Dec 16 2020, 8:56 PM
bdrewery requested review of D27643: Makefile.inc1: Avoid using release/Makefile for VERSION..
Dec 16 2020, 8:36 PM

Dec 15 2020

bdrewery committed rS368673: Revert r368523 which fixed contig allocs waiting forever..
Revert r368523 which fixed contig allocs waiting forever.
Dec 15 2020, 7:38 PM

Dec 10 2020

bdrewery closed D27508: linux_dma: Ensure proper flags pass to allocators..
Dec 10 2020, 8:45 PM
bdrewery committed rS368524: linux_dma: Ensure proper flags pass to allocators..
linux_dma: Ensure proper flags pass to allocators.
Dec 10 2020, 8:45 PM
bdrewery closed D27507: contig allocs: Don't retry forever on M_WAITOK..
Dec 10 2020, 8:45 PM
bdrewery committed rS368523: contig allocs: Don't retry forever on M_WAITOK..
contig allocs: Don't retry forever on M_WAITOK.
Dec 10 2020, 8:45 PM
bdrewery added a comment to D27507: contig allocs: Don't retry forever on M_WAITOK..

I think a dedicated iterator would be reasonable. I just wanted to avoid polluting the common case with checks needed to handle rare contig allocations.

Dec 10 2020, 5:28 PM

Dec 9 2020

bdrewery added a comment to D27508: linux_dma: Ensure proper flags pass to allocators..

Hi,

Can you explain this change a bit more?

gfp_t may contain bits which are not supported by the M_XXX flags and should be filtered away?

If you need to pass additional flags you need to update GFP_NATIVE_MASK .

--HPS

Dec 9 2020, 6:08 PM
bdrewery added a comment to D27507: contig allocs: Don't retry forever on M_WAITOK..
In D27507#615134, @kib wrote:

I wonder if it is better to move the retry policy into iterators instead.

Dec 9 2020, 6:01 PM

Dec 8 2020

bdrewery closed D27184: fts_read: Handle error from a NULL return better..
Dec 8 2020, 11:39 PM
bdrewery committed rS368467: fts_read: Handle error from a NULL return better..
fts_read: Handle error from a NULL return better.
Dec 8 2020, 11:39 PM
bdrewery retitled D27507: contig allocs: Don't retry forever on M_WAITOK. from contig allocs: Don't sleep forever on M_WAITOK. to contig allocs: Don't retry forever on M_WAITOK..
Dec 8 2020, 11:34 PM
bdrewery added a reviewer for D27508: linux_dma: Ensure proper flags pass to allocators.: hselasky.
Dec 8 2020, 11:14 PM
bdrewery updated the diff for D27507: contig allocs: Don't retry forever on M_WAITOK..
  • Take Mark's comment
Dec 8 2020, 11:11 PM
bdrewery added inline comments to D27507: contig allocs: Don't retry forever on M_WAITOK..
Dec 8 2020, 8:28 PM
bdrewery added inline comments to D27507: contig allocs: Don't retry forever on M_WAITOK..
Dec 8 2020, 7:15 PM
bdrewery updated the diff for D27507: contig allocs: Don't retry forever on M_WAITOK..
  • Move the fix out of the iterator.
Dec 8 2020, 5:41 PM
bdrewery added inline comments to D27507: contig allocs: Don't retry forever on M_WAITOK..
Dec 8 2020, 5:12 PM
bdrewery updated the summary of D27508: linux_dma: Ensure proper flags pass to allocators..
Dec 8 2020, 5:53 AM
bdrewery requested review of D27508: linux_dma: Ensure proper flags pass to allocators..
Dec 8 2020, 5:45 AM
bdrewery updated the diff for D27507: contig allocs: Don't retry forever on M_WAITOK..
  • Set di_flags|=M_NOWAIT consistently
Dec 8 2020, 5:40 AM
bdrewery added inline comments to D27507: contig allocs: Don't retry forever on M_WAITOK..
Dec 8 2020, 5:37 AM
bdrewery requested review of D27507: contig allocs: Don't retry forever on M_WAITOK..
Dec 8 2020, 5:35 AM

Dec 1 2020

bdrewery added a comment to D27393: Upgrade devel/ccache to v4.1.

Thanks for working on this. I'll review+test soon.

Dec 1 2020, 11:46 PM

Nov 24 2020

bdrewery accepted D27300: Update dirdeps.mk et al to latest.
Nov 24 2020, 9:01 PM
bdrewery committed rP556185: - Fix KERB_GSSAPI build; missing prototypes for DH openssl-compat..
- Fix KERB_GSSAPI build; missing prototypes for DH openssl-compat.
Nov 24 2020, 8:47 PM