In D42070#960269, @des wrote:

In D42070#960267, @bdrewery wrote:

What is the motivation for dropping ca_root_nss?

It's not needed. We've shipped a fully populated trust root in base since 12.2.

This doesn’t seem right. I’m away from computer today so can’t verify. What is the motivation for dropping ca_root_nss?

I mention "style" which is from style(9) man style. Accepted pending style fixes.

I didn't mean to "accept as portmgr".

@markj Great, thanks!

This vdso thing happens when building releng/12.3 as well. Edit: I suppose it will happen on any older builds but this branch is at least still supported.

+1

Very nice. Thank you!

The here-document shall be treated as a single word that begins after the next <newline>

https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_07_04

Looks good.

• test feedback
• avoid races in read11.0 test

• add braces around ungetc loop

In D31687#714822, @kib wrote:

I believe stdio is not supposed to work (correctly) with non-blocking file descriptors. I do not object against attempts to make part of it work regardless, but I am not sure it is possible without making it all functional.

Address feedback

• Reset errno before __srefill as it may return EOF without setting it.
• Destaircase
• Handle (malloc failing) EOF error from __ungetc

• Make failure of the partner process less prominent in kyua output