You've got 2 distinct changes here, one is shares/examples and the other is adding a DIRS thing to bsd.files.mk. They should really be separate commits.

Thanks, I'll get this added into my patch.

Committed in rP467538

Also "reviewed" by me.

Thank you!
Approved by me but I think you'll need mentor approval still.

Also you need to bump PORTREVISION too

Looks good but could you add the header back in from the des commit please? It lets me know I took it from the base patches. Anything above the --- ssh.c.orig line is ignored.

But why?

+1

In D14185#314787, @arichardson wrote:

@bdrewery does this look okay?

Looking

On head there seems to be very little backpressure on the ARC lately to the point of needing extreme swap support. On my 78GB ram system with ARC limited to 40GB, I can have the ARC pegged at 40GB but swap in the 50GB range for package builds in tmpfs. The ARC never seems to shrink at all. This commit was partially implicated in the thread on current: https://lists.freebsd.org/pipermail/freebsd-current/2018-March/068888.html. Could it be a problem?

I think this is fine but we'll need to keep some of the flags to handle the SYSTEM_COMPILER CC=/usr/bin/cc case until we can fix --sysroot fully.

Discussed on IRC, there's 3 cases for the compiler. External (for which you fixed the port to respect --sysroot properly). Interal (bootstrap) from contrib/gcc which you've modified here to respect --sysroot (Except headers which will just work from WORLDTMP). But there's a 3rd case of the installed /usr/bin/cc which is used for WITH_SYSTEM_COMPILER which won't work without the -isystem, etc, flags or a fixed --sysroot.

In D14627#308125, @bdrewery wrote:

One caveat is that the built GCC does look for headers in /usr/local/include
(under the sysroot) before /usr/include, but I think that is an existing
problem in the native GCC ports as well and whatever solution is used for
that would be applicable here.

And libs. See rS297435

One caveat is that the built GCC does look for headers in /usr/local/include
(under the sysroot) before /usr/include, but I think that is an existing
problem in the native GCC ports as well and whatever solution is used for
that would be applicable here.

Committed in rS330260