bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (214 w, 2 d)

Recent Activity

Today

bdrewery added inline comments to D15836: Rework how the ld link is handled in WORLDTMP from r322811..
Mon, Jun 18, 6:47 PM

Sat, Jun 16

bdrewery committed rS335244: Assert that a build is done before an install..
Assert that a build is done before an install.
Sat, Jun 16, 12:35 AM

Fri, Jun 15

bdrewery added inline comments to D15836: Rework how the ld link is handled in WORLDTMP from r322811..
Fri, Jun 15, 10:38 PM
bdrewery created D15837: Rework WITHOUT_LLD/TOOLCHAIN fix from r327892 for cross-tools..
Fri, Jun 15, 10:37 PM
bdrewery created D15836: Rework how the ld link is handled in WORLDTMP from r322811..
Fri, Jun 15, 10:36 PM
bdrewery added a comment to D15833: truss: add option to print the active syscall(s) if no activity after N seconds..

I wonder if the wchan for the process can be printed easily instead of 'sleeping'

Fri, Jun 15, 9:07 PM
bdrewery committed rS335233: Put in temporary hacks for jevents..
Put in temporary hacks for jevents.
Fri, Jun 15, 7:19 PM
bdrewery committed rS335225: lib32: Fix lib/libpmc/pmu-events files ending up in source directory..
lib32: Fix lib/libpmc/pmu-events files ending up in source directory.
Fri, Jun 15, 6:50 PM
bdrewery committed rS335218: libcompat: Only build libmagic build tool if MK_FILE is yes..
libcompat: Only build libmagic build tool if MK_FILE is yes.
Fri, Jun 15, 5:04 PM
bdrewery committed rS335216: Only build jevents if MK_PMC is yes and only for amd64 in libcompat..
Only build jevents if MK_PMC is yes and only for amd64 in libcompat.
Fri, Jun 15, 4:48 PM
bdrewery committed rS335204: MFC r325560:.
MFC r325560:
Fri, Jun 15, 3:10 PM
bdrewery committed rS335203: MFC r334791,r334811:.
MFC r334791,r334811:
Fri, Jun 15, 3:05 PM
bdrewery committed rS335202: MFC r330702:.
MFC r330702:
Fri, Jun 15, 3:02 PM
bdrewery committed rS335183: proc0_post: Fix some locking issues.
proc0_post: Fix some locking issues
Fri, Jun 15, 12:37 AM
bdrewery closed D15809: proc0_post: Fix some locking issues.
Fri, Jun 15, 12:37 AM

Thu, Jun 14

bdrewery accepted D15648: Rework ofed build..
Thu, Jun 14, 11:55 PM
bdrewery retitled D15809: proc0_post: Fix some locking issues from proc0_post: Filter out new forking procs. to proc0_post: Fix some locking issues.
Thu, Jun 14, 6:35 PM
bdrewery updated the diff for D15809: proc0_post: Fix some locking issues.
  • Filter out PRS_NEW procs as rufetch() tries taking the thread lock which may not yet be initialized.
  • Hold PROC_LOCK to ensure stability of iterating the threads.
  • p_rux fields are protected by the process statlock as well.
Thu, Jun 14, 6:35 PM
bdrewery updated the summary of D15809: proc0_post: Fix some locking issues.
Thu, Jun 14, 4:55 PM
bdrewery created D15809: proc0_post: Fix some locking issues.
Thu, Jun 14, 4:50 PM
bdrewery requested changes to D15648: Rework ofed build..

Consider it Reviewed after these are fixed.

Thu, Jun 14, 4:29 PM

Thu, Jun 7

bdrewery committed rS334811: Use simpler sed invocation..
Use simpler sed invocation.
Thu, Jun 7, 7:39 PM
bdrewery committed rS334791: Stop using head(1) which is not available in installworld..
Stop using head(1) which is not available in installworld.
Thu, Jun 7, 4:16 PM

Wed, Jun 6

bdrewery added a comment to D15648: Rework ofed build..
In D15648#330673, @kib wrote:

Abusing prebuild_libs seems like a hack!

Sort of, yes. I agree with the statement that ib libs should be not put into the prebuild libs.

For now I used the recipe provided by bdrewery. When the build system grows the ability to handle this case cleaner, we will adopt.

Wed, Jun 6, 3:58 PM
bdrewery added inline comments to D15648: Rework ofed build..
Wed, Jun 6, 3:44 PM

Fri, Jun 1

bdrewery added inline comments to D15648: Rework ofed build..
Fri, Jun 1, 10:12 PM
bdrewery added inline comments to D15648: Rework ofed build..
Fri, Jun 1, 10:10 PM
bdrewery added inline comments to D15648: Rework ofed build..
Fri, Jun 1, 9:57 PM
bdrewery added inline comments to D15648: Rework ofed build..
Fri, Jun 1, 9:56 PM
bdrewery committed rP471282: - Update to 3.2.7-372-g6125e0831.
- Update to 3.2.7-372-g6125e0831
Fri, Jun 1, 6:36 PM
bdrewery committed rP471281: MFH: r468995 r471280.
MFH: r468995 r471280
Fri, Jun 1, 6:33 PM
bdrewery committed rP471280: - Update to 3.2.7.
- Update to 3.2.7
Fri, Jun 1, 6:32 PM

Tue, May 29

bdrewery committed rP471099: MFH: r466129.
MFH: r466129
Tue, May 29, 4:23 PM

Fri, May 25

bdrewery committed rS334228: META_MODE: Fix trying to rebuild jevents due to missing .meta file..
META_MODE: Fix trying to rebuild jevents due to missing .meta file.
Fri, May 25, 9:47 PM
bdrewery committed rS334227: Use proper BTOOLSPATH for build-tools path..
Use proper BTOOLSPATH for build-tools path.
Fri, May 25, 9:47 PM
bdrewery committed rS334226: Cleanup style.
Cleanup style
Fri, May 25, 9:46 PM

Thu, May 24

bdrewery committed rS334190: Fix exit code for mismatches after r333013..
Fix exit code for mismatches after r333013.
Thu, May 24, 10:16 PM
bdrewery accepted D15542: Drop objcopy from base/binutils for sparc64 and powerpc64..

10.4 uses elftoolchain objcopy as well?

Thu, May 24, 8:02 PM
bdrewery accepted D15541: Remove an unnecessary variable from CONFIGURE_ENV..
Thu, May 24, 8:01 PM
bdrewery committed rS334177: rescue: Restore 'make depend' call to fix WITH_META_MODE after r334008..
rescue: Restore 'make depend' call to fix WITH_META_MODE after r334008.
Thu, May 24, 6:49 PM

May 15 2018

bdrewery committed rS333654: Fix stale dependencies on libcasper libraries..
Fix stale dependencies on libcasper libraries.
May 15 2018, 11:47 PM

May 11 2018

bdrewery added a comment to D15127: Fix GCC 4.2.1 to honor --sysroot for includes..
In D15127#324326, @jhb wrote:

Makefile.inc1

.if ${WANT_COMPILER_TYPE} == gcc || \
    (defined(X_COMPILER_TYPE) && ${X_COMPILER_TYPE} == gcc)
# GCC requires -isystem and -L when using a cross-compiler.  --sysroot
# won't set header path and -L is used to ensure the base library path
# is added before the port PREFIX library path.
XCFLAGS+=       -isystem ${WORLDTMP}/usr/include -L${WORLDTMP}/usr/lib
# GCC requires -B to find /usr/lib/crti.o when using a cross-compiler
# combined with --sysroot.
XCFLAGS+=       -B${WORLDTMP}/usr/lib
# Force using libc++ for external GCC.
.if defined(X_COMPILER_TYPE) && \
    ${X_COMPILER_TYPE} == gcc && ${X_COMPILER_VERSION} >= 40800
XCXXFLAGS+=     -isystem ${WORLDTMP}/usr/include/c++/v1 -std=c++11 \
                -nostdinc++
.endif

We may need to keep some of this like the -L usage if your port work didn't change the ordering or the -B usage... Did you test without the 2 -isystem uses here? I think the C++ one will need to remain looking at the freebsd-native.h change.

All of this is gone in my testing. The port versions now look in the right place when using --sysroot. The earlier commit in this git branch that I've been using for all my tests is here: https://github.com/freebsd/freebsd/commit/d68a00bbb3c0844020ba89c69fa0b13c27b561ff

May 11 2018, 7:27 PM
bdrewery committed rP469680: MFH: r468349.
MFH: r468349
May 11 2018, 6:07 PM
bdrewery committed rS333498: Revert r333496..
Revert r333496.
May 11 2018, 5:24 PM
bdrewery committed rP469675: MFH: r469674.
MFH: r469674
May 11 2018, 5:10 PM
bdrewery committed rP469674: - Update to 3.2.6-369-g91f1ddf5f.
- Update to 3.2.6-369-g91f1ddf5f
May 11 2018, 5:09 PM
bdrewery committed rS333496: Add a bunch of orphaned libraries..
Add a bunch of orphaned libraries.
May 11 2018, 4:47 PM

May 10 2018

bdrewery committed rP469592: MFH: r469591.
MFH: r469591
May 10 2018, 11:06 PM
bdrewery committed rP469591: Fix libtclstub.a being stripped of symbols and thus being useless..
Fix libtclstub.a being stripped of symbols and thus being useless.
May 10 2018, 11:05 PM
bdrewery committed rP469590: MFH: r469589.
MFH: r469589
May 10 2018, 11:01 PM
bdrewery committed rP469589: stage-qa: Change stripped check to only look for .debug_info..
stage-qa: Change stripped check to only look for .debug_info.
May 10 2018, 11:00 PM
bdrewery added a comment to D15127: Fix GCC 4.2.1 to honor --sysroot for includes..

Makefile.inc1

.if ${WANT_COMPILER_TYPE} == gcc || \
    (defined(X_COMPILER_TYPE) && ${X_COMPILER_TYPE} == gcc)
# GCC requires -isystem and -L when using a cross-compiler.  --sysroot
# won't set header path and -L is used to ensure the base library path
# is added before the port PREFIX library path.
XCFLAGS+=       -isystem ${WORLDTMP}/usr/include -L${WORLDTMP}/usr/lib
# GCC requires -B to find /usr/lib/crti.o when using a cross-compiler
# combined with --sysroot.
XCFLAGS+=       -B${WORLDTMP}/usr/lib
# Force using libc++ for external GCC.
.if defined(X_COMPILER_TYPE) && \
    ${X_COMPILER_TYPE} == gcc && ${X_COMPILER_VERSION} >= 40800
XCXXFLAGS+=     -isystem ${WORLDTMP}/usr/include/c++/v1 -std=c++11 \
                -nostdinc++
.endif
May 10 2018, 1:43 AM

May 8 2018

bdrewery added inline comments to D15360: Normalize the g(eom,cache,part,...) build..
May 8 2018, 10:56 PM
bdrewery requested changes to D15360: Normalize the g(eom,cache,part,...) build..

Please update the paths here too:

May 8 2018, 10:46 PM
bdrewery committed rP469390: MFH: r469300 r469389.
MFH: r469300 r469389
May 8 2018, 7:15 PM
bdrewery committed rP469389: Update howto.
Update howto
May 8 2018, 7:12 PM

May 7 2018

bdrewery committed rP469300: Add clang60 support.
Add clang60 support
May 7 2018, 5:16 PM

May 4 2018

bdrewery added a comment to D15283: Created static pic libc with no SSP to be used by rtld.

This seems fine though I'm not super excited about compiling all of libc yet another time.

May 4 2018, 12:25 AM

May 3 2018

bdrewery committed rP468998: - Add XMSS option to enable experimental key support added in 7.7 [1].
- Add XMSS option to enable experimental key support added in 7.7 [1]
May 3 2018, 11:39 PM
bdrewery committed rP468995: - Add DIALOG4PORTS option (default on) to install it for 'options' command [1]..
- Add DIALOG4PORTS option (default on) to install it for 'options' command [1].
May 3 2018, 11:10 PM
bdrewery added inline comments to D15263: `make po' does not update the *.po file .
May 3 2018, 10:54 PM
bdrewery added inline comments to D15267: Add 32-bit mips support to base/binutils and base/gcc..
May 3 2018, 10:52 PM
bdrewery accepted D15283: Created static pic libc with no SSP to be used by rtld.
May 3 2018, 10:39 PM

Apr 25 2018

bdrewery committed rP468296: MFH: r468295.
MFH: r468295
Apr 25 2018, 8:18 PM
bdrewery committed rP468295: The newer meson requires 3.5 (setup.py).
The newer meson requires 3.5 (setup.py)
Apr 25 2018, 8:17 PM
bdrewery committed rP468286: Update the KERB_GSSAPI patch from debian..
Update the KERB_GSSAPI patch from debian.
Apr 25 2018, 6:06 PM
bdrewery committed rP468284: MFH: r466385.
MFH: r466385
Apr 25 2018, 5:51 PM

Apr 24 2018

bdrewery accepted D15185: Update netdumpd to 20180424..
Apr 24 2018, 5:39 PM

Apr 19 2018

bdrewery requested changes to D15130: Switch installing share/examples to FILES.

You've got 2 distinct changes here, one is shares/examples and the other is adding a DIRS thing to bsd.files.mk. They should really be separate commits.

Apr 19 2018, 9:29 PM

Apr 17 2018

bdrewery added a comment to D15110: lld: add a __FreeBSD_version-style identifier to version.

Thanks, I'll get this added into my patch.

Apr 17 2018, 6:46 PM

Apr 16 2018

bdrewery abandoned D14921: lang/rust: Update to 1.25.

Committed in rP467538

Apr 16 2018, 9:38 PM
bdrewery commandeered D14921: lang/rust: Update to 1.25.
Apr 16 2018, 9:38 PM
bdrewery committed rP467539: MFH: r467538.
MFH: r467538
Apr 16 2018, 9:37 PM
bdrewery committed rP467538: Update to 1.25.0..
Update to 1.25.0.
Apr 16 2018, 9:35 PM

Apr 12 2018

bdrewery added a comment to D15053: security/openssh-portable: Regenerate broken patch and fix ssh SSHFP support for non-canonical hostnames.

Also "reviewed" by me.

Apr 12 2018, 8:48 PM
bdrewery accepted D15053: security/openssh-portable: Regenerate broken patch and fix ssh SSHFP support for non-canonical hostnames.

Thank you!
Approved by me but I think you'll need mentor approval still.

Apr 12 2018, 8:48 PM
bdrewery committed rS332455: Use known SRCTOP if possible to determine SYSDIR..
Use known SRCTOP if possible to determine SYSDIR.
Apr 12 2018, 8:48 PM
bdrewery requested changes to D15053: security/openssh-portable: Regenerate broken patch and fix ssh SSHFP support for non-canonical hostnames.

Also you need to bump PORTREVISION too

Apr 12 2018, 8:34 PM
bdrewery added a comment to D15053: security/openssh-portable: Regenerate broken patch and fix ssh SSHFP support for non-canonical hostnames.

Looks good but could you add the header back in from the des commit please? It lets me know I took it from the base patches. Anything above the --- ssh.c.orig line is ignored.

Apr 12 2018, 8:34 PM
bdrewery committed rS332453: Fix using wrong SYSDIR after r331683..
Fix using wrong SYSDIR after r331683.
Apr 12 2018, 8:28 PM

Apr 11 2018

bdrewery accepted D15039: Try and prevent people from adding github archive urls..
Apr 11 2018, 8:09 PM
bdrewery accepted D15045: Update netdumpd to 20180411..
Apr 11 2018, 7:32 PM
bdrewery added a comment to D15039: Try and prevent people from adding github archive urls..

But why?

Apr 11 2018, 6:23 PM

Apr 9 2018

bdrewery added a comment to D14787: Bring over some fixes from the other external GCC toolchain ports..

+1

Apr 9 2018, 4:10 PM

Apr 6 2018

bdrewery accepted D14925: Fix two more issues with r465416..
Apr 6 2018, 6:54 PM

Apr 5 2018

bdrewery committed rP466595: Make BROKEN lines more clear.
Make BROKEN lines more clear
Apr 5 2018, 7:57 PM
bdrewery committed rP466577: Update to 7.7p1.
Update to 7.7p1
Apr 5 2018, 6:21 PM

Apr 4 2018

bdrewery accepted D14185: Don't change directory owner to root when building with -DNO_ROOT.

@bdrewery does this look okay?

Apr 4 2018, 10:00 PM

Apr 3 2018

bdrewery committed rP466385: libressl support was fixed in r452358.
libressl support was fixed in r452358
Apr 3 2018, 11:14 PM
bdrewery committed rP466378: Update to 2018-04-03.
Update to 2018-04-03
Apr 3 2018, 8:49 PM

Apr 2 2018

bdrewery added inline comments to D4385: Prepare the ports tree for reproducible builds.
Apr 2 2018, 8:29 PM
bdrewery added inline comments to D14921: lang/rust: Update to 1.25.
Apr 2 2018, 5:36 PM
bdrewery added inline comments to D14921: lang/rust: Update to 1.25.
Apr 2 2018, 5:33 PM
bdrewery requested changes to D14921: lang/rust: Update to 1.25.
Apr 2 2018, 5:31 PM
bdrewery added a comment to D14921: lang/rust: Update to 1.25.

Looking

Apr 2 2018, 4:59 PM

Mar 31 2018

bdrewery added inline comments to D10018: Summary:.
Mar 31 2018, 2:34 AM

Mar 30 2018

bdrewery committed rP465999: MFH: r465998.
MFH: r465998
Mar 30 2018, 8:20 PM
bdrewery committed rP465998: - Update to 3.2.6.
- Update to 3.2.6
Mar 30 2018, 8:18 PM
bdrewery accepted D14143: Remove MK_AUTO_OBJ from env passed to PORTS_MODULES.
Mar 30 2018, 7:52 PM

Mar 29 2018

bdrewery committed rP465910: Update to 2018-03-28.
Update to 2018-03-28
Mar 29 2018, 6:45 PM