Page MenuHomeFreeBSD

bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (332 w, 5 h)

Recent Activity

Tue, Sep 15

bdrewery accepted D26445: fix setitimer test for returned it_value.
Tue, Sep 15, 8:10 PM

Aug 19 2020

bdrewery accepted D26056: Also print number of available CPUs on Linux.
Aug 19 2020, 5:30 PM
bdrewery added inline comments to D24183: Introduce (build|install)sysroot targets..
Aug 19 2020, 5:29 PM

Aug 14 2020

bdrewery accepted D26068: Move -L${LIBCOMPATTMP}/usr/lib${libcompat} from CFLAGS to LDFLAGS..

If it passes universe then +1. I wonder if this was a workaround for bfd or just an old mistake.

Aug 14 2020, 10:28 PM
bdrewery committed rS364223: syslog(3): Send proper NILVALUE if gethostname(3) fails..
syslog(3): Send proper NILVALUE if gethostname(3) fails.
Aug 14 2020, 12:18 AM

Aug 13 2020

bdrewery closed D26037: Add test to verify fix for FreeBSD-SA-19:20.bsnmp.
Aug 13 2020, 10:42 PM
bdrewery committed rS364221: Add test to for FreeBSD-SA-19:20.bsnmp.
Add test to for FreeBSD-SA-19:20.bsnmp
Aug 13 2020, 10:42 PM
bdrewery committed rS364220: lagg: Avoid adding a port to a lagg device being destroyed..
lagg: Avoid adding a port to a lagg device being destroyed.
Aug 13 2020, 10:06 PM
bdrewery closed D25284: lagg: Avoid adding a port to a lagg device being destroyed..
Aug 13 2020, 10:06 PM

Aug 3 2020

bdrewery updated the diff for D25284: lagg: Avoid adding a port to a lagg device being destroyed..

Add comment noting there is still a race in lagg_ioctl()

Aug 3 2020, 3:01 PM

Jul 23 2020

bdrewery committed rS363463: Limit gmirror failpoint tests to the test worker.
Limit gmirror failpoint tests to the test worker
Jul 23 2020, 11:30 PM

Jul 9 2020

bdrewery accepted D25270: sh: Do not ignore INTOFF during a trap.

Tested this with a builtin and agree it's redundant and dangerous.

Jul 9 2020, 8:26 PM

Jul 1 2020

bdrewery added inline comments to D15337: Add support for higher resolution timestamps.
Jul 1 2020, 1:51 AM

Jun 23 2020

bdrewery closed D24536: Don't try ctfconvert on file without debug info..
Jun 23 2020, 3:16 AM

Jun 18 2020

bdrewery accepted D25346: bmake: Hide noisy spam behind debug options.

Wow. Be sure to get buyin from sjg@ or it may get dropped by accident.

Jun 18 2020, 5:03 PM

Jun 15 2020

bdrewery added a comment to D25284: lagg: Avoid adding a port to a lagg device being destroyed..

I think this is a step in the right direction, but it does not completely fix the problem. sc_destroying is set by lagg_clone_destroy(), which later drops the lock and frees the lagg softc. If lagg_port_create() is dereferencing the softc pointer, then it may be dereferencing freed memory. You could probably trigger a panic by enabling memguard on "lagg" and running your repro.

I suspect that we need to use the net epoch to ensure that if_softc points to valid memory, but I don't have any detailed suggestions at the moment.

Jun 15 2020, 9:06 PM
bdrewery updated subscribers of D25284: lagg: Avoid adding a port to a lagg device being destroyed..
Jun 15 2020, 5:37 PM
bdrewery requested review of D25284: lagg: Avoid adding a port to a lagg device being destroyed..
Jun 15 2020, 5:36 PM

May 17 2020

bdrewery accepted D24836: x11/nvidia-driver: Respect WITH_DEBUG.
May 17 2020, 12:01 AM

May 15 2020

bdrewery added inline comments to D24596: vfs: add restrictions to read(2) of a directory.
May 15 2020, 3:18 PM

May 14 2020

bdrewery added inline comments to D24596: vfs: add restrictions to read(2) of a directory.
May 14 2020, 7:20 PM

May 12 2020

bdrewery added a comment to D23848: Reduce object locking in zfs..

I think deadlock at https://lists.freebsd.org/pipermail/freebsd-current/2020-May/076100.html may be related to this but I don't understand a lot of it.
Edit: Nevermind, reverting did not help. Sorry for the noise.

May 12 2020, 10:16 PM

May 8 2020

bdrewery added inline comments to D23690: pkgbase: return most config files back to ^/etc.
May 8 2020, 9:16 PM

May 4 2020

bdrewery committed rP533940: Support OVERLAY dir passed in from Poudriere..
Support OVERLAY dir passed in from Poudriere.
May 4 2020, 6:28 PM

Apr 29 2020

bdrewery committed rS360476: dtrace tests: Support globbing for excludes.
dtrace tests: Support globbing for excludes
Apr 29 2020, 9:12 PM
bdrewery closed D24608: dtrace tests: Support globbing for excludes.
Apr 29 2020, 9:12 PM
bdrewery updated the diff for D24608: dtrace tests: Support globbing for excludes.

Expand tabs to 4 spaces

Apr 29 2020, 5:31 PM
bdrewery added inline comments to D24608: dtrace tests: Support globbing for excludes.
Apr 29 2020, 4:36 PM
bdrewery committed rS360453: Use universe-toolchain config(8).
Use universe-toolchain config(8)
Apr 29 2020, 2:18 AM

Apr 28 2020

bdrewery updated the diff for D24608: dtrace tests: Support globbing for excludes.

Handle invalid globs

Invalid exclude for common/ip/tst.*sctp*.ksh*blah
Apr 28 2020, 9:45 PM
bdrewery updated the diff for D24608: dtrace tests: Support globbing for excludes.

Meant to remove the default TESTBASE before submitting.

Apr 28 2020, 9:30 PM
bdrewery requested review of D24608: dtrace tests: Support globbing for excludes.
Apr 28 2020, 9:27 PM
bdrewery reopened D24537: ctfmerge: Assert that there is enough room for types..

Wasn't intended to be pushed yet.

Apr 28 2020, 6:54 PM
bdrewery committed rS360448: Revert r360445.
Revert r360445
Apr 28 2020, 6:53 PM
bdrewery closed D24537: ctfmerge: Assert that there is enough room for types..
Apr 28 2020, 4:09 PM
bdrewery committed rS360445: ctfmerge: Assert that there is enough room for types..
ctfmerge: Assert that there is enough room for types.
Apr 28 2020, 4:09 PM
bdrewery committed rS360444: Don't try ctfconvert on file without debug info..
Don't try ctfconvert on file without debug info.
Apr 28 2020, 4:09 PM
bdrewery committed rS360443: config: Add no-ctfconvert support..
config: Add no-ctfconvert support.
Apr 28 2020, 4:09 PM
bdrewery closed D24535: config: Add no-ctfconvert support..
Apr 28 2020, 4:09 PM
bdrewery committed rS360442: None of these use opt_sched.h.
None of these use opt_sched.h
Apr 28 2020, 4:09 PM
bdrewery committed rS360441: Restore local kernel "prog" filtering lost in r332099..
Restore local kernel "prog" filtering lost in r332099.
Apr 28 2020, 4:07 PM
bdrewery closed D24286: Restore local kernel "prog" filtering lost in r332099..
Apr 28 2020, 4:07 PM
bdrewery updated the diff for D24535: config: Add no-ctfconvert support..

Set NO_CTFCONVERT for no-obj

Apr 28 2020, 3:29 PM
bdrewery added inline comments to D24535: config: Add no-ctfconvert support..
Apr 28 2020, 3:26 PM

Apr 27 2020

bdrewery accepted D24599: sh: Assert INTOFF rather than applying it in ck*.
Apr 27 2020, 11:02 PM
bdrewery added inline comments to D24535: config: Add no-ctfconvert support..
Apr 27 2020, 5:06 PM
bdrewery added a comment to D24528: Some fixes for FIFOs/pipes when used with kqueue/poll.

While everyone's head is in this code have any ideas on https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225934 ?

Apr 27 2020, 4:53 PM

Apr 24 2020

bdrewery updated the diff for D24536: Don't try ctfconvert on file without debug info..

Use proper version

Apr 24 2020, 6:04 PM
bdrewery added inline comments to D24536: Don't try ctfconvert on file without debug info..
Apr 24 2020, 6:03 PM
bdrewery updated the diff for D24536: Don't try ctfconvert on file without debug info..

bump required version

Apr 24 2020, 5:23 PM
bdrewery updated the diff for D24535: config: Add no-ctfconvert support..

Upload proper diff

Apr 24 2020, 5:22 PM
bdrewery updated the diff for D24535: config: Add no-ctfconvert support..

Bump CONFIGVERS for change

Apr 24 2020, 5:22 PM

Apr 22 2020

bdrewery added a comment to D24537: ctfmerge: Assert that there is enough room for types..

Hmm I had this at Isilon but not here.

--- cddl/contrib/opensolaris/tools/ctf/cvt/merge.c
+++ cddl/contrib/opensolaris/tools/ctf/cvt/merge.c
@@ -347,7 +347,7 @@ equiv_node(tdesc_t *ctdp, tdesc_t *mtdp, equiv_data_t *ed)
        int (*equiv)(tdesc_t *, tdesc_t *, equiv_data_t *);
        int mapping;

-       if (ctdp->t_emark > ed->ed_clear_mark ||
+       if (ctdp->t_emark > ed->ed_clear_mark &&
            mtdp->t_emark > ed->ed_clear_mark)
                return (ctdp->t_emark == mtdp->t_emark);
Apr 22 2020, 7:18 PM
bdrewery added a comment to D24537: ctfmerge: Assert that there is enough room for types..

Hmm I had this at Isilon but not here.

--- cddl/contrib/opensolaris/tools/ctf/cvt/merge.c
+++ cddl/contrib/opensolaris/tools/ctf/cvt/merge.c
@@ -347,7 +347,7 @@ equiv_node(tdesc_t *ctdp, tdesc_t *mtdp, equiv_data_t *ed)
        int (*equiv)(tdesc_t *, tdesc_t *, equiv_data_t *);
        int mapping;
Apr 22 2020, 7:17 PM
bdrewery created D24537: ctfmerge: Assert that there is enough room for types..
Apr 22 2020, 7:07 PM
bdrewery created D24536: Don't try ctfconvert on file without debug info..
Apr 22 2020, 7:00 PM
bdrewery created D24535: config: Add no-ctfconvert support..
Apr 22 2020, 6:58 PM

Apr 21 2020

bdrewery committed rP532423: Update to 2019.01.06.
Update to 2019.01.06
Apr 21 2020, 9:24 PM
bdrewery closed D24470: Update devel/autoconf-archive to 2019.01.06.
Apr 21 2020, 9:24 PM
bdrewery added a comment to D24470: Update devel/autoconf-archive to 2019.01.06.

This is old but was the last on the mirror I checked. Git has year newer files though. Hmm

Apr 21 2020, 6:26 PM
bdrewery accepted D24522: Update jemalloc to version 5.2.1.
Apr 21 2020, 6:19 PM
bdrewery committed rP532277: OVERLAYS: Include <overlay>/Mk/bsd.overlay.mk.
OVERLAYS: Include <overlay>/Mk/bsd.overlay.mk
Apr 21 2020, 3:51 PM
bdrewery closed D24506: OVERLAYS: Include <overlay>/Mk/bsd.overlay.mk.
Apr 21 2020, 3:51 PM
bdrewery committed rP532276: Revert r532275.
Revert r532275
Apr 21 2020, 3:49 PM
bdrewery committed rP532275: OVERLAYS: Include <overlay>/Mk/bsd.overlay.mk.
OVERLAYS: Include <overlay>/Mk/bsd.overlay.mk
Apr 21 2020, 3:48 PM
bdrewery closed D24458: Fix build with NO_HISTORY set.
Apr 21 2020, 12:38 AM
bdrewery committed rS360139: Fix build with NO_HISTORY set.
Fix build with NO_HISTORY set
Apr 21 2020, 12:38 AM

Apr 20 2020

bdrewery added a comment to D24458: Fix build with NO_HISTORY set.

I have no opinions on how this should work. I was just trying to follow what was there. The presence of -h is definitely inconsistent now. If you want to pick this up and pick the right route that's fine with me.

Apr 20 2020, 5:00 PM
bdrewery updated the diff for D24506: OVERLAYS: Include <overlay>/Mk/bsd.overlay.mk.

Use .sinclude for consistency

Apr 20 2020, 4:56 PM

Apr 19 2020

bdrewery added a comment to D24506: OVERLAYS: Include <overlay>/Mk/bsd.overlay.mk.

The test layout in Poudriere is chaos. I started converting to using OVERLAYS per test that needed special ports. bsd.overlay.mk helps with testing pre-FLAVORS support.

Apr 19 2020, 9:08 PM
bdrewery created D24506: OVERLAYS: Include <overlay>/Mk/bsd.overlay.mk.
Apr 19 2020, 9:06 PM

Apr 17 2020

bdrewery updated the diff for D24458: Fix build with NO_HISTORY set.

builtins.h does define these prototypes

Apr 17 2020, 5:54 PM
bdrewery created D24470: Update devel/autoconf-archive to 2019.01.06.
Apr 17 2020, 3:51 PM
bdrewery created D24458: Fix build with NO_HISTORY set.
Apr 17 2020, 12:39 AM

Apr 12 2020

bdrewery committed rP531539: - Update compiler list.
- Update compiler list
Apr 12 2020, 6:19 PM

Apr 10 2020

bdrewery committed rP531389: Don't show private variable name in user message..
Don't show private variable name in user message.
Apr 10 2020, 11:29 PM

Apr 8 2020

bdrewery committed rP531149: Note an upgrade issue with OpenSSH 8.2.
Note an upgrade issue with OpenSSH 8.2
Apr 8 2020, 10:02 PM
bdrewery updated the diff for D24286: Restore local kernel "prog" filtering lost in r332099..

Fix uninitialized kernel_app_name

Apr 8 2020, 8:00 PM

Apr 7 2020

bdrewery committed rS359714: MFC r349729:.
MFC r349729:
Apr 7 2020, 7:44 PM
bdrewery committed rS359715: MFC r349729:.
MFC r349729:
Apr 7 2020, 7:44 PM
bdrewery committed rS359713: MFC r353771:.
MFC r353771:
Apr 7 2020, 7:40 PM
bdrewery committed rS359712: MFC r353771:.
MFC r353771:
Apr 7 2020, 7:40 PM
bdrewery committed rS359711: MFC r357353:.
MFC r357353:
Apr 7 2020, 7:40 PM
bdrewery committed rS359710: MFC r357353:.
MFC r357353:
Apr 7 2020, 7:39 PM
bdrewery committed rS359705: NO_OBJ: Always fix .OBJDIR regardless of AUTO_OBJ..
NO_OBJ: Always fix .OBJDIR regardless of AUTO_OBJ.
Apr 7 2020, 5:07 PM
bdrewery added inline comments to D24197: POC: Add build-id and gdb_index support..
Apr 7 2020, 1:36 AM

Apr 6 2020

bdrewery added inline comments to D24286: Restore local kernel "prog" filtering lost in r332099..
Apr 6 2020, 11:53 PM
bdrewery updated the diff for D24286: Restore local kernel "prog" filtering lost in r332099..

Review updates

Apr 6 2020, 11:53 PM

Apr 4 2020

bdrewery updated the diff for D24286: Restore local kernel "prog" filtering lost in r332099..

Fix handling of no LOG_PID on older releases. It is force enabled on head...

Apr 4 2020, 3:42 PM

Apr 3 2020

bdrewery updated the test plan for D24286: Restore local kernel "prog" filtering lost in r332099..
Apr 3 2020, 11:39 PM
bdrewery created D24286: Restore local kernel "prog" filtering lost in r332099..
Apr 3 2020, 11:38 PM

Mar 31 2020

bdrewery committed rP529997: MFH: r529993.
MFH: r529993
Mar 31 2020, 5:46 PM
bdrewery committed rP529995: MFH: r529134.
MFH: r529134
Mar 31 2020, 5:43 PM
bdrewery committed rP529994: MFH: r529125.
MFH: r529125
Mar 31 2020, 5:42 PM
bdrewery committed rP529993: - Fix runtime for gcc rpath. [1].
- Fix runtime for gcc rpath. [1]
Mar 31 2020, 5:41 PM
bdrewery accepted D24212: Various universe fixes.
Mar 31 2020, 5:35 PM
bdrewery committed rS359475: Remove dead code leftover from r331018..
Remove dead code leftover from r331018.
Mar 31 2020, 1:13 AM
bdrewery accepted D24101: Allow for per directory local.init.mk.
Mar 31 2020, 12:42 AM

Mar 30 2020

bdrewery added a comment to D24101: Allow for per directory local.init.mk.

Can you still make -C share/mk with this?

Mar 30 2020, 11:56 PM

Mar 26 2020

bdrewery committed rP529219: - Update to 3.3.0-253-g531ee09f6.
- Update to 3.3.0-253-g531ee09f6
Mar 26 2020, 8:47 PM