Page MenuHomeFreeBSD

bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (275 w, 6 d)

Recent Activity

Fri, Aug 16

bdrewery committed rS351151: Rework r339635 to fix .depend.tables.h handling..
Rework r339635 to fix .depend.tables.h handling.
Fri, Aug 16, 10:34 PM
bdrewery closed D21295: Rework r339635 to fix .depend.tables.h handling..
Fri, Aug 16, 10:34 PM
bdrewery added a comment to D21295: Rework r339635 to fix .depend.tables.h handling..

Review findings

Fri, Aug 16, 9:32 PM
bdrewery added a comment to D21069: libsysdecode: automate tables.h dependency generation.

My change is at D21295

Fri, Aug 16, 8:00 PM
bdrewery created D21295: Rework r339635 to fix .depend.tables.h handling..
Fri, Aug 16, 8:00 PM
bdrewery added a comment to D21069: libsysdecode: automate tables.h dependency generation.

Something like this is probably needed instead

~/git/freebsd2/lib/libsysdecode # git diff
diff --git lib/libsysdecode/Makefile lib/libsysdecode/Makefile
index 2be244a6da46..9edfe067063c 100644
--- lib/libsysdecode/Makefile
+++ lib/libsysdecode/Makefile
@@ -127,7 +127,8 @@ incdir=${SYSROOT:U${DESTDIR}}${INCLUDEDIR}
 tables.h: mktables ${incdir}/netinet/in.h ${incdir}/netinet/tcp.h \
     ${incdir}/netinet6/in6.h
        sh ${.CURDIR}/mktables ${incdir} ${.TARGET}.tmp && \
-           mv -f ${.TARGET}.tmp ${.TARGET}
+           mv -f ${.TARGET}.tmp ${.TARGET} && \
+           mv -f .depend.${.TARGET}.tmp .depend.${.TARGET}
Fri, Aug 16, 7:47 PM
bdrewery added a comment to D21069: libsysdecode: automate tables.h dependency generation.

The hacks to using tables.h.tmp is probably what broke my work.

Fri, Aug 16, 7:45 PM
D21069: libsysdecode: automate tables.h dependency generation now requires changes to proceed.

This already has .depend file support. Why is this needed?

Fri, Aug 16, 7:43 PM
bdrewery added inline comments to D21069: libsysdecode: automate tables.h dependency generation.
Fri, Aug 16, 7:43 PM

Thu, Aug 15

bdrewery committed rP509046: - Update to 3.3.0-126-g12112ee57.
- Update to 3.3.0-126-g12112ee57
Thu, Aug 15, 7:58 PM
bdrewery added a comment to D21060: Stop installing clang, clang++, and clang-cpp hardlinks in /usr/bin..

Which package provides clang? I don't have a /usr/local/bin/clang on my system.

Thu, Aug 15, 6:22 PM

Sat, Aug 3

bdrewery committed rP507975: - Update to 3.3.0-125-g0a50192f8.
- Update to 3.3.0-125-g0a50192f8
Sat, Aug 3, 5:41 PM

Wed, Jul 31

bdrewery added a comment to D21124: Make umtxq_check_susp() to correctly handle thread exit requests..

This doesn't seem to fix the SIGKILL issue.

~ # procstat -kk 19680
  PID    TID COMM                TDNAME              KSTACK
19680 101200 python2.7           -                   __mtx_lock_sleep+0x118 __mtx_lock_flags+0x102 _sleep+0x334 umtxq_busy+0xb7 do_sem_wait+0x150 __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
19680 101634 python2.7           -                   mi_switch+0x174 sleepq_switch+0x110 sleepq_catch_signals+0x417 sleepq_wait_sig+0xf _sleep+0x2d0 umtxq_sleep+0x153 do_sem_wait+0x41c __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
19680 101635 python2.7           -                   _mtx_lock_spin_cookie+0x231 __mtx_lock_spin_flags+0xf8 wakeup_one+0xf do_sem_wait+0x26f __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
~ # kill -9 19680
~ # procstat -kk 19680
  PID    TID COMM                TDNAME              KSTACK
19680 101200 python2.7           -                   __mtx_lock_flags+0xc1 do_sem_wait+0x218 __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
19680 101634 python2.7           -                   mi_switch+0x174 sleepq_switch+0x110 sleepq_catch_signals+0x417 sleepq_wait_sig+0xf _sleep+0x2d0 umtxq_sleep+0x153 do_sem_wait+0x41c __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
19680 101635 python2.7           -                   __mtx_lock_sleep+0x118 __mtx_lock_flags+0x102 do_sem_wait+0x148 __umtx_op_sem_wait+0x6e amd64_syscall+0x2bb fast_syscall_common+0x101
~ # procstat -i 19680|grep -v -- ---|grep KILL
19680 python2.7        KILL     P--
Wed, Jul 31, 8:20 PM

Tue, Jul 30

bdrewery committed rP507681: Grammar nit.
Grammar nit
Tue, Jul 30, 9:09 PM
bdrewery added inline comments to rS350446: Handle refcount(9) wraparound..
Tue, Jul 30, 6:53 PM
bdrewery added inline comments to rS350446: Handle refcount(9) wraparound..
Tue, Jul 30, 6:33 PM
bdrewery added inline comments to rS350446: Handle refcount(9) wraparound..
Tue, Jul 30, 6:18 PM

Sun, Jul 28

bdrewery committed rP507530: NOCCACHE also disables setting CCACHE_WRAPPER_PATH which can break the build..
NOCCACHE also disables setting CCACHE_WRAPPER_PATH which can break the build.
Sun, Jul 28, 8:28 PM

Fri, Jul 26

bdrewery added a comment to D17906: rm(1): Formalize non-functional status of -P flag.

This is a massive POLA violation. What the hell. You took a flag that was intended to make <some effort> to overwrite data and made it SILENTLY DO NOTHING. That's insane.

Fri, Jul 26, 7:23 AM

Jul 24 2019

bdrewery committed rP507274: - Update to 3.3.0-90-gd6f021339.
- Update to 3.3.0-90-gd6f021339
Jul 24 2019, 4:21 PM

Jul 19 2019

bdrewery committed rP506960: Update to 1.3.0..
Update to 1.3.0.
Jul 19 2019, 7:29 PM
bdrewery committed rP506959: - Update gssapi patch for 8.0.
- Update gssapi patch for 8.0
Jul 19 2019, 7:18 PM
bdrewery committed rS350119: Rework some multi-output target dependency handling..
Rework some multi-output target dependency handling.
Jul 19 2019, 12:15 AM

Jul 18 2019

bdrewery committed rP506878: Fix BROKEN handling for x509/gssapi FLAVORS.
Fix BROKEN handling for x509/gssapi FLAVORS
Jul 18 2019, 8:10 PM

Jul 13 2019

bdrewery committed rP506548: Don't try splitting symbols out of .a archives..
Don't try splitting symbols out of .a archives.
Jul 13 2019, 5:32 PM

Jul 12 2019

bdrewery added inline comments to D20261: [PowerPC64] Adds support for using ld.bfd on LIB32 and STAND, when default linker is ld.lld.
Jul 12 2019, 5:00 PM
bdrewery committed rP506433: Update to 8.0p1.
Update to 8.0p1
Jul 12 2019, 3:49 AM

Jul 10 2019

bdrewery committed rP506358: Fix handling of ports with *1* file..
Fix handling of ports with *1* file.
Jul 10 2019, 4:18 PM

Jul 4 2019

bdrewery committed rS349729: Consider *clean targets as non-build targets as well..
Consider *clean targets as non-build targets as well.
Jul 4 2019, 2:51 PM

Jun 30 2019

bdrewery committed rP505522: Reduce code duplication from r504140..
Reduce code duplication from r504140.
Jun 30 2019, 11:03 PM

Jun 26 2019

bdrewery committed rP505131: generate-symbols: Commit a working version..
generate-symbols: Commit a working version.
Jun 26 2019, 1:19 AM
bdrewery committed rP505130: Revert r505129: I still have the wrong version..
Revert r505129: I still have the wrong version.
Jun 26 2019, 1:07 AM
bdrewery committed rP505129: Allow generate-symbols.sh to actually work..
Allow generate-symbols.sh to actually work.
Jun 26 2019, 12:45 AM

Jun 19 2019

bdrewery committed rS349202: Follow-up r349065: Fix .TARGET flag ambiguity with PROGS which broke MK_TESTS..
Follow-up r349065: Fix .TARGET flag ambiguity with PROGS which broke MK_TESTS.
Jun 19 2019, 7:19 PM

Jun 18 2019

bdrewery committed rS349179: Rework r349061: Don't apply guessed dependencies if there is a custom target..
Rework r349061: Don't apply guessed dependencies if there is a custom target.
Jun 18 2019, 10:00 PM

Jun 16 2019

bdrewery committed rS349099: symlinkat(2) is not covered..
symlinkat(2) is not covered.
Jun 16 2019, 5:12 AM

Jun 15 2019

bdrewery committed rS349067: Support reading in .depend files..
Support reading in .depend files.
Jun 15 2019, 5:08 PM
bdrewery committed rS349068: Allow DEPENDOBJS/DEPENDSRCS to work with only OBJS set and no SRCS..
Allow DEPENDOBJS/DEPENDSRCS to work with only OBJS set and no SRCS.
Jun 15 2019, 5:08 PM
bdrewery committed rS349069: csu: Add proper .depend tracking for each object..
csu: Add proper .depend tracking for each object.
Jun 15 2019, 5:08 PM
bdrewery committed rS349066: META_MODE: Delete build targets that fail..
META_MODE: Delete build targets that fail.
Jun 15 2019, 5:08 PM
bdrewery committed rS349065: Add various CFLAGS/LDADD overrides for the output target file..
Add various CFLAGS/LDADD overrides for the output target file.
Jun 15 2019, 5:08 PM
bdrewery committed rS349064: Avoid generating DEPENDFILES='.depend.' when there's no DEPENDOBJS..
Avoid generating DEPENDFILES='.depend.' when there's no DEPENDOBJS.
Jun 15 2019, 5:08 PM
bdrewery committed rS349063: Similar to r335710 avoid ccache when linking a .cc file directly..
Similar to r335710 avoid ccache when linking a .cc file directly.
Jun 15 2019, 5:08 PM
bdrewery committed rS349062: Fix .depend files to work for build tools..
Fix .depend files to work for build tools.
Jun 15 2019, 5:08 PM
bdrewery committed rS349061: Don't force OBJS_DEPEND_GUESS headers onto all objects..
Don't force OBJS_DEPEND_GUESS headers onto all objects.
Jun 15 2019, 5:08 PM

Jun 13 2019

bdrewery committed rP504140: parse_plist: Avoid excess fork+exec inside the loop for stripping (mode) lines..
parse_plist: Avoid excess fork+exec inside the loop for stripping (mode) lines.
Jun 13 2019, 10:22 PM
bdrewery committed rP504139: Remove the .error as it is causing unintended side effects..
Remove the .error as it is causing unintended side effects.
Jun 13 2019, 10:14 PM

Jun 12 2019

bdrewery committed rS349005: Don't delete .depend files outside of cleandepend..
Don't delete .depend files outside of cleandepend.
Jun 12 2019, 11:09 PM
bdrewery committed rS348979: Stop using .OODATE for extracting firmware..
Stop using .OODATE for extracting firmware.
Jun 12 2019, 12:03 AM

Jun 11 2019

bdrewery committed rS348976: Add missing DPSRCS entry for assym.inc..
Add missing DPSRCS entry for assym.inc.
Jun 11 2019, 11:35 PM
bdrewery committed rS348975: Restore genassym.o to CLEANFILES..
Restore genassym.o to CLEANFILES.
Jun 11 2019, 11:35 PM
bdrewery committed rP503998: Speedup ELF file detection almost 100%..
Speedup ELF file detection almost 100%.
Jun 11 2019, 10:56 PM
bdrewery committed rP503996: Fix MAKE_JOBS support..
Fix MAKE_JOBS support.
Jun 11 2019, 10:30 PM

Jun 10 2019

bdrewery committed rP503929: Add debug for BUILD_DEPENDS .error.
Add debug for BUILD_DEPENDS .error
Jun 10 2019, 10:49 PM
bdrewery committed rS348877: DPSRCS need to be built before recursing..
DPSRCS need to be built before recursing.
Jun 10 2019, 7:38 PM

May 30 2019

bdrewery accepted D20476: makesyscalls.sh: always use absolute path for syscalls.conf.
May 30 2019, 8:50 PM
bdrewery requested changes to D20476: makesyscalls.sh: always use absolute path for syscalls.conf.
May 30 2019, 8:43 PM

May 20 2019

bdrewery committed rP502126: Fix recursive dependency issue with gmake..
Fix recursive dependency issue with gmake.
May 20 2019, 5:06 PM

May 18 2019

bdrewery committed rP501985: Update ccache to 3.7.1.
Update ccache to 3.7.1
May 18 2019, 9:53 PM

May 10 2019

bdrewery committed rS347458: Fix build race with machine links and genoffset.o..
Fix build race with machine links and genoffset.o.
May 10 2019, 6:09 PM

Apr 19 2019

bdrewery accepted D19853: [security/nist-kat]: Add AES-CCM and plain SHA digest test vectors..

Ports approved

Apr 19 2019, 10:55 PM

Apr 16 2019

bdrewery committed rS346255: Fix 'jot -r 0 start end' to work..
Fix 'jot -r 0 start end' to work.
Apr 16 2019, 12:41 AM

Mar 27 2019

bdrewery accepted D19482: If CROSS_TOOLCHAIN isn't set, look for base toolchain makefiles..

Technically seems fine.
Feels like a POLA issue though. If I happened to have some package installed then buildworld behaved differently.
Maybe CROSS_TOOLCHAIN=yes or CROSS_TOOLCHAIN=base?
I don't really care either way; default on like you have is fine too as I don't fully understand the use case.

Mar 27 2019, 9:00 PM

Mar 20 2019

bdrewery committed rS345351: Build common kernel dependencies before modules..
Build common kernel dependencies before modules.
Mar 20 2019, 10:50 PM

Mar 11 2019

bdrewery committed rP495387: Update to 3.3.2.
Update to 3.3.2
Mar 11 2019, 8:13 PM
bdrewery committed rP495386: Update to 3.3.0-62-g5abf90c67.
Update to 3.3.0-62-g5abf90c67
Mar 11 2019, 8:13 PM

Mar 9 2019

bdrewery committed rP495193: - Update to 3.3.0-59-g6e1132813.
- Update to 3.3.0-59-g6e1132813
Mar 9 2019, 6:52 PM
bdrewery committed rP495191: MFH: r495190.
MFH: r495190
Mar 9 2019, 6:39 PM
bdrewery committed rP495190: Respect UID_FILES..
Respect UID_FILES.
Mar 9 2019, 6:38 PM
bdrewery committed rP495096: Drop maintainership.
Drop maintainership
Mar 9 2019, 3:35 AM

Mar 4 2019

bdrewery committed rS344781: MFC r344666:.
MFC r344666:
Mar 4 2019, 9:10 PM

Mar 1 2019

bdrewery added a comment to D19426: post-commit hooks: Accept BZ URLs in PR lines.

Check out rP154065.
All of the PRs linked there were filed in GNATS but were mapped over in BUGZILLA so they had the same numbers.
Had they been GNATS urls they would be more annoying to deal with IMO as the links would all be dead now. I realize this is an objective opinion. I would be comfortable with simply "https://bugs.freebsd.org/12344" as that can likely work forever.

Mar 1 2019, 9:29 PM
bdrewery committed rP494303: Update to 3.3.1.
Update to 3.3.1
Mar 1 2019, 4:24 PM
bdrewery committed rP494219: Update to 3.3.0-36-g824cd5d40.
Update to 3.3.0-36-g824cd5d40
Mar 1 2019, 12:52 AM

Feb 28 2019

bdrewery committed rS344668: MFC r343877,r343880:.
MFC r343877,r343880:
Feb 28 2019, 8:57 PM
bdrewery committed rS344667: MFC r343877,r343880:.
MFC r343877,r343880:
Feb 28 2019, 8:57 PM
bdrewery committed rS344666: bsd.nls.mk isn't optional..
bsd.nls.mk isn't optional.
Feb 28 2019, 8:48 PM
bdrewery added a comment to D16868: Add a BUILD_WITH_OPIPEFAIL option to use `bash -o pipefail` as the bmake shell.

Jilles mentioned on IRC a simpler way in the wrapper to enable it without the set -o call:

command set -o pipefail 2>/dev/null || :
Feb 28 2019, 6:57 PM
bdrewery added a comment to D16868: Add a BUILD_WITH_OPIPEFAIL option to use `bash -o pipefail` as the bmake shell.

Has this turned up any bad pipelines in Makefiles?

Ah right there is that dd one from a while back.
Now that pipefail is in we could do this a lot simpler like tools/install.sh works.
I don't think it needs to be a MK_ option.
It doesn't need to install.
Maybe something like this could work in tools/sh.sh that we just set with __MAKE_SHELL=?

#! /bin/sh
set -o pipefail 2>/dev/null || :
exec "$@"

Hmm set -o pipefail || : doesn't actually ignore the error.

# sh -ec 'set -o pipefail || :; echo test'
set: Illegal option -o pipefail

:(

Feb 28 2019, 1:06 AM
bdrewery added a comment to D16868: Add a BUILD_WITH_OPIPEFAIL option to use `bash -o pipefail` as the bmake shell.

Has this turned up any bad pipelines in Makefiles?

Ah right there is that dd one from a while back.
Now that pipefail is in we could do this a lot simpler like tools/install.sh works.
I don't think it needs to be a MK_ option.
It doesn't need to install.
Maybe something like this could work in tools/sh.sh that we just set with __MAKE_SHELL=?

#! /bin/sh
set -o pipefail 2>/dev/null || :
exec "$@"
Feb 28 2019, 12:59 AM

Feb 27 2019

bdrewery added a comment to D16868: Add a BUILD_WITH_OPIPEFAIL option to use `bash -o pipefail` as the bmake shell.

Has this turned up any bad pipelines in Makefiles?

Feb 27 2019, 11:27 PM
bdrewery added a comment to D16868: Add a BUILD_WITH_OPIPEFAIL option to use `bash -o pipefail` as the bmake shell.

Has this turned up any bad pipelines in Makefiles?

Feb 27 2019, 10:46 PM
bdrewery added a comment to D16762: Don't delete the source file when installing links on case-insensitive file systems.

This seems incomplete. It's just fixing the specific cases having problems today?
Why shouldn't we mandate enabling case-sensitivity on the filesystem first?

Feb 27 2019, 10:45 PM

Feb 26 2019

bdrewery committed rP493976: Update to 3.3.0.
Update to 3.3.0
Feb 26 2019, 6:26 PM
bdrewery committed rP493975: Update to 3.3.30 release..
Update to 3.3.30 release.
Feb 26 2019, 6:22 PM

Feb 25 2019

bdrewery committed rP493900: - Update to 3.2.8-438-ga95f2cbfe.
- Update to 3.2.8-438-ga95f2cbfe
Feb 25 2019, 9:54 PM

Feb 12 2019

bdrewery committed rP492801: - Update to 3.2.8-432-g070fc33be.
- Update to 3.2.8-432-g070fc33be
Feb 12 2019, 8:34 PM

Feb 8 2019

bdrewery added inline comments to D19087: [new port] devel/libcxx-gdb: libc++ pretty printers for GDB..
Feb 8 2019, 9:29 PM

Feb 7 2019

bdrewery committed rS343886: MFC r337272:.
MFC r337272:
Feb 7 2019, 11:57 PM
bdrewery committed rS343885: MFC r337272:.
MFC r337272:
Feb 7 2019, 11:55 PM
bdrewery committed rS343883: MFC r343633:.
MFC r343633:
Feb 7 2019, 10:50 PM
bdrewery committed rS343880: Fix build of r343877.
Fix build of r343877
Feb 7 2019, 9:41 PM
bdrewery committed rS343879: MFC r343633:.
MFC r343633:
Feb 7 2019, 9:37 PM
bdrewery committed rS343878: MFC r343633:.
MFC r343633:
Feb 7 2019, 9:22 PM
bdrewery committed rS343877: ipfw table list: Fix showing header outside of 'all'..
ipfw table list: Fix showing header outside of 'all'.
Feb 7 2019, 9:05 PM

Jan 31 2019

bdrewery committed rS343633: Shar files may be seen as binary by grep..
Shar files may be seen as binary by grep.
Jan 31 2019, 11:21 PM

Jan 23 2019

bdrewery added inline comments to D18623: Address the fact that errors from `copyout(9)` are not properly percolated up on failure.
Jan 23 2019, 10:52 PM

Jan 15 2019

bdrewery committed rP490435: MFH: r490434.
MFH: r490434
Jan 15 2019, 11:17 PM
bdrewery committed rP490434: Fix build of ccache-memcached-static sasl2 update in r485191.
Fix build of ccache-memcached-static sasl2 update in r485191
Jan 15 2019, 11:14 PM
bdrewery accepted D17251: Use .undef per variable.
Jan 15 2019, 10:28 PM