Even if it's a bug in node, the symlink option installs a symlink to /usr/local/openssl/cert.pem, and now the package does not do that. It's a simple hack to keep locally but there is a behavior change here that was probably not intended.

Why? I assume certctl is expected to do the right thing but it doesn't. The port was installing a symlink to /usr/local/openssl/cert.pem but now nothing lands there and node breaks.

I would definitely prefer to keep the 3 second slop

I ended up moving the LIBWRAP stuff to the tcpwrappers patch but it's still there.

Merging into D53273

Merging into D53273

Merging into D53273

Merging into D53273

D53268 covers this. The servconf changes belongs there. It will come in with the ports change.

I have this staged for commit in ports for D53268. The version.h removal I'll bring in eventually. It's part of a lot of glue so can't come out easily.

I have this staged to commit to ports. Thank you.

Can we get a test added for this?

In D55191#1294886, @des wrote:

I'm still waiting for someone to explain what this is supposed to mean:

Since the test assumes a 250 ms response time, the test delay can be 1 second instead of 3.

Thank you! I ran it through poudriere's test suite with no problems.

Nice work

• Fix handling of case 3

This still has a problem with the 3rd case.

# 3. Common sources in SRCS.
#         SRCS= common.c
#         SRCS.prog1= prog1.c
#         SRCS.prog2= prog2.c

The common.o.meta is not getting generated.

• Add additional comment clarifying this code is used in the parent _and_ when recursing.

It was pointed out to me that "current current" should be interpreted as "current CURRENT" which makes sense. So not a typo.

Commit message typo "current current"

In D24007#1256532, @bdrewery wrote:

This change is super confusing. Why are some cr* converted to crcow* and others (rest of the kernel) not? I'm porting this to downstream changes. It's not great that _credential code_ is this confusing and inconsistent.

This change is super confusing. Why are some cr* converted to crcow* and others (rest of the kernel) not? I'm porting this to downstream changes. It's not great that _credential code_ is this confusing and inconsistent.

In D53964#1233038, @cperciva wrote:

In D53964#1233037, @bdrewery wrote:

In D53964#1232996, @philip wrote:

We could probably shave off several seconds for many people by replacing pkg+https with pkg+http. The TLS n-way handshake is a complete waste of time. I have made this observation about the other repositories as well but...

Windmills. Have to keep trying.

Agreed. All https buys us here is quieting an FAQ. It otherwise adds time and potentially has problems in some corporate setups.

It does provide a little bit of protection against rollback attacks. Not much, though; there's a reason I used HTTP for freebsd-update.

The main reason I used HTTPS here was because that's what the other repositories used and I wanted to minimize the number of bikesheds I had to paint.