Page MenuHomeFreeBSD
People bdrewery

bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (249 w, 4 d)

Recent Activity
View All

Tue, Feb 12

bdrewery committed rP492801: - Update to 3.2.8-432-g070fc33be.
- Update to 3.2.8-432-g070fc33be
Tue, Feb 12, 8:34 PM

Fri, Feb 8

bdrewery added inline comments to D19087: [new port] devel/libcxx-gdb: libc++ pretty printers for GDB..
Fri, Feb 8, 9:29 PM

Thu, Feb 7

bdrewery committed rS343886: MFC r337272:.
MFC r337272:
Thu, Feb 7, 11:57 PM
bdrewery committed rS343885: MFC r337272:.
MFC r337272:
Thu, Feb 7, 11:55 PM
bdrewery committed rS343883: MFC r343633:.
MFC r343633:
Thu, Feb 7, 10:50 PM
bdrewery committed rS343880: Fix build of r343877.
Fix build of r343877
Thu, Feb 7, 9:41 PM
bdrewery committed rS343879: MFC r343633:.
MFC r343633:
Thu, Feb 7, 9:37 PM
bdrewery committed rS343878: MFC r343633:.
MFC r343633:
Thu, Feb 7, 9:22 PM
bdrewery committed rS343877: ipfw table list: Fix showing header outside of 'all'..
ipfw table list: Fix showing header outside of 'all'.
Thu, Feb 7, 9:05 PM

Thu, Jan 31

bdrewery committed rS343633: Shar files may be seen as binary by grep..
Shar files may be seen as binary by grep.
Thu, Jan 31, 11:21 PM

Wed, Jan 23

bdrewery added inline comments to D18623: Address the fact that errors from `copyout(9)` are not properly percolated up on failure.
Wed, Jan 23, 10:52 PM

Jan 15 2019

bdrewery committed rP490435: MFH: r490434.
MFH: r490434
Jan 15 2019, 11:17 PM
bdrewery committed rP490434: Fix build of ccache-memcached-static sasl2 update in r485191.
Fix build of ccache-memcached-static sasl2 update in r485191
Jan 15 2019, 11:14 PM
bdrewery accepted D17251: Use .undef per variable.
Jan 15 2019, 10:28 PM
bdrewery accepted D18847: Fix STAGE_DIR.* setting inline with recent changes..

Looks ok. I didn't dive in very deep.

Jan 15 2019, 10:28 PM

Dec 5 2018

bdrewery added a comment to D14244: crossbuild: Allow bootstrapping libopenbsd on Linux.
In D14244#388189, @emaste wrote:

I don't really like this, but given that any failure should be fairly straightforward to track down OK.

(I'd probably prefer some sort of #ifdef linux in getdtablecount.c itself with a #warning and a stub implementation.)

Dec 5 2018, 7:50 PM

Dec 4 2018

bdrewery added inline comments to D17820: Don't hardcode X_ prefix on fallback path for X_COMPILER_*/X_LINKER_*.
Dec 4 2018, 11:12 PM
bdrewery added inline comments to D17820: Don't hardcode X_ prefix on fallback path for X_COMPILER_*/X_LINKER_*.
Dec 4 2018, 11:05 PM
bdrewery added inline comments to D17820: Don't hardcode X_ prefix on fallback path for X_COMPILER_*/X_LINKER_*.
Dec 4 2018, 10:58 PM
bdrewery added inline comments to D17820: Don't hardcode X_ prefix on fallback path for X_COMPILER_*/X_LINKER_*.
Dec 4 2018, 10:54 PM
bdrewery added inline comments to D17820: Don't hardcode X_ prefix on fallback path for X_COMPILER_*/X_LINKER_*.
Dec 4 2018, 10:44 PM
bdrewery requested changes to D17820: Don't hardcode X_ prefix on fallback path for X_COMPILER_*/X_LINKER_*.
Dec 4 2018, 10:37 PM

Nov 19 2018

bdrewery accepted D17971: Add capsicum_helpers.h to -legacy if needed.
Nov 19 2018, 5:29 PM

Nov 14 2018

bdrewery added a comment to D17990: Avoid realpath(3) if not needed..
~/git/poudriere3 # cat /usr/local/bin/clang70
#!/bin/sh
# $FreeBSD: head/devel/llvm70/files/llvm-wrapper.sh.in 466018 2018-03-31 03:28:42Z tobik $
Nov 14 2018, 10:07 PM
bdrewery created D17990: Avoid realpath(3) if not needed..
Nov 14 2018, 6:24 PM
bdrewery committed rP484937: Use exec in wrapper to avoid an extra shell process sticking around..
Use exec in wrapper to avoid an extra shell process sticking around.
Nov 14 2018, 6:12 PM

Nov 12 2018

bdrewery committed rP484843: MFH: r484842.
MFH: r484842
Nov 12 2018, 9:56 PM
bdrewery committed rP484842: - Fix X509 build after r484765 openssl fix.
- Fix X509 build after r484765 openssl fix
Nov 12 2018, 9:55 PM
bdrewery committed rP484825: MFH: r484765 r484823 r484824.
MFH: r484765 r484823 r484824
Nov 12 2018, 9:06 PM
bdrewery committed rP484824: - Update KERB_GSSAPI for 7.9p1.
- Update KERB_GSSAPI for 7.9p1
Nov 12 2018, 9:04 PM
bdrewery committed rP484823: - Fix HPN for 7.9p1.
- Fix HPN for 7.9p1
Nov 12 2018, 8:56 PM

Nov 11 2018

bdrewery committed rP484765: Update to 7.9p1..
Update to 7.9p1.
Nov 11 2018, 8:21 PM

Nov 9 2018

bdrewery committed rD52478: Extend my key more.
Extend my key more
Nov 9 2018, 11:17 PM

Nov 8 2018

bdrewery accepted D17899: Add a top-level target to rebuild all sysent files..

Thanks!

Nov 8 2018, 12:29 AM
bdrewery added a comment to D17899: Add a top-level target to rebuild all sysent files..
In D17899#382351, @bdrewery wrote:

I don't think this _must_ be in Makefile.inc1 but it's simpler to put it there to ensure the right bmake and share/mk is used, so fine to be there.

Nov 8 2018, 12:18 AM
bdrewery requested changes to D17899: Add a top-level target to rebuild all sysent files..

I don't think this _must_ be in Makefile.inc1 but it's simpler to put it there to ensure the right bmake and share/mk is used, so fine to be there.

Nov 8 2018, 12:18 AM
bdrewery added inline comments to D17899: Add a top-level target to rebuild all sysent files..
Nov 8 2018, 12:05 AM

Nov 7 2018

bdrewery added inline comments to D17899: Add a top-level target to rebuild all sysent files..
Nov 7 2018, 11:48 PM
bdrewery added inline comments to D17899: Add a top-level target to rebuild all sysent files..
Nov 7 2018, 11:40 PM
bdrewery accepted D17882: devel/elfutils: Unbreak gcc8 build.

reviewed and approved

Nov 7 2018, 9:07 PM

Nov 5 2018

bdrewery added a comment to D16842: Fix non-FreeBSD host lib32 build for TARGET=amd64.
In D16842#359095, @jhb wrote:

Agreed that as a followup we should define a single variable in src/Makefile.inc1 to hold 'freebsd12.0'. Will be useful since we are about to bump it to 13 in a few weeks.

Nov 5 2018, 11:27 PM
bdrewery added a comment to D16842: Fix non-FreeBSD host lib32 build for TARGET=amd64.

I don't get emails for phabricator emails.
I do get and respond to IRC usually instantly.
Please get my feedback for further build changes.

Nov 5 2018, 11:26 PM

Oct 26 2018

bdrewery committed rD52409: Update my key after bumping the expiry some time ago.
Update my key after bumping the expiry some time ago
Oct 26 2018, 9:19 PM

Oct 24 2018

bdrewery committed rP482941: - Update to 3.2.8-402-g73eefa2e6.
- Update to 3.2.8-402-g73eefa2e6
Oct 24 2018, 10:17 PM
bdrewery committed rP482940: Update to 3.2.8.
Update to 3.2.8
Oct 24 2018, 10:09 PM

Oct 16 2018

bdrewery added inline comments to D14599: Implement kernel code coverage (kcov).
Oct 16 2018, 7:23 PM

Oct 11 2018

bdrewery committed rP481847: Need to define PORTVERSION later due to depending on MEMCACHED option..
Need to define PORTVERSION later due to depending on MEMCACHED option.
Oct 11 2018, 7:37 PM

Oct 3 2018

bdrewery requested changes to D16856: Initial proposed patch for SSL root bundle in base.

Please also don't checkin generated files in the initial commit. As-is it makes it hard to review.

Oct 3 2018, 9:24 PM
bdrewery committed rP481187: - MEMCACHED with no DOCS: Remove dependency on asciidoc which is required.
- MEMCACHED with no DOCS: Remove dependency on asciidoc which is required
Oct 3 2018, 8:21 PM
bdrewery committed rP481183: - Update to 3.4.3.
- Update to 3.4.3
Oct 3 2018, 7:58 PM
bdrewery committed rP481181: Note why CXX is used here.
Note why CXX is used here
Oct 3 2018, 7:26 PM

Oct 1 2018

bdrewery accepted D17279: Define a ifunc-noplt linker feature..
Oct 1 2018, 8:12 PM

Sep 27 2018

bdrewery committed rP480806: - Fix build on powerpc64.
- Fix build on powerpc64
Sep 27 2018, 4:55 PM

Sep 26 2018

bdrewery added inline comments to D17331: Remove -m (update) from ldconfig -32 invocation on startup..
Sep 26 2018, 11:18 PM
bdrewery committed rS338950: Handle overflow of uid or gid in arguments for chown.
Handle overflow of uid or gid in arguments for chown
Sep 26 2018, 6:41 PM
bdrewery closed D15119: Handle overflow of uid or gid in arguments for chown.
Sep 26 2018, 6:41 PM · Contributor Reviews (base)

Sep 17 2018

bdrewery committed rS338738: DIRS: Rework how duplicated dirs are installed..
DIRS: Rework how duplicated dirs are installed.
Sep 17 2018, 10:15 PM
bdrewery committed rS338737: installdirs can be a recursive/standalone target..
installdirs can be a recursive/standalone target.
Sep 17 2018, 10:15 PM
bdrewery committed rS338736: PROGS: Don't redundantly process DIRS..
PROGS: Don't redundantly process DIRS.
Sep 17 2018, 10:15 PM
bdrewery committed rS338735: DIRS: installdirs should also be .PHONY.
DIRS: installdirs should also be .PHONY
Sep 17 2018, 10:15 PM

Sep 13 2018

bdrewery committed rP479748: Update to 2.0.2.
Update to 2.0.2
Sep 13 2018, 10:24 PM
bdrewery committed rP479695: - Update to 0.5.10.2 [1].
- Update to 0.5.10.2 [1]
Sep 13 2018, 8:59 PM
bdrewery committed rP479694: Update to 0.6.1.
Update to 0.6.1
Sep 13 2018, 8:45 PM
bdrewery requested changes to D17002: Fix compilation with upstream clang builtin headers.
Sep 13 2018, 8:13 PM

Sep 6 2018

bdrewery requested changes to D16334: Build libbearssl for loader and sbin/veriexec.
Sep 6 2018, 12:24 PM
bdrewery added inline comments to D16335: Build libve for loader and sbin/veriexec.
Sep 6 2018, 12:24 PM
bdrewery requested changes to D16335: Build libve for loader and sbin/veriexec.
Sep 6 2018, 12:24 PM
bdrewery accepted D16337: Build options etc for libbearssl and libve.
Sep 6 2018, 12:24 PM
bdrewery requested changes to D16337: Build options etc for libbearssl and libve.

Can't evaluate lib/Makefile changes without the rest of the changes. I.e., does it require dependency changes in Makefile.inc1's make libraries handling? Can't tell from this.

Sep 6 2018, 12:24 PM

Aug 16 2018

bdrewery committed rS337928: Fix build after r337852: Don't rebuild moduli based on unrelated moduli.c.
Fix build after r337852: Don't rebuild moduli based on unrelated moduli.c
Aug 16 2018, 7:48 PM

Aug 9 2018

bdrewery accepted D16033: Add LLVM BPF backend.

Remove my blocker - I think it's fine in general if off-by-default

Aug 9 2018, 7:12 PM

Aug 8 2018

bdrewery committed rS337507: MFC r326569:.
MFC r326569:
Aug 8 2018, 10:42 PM
bdrewery committed rS337499: MFC r320280,r320281,r320282,r320283,r320284,r320285,r320692,r322362,r322401….
MFC r320280,r320281,r320282,r320283,r320284,r320285,r320692,r322362,r322401…
Aug 8 2018, 7:36 PM
bdrewery committed rS337498: Revert r325808 (MFC r322401) to re-MFC with larger set.
Revert r325808 (MFC r322401) to re-MFC with larger set
Aug 8 2018, 7:32 PM
bdrewery committed rS337496: MFC r320274:.
MFC r320274:
Aug 8 2018, 7:21 PM
bdrewery committed rS337495: DIRS: Fix duplicate target warnings..
DIRS: Fix duplicate target warnings.
Aug 8 2018, 7:16 PM
bdrewery committed rS337494: DIRS: Ensure existing directory still has permissions set..
DIRS: Ensure existing directory still has permissions set.
Aug 8 2018, 7:16 PM
bdrewery committed rS337493: MFC r320191:.
MFC r320191:
Aug 8 2018, 7:03 PM
bdrewery committed rS337492: MFC r320286:.
MFC r320286:
Aug 8 2018, 7:01 PM
bdrewery committed rS337491: MFC r321333:.
MFC r321333:
Aug 8 2018, 6:59 PM
bdrewery committed rS337490: MFC r321333:.
MFC r321333:
Aug 8 2018, 6:59 PM
bdrewery committed rS337489: MFC r321491:.
MFC r321491:
Aug 8 2018, 6:58 PM
bdrewery committed rS337488: MFC r321492:.
MFC r321492:
Aug 8 2018, 6:56 PM
bdrewery committed rS337487: MFC r322565,r323323:.
MFC r322565,r323323:
Aug 8 2018, 6:55 PM
bdrewery committed rS337486: MFC r323620:.
MFC r323620:
Aug 8 2018, 6:54 PM
bdrewery committed rS337485: MFC r323620:.
MFC r323620:
Aug 8 2018, 6:53 PM
bdrewery committed rS337484: MFC r324103:.
MFC r324103:
Aug 8 2018, 6:52 PM
bdrewery committed rS337481: MFC r326552:.
MFC r326552:
Aug 8 2018, 6:50 PM
bdrewery committed rS337480: MFC r335922:.
MFC r335922:
Aug 8 2018, 6:48 PM
bdrewery committed rS337479: MFC r335912:.
MFC r335912:
Aug 8 2018, 6:46 PM
bdrewery committed rS337478: MFC r335923:.
MFC r335923:
Aug 8 2018, 6:41 PM
bdrewery committed rS337477: MFC r335733:.
MFC r335733:
Aug 8 2018, 6:05 PM
bdrewery committed rS337476: MFC r310789,r314901:.
MFC r310789,r314901:
Aug 8 2018, 6:04 PM
bdrewery committed rS337475: MFC r335709:.
MFC r335709:
Aug 8 2018, 5:59 PM
bdrewery committed rS337474: MFC r335708:.
MFC r335708:
Aug 8 2018, 5:58 PM
bdrewery committed rS337473: MFC r335704:.
MFC r335704:
Aug 8 2018, 5:57 PM
bdrewery committed rS337472: MFC r335244:.
MFC r335244:
Aug 8 2018, 5:50 PM
bdrewery committed rS337471: MFC r335183:.
MFC r335183:
Aug 8 2018, 5:49 PM
bdrewery committed rS337470: MFC r335183:.
MFC r335183:
Aug 8 2018, 5:48 PM

Aug 3 2018

bdrewery committed rS337272: Fix some filemon path logging issues..
Fix some filemon path logging issues.
Aug 3 2018, 7:24 PM