Page MenuHomeFreeBSD

bdrewery (Bryan Drewery)
User

Projects

User Details

User Since
May 10 2014, 4:48 PM (394 w, 5 d)

Recent Activity

Yesterday

bdrewery committed R10:8f82dc8dd3ff: hyperv: Flag hn and storvsc statistics with CTLFLAG_STATS. (authored by dgmorris_earthlink.net).
hyperv: Flag hn and storvsc statistics with CTLFLAG_STATS.
Thu, Dec 2, 6:47 PM
bdrewery closed D30060: Flag hn and storvsc statistics with CTLFLAG_STATS..
Thu, Dec 2, 6:47 PM
bdrewery accepted D30060: Flag hn and storvsc statistics with CTLFLAG_STATS..
Thu, Dec 2, 6:45 PM

Tue, Nov 30

bdrewery committed R11:d541dfc457b3: ports-mgmt/poudriere-devel: Update to 3.3.0-1068-g8d0342ef6 (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-1068-g8d0342ef6
Tue, Nov 30, 8:10 PM

Mon, Nov 29

bdrewery added a comment to D32369: devel/git: Split into subpackages.

Very nice. Thank you!

Mon, Nov 29, 8:08 PM

Thu, Nov 25

bdrewery committed R10:971677d5fd4c: sh: Avoid some headers when NO_HISTORY is set. (authored by bdrewery).
sh: Avoid some headers when NO_HISTORY is set.
Thu, Nov 25, 1:55 AM

Wed, Nov 24

bdrewery committed R11:6bdec1b29902: textproc/muse: Ensure that EMACS_DEFAULT is considered for default FLAVOR (authored by bdrewery).
textproc/muse: Ensure that EMACS_DEFAULT is considered for default FLAVOR
Wed, Nov 24, 5:23 AM
bdrewery committed R11:04dcdd1a96de: Mk/Uses/emacs.mk: Sort the default FLAVOR to be first in FLAVORS. (authored by bdrewery).
Mk/Uses/emacs.mk: Sort the default FLAVOR to be first in FLAVORS.
Wed, Nov 24, 5:23 AM

Tue, Nov 16

bdrewery committed R11:1aee6ce59094: devel/rbtools: Fix syntax error (authored by bdrewery).
devel/rbtools: Fix syntax error
Tue, Nov 16, 2:26 AM
bdrewery committed R11:3c8e68a28d3d: devel/rbtools: Add some missing dependencies (authored by bdrewery).
devel/rbtools: Add some missing dependencies
Tue, Nov 16, 1:57 AM

Oct 28 2021

bdrewery committed R11:604c4de998e9: ports-mgmt/poudriere-devel: Really fix non-amd64 build (authored by bdrewery).
ports-mgmt/poudriere-devel: Really fix non-amd64 build
Oct 28 2021, 9:37 PM
bdrewery committed R11:8c3cdd69f680: ports-mgmt/poudriere-devel: Update to 3.3.0-1022-g964cf327f (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-1022-g964cf327f
Oct 28 2021, 9:37 PM
bdrewery committed R11:470de1bf5ed4: ports-mgmt/poudriere-devel: Update to 3.3.0-1019-gef4526594 (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-1019-gef4526594
Oct 28 2021, 9:37 PM
bdrewery committed R11:48fdb60bb351: ports-mgmt/poudriere-devel: Update to 3.3.0-1020-g59a87677c (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-1020-g59a87677c
Oct 28 2021, 9:37 PM

Oct 26 2021

bdrewery accepted D32628: sh: Fix heredoc at certain places in case and for.

The here-document shall be treated as a single word that begins after the next <newline>

https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_07_04

Oct 26 2021, 5:06 PM

Oct 18 2021

bdrewery committed R11:f3b8c0953312: ports-mgmt/poudriere-devel: Really fix non-amd64 build (authored by bdrewery).
ports-mgmt/poudriere-devel: Really fix non-amd64 build
Oct 18 2021, 10:26 PM

Oct 17 2021

bdrewery committed R11:4116dc2f1f63: ports-mgmt/poudriere-devel: Update to 3.3.0-1022-g964cf327f (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-1022-g964cf327f
Oct 17 2021, 9:52 PM
bdrewery committed R11:14e5e1370ddb: ports-mgmt/poudriere-devel: Update to 3.3.0-1020-g59a87677c (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-1020-g59a87677c
Oct 17 2021, 7:25 PM

Oct 16 2021

bdrewery committed R11:7791106ed586: ports-mgmt/poudriere-devel: Update to 3.3.0-1019-gef4526594 (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-1019-gef4526594
Oct 16 2021, 3:58 AM
bdrewery committed R11:02dbfbc67645: security/openssh-portable: libfido fix went in 505373243 (authored by bdrewery).
security/openssh-portable: libfido fix went in 505373243
Oct 16 2021, 3:58 AM

Oct 15 2021

bdrewery committed R11:f4a5ae5fd8ee: security/openssh-portable: Fix sftp crash (authored by bdrewery).
security/openssh-portable: Fix sftp crash
Oct 15 2021, 5:10 PM

Oct 14 2021

bdrewery accepted D32495: Mk/bsd.port.mk: Add FLAVOR_SUB.
Oct 14 2021, 8:57 PM

Oct 12 2021

bdrewery committed R11:ce99ac162f41: security/openssh-portable: Bring in patch for CVE-2021-41617 (authored by bdrewery).
security/openssh-portable: Bring in patch for CVE-2021-41617
Oct 12 2021, 9:16 PM
bdrewery committed R11:dd274bdd8a81: security/vuxml: Update OpenSSH CVE-2021-41617 fix for quarterly commit (authored by bdrewery).
security/vuxml: Update OpenSSH CVE-2021-41617 fix for quarterly commit
Oct 12 2021, 9:16 PM
bdrewery committed R11:8d40d32ae373: security/openssh-portable: Fix build without LIBEDIT (authored by bdrewery).
security/openssh-portable: Fix build without LIBEDIT
Oct 12 2021, 9:07 PM
bdrewery committed R11:384966798240: security/openssh-portable: Update to 8.8p1 (authored by bdrewery).
security/openssh-portable: Update to 8.8p1
Oct 12 2021, 6:07 PM
bdrewery committed R11:3d4619833226: security/vuxml: Document OpenSSH CVE-2021-41617 (authored by bdrewery).
security/vuxml: Document OpenSSH CVE-2021-41617
Oct 12 2021, 6:07 PM

Sep 27 2021

bdrewery committed R11:fd74bc8eb2fe: security/openssh-portable: Fix default ssh-askpass path (authored by bdrewery).
security/openssh-portable: Fix default ssh-askpass path
Sep 27 2021, 10:43 PM

Sep 24 2021

bdrewery committed R10:e31fb97148f7: read builtin: Empty variables on timeout (authored by bdrewery).
read builtin: Empty variables on timeout
Sep 24 2021, 6:36 PM
bdrewery closed D31876: read builtin: Empty variables on timeout.
Sep 24 2021, 6:35 PM
bdrewery added a comment to D32098: ncurses: split libtinfo from libncurses.

Looks good.

Sep 24 2021, 5:59 PM

Sep 20 2021

bdrewery committed R11:497ca938c5ed: sysutils/monit: Update to 5.29.0 (authored by Martin Pala <martinp@tildeslash.com>).
sysutils/monit: Update to 5.29.0
Sep 20 2021, 9:32 PM

Sep 19 2021

bdrewery requested review of D32020: Mk/bsd.sanity.mk: Avoid loading this unless needed..
Sep 19 2021, 6:27 PM

Sep 14 2021

bdrewery accepted D31961: tzcode: Fix operation without WITH_DETECT_TZ_CHANGES.
Sep 14 2021, 7:01 PM

Sep 10 2021

bdrewery committed R11:d27003d56449: security/openssh-portable: Various build fixes (authored by bdrewery).
security/openssh-portable: Various build fixes
Sep 10 2021, 5:48 PM

Sep 9 2021

bdrewery committed R11:a981593ecc06: security/openssh-portable: Update to 8.7p1. (authored by bdrewery).
security/openssh-portable: Update to 8.7p1.
Sep 9 2021, 7:10 PM
bdrewery updated the diff for D31876: read builtin: Empty variables on timeout.
  • test feedback
  • avoid races in read11.0 test
Sep 9 2021, 6:18 PM

Sep 7 2021

bdrewery committed R11:ea4bd5e0889c: ports-mgmt/poudriere-devel: Update to 3.3.0-967-g764941e90 (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-967-g764941e90
Sep 7 2021, 8:53 PM
bdrewery committed R11:3dd6478b9231: ports-mgmt/poudriere-devel: Update to 3.3.0-961-g039b378dc (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-961-g039b378dc
Sep 7 2021, 7:11 PM
bdrewery requested review of D31876: read builtin: Empty variables on timeout.
Sep 7 2021, 7:05 PM
bdrewery committed R11:0d887476a43b: ports-mgmt/poudriere-devel: Mark BROKEN (authored by bdrewery).
ports-mgmt/poudriere-devel: Mark BROKEN
Sep 7 2021, 5:17 PM

Sep 4 2021

bdrewery committed R11:1357179a0c89: ports-mgmt/poudriere-devel: Update to 3.3.0-958-g3d248385b (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-958-g3d248385b
Sep 4 2021, 7:41 PM

Sep 2 2021

bdrewery closed D31687: getdelim(3): Fix losing data on EAGAIN.
Sep 2 2021, 6:27 PM
bdrewery committed R10:8f8a794775bd: getdelim(3): Fix losing data on [EAGAIN] (authored by bdrewery).
getdelim(3): Fix losing data on [EAGAIN]
Sep 2 2021, 6:27 PM

Aug 30 2021

bdrewery committed R11:c555f0f92a65: ports-mgmt/poudriere: Bring in fix for distclean make.conf error (authored by bdrewery).
ports-mgmt/poudriere: Bring in fix for distclean make.conf error
Aug 30 2021, 5:22 PM

Aug 28 2021

bdrewery committed R11:c47ee773c4cf: ports-mgmt/poudriere-devel: Update to 3.3.0-927-gb63d7c829 (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-927-gb63d7c829
Aug 28 2021, 7:10 PM

Aug 27 2021

bdrewery committed R11:84a57f6bb773: ports-mgmt/poudriere-devel: Update to 3.3.0-924-g8de014b5e (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-924-g8de014b5e
Aug 27 2021, 8:48 PM

Aug 26 2021

bdrewery updated the diff for D31687: getdelim(3): Fix losing data on EAGAIN.
  • add braces around ungetc loop
Aug 26 2021, 6:57 PM
bdrewery added a comment to D31687: getdelim(3): Fix losing data on EAGAIN.
In D31687#714822, @kib wrote:

I believe stdio is not supposed to work (correctly) with non-blocking file descriptors. I do not object against attempts to make part of it work regardless, but I am not sure it is possible without making it all functional.

Aug 26 2021, 12:18 AM
bdrewery updated the diff for D31687: getdelim(3): Fix losing data on EAGAIN.

Address feedback

  • Reset errno before __srefill as it may return EOF without setting it.
  • Destaircase
  • Handle (malloc failing) EOF error from __ungetc
Aug 26 2021, 12:12 AM

Aug 25 2021

bdrewery updated the diff for D31687: getdelim(3): Fix losing data on EAGAIN.
  • Make failure of the partner process less prominent in kyua output
Aug 25 2021, 11:28 PM
bdrewery updated the test plan for D31687: getdelim(3): Fix losing data on EAGAIN.
Aug 25 2021, 11:27 PM
bdrewery updated the test plan for D31687: getdelim(3): Fix losing data on EAGAIN.
Aug 25 2021, 11:22 PM
bdrewery requested review of D31687: getdelim(3): Fix losing data on EAGAIN.
Aug 25 2021, 11:18 PM

Aug 18 2021

bdrewery added inline comments to D31454: Limit compressed debug to little-endian targets.
Aug 18 2021, 11:46 PM
bdrewery added inline comments to D31454: Limit compressed debug to little-endian targets.
Aug 18 2021, 9:01 PM
bdrewery added a comment to D29493: sh: implement persistent history storage.

By the way it does not build with -DNO_HISTORY.

/usr/src/bin/sh/histedit.c:703:13: error: unknown type name 'EditLine'
sh_complete(EditLine *sel, int ch __unused)
            ^
/usr/src/bin/sh/histedit.c:705:24: error: implicit declaration of function 'fn_complete2' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        return (unsigned char)fn_complete2(sel, NULL, sh_matches,
                              ^
/usr/src/bin/sh/histedit.c:705:24: note: did you mean 'sh_complete'?
/usr/src/bin/sh/histedit.c:703:1: note: 'sh_complete' declared here
sh_complete(EditLine *sel, int ch __unused)
^
/usr/src/bin/sh/histedit.c:707:35: error: use of undeclared identifier 'FN_QUOTE_MATCH'
                NULL, &((int) {0}), NULL, NULL, FN_QUOTE_MATCH);
                                                ^
3 errors generated.
*** [histedit.o] Error code 1
Aug 18 2021, 7:20 PM
bdrewery added a comment to D29493: sh: implement persistent history storage.

3 months later I realized why my zsh history file keeps being truncated. Simply running sh and exiting does it. How am I supposed to avoid sh blowing away $HISTFILE when zsh uses that same var name along with HISTSIZE?

Aug 18 2021, 7:03 PM
bdrewery committed R11:70421b2fb1c0: ports-mgmt/poudriere: Update to 3.3.7 (authored by bdrewery).
ports-mgmt/poudriere: Update to 3.3.7
Aug 18 2021, 6:14 PM
bdrewery committed R11:0081aa8f7f5c: ports-mgmt/poudriere-devel: Update to 3.3.0-869-g7a9e09c8f (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-869-g7a9e09c8f
Aug 18 2021, 6:14 PM

Aug 17 2021

bdrewery committed R10:4b7bf8424892: bootstrap-tools: Don't copy host tools with make -n (authored by bdrewery).
bootstrap-tools: Don't copy host tools with make -n
Aug 17 2021, 7:26 PM
bdrewery committed R10:a3ddd7c92b99: _worldtmp: Fix some sub-makes not working with make -n (authored by bdrewery).
_worldtmp: Fix some sub-makes not working with make -n
Aug 17 2021, 7:07 PM

Aug 14 2021

bdrewery committed R11:259478fc3ad5: Mk/bsd.port.mk: Revert the UNAME_r error text change for now. (authored by bdrewery).
Mk/bsd.port.mk: Revert the UNAME_r error text change for now.
Aug 14 2021, 4:52 AM
bdrewery added a comment to D30239: Add ALLOW_OSVERSION_MISMATCH flag to bsd.ports.mk.
In D30239#710984, @gjb wrote:
Aug 14 2021, 2:15 AM
bdrewery committed R11:8ec588d8f091: Mk/bsd.port.mk: Fix another typo (authored by bdrewery).
Mk/bsd.port.mk: Fix another typo
Aug 14 2021, 12:26 AM
bdrewery added a comment to D30239: Add ALLOW_OSVERSION_MISMATCH flag to bsd.ports.mk.

I understand that people want to just chroot /some/path make -C myport but that's not a sufficient build environment setup for ports where there are 30k+ random 3rd party things that may run uname. Yes your port may be special but the common case is not your port.

Aug 14 2021, 12:23 AM

Aug 13 2021

bdrewery committed R11:bed9a4de0ee7: Mk/bsd.port.mk: Fix typo (authored by bdrewery).
Mk/bsd.port.mk: Fix typo
Aug 13 2021, 8:37 PM
bdrewery added a comment to D30239: Add ALLOW_OSVERSION_MISMATCH flag to bsd.ports.mk.

I've added a foot shooter in https://cgit.freebsd.org/ports/commit/?id=154492dd1f1d8c9a8f9c283f830a737c96e64a10

Aug 13 2021, 8:33 PM
bdrewery committed R11:154492dd1f1d: Mk/bsd.port.mk: Clarify UNAME_r failure. (authored by bdrewery).
Mk/bsd.port.mk: Clarify UNAME_r failure.
Aug 13 2021, 8:23 PM

Aug 9 2021

bdrewery added inline comments to D31453: netdump: send key before dump, in case dump fails.
Aug 9 2021, 11:01 PM
bdrewery accepted D31452: dumpon: fix encrypted dumps after commit 372557d8c3d.

Doh. Thanks for testing and fixing.

Aug 9 2021, 10:59 PM

Aug 3 2021

bdrewery committed R10:b60770fceb2b: Fix native-xtools build (authored by bdrewery).
Fix native-xtools build
Aug 3 2021, 5:01 PM
bdrewery added a reverting change for R10:36269b823182: Fix native-xtools build: R10:2482ea42fb60: Revert "Fix native-xtools build".
Aug 3 2021, 5:01 PM
bdrewery committed R10:2482ea42fb60: Revert "Fix native-xtools build" (authored by bdrewery).
Revert "Fix native-xtools build"
Aug 3 2021, 5:01 PM
bdrewery committed R10:36269b823182: Fix native-xtools build (authored by bdrewery).
Fix native-xtools build
Aug 3 2021, 3:23 PM

Aug 2 2021

bdrewery accepted D31384: Fix lockstat:::thread-spin dtrace probe with LOCK_PROFILING.
Aug 2 2021, 7:29 PM

Jul 28 2021

bdrewery committed R10:7cbf1de38e06: debugnet: Fix false-positive assertions for dp_state (authored by bdrewery).
debugnet: Fix false-positive assertions for dp_state
Jul 28 2021, 11:35 PM
bdrewery closed D31327: debugnet_handle_arp(): Fix false-positive assertion for dp_state.
Jul 28 2021, 11:34 PM
bdrewery added a comment to D31327: debugnet_handle_arp(): Fix false-positive assertion for dp_state.
In D31327#705894, @cem wrote:

This would only happen if you have multiple competing dhcp servers on a subnet, right? Edit: not dhcp, oops. Still, kind of surprising we’re getting multiple ARP responses?

Jul 28 2021, 5:04 PM

Jul 27 2021

bdrewery updated the diff for D31327: debugnet_handle_arp(): Fix false-positive assertion for dp_state.
  • initialize buf
Jul 27 2021, 11:08 PM
bdrewery requested review of D31327: debugnet_handle_arp(): Fix false-positive assertion for dp_state.
Jul 27 2021, 9:14 PM
bdrewery committed R10:a573243370d3: netdump: Fix leaking debugnet state on errors. (authored by bdrewery).
netdump: Fix leaking debugnet state on errors.
Jul 27 2021, 4:07 PM
bdrewery closed D31319: netdump: Fix leaking debugnet state on errors..
Jul 27 2021, 4:06 PM
bdrewery requested review of D31319: netdump: Fix leaking debugnet state on errors..
Jul 27 2021, 2:12 AM

Jul 26 2021

bdrewery committed R10:accff08c2f6a: dumpon: Fix unconfiguring netdump with "off" and "/dev/null". (authored by bdrewery).
dumpon: Fix unconfiguring netdump with "off" and "/dev/null".
Jul 26 2021, 8:11 PM
bdrewery committed R10:372557d8c3d3: dumpon: Fix -v causing error when configuring an encrypted dump (authored by bdrewery).
dumpon: Fix -v causing error when configuring an encrypted dump
Jul 26 2021, 8:11 PM
bdrewery closed D31300: dumpon: Fix unconfiguring netdump with "off" and "/dev/null"..
Jul 26 2021, 8:10 PM
bdrewery closed D31266: dumpon: Fix -v causing error when configuring an encrypted dump.
Jul 26 2021, 8:10 PM

Jul 24 2021

bdrewery updated the diff for D31300: dumpon: Fix unconfiguring netdump with "off" and "/dev/null"..
  • Handle dumpon /dev/null as well.
Jul 24 2021, 9:27 PM
bdrewery requested review of D31300: dumpon: Fix unconfiguring netdump with "off" and "/dev/null"..
Jul 24 2021, 9:25 PM
bdrewery updated the diff for D31266: dumpon: Fix -v causing error when configuring an encrypted dump.
  • Address feedback
Jul 24 2021, 7:24 PM

Jul 23 2021

bdrewery updated the diff for D31266: dumpon: Fix -v causing error when configuring an encrypted dump.
  • Switch to using fork rather than casper
Jul 23 2021, 8:17 PM
bdrewery added inline comments to D31266: dumpon: Fix -v causing error when configuring an encrypted dump.
Jul 23 2021, 8:08 PM

Jul 22 2021

bdrewery added inline comments to D31266: dumpon: Fix -v causing error when configuring an encrypted dump.
Jul 22 2021, 6:50 PM
bdrewery added a comment to D31266: dumpon: Fix -v causing error when configuring an encrypted dump.

I really wish we had a sysctlfd which allowed one to pre-"open" a sysctl like we are doing here with /dev/netdump...

Jul 22 2021, 4:08 PM
bdrewery updated the diff for D31266: dumpon: Fix -v causing error when configuring an encrypted dump.
  • capcas isn't needed unless -v is given
Jul 22 2021, 4:07 PM
bdrewery added inline comments to D31266: dumpon: Fix -v causing error when configuring an encrypted dump.
Jul 22 2021, 4:05 PM
bdrewery updated the diff for D31266: dumpon: Fix -v causing error when configuring an encrypted dump.
  • Fix -v without -k
  • Properly load casper
  • Fallback to proper capability mode if casper is not present
Jul 22 2021, 3:56 PM
bdrewery requested review of D31266: dumpon: Fix -v causing error when configuring an encrypted dump.
Jul 22 2021, 2:22 AM

Jul 20 2021

bdrewery committed R11:8bccb92f04a1: ports-mgmt/poudriere-devel: Update to 3.3.0-748-g71646de83 (authored by bdrewery).
ports-mgmt/poudriere-devel: Update to 3.3.0-748-g71646de83
Jul 20 2021, 11:39 PM