Fix handling of no LOG_PID on older releases. It is force enabled on head...

Can you still make -C share/mk with this?

Why though? Plenty of users still use it. What's the argument for forcing etcupdate over mergemaster? IMHO it's a large burden to users to convert things that use mergemaster fine to etcupdate.

FYI This fixes *DIRDEPS* not *META*. The file is misnamed.
I suggest adding @sjg to the review

Thanks for looking.

I may disappear so I'll approve for now; my questions aren't blockers but I think there is an unrelated change that should be fixed first.

I spot checked a few and they looked fine.

I don't like that we have auto generated and manual maintained outside of Makefile as it will get stale fast.

I think the comment from targets/ should be added in too.

# This file is not autogenerated - take care!

What case does this fix exactly?

In D22144#484006, @jhb wrote:

I guess the extra directories don't hurt. I'm less certain about the implications of the missing checks for an empty KERNBUILDDIR.

I only reviewed defs.mk. Looks fine.

In D21654#482501, @ngie wrote:

@bdrewery, @mat, @woodsb02: ping?

In D22059#482035, @imp wrote:

The question is, do we need them to be TARGET_* in this makefile.inc1 usage?
I kinda think it does. Checking into *that* detail...

In D22057#481956, @kevans wrote:

I'd be inclined to explicitly spell it as -I ${KRNLCONFDIR} instead of -I., and then we later rename KRNLCONFDIR to make it more clear. We can't quickly change the cd, at least, because:

In D22057#481900, @avg wrote:

I don't have answers to your questions, sorry.
And I did not intend for the review to center around KRNLCONFDIR vs KERNCONFDIR.
I just want to be able to do what this change allows me to do.
That is, I want to be able to include files from both directories.

In D22057#481894, @bdrewery wrote:

In D22057#481764, @avg wrote:

Just a note, KRNLCONFDIR is the standard location (derived from TARGET) and KERNCONFDIR is the actual, possibly overridden, location.

Sigh. Why. These appear to be the same at quick glance.

In D22057#481764, @avg wrote:

Just a note, KRNLCONFDIR is the standard location (derived from TARGET) and KERNCONFDIR is the actual, possibly overridden, location.

Oops sorry for missing this before. TARGET_ are only useful in Makefile.inc1.

We have use for this at work as well for FreeBSD amd64/32 ABI compat testing since we have our own ABI. Though we just use FreeBSD 10 dist files for the purpose this feature is still nice.

This is great!

I don't know lua yet so cannot review most of this. But I'm OK with expanding lua usage. One "regression" I see is that move from a heredoc to a ton of write_line lines. Can lua not continue a string on the next line? Or maybe we should have some kind of template file instead.

I'm planning to make the syscall files generate *during the build*. It will need to happen quite early. Is lua already an early bootstrap tool?

I like it. But it still comes down to a bikeshed/opinion. Anyway it's a good guidance.