Approved by: philip (mentor)

I agree with bapt: I would only import the latest version. There's no point littering our vendor tree with versions that we'll never merge. Unless there is a compelling reason to have the intermediate version (e.g. it makes the merge to contrib substantially easier). Since this is a new vendor import, that's not the case here.

Looks good. :)

I think this looks good. As far as I can tell, these bits pass the test suite (though the tests panic elsewhere, which is tedious). I looked carefully over the localtime.c changes and I don't see anything broken, but I haven't manually tested every FreeBSD-ism.

Thank you for dealing with upstream so patiently. ;-)

I don't like this. It further hides the real problem.

In D53964#1233038, @cperciva wrote:

In D53964#1233037, @bdrewery wrote:

In D53964#1232996, @philip wrote:

We could probably shave off several seconds for many people by replacing pkg+https with pkg+http. The TLS n-way handshake is a complete waste of time. I have made this observation about the other repositories as well but...

Windmills. Have to keep trying.

Agreed. All https buys us here is quieting an FAQ. It otherwise adds time and potentially has problems in some corporate setups.

It does provide a little bit of protection against rollback attacks. Not much, though; there's a reason I used HTTP for freebsd-update.

We could probably shave off several seconds for many people by replacing pkg+https with pkg+http. The TLS n-way handshake is a complete waste of time. I have made this observation about the other repositories as well but...

Pong. This one looks good too. :)

Thank you. And I'm glad to see upstream getting more in sync with us. ;-)

Wow. That's a blast from the past.

Thanks for clarifying.

This makes sense. Thank you.