Page MenuHomeFreeBSD

philip (Philip Paeps)
Troublemaker

Projects

User Details

User Since
May 14 2014, 3:42 PM (315 w, 6 d)

Recent Activity

Thu, May 28

philip added a comment to D25034: riscv: honor the environment set via the kernel config file .

This looks good -- and is known to work. The size of the environment should probably be a constant rather than a magic number though.

Thu, May 28, 7:06 AM

Fri, May 22

philip accepted D24947: Remove support for SSLv3 from fetch(3).
Fri, May 22, 3:30 AM
philip accepted D24945: Turn off SSLv3..
Fri, May 22, 3:29 AM

Sun, May 10

philip accepted D24790: libalias: retire cuseeme support.

Looks good to me. I did a quick build-test and verified that make find-old; make delete-old does the right thing.

Sun, May 10, 6:03 AM

Sat, May 9

philip accepted D24760: remove %n support from printf(9).

I double-checked @emaste's grep and likewise see no consumer of %n in callers of kernel printf(9).

Sat, May 9, 1:42 PM

Fri, May 8

philip committed rD54111: Annual update of my PGP key expiry date..
Annual update of my PGP key expiry date.
Fri, May 8, 4:15 AM

Mon, May 4

philip added a comment to D24565: misc/zoneinfo: split BACKWARD into two options for recent/ancient backward compatibility.

Thank you!

Mon, May 4, 2:44 AM

May 2 2020

philip accepted D24297: Make include/malloc.h usable again..
May 2 2020, 1:40 AM
philip added a comment to D24660: sysutils/opensbi: update to v0.7.

At first glance, this looks good.

May 2 2020, 1:38 AM

Apr 27 2020

philip committed rS360362: MFC r360240: Import tzdata 2020a.
MFC r360240: Import tzdata 2020a
Apr 27 2020, 3:57 AM
philip committed rS360361: MFC r360240: Import tzdata 2020a.
MFC r360240: Import tzdata 2020a
Apr 27 2020, 3:57 AM

Apr 25 2020

philip added a comment to D24565: misc/zoneinfo: split BACKWARD into two options for recent/ancient backward compatibility.

I have no objection to this patch but I worry about FreeBSD diverging more from other operating systems. People have expectations about backwards compatible timezone lines existing. Breaking software gratuitously because we have a subset of compat links (even if the compat links by themselves are long stale) would not be cool.

Apr 25 2020, 2:49 AM
philip added a comment to D24306: Always install backward compatibility timezones, as they are installed on all major Linux distributions as well as NetBSD and OpenBSD..

I'm late to the party but for what it's worth: I support this change.
This was discussed on the tz mailing list in November last year.

Apr 25 2020, 2:39 AM

Apr 24 2020

philip committed rS360240: Import tzdata 2020a.
Import tzdata 2020a
Apr 24 2020, 5:06 AM
philip committed rS360239: Tag import of tzdata 2020a.
Tag import of tzdata 2020a
Apr 24 2020, 4:55 AM
philip committed rS360238: Import tzdata 2020a.
Import tzdata 2020a
Apr 24 2020, 4:53 AM

Apr 23 2020

philip accepted D24297: Make include/malloc.h usable again..
Apr 23 2020, 9:54 AM

Apr 22 2020

philip accepted D24250: bridge: epoch-ification.

Looks good to me!

Apr 22 2020, 7:38 AM
philip added a comment to D24304: Add 64-bit support to Cadence CGEM Ethernet driver..

I am a little dubious about the many instances of #if INTPTR_MAX == INT64_MAX compile-time gymnastics.

Apr 22 2020, 7:14 AM
philip added a comment to D24304: Add 64-bit support to Cadence CGEM Ethernet driver..

@kp, @philip, @nick would it be possible to sanity test this on a sifive board?

Apr 22 2020, 6:55 AM
philip added a reviewer for D24304: Add 64-bit support to Cadence CGEM Ethernet driver.: philip.
Apr 22 2020, 6:54 AM

Apr 17 2020

philip accepted D24297: Make include/malloc.h usable again..

This is the best solution under the circumstances.

Apr 17 2020, 7:20 AM
philip accepted D24250: bridge: epoch-ification.

I thought I had accepted this latest revision. Sorry about that.

Apr 17 2020, 1:58 AM

Apr 9 2020

philip accepted D24337: bridge tests: Test deleting a bridge with members.
Apr 9 2020, 3:48 AM

Apr 2 2020

philip added inline comments to D24249: bridge: Change lists to CK_LIST as a peparation for epochification.
Apr 2 2020, 2:16 AM
philip accepted D24251: bridge tests: Test for #216510.

This looks good. Thank you for adding more tests!

Apr 2 2020, 2:11 AM

Mar 31 2020

philip accepted D24170: SiFive FE310 Always-on driver.

Good catch.

Mar 31 2020, 2:26 AM · riscv

Mar 24 2020

philip accepted D24170: SiFive FE310 Always-on driver.

Looks good to me! Thank you.

Mar 24 2020, 2:21 AM · riscv

Mar 20 2020

philip accepted D24130: Add myself (nick) as a src commiter.

Looks good!

Mar 20 2020, 2:22 AM
philip accepted D24129: Add myself (nick) as a src commiter.

This looks good!

Mar 20 2020, 2:21 AM

Mar 15 2020

philip accepted D23961: bridge tests: Basic span test.

Looks good to me. Thank you!

Mar 15 2020, 2:39 AM

Mar 11 2020

philip committed rS358866: Welcome Nick O'Brien as a src committer..
Welcome Nick O'Brien as a src committer.
Mar 11 2020, 3:45 AM

Mar 9 2020

philip closed D24004: SiFive/SPI: Silence build warning.
Mar 9 2020, 4:09 AM
philip committed rS358801: fuspi: silence build warning, plug resource leak.
fuspi: silence build warning, plug resource leak
Mar 9 2020, 4:09 AM
philip accepted D24004: SiFive/SPI: Silence build warning.

Pointy hat to: philip :)

Mar 9 2020, 3:38 AM

Mar 7 2020

philip accepted D23877: RISCV Platform Specific Code.

It sounds like we're reaching consensus that we should move forward with this.

Mar 7 2020, 4:13 AM · riscv

Mar 5 2020

philip added a comment to D23877: RISCV Platform Specific Code.

I agree that we should be careful not to go down the path of ARM with a plethora of platform files littering the tree. While this patch makes that easier, it doesn't actually force us in that direction.

Mar 5 2020, 3:57 AM · riscv
philip accepted D23960: bridge test: adding and removing static addresses.

Looks good to me!

Mar 5 2020, 3:43 AM
philip added a comment to D23961: bridge tests: Basic span test.

Isn't this test always going to succeed as long as the span can be removed? Or am I misunderstanding something?

Mar 5 2020, 3:43 AM
philip accepted D23959: bridge test: spanning tree.

This looks good in principle.

Mar 5 2020, 3:38 AM

Mar 2 2020

philip committed rS358517: MFC r358419:.
MFC r358419:
Mar 2 2020, 2:48 AM
philip committed rS358516: MFC r358418:.
MFC r358418:
Mar 2 2020, 2:47 AM
philip committed rS358514: MFC r358419:.
MFC r358419:
Mar 2 2020, 2:46 AM
philip committed rS358513: MFC r358418:.
MFC r358418:
Mar 2 2020, 2:44 AM

Mar 1 2020

philip accepted D23879: RISCV: PLATFORM_DEFAULT implementation.

Looks good to me.

Mar 1 2020, 3:12 AM · riscv

Feb 28 2020

philip committed rS358419: bsdinstall: remove the Italian mirror.
bsdinstall: remove the Italian mirror
Feb 28 2020, 3:39 AM
philip committed rS358418: bsdconfig: remove the Italian mirror.
bsdconfig: remove the Italian mirror
Feb 28 2020, 3:39 AM

Feb 25 2020

philip added a comment to D23820: sysutils/opensbi: update to version 0.6.

This looks good but I'd like to test it before I click the accept button. I'll try to make this work on my FU540 this afternoon.

Feb 25 2020, 3:42 AM

Feb 24 2020

philip added a comment to D23812: Add a soft-float riscv kernel config.
In D23812#523285, @imp wrote:

Yeah. The diff is tiny.

Unless anyone else under riscv objects strongly, we should just build both targets.

I have the commit all queued up (along with a hack to config to mkdir ../compile when it doesn't exist because git automatically deletes empty directories). I'll push it in about 8 hours from now (~8am MST Denver Co time). that should give people in EU time enough to wake up and read their mail.

Feb 24 2020, 6:56 AM
philip accepted D23812: Add a soft-float riscv kernel config.

Yeah. The diff is tiny.

Feb 24 2020, 6:50 AM
philip added a comment to D23812: Add a soft-float riscv kernel config.
In D23812#523274, @imp wrote:

This looks good to me.

Any reason not to hook this up to universe? The more testing RISC-V gets, the better. Does it significantly increase the build-time?

Paranoia on my part. If it's ready, no reason...

Feb 24 2020, 5:35 AM
philip accepted D23808: bridge: Move locking defines into if_bridge.c.

Good idea. There should be no reason for the bridge locks to be manipulated elsewhere.

Feb 24 2020, 5:18 AM
philip added a comment to D23812: Add a soft-float riscv kernel config.

(Adding riscv for wider review.)

Feb 24 2020, 4:48 AM
philip added a reviewer for D23812: Add a soft-float riscv kernel config: riscv.
Feb 24 2020, 4:47 AM
philip accepted D23812: Add a soft-float riscv kernel config.

This looks good to me.

Feb 24 2020, 4:47 AM

Feb 20 2020

philip accepted D23741: riscv: Set MACHINE_ARCH define based on TARGET_ARCH.

Looks good to me.
Thank you!

Feb 20 2020, 3:00 AM

Feb 17 2020

philip committed rP526343: astro/xearth: remove my inaccurate marker.
astro/xearth: remove my inaccurate marker
Feb 17 2020, 6:27 AM

Feb 16 2020

philip added a comment to D23697: bridge: Basic test case.
In D23697#520613, @kp wrote:
  • sort test list in Makefile
  • rename test case
Feb 16 2020, 10:46 PM

Feb 15 2020

philip accepted D23697: bridge: Basic test case.

This looks good to me. I had one minor style observation in addition to the ones @melifaro caught.

Feb 15 2020, 11:40 PM
philip added a comment to D23690: pkgbase: return most config files back to ^/etc.

Thank you!

Feb 15 2020, 3:35 AM

Feb 14 2020

philip committed rP526079: security/vuxml: Add January FreeBSD SAs.
security/vuxml: Add January FreeBSD SAs
Feb 14 2020, 1:16 AM

Feb 2 2020

philip committed rS357402: MFC r357292:.
MFC r357292:
Feb 2 2020, 8:46 AM

Jan 30 2020

philip committed rS357292: acpi_ibm: add support for ThinkPad PrivacyGuard.
acpi_ibm: add support for ThinkPad PrivacyGuard
Jan 30 2020, 10:40 AM
philip closed D23370: acpi_ibm: add support for ThinkPad PrivacyGuard.
Jan 30 2020, 10:40 AM
philip accepted D23370: acpi_ibm: add support for ThinkPad PrivacyGuard.

Just doing a quick final test-build and I'll commit this.

Jan 30 2020, 10:19 AM

Jan 25 2020

philip accepted D23224: bsdinstall: Provide help text for partitioning options.
Jan 25 2020, 4:09 AM
philip accepted D23224: bsdinstall: Provide help text for partitioning options.

Looks good. I like the pointer to the tuning guide.

Jan 25 2020, 4:05 AM

Jan 18 2020

philip accepted D23224: bsdinstall: Provide help text for partitioning options.

Looks good to me!

Jan 18 2020, 12:29 AM

Jan 15 2020

philip accepted D23173: bsdinstall: Change ZFS to "default" method (first option).

Looks good to me.
Thank you!

Jan 15 2020, 4:22 AM
philip committed rP523077: devel/aarch64-none-elf-gcc: parameterise PORTVERSION.
devel/aarch64-none-elf-gcc: parameterise PORTVERSION
Jan 15 2020, 1:27 AM
philip committed rP523076: New port: riscv64-none-elf-gcc: bare metal toolchain for riscv64.
New port: riscv64-none-elf-gcc: bare metal toolchain for riscv64
Jan 15 2020, 1:15 AM
philip committed rP523075: Add a riscv64_none_elf flavor to devel/binutils..
Add a riscv64_none_elf flavor to devel/binutils.
Jan 15 2020, 1:10 AM
philip requested changes to D23173: bsdinstall: Change ZFS to "default" method (first option).

I think we should take a closer look to ensure the manpage actually reflects the new reality. Other than that, this change looks good! Thank you.

Jan 15 2020, 12:24 AM

Dec 29 2019

philip committed rS356166: fuspi: Fix 'sleepable after non-sleepable' lock.
fuspi: Fix 'sleepable after non-sleepable' lock
Dec 29 2019, 4:26 AM

Dec 21 2019

philip committed rS355978: top: display battery capacity remaining.
top: display battery capacity remaining
Dec 21 2019, 5:03 AM
philip closed D22871: Battery capacity remaining percent in top(1).
Dec 21 2019, 5:03 AM
philip accepted D22871: Battery capacity remaining percent in top(1).

This looks good now. I'll commit it.

Dec 21 2019, 3:28 AM

Dec 20 2019

philip committed rS355926: iicoc: fix the build on PCI machines.
iicoc: fix the build on PCI machines
Dec 20 2019, 5:15 AM
philip committed rS355925: Print upper 32 bits in devmap table entries.
Print upper 32 bits in devmap table entries
Dec 20 2019, 3:41 AM
philip committed rS355924: iicoc: add FDT bus attachment.
iicoc: add FDT bus attachment
Dec 20 2019, 3:41 AM
philip committed rS355923: iicoc: split up common core and PCI bus specifics.
iicoc: split up common core and PCI bus specifics
Dec 20 2019, 3:41 AM
philip committed rS355922: iicoc: minor whitespace and style(9) fixes.
iicoc: minor whitespace and style(9) fixes
Dec 20 2019, 3:40 AM
philip committed rS355921: riscv/sifive: add FU540 SPI controller driver.
riscv/sifive: add FU540 SPI controller driver
Dec 20 2019, 3:40 AM
philip committed rS355920: riscv/sifive: add SiFive FU540 PRCI driver.
riscv/sifive: add SiFive FU540 PRCI driver
Dec 20 2019, 3:38 AM

Dec 19 2019

philip requested changes to D22871: Battery capacity remaining percent in top(1).

Except for some very minor style issues, this looks like a good change! Thanks for the submission.

Dec 19 2019, 8:42 AM

Dec 2 2019

philip committed rP518863: Release Santhosh Raju (fox) from mentorship..
Release Santhosh Raju (fox) from mentorship.
Dec 2 2019, 6:19 PM

Oct 27 2019

philip accepted D22164: New port: sysutils/opensbi: OpenSBI, a RISC-V bootloader and firmware.

I also tested this in Poudriere on 12 and HEAD.

Oct 27 2019, 2:29 AM

Oct 17 2019

philip added a member for riscv: philip.
Oct 17 2019, 4:25 AM
philip committed rS353674: ether: add older ethertype definitions for QinQ.
ether: add older ethertype definitions for QinQ
Oct 17 2019, 12:35 AM
philip closed D21846: Add 802.1Q ethertypes used in the wild.
Oct 17 2019, 12:35 AM

Oct 16 2019

philip accepted D21846: Add 802.1Q ethertypes used in the wild.

Looks good to me. I'll commit this.

Oct 16 2019, 8:10 PM

Oct 15 2019

philip accepted D22035: Generalize ARM specific comments in devmap.
Oct 15 2019, 11:20 PM

Oct 14 2019

philip added a comment to D22012: Import dhcpcd(8) version 8.1.0 into FreeBSD base..

Thank you for doing this work, @woodsb02!

Oct 14 2019, 6:44 PM

Oct 12 2019

philip committed rS353453: A comment in subr_devmap.c mentions that devmap_print_table() should.
A comment in subr_devmap.c mentions that devmap_print_table() should
Oct 12 2019, 6:18 PM
philip closed D21998: RISC-V: Call devmap_print_table() on bootverbose.
Oct 12 2019, 6:18 PM
philip added a comment to D21998: RISC-V: Call devmap_print_table() on bootverbose.

I'll take it unless someone beats me to it. :)

Oct 12 2019, 6:14 PM
philip added a comment to D21998: RISC-V: Call devmap_print_table() on bootverbose.

While you're at it, it would be helpful to fix the dated arm-specific comments in subr_devmap.c. ;-)

Oct 12 2019, 5:41 PM

Oct 11 2019

philip committed rS353441: Call devmap_bootstrap in RISC-V machine dependent code to actually create.
Call devmap_bootstrap in RISC-V machine dependent code to actually create
Oct 11 2019, 4:29 PM
philip closed D21975: RISC-V: Call devmap_bootstrap().
Oct 11 2019, 4:28 PM

Oct 10 2019

philip accepted D21975: RISC-V: Call devmap_bootstrap().
Oct 10 2019, 9:22 PM