Page MenuHomeFreeBSD

philip (Philip Paeps)
Troublemaker

Projects

User Details

User Since
May 14 2014, 3:42 PM (336 w, 23 h)

Recent Activity

Today

philip committed rS366921: Import tzdata 2020c.
Import tzdata 2020c
Thu, Oct 22, 1:05 AM
philip committed rS366920: Tag import of tzdata 2020d.
Tag import of tzdata 2020d
Thu, Oct 22, 1:04 AM
philip committed rS366919: Import tzdata 2020d.
Import tzdata 2020d
Thu, Oct 22, 1:03 AM

Sun, Oct 18

philip committed rS366802: MFC r366779: Import tzdata 2020c.
MFC r366779: Import tzdata 2020c
Sun, Oct 18, 1:10 AM
philip committed rS366801: MFC r366779: Import tzdata 2020c.
MFC r366779: Import tzdata 2020c
Sun, Oct 18, 1:10 AM

Sat, Oct 17

philip committed rS366779: Import tzdata 2020c.
Import tzdata 2020c
Sat, Oct 17, 12:44 AM
philip committed rS366778: Tag import of tzdata 2020c.
Tag import of tzdata 2020c
Sat, Oct 17, 12:42 AM
philip committed rS366777: Import tzdata 2020c.
Import tzdata 2020c
Sat, Oct 17, 12:41 AM

Sun, Oct 11

philip committed rS366625: MFC r366529: Import tzdata 2020b.
MFC r366529: Import tzdata 2020b
Sun, Oct 11, 9:05 AM
philip committed rS366624: MFC r366529: Import tzdata 2020b.
MFC r366529: Import tzdata 2020b
Sun, Oct 11, 9:05 AM

Thu, Oct 8

philip committed rS366529: Import tzdata 2020b.
Import tzdata 2020b
Thu, Oct 8, 12:36 AM
philip committed rS366528: Tag import of tzdata 2020b.
Tag import of tzdata 2020b
Thu, Oct 8, 12:30 AM
philip committed rS366527: Import tzdata 2020b.
Import tzdata 2020b
Thu, Oct 8, 12:28 AM

Sep 16 2020

philip committed rP548763: security/vuxml: add FreeBSD SA-20:30.ftpd.
security/vuxml: add FreeBSD SA-20:30.ftpd
Sep 16 2020, 6:45 AM
philip committed rP548762: security/vuxml: add FreeBSD SA-20:29.bhyve_svm.
security/vuxml: add FreeBSD SA-20:29.bhyve_svm
Sep 16 2020, 6:44 AM
philip committed rP548761: security/vuxml: add FreeBSD SA-20:28.bhyve_vmcs.
security/vuxml: add FreeBSD SA-20:28.bhyve_vmcs
Sep 16 2020, 6:44 AM
philip committed rP548760: security/vuxml: add FreeBSD SA-20:27.ure.
security/vuxml: add FreeBSD SA-20:27.ure
Sep 16 2020, 6:44 AM

Sep 3 2020

philip committed rP547401: security/vuxml: add FreeBSD SA-20:26.dhclient.
security/vuxml: add FreeBSD SA-20:26.dhclient
Sep 3 2020, 1:01 AM
philip committed rP547400: security/vuxml: add FreeBSD SA-20:25.sctp.
security/vuxml: add FreeBSD SA-20:25.sctp
Sep 3 2020, 1:01 AM
philip committed rP547399: security/vuxml: add FreeBSD SA-20:24.ipv6.
security/vuxml: add FreeBSD SA-20:24.ipv6
Sep 3 2020, 1:01 AM

Aug 28 2020

philip committed rS364903: MFC r350079:.
MFC r350079:
Aug 28 2020, 8:14 AM
philip committed rS364902: MFC r350079:.
MFC r350079:
Aug 28 2020, 8:14 AM

Aug 18 2020

philip accepted D26092: riscv: Use global mimpid in identify_cpu().

Looks good to me.

Aug 18 2020, 1:49 AM · riscv

Aug 6 2020

philip committed rP544262: security/vuxml: correct a typo in SA-20:22.sqlite.
security/vuxml: correct a typo in SA-20:22.sqlite
Aug 6 2020, 3:43 AM
philip committed rP544261: security/vuxml: add FreeBSD SA-20:23.sendmsg.
security/vuxml: add FreeBSD SA-20:23.sendmsg
Aug 6 2020, 3:31 AM
philip committed rP544260: security/vuxml: add FreeBSD SA-20:21.usb_net.
security/vuxml: add FreeBSD SA-20:21.usb_net
Aug 6 2020, 3:31 AM
philip committed rP544259: security/vuxml: add FreeBSD SA to sqlite3 entry.
security/vuxml: add FreeBSD SA to sqlite3 entry
Aug 6 2020, 3:31 AM

Aug 2 2020

philip added a comment to D25737: RISC-V u-boot ports.

I've not had a chance to poke at this further. It's been busy recently. I'll pick this up again this week. Thanks for keeping my feet close to the fire!

Aug 2 2020, 3:34 AM
philip accepted D24304: Add 64-bit support to Cadence CGEM Ethernet driver..

Looks good to me!

Aug 2 2020, 3:27 AM

Jul 30 2020

philip committed rP543709: astro/xearth: add myself to freebsd.committers.markers again.
astro/xearth: add myself to freebsd.committers.markers again
Jul 30 2020, 5:16 AM
philip accepted D25735: devel/binutils: enable shared for riscv64_none_elf.

I still have a lukewarm ports commit bit. :)

Jul 30 2020, 1:40 AM

Jul 21 2020

philip added a comment to D25737: RISC-V u-boot ports.

I didn't manage to get this booting yesterday. But the boot switches on my SiFive board are a little confused. Continuing to poke at this today.

Jul 21 2020, 6:31 AM

Jul 20 2020

philip added a comment to D25737: RISC-V u-boot ports.

Yeah. I can take a look later this afternoon.

Jul 20 2020, 3:32 AM

Jul 10 2020

philip committed rP541837: security/vuxml: update CVE-2020-1266[23] entry.
security/vuxml: update CVE-2020-1266[23] entry
Jul 10 2020, 5:30 AM
philip committed rP541836: security/vuxml: add FreeBSD SA-20:20.ipv6.
security/vuxml: add FreeBSD SA-20:20.ipv6
Jul 10 2020, 5:30 AM
philip committed rP541835: security/vuxml: add FreeBSD SA-20:18.posix_spawnp.
security/vuxml: add FreeBSD SA-20:18.posix_spawnp
Jul 10 2020, 5:30 AM

Jun 18 2020

philip committed rP539533: security/vuxml: CVE-2020-8618 and CVE-2020-8619.
security/vuxml: CVE-2020-8618 and CVE-2020-8619
Jun 18 2020, 9:28 AM
philip committed rP539535: MFH: r539519.
MFH: r539519
Jun 18 2020, 9:28 AM
philip committed rP539534: MFH: r539518.
MFH: r539518
Jun 18 2020, 9:23 AM
philip committed rP539519: Update to 9.11.20..
Update to 9.11.20.
Jun 18 2020, 9:23 AM
philip committed rP539518: Update to 9.16.4..
Update to 9.16.4.
Jun 18 2020, 9:23 AM

May 28 2020

philip added a comment to D25034: riscv: honor the environment set via the kernel config file .

This looks good -- and is known to work. The size of the environment should probably be a constant rather than a magic number though.

May 28 2020, 7:06 AM

May 22 2020

philip accepted D24947: Remove support for SSLv3 from fetch(3).
May 22 2020, 3:30 AM
philip accepted D24945: Turn off SSLv3..
May 22 2020, 3:29 AM

May 10 2020

philip accepted D24790: libalias: retire cuseeme support.

Looks good to me. I did a quick build-test and verified that make find-old; make delete-old does the right thing.

May 10 2020, 6:03 AM

May 9 2020

philip accepted D24760: remove %n support from printf(9).

I double-checked @emaste's grep and likewise see no consumer of %n in callers of kernel printf(9).

May 9 2020, 1:42 PM

May 8 2020

philip committed rD54111: Annual update of my PGP key expiry date..
Annual update of my PGP key expiry date.
May 8 2020, 4:15 AM

May 4 2020

philip added a comment to D24565: misc/zoneinfo: split BACKWARD into two options for recent/ancient backward compatibility.

Thank you!

May 4 2020, 2:44 AM

May 2 2020

philip accepted D24297: Make include/malloc.h usable again..
May 2 2020, 1:40 AM
philip added a comment to D24660: sysutils/opensbi: update to v0.8.

At first glance, this looks good.

May 2 2020, 1:38 AM

Apr 27 2020

philip committed rS360362: MFC r360240: Import tzdata 2020a.
MFC r360240: Import tzdata 2020a
Apr 27 2020, 3:57 AM
philip committed rS360361: MFC r360240: Import tzdata 2020a.
MFC r360240: Import tzdata 2020a
Apr 27 2020, 3:57 AM

Apr 25 2020

philip added a comment to D24565: misc/zoneinfo: split BACKWARD into two options for recent/ancient backward compatibility.

I have no objection to this patch but I worry about FreeBSD diverging more from other operating systems. People have expectations about backwards compatible timezone lines existing. Breaking software gratuitously because we have a subset of compat links (even if the compat links by themselves are long stale) would not be cool.

Apr 25 2020, 2:49 AM
philip added a comment to D24306: Always install backward compatibility timezones, as they are installed on all major Linux distributions as well as NetBSD and OpenBSD..

I'm late to the party but for what it's worth: I support this change.
This was discussed on the tz mailing list in November last year.

Apr 25 2020, 2:39 AM

Apr 24 2020

philip committed rS360240: Import tzdata 2020a.
Import tzdata 2020a
Apr 24 2020, 5:06 AM
philip committed rS360239: Tag import of tzdata 2020a.
Tag import of tzdata 2020a
Apr 24 2020, 4:55 AM
philip committed rS360238: Import tzdata 2020a.
Import tzdata 2020a
Apr 24 2020, 4:53 AM

Apr 23 2020

philip accepted D24297: Make include/malloc.h usable again..
Apr 23 2020, 9:54 AM

Apr 22 2020

philip accepted D24250: bridge: epoch-ification.

Looks good to me!

Apr 22 2020, 7:38 AM
philip added a comment to D24304: Add 64-bit support to Cadence CGEM Ethernet driver..

I am a little dubious about the many instances of #if INTPTR_MAX == INT64_MAX compile-time gymnastics.

Apr 22 2020, 7:14 AM
philip added a comment to D24304: Add 64-bit support to Cadence CGEM Ethernet driver..

@kp, @philip, @nick would it be possible to sanity test this on a sifive board?

Apr 22 2020, 6:55 AM
philip added a reviewer for D24304: Add 64-bit support to Cadence CGEM Ethernet driver.: philip.
Apr 22 2020, 6:54 AM

Apr 17 2020

philip accepted D24297: Make include/malloc.h usable again..

This is the best solution under the circumstances.

Apr 17 2020, 7:20 AM
philip accepted D24250: bridge: epoch-ification.

I thought I had accepted this latest revision. Sorry about that.

Apr 17 2020, 1:58 AM

Apr 9 2020

philip accepted D24337: bridge tests: Test deleting a bridge with members.
Apr 9 2020, 3:48 AM

Apr 2 2020

philip added inline comments to D24249: bridge: Change lists to CK_LIST as a peparation for epochification.
Apr 2 2020, 2:16 AM
philip accepted D24251: bridge tests: Test for #216510.

This looks good. Thank you for adding more tests!

Apr 2 2020, 2:11 AM

Mar 31 2020

philip accepted D24170: SiFive FE310 Always-on driver.

Good catch.

Mar 31 2020, 2:26 AM · riscv

Mar 24 2020

philip accepted D24170: SiFive FE310 Always-on driver.

Looks good to me! Thank you.

Mar 24 2020, 2:21 AM · riscv

Mar 20 2020

philip accepted D24130: Add myself (nick) as a src commiter.

Looks good!

Mar 20 2020, 2:22 AM
philip accepted D24129: Add myself (nick) as a src commiter.

This looks good!

Mar 20 2020, 2:21 AM

Mar 15 2020

philip accepted D23961: bridge tests: Basic span test.

Looks good to me. Thank you!

Mar 15 2020, 2:39 AM

Mar 11 2020

philip committed rS358866: Welcome Nick O'Brien as a src committer..
Welcome Nick O'Brien as a src committer.
Mar 11 2020, 3:45 AM

Mar 9 2020

philip closed D24004: SiFive/SPI: Silence build warning.
Mar 9 2020, 4:09 AM
philip committed rS358801: fuspi: silence build warning, plug resource leak.
fuspi: silence build warning, plug resource leak
Mar 9 2020, 4:09 AM
philip accepted D24004: SiFive/SPI: Silence build warning.

Pointy hat to: philip :)

Mar 9 2020, 3:38 AM

Mar 7 2020

philip accepted D23877: RISCV Platform Specific Code.

It sounds like we're reaching consensus that we should move forward with this.

Mar 7 2020, 4:13 AM · riscv

Mar 5 2020

philip added a comment to D23877: RISCV Platform Specific Code.

I agree that we should be careful not to go down the path of ARM with a plethora of platform files littering the tree. While this patch makes that easier, it doesn't actually force us in that direction.

Mar 5 2020, 3:57 AM · riscv
philip accepted D23960: bridge test: adding and removing static addresses.

Looks good to me!

Mar 5 2020, 3:43 AM
philip added a comment to D23961: bridge tests: Basic span test.

Isn't this test always going to succeed as long as the span can be removed? Or am I misunderstanding something?

Mar 5 2020, 3:43 AM
philip accepted D23959: bridge test: spanning tree.

This looks good in principle.

Mar 5 2020, 3:38 AM

Mar 2 2020

philip committed rS358517: MFC r358419:.
MFC r358419:
Mar 2 2020, 2:48 AM
philip committed rS358516: MFC r358418:.
MFC r358418:
Mar 2 2020, 2:47 AM
philip committed rS358514: MFC r358419:.
MFC r358419:
Mar 2 2020, 2:46 AM
philip committed rS358513: MFC r358418:.
MFC r358418:
Mar 2 2020, 2:44 AM

Mar 1 2020

philip accepted D23879: RISCV: PLATFORM_DEFAULT implementation.

Looks good to me.

Mar 1 2020, 3:12 AM · riscv

Feb 28 2020

philip committed rS358419: bsdinstall: remove the Italian mirror.
bsdinstall: remove the Italian mirror
Feb 28 2020, 3:39 AM
philip committed rS358418: bsdconfig: remove the Italian mirror.
bsdconfig: remove the Italian mirror
Feb 28 2020, 3:39 AM

Feb 25 2020

philip added a comment to D23820: sysutils/opensbi: update to version 0.6.

This looks good but I'd like to test it before I click the accept button. I'll try to make this work on my FU540 this afternoon.

Feb 25 2020, 3:42 AM

Feb 24 2020

philip added a comment to D23812: Add a soft-float riscv kernel config.
In D23812#523285, @imp wrote:

Yeah. The diff is tiny.

Unless anyone else under riscv objects strongly, we should just build both targets.

I have the commit all queued up (along with a hack to config to mkdir ../compile when it doesn't exist because git automatically deletes empty directories). I'll push it in about 8 hours from now (~8am MST Denver Co time). that should give people in EU time enough to wake up and read their mail.

Feb 24 2020, 6:56 AM
philip accepted D23812: Add a soft-float riscv kernel config.

Yeah. The diff is tiny.

Feb 24 2020, 6:50 AM
philip added a comment to D23812: Add a soft-float riscv kernel config.
In D23812#523274, @imp wrote:

This looks good to me.

Any reason not to hook this up to universe? The more testing RISC-V gets, the better. Does it significantly increase the build-time?

Paranoia on my part. If it's ready, no reason...

Feb 24 2020, 5:35 AM
philip accepted D23808: bridge: Move locking defines into if_bridge.c.

Good idea. There should be no reason for the bridge locks to be manipulated elsewhere.

Feb 24 2020, 5:18 AM
philip added a comment to D23812: Add a soft-float riscv kernel config.

(Adding riscv for wider review.)

Feb 24 2020, 4:48 AM
philip added a reviewer for D23812: Add a soft-float riscv kernel config: riscv.
Feb 24 2020, 4:47 AM
philip accepted D23812: Add a soft-float riscv kernel config.

This looks good to me.

Feb 24 2020, 4:47 AM

Feb 20 2020

philip accepted D23741: riscv: Set MACHINE_ARCH define based on TARGET_ARCH.

Looks good to me.
Thank you!

Feb 20 2020, 3:00 AM

Feb 17 2020

philip committed rP526343: astro/xearth: remove my inaccurate marker.
astro/xearth: remove my inaccurate marker
Feb 17 2020, 6:27 AM

Feb 16 2020

philip added a comment to D23697: bridge: Basic test case.
In D23697#520613, @kp wrote:
  • sort test list in Makefile
  • rename test case
Feb 16 2020, 10:46 PM

Feb 15 2020

philip accepted D23697: bridge: Basic test case.

This looks good to me. I had one minor style observation in addition to the ones @melifaro caught.

Feb 15 2020, 11:40 PM