Page MenuHomeFreeBSD

networkUmbrella
ActivePublic

Recent Activity

Sun, Nov 18

farrokhi added a member for network: farrokhi.
Sun, Nov 18, 1:53 PM

Oct 30 2018

araujo closed D17576: Allow changing lagg(4) MTU.
Oct 30 2018, 9:54 AM · network

Oct 24 2018

mav accepted D17576: Allow changing lagg(4) MTU.

I have no specific objections. Looks good to me. It just looks slightly odd, that MTU is handled different from other properties -- set before interface addition to LAGG, while multicast filters set after just before protocol initialization, and capabilities are set after the protocol initialization. As one of downsides this different order required addition of duplicate checks for LAGG nesting.

Oct 24 2018, 4:02 PM · network
ryan_freqlabs.com updated the diff for D17576: Allow changing lagg(4) MTU.

Addressed feedback by adding handling of new ports, so creating a lagg or adding new ports to an existing lagg sets all the port interfaces to the correct MTU automatically, too.

Oct 24 2018, 3:41 AM · network

Oct 16 2018

ryan_freqlabs.com updated the diff for D17576: Allow changing lagg(4) MTU.

Addressed feedback I received here and elsewhere on the previous patch. Please consider this alternative approach.

Oct 16 2018, 7:27 PM · network
ryan_freqlabs.com added a comment to D17576: Allow changing lagg(4) MTU.

For additional context, here is the code from if_bridge.c this is based on:

case SIOCSIFMTU:
        if (ifr->ifr_mtu < 576) {
                error = EINVAL;
                break;
        }
        if (LIST_EMPTY(&sc->sc_iflist)) {
                sc->sc_ifp->if_mtu = ifr->ifr_mtu;
                break;
        }
        BRIDGE_LOCK(sc);
        LIST_FOREACH(bif, &sc->sc_iflist, bif_next) {
                if (bif->bif_ifp->if_mtu != ifr->ifr_mtu) {
                        log(LOG_NOTICE, "%s: invalid MTU: %u(%s)"
                            " != %d\n", sc->sc_ifp->if_xname,
                            bif->bif_ifp->if_mtu,
                            bif->bif_ifp->if_xname, ifr->ifr_mtu);
                        error = EINVAL;
                        break;
                }
        }
        if (!error)
                sc->sc_ifp->if_mtu = ifr->ifr_mtu;
        BRIDGE_UNLOCK(sc);
        break;

It was not obvious to me why the minimum MTU should be limited by IPv4 but I included it here erring on the side of caution.

Oct 16 2018, 3:36 PM · network
pi added a comment to D17576: Allow changing lagg(4) MTU.

The value seems to come from RFC791, quote:

Oct 16 2018, 10:43 AM · network
0mp added inline comments to D17576: Allow changing lagg(4) MTU.
Oct 16 2018, 10:11 AM · network
araujo added inline comments to D17576: Allow changing lagg(4) MTU.
Oct 16 2018, 10:03 AM · network
0mp added a comment to D17576: Allow changing lagg(4) MTU.

Also, the manpage patch looks good to me.

Oct 16 2018, 9:50 AM · network
0mp added inline comments to D17576: Allow changing lagg(4) MTU.
Oct 16 2018, 9:47 AM · network
ryan_freqlabs.com updated the diff for D17576: Allow changing lagg(4) MTU.

Bumped the date in the man page.

Oct 16 2018, 7:44 AM · network
bcr accepted D17576: Allow changing lagg(4) MTU.

You need to bump the .Dd at the beginning of the document to the date of the commit since this is a content change.

Oct 16 2018, 7:36 AM · network
araujo accepted D17576: Allow changing lagg(4) MTU.

LGTM! I have spoke with Ryan to get a better scenario about this issue and here there is a reference for that: https://redmine.ixsystems.com/issues/25092

Oct 16 2018, 4:34 AM · network

Oct 15 2018

ryan_freqlabs.com created D17576: Allow changing lagg(4) MTU.
Oct 15 2018, 10:34 PM · network

Sep 19 2018

rockyhotas_post.com added a comment to D10600: Revision of LDAP section of the FreeBSD Handbook.

An update as regards the links issues. According to the Primer,

Sep 19 2018, 2:42 PM · Doc Committers, network
rockyhotas_post.com updated the diff for D10600: Revision of LDAP section of the FreeBSD Handbook.

Also the second part has been completely revisited, to be more concise and more uniform to the original text.
Links to specific versions of the OS are still present. Please, refer to this previous comment for more details. How to fix this?

Sep 19 2018, 2:09 PM · Doc Committers, network

Jul 1 2018

Diffusion closed D14536: Set DSCP bits in ip_carp.
Jul 1 2018, 8:37 AM · network

Jun 29 2018

darkfiberiru_gmail.com added a comment to D14536: Set DSCP bits in ip_carp.

Thanks for the help kristof. I couldn't find the documentation to bound input of sysctl's but I definitely agree it's better to validate it on entry.

Jun 29 2018, 10:49 AM · network
darkfiberiru_gmail.com updated the diff for D14536: Set DSCP bits in ip_carp.

Updated with help from kristof to validate sysctl on change.

Jun 29 2018, 10:46 AM · network

Jun 22 2018

rockyhotas_post.com added a comment to D10600: Revision of LDAP section of the FreeBSD Handbook.
In D10600#337622, @bcr wrote:

So, you're saying the we need testers for this configuration before we put it in the handbook as official instructions?

Jun 22 2018, 2:28 PM · Doc Committers, network

Jun 21 2018

bcr removed a reviewer for D10600: Revision of LDAP section of the FreeBSD Handbook: manpages.
Jun 21 2018, 4:59 PM · Doc Committers, network
bcr added a comment to D10600: Revision of LDAP section of the FreeBSD Handbook.

So, you're saying the we need testers for this configuration before we put it in the handbook as official instructions?

Jun 21 2018, 4:58 PM · Doc Committers, network

Jun 20 2018

rockyhotas_post.com updated the diff for D10600: Revision of LDAP section of the FreeBSD Handbook.

Applied all the modifications suggested by @bcr . Thank you!
The line-breaking were a first attempt to handle too-long lines, your solution is far better. A couple of comments:

Jun 20 2018, 2:49 PM · Doc Committers, network

Jun 18 2018

bcr added a comment to D10600: Revision of LDAP section of the FreeBSD Handbook.

A few suggestions, mostly about line breaks with a few textual corrections.

Jun 18 2018, 5:37 PM · Doc Committers, network
allanjude added a reviewer for D10600: Revision of LDAP section of the FreeBSD Handbook: bcr.
Jun 18 2018, 2:43 AM · Doc Committers, network
eadler resigned from D10600: Revision of LDAP section of the FreeBSD Handbook.
Jun 18 2018, 2:26 AM · Doc Committers, network

Jun 9 2018

kristof added a comment to D14536: Set DSCP bits in ip_carp.

I'd prefer the sysctl to reject values that are out of range.
What do you think about this: https://people.freebsd.org/~kp/patches/D14536.patch ?

Jun 9 2018, 8:31 PM · network

Jun 8 2018

darkfiberiru_gmail.com updated the diff for D14536: Set DSCP bits in ip_carp.

Update sysctl to be based on decimal dscp value instead of toggle

Jun 8 2018, 7:46 PM · network

May 22 2018

fabient closed D15050: Add a SPD cache to speed up lookups.
May 22 2018, 3:54 PM · network

May 17 2018

emaste closed D15168: Microchip's LAN78XX driver for FreeBSD.
May 17 2018, 2:05 PM · network

May 15 2018

emeric.poupon_stormshield.eu updated the diff for D15050: Add a SPD cache to speed up lookups.

ae's remarks

May 15 2018, 9:08 AM · network
mmacy added a watcher for network: mmacy.
May 15 2018, 1:08 AM

May 14 2018

ae added inline comments to D15050: Add a SPD cache to speed up lookups.
May 14 2018, 10:16 AM · network
emeric.poupon_stormshield.eu added inline comments to D15050: Add a SPD cache to speed up lookups.
May 14 2018, 8:21 AM · network

May 13 2018

ae accepted D15050: Add a SPD cache to speed up lookups.

I think we can try to test this with wider auditory.

May 13 2018, 1:06 PM · network

May 11 2018

arshankhanifar_gmail.com added a comment to D15168: Microchip's LAN78XX driver for FreeBSD.

yeah I must've forgotten to do that sorry. Thanks!

May 11 2018, 1:30 PM · network
emaste added a comment to D15168: Microchip's LAN78XX driver for FreeBSD.

style(9) issue - should not have trailing whitespace (tabs or spaces) at the end of the line
I will clean these up before commit

May 11 2018, 1:28 PM · network
emaste added a comment to D15168: Microchip's LAN78XX driver for FreeBSD.

I added the pid in rS333489, as well as the pid for the LAN7801 (which Microchip sent me after the co-op term ended). I'll commit the driver with LAN7800 support only, then see if the 7801 "just works" or if we need additional changes.

May 11 2018, 1:16 PM · network
wollman added inline comments to D10600: Revision of LDAP section of the FreeBSD Handbook.
May 11 2018, 1:40 AM · Doc Committers, network

May 10 2018

rockyhotas_post.com added a comment to D10600: Revision of LDAP section of the FreeBSD Handbook.

A new version with a more concise text in the first part is available.

May 10 2018, 1:55 PM · Doc Committers, network
rockyhotas_post.com added a comment to D10600: Revision of LDAP section of the FreeBSD Handbook.

Is it planned to address the client side (e.g., nss-pam-ldapd) or just the server?

May 10 2018, 1:44 PM · Doc Committers, network
rockyhotas_post.com updated the diff for D10600: Revision of LDAP section of the FreeBSD Handbook.

Correction of the first part. The original text has been restored till the slapd.ldif example. The first section of slapd.ldif configuration has been significantly shortened, and many not necessary flaws have been deleted. If this is ok, the remainder can be modified following the same method.
The whole chapter


is also attached.

May 10 2018, 1:40 PM · Doc Committers, network

May 9 2018

wollman added a comment to D10600: Revision of LDAP section of the FreeBSD Handbook.

Is it planned to address the client side (e.g., nss-pam-ldapd) or just the server?

May 9 2018, 2:09 AM · Doc Committers, network

May 8 2018

hselasky accepted D15168: Microchip's LAN78XX driver for FreeBSD.

Looks good to me.

May 8 2018, 8:15 AM · network
mmacy closed D8556: Fix spurious retransmit recovery on low latency networks.
May 8 2018, 2:22 AM · network
sbruno accepted D8556: Fix spurious retransmit recovery on low latency networks.
May 8 2018, 1:14 AM · network

May 3 2018

sbruno closed D10556: Update cubic constants.
May 3 2018, 3:01 PM · network
kmacy added a comment to D10556: Update cubic constants.

@shurd @sbruno might one of you commit this?

May 3 2018, 4:10 AM · network
kmacy updated subscribers of D10556: Update cubic constants.
May 3 2018, 4:10 AM · network