rstone (Ryan Stone)
User

Projects

User Details

User Since
May 12 2014, 8:03 PM (192 w, 2 d)

Recent Activity

Dec 14 2017

rstone committed rS326860: Plug an ifaddr leak when changing a route's src.
Plug an ifaddr leak when changing a route's src
Dec 14 2017, 8:49 PM
rstone closed D13417: Plug an ifaddr leak when changing a route's src.
Dec 14 2017, 8:49 PM

Dec 13 2017

rstone added a comment to D13417: Plug an ifaddr leak when changing a route's src.
In D13417#281628, @ae wrote:

It would be nice if you describe why this leak happens, i.e. where leaked reference was acquired.

Dec 13 2017, 4:01 PM

Dec 7 2017

rstone updated the test plan for D13417: Plug an ifaddr leak when changing a route's src.
Dec 7 2017, 9:54 PM
rstone created D13417: Plug an ifaddr leak when changing a route's src.
Dec 7 2017, 9:50 PM

Nov 17 2017

rstone added inline comments to D12101: swfw_sync DELAY -> sleep conversion.
Nov 17 2017, 2:37 PM · network

Oct 24 2017

rstone created D12772: Prevent bge_init and bge_rxeof from running in parallel.
Oct 24 2017, 3:53 AM

Oct 23 2017

rstone accepted D12749: Move clear_unrhdr to tmpfs_free_tmp..
Oct 23 2017, 3:14 PM

Oct 16 2017

rstone accepted D12662: Properly reset fields in clean_unrhdr..
Oct 16 2017, 3:40 PM

Oct 11 2017

rstone accepted D12591: Add clearing function for unr(9), call it from tmpfs..
Oct 11 2017, 9:23 PM

Sep 22 2017

rstone accepted D12468: ddb(4): Add 'show badstacks' command to show witness badstacks.
Sep 22 2017, 7:43 PM

Sep 12 2017

rstone accepted D12191: Allow vlan interfaces to rx through netmap(4).
Sep 12 2017, 11:57 PM
rstone committed rS323506: Fix incorrect error message in iovctl.
Fix incorrect error message in iovctl
Sep 12 2017, 9:12 PM

Aug 15 2017

rstone accepted D11370: Rework vlan(4) locking..
Aug 15 2017, 5:05 PM

Aug 4 2017

rstone accepted D11777: Selectively print "hwaddr" from ifconfig(8)..
Aug 4 2017, 8:51 PM

Aug 2 2017

rstone committed rS321939: Add my birthdate to the calendar.
Add my birthdate to the calendar
Aug 2 2017, 7:45 PM

Jul 31 2017

rstone accepted D11797: Add myself to the calendar..
Jul 31 2017, 5:28 PM

Jul 20 2017

rstone accepted D11670: Add myself (mjoras) as a new src committer.
Jul 20 2017, 6:03 PM
rstone committed rS321300: Welcome Matt Joras (mjoras@) as a new src committer. Matt has been doing.
Welcome Matt Joras (mjoras@) as a new src committer. Matt has been doing
Jul 20 2017, 6:02 PM
rstone accepted D11672: Add myself and mentor line to committers-src.dot..
Jul 20 2017, 6:02 PM
rstone committed rD50525: Update my GPG key.
Update my GPG key
Jul 20 2017, 1:30 AM

Jul 13 2017

rstone accepted D11573: Fix kldload of if_ixl without PCI_IOV kernel option..
Jul 13 2017, 7:28 PM

Jul 12 2017

rstone added a comment to D11560: Remove use of 9k clusters from mlx4_en rx path.

Hi,

Don't pull the "old behaviour" into the driver. You should use a linked list of mbufs and load that instead of the mlx4_en_frag_info structure now we are using busdma!

There is a better way to implement this. Can Mellanox take over this issue?

--HPS

Jul 12 2017, 4:22 PM

Jul 11 2017

rstone created D11560: Remove use of 9k clusters from mlx4_en rx path.
Jul 11 2017, 10:59 PM

Jun 27 2017

rstone added inline comments to D11370: Rework vlan(4) locking..
Jun 27 2017, 8:09 PM
rstone added inline comments to D11370: Rework vlan(4) locking..
Jun 27 2017, 5:35 PM

May 29 2017

rstone added a comment to D8556: Fix spurious retransmit recovery on low latency networks.

@kmacy I have not. We probably have an equivalent fix committed locally @ $WORK but it might be tied too closely to the high-precision timestamp work to easily extract.

May 29 2017, 6:28 PM · network

May 24 2017

rstone accepted D10874: vmxnet3 crash when LRO is enabled.
May 24 2017, 7:23 PM

May 3 2017

rstone added a comment to D10535: ixgbe: Acquire lock for shared code API calls in handle_phy.

Maybe you've seen something that requires this lock acquisition in your testing. Can you explain why we need to acquire this lock here?

May 3 2017, 9:36 PM

Apr 28 2017

rstone created D10535: ixgbe: Acquire lock for shared code API calls in handle_phy.
Apr 28 2017, 3:13 PM

Apr 5 2017

rstone committed rS316527: Revert the optimization from r304436.
Revert the optimization from r304436
Apr 5 2017, 4:57 PM

Apr 3 2017

rstone updated the diff for D10255: Fix a double free in ixgbe_rxeof().

Add the locking mentioned the description but omitted from the
actual revision.

Apr 3 2017, 7:04 PM
rstone added a comment to D10255: Fix a double free in ixgbe_rxeof().

I'm not sure what we want to do with this fix given the imminent iflib conversion, but at least this should go into stable branches.

Apr 3 2017, 7:02 PM
rstone created D10255: Fix a double free in ixgbe_rxeof().
Apr 3 2017, 7:00 PM

Mar 22 2017

rstone abandoned D9465: Remove unnecessary ifdef soup from struct tcpcb.

Obsoleted by gleb's User/Kernel KPI fixes

Mar 22 2017, 6:00 PM

Feb 23 2017

rstone added a reviewer for D9485: Make LACP behavior more closely conform to the standard: rstone.
Feb 23 2017, 5:34 PM

Feb 18 2017

rstone added inline comments to D9519: Don't zero out srtt after excess retransmits.
Feb 18 2017, 12:46 AM

Feb 17 2017

rstone added inline comments to D9658: Remove the arbitrary limit on DTrace buffers.
Feb 17 2017, 10:55 PM

Feb 16 2017

rstone committed rS313824: Revert r313814 and r313816.
Revert r313814 and r313816
Feb 16 2017, 9:18 PM
rstone committed rS313816: Fix a typo in my previous commit.
Fix a typo in my previous commit
Feb 16 2017, 8:06 PM
rstone committed rS313814: Check for preemption after lowering a thread's priority.
Check for preemption after lowering a thread's priority
Feb 16 2017, 7:41 PM
rstone closed D9518: Check for preemption after lowering a thread's priority by committing rS313814: Check for preemption after lowering a thread's priority.
Feb 16 2017, 7:41 PM

Feb 15 2017

rstone added a comment to D9465: Remove unnecessary ifdef soup from struct tcpcb.

I realize the issue there is exposure of a type definition to userland, but a related question is - what exactly is the userland-ABI property we are trying to maintain here? Are we just trying to keep this struct the same size and layout under all kernel configuration option selections and feature evolutions for a given machine type? Or are we also trying to keep it the same size and layout across different machine types (or at the very least a single pair of relevant machine types)? For example, is the #ifdef_LP64 really necessary in the TCPPCAP section?

Feb 15 2017, 12:49 AM

Feb 11 2017

rstone committed rS313646: Don't zero out srtt after excess retransmits.
Don't zero out srtt after excess retransmits
Feb 11 2017, 5:05 PM
rstone closed D9519: Don't zero out srtt after excess retransmits by committing rS313646: Don't zero out srtt after excess retransmits.
Feb 11 2017, 5:05 PM
rstone updated the diff for D9519: Don't zero out srtt after excess retransmits.
  • fixup! Don't zero out srtt after excess retransmits
Feb 11 2017, 4:50 PM

Feb 9 2017

rstone retitled D9519: Don't zero out srtt after excess retransmits from to Don't zero out srtt after excess retransmits.
Feb 9 2017, 6:18 PM
rstone added a comment to D9518: Check for preemption after lowering a thread's priority.
Feb 9 2017, 5:57 PM
rstone added a comment to D9518: Check for preemption after lowering a thread's priority.

See this ML post for a detailed description of the problem:
https://lists.freebsd.org/pipermail/freebsd-current/2013-January/039261.html

Feb 9 2017, 5:55 PM
rstone retitled D9518: Check for preemption after lowering a thread's priority from to Check for preemption after lowering a thread's priority.
Feb 9 2017, 5:53 PM

Feb 7 2017

rstone committed rS313388: MFC r312544.
MFC r312544
Feb 7 2017, 3:13 PM
rstone committed rS313387: MFC r312544.
MFC r312544
Feb 7 2017, 3:12 PM

Feb 6 2017

rstone retitled D9465: Remove unnecessary ifdef soup from struct tcpcb from to Remove unnecessary ifdef soup from struct tcpcb.
Feb 6 2017, 11:36 PM

Jan 20 2017

rstone closed D9164: Set ifm_cur to NULL in ifmedia_removeall. by committing rS312544: Fix reference to free memory in ixgbe/if_media.c.
Jan 20 2017, 5:17 PM
rstone committed rS312544: Fix reference to free memory in ixgbe/if_media.c.
Fix reference to free memory in ixgbe/if_media.c
Jan 20 2017, 5:17 PM

Dec 9 2016

rstone added inline comments to D8736: Add COMPAT_FREEBSD11 and use it vm_meter.c..
Dec 9 2016, 3:30 AM

Dec 2 2016

rstone committed rS309414: Revert r309372.
Revert r309372
Dec 2 2016, 3:39 PM

Dec 1 2016

rstone committed rS309372: Fix a false positive in a buf_ring assert.
Fix a false positive in a buf_ring assert
Dec 1 2016, 9:08 PM
rstone closed D8685: Fix a false positive in a buf_ring assert by committing rS309372: Fix a false positive in a buf_ring assert.
Dec 1 2016, 9:08 PM

Nov 30 2016

rstone added inline comments to D8685: Fix a false positive in a buf_ring assert.
Nov 30 2016, 11:42 PM
rstone updated the diff for D8685: Fix a false positive in a buf_ring assert.

Ensure we don't walk off the end of the ring

Nov 30 2016, 11:41 PM
rstone updated subscribers of D8685: Fix a false positive in a buf_ring assert.
Nov 30 2016, 9:59 PM
rstone retitled D8685: Fix a false positive in a buf_ring assert from to Fix a false positive in a buf_ring assert.
Nov 30 2016, 9:43 PM

Nov 26 2016

rstone committed rS309177: MFC r308580:.
MFC r308580:
Nov 26 2016, 1:16 AM

Nov 23 2016

rstone accepted D8624: Add tunable to disable destructive dtrace Security.
Nov 23 2016, 4:50 PM
rstone added inline comments to D8624: Add tunable to disable destructive dtrace Security.
Nov 23 2016, 4:50 PM

Nov 18 2016

rstone committed rS308790: Add a dtrace script for collecting schedgraph data.
Add a dtrace script for collecting schedgraph data
Nov 18 2016, 2:29 AM

Nov 17 2016

rstone accepted D8515: loader: beri_sdcard_disk_print() needs to return int..
Nov 17 2016, 6:19 PM

Nov 12 2016

rstone committed rS308580: Don't read if_counters with if_addr_lock held.
Don't read if_counters with if_addr_lock held
Nov 12 2016, 7:03 PM
rstone closed D8498: Don't read if_counters with if_addr_lock held by committing rS308580: Don't read if_counters with if_addr_lock held.
Nov 12 2016, 7:03 PM

Nov 11 2016

rstone committed rS308562: Fix git tools when run against a worktree.
Fix git tools when run against a worktree
Nov 11 2016, 11:07 PM
rstone closed D8501: Fix arcgit when run from a worktree by committing rS308562: Fix git tools when run against a worktree.
Nov 11 2016, 11:07 PM
rstone updated the diff for D8501: Fix arcgit when run from a worktree.

--git-dir is unreliable, so use -C $git_repo instead

Nov 11 2016, 9:06 PM
rstone added inline comments to D8501: Fix arcgit when run from a worktree.
Nov 11 2016, 8:57 PM
rstone added inline comments to D8501: Fix arcgit when run from a worktree.
Nov 11 2016, 8:51 PM
rstone updated the diff for D8501: Fix arcgit when run from a worktree.

Similar fix is needed in importgit

Nov 11 2016, 8:29 PM
rstone retitled D8501: Fix arcgit when run from a worktree from to Fix arcgit when run from a worktree.
Nov 11 2016, 7:26 PM
rstone abandoned D8500: Fix arcgit when run from a worktree.
Nov 11 2016, 7:26 PM
rstone retitled D8500: Fix arcgit when run from a worktree from to Fix arcgit when run from a worktree.
Nov 11 2016, 7:26 PM
rstone added reviewers for D8498: Don't read if_counters with if_addr_lock held: sbruno, asomers.
Nov 11 2016, 5:42 PM
rstone retitled D8498: Don't read if_counters with if_addr_lock held from to Don't read if_counters with if_addr_lock held.
Nov 11 2016, 5:41 PM
rstone added a comment to D8306: Fix lock order reversal in lagg_get_counter.

This is not the correct fix. The bug lies in a higher layer; the stack must never call into the ifnet layer with the if_addr_lock already held. I see how to fix the upper layer, so I'll take that.

Nov 11 2016, 3:34 PM

Oct 24 2016

rstone closed D8303: Fix ip_output() on point-to-point links by committing rS307887: Fix ip_output() on point-to-point links.
Oct 24 2016, 10:11 PM
rstone committed rS307887: Fix ip_output() on point-to-point links.
Fix ip_output() on point-to-point links
Oct 24 2016, 10:11 PM

Oct 20 2016

rstone updated subscribers of D8303: Fix ip_output() on point-to-point links.
Oct 20 2016, 6:30 PM
rstone retitled D8303: Fix ip_output() on point-to-point links from to Fix ip_output() on point-to-point links.
Oct 20 2016, 6:29 PM
rstone committed rS307681: Set the executable bit on arcgit and importgit.
Set the executable bit on arcgit and importgit
Oct 20 2016, 6:28 PM
rstone closed D2071: Add some tools to simplify the use of git by committing rS307680: Add some tools to simplify the use of git.
Oct 20 2016, 6:24 PM
rstone committed rS307680: Add some tools to simplify the use of git.
Add some tools to simplify the use of git
Oct 20 2016, 6:24 PM

Oct 5 2016

rstone accepted D8157: Corrected non-portable reuse of va_list in dt_printf().
Oct 5 2016, 9:34 PM

Sep 8 2016

rstone updated the test plan for D7821: Preserve ECN bits when merging frames in LRO.
Sep 8 2016, 2:18 AM
rstone retitled D7821: Preserve ECN bits when merging frames in LRO from to Preserve ECN bits when merging frames in LRO.
Sep 8 2016, 2:16 AM

Aug 22 2016

rstone committed rS304606: Temporarily disable the optimization from r304436.
Temporarily disable the optimization from r304436
Aug 22 2016, 3:28 PM

Aug 18 2016

rstone committed rS304437: Fix unlocked access to ifnet address list.
Fix unlocked access to ifnet address list
Aug 18 2016, 10:59 PM
rstone committed rS304436: Don't check for broadcast IPs on non-bcast pkts.
Don't check for broadcast IPs on non-bcast pkts
Aug 18 2016, 10:59 PM
rstone closed D7227: Fix unlocked access to ifnet address list by committing rS304437: Fix unlocked access to ifnet address list.
Aug 18 2016, 10:59 PM
rstone closed D7309: Don't check for broadcast IPs on non-bcast pkts by committing rS304436: Don't check for broadcast IPs on non-bcast pkts.
Aug 18 2016, 10:59 PM
rstone committed rS304435: Don't iterate over the ifnet addr list in ip_output().
Don't iterate over the ifnet addr list in ip_output()
Aug 18 2016, 10:59 PM
rstone closed D7266: Don't iterate over the ifnet addr list in ip_output() by committing rS304435: Don't iterate over the ifnet addr list in ip_output().
Aug 18 2016, 10:59 PM

Aug 15 2016

rstone committed rS304179: MFC r304163.
MFC r304163
Aug 15 2016, 7:18 PM