Page MenuHomeFreeBSD

rstone (Ryan Stone)
User

Projects

User Details

User Since
May 12 2014, 8:03 PM (360 w, 6 d)

Recent Activity

Wed, Mar 24

rstone accepted D29391: LinuxKPI: remove < 5.0 version support.

I can confirm don't have any out-of-tree consumers of linuxkpi, so looks fine to me.

Wed, Mar 24, 8:25 PM

Feb 16 2021

rstone accepted D28639: Add ifa_try_ref() to simplify ifa handling inside epoch..
Feb 16 2021, 7:55 PM
rstone abandoned D28705: Fix ifa refcount leak in ifa_ifwithnet().
Feb 16 2021, 4:26 PM
rstone added a reviewer for D28705: Fix ifa refcount leak in ifa_ifwithnet(): network.
Feb 16 2021, 4:21 PM
rstone requested review of D28705: Fix ifa refcount leak in ifa_ifwithnet().
Feb 16 2021, 4:20 PM

Feb 14 2021

rstone accepted D28649: Do not reference returned ifa in in6_ifawithifp()..
Feb 14 2021, 4:13 AM

Feb 12 2021

rstone accepted D28629: Fix ifa refcount leak during route addition..
Feb 12 2021, 9:42 PM
rstone accepted D28603: libdtrace: Don't try to unput a nul terminator.

Thanks for looking into this for me.

Feb 12 2021, 4:54 PM

Feb 4 2021

rstone committed R10:8a06ca2f734c: Fix mismerge in OFED update (authored by rstone).
Fix mismerge in OFED update
Feb 4 2021, 6:59 PM
rstone closed D28421: Fix mismerge in OFED update.
Feb 4 2021, 6:58 PM
rstone closed D28420: Fix race condition in linuxkpi workqueue.
Feb 4 2021, 6:56 PM
rstone committed R10:b58cf1cb35ab: Fix race condition in linuxkpi workqueue (authored by rstone).
Fix race condition in linuxkpi workqueue
Feb 4 2021, 6:56 PM

Feb 3 2021

rstone closed D28422: Add a VM flag to prevent reclaim on a failed contig allocation.
Feb 3 2021, 9:18 PM
rstone committed R10:660344ca44c6: Add a VM flag to prevent reclaim on a failed contig allocation (authored by rstone).
Add a VM flag to prevent reclaim on a failed contig allocation
Feb 3 2021, 9:18 PM

Feb 2 2021

rstone updated the diff for D28420: Fix race condition in linuxkpi workqueue.

Fix lock leak. Sorry, this review was based off of an
older version of my patch that didn't have that fixed.
I've confirmed that this is now in sync with what was
tested internally at $WORK

Feb 2 2021, 2:01 PM

Feb 1 2021

rstone updated the diff for D28422: Add a VM flag to prevent reclaim on a failed contig allocation.

Change the value of M_NORECLAIM to avoid the style issue

Feb 1 2021, 6:16 PM
rstone updated the diff for D28422: Add a VM flag to prevent reclaim on a failed contig allocation.

Fix overflap between new flag and count field

Feb 1 2021, 6:14 PM

Jan 29 2021

rstone added inline comments to D28422: Add a VM flag to prevent reclaim on a failed contig allocation.
Jan 29 2021, 11:57 PM
rstone requested review of D28422: Add a VM flag to prevent reclaim on a failed contig allocation.
Jan 29 2021, 9:18 PM
rstone requested review of D28421: Fix mismerge in OFED update.
Jan 29 2021, 8:52 PM
rstone added a comment to D28017: Fix race in cancel_delayed_work() in the LinuxKPI.

Sorry about the delay in coming back to this; I've had to deal with a number of critical issues at work. I ported the patch that we tested internally to main and posted it to this review:

Jan 29 2021, 8:36 PM
rstone requested review of D28420: Fix race condition in linuxkpi workqueue.
Jan 29 2021, 8:32 PM

Jan 15 2021

rstone added a comment to D28017: Fix race in cancel_delayed_work() in the LinuxKPI.

sorry I got distracted by a different critical issue at work. Will be able to return to this next week

Jan 15 2021, 9:58 PM

Jan 7 2021

rstone added inline comments to D28017: Fix race in cancel_delayed_work() in the LinuxKPI.
Jan 7 2021, 4:44 PM
rstone requested changes to D28017: Fix race in cancel_delayed_work() in the LinuxKPI.

This patch doesn't work. After the goto retry, nothing stops the cancelling thread from seeing state still in WORK_ST_CANCEL, and then the timer thread can come in and change it to TASK, causing the same bug.

Jan 7 2021, 4:03 PM
rstone added a comment to D28017: Fix race in cancel_delayed_work() in the LinuxKPI.

I don't think that spinning is the right answer. That could hold the CPU that the callout needs to make progress, resulting in a livelock.

Jan 7 2021, 2:51 PM

Dec 13 2020

rstone committed R9:df279f34273b: add metadata and pgp key for new committer rstone@ (authored by rstone).
add metadata and pgp key for new committer rstone@
Dec 13 2020, 5:33 PM
rstone committed R9:8d05a4dbea5b: add new committer metadata and news entry for new committer rstone (authored by rstone).
add new committer metadata and news entry for new committer rstone
Dec 13 2020, 5:33 PM

Dec 9 2020

rstone requested changes to D27505: Fix subinterface vlan creation..

Removing the ability to create unnamed vlans is an unnecessary POLA violation. It can make sense for the user to establish a convention that vlanX is for vlan tag X, but we absolutely shouldn't bake that assumption into the kernel.

Dec 9 2020, 5:53 PM

Nov 21 2020

rstone added a comment to D27279: if: Protect V_ifnet in vnet_if_return().

Try putting entries in the witness_order_list_entry in kern/subr_witness.c specifying the ifnet_sx -> in_multi_sx ordering as correct. That should get better information. Likely the issue is a cycle of length larger than 2 (e.g. in_multi_sx before mystery lock, mystery lock before ifnet_sx, ifnet_sx before in_multi_sx).

Nov 21 2020, 6:53 PM

Oct 20 2020

rstone added a comment to D26879: Add ipfw SDT probe..

That shouldn't be true. Did you test that recently? I'm not sure if it'll work for standalone module builds since KDTRACE_HOOKS might not be defined.

Oct 20 2020, 7:38 PM

Aug 25 2020

rstone added a comment to D25085: netinet6: In tcp_lro_rx_ipv6(), check for IPv6 flow ID..
In D25085#560681, @lutz_donnerhacke.de wrote:

In my eyes, throwing away packets which successfully reached the destination for potential QoS/routing issues, is unexpected.

Aug 25 2020, 2:53 PM · network

Jul 3 2020

rstone added a comment to D23973: Infiniband clients must be attached and detached in a specific order.

What's the status of this? We're hitting this problem very frequently at Isilon and this patch does fix the issue.

Jul 3 2020, 2:29 PM

Jun 20 2020

rstone accepted D25364: oce(4): Account and trace mbufs before handing to hw.
Jun 20 2020, 5:04 PM

Jun 18 2020

rstone added a reviewer for D25325: Fix panic induced by ndp -P: network.
Jun 18 2020, 9:18 AM
rstone requested review of D25325: Fix panic induced by ndp -P.
Jun 18 2020, 9:18 AM

May 25 2020

rstone added a comment to D24902: Time to First byte in and out.
In D24902#550400, @rrs wrote:

Has discussed on the transport call, I will be updating these to have a uint64_t and a nano-second basis for the values (including t_starttime I think since this
is what you compare these against) :)

May 25 2020, 2:45 PM

Jan 24 2020

rstone added a member for network: rstone.
Jan 24 2020, 2:54 PM

Jan 20 2020

rstone added a comment to D7821: Preserve ECN bits when merging frames in LRO.
In D7821#510126, @rscheff_gmx.at wrote:

Is this still alive? As ECN has become more interesting recently, something like this is probably needed for RFC3168 ECN flows.

Also, forgive my ignorance, but can the LRO code add some side-band information to the upstream - e.g. number of packets coalesced, or number of CE marks observed? This would be very relevant in context of Accurate ECN. Where for RFC3168 it is sufficience that any segment marked as CE to appear in the final header, for AccECN the actual number of the CE marks, and also the number of coalesced packets would be relevant, to arrive at an appropriate alpha (reduction) value.

By just moving any number of CE marks to a single, the AccECN CC reaction would be more strong, shedding more bandwidth than appropriate...

Jan 20 2020, 4:39 PM

Jan 10 2020

rstone accepted D23121: Stop prepending prefix to the result of realpath(3)..
Jan 10 2020, 4:35 PM
rstone added inline comments to D23121: Stop prepending prefix to the result of realpath(3)..
Jan 10 2020, 2:26 PM

Jan 9 2020

rstone added inline comments to D23014: Resolve relative argv0 for direct exec mode to absolute path for AT_EXECPATH..
Jan 9 2020, 7:09 PM

Jan 7 2020

rstone closed D23008: rtld: Fix segfault in direct exec mode.
Jan 7 2020, 4:03 PM
rstone committed rS356444: rtld: Fix segfault in direct exec mode.
rtld: Fix segfault in direct exec mode
Jan 7 2020, 4:03 PM

Jan 2 2020

rstone accepted D22894: Fix AT_EXECPATH for direct exec mode..
Jan 2 2020, 5:14 PM
rstone created D23008: rtld: Fix segfault in direct exec mode.
Jan 2 2020, 4:08 PM

Dec 21 2019

rstone added inline comments to D22894: Fix AT_EXECPATH for direct exec mode..
Dec 21 2019, 2:57 AM

Dec 3 2019

rstone planned changes to D22198: nd6: Reject routers on a prefix about to be freed.
Dec 3 2019, 8:02 PM

Nov 26 2019

rstone added inline comments to D22198: nd6: Reject routers on a prefix about to be freed.
Nov 26 2019, 8:22 PM
rstone added a comment to D22198: nd6: Reject routers on a prefix about to be freed.

Do you happen to have a test case for this? We don't have any ND6 regression tests at the moment. :(

Nov 26 2019, 8:21 PM

Oct 30 2019

rstone created D22198: nd6: Reject routers on a prefix about to be freed.
Oct 30 2019, 7:14 PM

Oct 23 2019

rstone closed D22127: Add missing M_NOWAIT flag.
Oct 23 2019, 5:20 PM
rstone committed rS353938: Add missing M_NOWAIT flag.
Add missing M_NOWAIT flag
Oct 23 2019, 5:20 PM
rstone added a reviewer for D22127: Add missing M_NOWAIT flag: hselasky.
Oct 23 2019, 4:24 PM
rstone created D22127: Add missing M_NOWAIT flag.
Oct 23 2019, 4:21 PM

Oct 8 2019

rstone added a comment to D21944: pci_iov: Stop preventing VFs from allocating extra bus numbers.

I suspect that means that your BIOS pre-allocated enough bus numbers to the bridge to account for the VFs. Perhaps we should add a pcib method that recursively checks that a contiguous range of bus numbers is assigned to the bridge?

Oct 8 2019, 6:49 PM

Oct 1 2019

rstone committed rS352926: Clean up duplicate entries in sys/conf/files.
Clean up duplicate entries in sys/conf/files
Oct 1 2019, 1:36 PM

Aug 27 2019

D21209: Wrap a vlan's parent's if_output in a separate function. is now accepted and ready to land.
Aug 27 2019, 8:54 PM

Oct 4 2018

rstone committed rS339185: Hold a write lock across udp_notify().
Hold a write lock across udp_notify()
Oct 4 2018, 10:04 PM
rstone closed D17246: Hold a write lock across udp_notify().
Oct 4 2018, 10:04 PM

Sep 19 2018

rstone created D17246: Hold a write lock across udp_notify().
Sep 19 2018, 5:08 PM

Jun 12 2018

rstone added a comment to D15337: Add support for higher resolution timestamps.

@rstone do you think you might be able to share the work that you or Jeff did on the frontend to adaptively lower the minRTO if the pipe was full?

Jun 12 2018, 7:23 PM

May 17 2018

rstone added a comment to D11560: Remove use of 9k clusters from mlx4_en rx path.
In D11560#326314, @kib wrote:

I do not see such code in mlx4_en_rx.c. Could you point it out, please ?

May 17 2018, 3:44 PM

May 16 2018

rstone added a comment to D11560: Remove use of 9k clusters from mlx4_en rx path.
In D11560#326054, @kib wrote:

Well, from my reading, your patch and this patch are quite similar, but this review provides two interesting optimizations.

  • Use page-size fragments if MTU >= PAGE_SIZE, already discussed on lists for mlx5.
  • Keep around mbufs and memory for unused fragments, if the received packed was shorter than MTU.

If these changes are transplanted into your patch, I believe the things start look almost identical. I want to confirm my understanding with Ryan.

May 16 2018, 5:04 PM

May 7 2018

rstone added a comment to D15337: Add support for higher resolution timestamps.

The message that I got at BSDCan last year is that they wanted to see at least a full IETF draft before these changes could be merged in, which is why my work on it stalled. Has people's position on this changed?

May 7 2018, 8:16 PM
rstone added a comment to D15337: Add support for higher resolution timestamps.

FWIW, I had a short email conversation with the writers of that draft about a year ago and they went radio silent pretty quickly. I assumed that they weren't working on it anymore.

May 7 2018, 8:06 PM

Mar 19 2018

rstone accepted D14764: Fix initialization of eventhandler mutex..
Mar 19 2018, 10:28 PM

Mar 14 2018

rstone added a comment to D14559: Add test for regression fixed in r329743.

Where is route.subr? And where did ipv4_move_subnet_route come from? I think you used the wrong base revision to generate the review.

Mar 14 2018, 8:14 PM
rstone updated the diff for D14559: Add test for regression fixed in r329743.

Move non-fib test into separate test file

Mar 14 2018, 7:03 PM

Mar 8 2018

rstone added inline comments to D14540: Several LRO fixes.
Mar 8 2018, 4:28 PM · transport
rstone accepted D14540: Several LRO fixes.
Mar 8 2018, 2:34 PM · transport

Mar 7 2018

rstone accepted D14540: Several LRO fixes.

I've written some unit tests that covering these cases here:

Mar 7 2018, 10:32 PM · transport

Mar 5 2018

rstone added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

I don't think that this conversation is going to go anywhere productive. Do you have specific technical objection to raise about this change?

Mar 5 2018, 6:02 PM
rstone added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

Care to elaborate what are you trying to achieve by moving subnet route between interfaces?

Mar 5 2018, 5:43 PM
rstone updated the diff for D14547: Allow IPv4 subnet routes to move to a different ifa.

Uploaded the wrong test to this review; fixed now

Mar 5 2018, 5:32 PM
rstone updated the diff for D14547: Allow IPv4 subnet routes to move to a different ifa.

Move route(8) tests to their own atf test file

Mar 5 2018, 5:21 PM
rstone added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

In any case, even if the use-case is weird, the current behaviour is clearly buggy and needs to be fixed in some way.

Well, I guess so. But original configuration may be supposed to be "buggy" too (read: not supported). What if you use /16 mask for single interface only and assign IP from the same prefix to other interfaces using /32 mask?

Mar 5 2018, 4:57 PM

Mar 1 2018

rstone created D14559: Add test for regression fixed in r329743.
Mar 1 2018, 9:37 PM
rstone added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

And you do you insist in doing things manually while moving IP (first route change, then reassign IP) instead of just allowing system do all housekeeping for you by reassigning IP first?

Mar 1 2018, 8:54 PM
rstone updated the diff for D14547: Allow IPv4 subnet routes to move to a different ifa.

Add ATF test cases for IPv4/IPv6 subnet route migration

Mar 1 2018, 8:51 PM
rstone updated the test plan for D14547: Allow IPv4 subnet routes to move to a different ifa.
Mar 1 2018, 8:50 PM
rstone added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

The fibs must actually exist. Set net.fibs=6 in /boot/loader.conf and reboot. Also, are you sure you need so many? I don't think there are any tests there that require more than two.

Mar 1 2018, 7:01 PM
rstone added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

In tests/sys/netinet/fibs_test.sh there are some ATF tests that check this kind of functionality. They do it on separate FIBs so they won't upset the system running the tests, and they use tap(4) and/or epair(4) interfaces. You should be able to copy one of those to create a regression test for this problem.

Mar 1 2018, 6:46 PM

Feb 28 2018

rstone updated the diff for D14547: Allow IPv4 subnet routes to move to a different ifa.

Check for NULL pointers

Feb 28 2018, 7:48 PM
rstone updated the test plan for D14547: Allow IPv4 subnet routes to move to a different ifa.
Feb 28 2018, 7:03 PM
rstone created D14547: Allow IPv4 subnet routes to move to a different ifa.
Feb 28 2018, 6:56 PM

Feb 21 2018

rstone committed rS329744: Fix route manpage to show correct flush syntax.
Fix route manpage to show correct flush syntax
Feb 21 2018, 7:14 PM
rstone closed D14401: Fix route manpage to show correct flush syntax.
Feb 21 2018, 7:14 PM
rstone committed rS329743: Allow route change requests to not specify the gateway..
Allow route change requests to not specify the gateway.
Feb 21 2018, 7:13 PM
rstone closed D14291: Allow route change requests to not specify the gateway..
Feb 21 2018, 7:13 PM

Feb 16 2018

rstone added a comment to D14291: Allow route change requests to not specify the gateway..
In D14291#300646, @ae wrote:

How it supposed to work for RADIX_MPATH case? I know RADIX_MPATH is currently broken, but anyway...

Feb 16 2018, 7:59 PM
rstone added inline comments to D14291: Allow route change requests to not specify the gateway..
Feb 16 2018, 7:53 PM
rstone added inline comments to D14291: Allow route change requests to not specify the gateway..
Feb 16 2018, 6:34 PM
rstone updated the diff for D14291: Allow route change requests to not specify the gateway..

Clarify manpage update as per rgrimes' suggestion

Feb 16 2018, 6:32 PM
rstone added a reviewer for D14401: Fix route manpage to show correct flush syntax: manpages.
Feb 16 2018, 6:14 PM
rstone created D14401: Fix route manpage to show correct flush syntax.
Feb 16 2018, 6:13 PM
rstone updated the diff for D14291: Allow route change requests to not specify the gateway..

Fix the manpage to document that the gateway parameter is
optional for most route subcommands.

Feb 16 2018, 4:42 PM

Feb 10 2018

rstone created D14291: Allow route change requests to not specify the gateway..
Feb 10 2018, 1:52 AM

Jan 29 2018

rstone accepted D14120: Remove duplicate entries from various conf/files*.
Jan 29 2018, 5:27 PM

Jan 23 2018

rstone closed D13990: Increment the route table gen count after a modify.
Jan 23 2018, 3:16 AM