In D15337#333205, @mmacy wrote:

@rstone do you think you might be able to share the work that you or Jeff did on the frontend to adaptively lower the minRTO if the pipe was full?

In D11560#326314, @kib wrote:

I do not see such code in mlx4_en_rx.c. Could you point it out, please ?

In D11560#326054, @kib wrote:

Well, from my reading, your patch and this patch are quite similar, but this review provides two interesting optimizations.

• Use page-size fragments if MTU >= PAGE_SIZE, already discussed on lists for mlx5.
• Keep around mbufs and memory for unused fragments, if the received packed was shorter than MTU.

If these changes are transplanted into your patch, I believe the things start look almost identical. I want to confirm my understanding with Ryan.

The message that I got at BSDCan last year is that they wanted to see at least a full IETF draft before these changes could be merged in, which is why my work on it stalled. Has people's position on this changed?

FWIW, I had a short email conversation with the writers of that draft about a year ago and they went radio silent pretty quickly. I assumed that they weren't working on it anymore.

In D14559#308712, @asomers wrote:

Where is route.subr? And where did ipv4_move_subnet_route come from? I think you used the wrong base revision to generate the review.

Move non-fib test into separate test file

I've written some unit tests that covering these cases here:

I don't think that this conversation is going to go anywhere productive. Do you have specific technical objection to raise about this change?

In D14547#306224, @eugen_grosbein.net wrote:

Care to elaborate what are you trying to achieve by moving subnet route between interfaces?

Uploaded the wrong test to this review; fixed now

Move route(8) tests to their own atf test file

In D14547#305453, @eugen_grosbein.net wrote:

In D14547#305425, @rstone wrote:

In any case, even if the use-case is weird, the current behaviour is clearly buggy and needs to be fixed in some way.

Well, I guess so. But original configuration may be supposed to be "buggy" too (read: not supported). What if you use /16 mask for single interface only and assign IP from the same prefix to other interfaces using /32 mask?

In D14547#305139, @eugen_grosbein.net wrote:

And you do you insist in doing things manually while moving IP (first route change, then reassign IP) instead of just allowing system do all housekeeping for you by reassigning IP first?

Add ATF test cases for IPv4/IPv6 subnet route migration

In D14547#305375, @asomers wrote:

The fibs must actually exist. Set net.fibs=6 in /boot/loader.conf and reboot. Also, are you sure you need so many? I don't think there are any tests there that require more than two.

In D14547#305342, @asomers wrote:

In tests/sys/netinet/fibs_test.sh there are some ATF tests that check this kind of functionality. They do it on separate FIBs so they won't upset the system running the tests, and they use tap(4) and/or epair(4) interfaces. You should be able to copy one of those to create a regression test for this problem.

Check for NULL pointers

In D14291#300646, @ae wrote:

How it supposed to work for RADIX_MPATH case? I know RADIX_MPATH is currently broken, but anyway...

Clarify manpage update as per rgrimes' suggestion

Fix the manpage to document that the gateway parameter is
optional for most route subcommands.

Add comment explaining generation increment

In D13988#293614, @karels wrote:

Could this use the new invalidate macro?

NULL-out rte after route cache is invalidated

In D13417#281628, @ae wrote:

It would be nice if you describe why this leak happens, i.e. where leaked reference was acquired.

In D11560#239289, @hselasky wrote:

Hi,
Don't pull the "old behaviour" into the driver. You should use a linked list of mbufs and load that instead of the mlx4_en_frag_info structure now we are using busdma!
There is a better way to implement this. Can Mellanox take over this issue?
--HPS

@kmacy I have not. We probably have an equivalent fix committed locally @ $WORK but it might be tied too closely to the high-precision timestamp work to easily extract.

In D10535#218388, @sbruno wrote:

Maybe you've seen something that requires this lock acquisition in your testing. Can you explain why we need to acquire this lock here?

Add the locking mentioned the description but omitted from the
actual revision.

I'm not sure what we want to do with this fix given the imminent iflib conversion, but at least this should go into stable branches.

Obsoleted by gleb's User/Kernel KPI fixes

In D9465#198397, @pkelsey wrote:

I realize the issue there is exposure of a type definition to userland, but a related question is - what exactly is the userland-ABI property we are trying to maintain here? Are we just trying to keep this struct the same size and layout under all kernel configuration option selections and feature evolutions for a given machine type? Or are we also trying to keep it the same size and layout across different machine types (or at the very least a single pair of relevant machine types)? For example, is the #ifdef_LP64 really necessary in the TCPPCAP section?

• fixup! Don't zero out srtt after excess retransmits