User Details
- User Since
- May 12 2014, 8:03 PM (542 w, 2 d)
Apr 4 2023
Apr 3 2023
Aug 16 2022
Mar 10 2022
Mar 7 2022
Mar 5 2022
Feb 25 2022
Feb 10 2022
This is the approach to exposing kernel declarations to userland that glebius@ requested I investigate. It has the advantage of being less invasive in kernel headers than the last attempt, and the meaning of the _KERNEL/_KERNEL_UT/_KERNEL_UT_KSRC macros is a lot clearer than in the last version. However I'm not thrilled with how this requires changes to how every header exposes syscalls. At the very least, this would require an exp-run before committing.
Feb 3 2022
glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.
glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.
glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.
glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.
glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.
glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.
glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.
glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.
glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.
glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.
Jan 26 2022
Jan 25 2022
Jan 13 2022
Jan 12 2022
Ping? I'd like to get this patch and the other LRO patch in by next week.
Ping? I'd like to get this off of my queue by some time next week.
Jan 6 2022
Nov 8 2021
Aug 31 2021
Aug 27 2021
Aug 7 2021
Please do not introduce new usages of mbuf clusters > PAGE_SIZE into
the network stack. When under memory pressure attempting to
allocating >PAGE_SIZE clusters will DoS the whole system if done at
the packet rates seen on modern networks.
Jun 4 2021
Jun 3 2021
May 12 2021
Apr 27 2021
I haven't been able to find a repro scenario for the leak outside of $WORK's repo, but by inspection this fix is obviously correct so I'm reopening this.
Mar 24 2021
I can confirm don't have any out-of-tree consumers of linuxkpi, so looks fine to me.
Feb 16 2021
Feb 14 2021
Feb 12 2021
Thanks for looking into this for me.
Feb 4 2021
Feb 3 2021
Feb 2 2021
Fix lock leak. Sorry, this review was based off of an
older version of my patch that didn't have that fixed.
I've confirmed that this is now in sync with what was
tested internally at $WORK
Feb 1 2021
Change the value of M_NORECLAIM to avoid the style issue
Fix overflap between new flag and count field
Jan 29 2021
Sorry about the delay in coming back to this; I've had to deal with a number of critical issues at work. I ported the patch that we tested internally to main and posted it to this review:
Jan 15 2021
sorry I got distracted by a different critical issue at work. Will be able to return to this next week
Jan 7 2021
This patch doesn't work. After the goto retry, nothing stops the cancelling thread from seeing state still in WORK_ST_CANCEL, and then the timer thread can come in and change it to TASK, causing the same bug.
I don't think that spinning is the right answer. That could hold the CPU that the callout needs to make progress, resulting in a livelock.
Dec 13 2020
Dec 9 2020
Removing the ability to create unnamed vlans is an unnecessary POLA violation. It can make sense for the user to establish a convention that vlanX is for vlan tag X, but we absolutely shouldn't bake that assumption into the kernel.
Nov 21 2020
Try putting entries in the witness_order_list_entry in kern/subr_witness.c specifying the ifnet_sx -> in_multi_sx ordering as correct. That should get better information. Likely the issue is a cycle of length larger than 2 (e.g. in_multi_sx before mystery lock, mystery lock before ifnet_sx, ifnet_sx before in_multi_sx).
Oct 20 2020
Aug 25 2020
Jul 3 2020
What's the status of this? We're hitting this problem very frequently at Isilon and this patch does fix the issue.