Page MenuHomeFreeBSD

rstone (Ryan Stone)
User

Projects

User Details

User Since
May 12 2014, 8:03 PM (418 w, 3 d)

Recent Activity

Mar 10 2022

rstone accepted D34450: vm_ksubmap_init: pass M_WAITOK to vmem_init -> uma_zalloc_arg.
Mar 10 2022, 8:39 PM
rstone accepted D34451: ksiginfo_alloc: pass M_WAITOK or M_NOWAIT to uma_zalloc.
Mar 10 2022, 8:38 PM
rstone accepted D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK.
Mar 10 2022, 8:38 PM
rstone accepted D34472: uma_zalloc_domain: call uma_zalloc_debug in multi-domain path.
Mar 10 2022, 8:37 PM

Mar 7 2022

rstone committed R10:617729314af3: Fix ifa refcount leak in ifa_ifwithnet() (authored by rstone).
Fix ifa refcount leak in ifa_ifwithnet()
Mar 7 2022, 5:46 PM
rstone accepted D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK.
Mar 7 2022, 2:39 PM

Mar 5 2022

rstone added inline comments to D34452: uma_zalloc: assert M_NOWAIT ^ M_WAITOK.
Mar 5 2022, 9:29 PM

Feb 25 2022

rstone committed R10:1708d1b88972: MFC b58cf1cb35ab: (authored by rstone).
MFC b58cf1cb35ab:
Feb 25 2022, 7:59 PM
rstone committed R10:bbce80f3efcb: MFC 2290dfb40fce: (authored by rstone).
MFC 2290dfb40fce:
Feb 25 2022, 7:56 PM
rstone committed R10:e88dbe4f4672: MFC 315bca194a14: (authored by rstone).
MFC 315bca194a14:
Feb 25 2022, 7:08 PM

Feb 10 2022

rstone updated subscribers of D34244: Make sys headers includable in kernel unit tests.

This is the approach to exposing kernel declarations to userland that glebius@ requested I investigate. It has the advantage of being less invasive in kernel headers than the last attempt, and the meaning of the _KERNEL/_KERNEL_UT/_KERNEL_UT_KSRC macros is a lot clearer than in the last version. However I'm not thrilled with how this requires changes to how every header exposes syscalls. At the very least, this would require an exp-run before committing.

Feb 10 2022, 8:57 PM
rstone requested review of D34244: Make sys headers includable in kernel unit tests.
Feb 10 2022, 8:51 PM

Feb 3 2022

rstone abandoned D34042: Expose <sys/sdt.h> kernel decls to sysunit tests.

glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.

Feb 3 2022, 8:55 PM
rstone abandoned D34041: Expose <sys/mbuf.h> kernel decls to sysunit tests.

glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.

Feb 3 2022, 8:55 PM
rstone abandoned D34040: Expose <sys/if_var.h> kernel decls to sysunit tests.

glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.

Feb 3 2022, 8:55 PM
rstone abandoned D34039: Expose sys/vnet.h kernel decls to sysunit tests.

glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.

Feb 3 2022, 8:55 PM
rstone abandoned D34038: Expose ip6?_var.h kernel decls to sysunit tests.

glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.

Feb 3 2022, 8:54 PM
rstone abandoned D34037: Expose <sys/malloc.h> kernel decls to sysunit tests.

glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.

Feb 3 2022, 8:54 PM
rstone abandoned D34036: Expose <sys/systm.h> kernel decls to sysunit tests.

glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.

Feb 3 2022, 8:54 PM
rstone abandoned D34035: Expose <sys/param.h> kernel decls to sysunit tests.

glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.

Feb 3 2022, 8:54 PM
rstone abandoned D34034: Expose <sys/pcpu.h> kernel decls to sysunit tests.

glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.

Feb 3 2022, 8:54 PM
rstone abandoned D34033: Expose <sys/types.h> kernel decls to sysunit tests.

glebius@ has requested a different approach where unit tests define _KERNEL and opt out of the KPI symbols that they don't want, rather than opting into the symbols that they do want.

Feb 3 2022, 8:54 PM

Jan 26 2022

rstone added a comment to D34034: Expose <sys/pcpu.h> kernel decls to sysunit tests.
In D34034#769620, @imp wrote:

A preference for positive logic here where the primary thing (_KERNEL) is also switched on makes it easier to understand, imho.

Jan 26 2022, 2:11 AM

Jan 25 2022

rstone requested review of D34042: Expose <sys/sdt.h> kernel decls to sysunit tests.
Jan 25 2022, 9:36 PM
rstone requested review of D34041: Expose <sys/mbuf.h> kernel decls to sysunit tests.
Jan 25 2022, 9:36 PM
rstone requested review of D34040: Expose <sys/if_var.h> kernel decls to sysunit tests.
Jan 25 2022, 9:36 PM
rstone requested review of D34039: Expose sys/vnet.h kernel decls to sysunit tests.
Jan 25 2022, 9:36 PM
rstone requested review of D34038: Expose ip6?_var.h kernel decls to sysunit tests.
Jan 25 2022, 9:36 PM
rstone requested review of D34037: Expose <sys/malloc.h> kernel decls to sysunit tests.
Jan 25 2022, 9:36 PM
rstone requested review of D34036: Expose <sys/systm.h> kernel decls to sysunit tests.
Jan 25 2022, 9:36 PM
rstone requested review of D34034: Expose <sys/pcpu.h> kernel decls to sysunit tests.
Jan 25 2022, 9:36 PM
rstone requested review of D34035: Expose <sys/param.h> kernel decls to sysunit tests.
Jan 25 2022, 9:36 PM
rstone requested review of D34033: Expose <sys/types.h> kernel decls to sysunit tests.
Jan 25 2022, 9:36 PM

Jan 13 2022

rstone closed D33775: LRO: Don't merge ACK and non-ACK packets together.
Jan 13 2022, 4:19 PM
rstone committed R10:3284f4925f69: LRO: Don't merge ACK and non-ACK packets together (authored by rstone).
LRO: Don't merge ACK and non-ACK packets together
Jan 13 2022, 4:19 PM
rstone closed D33774: LRO: Fix lost packets when merging 1 payload with an ACK.
Jan 13 2022, 4:19 PM
rstone committed R10:24fe6643dac0: LRO: Fix lost packets when merging 1 payload with an ACK (authored by rstone).
LRO: Fix lost packets when merging 1 payload with an ACK
Jan 13 2022, 4:19 PM

Jan 12 2022

rstone added a comment to D33774: LRO: Fix lost packets when merging 1 payload with an ACK.

Ping? I'd like to get this patch and the other LRO patch in by next week.

Jan 12 2022, 10:40 PM
rstone added a comment to D33775: LRO: Don't merge ACK and non-ACK packets together.

Ping? I'd like to get this off of my queue by some time next week.

Jan 12 2022, 10:39 PM

Jan 6 2022

rstone updated the test plan for D33775: LRO: Don't merge ACK and non-ACK packets together.
Jan 6 2022, 11:03 PM
rstone updated the test plan for D33774: LRO: Fix lost packets when merging 1 payload with an ACK.
Jan 6 2022, 11:00 PM
rstone updated the test plan for D33774: LRO: Fix lost packets when merging 1 payload with an ACK.
Jan 6 2022, 10:59 PM
rstone requested review of D33775: LRO: Don't merge ACK and non-ACK packets together.
Jan 6 2022, 10:55 PM
rstone requested review of D33774: LRO: Fix lost packets when merging 1 payload with an ACK.
Jan 6 2022, 10:55 PM
rstone closed D28705: Fix ifa refcount leak in ifa_ifwithnet().
Jan 6 2022, 8:49 PM
rstone committed R10:5adea417d494: Fix ifa refcount leak in ifa_ifwithnet() (authored by rstone).
Fix ifa refcount leak in ifa_ifwithnet()
Jan 6 2022, 8:49 PM

Nov 8 2021

rstone accepted D32839: pci: Implement pci_bar_enabled() for VFs.
Nov 8 2021, 2:11 PM

Aug 31 2021

rstone committed R10:315bca194a14: Fix an early return in ctld UCL parser (authored by rstone).
Fix an early return in ctld UCL parser
Aug 31 2021, 3:05 AM
rstone closed D31703: Fix an early return in ctld UCL parser.
Aug 31 2021, 3:04 AM

Aug 27 2021

rstone updated subscribers of D31703: Fix an early return in ctld UCL parser.
Aug 27 2021, 4:02 PM
rstone added a reviewer for D31703: Fix an early return in ctld UCL parser: araujo.
Aug 27 2021, 4:01 PM
rstone requested review of D31703: Fix an early return in ctld UCL parser.
Aug 27 2021, 3:58 PM

Aug 7 2021

rstone added a comment to D31455: Introduce m_get3().

Please do not introduce new usages of mbuf clusters > PAGE_SIZE into
the network stack. When under memory pressure attempting to
allocating >PAGE_SIZE clusters will DoS the whole system if done at
the packet rates seen on modern networks.

Aug 7 2021, 9:31 PM

Jun 4 2021

rstone committed R10:2290dfb40fce: Enter the net epoch before calling ip6_setpktopts (authored by rstone).
Enter the net epoch before calling ip6_setpktopts
Jun 4 2021, 5:18 PM
rstone closed D30630: Enter the net epoch before calling ip6_setpktopts.
Jun 4 2021, 5:18 PM

Jun 3 2021

rstone added a reviewer for D30630: Enter the net epoch before calling ip6_setpktopts: network.
Jun 3 2021, 7:18 PM
rstone requested review of D30630: Enter the net epoch before calling ip6_setpktopts.
Jun 3 2021, 7:15 PM

May 12 2021

rstone added inline comments to D28705: Fix ifa refcount leak in ifa_ifwithnet().
May 12 2021, 7:59 PM

Apr 27 2021

rstone reclaimed D28705: Fix ifa refcount leak in ifa_ifwithnet().

I haven't been able to find a repro scenario for the leak outside of $WORK's repo, but by inspection this fix is obviously correct so I'm reopening this.

Apr 27 2021, 8:00 PM

Mar 24 2021

rstone accepted D29391: LinuxKPI: remove < 5.0 version support.

I can confirm don't have any out-of-tree consumers of linuxkpi, so looks fine to me.

Mar 24 2021, 8:25 PM

Feb 16 2021

rstone accepted D28639: Add ifa_try_ref() to simplify ifa handling inside epoch..
Feb 16 2021, 7:55 PM
rstone abandoned D28705: Fix ifa refcount leak in ifa_ifwithnet().
Feb 16 2021, 4:26 PM
rstone added a reviewer for D28705: Fix ifa refcount leak in ifa_ifwithnet(): network.
Feb 16 2021, 4:21 PM
rstone requested review of D28705: Fix ifa refcount leak in ifa_ifwithnet().
Feb 16 2021, 4:20 PM

Feb 14 2021

rstone accepted D28649: Do not reference returned ifa in in6_ifawithifp()..
Feb 14 2021, 4:13 AM

Feb 12 2021

rstone accepted D28629: Fix ifa refcount leak during route addition..
Feb 12 2021, 9:42 PM
rstone accepted D28603: libdtrace: Don't try to unput a nul terminator.

Thanks for looking into this for me.

Feb 12 2021, 4:54 PM

Feb 4 2021

rstone committed R10:8a06ca2f734c: Fix mismerge in OFED update (authored by rstone).
Fix mismerge in OFED update
Feb 4 2021, 6:59 PM
rstone closed D28421: Fix mismerge in OFED update.
Feb 4 2021, 6:58 PM
rstone closed D28420: Fix race condition in linuxkpi workqueue.
Feb 4 2021, 6:56 PM
rstone committed R10:b58cf1cb35ab: Fix race condition in linuxkpi workqueue (authored by rstone).
Fix race condition in linuxkpi workqueue
Feb 4 2021, 6:56 PM

Feb 3 2021

rstone closed D28422: Add a VM flag to prevent reclaim on a failed contig allocation.
Feb 3 2021, 9:18 PM
rstone committed R10:660344ca44c6: Add a VM flag to prevent reclaim on a failed contig allocation (authored by rstone).
Add a VM flag to prevent reclaim on a failed contig allocation
Feb 3 2021, 9:18 PM

Feb 2 2021

rstone updated the diff for D28420: Fix race condition in linuxkpi workqueue.

Fix lock leak. Sorry, this review was based off of an
older version of my patch that didn't have that fixed.
I've confirmed that this is now in sync with what was
tested internally at $WORK

Feb 2 2021, 2:01 PM

Feb 1 2021

rstone updated the diff for D28422: Add a VM flag to prevent reclaim on a failed contig allocation.

Change the value of M_NORECLAIM to avoid the style issue

Feb 1 2021, 6:16 PM
rstone updated the diff for D28422: Add a VM flag to prevent reclaim on a failed contig allocation.

Fix overflap between new flag and count field

Feb 1 2021, 6:14 PM

Jan 29 2021

rstone added inline comments to D28422: Add a VM flag to prevent reclaim on a failed contig allocation.
Jan 29 2021, 11:57 PM
rstone requested review of D28422: Add a VM flag to prevent reclaim on a failed contig allocation.
Jan 29 2021, 9:18 PM
rstone requested review of D28421: Fix mismerge in OFED update.
Jan 29 2021, 8:52 PM
rstone added a comment to D28017: Fix race in cancel_delayed_work() in the LinuxKPI.

Sorry about the delay in coming back to this; I've had to deal with a number of critical issues at work. I ported the patch that we tested internally to main and posted it to this review:

Jan 29 2021, 8:36 PM
rstone requested review of D28420: Fix race condition in linuxkpi workqueue.
Jan 29 2021, 8:32 PM

Jan 15 2021

rstone added a comment to D28017: Fix race in cancel_delayed_work() in the LinuxKPI.

sorry I got distracted by a different critical issue at work. Will be able to return to this next week

Jan 15 2021, 9:58 PM

Jan 7 2021

rstone added inline comments to D28017: Fix race in cancel_delayed_work() in the LinuxKPI.
Jan 7 2021, 4:44 PM
rstone requested changes to D28017: Fix race in cancel_delayed_work() in the LinuxKPI.

This patch doesn't work. After the goto retry, nothing stops the cancelling thread from seeing state still in WORK_ST_CANCEL, and then the timer thread can come in and change it to TASK, causing the same bug.

Jan 7 2021, 4:03 PM
rstone added a comment to D28017: Fix race in cancel_delayed_work() in the LinuxKPI.

I don't think that spinning is the right answer. That could hold the CPU that the callout needs to make progress, resulting in a livelock.

Jan 7 2021, 2:51 PM

Dec 13 2020

rstone committed R9:df279f34273b: add metadata and pgp key for new committer rstone@ (authored by rstone).
add metadata and pgp key for new committer rstone@
Dec 13 2020, 5:33 PM
rstone committed R9:8d05a4dbea5b: add new committer metadata and news entry for new committer rstone (authored by rstone).
add new committer metadata and news entry for new committer rstone
Dec 13 2020, 5:33 PM

Dec 9 2020

rstone requested changes to D27505: Fix subinterface vlan creation..

Removing the ability to create unnamed vlans is an unnecessary POLA violation. It can make sense for the user to establish a convention that vlanX is for vlan tag X, but we absolutely shouldn't bake that assumption into the kernel.

Dec 9 2020, 5:53 PM

Nov 21 2020

rstone added a comment to D27279: if: Protect V_ifnet in vnet_if_return().

Try putting entries in the witness_order_list_entry in kern/subr_witness.c specifying the ifnet_sx -> in_multi_sx ordering as correct. That should get better information. Likely the issue is a cycle of length larger than 2 (e.g. in_multi_sx before mystery lock, mystery lock before ifnet_sx, ifnet_sx before in_multi_sx).

Nov 21 2020, 6:53 PM

Oct 20 2020

rstone added a comment to D26879: Add ipfw SDT probe..

That shouldn't be true. Did you test that recently? I'm not sure if it'll work for standalone module builds since KDTRACE_HOOKS might not be defined.

Oct 20 2020, 7:38 PM

Aug 25 2020

rstone added a comment to D25085: netinet6: In tcp_lro_rx_ipv6(), check for IPv6 flow ID..
In D25085#560681, @lutz_donnerhacke.de wrote:

In my eyes, throwing away packets which successfully reached the destination for potential QoS/routing issues, is unexpected.

Aug 25 2020, 2:53 PM · network

Jul 3 2020

rstone added a comment to D23973: Infiniband clients must be attached and detached in a specific order.

What's the status of this? We're hitting this problem very frequently at Isilon and this patch does fix the issue.

Jul 3 2020, 2:29 PM

Jun 20 2020

rstone accepted D25364: oce(4): Account and trace mbufs before handing to hw.
Jun 20 2020, 5:04 PM

Jun 18 2020

rstone added a reviewer for D25325: Fix panic induced by ndp -P: network.
Jun 18 2020, 9:18 AM
rstone requested review of D25325: Fix panic induced by ndp -P.
Jun 18 2020, 9:18 AM

May 25 2020

rstone added a comment to D24902: Time to First byte in and out.
In D24902#550400, @rrs wrote:

Has discussed on the transport call, I will be updating these to have a uint64_t and a nano-second basis for the values (including t_starttime I think since this
is what you compare these against) :)

May 25 2020, 2:45 PM

Jan 24 2020

rstone added a member for network: rstone.
Jan 24 2020, 2:54 PM

Jan 20 2020

rstone added a comment to D7821: Preserve ECN bits when merging frames in LRO.
In D7821#510126, @rscheff_gmx.at wrote:

Is this still alive? As ECN has become more interesting recently, something like this is probably needed for RFC3168 ECN flows.

Also, forgive my ignorance, but can the LRO code add some side-band information to the upstream - e.g. number of packets coalesced, or number of CE marks observed? This would be very relevant in context of Accurate ECN. Where for RFC3168 it is sufficience that any segment marked as CE to appear in the final header, for AccECN the actual number of the CE marks, and also the number of coalesced packets would be relevant, to arrive at an appropriate alpha (reduction) value.

By just moving any number of CE marks to a single, the AccECN CC reaction would be more strong, shedding more bandwidth than appropriate...

Jan 20 2020, 4:39 PM

Jan 10 2020

rstone accepted D23121: Stop prepending prefix to the result of realpath(3)..
Jan 10 2020, 4:35 PM
rstone added inline comments to D23121: Stop prepending prefix to the result of realpath(3)..
Jan 10 2020, 2:26 PM