Differential D28649

Do not reference returned ifa in in6_ifawithifp().
ClosedPublic
Actions

Authored by melifaro on Sat, Feb 13, 3:59 PM.

Details

Reviewers

rstone

Group Reviewers

network

Commits

R10:1bd44b11e59f: Do not reference returned ifa in in6_ifawithifp().

Summary

The only place where in6_ifawithifp() is used is ip6_output(), which uses the returned ifa to bump traffic counters.
Given ifa stability guarantees is provided by epoch, do not refcount ifa.

Diff Detail

Repository

R10 FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

melifaro created this revision.Sat, Feb 13, 3:59 PM

Herald added subscribers: bz, ae, imp. · View Herald TranscriptSat, Feb 13, 3:59 PM

melifaro requested review of this revision.Sat, Feb 13, 3:59 PM

melifaro edited the summary of this revision. (Show Details)Sat, Feb 13, 4:00 PM

melifaro added a reviewer: network.

Harbormaster completed remote builds in B36970: Diff 83834.Sat, Feb 13, 4:00 PM

rstone accepted this revision.Sun, Feb 14, 4:13 AM

This revision is now accepted and ready to land.Sun, Feb 14, 4:13 AM

Closed by commit R10:1bd44b11e59f: Do not reference returned ifa in in6_ifawithifp(). (authored by melifaro). · Explain WhySun, Feb 14, 10:13 AM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: R10:1bd44b11e59f: Do not reference returned ifa in in6_ifawithifp()..

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

in6.c

14 lines

ip6_output.c

1 line

Diff 83866

View Options

sys/netinet6/in6.c