Page MenuHomeFreeBSD
Feed Advanced Search

Jan 24 2020

rstone added a member for network: rstone.
Jan 24 2020, 2:54 PM

Jan 20 2020

rstone added a comment to D7821: Preserve ECN bits when merging frames in LRO.

Is this still alive? As ECN has become more interesting recently, something like this is probably needed for RFC3168 ECN flows.
Also, forgive my ignorance, but can the LRO code add some side-band information to the upstream - e.g. number of packets coalesced, or number of CE marks observed? This would be very relevant in context of Accurate ECN. Where for RFC3168 it is sufficience that any segment marked as CE to appear in the final header, for AccECN the actual number of the CE marks, and also the number of coalesced packets would be relevant, to arrive at an appropriate alpha (reduction) value.
By just moving any number of CE marks to a single, the AccECN CC reaction would be more strong, shedding more bandwidth than appropriate...

Jan 20 2020, 4:39 PM

Jan 10 2020

rstone accepted D23121: Stop prepending prefix to the result of realpath(3)..
Jan 10 2020, 4:35 PM
rstone added inline comments to D23121: Stop prepending prefix to the result of realpath(3)..
Jan 10 2020, 2:26 PM

Jan 9 2020

rstone added inline comments to D23014: Resolve relative argv0 for direct exec mode to absolute path for AT_EXECPATH..
Jan 9 2020, 7:09 PM

Jan 7 2020

rstone closed D23008: rtld: Fix segfault in direct exec mode.
Jan 7 2020, 4:03 PM
rstone committed rS356444: rtld: Fix segfault in direct exec mode.
rtld: Fix segfault in direct exec mode
Jan 7 2020, 4:03 PM

Jan 2 2020

rstone accepted D22894: Fix AT_EXECPATH for direct exec mode..
Jan 2 2020, 5:14 PM
rstone created D23008: rtld: Fix segfault in direct exec mode.
Jan 2 2020, 4:08 PM

Dec 21 2019

rstone added inline comments to D22894: Fix AT_EXECPATH for direct exec mode..
Dec 21 2019, 2:57 AM

Dec 3 2019

rstone planned changes to D22198: nd6: Reject routers on a prefix about to be freed.
Dec 3 2019, 8:02 PM

Nov 26 2019

rstone added inline comments to D22198: nd6: Reject routers on a prefix about to be freed.
Nov 26 2019, 8:22 PM
rstone added a comment to D22198: nd6: Reject routers on a prefix about to be freed.

Do you happen to have a test case for this? We don't have any ND6 regression tests at the moment. :(

Nov 26 2019, 8:21 PM

Oct 30 2019

rstone created D22198: nd6: Reject routers on a prefix about to be freed.
Oct 30 2019, 7:14 PM

Oct 23 2019

rstone closed D22127: Add missing M_NOWAIT flag.
Oct 23 2019, 5:20 PM
rstone committed rS353938: Add missing M_NOWAIT flag.
Add missing M_NOWAIT flag
Oct 23 2019, 5:20 PM
rstone added a reviewer for D22127: Add missing M_NOWAIT flag: hselasky.
Oct 23 2019, 4:24 PM
rstone created D22127: Add missing M_NOWAIT flag.
Oct 23 2019, 4:21 PM

Oct 8 2019

rstone added a comment to D21944: pci_iov: Stop preventing VFs from allocating extra bus numbers.

I suspect that means that your BIOS pre-allocated enough bus numbers to the bridge to account for the VFs. Perhaps we should add a pcib method that recursively checks that a contiguous range of bus numbers is assigned to the bridge?

Oct 8 2019, 6:49 PM

Oct 1 2019

rstone committed rS352926: Clean up duplicate entries in sys/conf/files.
Clean up duplicate entries in sys/conf/files
Oct 1 2019, 1:36 PM

Aug 27 2019

D21209: Wrap a vlan's parent's if_output in a separate function. is now accepted and ready to land.
Aug 27 2019, 8:54 PM

Oct 4 2018

rstone committed rS339185: Hold a write lock across udp_notify().
Hold a write lock across udp_notify()
Oct 4 2018, 10:04 PM
rstone closed D17246: Hold a write lock across udp_notify().
Oct 4 2018, 10:04 PM

Sep 19 2018

rstone created D17246: Hold a write lock across udp_notify().
Sep 19 2018, 5:08 PM

Jun 12 2018

rstone added a comment to D15337: Add support for higher resolution timestamps.

@rstone do you think you might be able to share the work that you or Jeff did on the frontend to adaptively lower the minRTO if the pipe was full?

Jun 12 2018, 7:23 PM

May 17 2018

rstone added a comment to D11560: Remove use of 9k clusters from mlx4_en rx path.
In D11560#326314, @kib wrote:

I do not see such code in mlx4_en_rx.c. Could you point it out, please ?

May 17 2018, 3:44 PM

May 16 2018

rstone added a comment to D11560: Remove use of 9k clusters from mlx4_en rx path.
In D11560#326054, @kib wrote:

Well, from my reading, your patch and this patch are quite similar, but this review provides two interesting optimizations.

  • Use page-size fragments if MTU >= PAGE_SIZE, already discussed on lists for mlx5.
  • Keep around mbufs and memory for unused fragments, if the received packed was shorter than MTU.

If these changes are transplanted into your patch, I believe the things start look almost identical. I want to confirm my understanding with Ryan.

May 16 2018, 5:04 PM

May 7 2018

rstone added a comment to D15337: Add support for higher resolution timestamps.

The message that I got at BSDCan last year is that they wanted to see at least a full IETF draft before these changes could be merged in, which is why my work on it stalled. Has people's position on this changed?

May 7 2018, 8:16 PM
rstone added a comment to D15337: Add support for higher resolution timestamps.

FWIW, I had a short email conversation with the writers of that draft about a year ago and they went radio silent pretty quickly. I assumed that they weren't working on it anymore.

May 7 2018, 8:06 PM

Mar 19 2018

rstone accepted D14764: Fix initialization of eventhandler mutex..
Mar 19 2018, 10:28 PM

Mar 14 2018

rstone added a comment to D14559: Add test for regression fixed in r329743.

Where is route.subr? And where did ipv4_move_subnet_route come from? I think you used the wrong base revision to generate the review.

Mar 14 2018, 8:14 PM
rstone updated the diff for D14559: Add test for regression fixed in r329743.

Move non-fib test into separate test file

Mar 14 2018, 7:03 PM

Mar 8 2018

rstone added inline comments to D14540: Several LRO fixes.
Mar 8 2018, 4:28 PM · transport
rstone accepted D14540: Several LRO fixes.
Mar 8 2018, 2:34 PM · transport

Mar 7 2018

rstone accepted D14540: Several LRO fixes.

I've written some unit tests that covering these cases here:

Mar 7 2018, 10:32 PM · transport

Mar 5 2018

rstone added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

I don't think that this conversation is going to go anywhere productive. Do you have specific technical objection to raise about this change?

Mar 5 2018, 6:02 PM
rstone added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

Care to elaborate what are you trying to achieve by moving subnet route between interfaces?

Mar 5 2018, 5:43 PM
rstone updated the diff for D14547: Allow IPv4 subnet routes to move to a different ifa.

Uploaded the wrong test to this review; fixed now

Mar 5 2018, 5:32 PM
rstone updated the diff for D14547: Allow IPv4 subnet routes to move to a different ifa.

Move route(8) tests to their own atf test file

Mar 5 2018, 5:21 PM
rstone added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

In any case, even if the use-case is weird, the current behaviour is clearly buggy and needs to be fixed in some way.

Well, I guess so. But original configuration may be supposed to be "buggy" too (read: not supported). What if you use /16 mask for single interface only and assign IP from the same prefix to other interfaces using /32 mask?

Mar 5 2018, 4:57 PM

Mar 1 2018

rstone created D14559: Add test for regression fixed in r329743.
Mar 1 2018, 9:37 PM
rstone added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

And you do you insist in doing things manually while moving IP (first route change, then reassign IP) instead of just allowing system do all housekeeping for you by reassigning IP first?

Mar 1 2018, 8:54 PM
rstone updated the diff for D14547: Allow IPv4 subnet routes to move to a different ifa.

Add ATF test cases for IPv4/IPv6 subnet route migration

Mar 1 2018, 8:51 PM
rstone updated the test plan for D14547: Allow IPv4 subnet routes to move to a different ifa.
Mar 1 2018, 8:50 PM
rstone added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

The fibs must actually exist. Set net.fibs=6 in /boot/loader.conf and reboot. Also, are you sure you need so many? I don't think there are any tests there that require more than two.

Mar 1 2018, 7:01 PM
rstone added a comment to D14547: Allow IPv4 subnet routes to move to a different ifa.

In tests/sys/netinet/fibs_test.sh there are some ATF tests that check this kind of functionality. They do it on separate FIBs so they won't upset the system running the tests, and they use tap(4) and/or epair(4) interfaces. You should be able to copy one of those to create a regression test for this problem.

Mar 1 2018, 6:46 PM

Feb 28 2018

rstone updated the diff for D14547: Allow IPv4 subnet routes to move to a different ifa.

Check for NULL pointers

Feb 28 2018, 7:48 PM
rstone updated the test plan for D14547: Allow IPv4 subnet routes to move to a different ifa.
Feb 28 2018, 7:03 PM
rstone created D14547: Allow IPv4 subnet routes to move to a different ifa.
Feb 28 2018, 6:56 PM

Feb 21 2018

rstone committed rS329744: Fix route manpage to show correct flush syntax.
Fix route manpage to show correct flush syntax
Feb 21 2018, 7:14 PM
rstone closed D14401: Fix route manpage to show correct flush syntax.
Feb 21 2018, 7:14 PM
rstone committed rS329743: Allow route change requests to not specify the gateway..
Allow route change requests to not specify the gateway.
Feb 21 2018, 7:13 PM
rstone closed D14291: Allow route change requests to not specify the gateway..
Feb 21 2018, 7:13 PM

Feb 16 2018

rstone added a comment to D14291: Allow route change requests to not specify the gateway..
In D14291#300646, @ae wrote:

How it supposed to work for RADIX_MPATH case? I know RADIX_MPATH is currently broken, but anyway...

Feb 16 2018, 7:59 PM
rstone added inline comments to D14291: Allow route change requests to not specify the gateway..
Feb 16 2018, 7:53 PM
rstone added inline comments to D14291: Allow route change requests to not specify the gateway..
Feb 16 2018, 6:34 PM
rstone updated the diff for D14291: Allow route change requests to not specify the gateway..

Clarify manpage update as per rgrimes' suggestion

Feb 16 2018, 6:32 PM
rstone added a reviewer for D14401: Fix route manpage to show correct flush syntax: manpages.
Feb 16 2018, 6:14 PM
rstone created D14401: Fix route manpage to show correct flush syntax.
Feb 16 2018, 6:13 PM
rstone updated the diff for D14291: Allow route change requests to not specify the gateway..

Fix the manpage to document that the gateway parameter is
optional for most route subcommands.

Feb 16 2018, 4:42 PM

Feb 10 2018

rstone created D14291: Allow route change requests to not specify the gateway..
Feb 10 2018, 1:52 AM

Jan 29 2018

rstone accepted D14120: Remove duplicate entries from various conf/files*.
Jan 29 2018, 5:27 PM

Jan 23 2018

rstone closed D13990: Increment the route table gen count after a modify.
Jan 23 2018, 3:16 AM
rstone committed rS328272: Increment the route table gen count after a modify.
Increment the route table gen count after a modify
Jan 23 2018, 3:16 AM
rstone committed rS328271: Reduce code duplication for inpcb route caching.
Reduce code duplication for inpcb route caching
Jan 23 2018, 3:16 AM
rstone closed D13989: Reduce code duplication for inpcb route caching.
Jan 23 2018, 3:16 AM
rstone closed D13988: Invalidate inpcb LLE cache if cached route is invalidated.
Jan 23 2018, 3:16 AM
rstone committed rS328270: Invalidate inpcb LLE cache if cached route is invalidated.
Invalidate inpcb LLE cache if cached route is invalidated
Jan 23 2018, 3:16 AM

Jan 22 2018

rstone updated the diff for D13990: Increment the route table gen count after a modify.

Add comment explaining generation increment

Jan 22 2018, 4:17 PM
rstone added a comment to D13988: Invalidate inpcb LLE cache if cached route is invalidated.

Could this use the new invalidate macro?

Jan 22 2018, 1:59 AM

Jan 19 2018

rstone updated the diff for D13989: Reduce code duplication for inpcb route caching.

NULL-out rte after route cache is invalidated

Jan 19 2018, 11:36 PM
rstone created D13990: Increment the route table gen count after a modify.
Jan 19 2018, 9:40 PM
rstone created D13989: Reduce code duplication for inpcb route caching.
Jan 19 2018, 9:40 PM
rstone created D13988: Invalidate inpcb LLE cache if cached route is invalidated.
Jan 19 2018, 9:40 PM

Dec 14 2017

rstone committed rS326860: Plug an ifaddr leak when changing a route's src.
Plug an ifaddr leak when changing a route's src
Dec 14 2017, 8:49 PM
rstone closed D13417: Plug an ifaddr leak when changing a route's src.
Dec 14 2017, 8:49 PM

Dec 13 2017

rstone added a comment to D13417: Plug an ifaddr leak when changing a route's src.
In D13417#281628, @ae wrote:

It would be nice if you describe why this leak happens, i.e. where leaked reference was acquired.

Dec 13 2017, 4:01 PM

Dec 7 2017

rstone updated the test plan for D13417: Plug an ifaddr leak when changing a route's src.
Dec 7 2017, 9:54 PM
rstone created D13417: Plug an ifaddr leak when changing a route's src.
Dec 7 2017, 9:50 PM

Nov 17 2017

rstone added inline comments to D12101: swfw_sync DELAY -> sleep conversion.
Nov 17 2017, 2:37 PM · network

Oct 24 2017

rstone created D12772: Prevent bge_init and bge_rxeof from running in parallel.
Oct 24 2017, 3:53 AM

Oct 23 2017

rstone accepted D12749: Move clear_unrhdr to tmpfs_free_tmp..
Oct 23 2017, 3:14 PM

Oct 16 2017

rstone accepted D12662: Properly reset fields in clean_unrhdr..
Oct 16 2017, 3:40 PM

Oct 11 2017

rstone accepted D12591: Add clearing function for unr(9), call it from tmpfs..
Oct 11 2017, 9:23 PM

Sep 22 2017

rstone accepted D12468: ddb(4): Add 'show badstacks' command to show witness badstacks.
Sep 22 2017, 7:43 PM

Sep 12 2017

rstone accepted D12191: Allow vlan interfaces to rx through netmap(4).
Sep 12 2017, 11:57 PM
rstone committed rS323506: Fix incorrect error message in iovctl.
Fix incorrect error message in iovctl
Sep 12 2017, 9:12 PM

Aug 15 2017

rstone accepted D11370: Rework vlan(4) locking..
Aug 15 2017, 5:05 PM

Aug 4 2017

rstone accepted D11777: Selectively print "hwaddr" from ifconfig(8)..
Aug 4 2017, 8:51 PM

Aug 2 2017

rstone committed rS321939: Add my birthdate to the calendar.
Add my birthdate to the calendar
Aug 2 2017, 7:45 PM

Jul 31 2017

rstone accepted D11797: Add myself to the calendar..
Jul 31 2017, 5:28 PM

Jul 20 2017

rstone accepted D11670: Add myself (mjoras) as a new src committer.
Jul 20 2017, 6:03 PM
rstone committed rS321300: Welcome Matt Joras (mjoras@) as a new src committer. Matt has been doing.
Welcome Matt Joras (mjoras@) as a new src committer. Matt has been doing
Jul 20 2017, 6:02 PM
rstone accepted D11672: Add myself and mentor line to committers-src.dot..
Jul 20 2017, 6:02 PM
rstone committed rD50525: Update my GPG key.
Update my GPG key
Jul 20 2017, 1:30 AM

Jul 13 2017

rstone accepted D11573: Fix kldload of if_ixl without PCI_IOV kernel option..
Jul 13 2017, 7:28 PM

Jul 12 2017

rstone added a comment to D11560: Remove use of 9k clusters from mlx4_en rx path.

Hi,
Don't pull the "old behaviour" into the driver. You should use a linked list of mbufs and load that instead of the mlx4_en_frag_info structure now we are using busdma!
There is a better way to implement this. Can Mellanox take over this issue?
--HPS

Jul 12 2017, 4:22 PM

Jul 11 2017

rstone created D11560: Remove use of 9k clusters from mlx4_en rx path.
Jul 11 2017, 10:59 PM

Jun 27 2017

rstone added inline comments to D11370: Rework vlan(4) locking..
Jun 27 2017, 8:09 PM
rstone added inline comments to D11370: Rework vlan(4) locking..
Jun 27 2017, 5:35 PM