Fri, Jun 4
Thu, Jun 3
May 12 2021
Apr 27 2021
I haven't been able to find a repro scenario for the leak outside of $WORK's repo, but by inspection this fix is obviously correct so I'm reopening this.
Mar 24 2021
I can confirm don't have any out-of-tree consumers of linuxkpi, so looks fine to me.
Feb 16 2021
Feb 14 2021
Feb 12 2021
Thanks for looking into this for me.
Feb 4 2021
Feb 3 2021
Feb 2 2021
Fix lock leak. Sorry, this review was based off of an
older version of my patch that didn't have that fixed.
I've confirmed that this is now in sync with what was
tested internally at $WORK
Feb 1 2021
Change the value of M_NORECLAIM to avoid the style issue
Fix overflap between new flag and count field
Jan 29 2021
Sorry about the delay in coming back to this; I've had to deal with a number of critical issues at work. I ported the patch that we tested internally to main and posted it to this review:
Jan 15 2021
sorry I got distracted by a different critical issue at work. Will be able to return to this next week
Jan 7 2021
This patch doesn't work. After the goto retry, nothing stops the cancelling thread from seeing state still in WORK_ST_CANCEL, and then the timer thread can come in and change it to TASK, causing the same bug.
I don't think that spinning is the right answer. That could hold the CPU that the callout needs to make progress, resulting in a livelock.
Dec 13 2020
Dec 9 2020
Removing the ability to create unnamed vlans is an unnecessary POLA violation. It can make sense for the user to establish a convention that vlanX is for vlan tag X, but we absolutely shouldn't bake that assumption into the kernel.
Nov 21 2020
Try putting entries in the witness_order_list_entry in kern/subr_witness.c specifying the ifnet_sx -> in_multi_sx ordering as correct. That should get better information. Likely the issue is a cycle of length larger than 2 (e.g. in_multi_sx before mystery lock, mystery lock before ifnet_sx, ifnet_sx before in_multi_sx).
Oct 20 2020
That shouldn't be true. Did you test that recently? I'm not sure if it'll work for standalone module builds since KDTRACE_HOOKS might not be defined.
Aug 25 2020
In D25085#560681, @lutz_donnerhacke.de wrote:
In my eyes, throwing away packets which successfully reached the destination for potential QoS/routing issues, is unexpected.
Jul 3 2020
What's the status of this? We're hitting this problem very frequently at Isilon and this patch does fix the issue.
Jun 20 2020
Jun 18 2020
May 25 2020
Has discussed on the transport call, I will be updating these to have a uint64_t and a nano-second basis for the values (including t_starttime I think since this
is what you compare these against) :)
Jan 24 2020
Jan 20 2020
In D7821#510126, @rscheff_gmx.at wrote:
Is this still alive? As ECN has become more interesting recently, something like this is probably needed for RFC3168 ECN flows.
Also, forgive my ignorance, but can the LRO code add some side-band information to the upstream - e.g. number of packets coalesced, or number of CE marks observed? This would be very relevant in context of Accurate ECN. Where for RFC3168 it is sufficience that any segment marked as CE to appear in the final header, for AccECN the actual number of the CE marks, and also the number of coalesced packets would be relevant, to arrive at an appropriate alpha (reduction) value.
By just moving any number of CE marks to a single, the AccECN CC reaction would be more strong, shedding more bandwidth than appropriate...
Jan 10 2020
Jan 9 2020
Jan 7 2020
Jan 2 2020
Dec 21 2019
Dec 3 2019
Nov 26 2019
Do you happen to have a test case for this? We don't have any ND6 regression tests at the moment. :(
Oct 30 2019
Oct 23 2019
Oct 8 2019
I suspect that means that your BIOS pre-allocated enough bus numbers to the bridge to account for the VFs. Perhaps we should add a pcib method that recursively checks that a contiguous range of bus numbers is assigned to the bridge?
Oct 1 2019
Aug 27 2019
Oct 4 2018
Sep 19 2018
Jun 12 2018
@rstone do you think you might be able to share the work that you or Jeff did on the frontend to adaptively lower the minRTO if the pipe was full?
May 17 2018
I do not see such code in mlx4_en_rx.c. Could you point it out, please ?
May 16 2018
Well, from my reading, your patch and this patch are quite similar, but this review provides two interesting optimizations.
- Use page-size fragments if MTU >= PAGE_SIZE, already discussed on lists for mlx5.
- Keep around mbufs and memory for unused fragments, if the received packed was shorter than MTU.
If these changes are transplanted into your patch, I believe the things start look almost identical. I want to confirm my understanding with Ryan.
May 7 2018
The message that I got at BSDCan last year is that they wanted to see at least a full IETF draft before these changes could be merged in, which is why my work on it stalled. Has people's position on this changed?
FWIW, I had a short email conversation with the writers of that draft about a year ago and they went radio silent pretty quickly. I assumed that they weren't working on it anymore.
Mar 19 2018
Mar 14 2018
Where is route.subr? And where did ipv4_move_subnet_route come from? I think you used the wrong base revision to generate the review.
Move non-fib test into separate test file
Mar 8 2018
Mar 7 2018
I've written some unit tests that covering these cases here:
Mar 5 2018
I don't think that this conversation is going to go anywhere productive. Do you have specific technical objection to raise about this change?
Care to elaborate what are you trying to achieve by moving subnet route between interfaces?
Uploaded the wrong test to this review; fixed now
Move route(8) tests to their own atf test file
In any case, even if the use-case is weird, the current behaviour is clearly buggy and needs to be fixed in some way.
Well, I guess so. But original configuration may be supposed to be "buggy" too (read: not supported). What if you use /16 mask for single interface only and assign IP from the same prefix to other interfaces using /32 mask?
Mar 1 2018
And you do you insist in doing things manually while moving IP (first route change, then reassign IP) instead of just allowing system do all housekeeping for you by reassigning IP first?
Add ATF test cases for IPv4/IPv6 subnet route migration
The fibs must actually exist. Set net.fibs=6 in /boot/loader.conf and reboot. Also, are you sure you need so many? I don't think there are any tests there that require more than two.
In tests/sys/netinet/fibs_test.sh there are some ATF tests that check this kind of functionality. They do it on separate FIBs so they won't upset the system running the tests, and they use tap(4) and/or epair(4) interfaces. You should be able to copy one of those to create a regression test for this problem.
Feb 28 2018
Check for NULL pointers
Feb 21 2018
Feb 16 2018
How it supposed to work for RADIX_MPATH case? I know RADIX_MPATH is currently broken, but anyway...
Clarify manpage update as per rgrimes' suggestion