- User Since
- May 10 2014, 4:51 AM (342 w, 18 h)
Aug 14 2020
Aug 13 2020
Aug 12 2020
The configuration file is not intuitive at all, how I will know what pci slot my virtio-blk shall live?
Why not simplify it instead of complicate more? The configuration file supposed to be something to simplify the command line, and instead is getting more complex than bhyve cli itself. Perhaps we will need another io<something> wrapper to simplify the creation of bhyve configuration files.
May 4 2020
May 3 2020
Nice to see you back Hope all is good with you
Feb 7 2020
LGTM, add the Approved by as usual.
Feb 6 2020
Approve by: araujo
OK, as soon as the poudriere get the results, share it here.
Did you test it using poudriere?
Feb 5 2020
How are you testing these changes that you didn't catch this problem before?
Feb 3 2020
Ops my bad :)
If you will remove the port, why botter to update it and trigger hooks around to rebuild the package?
@bcran You can commit it, you have my approval. Just add:
Jan 20 2020
Have you ever take a look at: https://github.com/xcllnt/libvdsk
It seemed to me a better idea than what are you trying to achieve here, and there, there is an experimental implementation of qcow2.
Jan 17 2020
Jan 3 2020
Dec 20 2019
Dec 19 2019
Dec 17 2019
Dec 16 2019
@jhb Does that make more sense?
- move the implementation to libvmmapi.
Dec 2 2019
Committed at: https://svnweb.freebsd.org/changeset/ports/518840
LGTM, gimme couple hours and I will commit it.
Nov 19 2019
Nov 8 2019
@samm Can you move forward with this patch? The maintainer has timeout already.
Oct 30 2019
Oct 25 2019
So please, proceed to merge these two reviews and incorporate the submitter suggestions.
Oct 23 2019
Can we abandon this review in favor of the another one?
Oct 22 2019
LGTM, I will commit soon!!!
Oct 21 2019
Oct 19 2019
Oct 18 2019
Oct 17 2019
You should bump PORTREVISION to force package rebuild.
Oct 16 2019
For record only, accepting it from Fukushima, Japan!
Why bump PORTREVISION?
You don't need the gratuitous PORTREVISION bump here!
Oct 15 2019
Forgot to commit? Is there anything left to be reviewed?
Oct 14 2019
Do you use poudriere?
Oct 12 2019
You have two "right" options, choose wisely :)
Two separate commits makes it easier to write the history log and in case you need one day to make a revert, it will be more easier to identify the reason. But it is not mandatory, but it is what I have been doing since 2007.
Oct 11 2019
Sorry, I should have accepted it!!! But please wait for krion to approve it.
Thanks for that! You did right already!
Oct 10 2019
I came here from D21838 to say: looks good too!!! :)
Lgtm, thank you!
Oct 9 2019
You need to connect the new port on security/Makefile, seems it is missing from this diff.
It is a bit of nit picky from my side, but I don't see a reason for those changes, actually before was better, the files were in alphabetic order.
Did I miss something?