Page MenuHomeFreeBSD

araujo (Marcelo Araujo)
User

Projects

User Details

User Since
May 10 2014, 4:51 AM (283 w, 1 d)

Recent Activity

Yesterday

araujo added a comment to D22000: security/botan2: Update to 2.12.0.

You have two "right" options, choose wisely :)

Sat, Oct 12, 11:58 PM
araujo added a comment to D22000: security/botan2: Update to 2.12.0.

Two separate commits makes it easier to write the history log and in case you need one day to make a revert, it will be more easier to identify the reason. But it is not mandatory, but it is what I have been doing since 2007.

Sat, Oct 12, 11:01 PM
araujo accepted D21981: databases/pspg: Update to 2.1.7.
Sat, Oct 12, 12:44 PM
araujo accepted D21991: www/gitea: Update to 1.9.4.
Sat, Oct 12, 12:30 PM
araujo accepted D21985: Add samm to committers-ports.dot and calendar.freebsd.
Sat, Oct 12, 9:48 AM
araujo accepted D21986: Add samm to freebsd.commiters.markers.
Sat, Oct 12, 9:47 AM

Fri, Oct 11

araujo added inline comments to D21985: Add samm to committers-ports.dot and calendar.freebsd.
Fri, Oct 11, 10:48 PM
araujo accepted D21977: Add samm as a ports committer.

Sorry, I should have accepted it!!! But please wait for krion to approve it.

Fri, Oct 11, 8:20 AM
araujo requested changes to D21977: Add samm as a ports committer.

Thanks for that! You did right already!

Fri, Oct 11, 8:19 AM

Thu, Oct 10

araujo added a comment to D21837: bhyve: refactor NVMe PRP memcpy.

I came here from D21838 to say: looks good too!!! :)

Thu, Oct 10, 11:52 PM
araujo accepted D21838: bhyve: refactor NVMe namespace initialization.

Lgtm, thank you!

Thu, Oct 10, 11:50 PM
araujo accepted D21839: bhyve: implement NVMe deallocate command.

Lgtm

Thu, Oct 10, 11:43 PM

Wed, Oct 9

araujo added a comment to D21955: New port: security/aws-vault: Vault for securely storing and accessing AWS credentials.
In D21955#479672, @dmgk wrote:

Hook to the build.

Wed, Oct 9, 4:02 PM
araujo accepted D21955: New port: security/aws-vault: Vault for securely storing and accessing AWS credentials.
Wed, Oct 9, 3:56 PM
araujo accepted D21957: security/lego: Update to 3.1.0.
Wed, Oct 9, 3:50 PM
araujo added a comment to D21955: New port: security/aws-vault: Vault for securely storing and accessing AWS credentials.
In D21955#479658, @dmgk wrote:

You need to connect the new port on security/Makefile, seems it is missing from this diff.

But I was asked to use addport for this by @tz - https://reviews.freebsd.org/D21780?id=62505#inline-136019
So what should I use? :)

Wed, Oct 9, 3:49 PM
araujo requested changes to D21955: New port: security/aws-vault: Vault for securely storing and accessing AWS credentials.

You need to connect the new port on security/Makefile, seems it is missing from this diff.

Wed, Oct 9, 3:16 PM
araujo accepted D21956: databases/pspg: Update to 2.1.4.
Wed, Oct 9, 3:14 PM
araujo requested changes to D21957: security/lego: Update to 3.1.0.

It is a bit of nit picky from my side, but I don't see a reason for those changes, actually before was better, the files were in alphabetic order.
Did I miss something?

Wed, Oct 9, 3:14 PM
araujo committed rP514165: Welcome Oleksii Samorukov (samm@) to the rank of ports committer..
Welcome Oleksii Samorukov (samm@) to the rank of ports committer.
Wed, Oct 9, 2:55 PM

Tue, Oct 8

araujo accepted D21941: devel/packr: Update to 2.7.1.
Tue, Oct 8, 3:08 PM
araujo added a comment to D21929: sysutils/iocage - Fix git/git-lite dependencies as well as leftover EGG files..

This solves my problem as far as I am concerned. Maybe it's worth thinking about this tuning globally since we have more than 50 ports depending on devel/git and I am pretty sure most of these ports would be functional with devel/git-lite. By defaulting to devel/git-lite, you make it impossible to use both one of there 50+ ports and sysutils/iocage, which might be a problem? I am not sure about what is the best solution, so I will stick to a LGTM for now :-)

Tue, Oct 8, 7:40 AM
araujo committed rP514026: - Update to 2019.09.28..
- Update to 2019.09.28.
Tue, Oct 8, 3:44 AM
araujo updated the summary of D21929: sysutils/iocage - Fix git/git-lite dependencies as well as leftover EGG files..
Tue, Oct 8, 3:07 AM
araujo created D21929: sysutils/iocage - Fix git/git-lite dependencies as well as leftover EGG files..
Tue, Oct 8, 2:14 AM
araujo added a comment to D21854: Bump PORTREVISION for D21730.
In D21854#479049, @dmgk wrote:

Hey @dmgk, please proceed with the commit. You have my blessing.

Thanks, I asked for an exp-run (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240986) and will commit as soon as it passes.

Tue, Oct 8, 2:01 AM
araujo added a comment to D21854: Bump PORTREVISION for D21730.

Hey @dmgk, please proceed with the commit. You have my blessing.

Tue, Oct 8, 12:55 AM
araujo accepted D21917: misc/nnn: Update to 2.7.
Tue, Oct 8, 12:39 AM

Tue, Oct 1

araujo accepted D21856: databases/pspg: Update to 2.1.3.
Tue, Oct 1, 2:24 PM
araujo added a comment to D21854: Bump PORTREVISION for D21730.
In D21854#477434, @dmgk wrote:

LGTM!

Do I need to get portmgr approval for this or it's OK to commit along with https://reviews.freebsd.org/D21730?

Tue, Oct 1, 2:23 PM
araujo accepted D21854: Bump PORTREVISION for D21730.

LGTM!

Tue, Oct 1, 6:05 AM
araujo committed rP513454: - Drop support for devel/dulwich. [0].
- Drop support for devel/dulwich. [0]
Tue, Oct 1, 5:49 AM

Mon, Sep 30

araujo committed rP513279: - Update necessary dependencies for iocage 1.2 release..
- Update necessary dependencies for iocage 1.2 release.
Mon, Sep 30, 2:51 AM
araujo added a comment to D21744: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. sysutils-x11).
In D21744#477011, @dmgk wrote:

That's fair. However, this review is a sweeping change of all go ports to meet a specific, consistent standard, suggesting that the plurality of ports were doing things in a suboptimal way. IMO the PHB should demonstrate what the ports should and should not be doing.

Makes sense. Perhaps it would be useful to have a list of "best practices" for creating Go ports. I'll extend the "Building Go Applications" section and post a doc review.

Mon, Sep 30, 1:16 AM

Fri, Sep 27

araujo added a comment to D21819: ports-mgmt/modules2tuple: Update to 1.8.2.
In D21819#476317, @dmgk wrote:

Looks like svn ate "Changes:" line in the commit message, sorry about that. Is it some kind a reserved keyword? Should I use "Changelog" or similar for itemized changes list?

Fri, Sep 27, 3:39 PM
araujo accepted D21819: ports-mgmt/modules2tuple: Update to 1.8.2.
Fri, Sep 27, 2:57 PM
araujo committed rP512999: - Update to 1.2..
- Update to 1.2.
Fri, Sep 27, 2:30 AM
araujo added a comment to D21808: lang/go-devel: Update to g20190925 (go1.13.1).

On this Port secteam isn't needed because your are the maintainer. The another case we will check who approves first maintainer or secteam. If none of them approves in couple days, we need to escalate to portmng.

Fri, Sep 27, 12:18 AM

Thu, Sep 26

araujo accepted D21809: lang/go: Update to 1.13.1.

ports secteam any of you could approve? @dmgk add see ports_secteam group in the review too.

Thu, Sep 26, 11:53 PM
araujo accepted D21808: lang/go-devel: Update to g20190925 (go1.13.1).
Thu, Sep 26, 11:46 PM
araujo accepted D21802: security/vuxml: Add entry for lang/go and lang/go-devel CVE-2019-16276.

Ok, please open reviews for both of go and go-devel, we should commit the vuxml and both ports together, not mandatory, but nice to do.

Thu, Sep 26, 3:52 PM
araujo updated subscribers of D21802: security/vuxml: Add entry for lang/go and lang/go-devel CVE-2019-16276.

Will we update go and go-devel ports? Do you need to sync anything with @jlaffaye?

Thu, Sep 26, 3:29 PM
araujo accepted D21799: databases/pspg: Update to 2.1.2.
Thu, Sep 26, 12:26 PM

Wed, Sep 25

araujo accepted D21793: dns/knot-resolver: Remove redundant lang/go build dependency.
Wed, Sep 25, 10:23 PM

Tue, Sep 24

araujo accepted D21730: Mk/Uses/go.mk: Omit symbol table and debug information by default.

Is it worth do an exp-run on this one too?

Tue, Sep 24, 2:02 AM
araujo accepted D21743: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. misc-shells).

LGTM, same thing as the other reviews, wait for the exp-run and also for the portmgr approval.

Tue, Sep 24, 1:58 AM
araujo accepted D21744: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. sysutils-x11).

LGTM, same thing, wait for the exp-run and portmgr approval.

Tue, Sep 24, 1:50 AM
araujo accepted D21741: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. audio-mail).

It looks good to me, but you need to wait for the exp-run and also portmgr approval.
Thanks to work on this.

Tue, Sep 24, 1:44 AM

Mon, Sep 23

araujo accepted D21771: www/gitea: Use linker flags to set version instead of patching the source..

This is cool, I didn't know it would be possible set version via ldflags.

Mon, Sep 23, 10:52 PM
araujo added a comment to D21730: Mk/Uses/go.mk: Omit symbol table and debug information by default.
In D21730#475087, @dmgk wrote:

IIUC this potentially changes all Go binaries, so all USES=go ports that do not set ldflags themselves probably need a PORTREVISION bump afterwards to relink them?

A quick search

for f in $(find /usr/ports -name Makefile | xargs grep -l 'USES=.*\bgo\b'); do grep -q '\bldflags\b' $f || echo $f; done | wc -l

shows that it would require bumping PORTREVISION of 198 ports. Recompiling will make binaries about 25% smaller on average but there are no other functional changes. I can prepare a separate review if we're OK with this.

Mon, Sep 23, 10:49 PM
araujo accepted D21735: www/gohugo: Update for D21730.
Mon, Sep 23, 7:59 PM

Sun, Sep 22

araujo accepted D21751: editors/dte: Update to 1.9.
Sun, Sep 22, 1:38 PM
araujo accepted D21748: databases/pspg: Update to 2.0.4.
Sun, Sep 22, 1:37 PM

Fri, Sep 20

araujo added a comment to D21721: USES=go ports: cleanup, make use of the new GO_TARGET tuple syntax.
In D21721#474028, @dmgk wrote:

As you are working on this already for a while, how about ports that you are not a maintainer? Maybe an exp-run following with a portmgr@ approval would be interesting to clean up the rest of the ports.

That was my plan actually, I was just not sure what would be the best way to get something like that reviewed/committed. The complete diff is about 250KB, I was thinking about maybe breaking it to 3-4 parts for easier review. Would that make sense or it would be better to post it in a single review?

Fri, Sep 20, 12:23 PM
araujo accepted D21721: USES=go ports: cleanup, make use of the new GO_TARGET tuple syntax.
In D21721#473887, @dmgk wrote:
In D21721#473870, @tz wrote:

Since i am very unfamiliar with the go ports, i have problems to understand this diff.
In devel/awless only do-build and do-install is removed, but i do not see any usage of GO_TARGET. Same for some other ports.

r505321 converted all ports to USES=go which already provides do-build and do-install targets. During that conversion, ports that were defining their own build/install targets were left alone to be cleaned up later. This commit does this cleanup for the ports that I maintain.

Fri, Sep 20, 2:05 AM

Thu, Sep 19

araujo accepted D21716: security/botan2: Update to 2.11.0.

You should do two commits for this review, first commit security/botan2 and then commit the BUMP for the other ports that depends of security/botan2.

Thu, Sep 19, 2:39 PM

Wed, Sep 18

araujo committed rP512255: This is a multi tabbed terminal that uses embedded windows and a gtk.
This is a multi tabbed terminal that uses embedded windows and a gtk
Wed, Sep 18, 7:23 AM
araujo committed rP512254: - Update to 2019.09.12.1..
- Update to 2019.09.12.1.
Wed, Sep 18, 6:49 AM

Tue, Sep 17

araujo accepted D21691: x11-fonts/font-awesome: Update to 5.10.2.
Tue, Sep 17, 5:27 PM
araujo accepted D21687: security/sops: Update to 3.4.0.
Tue, Sep 17, 12:43 PM
araujo accepted D21679: Amend r352422, add missing 'n'.
Tue, Sep 17, 12:16 AM

Mon, Sep 16

araujo committed rP512140: Welcome Dmitri Goutnik (dmgk) to the rank of ports committer..
Welcome Dmitri Goutnik (dmgk) to the rank of ports committer.
Mon, Sep 16, 3:42 AM

Sep 11 2019

araujo accepted D21601: Depend on the gcc${GCC_DEFAULT} binary, since only lang/gcc installs gcc..

It builds fine at my side with poudriere: build of sysutils/uefi-edk2-qemu | uefi-edk2-qemu-x86_64-g20190307_1 ended at Wed Sep 11 09:26:10 CST 2019

Sep 11 2019, 1:32 AM

Sep 10 2019

araujo added a comment to D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

You have my approve to commit it! Thank you!

Committed. But I just realized, should I also bump PORTREVISION?

Sep 10 2019, 2:03 AM
araujo added a comment to D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

USE_GCC will set build-time and run-time dependency, if we need only build-time dependency the patch looks good to me.

Thanks! Since I'm not a ports committer, could you commit the change please?

Sep 10 2019, 1:49 AM
araujo committed rP511726: Update to 2019.09.01.
Update to 2019.09.01
Sep 10 2019, 1:48 AM
araujo accepted D21580: sysutils/uefi-edk2-qemu: GCC should be a build dependency, not runtime.

USE_GCC will set build-time and run-time dependency, if we need only build-time dependency the patch looks good to me.

Sep 10 2019, 1:44 AM

Sep 9 2019

araujo committed rP511604: - Use vendored deps.
- Use vendored deps
Sep 9 2019, 2:05 AM

Sep 2 2019

araujo committed rP510766: - Update to 0.21.0.
- Update to 0.21.0
Sep 2 2019, 7:12 AM

Aug 28 2019

araujo committed rP510038: - Simplify the port moving out unneeded post-extract, do-build and.
- Simplify the port moving out unneeded post-extract, do-build and
Aug 28 2019, 3:06 AM

Aug 27 2019

araujo committed rS351541: MFC r350433: Fix sound on headset jack for ALC255 and ALC256 codec..
MFC r350433: Fix sound on headset jack for ALC255 and ALC256 codec.
Aug 27 2019, 7:17 AM
araujo committed rP509991: Update to 2019.08.13..
Update to 2019.08.13.
Aug 27 2019, 6:44 AM
araujo committed rP509990: A personal terminal-based dashboard utility, designed for displaying.
A personal terminal-based dashboard utility, designed for displaying
Aug 27 2019, 6:21 AM

Aug 2 2019

araujo committed rP507862: Assign back to the pool.
Assign back to the pool
Aug 2 2019, 8:44 AM
araujo committed rP507860: Update to 2.04.
Update to 2.04
Aug 2 2019, 8:40 AM
araujo added a comment to D21053: Simplify capsicumization of bhyve (cont'd).
In D21053#458959, @jhb wrote:

I worry this might be a bit premature. New features for bhyve are often developed without capsicum because capsicum is a pain to work with. The debug server didn't use it at first, save/restore currently disables it as does the 9p patch. Removing WITHOUT_CAPSICUM makes coordinating that existing work harder. It also adds a pretty good barrier to entry when trying to add new things that add new ioctls, etc.

It's not much more work to add a new right in a driver that already works under capsicum than it is to add -DWITHOUT_CAPSICUM to the build flags.

Aug 2 2019, 3:30 AM

Aug 1 2019

araujo committed rP507757: Update to 2019.07.30.
Update to 2019.07.30
Aug 1 2019, 8:09 AM
araujo added a comment to D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).

@araujo, sounds like you are taking over this review?

Aug 1 2019, 12:13 AM
araujo added a comment to D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).
In D19400#458949, @jhb wrote:

I wonder if it makes more sense to do this in vmrun.sh? OTOH, it's probably fine to do this. We should also probably do it in bhyverun.c since bhyveload isn't used in the UEFI case. Another option would be to do this in the vm_create() wrapper in libvmmapi in which case that would fix bhyveload, grub2-bhyve, and bhyve all in one place.

Aug 1 2019, 12:02 AM

Jul 30 2019

Herald updated subscribers of D15992: bhyve: supported features reporting PoC.
Jul 30 2019, 8:20 AM
araujo added a comment to D7840: HD Audio Emulation For Bhyve.

Committed already at r349335

Jul 30 2019, 8:16 AM
araujo added a reviewer for D7840: HD Audio Emulation For Bhyve: iateaca.

I'm commandeer this revision because this patch were committed already by @scottl: https://svnweb.freebsd.org/base?view=revision&sortby=date&revision=349335

Jul 30 2019, 8:16 AM
araujo added a member for bhyve: araujo.
Jul 30 2019, 7:52 AM
araujo added a comment to D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).

@jhb Perhaps do the same with bhyverun.c?

Jul 30 2019, 7:06 AM
araujo committed rS350433: Fix sound on headset jack for ALC255 and ALC256 codec..
Fix sound on headset jack for ALC255 and ALC256 codec.
Jul 30 2019, 2:02 AM
araujo closed D19017: - Fix Headset sound for DELL laptops.
Jul 30 2019, 2:02 AM

Jul 28 2019

araujo added a comment to D19017: - Fix Headset sound for DELL laptops.

Ok, I'm gonna do it tomorrow!!!

Jul 28 2019, 12:10 PM

Jul 25 2019

araujo added inline comments to D21053: Simplify capsicumization of bhyve (cont'd).
Jul 25 2019, 4:29 AM
araujo committed rP507309: - Update GH_TAGNAME to reflect the right tag on github for version 1.1.0..
- Update GH_TAGNAME to reflect the right tag on github for version 1.1.0.
Jul 25 2019, 2:34 AM

Jul 24 2019

araujo committed rP507267: Update to 2.22.
Update to 2.22
Jul 24 2019, 9:00 AM
araujo added a comment to D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).

@jhb Any objection if I proceed to commit this patch? I just hit the same situation "forgot to load vmm" and this patch does fix it.

Jul 24 2019, 8:22 AM
araujo added a comment to D19976: bhyve: Support a _VARS.fd file for bootrom.

ping!!!

Jul 24 2019, 8:18 AM
araujo added a comment to D21053: Simplify capsicumization of bhyve (cont'd).

The problem here is that you will not be able to build this code on other platforms like Solaris.
I'm not sure if this is applicaple for bhyve, if not then the change looks good to me.

Jul 24 2019, 8:05 AM
araujo added a comment to D21053: Simplify capsicumization of bhyve (cont'd).

Remove CASPER from Makefile as we don't use any service.

Jul 24 2019, 8:00 AM
araujo added inline comments to D21053: Simplify capsicumization of bhyve (cont'd).
Jul 24 2019, 8:00 AM
araujo added reviewers for D21053: Simplify capsicumization of bhyve (cont'd): oshogbo, jhb.
Jul 24 2019, 7:47 AM
araujo created D21053: Simplify capsicumization of bhyve (cont'd).
Jul 24 2019, 7:45 AM
araujo committed rP507264: Update to 2019.07.16.
Update to 2019.07.16
Jul 24 2019, 6:15 AM
araujo committed rP507263: - Enable ZMQ by default.
- Enable ZMQ by default
Jul 24 2019, 5:35 AM
araujo committed rP507261: Update to 1.1.0.
Update to 1.1.0
Jul 24 2019, 2:29 AM