Page MenuHomeFreeBSD

araujo (Marcelo Araujo)
User

Projects

User Details

User Since
May 10 2014, 4:51 AM (342 w, 18 h)

Recent Activity

Aug 14 2020

araujo added a comment to D26035: Refactor configuration management in bhyve..
In D26035#578290, @jhb wrote:

Definitely that is what will happen, somebody else will write a wrapper for this configuration file!!! The problem I see here is the standard(syntax and etc), it does not look like any configuration file I have ever see, and you know after you commit it, it will live there for forever, because we need to respect POLA.

I think you are conflating a few things. First, the syntax to me at least seems rather straight forward and even rather common (e.g. Windows INI files, the OpenSSL config file, even rc.conf) all use 'name=value' lines. It doesn't have [group] lines. I suppose if you really wanted that you could do that for nesting instead of a MIB name, but that seems equally unreadable.

Also, to be clear, the main thrust here is not really having a config file (that is more thrown in as a PoC of how one can combine both files and command line options to build a config), but it is really the nvlist tree and separating config parsing from acting on the config. That removes lots of dubious string parsing code from device models and also makes it much easier (IMO) to add new config variables in the future with minimal code changes. One of the things this model permits is adding config options to USB devices with previously were not permitted by the limited syntax of '-s' options used for XHCI controllers. The "flat" config file is basically the simplest type of config file format one could have (direct key=value without additional implicit knowledge). Right now we already require people using '-s' to know about which PCI slot devices live on, so the "flat" config file isn't worse, just equally non-ideal in that regard.

I think your actual concern is not the syntax, but the fact that the file maps 1:1 onto the set of config values and the stability of how the config tree is managed over time. Devices in particular I think are one of the hardest to reason about. I had originally toyed with trying to do a device namespace that looked a bit more like this:

device.0.type="ahci"
device.0.location="pci0:1:0"
device.0.path="disk.img"

etc. However, while more abstract, it is harder to deal with this sanely in bhyve itself as there may be parent-child dependencies this doesn't capture. Even the current 'pci.<bus>.<slot>.<function>' scheme isn't really ideal if we ever have support for PCI-PCI bridges (though it is doable, you do pci bus 0 first and do a depth-first traversal using the bridge bus numbers to look for devices instead of the current iteration over all possible values).

The other scheme I considered would be to have the device nodes be an actual tree reflecting their layout much like ACPI or FDT. USB devices are already following this somewhat by being hung under the xhci node, whereas lpc devices are not (they are not children of the lpc device). For PCI devices this would be more invasive if PCI-PCI bridges were added since that would then become more of a tree rather than the current flat layout it is now. However, this would also be more complex than the current layout which more naturally fit the existing device model initialization.

Aug 14 2020, 1:37 AM
araujo resigned from D26035: Refactor configuration management in bhyve..
Aug 14 2020, 1:35 AM
araujo requested changes to D26035: Refactor configuration management in bhyve..
Aug 14 2020, 1:34 AM

Aug 13 2020

araujo added a comment to D26035: Refactor configuration management in bhyve..
In D26035#578006, @jhb wrote:

The configuration file is not intuitive at all, how I will know what pci slot my virtio-blk shall live?
Why not simplify it instead of complicate more? The configuration file supposed to be something to simplify the command line, and instead is getting more complex than bhyve cli itself. Perhaps we will need another io<something> wrapper to simplify the creation of bhyve configuration files.

This is much more complex than bhyve cli itself.
pci.0.0.0.device=hostbridge
pci.0.2.0.device=virtio-net
pci.0.2.0.backend=%(tap)
pci.0.3.0.device=virtio-blk
pci.0.3.0.path=/dev/zvol/zroot/bhyve/%(name)
pci.0.4.0.device=virtio-rnd
pci.0.31.0.device=lpc
lpc.com1.device=stdio
lpc.com2.device=/dev/nmdm%(name)2B
lpc.bootrom=/usr/local/share/uefi-firmware/BHYVE_UEFI.fd

Could we use a similar approach of the configuration file syntax like everybody else is using? I know make things simple is hard.

To be clear, one can build a UCL parser (I think I mentioned this on the list) that uses rules to write a backing config. I explicitly mentioned there that the UCL syntax could auto-compute the PCI slots to use while having an optional keyword to force a specific PCI slot if desired. Reading the config file is just a means of translating the config the UCL file likes into a set of configuration variable settings. That is, you could very much do something like:

Aug 13 2020, 2:04 AM

Aug 12 2020

araujo added a comment to D26035: Refactor configuration management in bhyve..

The configuration file is not intuitive at all, how I will know what pci slot my virtio-blk shall live?
Why not simplify it instead of complicate more? The configuration file supposed to be something to simplify the command line, and instead is getting more complex than bhyve cli itself. Perhaps we will need another io<something> wrapper to simplify the creation of bhyve configuration files.

Could we use a similar approach of the configuration file syntax like everybody else is using? I know make things simple is hard.

The config file here is for bhyve internal, it is accurate but complex.
Maybe other hypervisor manager, such as vm-bhyve will read their simple config file and output this config style for bhyve, then launch the bhyve process.

Aug 12 2020, 2:31 AM
araujo added a comment to D26035: Refactor configuration management in bhyve..

The configuration file is not intuitive at all, how I will know what pci slot my virtio-blk shall live?
Why not simplify it instead of complicate more? The configuration file supposed to be something to simplify the command line, and instead is getting more complex than bhyve cli itself. Perhaps we will need another io<something> wrapper to simplify the creation of bhyve configuration files.

Aug 12 2020, 1:27 AM

May 4 2020

araujo accepted D24682: update sysutils/busybox.

LGTM!

May 4 2020, 6:19 AM

May 3 2020

araujo accepted D24676: security/acmetool: - upgrade to v0.2.1 [PR 244888].

Nice to see you back Hope all is good with you

May 3 2020, 10:36 AM

Feb 7 2020

araujo accepted D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".

LGTM, add the Approved by as usual.

Feb 7 2020, 1:44 AM

Feb 6 2020

araujo accepted D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

Approve by: araujo

Feb 6 2020, 7:37 AM
araujo added a comment to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

OK, as soon as the poudriere get the results, share it here.

Feb 6 2020, 6:40 AM
araujo added inline comments to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.
Feb 6 2020, 6:01 AM
araujo added a comment to D23476: sysutils/uefi-edk2-bhyve: update to be same as uefi-edk2-bhyve-devel and delete -devel port.

Did you test it using poudriere?

Feb 6 2020, 5:57 AM

Feb 5 2020

araujo requested changes to D23486: sysutils/uefi-edk2-qemu: Replace "python2.7" with "${PYTHON_CMD}".

How are you testing these changes that you didn't catch this problem before?

Feb 5 2020, 2:52 AM

Feb 3 2020

araujo accepted D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.

Ops my bad :)

Feb 3 2020, 3:36 AM
araujo added a comment to D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.

If you will remove the port, why botter to update it and trigger hooks around to rebuild the package?

Feb 3 2020, 3:19 AM
araujo requested changes to D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.

Wait...

Feb 3 2020, 3:18 AM
araujo added a comment to D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.

@bcran You can commit it, you have my approval. Just add:

Feb 3 2020, 3:17 AM
araujo accepted D23466: sysutils/uefi-edk2-qemu: update to edk2-stable201911.
Feb 3 2020, 2:23 AM

Jan 20 2020

araujo added a comment to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..

Have you ever take a look at: https://github.com/xcllnt/libvdsk
It seemed to me a better idea than what are you trying to achieve here, and there, there is an experimental implementation of qcow2.

Jan 20 2020, 1:42 AM

Jan 17 2020

araujo committed rP523293: The Bitmark distributed property system..
The Bitmark distributed property system.
Jan 17 2020, 10:47 AM
araujo closed D23167: New port net-p2p/bitmark and associated slave ports (v0.12.4).
Jan 17 2020, 10:47 AM

Jan 3 2020

araujo committed rP521897: - Forgotten to add the patches on files directory at r521896..
- Forgotten to add the patches on files directory at r521896.
Jan 3 2020, 4:06 AM
araujo committed rP521896: - Update to 1.0.7..
- Update to 1.0.7.
Jan 3 2020, 3:59 AM

Dec 20 2019

araujo closed D22873: Fix rfb handshake after r355301..

It was committed already by @jhb at: https://svnweb.freebsd.org/changeset/base/355912

Dec 20 2019, 1:53 AM

Dec 19 2019

araujo updated the summary of D22873: Fix rfb handshake after r355301..
Dec 19 2019, 3:24 AM
araujo created D22873: Fix rfb handshake after r355301..
Dec 19 2019, 3:24 AM

Dec 17 2019

araujo committed rS355839: Forgotten to remove the previous if statement in commit r355838..
Forgotten to remove the previous if statement in commit r355838.
Dec 17 2019, 1:37 AM
araujo closed D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).
Dec 17 2019, 1:34 AM
araujo committed rS355838: Attempt to load vmm(4) module before creating a guest using vm_create().
Attempt to load vmm(4) module before creating a guest using vm_create()
Dec 17 2019, 1:33 AM

Dec 16 2019

araujo committed rP520225: - Update to master branch on 2018-12-16, this is a few commits after.
- Update to master branch on 2018-12-16, this is a few commits after
Dec 16 2019, 7:25 AM
araujo closed D22832: Update sysutils/go-wtf to version 0.25.0.
Dec 16 2019, 7:25 AM
araujo added a comment to D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).

@jhb Does that make more sense?

Dec 16 2019, 5:48 AM
araujo updated the diff for D19400: attempt to load vmm.ko if it's not already loaded (bhyveload).
  • move the implementation to libvmmapi.
Dec 16 2019, 5:47 AM
araujo committed rP520217: - Move the project to github and mark it as fetchable again..
- Move the project to github and mark it as fetchable again.
Dec 16 2019, 5:11 AM

Dec 2 2019

araujo added a comment to D22615: net-mgmt/netdata: Update to 1.19.0.

Thanks!

Dec 2 2019, 9:57 AM
araujo closed D22045: net-mgmt/netdata: upgrade to 1.18.1.

Committed at: https://svnweb.freebsd.org/changeset/ports/518840

Dec 2 2019, 9:56 AM
araujo commandeered D22045: net-mgmt/netdata: upgrade to 1.18.1.

Taking it.

Dec 2 2019, 9:56 AM
araujo committed rP518841: - Update to 2019.11.28..
- Update to 2019.11.28.
Dec 2 2019, 9:55 AM
araujo committed rP518840: - Update to 1.19.0..
- Update to 1.19.0.
Dec 2 2019, 9:53 AM
araujo closed D22615: net-mgmt/netdata: Update to 1.19.0.
Dec 2 2019, 9:53 AM
araujo accepted D22615: net-mgmt/netdata: Update to 1.19.0.

LGTM, gimme couple hours and I will commit it.

Dec 2 2019, 7:17 AM

Nov 19 2019

araujo committed rP517937: Release Dmitri Goutnik (dmgk) from mentorship, he is more than ready.
Release Dmitri Goutnik (dmgk) from mentorship, he is more than ready
Nov 19 2019, 1:20 AM

Nov 8 2019

araujo added a comment to D22045: net-mgmt/netdata: upgrade to 1.18.1.

@samm Can you move forward with this patch? The maintainer has timeout already.

Nov 8 2019, 12:44 AM

Oct 30 2019

araujo accepted D22190: security/aws-vault: Update to 4.7.1.
Oct 30 2019, 3:15 PM

Oct 25 2019

araujo accepted D22149: shells/elvish: Set version information, omit debug info.
Oct 25 2019, 1:52 AM
araujo added a comment to D22045: net-mgmt/netdata: upgrade to 1.18.1.

So please, proceed to merge these two reviews and incorporate the submitter suggestions.

Oct 25 2019, 1:51 AM
araujo added a comment to D22045: net-mgmt/netdata: upgrade to 1.18.1.
In D22045#483993, @samm wrote:

@samm Could you double check with @daniel.engberg.lists_pyret.net the changes that he is proposing and perhaps after that we can close the D21969 review?

A single place makes more sense, however @daniel.engberg.lists_pyret.net opened the review first, so technically he will receive the credits for the patch submission. I just want a single review for this port update.

Best Regards,

Hi, i am perfectly fine to give him credits and merge the patches. Main problem is that there is no feedback from the maintainer. What should we do to get this done?

Oct 25 2019, 1:48 AM

Oct 23 2019

araujo added a comment to D21969: net-mgmt/netdata: Update to 1.18.1.

Sure, but I think it's a discouraging way to handle submissions in terms of chronological order.

Oct 23 2019, 9:07 AM
araujo requested changes to D22045: net-mgmt/netdata: upgrade to 1.18.1.

@samm Could you double check with @daniel.engberg.lists_pyret.net the changes that he is proposing and perhaps after that we can close the D21969 review?

Oct 23 2019, 8:55 AM
araujo added a comment to D21969: net-mgmt/netdata: Update to 1.18.1.

At least fix the issues reported in that case?

Oct 23 2019, 8:51 AM
araujo added a comment to D21969: net-mgmt/netdata: Update to 1.18.1.

Can we abandon this review in favor of the another one?

Oct 23 2019, 8:38 AM
araujo accepted D22092: devel/goswagger: Update to 0.21.0.
Oct 23 2019, 8:35 AM
araujo accepted D22105: www/gohugo: Update to 0.59.0.
Oct 23 2019, 8:35 AM

Oct 22 2019

araujo awarded Dev Summit Attendee to recipient: araujo.
Oct 22 2019, 8:53 AM
araujo accepted D22098: ports-mgmt/modules2tuple: Update to 1.9.0.
Oct 22 2019, 3:56 AM
araujo accepted D22097: databases/pgbouncer: Update to 1.12.0.
Oct 22 2019, 3:56 AM
araujo closed D22102: Update sysutils/go-wtf to version 0.23.
Oct 22 2019, 3:05 AM
araujo committed rP515166: - Update to 0.23..
- Update to 0.23.
Oct 22 2019, 3:05 AM
araujo accepted D22102: Update sysutils/go-wtf to version 0.23.

LGTM, I will commit soon!!!

Oct 22 2019, 2:35 AM

Oct 21 2019

araujo committed rP515095: Update to 2019.10.16..
Update to 2019.10.16.
Oct 21 2019, 10:04 AM
araujo committed rP515091: - Set OPTIONS_DEFAULT to devel/git instead of devel/git-lite..
- Set OPTIONS_DEFAULT to devel/git instead of devel/git-lite.
Oct 21 2019, 9:13 AM
araujo committed rP515086: - Fix git/git-lite dependencies..
- Fix git/git-lite dependencies.
Oct 21 2019, 7:13 AM
araujo committed rP515084: - Fix git/git-lite dependencies as well as leftover EGG files..
- Fix git/git-lite dependencies as well as leftover EGG files.
Oct 21 2019, 6:25 AM
araujo closed D21929: sysutils/iocage - Fix git/git-lite dependencies as well as leftover EGG files..
Oct 21 2019, 6:25 AM

Oct 19 2019

araujo accepted D22058: x11/wmutils-core: Update to 1.5.

Lgtm!

Oct 19 2019, 11:52 PM

Oct 18 2019

araujo accepted D22078: www/gobuffalo: Update to 0.14.11.
Oct 18 2019, 11:01 PM
araujo accepted D22079: databases/pspg: Update to 2.1.8.
Oct 18 2019, 11:00 PM
araujo accepted D22080: lang/go-devel: Update to g20191017 (go1.13.3).
Oct 18 2019, 11:00 PM

Oct 17 2019

araujo accepted D22066: sysutils/busybox: fix the build.

You should bump PORTREVISION to force package rebuild.

Oct 17 2019, 8:13 AM

Oct 16 2019

araujo added a comment to D22051: x11-fm/filerunner : Update MAINTAINER.
In D22051#481744, @dmgk wrote:

The PHB seems to say otherwise:

PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way.

Changing MAINTAINER does change package metadata (and the generated package as a consequence) and according to the above, needs a PORTREVISION bump. But looking at the svn logs, nobody deems this change "important enough" to warrant a rebuild :)

Oct 16 2019, 2:17 PM
araujo accepted D22051: x11-fm/filerunner : Update MAINTAINER.

For record only, accepting it from Fukushima, Japan!

Oct 16 2019, 12:20 PM
araujo accepted D22047: print/a2pdf : Update MAINTAINER.
Oct 16 2019, 12:19 PM
araujo requested changes to D22047: print/a2pdf : Update MAINTAINER.

Why bump PORTREVISION?

Oct 16 2019, 9:15 AM
araujo requested changes to D22051: x11-fm/filerunner : Update MAINTAINER.

You don't need the gratuitous PORTREVISION bump here!

Oct 16 2019, 9:13 AM

Oct 15 2019

araujo added a comment to D22022: sysutils/busybox: update to the 1.31.0 version.

Forgot to commit? Is there anything left to be reviewed?

Oct 15 2019, 11:36 PM

Oct 14 2019

araujo added a comment to D22022: sysutils/busybox: update to the 1.31.0 version.
In D22022#481030, @samm wrote:

Thank you for feedback!

Yes, i am using it already

You must always test the changes using it, also when you open a review, you should fullfil the test area saying at least something like:

poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r348350 amd64 + i386) -> OK
portlint and portclippy -> OK
Runtime tests -> OK

Ok, was not aware of this, will do from the next submission. Only problem is that host for the poudriere is now running on 11.3, so 12+ tests will fail.

And will think how to automate all the process...

Probably will setup bhyve vm on 12+ to do the tests or will upgrade this host.

Oct 14 2019, 4:22 PM
araujo accepted D22022: sysutils/busybox: update to the 1.31.0 version.

Do you use poudriere?
https://www.freebsd.org/doc/handbook/ports-poudriere.html

Oct 14 2019, 4:11 PM
araujo accepted D22018: dns/inadyn, net-mgmt/flowviewer, sysutils/smartmontools: update homepage URL.
Oct 14 2019, 7:56 AM

Oct 12 2019

araujo added a comment to D22000: security/botan2: Update to 2.12.0.

You have two "right" options, choose wisely :)

Oct 12 2019, 11:58 PM
araujo added a comment to D22000: security/botan2: Update to 2.12.0.

Two separate commits makes it easier to write the history log and in case you need one day to make a revert, it will be more easier to identify the reason. But it is not mandatory, but it is what I have been doing since 2007.

Oct 12 2019, 11:01 PM
araujo accepted D21981: databases/pspg: Update to 2.1.7.
Oct 12 2019, 12:44 PM
araujo accepted D21991: www/gitea: Update to 1.9.4.
Oct 12 2019, 12:30 PM
araujo accepted D21985: Add samm to committers-ports.dot and calendar.freebsd.
Oct 12 2019, 9:48 AM
araujo accepted D21986: Add samm to freebsd.commiters.markers.
Oct 12 2019, 9:47 AM

Oct 11 2019

araujo added inline comments to D21985: Add samm to committers-ports.dot and calendar.freebsd.
Oct 11 2019, 10:48 PM
araujo accepted D21977: Add samm as a ports committer.

Sorry, I should have accepted it!!! But please wait for krion to approve it.

Oct 11 2019, 8:20 AM
araujo requested changes to D21977: Add samm as a ports committer.

Thanks for that! You did right already!

Oct 11 2019, 8:19 AM

Oct 10 2019

araujo added a comment to D21837: bhyve: refactor NVMe PRP memcpy.

I came here from D21838 to say: looks good too!!! :)

Oct 10 2019, 11:52 PM
araujo accepted D21838: bhyve: refactor NVMe namespace initialization.

Lgtm, thank you!

Oct 10 2019, 11:50 PM
araujo accepted D21839: bhyve: implement NVMe deallocate command.

Lgtm

Oct 10 2019, 11:43 PM

Oct 9 2019

araujo added a comment to D21955: New port: security/aws-vault: Vault for securely storing and accessing AWS credentials.
In D21955#479672, @dmgk wrote:

Hook to the build.

Oct 9 2019, 4:02 PM
araujo accepted D21955: New port: security/aws-vault: Vault for securely storing and accessing AWS credentials.
Oct 9 2019, 3:56 PM
araujo accepted D21957: security/lego: Update to 3.1.0.
Oct 9 2019, 3:50 PM
araujo added a comment to D21955: New port: security/aws-vault: Vault for securely storing and accessing AWS credentials.
In D21955#479658, @dmgk wrote:

You need to connect the new port on security/Makefile, seems it is missing from this diff.

But I was asked to use addport for this by @tz - https://reviews.freebsd.org/D21780?id=62505#inline-136019
So what should I use? :)

Oct 9 2019, 3:49 PM
araujo requested changes to D21955: New port: security/aws-vault: Vault for securely storing and accessing AWS credentials.

You need to connect the new port on security/Makefile, seems it is missing from this diff.

Oct 9 2019, 3:16 PM
araujo accepted D21956: databases/pspg: Update to 2.1.4.
Oct 9 2019, 3:14 PM
araujo requested changes to D21957: security/lego: Update to 3.1.0.

It is a bit of nit picky from my side, but I don't see a reason for those changes, actually before was better, the files were in alphabetic order.
Did I miss something?

Oct 9 2019, 3:14 PM
araujo committed rP514165: Welcome Oleksii Samorukov (samm@) to the rank of ports committer..
Welcome Oleksii Samorukov (samm@) to the rank of ports committer.
Oct 9 2019, 2:55 PM

Oct 8 2019

araujo accepted D21941: devel/packr: Update to 2.7.1.
Oct 8 2019, 3:08 PM