- User Since
- May 10 2014, 4:51 AM (283 w, 1 d)
You have two "right" options, choose wisely :)
Two separate commits makes it easier to write the history log and in case you need one day to make a revert, it will be more easier to identify the reason. But it is not mandatory, but it is what I have been doing since 2007.
Fri, Oct 11
Sorry, I should have accepted it!!! But please wait for krion to approve it.
Thanks for that! You did right already!
Thu, Oct 10
I came here from D21838 to say: looks good too!!! :)
Lgtm, thank you!
Wed, Oct 9
You need to connect the new port on security/Makefile, seems it is missing from this diff.
It is a bit of nit picky from my side, but I don't see a reason for those changes, actually before was better, the files were in alphabetic order.
Did I miss something?
Tue, Oct 8
Hey @dmgk, please proceed with the commit. You have my blessing.
Tue, Oct 1
Mon, Sep 30
Fri, Sep 27
On this Port secteam isn't needed because your are the maintainer. The another case we will check who approves first maintainer or secteam. If none of them approves in couple days, we need to escalate to portmng.
Thu, Sep 26
Ok, please open reviews for both of go and go-devel, we should commit the vuxml and both ports together, not mandatory, but nice to do.
Will we update go and go-devel ports? Do you need to sync anything with @jlaffaye?
Wed, Sep 25
Tue, Sep 24
Is it worth do an exp-run on this one too?
LGTM, same thing as the other reviews, wait for the exp-run and also for the portmgr approval.
LGTM, same thing, wait for the exp-run and portmgr approval.
It looks good to me, but you need to wait for the exp-run and also portmgr approval.
Thanks to work on this.
Mon, Sep 23
This is cool, I didn't know it would be possible set version via ldflags.
Sun, Sep 22
Fri, Sep 20
Thu, Sep 19
You should do two commits for this review, first commit security/botan2 and then commit the BUMP for the other ports that depends of security/botan2.
Wed, Sep 18
Tue, Sep 17
Mon, Sep 16
Sep 11 2019
It builds fine at my side with poudriere: build of sysutils/uefi-edk2-qemu | uefi-edk2-qemu-x86_64-g20190307_1 ended at Wed Sep 11 09:26:10 CST 2019
Sep 10 2019
USE_GCC will set build-time and run-time dependency, if we need only build-time dependency the patch looks good to me.
Sep 9 2019
Sep 2 2019
Aug 28 2019
Aug 27 2019
Aug 2 2019
Aug 1 2019
Jul 30 2019
Committed already at r349335
I'm commandeer this revision because this patch were committed already by @scottl: https://svnweb.freebsd.org/base?view=revision&sortby=date&revision=349335
@jhb Perhaps do the same with bhyverun.c?
Jul 28 2019
Ok, I'm gonna do it tomorrow!!!
Jul 25 2019
Jul 24 2019
@jhb Any objection if I proceed to commit this patch? I just hit the same situation "forgot to load vmm" and this patch does fix it.
Remove CASPER from Makefile as we don't use any service.