Page MenuHomeFreeBSD

araujo (Marcelo Araujo)
User

Projects

User Details

User Since
May 10 2014, 4:51 AM (249 w, 2 d)

Recent Activity

Fri, Feb 8

araujo accepted D17848: Update review requests for bhyve..

I still feel locked out of usr.sbin/bhyve, mostly of the commits made there in the past year were made by myself or reviewed by myself. Would be fair have my name explicit in that area, I don't want bypass reviews, it is more about the effort I have put in that area and appreciation of it, otherwise doesn't make sense for me to keep contributing with bhyve.

Fri, Feb 8, 10:06 PM

Sun, Feb 3

araujo added a comment to D19042: [New port] audio/pianod2: A free, multi-source, network-controlled music player daemon.

Please, reopen the review, when I'm back from holidays I will help you.

Sun, Feb 3, 1:30 AM

Fri, Feb 1

araujo committed rS343642: Revert r343634:.
Revert r343634:
Fri, Feb 1, 3:09 AM

Thu, Jan 31

araujo abandoned D19016: Replace strlen with strnlen..

It is basically a cosmetic change, so I have committed it already: r343634.

Thu, Jan 31, 11:33 PM
araujo committed rS343634: Mostly a cosmetic change to replace strlen with strnlen..
Mostly a cosmetic change to replace strlen with strnlen.
Thu, Jan 31, 11:32 PM
araujo committed rS343602: MFC r343077:.
MFC r343077:
Thu, Jan 31, 7:08 AM
araujo accepted D18978: [new port] sysutils/conman - serial console manager.
Thu, Jan 31, 2:19 AM
araujo accepted D19018: net/py-ifaddr: Port fixes - Use conditional ${PY_IPADDRESS} - Add LICENSE_FILE.
Thu, Jan 31, 2:17 AM
araujo accepted D18962: sysutils/py-consul -> sysutils/py-python-consul.
Thu, Jan 31, 2:17 AM
araujo accepted D19037: sysutils/py-python-nomad: Update to 1.1.0.
Thu, Jan 31, 2:15 AM
araujo accepted D19038: audio/pianobar: Update to 2019.01.25.
Thu, Jan 31, 2:14 AM
araujo committed rP491673: - Add CMAKE options properly..
- Add CMAKE options properly.
Thu, Jan 31, 1:47 AM
araujo closed D19009: Disable LibVNC/libvncserver cmake default options.
Thu, Jan 31, 1:47 AM
araujo committed rP491672: Update to 2.18..
Update to 2.18.
Thu, Jan 31, 1:39 AM
araujo committed rP491671: Update to 2019.01.30.1..
Update to 2019.01.30.1.
Thu, Jan 31, 1:38 AM
araujo committed rP491670: Update to 1.0.0..
Update to 1.0.0.
Thu, Jan 31, 1:37 AM

Wed, Jan 30

araujo added inline comments to D19016: Replace strlen with strnlen..
Wed, Jan 30, 2:58 AM
araujo updated the diff for D19016: Replace strlen with strnlen..

Revert strnlen to strlen on pci_virtio_net as snprintf does the job already.

Wed, Jan 30, 2:58 AM

Tue, Jan 29

araujo accepted D19018: net/py-ifaddr: Port fixes - Use conditional ${PY_IPADDRESS} - Add LICENSE_FILE.
Tue, Jan 29, 3:51 PM
araujo accepted D18959: dns/py-bonjour -> dns/py-pybonjour.
Tue, Jan 29, 12:52 PM
araujo accepted D19013: [New port] net/py-ifaddr: Python library to enumerate all network interfaces.
Tue, Jan 29, 12:46 PM
araujo removed a reviewer for D19016: Replace strlen with strnlen.: rgrimes.
Tue, Jan 29, 12:37 PM
araujo updated the summary of D19016: Replace strlen with strnlen..
Tue, Jan 29, 12:18 PM
araujo edited reviewers for D19016: Replace strlen with strnlen., added: bhyve; removed: rgrimes.
Tue, Jan 29, 12:16 PM
araujo created D19016: Replace strlen with strnlen..
Tue, Jan 29, 12:15 PM
araujo added a comment to D18959: dns/py-bonjour -> dns/py-pybonjour.

The Makefile disappear :D

Tue, Jan 29, 3:55 AM
araujo requested changes to D18959: dns/py-bonjour -> dns/py-pybonjour.

Missing MOVED entry!

Tue, Jan 29, 3:39 AM
araujo added inline comments to D18962: sysutils/py-consul -> sysutils/py-python-consul.
Tue, Jan 29, 3:38 AM
araujo accepted D18964: sysutils/py-nomad -> sysutils/py-python-nomad.
Tue, Jan 29, 3:37 AM
araujo accepted D18967: update devel/py-minio from 4.0.0 to 4.0.10.
Tue, Jan 29, 3:37 AM
araujo added inline comments to D18978: [new port] sysutils/conman - serial console manager.
Tue, Jan 29, 3:36 AM
araujo added inline comments to D19011: sysutils/ipfs-go: fix rc script when default ipfs_go_path is used.
Tue, Jan 29, 3:28 AM

Mon, Jan 28

araujo accepted D18972: update net/py-zeroconf from 0.20.0 to 0.21.3.
Mon, Jan 28, 6:28 PM
araujo accepted D18973: Update www/minio-client from RELEASE.2018-12-27T00-37-49Z to RELEASE.2019-01-25T23-38-19Z.
Mon, Jan 28, 6:27 PM
araujo committed rP491457: - Bump PORTREVISION of ports that depends of net/libvncserver after it.
- Bump PORTREVISION of ports that depends of net/libvncserver after it
Mon, Jan 28, 6:56 AM
araujo committed rP491456: - Update to 0.9.12..
- Update to 0.9.12.
Mon, Jan 28, 6:52 AM
araujo closed D18836: Update net/libvncserver to 0.9.12.
Mon, Jan 28, 6:52 AM
araujo accepted D18836: Update net/libvncserver to 0.9.12.

I will commit it in a few!
Thanks again and sorry my delay!

Mon, Jan 28, 6:12 AM
araujo committed rP491454: BaseTools: Add missing Elf relocation type for LTO build.
BaseTools: Add missing Elf relocation type for LTO build
Mon, Jan 28, 6:07 AM
araujo committed rP491453: Update to 1.1..
Update to 1.1.
Mon, Jan 28, 5:59 AM

Thu, Jan 24

araujo added a comment to D18946: sysutils/py-nomad -> sysutils/py-python-nomad.

It seems to be redundant py-python, I don't believe it is necessary to do it.

Thu, Jan 24, 11:34 PM
araujo added a reviewer for D18898: audio/pithos: update from 1.0.0 to 1.4.1: miwi.
Thu, Jan 24, 12:50 PM
araujo added inline comments to D18898: audio/pithos: update from 1.0.0 to 1.4.1.
Thu, Jan 24, 12:49 PM
araujo accepted D18883: Rename dns/py-bonjour to dns/py-pybonjour.

LGTM!

Thu, Jan 24, 12:39 PM

Mon, Jan 21

araujo added a reviewer for D18883: Rename dns/py-bonjour to dns/py-pybonjour: koobs.
Mon, Jan 21, 6:06 AM
araujo added a reviewer for D18884: sysutils/py-consul: fix PORTNAME: koobs.
Mon, Jan 21, 6:05 AM

Jan 18 2019

araujo committed rP490673: Update to 2019.01.17..
Update to 2019.01.17.
Jan 18 2019, 9:51 PM

Jan 16 2019

araujo committed rS343077: Fix broken uart on Win2016 guest..
Fix broken uart on Win2016 guest.
Jan 16 2019, 3:46 AM
araujo added a comment to D18749: vmm(4): Partially unfuck multicore AMD support.

Thanks for the patch, it looks right for me, although I don't have any AMD machine right now to make more tests.
I have only two requests and I would like to check with you if you could follow them:

  1. Give some more time for @jhb to also have a chance to take a look on this patch.
  2. When you commit it, please don't use the word "unfuck", just to avoid open room for people to have something to create noise.
Jan 16 2019, 1:37 AM
araujo committed rS343068: Use capsicum_helpers(3) that allow us to simplify the code and its functions.
Use capsicum_helpers(3) that allow us to simplify the code and its functions
Jan 16 2019, 12:39 AM
araujo closed D18744: Simplify capsicumization of bhyve..
Jan 16 2019, 12:39 AM
araujo added a comment to D18744: Simplify capsicumization of bhyve..
In D18744#402454, @jhb wrote:

Thanks! Hopefully this means 'grep -c ENOSYS' in bhyve is now zero. :)

Jan 16 2019, 12:24 AM

Jan 15 2019

araujo requested changes to D18816: bhyve vmm statistics tables need to be sized relative to VM_MAXCPU.

It doesn't looks quite right! I need more time to articulate better arguments, but this patch as it is, must not be committed in.

Jan 15 2019, 12:19 AM
araujo requested changes to D18815: Bhyve acpi MADT table correction for VM_MAXCPU > 21.

It doesn't looks quite right! I need more time to articulate better arguments, but this patch as it is, must not be committed in.

Jan 15 2019, 12:19 AM
araujo added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.
NOTE: I blocked this patch, till I finish my analysis, nothing wrong with that...
Jan 15 2019, 12:19 AM · bhyve
araujo requested changes to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.
Jan 15 2019, 12:17 AM · bhyve

Jan 14 2019

araujo added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Hi Richard,

Do you mind share the tests you made??

Best,

I've currently got these changes running in a FreeNAS-11.2-RELEASE-U1 instance (FreeBSD 11.2 kernel) running a couple of Windows 2016 VMs plus one Centos 7 - all using virtio-blk disk devices without issue. I also have pfSense (FreeBSD 11.2) and OpenSuSE (Leap 42.3) VMs which I haven't tested yet - but can do if required.

Jan 14 2019, 9:43 AM · bhyve
araujo added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Hi Richard,

Jan 14 2019, 3:31 AM · bhyve

Jan 13 2019

araujo added a comment to D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests.

Thanks for the patch, I will take a look on within the next two weeks.

Jan 13 2019, 7:09 AM · bhyve
araujo added a reviewer for D18831: Increase bhyve BLOCKIF_IOV_MAX and VTBLK_RINGSZ to 128 to support modern Windows guests: araujo.
Jan 13 2019, 7:05 AM · bhyve

Jan 8 2019

araujo added a comment to D18755: Add accessor for vm->maxcpus in preperation for run time maxcpu setting.

Add bhyve group, I thought I had that in the list when I created the review. I am soliciting feedback on if I should abandon this diff and re-write the code using an accessor function (called vmm_vm_maxcpus()) to vmm.c that does the vmx->vm->maxcpus dereference and call that. The most common use of this is in vmm.c itself, and would probably end up inlined by the compiler anyway, though there are at least 4 other files that have the need for this, and iirc there is userland code that uses the VM_MAXCPU constant that needs to NOT do that!

Jan 8 2019, 4:46 PM
araujo committed rP489667: Update to 2019.01.02..
Update to 2019.01.02.
Jan 8 2019, 10:39 AM
araujo committed rP489665: Reset the maintainership back to ports@ because I'm not using these.
Reset the maintainership back to ports@ because I'm not using these
Jan 8 2019, 10:30 AM
araujo accepted D18782: [new port] dns/py-bonjour: Python interface for mDNSResponder.
Jan 8 2019, 8:40 AM
araujo requested changes to D18782: [new port] dns/py-bonjour: Python interface for mDNSResponder.
Jan 8 2019, 8:29 AM
araujo accepted D18781: sysutils/py-consul: allow python 2.7 to be used.

LGTM

Jan 8 2019, 8:10 AM
araujo accepted D18780: sysutils/py-consul: update to 1.1.0.
Jan 8 2019, 5:00 AM
araujo requested changes to D18780: sysutils/py-consul: update to 1.1.0.

Version needs to be update to 1.1.0, John have spotted that already!!!!

Jan 8 2019, 4:59 AM
araujo accepted D18780: sysutils/py-consul: update to 1.1.0.
Jan 8 2019, 4:53 AM
araujo requested changes to D18780: sysutils/py-consul: update to 1.1.0.
Jan 8 2019, 4:01 AM
araujo closed D18776: Update sysutils/ipfs-go to allow IPFS_PATH to be set.

Don't forget to add the tag related with the review! When you add it, the review will be closed automatically.

Jan 8 2019, 2:51 AM
araujo accepted D18776: Update sysutils/ipfs-go to allow IPFS_PATH to be set.
Jan 8 2019, 1:18 AM

Jan 7 2019

araujo accepted D18766: audio/pianobar: update to 2018.06.22.
Jan 7 2019, 4:08 AM

Jan 6 2019

araujo closed D18751: www/minio-client: update to RELEASE.2018-12-27T00-37-49Z.

It was committed already, but for some reason the svn log tags were missed, so I'm closing it.

Jan 6 2019, 8:05 AM
araujo closed D18752: sysutils/ipfs-go: 0.14.7 -> 0.14.8.

It was committed already, but for some reason the svn log tags were missed, so I'm closing it.

Jan 6 2019, 8:05 AM
araujo updated the diff for D18744: Simplify capsicumization of bhyve..

Following @jhb suggestion, I will break down these updates in chunks.

Jan 6 2019, 7:13 AM

Jan 5 2019

araujo accepted D18752: sysutils/ipfs-go: 0.14.7 -> 0.14.8.

Just remove the portrevision before you commit it.

Jan 5 2019, 10:41 AM
araujo requested changes to D18752: sysutils/ipfs-go: 0.14.7 -> 0.14.8.
Jan 5 2019, 10:40 AM
araujo accepted D18751: www/minio-client: update to RELEASE.2018-12-27T00-37-49Z.

Lgtm!!

Jan 5 2019, 10:02 AM

Jan 4 2019

araujo added a reviewer for D18744: Simplify capsicumization of bhyve.: emaste.
Jan 4 2019, 1:14 PM
araujo added inline comments to D18744: Simplify capsicumization of bhyve..
Jan 4 2019, 1:13 PM
araujo added a comment to D18744: Simplify capsicumization of bhyve..

Smoke test built without CAPSICUM and CASPER. Ex.: "-DWITHOUT_CAPSICUM"

But all of the WITHOUT_CAPSICUM #ifdefs have been removed?

Jan 4 2019, 1:11 PM
araujo updated the summary of D18744: Simplify capsicumization of bhyve..
Jan 4 2019, 12:49 PM
araujo created D18744: Simplify capsicumization of bhyve..
Jan 4 2019, 12:45 PM

Jan 2 2019

araujo accepted D18703: Fix bhyve's NVMe Completion Queue entry values.

LGTM! Could you please set a MFC?

Jan 2 2019, 4:21 AM · bhyve
araujo added a reviewer for D18703: Fix bhyve's NVMe Completion Queue entry values: bhyve.
Jan 2 2019, 4:21 AM · bhyve
araujo accepted D18702: Fix bhyve's NVMe queue bookkeeping.
Jan 2 2019, 4:20 AM · bhyve
araujo added a reviewer for D18702: Fix bhyve's NVMe queue bookkeeping: bhyve.
Jan 2 2019, 4:20 AM · bhyve
araujo accepted D18702: Fix bhyve's NVMe queue bookkeeping.

LGTM! Do you mind set a MFC?

Jan 2 2019, 4:20 AM · bhyve

Dec 24 2018

araujo committed rP488257: Update to 2018.12.17..
Update to 2018.12.17.
Dec 24 2018, 6:07 AM
araujo committed rP488256: - Pet PORTLINT..
- Pet PORTLINT.
Dec 24 2018, 6:04 AM
araujo committed rP488255: Update to 1.0..
Update to 1.0.
Dec 24 2018, 5:59 AM

Dec 19 2018

araujo added a comment to D18578: OpenRC for FreeBSD.

I have asked @miwi to keep that huge patch on the review because of the lack of coordination and discussion between different groups and also because there is not a clear plan how to bring OpenRC into FreeBSD. So in that way people could try the patch easily without chasing different open reviews, and to be honest, without further discussion regarding to how the transition would happens between rcd and OpenRC, there is nothing much to review here.

Dec 19 2018, 3:45 PM
araujo added a comment to D12419: HD Audio Emulation For Bhyve (Based on D7840).

Hi @araujo, are there plans to move forward with this now that https://reviews.freebsd.org/rS340373 (libcasper: introduce cap_fileargs service) was commited?

Yes, definitely! I'm working on it, I got some issues with cap_fileargs and I have asked Mariuz support to help me debug the issue. But yeah, I'm on it right now!

Dec 19 2018, 6:29 AM

Dec 18 2018

araujo committed rS342184: MFC r340707:.
MFC r340707:
Dec 18 2018, 3:00 AM

Dec 17 2018

araujo requested changes to D18578: OpenRC for FreeBSD.

Email to developers and more discussion are necessary prior to move forward with this patch!

Dec 17 2018, 3:14 AM
araujo added a comment to D18578: OpenRC for FreeBSD.

As we have spoke in private 2 or 3 times already, I think you need to send an email as a RFC for developers@ list and/or freebsd-hackers! Add OpenRC on FreeBSD needs a broad discussion with developers and community.
Also we will need some documentation that are missing in this patch.

Dec 17 2018, 2:55 AM

Dec 16 2018

araujo added a comment to D18574: vmrun: Default to "vmnet"-style tap devices.

Hi guys,

...

One possible solution would be to give the options for users to choose between tap and vmnet style to be used and also document it (we can add some info on our bhyve wiki page)!

There already is a documented -t option that allows one to change this setting on the command line, it is in the usage() message. vmrun.sh is an example script and needs to die sooner, rather than later, with less effort spent on it and more effort on a new config file syntax that gets us out of using this "temporary" script.

Dec 16 2018, 11:50 AM
araujo requested changes to D18574: vmrun: Default to "vmnet"-style tap devices.

Hi guys,

Dec 16 2018, 3:06 AM

Dec 11 2018

araujo added a comment to D17874: libvmmapi: Separate MI from MD code.

Tested using the following guests:

  1. FreeBSD without UEFI - installation and then booting from disk file.
  2. Fedora 29 Workstation with grub2-bhyve - installation and then booting from disk file.
  3. FreeBSD with UEFI - installation and then booting from disk file.
  4. Fedora 29 Workstation with UEFI - installation and then booting from disk file.

    Commands used for testing can be found at github.

    Not tested:
  5. Windows guest - I don't have an iso image for Windows.
  6. PCI passthrough - not possible on my laptop.

Hi,

For the Windows guest, you can download a trial ISO that works for 90 days.
Usually I test Windows using these ISOs and it works great.

Dec 11 2018, 6:53 AM