- User Since
- May 10 2014, 4:51 AM (266 w, 2 d)
Thu, May 23
Apr 28 2019
Apr 24 2019
LGTM! Thank you!
Apr 19 2019
double accept this revision!
Apr 15 2019
Any news about this patch?
I'm fine with that too! We can have it as it is and later evolve it.
Apr 14 2019
- Also remove SHEBANGFIX not needed.
- Update ONLY_FOR_ARCHS that was replaced wrong.
Address @bcran suggestions!
Apr 10 2019
I did only smoke tests!! Do you mind do additional tests with different guests?
Apr 3 2019
It looks good! Thanks again @chuck
Mar 26 2019
Mar 23 2019
Mar 15 2019
Feb 22 2019
If anybody else is interested on this patch, ping me and I can share my latest changes. However I'm not interested on it anymore.
I have added @mav as a reviewer, I know he has worked with the hda drivers before.
Feb 8 2019
I still feel locked out of usr.sbin/bhyve, mostly of the commits made there in the past year were made by myself or reviewed by myself. Would be fair have my name explicit in that area, I don't want bypass reviews, it is more about the effort I have put in that area and appreciation of it, otherwise doesn't make sense for me to keep contributing with bhyve.
Feb 3 2019
Please, reopen the review, when I'm back from holidays I will help you.
Feb 1 2019
Jan 31 2019
It is basically a cosmetic change, so I have committed it already: r343634.
Jan 30 2019
Revert strnlen to strlen on pci_virtio_net as snprintf does the job already.
Jan 29 2019
The Makefile disappear :D
Missing MOVED entry!
Jan 28 2019
I will commit it in a few!
Thanks again and sorry my delay!
Jan 24 2019
It seems to be redundant py-python, I don't believe it is necessary to do it.
Jan 21 2019
Jan 18 2019
Jan 16 2019
Thanks for the patch, it looks right for me, although I don't have any AMD machine right now to make more tests.
I have only two requests and I would like to check with you if you could follow them:
- Give some more time for @jhb to also have a chance to take a look on this patch.
- When you commit it, please don't use the word "unfuck", just to avoid open room for people to have something to create noise.
Jan 15 2019
It doesn't looks quite right! I need more time to articulate better arguments, but this patch as it is, must not be committed in.