- User Since
- May 10 2014, 4:51 AM (291 w, 2 d)
Mon, Dec 2
Committed at: https://svnweb.freebsd.org/changeset/ports/518840
LGTM, gimme couple hours and I will commit it.
Tue, Nov 19
Nov 8 2019
@samm Can you move forward with this patch? The maintainer has timeout already.
Oct 30 2019
Oct 25 2019
So please, proceed to merge these two reviews and incorporate the submitter suggestions.
Oct 23 2019
Can we abandon this review in favor of the another one?
Oct 22 2019
LGTM, I will commit soon!!!
Oct 21 2019
Oct 19 2019
Oct 18 2019
Oct 17 2019
You should bump PORTREVISION to force package rebuild.
Oct 16 2019
For record only, accepting it from Fukushima, Japan!
Why bump PORTREVISION?
You don't need the gratuitous PORTREVISION bump here!
Oct 15 2019
Forgot to commit? Is there anything left to be reviewed?
Oct 14 2019
Do you use poudriere?
Oct 12 2019
You have two "right" options, choose wisely :)
Two separate commits makes it easier to write the history log and in case you need one day to make a revert, it will be more easier to identify the reason. But it is not mandatory, but it is what I have been doing since 2007.
Oct 11 2019
Sorry, I should have accepted it!!! But please wait for krion to approve it.
Thanks for that! You did right already!
Oct 10 2019
I came here from D21838 to say: looks good too!!! :)
Lgtm, thank you!
Oct 9 2019
You need to connect the new port on security/Makefile, seems it is missing from this diff.
It is a bit of nit picky from my side, but I don't see a reason for those changes, actually before was better, the files were in alphabetic order.
Did I miss something?
Oct 8 2019
Hey @dmgk, please proceed with the commit. You have my blessing.
Oct 1 2019
Sep 30 2019
Sep 27 2019
On this Port secteam isn't needed because your are the maintainer. The another case we will check who approves first maintainer or secteam. If none of them approves in couple days, we need to escalate to portmng.
Sep 26 2019
Ok, please open reviews for both of go and go-devel, we should commit the vuxml and both ports together, not mandatory, but nice to do.
Will we update go and go-devel ports? Do you need to sync anything with @jlaffaye?
Sep 25 2019
Sep 24 2019
Is it worth do an exp-run on this one too?
LGTM, same thing as the other reviews, wait for the exp-run and also for the portmgr approval.
LGTM, same thing, wait for the exp-run and portmgr approval.
It looks good to me, but you need to wait for the exp-run and also portmgr approval.
Thanks to work on this.
Sep 23 2019
This is cool, I didn't know it would be possible set version via ldflags.