Page MenuHomeFreeBSD

araujo (Marcelo Araujo)
User

Projects

User Details

User Since
May 10 2014, 4:51 AM (291 w, 2 d)

Recent Activity

Mon, Dec 2

araujo added a comment to D22615: net-mgmt/netdata: Update to 1.19.0.

Thanks!

Mon, Dec 2, 9:57 AM
araujo closed D22045: net-mgmt/netdata: upgrade to 1.18.1.

Committed at: https://svnweb.freebsd.org/changeset/ports/518840

Mon, Dec 2, 9:56 AM
araujo commandeered D22045: net-mgmt/netdata: upgrade to 1.18.1.

Taking it.

Mon, Dec 2, 9:56 AM
araujo committed rP518841: - Update to 2019.11.28..
- Update to 2019.11.28.
Mon, Dec 2, 9:55 AM
araujo committed rP518840: - Update to 1.19.0..
- Update to 1.19.0.
Mon, Dec 2, 9:53 AM
araujo closed D22615: net-mgmt/netdata: Update to 1.19.0.
Mon, Dec 2, 9:53 AM
araujo accepted D22615: net-mgmt/netdata: Update to 1.19.0.

LGTM, gimme couple hours and I will commit it.

Mon, Dec 2, 7:17 AM

Tue, Nov 19

araujo committed rP517937: Release Dmitri Goutnik (dmgk) from mentorship, he is more than ready.
Release Dmitri Goutnik (dmgk) from mentorship, he is more than ready
Tue, Nov 19, 1:20 AM

Nov 8 2019

araujo added a comment to D22045: net-mgmt/netdata: upgrade to 1.18.1.

@samm Can you move forward with this patch? The maintainer has timeout already.

Nov 8 2019, 12:44 AM

Oct 30 2019

araujo accepted D22190: security/aws-vault: Update to 4.7.1.
Oct 30 2019, 3:15 PM

Oct 25 2019

araujo accepted D22149: shells/elvish: Set version information, omit debug info.
Oct 25 2019, 1:52 AM
araujo added a comment to D22045: net-mgmt/netdata: upgrade to 1.18.1.

So please, proceed to merge these two reviews and incorporate the submitter suggestions.

Oct 25 2019, 1:51 AM
araujo added a comment to D22045: net-mgmt/netdata: upgrade to 1.18.1.
In D22045#483993, @samm wrote:

@samm Could you double check with @daniel.engberg.lists_pyret.net the changes that he is proposing and perhaps after that we can close the D21969 review?
A single place makes more sense, however @daniel.engberg.lists_pyret.net opened the review first, so technically he will receive the credits for the patch submission. I just want a single review for this port update.
Best Regards,

Hi, i am perfectly fine to give him credits and merge the patches. Main problem is that there is no feedback from the maintainer. What should we do to get this done?

Oct 25 2019, 1:48 AM

Oct 23 2019

araujo added a comment to D21969: net-mgmt/netdata: Update to 1.18.1.

Sure, but I think it's a discouraging way to handle submissions in terms of chronological order.

Oct 23 2019, 9:07 AM
araujo requested changes to D22045: net-mgmt/netdata: upgrade to 1.18.1.

@samm Could you double check with @daniel.engberg.lists_pyret.net the changes that he is proposing and perhaps after that we can close the D21969 review?

Oct 23 2019, 8:55 AM
araujo added a comment to D21969: net-mgmt/netdata: Update to 1.18.1.

At least fix the issues reported in that case?

Oct 23 2019, 8:51 AM
araujo added a comment to D21969: net-mgmt/netdata: Update to 1.18.1.

Can we abandon this review in favor of the another one?

Oct 23 2019, 8:38 AM
araujo accepted D22092: devel/goswagger: Update to 0.21.0.
Oct 23 2019, 8:35 AM
araujo accepted D22105: www/gohugo: Update to 0.59.0.
Oct 23 2019, 8:35 AM

Oct 22 2019

araujo awarded Dev Summit Attendee to recipient: araujo.
Oct 22 2019, 8:53 AM
araujo accepted D22098: ports-mgmt/modules2tuple: Update to 1.9.0.
Oct 22 2019, 3:56 AM
araujo accepted D22097: databases/pgbouncer: Update to 1.12.0.
Oct 22 2019, 3:56 AM
araujo closed D22102: Update sysutils/go-wtf to version 0.23.
Oct 22 2019, 3:05 AM
araujo committed rP515166: - Update to 0.23..
- Update to 0.23.
Oct 22 2019, 3:05 AM
araujo accepted D22102: Update sysutils/go-wtf to version 0.23.

LGTM, I will commit soon!!!

Oct 22 2019, 2:35 AM

Oct 21 2019

araujo committed rP515095: Update to 2019.10.16..
Update to 2019.10.16.
Oct 21 2019, 10:04 AM
araujo committed rP515091: - Set OPTIONS_DEFAULT to devel/git instead of devel/git-lite..
- Set OPTIONS_DEFAULT to devel/git instead of devel/git-lite.
Oct 21 2019, 9:13 AM
araujo committed rP515086: - Fix git/git-lite dependencies..
- Fix git/git-lite dependencies.
Oct 21 2019, 7:13 AM
araujo committed rP515084: - Fix git/git-lite dependencies as well as leftover EGG files..
- Fix git/git-lite dependencies as well as leftover EGG files.
Oct 21 2019, 6:25 AM
araujo closed D21929: sysutils/iocage - Fix git/git-lite dependencies as well as leftover EGG files..
Oct 21 2019, 6:25 AM

Oct 19 2019

araujo accepted D22058: x11/wmutils-core: Update to 1.5.

Lgtm!

Oct 19 2019, 11:52 PM

Oct 18 2019

araujo accepted D22078: www/gobuffalo: Update to 0.14.11.
Oct 18 2019, 11:01 PM
araujo accepted D22079: databases/pspg: Update to 2.1.8.
Oct 18 2019, 11:00 PM
araujo accepted D22080: lang/go-devel: Update to g20191017 (go1.13.3).
Oct 18 2019, 11:00 PM

Oct 17 2019

araujo accepted D22066: sysutils/busybox: fix the build.

You should bump PORTREVISION to force package rebuild.

Oct 17 2019, 8:13 AM

Oct 16 2019

araujo added a comment to D22051: x11-fm/filerunner : Update MAINTAINER.
In D22051#481744, @dmgk wrote:

The PHB seems to say otherwise:

PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way.

Changing MAINTAINER does change package metadata (and the generated package as a consequence) and according to the above, needs a PORTREVISION bump. But looking at the svn logs, nobody deems this change "important enough" to warrant a rebuild :)

Oct 16 2019, 2:17 PM
araujo accepted D22051: x11-fm/filerunner : Update MAINTAINER.

For record only, accepting it from Fukushima, Japan!

Oct 16 2019, 12:20 PM
araujo accepted D22047: print/a2pdf : Update MAINTAINER.
Oct 16 2019, 12:19 PM
araujo requested changes to D22047: print/a2pdf : Update MAINTAINER.

Why bump PORTREVISION?

Oct 16 2019, 9:15 AM
araujo requested changes to D22051: x11-fm/filerunner : Update MAINTAINER.

You don't need the gratuitous PORTREVISION bump here!

Oct 16 2019, 9:13 AM

Oct 15 2019

araujo added a comment to D22022: sysutils/busybox: update to the 1.31.0 version.

Forgot to commit? Is there anything left to be reviewed?

Oct 15 2019, 11:36 PM

Oct 14 2019

araujo added a comment to D22022: sysutils/busybox: update to the 1.31.0 version.
In D22022#481030, @samm wrote:

Thank you for feedback!

Yes, i am using it already

You must always test the changes using it, also when you open a review, you should fullfil the test area saying at least something like:
poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r348350 amd64 + i386) -> OK
portlint and portclippy -> OK
Runtime tests -> OK

Ok, was not aware of this, will do from the next submission. Only problem is that host for the poudriere is now running on 11.3, so 12+ tests will fail.
And will think how to automate all the process...
Probably will setup bhyve vm on 12+ to do the tests or will upgrade this host.

Oct 14 2019, 4:22 PM
araujo accepted D22022: sysutils/busybox: update to the 1.31.0 version.

Do you use poudriere?
https://www.freebsd.org/doc/handbook/ports-poudriere.html

Oct 14 2019, 4:11 PM
araujo accepted D22018: dns/inadyn, net-mgmt/flowviewer, sysutils/smartmontools: update homepage URL.
Oct 14 2019, 7:56 AM

Oct 12 2019

araujo added a comment to D22000: security/botan2: Update to 2.12.0.

You have two "right" options, choose wisely :)

Oct 12 2019, 11:58 PM
araujo added a comment to D22000: security/botan2: Update to 2.12.0.

Two separate commits makes it easier to write the history log and in case you need one day to make a revert, it will be more easier to identify the reason. But it is not mandatory, but it is what I have been doing since 2007.

Oct 12 2019, 11:01 PM
araujo accepted D21981: databases/pspg: Update to 2.1.7.
Oct 12 2019, 12:44 PM
araujo accepted D21991: www/gitea: Update to 1.9.4.
Oct 12 2019, 12:30 PM
araujo accepted D21985: Add samm to committers-ports.dot and calendar.freebsd.
Oct 12 2019, 9:48 AM
araujo accepted D21986: Add samm to freebsd.commiters.markers.
Oct 12 2019, 9:47 AM

Oct 11 2019

araujo added inline comments to D21985: Add samm to committers-ports.dot and calendar.freebsd.
Oct 11 2019, 10:48 PM
araujo accepted D21977: Add samm as a ports committer.

Sorry, I should have accepted it!!! But please wait for krion to approve it.

Oct 11 2019, 8:20 AM
araujo requested changes to D21977: Add samm as a ports committer.

Thanks for that! You did right already!

Oct 11 2019, 8:19 AM

Oct 10 2019

araujo added a comment to D21837: bhyve: refactor NVMe PRP memcpy.

I came here from D21838 to say: looks good too!!! :)

Oct 10 2019, 11:52 PM
araujo accepted D21838: bhyve: refactor NVMe namespace initialization.

Lgtm, thank you!

Oct 10 2019, 11:50 PM
araujo accepted D21839: bhyve: implement NVMe deallocate command.

Lgtm

Oct 10 2019, 11:43 PM

Oct 9 2019

araujo added a comment to D21955: New port: security/aws-vault: Vault for securely storing and accessing AWS credentials.
In D21955#479672, @dmgk wrote:

Hook to the build.

Oct 9 2019, 4:02 PM
araujo accepted D21955: New port: security/aws-vault: Vault for securely storing and accessing AWS credentials.
Oct 9 2019, 3:56 PM
araujo accepted D21957: security/lego: Update to 3.1.0.
Oct 9 2019, 3:50 PM
araujo added a comment to D21955: New port: security/aws-vault: Vault for securely storing and accessing AWS credentials.
In D21955#479658, @dmgk wrote:

You need to connect the new port on security/Makefile, seems it is missing from this diff.

But I was asked to use addport for this by @tz - https://reviews.freebsd.org/D21780?id=62505#inline-136019
So what should I use? :)

Oct 9 2019, 3:49 PM
araujo requested changes to D21955: New port: security/aws-vault: Vault for securely storing and accessing AWS credentials.

You need to connect the new port on security/Makefile, seems it is missing from this diff.

Oct 9 2019, 3:16 PM
araujo accepted D21956: databases/pspg: Update to 2.1.4.
Oct 9 2019, 3:14 PM
araujo requested changes to D21957: security/lego: Update to 3.1.0.

It is a bit of nit picky from my side, but I don't see a reason for those changes, actually before was better, the files were in alphabetic order.
Did I miss something?

Oct 9 2019, 3:14 PM
araujo committed rP514165: Welcome Oleksii Samorukov (samm@) to the rank of ports committer..
Welcome Oleksii Samorukov (samm@) to the rank of ports committer.
Oct 9 2019, 2:55 PM

Oct 8 2019

araujo accepted D21941: devel/packr: Update to 2.7.1.
Oct 8 2019, 3:08 PM
araujo added a comment to D21929: sysutils/iocage - Fix git/git-lite dependencies as well as leftover EGG files..

This solves my problem as far as I am concerned. Maybe it's worth thinking about this tuning globally since we have more than 50 ports depending on devel/git and I am pretty sure most of these ports would be functional with devel/git-lite. By defaulting to devel/git-lite, you make it impossible to use both one of there 50+ ports and sysutils/iocage, which might be a problem? I am not sure about what is the best solution, so I will stick to a LGTM for now :-)

Oct 8 2019, 7:40 AM
araujo committed rP514026: - Update to 2019.09.28..
- Update to 2019.09.28.
Oct 8 2019, 3:44 AM
araujo updated the summary of D21929: sysutils/iocage - Fix git/git-lite dependencies as well as leftover EGG files..
Oct 8 2019, 3:07 AM
araujo created D21929: sysutils/iocage - Fix git/git-lite dependencies as well as leftover EGG files..
Oct 8 2019, 2:14 AM
araujo added a comment to D21854: Bump PORTREVISION for D21730.
In D21854#479049, @dmgk wrote:

Hey @dmgk, please proceed with the commit. You have my blessing.

Thanks, I asked for an exp-run (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240986) and will commit as soon as it passes.

Oct 8 2019, 2:01 AM
araujo added a comment to D21854: Bump PORTREVISION for D21730.

Hey @dmgk, please proceed with the commit. You have my blessing.

Oct 8 2019, 12:55 AM
araujo accepted D21917: misc/nnn: Update to 2.7.
Oct 8 2019, 12:39 AM

Oct 1 2019

araujo accepted D21856: databases/pspg: Update to 2.1.3.
Oct 1 2019, 2:24 PM
araujo added a comment to D21854: Bump PORTREVISION for D21730.
In D21854#477434, @dmgk wrote:

LGTM!

Do I need to get portmgr approval for this or it's OK to commit along with https://reviews.freebsd.org/D21730?

Oct 1 2019, 2:23 PM
araujo accepted D21854: Bump PORTREVISION for D21730.

LGTM!

Oct 1 2019, 6:05 AM
araujo committed rP513454: - Drop support for devel/dulwich. [0].
- Drop support for devel/dulwich. [0]
Oct 1 2019, 5:49 AM

Sep 30 2019

araujo committed rP513279: - Update necessary dependencies for iocage 1.2 release..
- Update necessary dependencies for iocage 1.2 release.
Sep 30 2019, 2:51 AM
araujo added a comment to D21744: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. sysutils-x11).
In D21744#477011, @dmgk wrote:

That's fair. However, this review is a sweeping change of all go ports to meet a specific, consistent standard, suggesting that the plurality of ports were doing things in a suboptimal way. IMO the PHB should demonstrate what the ports should and should not be doing.

Makes sense. Perhaps it would be useful to have a list of "best practices" for creating Go ports. I'll extend the "Building Go Applications" section and post a doc review.

Sep 30 2019, 1:16 AM

Sep 27 2019

araujo added a comment to D21819: ports-mgmt/modules2tuple: Update to 1.8.2.
In D21819#476317, @dmgk wrote:

Looks like svn ate "Changes:" line in the commit message, sorry about that. Is it some kind a reserved keyword? Should I use "Changelog" or similar for itemized changes list?

Sep 27 2019, 3:39 PM
araujo accepted D21819: ports-mgmt/modules2tuple: Update to 1.8.2.
Sep 27 2019, 2:57 PM
araujo committed rP512999: - Update to 1.2..
- Update to 1.2.
Sep 27 2019, 2:30 AM
araujo added a comment to D21808: lang/go-devel: Update to g20190925 (go1.13.1).

On this Port secteam isn't needed because your are the maintainer. The another case we will check who approves first maintainer or secteam. If none of them approves in couple days, we need to escalate to portmng.

Sep 27 2019, 12:18 AM

Sep 26 2019

araujo accepted D21809: lang/go: Update to 1.13.1.

ports secteam any of you could approve? @dmgk add ports_secteam group in the review too.

Sep 26 2019, 11:53 PM
araujo accepted D21808: lang/go-devel: Update to g20190925 (go1.13.1).
Sep 26 2019, 11:46 PM
araujo accepted D21802: security/vuxml: Add entry for lang/go and lang/go-devel CVE-2019-16276.

Ok, please open reviews for both of go and go-devel, we should commit the vuxml and both ports together, not mandatory, but nice to do.

Sep 26 2019, 3:52 PM
araujo updated subscribers of D21802: security/vuxml: Add entry for lang/go and lang/go-devel CVE-2019-16276.

Will we update go and go-devel ports? Do you need to sync anything with @jlaffaye?

Sep 26 2019, 3:29 PM
araujo accepted D21799: databases/pspg: Update to 2.1.2.
Sep 26 2019, 12:26 PM

Sep 25 2019

araujo accepted D21793: dns/knot-resolver: Remove redundant lang/go build dependency.
Sep 25 2019, 10:23 PM

Sep 24 2019

araujo accepted D21730: Mk/Uses/go.mk: Omit symbol table and debug information by default.

Is it worth do an exp-run on this one too?

Sep 24 2019, 2:02 AM
araujo accepted D21743: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. misc-shells).

LGTM, same thing as the other reviews, wait for the exp-run and also for the portmgr approval.

Sep 24 2019, 1:58 AM
araujo accepted D21744: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. sysutils-x11).

LGTM, same thing, wait for the exp-run and portmgr approval.

Sep 24 2019, 1:50 AM
araujo accepted D21741: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. audio-mail).

It looks good to me, but you need to wait for the exp-run and also portmgr approval.
Thanks to work on this.

Sep 24 2019, 1:44 AM

Sep 23 2019

araujo accepted D21771: www/gitea: Use linker flags to set version instead of patching the source..

This is cool, I didn't know it would be possible set version via ldflags.

Sep 23 2019, 10:52 PM
araujo added a comment to D21730: Mk/Uses/go.mk: Omit symbol table and debug information by default.
In D21730#475087, @dmgk wrote:

IIUC this potentially changes all Go binaries, so all USES=go ports that do not set ldflags themselves probably need a PORTREVISION bump afterwards to relink them?

A quick search

for f in $(find /usr/ports -name Makefile | xargs grep -l 'USES=.*\bgo\b'); do grep -q '\bldflags\b' $f || echo $f; done | wc -l

shows that it would require bumping PORTREVISION of 198 ports. Recompiling will make binaries about 25% smaller on average but there are no other functional changes. I can prepare a separate review if we're OK with this.

Sep 23 2019, 10:49 PM
araujo accepted D21735: www/gohugo: Update for D21730.
Sep 23 2019, 7:59 PM

Sep 22 2019

araujo accepted D21751: editors/dte: Update to 1.9.
Sep 22 2019, 1:38 PM
araujo accepted D21748: databases/pspg: Update to 2.0.4.
Sep 22 2019, 1:37 PM

Sep 20 2019

araujo added a comment to D21721: USES=go ports: cleanup, make use of the new GO_TARGET tuple syntax.
In D21721#474028, @dmgk wrote:

As you are working on this already for a while, how about ports that you are not a maintainer? Maybe an exp-run following with a portmgr@ approval would be interesting to clean up the rest of the ports.

That was my plan actually, I was just not sure what would be the best way to get something like that reviewed/committed. The complete diff is about 250KB, I was thinking about maybe breaking it to 3-4 parts for easier review. Would that make sense or it would be better to post it in a single review?

Sep 20 2019, 12:23 PM
araujo accepted D21721: USES=go ports: cleanup, make use of the new GO_TARGET tuple syntax.
In D21721#473887, @dmgk wrote:
In D21721#473870, @tz wrote:

Since i am very unfamiliar with the go ports, i have problems to understand this diff.
In devel/awless only do-build and do-install is removed, but i do not see any usage of GO_TARGET. Same for some other ports.

r505321 converted all ports to USES=go which already provides do-build and do-install targets. During that conversion, ports that were defining their own build/install targets were left alone to be cleaned up later. This commit does this cleanup for the ports that I maintain.

Sep 20 2019, 2:05 AM

Sep 19 2019

araujo accepted D21716: security/botan2: Update to 2.11.0.

You should do two commits for this review, first commit security/botan2 and then commit the BUMP for the other ports that depends of security/botan2.

Sep 19 2019, 2:39 PM