Page MenuHomeFreeBSD

araujo (Marcelo Araujo)
User

Projects

User Details

User Since
May 10 2014, 4:51 AM (240 w, 2 d)

Recent Activity

Today

araujo requested changes to D18578: OpenRC for FreeBSD.

Email to developers and more discussion are necessary prior to move forward with this patch!

Mon, Dec 17, 3:14 AM
araujo added a comment to D18578: OpenRC for FreeBSD.

As we have spoke in private 2 or 3 times already, I think you need to send an email as a RFC for developers@ list and/or freebsd-hackers! Add OpenRC on FreeBSD needs a broad discussion with developers and community.
Also we will need some documentation that are missing in this patch.

Mon, Dec 17, 2:55 AM

Yesterday

araujo added a comment to D18574: vmrun: Default to "vmnet"-style tap devices.

Hi guys,

...

One possible solution would be to give the options for users to choose between tap and vmnet style to be used and also document it (we can add some info on our bhyve wiki page)!

There already is a documented -t option that allows one to change this setting on the command line, it is in the usage() message. vmrun.sh is an example script and needs to die sooner, rather than later, with less effort spent on it and more effort on a new config file syntax that gets us out of using this "temporary" script.

Sun, Dec 16, 11:50 AM
araujo requested changes to D18574: vmrun: Default to "vmnet"-style tap devices.

Hi guys,

Sun, Dec 16, 3:06 AM

Tue, Dec 11

araujo added a comment to D17874: libvmmapi: Separate MI from MD code.

Tested using the following guests:

  1. FreeBSD without UEFI - installation and then booting from disk file.
  2. Fedora 29 Workstation with grub2-bhyve - installation and then booting from disk file.
  3. FreeBSD with UEFI - installation and then booting from disk file.
  4. Fedora 29 Workstation with UEFI - installation and then booting from disk file.

    Commands used for testing can be found at github.

    Not tested:
  5. Windows guest - I don't have an iso image for Windows.
  6. PCI passthrough - not possible on my laptop.

Hi,

For the Windows guest, you can download a trial ISO that works for 90 days.
Usually I test Windows using these ISOs and it works great.

Tue, Dec 11, 6:53 AM
araujo added a comment to D17874: libvmmapi: Separate MI from MD code.

Tested using the following guests:

  1. FreeBSD without UEFI - installation and then booting from disk file.
  2. Fedora 29 Workstation with grub2-bhyve - installation and then booting from disk file.
  3. FreeBSD with UEFI - installation and then booting from disk file.
  4. Fedora 29 Workstation with UEFI - installation and then booting from disk file.

    Commands used for testing can be found at github.

    Not tested:
  5. Windows guest - I don't have an iso image for Windows.
  6. PCI passthrough - not possible on my laptop.
Tue, Dec 11, 6:47 AM
araujo accepted D18504: Allow CTL device specification in bhyve virtio-scsi.

LGTM! Thanks for the patch!

Tue, Dec 11, 5:05 AM · bhyve

Sun, Dec 9

araujo committed rS341761: MFC r340211:.
MFC r340211:
Sun, Dec 9, 6:51 AM
araujo committed rS341758: MFC r340046, r340050.
MFC r340046, r340050
Sun, Dec 9, 6:44 AM
araujo committed rS341757: MFC r340046, r340050.
MFC r340046, r340050
Sun, Dec 9, 6:44 AM

Fri, Dec 7

araujo accepted D18465: Several iov handling bugs in bhyve virtio-scsi backend.

Lgtm!

Fri, Dec 7, 7:25 PM
araujo edited reviewers for D18465: Several iov handling bugs in bhyve virtio-scsi backend, added: bhyve; removed: wg.
Fri, Dec 7, 5:01 AM

Tue, Dec 4

araujo committed rP486589: Update to 2018.12.03..
Update to 2018.12.03.
Tue, Dec 4, 9:20 AM

Sun, Dec 2

araujo added a comment to D12419: HD Audio Emulation For Bhyve (Based on D7840).

Hi @araujo, are there plans to move forward with this now that https://reviews.freebsd.org/rS340373 (libcasper: introduce cap_fileargs service) was commited?

Sun, Dec 2, 8:59 AM

Tue, Nov 20

araujo abandoned D17711: vbsc_ident buffer accessed out of bounds..

Committed at: r340707

Tue, Nov 20, 10:22 PM
araujo committed rS340707: Define AHCI_PORT_IDENT and increase by 1 the VTBLK_BLK_ID_BYTES.
Define AHCI_PORT_IDENT and increase by 1 the VTBLK_BLK_ID_BYTES
Tue, Nov 20, 10:21 PM
araujo added inline comments to D17874: libvmmapi: Separate MI from MD code.
Tue, Nov 20, 10:02 PM
araujo added a comment to D17874: libvmmapi: Separate MI from MD code.

The only test I did for the patch was to compile the source code. When the patch code is stabilized I will try to do a proper test by running a virtual machine with bhyve.

Tue, Nov 20, 10:00 PM

Nov 17 2018

araujo added a comment to D2838: Add on bhyvectl the capability to list the running vms..

still pursuing this change?

Nov 17 2018, 1:08 AM

Nov 7 2018

araujo committed rP484389: - Update to 0.2..
- Update to 0.2.
Nov 7 2018, 6:40 AM
araujo closed D17778: Update sysutils/uefi-edk2-bhyve to 0.2..
Nov 7 2018, 6:40 AM
araujo requested changes to D17874: libvmmapi: Separate MI from MD code.

Also there are lots of style(9) issues!
@alexandru.elisei_gmail.com could you please first address @rgrimes comment and then we can do the review including the style(9) issues that need to be fixed too?

Nov 7 2018, 6:35 AM
araujo closed D17795: Cosmetic changes to try to inline the memset with SSE/AVX instructions..
Nov 7 2018, 6:29 AM
araujo committed rS340211: Comestic change to try to inline the memset with SSE/AVX instructions..
Comestic change to try to inline the memset with SSE/AVX instructions.
Nov 7 2018, 6:29 AM
araujo committed rS340210: Revert my bogus attempt to silence coverity on r340045, it created.
Revert my bogus attempt to silence coverity on r340045, it created
Nov 7 2018, 4:20 AM
araujo added a reviewer for D17874: libvmmapi: Separate MI from MD code: bhyve.
Nov 7 2018, 1:51 AM

Nov 6 2018

araujo requested changes to D17848: Update review requests for bhyve..

After reflect a little bit more about what @rgrimes mentioned, how about we do something like this?

Nov 6 2018, 3:53 AM

Nov 5 2018

araujo added a comment to D17848: Update review requests for bhyve..

This is good, but it is not clear on *who* can approve as bhyve, in the past that was Peter, is it now jhb & tychon, or anyone who just happens to join the bhyve group, which is not controller.

Nov 5 2018, 6:26 PM
araujo accepted D17848: Update review requests for bhyve..

Sounds reasonable!

Nov 5 2018, 6:01 PM
araujo removed a watcher for bhyve: araujo.
Nov 5 2018, 5:57 PM
araujo added a watcher for bhyve: araujo.
Nov 5 2018, 5:56 PM
araujo added a comment to D17795: Cosmetic changes to try to inline the memset with SSE/AVX instructions..

ping!

Nov 5 2018, 9:03 AM
araujo added a comment to D17778: Update sysutils/uefi-edk2-bhyve to 0.2..

ping!

Nov 5 2018, 9:03 AM

Nov 2 2018

araujo committed rS340050: Remove printf for debug purpose forgotten on r340046..
Remove printf for debug purpose forgotten on r340046.
Nov 2 2018, 1:48 PM
araujo abandoned D17712: ps/2 scancodes for NumLock, ScrollLock and numerical keypad keys..

Committed already: https://svnweb.freebsd.org/changeset/base/340046

Nov 2 2018, 8:29 AM
araujo committed rS340046: Add support ps/2 scancodes for NumLock, ScrollLock and numerical keypad.
Add support ps/2 scancodes for NumLock, ScrollLock and numerical keypad
Nov 2 2018, 8:28 AM
araujo committed rS340045: Fix resource leak when using strdup(3)..
Fix resource leak when using strdup(3).
Nov 2 2018, 8:03 AM
araujo committed rS340044: Fix resource leak when using strdup(3)..
Fix resource leak when using strdup(3).
Nov 2 2018, 8:01 AM
araujo committed rS340043: Fix resource leak, variable fd going out of scope..
Fix resource leak, variable fd going out of scope.
Nov 2 2018, 7:59 AM
araujo committed rS340042: Fix resource leak, variables cp, xopts and nopt going out of scope..
Fix resource leak, variables cp, xopts and nopt going out of scope.
Nov 2 2018, 7:57 AM
araujo accepted D17815: - Add quirk for Samsung on Mac Mini 7,1.

LGTM!

Nov 2 2018, 7:42 AM
araujo abandoned D17759: Fix a potential overflows on cpywithpad function..

Close in favor of: https://reviews.freebsd.org/D17795

Nov 2 2018, 6:04 AM
araujo reclaimed D17778: Update sysutils/uefi-edk2-bhyve to 0.2..

Ops, abandoned the wrong review... Sorry!

Nov 2 2018, 6:03 AM
araujo added inline comments to D17795: Cosmetic changes to try to inline the memset with SSE/AVX instructions..
Nov 2 2018, 2:02 AM
araujo added a reviewer for D17795: Cosmetic changes to try to inline the memset with SSE/AVX instructions.: brooks.
Nov 2 2018, 2:02 AM
araujo updated the diff for D17795: Cosmetic changes to try to inline the memset with SSE/AVX instructions..

Address the memset according with the suggestion made by @jhb.

Nov 2 2018, 2:02 AM

Nov 1 2018

araujo abandoned D17778: Update sysutils/uefi-edk2-bhyve to 0.2..

Close in favor of: https://reviews.freebsd.org/D17795

Nov 1 2018, 8:08 AM
araujo added reviewers for D17795: Cosmetic changes to try to inline the memset with SSE/AVX instructions.: jhb, bhyve.
Nov 1 2018, 8:07 AM
araujo created D17795: Cosmetic changes to try to inline the memset with SSE/AVX instructions..
Nov 1 2018, 8:06 AM
araujo added inline comments to D17778: Update sysutils/uefi-edk2-bhyve to 0.2..
Nov 1 2018, 4:49 AM
araujo updated the diff for D17778: Update sysutils/uefi-edk2-bhyve to 0.2..

Tag release to 2.0.

Nov 1 2018, 4:48 AM

Oct 31 2018

araujo updated the summary of D17778: Update sysutils/uefi-edk2-bhyve to 0.2..
Oct 31 2018, 6:39 AM
araujo created D17778: Update sysutils/uefi-edk2-bhyve to 0.2..
Oct 31 2018, 6:37 AM
araujo added inline comments to D17713: AMD - emulate Extended CPUID Features override..
Oct 31 2018, 1:28 AM
araujo committed rS339936: Merge cases with upper block..
Merge cases with upper block.
Oct 31 2018, 1:28 AM
araujo added a comment to D17759: Fix a potential overflows on cpywithpad function..
In D17759#379608, @jhb wrote:

I agree with @brooks that the current patch is a no-op as it is just re-computing 'strnlen' and then discarding the result.

That said, if you rewrote it to use memset of the static size first the compiler will probably inline the memset with SSE/AVX instructions and be faster than the current code. Something like:

size_t len;
 
len = strnlen(src, dst_size);
memset(dst, pad, dst_size);
memcpy(dst, src, len);

I would also probably make 'dst_size' a size_t. However, it would also be fine to just drop the current patch as the existing code works.

Oct 31 2018, 1:18 AM
araujo added a comment to D17759: Fix a potential overflows on cpywithpad function..

What ever overflow I thought I saw doesn't appear to exist when I read the code now. len is always <= dst_size so the memset is safe.

I don't know what the loop is attempting to do, but all it does is compute i = MIN(strlen(src)+1, dst_size) and then i isn't used.

The only real issue I can see with this code is that pad should probably be an int like c is in memset and that's mostly theoretical.

Oct 31 2018, 1:17 AM

Oct 30 2018

araujo added reviewers for D17759: Fix a potential overflows on cpywithpad function.: brooks, bhyve.
Oct 30 2018, 10:16 AM
araujo created D17759: Fix a potential overflows on cpywithpad function..
Oct 30 2018, 10:16 AM
araujo committed rS339911: Emulate machine check related MSR_EXTFEATURES to allow guest OSes to.
Emulate machine check related MSR_EXTFEATURES to allow guest OSes to
Oct 30 2018, 10:02 AM
araujo closed D17713: AMD - emulate Extended CPUID Features override..
Oct 30 2018, 10:02 AM
araujo committed rS339909: Allow changing lagg(4) MTU..
Allow changing lagg(4) MTU.
Oct 30 2018, 9:54 AM
araujo closed D17576: Allow changing lagg(4) MTU.
Oct 30 2018, 9:54 AM · network

Oct 27 2018

araujo added a comment to D16805: Turn back the clock just a little: make userboot.so always be 4th.

Hi @imp is there anything pending to commit this patch?

Oct 27 2018, 3:49 AM
araujo added a comment to D16913: vmrun: add -x flag to always exit when bhyve exists.

Hi @allanjude is there anything pending to move this patch forward?

Oct 27 2018, 3:48 AM
araujo added a comment to D17531: bhyve: provide basic descriptions for VMX exit reason.

Hi @yuripv , is there anything pending for this patch to be committed?

Oct 27 2018, 3:48 AM
araujo added a comment to D2838: Add on bhyvectl the capability to list the running vms..

Proposal: Rename the current bhyvectl code to bhyvedbg, and create a new bhyvectl that has --create, --destory and --list. This could also be the tool to do the bhyvectl --addcpu, --addmemory, --adddisk, etc, etc. This is just a random braincell firing of an idea, anyone and everyone can ignore as they see fit.

Oct 27 2018, 2:49 AM

Oct 26 2018

araujo added a comment to D2838: Add on bhyvectl the capability to list the running vms..

I shall re assert my earlier concern that we want to keep bhyvectl purely as a debugging tool, and not start to clutter it with stuff that is not part of that. Yes, there is the use of --destroy by others, but that is and should be the exception rather than the norm.

Oct 26 2018, 2:15 PM
araujo added a reviewer for D2838: Add on bhyvectl the capability to list the running vms.: bhyve.
Oct 26 2018, 12:14 PM
araujo added a reviewer for D15473: Add on bhyverun a new option '-B' that gives the capability to change the smbios table type1 using an ucl based configuration file.: bhyve.
Oct 26 2018, 12:13 PM
araujo added a reviewer for D17713: AMD - emulate Extended CPUID Features override.: bhyve.
Oct 26 2018, 11:42 AM
araujo created D17713: AMD - emulate Extended CPUID Features override..
Oct 26 2018, 11:42 AM
araujo updated the diff for D17712: ps/2 scancodes for NumLock, ScrollLock and numerical keypad keys..

s/company/keypads/g

Oct 26 2018, 11:33 AM
araujo added a reviewer for D17712: ps/2 scancodes for NumLock, ScrollLock and numerical keypad keys.: bhyve.
Oct 26 2018, 11:31 AM
araujo created D17712: ps/2 scancodes for NumLock, ScrollLock and numerical keypad keys..
Oct 26 2018, 11:31 AM
araujo added a reviewer for D17711: vbsc_ident buffer accessed out of bounds.: bhyve.
Oct 26 2018, 11:27 AM
araujo created D17711: vbsc_ident buffer accessed out of bounds..
Oct 26 2018, 11:26 AM
araujo edited reviewers for D2448: give bhyve the ability to parse a libucl guest configuration file, added: jhb, tychon; removed: grehan, neel.
Oct 26 2018, 9:53 AM
araujo removed a reviewer for D2448: give bhyve the ability to parse a libucl guest configuration file: 0mp.
Oct 26 2018, 9:52 AM
araujo added a comment to D2448: give bhyve the ability to parse a libucl guest configuration file.
In D2448#378445, @0mp wrote:

Just to be sure: the usage function mentions that the configuration file is in the UCL format but it is not mentioned anywhere in the manual page.

Am I missing something or the format of the configuration file is not yet documented?

Oct 26 2018, 9:50 AM
araujo added a comment to D12419: HD Audio Emulation For Bhyve (Based on D7840).

Just a hands up, this patch needs the following patches:

Oct 26 2018, 4:14 AM
araujo added a comment to D14407: Introduce cap_fileargs..

Any news about this patch? I need it to be able to finish this review: https://reviews.freebsd.org/D12419

Oct 26 2018, 4:14 AM
araujo commandeered D2448: give bhyve the ability to parse a libucl guest configuration file.

I have spoke with @allanjude about it, we at bhyve group are discussing this topic again and we will become with a new format for the configuration file.
So, I'm commandeer this revision again!

Oct 26 2018, 3:04 AM

Oct 16 2018

araujo added inline comments to D17576: Allow changing lagg(4) MTU.
Oct 16 2018, 10:03 AM · network
araujo accepted D17576: Allow changing lagg(4) MTU.

LGTM! I have spoke with Ryan to get a better scenario about this issue and here there is a reference for that: https://redmine.ixsystems.com/issues/25092

Oct 16 2018, 4:34 AM · network

Oct 10 2018

araujo accepted D17482: bhyve: emulate CLFLUSH and CLFLUSHOPT..

Lgtm!

Oct 10 2018, 4:27 PM

Oct 4 2018

araujo committed rP481198: Welcome Vinícius Zavam (egypcio) to the rank of ports committer..
Welcome Vinícius Zavam (egypcio) to the rank of ports committer.
Oct 4 2018, 3:24 AM

Sep 26 2018

araujo accepted D17192: Handle the vm* instructions from a guest.

Lgtm

Sep 26 2018, 12:03 AM

Sep 17 2018

araujo accepted D17192: Handle the vm* instructions from a guest.

Lgtm!

Sep 17 2018, 4:00 PM

Sep 14 2018

araujo committed rP479773: - Update to 2018.09.10..
- Update to 2018.09.10.
Sep 14 2018, 12:27 PM

Sep 4 2018

araujo accepted D16822: bhyve: Use MAP_GUARD guard pages.

I have tested it with FreeBSD HEAD as a guest running for couple days.

Sep 4 2018, 1:51 AM · bhyve

Aug 30 2018

araujo added a comment to D12419: HD Audio Emulation For Bhyve (Based on D7840).

Any update on this? I've tried this diff on a recent current but it seems like it doesn't work anymore?

Aug 30 2018, 6:19 AM
araujo accepted D16945: userboot: handle guest interpreter mismatches more intelligently.

For the bhyveload side, I'm ok with the changes.

Aug 30 2018, 3:40 AM
araujo added a comment to D16945: userboot: handle guest interpreter mismatches more intelligently.

A fast look over bhyveload it looks ok. I suppose you have done tests with these changes on bhyveload.

Indeed- I tested all of the cases listed: legacy setup where it's forthloader with old version string, lua+forth guest with each of the userboots in place as /boot/userboot.so, tolerance for a requested interpreter not existing on the host, and explicitly requesting a loader with -l.

Aug 30 2018, 3:39 AM
araujo added a comment to D16945: userboot: handle guest interpreter mismatches more intelligently.

A fast look over bhyveload it looks ok. I suppose you have done tests with these changes on bhyveload.

Aug 30 2018, 3:12 AM

Aug 28 2018

araujo added reviewers for D16822: bhyve: Use MAP_GUARD guard pages: araujo, bhyve.
Aug 28 2018, 6:42 AM · bhyve

Aug 27 2018

araujo accepted D16913: vmrun: add -x flag to always exit when bhyve exists.

Personally I'm not a vmrun.sh user, but I have no objection related with this change and I don't see anything harmful.

Aug 27 2018, 6:20 AM

Aug 23 2018

araujo committed rS338242: Add manpage entry for the new bhyve options -s "help" and -l "help"..
Add manpage entry for the new bhyve options -s "help" and -l "help".
Aug 23 2018, 7:35 AM

Aug 22 2018

araujo committed rS338210: Add -s "help" and -l "help" to print a list of supported PCI and LPC devices..
Add -s "help" and -l "help" to print a list of supported PCI and LPC devices.
Aug 22 2018, 8:23 PM

Aug 21 2018

araujo committed rS338164: Fix resource leak when using strdup(3)..
Fix resource leak when using strdup(3).
Aug 21 2018, 11:11 PM