security/botan2: Update to 2.12.0 Changes: https://botan.randombit.net/news.html#version-2-12-0-2019-10-07 PR: 241217 Submitted by: Ralf van der Enden <firstname.lastname@example.org> (maintainer)
Oh, i wasn't aware of this comment. I double checked the handbook (https://docs.freebsd.org/doc/4.5-RELEASE/usr/share/doc/en/books/porters-handbook/x387.html) but there is no rule for it. So it seems to be individual preference.
I personally prefer a single commit, because it is possible that there is an poudriere build right after the first commit, but before the second. In this scenario the user would end up with a broken software. If this happens on the cluster, it could be for several days in the worst case.
But since there is no rule feel free to get some other point of views and decide by yourself how to process such issues in the future!
Two separate commits makes it easier to write the history log and in case you need one day to make a revert, it will be more easier to identify the reason. But it is not mandatory, but it is what I have been doing since 2007.