Page MenuHomeFreeBSD

tz (Torsten Zühlsdorff)
User

Projects

User Details

User Since
Jul 5 2015, 3:06 PM (237 w, 1 d)

Recent Activity

Thu, Jan 9

tz committed rP522540: Unbreak databases/php74-mysqli when lang/php74 is build with MYSQLND=off.
Unbreak databases/php74-mysqli when lang/php74 is build with MYSQLND=off
Thu, Jan 9, 10:13 PM
tz committed rP522539: Unbreak databases/php73-mysqli when lang/php73 is build with MYSQLND=off.
Unbreak databases/php73-mysqli when lang/php73 is build with MYSQLND=off
Thu, Jan 9, 10:04 PM
tz committed rP522471: Unbreak databases/php72-mysqli when lang/php72 is build with MYSQLND=off.
Unbreak databases/php72-mysqli when lang/php72 is build with MYSQLND=off
Thu, Jan 9, 7:41 AM

Mon, Dec 23

tz committed rP520745: ftp/php74-ftp: Fix Undefined symbol "SSL_library_init".
ftp/php74-ftp: Fix Undefined symbol "SSL_library_init"
Mon, Dec 23, 10:31 PM

Sun, Dec 22

tz committed rP520650: MFH: r520631.
MFH: r520631
Sun, Dec 22, 6:45 PM
tz committed rP520649: MFH: r520629.
MFH: r520629
Sun, Dec 22, 6:43 PM
tz committed rP520648: MFH: r520628.
MFH: r520628
Sun, Dec 22, 6:42 PM
tz committed rP520631: lang/php74: Upgrade from 7.4.0 to 7.4.1.
lang/php74: Upgrade from 7.4.0 to 7.4.1
Sun, Dec 22, 2:35 PM
tz committed rP520629: lang/php73: Upgrade from 7.3.12 to 7.3.13.
lang/php73: Upgrade from 7.3.12 to 7.3.13
Sun, Dec 22, 2:32 PM
tz committed rP520628: lang/php72: Upgrade from 7.2.25 to 7.2.26.
lang/php72: Upgrade from 7.2.25 to 7.2.26
Sun, Dec 22, 2:31 PM

Nov 28 2019

tz committed rP518608: MFH: r518578.
MFH: r518578
Nov 28 2019, 9:57 PM
tz committed rP518578: lang/php74: Update from 7.4.0RC 6 to 7.4.0.
lang/php74: Update from 7.4.0RC 6 to 7.4.0
Nov 28 2019, 1:07 PM

Nov 24 2019

tz committed rP518365: MFH: r518169.
MFH: r518169
Nov 24 2019, 9:52 PM
tz committed rP518364: MFH: r518168.
MFH: r518168
Nov 24 2019, 9:51 PM

Nov 22 2019

tz committed rP518169: lang/php72: Update from 7.2.24 to 7.2.25.
lang/php72: Update from 7.2.24 to 7.2.25
Nov 22 2019, 10:14 PM
tz committed rP518168: lang/php73: Update from 7.3.11 to 7.3.12.
lang/php73: Update from 7.3.11 to 7.3.12
Nov 22 2019, 10:11 PM

Nov 15 2019

tz committed rP517637: MFH: r517342.
MFH: r517342
Nov 15 2019, 8:26 AM

Nov 12 2019

tz committed rP517342: lang/php74: Update from RC5 to RC6.
lang/php74: Update from RC5 to RC6
Nov 12 2019, 6:13 PM

Nov 6 2019

tz committed rP516927: security/vuxml: Document PHP RCE issues.
security/vuxml: Document PHP RCE issues
Nov 6 2019, 9:49 PM

Oct 30 2019

tz committed rP516111: lang/php74: Upgrade from RC4 to RC5.
lang/php74: Upgrade from RC4 to RC5
Oct 30 2019, 10:42 PM

Oct 29 2019

tz accepted D22152: New port: net-im/6cord: Terminal-driven Discord client.
Oct 29 2019, 10:44 PM
tz accepted D22159: irc/inspircd: Update to 3.4.0.
Oct 29 2019, 10:43 PM

Oct 25 2019

tz committed rP515627: MFH: r515599.
MFH: r515599
Oct 25 2019, 6:26 PM
tz committed rP515626: MFH: r515600.
MFH: r515600
Oct 25 2019, 6:13 PM
tz committed rP515625: MFH: r515601.
MFH: r515601
Oct 25 2019, 6:12 PM
tz committed rP515601: lang/php73: Update from 7.3.10 to 7.3.11.
lang/php73: Update from 7.3.10 to 7.3.11
Oct 25 2019, 10:36 AM
tz committed rP515600: lang/php72: Update from 7.2.23 to 7.2.24.
lang/php72: Update from 7.2.23 to 7.2.24
Oct 25 2019, 10:34 AM
tz committed rP515599: lang/php71: Update from 7.1.32 to 7.1.33.
lang/php71: Update from 7.1.32 to 7.1.33
Oct 25 2019, 10:32 AM

Oct 20 2019

tz committed rP515066: MFH: r514729.
MFH: r514729
Oct 20 2019, 7:55 PM

Oct 18 2019

tz accepted D22046: print/utopia : Update MAINTAINER, MASTER_SITES.
Oct 18 2019, 10:34 PM
tz accepted D22048: www/sfnt2woff : Update MAINTAINER and MASTER_SITES.
Oct 18 2019, 10:34 PM
tz accepted D22049: sysutils/lmon : Update MAINTAINER and MASTER_SITES.
Oct 18 2019, 10:33 PM
tz committed rP514729: lang/php74: Update from RC3 to RC4.
lang/php74: Update from RC3 to RC4
Oct 18 2019, 5:35 PM

Oct 16 2019

tz added a comment to D22051: x11-fm/filerunner : Update MAINTAINER.

I see, i shouldn't have written "changed package". Like araujo stated, meta-data are not considered as part of the package. PORTREVISION bumps will rebuild the software from which the package is build. As long as the software contained (!) in the "package" does not change, such a bump is not needed.

Oct 16 2019, 4:12 PM
tz added a comment to D22051: x11-fm/filerunner : Update MAINTAINER.

You don't need the gratuitous PORTREVISION bump here!

Oct 16 2019, 9:56 AM

Oct 12 2019

tz added a comment to D22000: security/botan2: Update to 2.12.0.
In D22000#480687, @dmgk wrote:
In D22000#480674, @tz wrote:

Also there is no need to separate the commits between updates and bumping the PORTREVISION. This can be done in one commit. So please commit this and D22001 together! :)

Thanks for approving. I was told before to split updates like this to two separate commits - https://reviews.freebsd.org/D21716#473777 :)

Oct 12 2019, 10:42 PM
tz accepted D22005: shells/elvish: Remove custom targets.
Oct 12 2019, 9:48 PM
tz accepted D22001: Bump PORTREVISION of ports depending on security/botan2.

See my commit in D22000

Oct 12 2019, 9:48 PM
tz accepted D22000: security/botan2: Update to 2.12.0.

Also there is no need to separate the commits between updates and bumping the PORTREVISION. This can be done in one commit. So please commit this and D22001 together! :)

Oct 12 2019, 9:47 PM

Oct 10 2019

tz accepted D21973: sysutils/qtpass: Update to 1.3.2.
Oct 10 2019, 7:44 PM

Oct 8 2019

tz committed rP514065: deskutils/sysctlview: Update to 1.5.2.
deskutils/sysctlview: Update to 1.5.2
Oct 8 2019, 9:33 AM
tz committed rP514064: sysutils/nsysctl: Update to 1.2.1.
sysutils/nsysctl: Update to 1.2.1
Oct 8 2019, 9:32 AM
tz committed rP514063: sysutils/sysctlinfo-kmod: update to 20191005.
sysutils/sysctlinfo-kmod: update to 20191005
Oct 8 2019, 9:31 AM

Oct 7 2019

tz accepted D21879: lang/go14: Don't install doc and test files.

I'm sorry, i missed your update. Its fine now, please go ahead and thank you! :)

Oct 7 2019, 9:47 PM

Oct 5 2019

tz requested changes to D21879: lang/go14: Don't install doc and test files.

In short: why? The commit message only state what the log says. But it does not tell us about the reasons. Why don't you want to install the test and the doc? I mean: normally this would be a sign of quality. Why not here?
I think the diff is fine, but the commit message needs to be improved

Oct 5 2019, 9:40 PM
tz added a comment to D21899: www/varnish_exporter: Update to 1.5.1.

If possible please add the changelog or a link to the changelog of the update!

Oct 5 2019, 9:38 PM
tz accepted D21899: www/varnish_exporter: Update to 1.5.1.
Oct 5 2019, 9:38 PM
tz committed rP513847: MFH: r513738.
MFH: r513738
Oct 5 2019, 9:33 PM

Oct 3 2019

tz committed rP513738: lang/php74: Upgrade from RC1 to RC3.
lang/php74: Upgrade from RC1 to RC3
Oct 3 2019, 9:55 PM

Sep 29 2019

tz committed rP513272: lang/php73: Update from 7.3.9 to 7.3.10.
lang/php73: Update from 7.3.9 to 7.3.10
Sep 29 2019, 9:08 PM
tz committed rP513271: lang/php72: Update from 7.2.22 to 7.2.23.
lang/php72: Update from 7.2.22 to 7.2.23
Sep 29 2019, 9:06 PM

Sep 27 2019

tz added a comment to D21819: ports-mgmt/modules2tuple: Update to 1.8.2.
In D21819#476317, @dmgk wrote:

Looks like svn ate "Changes:" line in the commit message, sorry about that. Is it some kind a reserved keyword? Should I use "Changelog" or similar for itemized changes list?

I felt strange after I doubled checked the svn log, I'm not aware about reserved keywords. Usually I use changelog, but we should have no limitations. @tz are you aware of any keywords or similar limitations?

Sep 27 2019, 9:32 PM

Sep 25 2019

tz added inline comments to D21793: dns/knot-resolver: Remove redundant lang/go build dependency.
Sep 25 2019, 10:57 PM

Sep 24 2019

tz accepted D21780: New port: devel/gllvm: Whole Program LLVM ported to Go.
Sep 24 2019, 9:23 PM
tz added a comment to D21780: New port: devel/gllvm: Whole Program LLVM ported to Go.

Beside my comment, everything looks fine. Approved :)

Sep 24 2019, 9:22 PM

Sep 22 2019

tz added a comment to D21744: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. sysutils-x11).
In D21744#474777, @dmgk wrote:
In D21744#474762, @tz wrote:

Aloha Dmitri,
two short questions:

poudriere bulk -C -j120a: OK

Why only 12? Please always check both versions. Sometimes there are some side effects in building, nobody could foresee.

Hi Torsten,
Given that these ports are building fine now and there's no functional change to the software (no version updates etc) and only changes to the ports, I felt that it would be enough to test these patches only on a single FreeBSD version. I can run the same poudriere bulk builds on say 11.3 i386 and update test plan with results.

Sep 22 2019, 10:24 PM
tz added a comment to D21744: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. sysutils-x11).

Aloha Dmitri,

Sep 22 2019, 9:47 PM

Sep 21 2019

tz committed rP512539: Delete security/php74-hash.
Delete security/php74-hash
Sep 21 2019, 8:09 PM

Sep 20 2019

tz committed rP512442: lang/php74: Remove another patch.
lang/php74: Remove another patch
Sep 20 2019, 8:06 PM
tz committed rP512441: lang/php74: Remove obsolete patches.
lang/php74: Remove obsolete patches
Sep 20 2019, 8:04 PM
tz committed rP512437: lang/php74: fix the broken patches.
lang/php74: fix the broken patches
Sep 20 2019, 7:50 PM
tz committed rP512431: Add missing module devel/php74-ffi.
Add missing module devel/php74-ffi
Sep 20 2019, 7:31 PM
tz added a comment to D21721: USES=go ports: cleanup, make use of the new GO_TARGET tuple syntax.
In D21721#474028, @dmgk wrote:

As you are working on this already for a while, how about ports that you are not a maintainer? Maybe an exp-run following with a portmgr@ approval would be interesting to clean up the rest of the ports.

That was my plan actually, I was just not sure what would be the best way to get something like that reviewed/committed. The complete diff is about 250KB, I was thinking about maybe breaking it to 3-4 parts for easier review. Would that make sense or it would be better to post it in a single review?

Sep 20 2019, 7:27 PM
tz committed rP512430: lang/php74: add module hash to PHP_EXT_INC.
lang/php74: add module hash to PHP_EXT_INC
Sep 20 2019, 7:24 PM
tz committed rP512406: Welcome PHP 7.4 RC 1 in the ports-tree..
Welcome PHP 7.4 RC 1 in the ports-tree.
Sep 20 2019, 12:21 PM
tz closed D21349: PHP 7.4.
Sep 20 2019, 12:21 PM
tz added a comment to D21349: PHP 7.4.

There a wrong MAINTAINER lines, for example www/mod_php74:
MAINTAINER= ports@FreeBSD.org
I think, this Lines are needless?

Sep 20 2019, 9:11 AM
tz added a comment to D21721: USES=go ports: cleanup, make use of the new GO_TARGET tuple syntax.
In D21721#473887, @dmgk wrote:
In D21721#473870, @tz wrote:

Since i am very unfamiliar with the go ports, i have problems to understand this diff.
In devel/awless only do-build and do-install is removed, but i do not see any usage of GO_TARGET. Same for some other ports.

r505321 converted all ports to USES=go which already provides do-build and do-install targets. During that conversion, ports that were defining their own build/install targets were left alone to be cleaned up later. This commit does this cleanup for the ports that I maintain.

Is there any reason why removing the unneeded build-steps and the switch to GO_TARGET are in the same commit?

Removing targets doesn't remove any build steps, just switches the port to use default targets that go.mk provides.
GO_TARGET is used by go.mk in do-build and do-install, it doesn't make sense to set it with custom targets and removing custom targets w/o setting GO_TARGET would break the build.

Sep 20 2019, 9:05 AM

Sep 19 2019

tz updated the diff for D21349: PHP 7.4.

Changed like requested by ale :)

Sep 19 2019, 9:40 PM
tz added a comment to D21721: USES=go ports: cleanup, make use of the new GO_TARGET tuple syntax.

Since i am very unfamiliar with the go ports, i have problems to understand this diff.
In devel/awless only do-build and do-install is removed, but i do not see any usage of GO_TARGET. Same for some other ports.

Sep 19 2019, 8:48 PM
tz committed rP512351: devel/aphpunit: Update from 1.8 to 1.9.
devel/aphpunit: Update from 1.8 to 1.9
Sep 19 2019, 3:34 PM

Sep 18 2019

tz added a comment to D21349: PHP 7.4.

I'm sorry to bother you @ale , but without your approval i am not allowed to commit the needed change to php.mk. Can you please have a look at it?

Sep 18 2019, 9:15 PM

Sep 16 2019

tz added a comment to D14152: Name change of all phpunit ports.

This revision is from last year and i'm pretty sure you already fixed the issue @joneum , right?
In this case let us close the review.

Sep 16 2019, 8:02 PM
tz added a comment to D10181: Build PHP hash and session modules by default.

Please notice: the hash module is gone in PHP 7.4. Its part of the core and can't be disabled anymore. You find details here:
https://reviews.freebsd.org/D21349

Sep 16 2019, 8:00 PM
tz accepted D21677: Change dmgk ports MAINTAINER email.

Approved!

Sep 16 2019, 7:43 PM
tz accepted D21675: Add dmgk to calendar.freebsd.

Approved _=

Sep 16 2019, 7:37 PM
tz accepted D21674: Add dmgk to xearth locations.

Approved

Sep 16 2019, 7:36 PM
tz accepted D21672: Add dmgk as a new ports committer (mentor/mentee info).

Approved

Sep 16 2019, 7:36 PM
tz accepted D21671: Add dmgk as a new ports committer.

Approved! Please go ahead a commit the news about you! :)

Sep 16 2019, 7:35 PM

Sep 10 2019

tz updated the diff for D21349: PHP 7.4.
Sep 10 2019, 7:07 PM
tz updated the diff for D21349: PHP 7.4.

Add new module devel/php74-ffi and fix net-mgmt Makefile.

Sep 10 2019, 7:05 PM
tz updated the diff for D21349: PHP 7.4.

Fix another plist issue with the php-fpm config

Sep 10 2019, 8:19 AM

Sep 9 2019

tz updated the diff for D21349: PHP 7.4.

Found and fix plist-issue for FPM

Sep 9 2019, 7:34 AM

Sep 8 2019

tz updated the diff for D21349: PHP 7.4.

Thank you @tobik , this works! And it was the last piece. So everything is compiling and running now! :)

Sep 8 2019, 8:32 PM

Sep 7 2019

tz updated the diff for D21349: PHP 7.4.

@tobik Thank you, this works with RC 1 too! :)

Sep 7 2019, 9:22 PM

Sep 6 2019

tz added a comment to D21349: PHP 7.4.

@ale Can you please review the changes of php.mk?
I would like to commit the RC1 without the broken modules imap and gd. I do not want to wait until the end and miss the interval to have runtime testing with an RC.

Sep 6 2019, 11:02 AM
tz updated the diff for D21349: PHP 7.4.

Update to RC 1.

Sep 6 2019, 11:00 AM

Sep 5 2019

tz committed rP511167: MFH: r511036.
MFH: r511036
Sep 5 2019, 10:17 AM
tz committed rP511166: MFH: r511035.
MFH: r511035
Sep 5 2019, 10:14 AM
tz committed rP511165: MFH: r511034.
MFH: r511034
Sep 5 2019, 10:09 AM

Sep 3 2019

tz committed rP511040: net/phpldapadmin: fix search button in PHP 7.3.
net/phpldapadmin: fix search button in PHP 7.3
Sep 3 2019, 9:09 PM
tz committed rP511036: lang/php73: Update from 7.3.8 to 7.3.9.
lang/php73: Update from 7.3.8 to 7.3.9
Sep 3 2019, 8:24 PM
tz committed rP511035: lang/php72: Update from 7.2.21 to 7.2.22.
lang/php72: Update from 7.2.21 to 7.2.22
Sep 3 2019, 8:23 PM
tz committed rP511034: lang/php71: Upgrade from 7.1.31 to 7.1.32.
lang/php71: Upgrade from 7.1.31 to 7.1.32
Sep 3 2019, 8:22 PM

Sep 2 2019

tz committed rP510848: MFH: r510422.
MFH: r510422
Sep 2 2019, 8:38 PM
tz committed rP510847: MFH: r510421.
MFH: r510421
Sep 2 2019, 8:35 PM
tz committed rP510846: MFH: r510420.
MFH: r510420
Sep 2 2019, 8:32 PM
tz committed rP510843: MFH: r510419.
MFH: r510419
Sep 2 2019, 8:28 PM
tz committed rP510781: MFH: r510418.
MFH: r510418
Sep 2 2019, 12:33 PM
tz added a comment to D21349: PHP 7.4.

You can find the diff with --copy-as-ads here:
http://www.meisterderspiele.de/freebsd/php-7.4.diff

Sep 2 2019, 8:45 AM