- User Since
- Jul 5 2015, 3:06 PM (223 w, 4 d)
Wed, Oct 16
I see, i shouldn't have written "changed package". Like araujo stated, meta-data are not considered as part of the package. PORTREVISION bumps will rebuild the software from which the package is build. As long as the software contained (!) in the "package" does not change, such a bump is not needed.
Sat, Oct 12
See my commit in D22000
Also there is no need to separate the commits between updates and bumping the PORTREVISION. This can be done in one commit. So please commit this and D22001 together! :)
Thu, Oct 10
Tue, Oct 8
Mon, Oct 7
I'm sorry, i missed your update. Its fine now, please go ahead and thank you! :)
Sat, Oct 5
In short: why? The commit message only state what the log says. But it does not tell us about the reasons. Why don't you want to install the test and the doc? I mean: normally this would be a sign of quality. Why not here?
I think the diff is fine, but the commit message needs to be improved
If possible please add the changelog or a link to the changelog of the update!
Thu, Oct 3
Sun, Sep 29
Fri, Sep 27
Wed, Sep 25
Tue, Sep 24
Beside my comment, everything looks fine. Approved :)
Sun, Sep 22
Sat, Sep 21
Fri, Sep 20
Thu, Sep 19
Since i am very unfamiliar with the go ports, i have problems to understand this diff.
In devel/awless only do-build and do-install is removed, but i do not see any usage of GO_TARGET. Same for some other ports.
Wed, Sep 18
I'm sorry to bother you @ale , but without your approval i am not allowed to commit the needed change to php.mk. Can you please have a look at it?
Sep 16 2019
This revision is from last year and i'm pretty sure you already fixed the issue @joneum , right?
In this case let us close the review.
Please notice: the hash module is gone in PHP 7.4. Its part of the core and can't be disabled anymore. You find details here:
Approved! Please go ahead a commit the news about you! :)
Sep 10 2019
Add new module devel/php74-ffi and fix net-mgmt Makefile.
Fix another plist issue with the php-fpm config
Sep 9 2019
Sep 8 2019
Thank you @tobik , this works! And it was the last piece. So everything is compiling and running now! :)
Sep 7 2019
@tobik Thank you, this works with RC 1 too! :)
Sep 6 2019
@ale Can you please review the changes of php.mk?
I would like to commit the RC1 without the broken modules imap and gd. I do not want to wait until the end and miss the interval to have runtime testing with an RC.
Sep 5 2019
Sep 3 2019
Sep 2 2019
You can find the diff with --copy-as-ads here:
Sep 1 2019
I updated the review to contain the diff only, like requested. Hopefully you can work with this better now.
Aug 31 2019
Aug 30 2019
Aug 29 2019
Aug 23 2019
Aug 20 2019
Before you asked: yes, all is a repo-copy. I used --show-copy-as-ads in order to let you use the review for your own build-tests.