Page MenuHomeFreeBSD

tz (Torsten Zühlsdorff)
User

Projects

User Details

User Since
Jul 5 2015, 3:06 PM (223 w, 4 d)

Recent Activity

Wed, Oct 16

tz added a comment to D22051: x11-fm/filerunner : Update MAINTAINER.

I see, i shouldn't have written "changed package". Like araujo stated, meta-data are not considered as part of the package. PORTREVISION bumps will rebuild the software from which the package is build. As long as the software contained (!) in the "package" does not change, such a bump is not needed.

Wed, Oct 16, 4:12 PM
tz added a comment to D22051: x11-fm/filerunner : Update MAINTAINER.

You don't need the gratuitous PORTREVISION bump here!

Wed, Oct 16, 9:56 AM

Sat, Oct 12

tz added a comment to D22000: security/botan2: Update to 2.12.0.
In D22000#480687, @dmgk wrote:
In D22000#480674, @tz wrote:

Also there is no need to separate the commits between updates and bumping the PORTREVISION. This can be done in one commit. So please commit this and D22001 together! :)

Thanks for approving. I was told before to split updates like this to two separate commits - https://reviews.freebsd.org/D21716#473777 :)

Sat, Oct 12, 10:42 PM
tz accepted D22005: shells/elvish: Remove custom targets.
Sat, Oct 12, 9:48 PM
tz accepted D22001: Bump PORTREVISION of ports depending on security/botan2.

See my commit in D22000

Sat, Oct 12, 9:48 PM
tz accepted D22000: security/botan2: Update to 2.12.0.

Also there is no need to separate the commits between updates and bumping the PORTREVISION. This can be done in one commit. So please commit this and D22001 together! :)

Sat, Oct 12, 9:47 PM

Thu, Oct 10

tz accepted D21973: sysutils/qtpass: Update to 1.3.2.
Thu, Oct 10, 7:44 PM

Tue, Oct 8

tz committed rP514065: deskutils/sysctlview: Update to 1.5.2.
deskutils/sysctlview: Update to 1.5.2
Tue, Oct 8, 9:33 AM
tz committed rP514064: sysutils/nsysctl: Update to 1.2.1.
sysutils/nsysctl: Update to 1.2.1
Tue, Oct 8, 9:32 AM
tz committed rP514063: sysutils/sysctlinfo-kmod: update to 20191005.
sysutils/sysctlinfo-kmod: update to 20191005
Tue, Oct 8, 9:31 AM

Mon, Oct 7

tz accepted D21879: lang/go14: Don't install doc and test files.

I'm sorry, i missed your update. Its fine now, please go ahead and thank you! :)

Mon, Oct 7, 9:47 PM

Sat, Oct 5

tz requested changes to D21879: lang/go14: Don't install doc and test files.

In short: why? The commit message only state what the log says. But it does not tell us about the reasons. Why don't you want to install the test and the doc? I mean: normally this would be a sign of quality. Why not here?
I think the diff is fine, but the commit message needs to be improved

Sat, Oct 5, 9:40 PM
tz added a comment to D21899: www/varnish_exporter: Update to 1.5.1.

If possible please add the changelog or a link to the changelog of the update!

Sat, Oct 5, 9:38 PM
tz accepted D21899: www/varnish_exporter: Update to 1.5.1.
Sat, Oct 5, 9:38 PM
tz committed rP513847: MFH: r513738.
MFH: r513738
Sat, Oct 5, 9:33 PM

Thu, Oct 3

tz committed rP513738: lang/php74: Upgrade from RC1 to RC3.
lang/php74: Upgrade from RC1 to RC3
Thu, Oct 3, 9:55 PM

Sun, Sep 29

tz committed rP513272: lang/php73: Update from 7.3.9 to 7.3.10.
lang/php73: Update from 7.3.9 to 7.3.10
Sun, Sep 29, 9:08 PM
tz committed rP513271: lang/php72: Update from 7.2.22 to 7.2.23.
lang/php72: Update from 7.2.22 to 7.2.23
Sun, Sep 29, 9:06 PM

Fri, Sep 27

tz added a comment to D21819: ports-mgmt/modules2tuple: Update to 1.8.2.
In D21819#476317, @dmgk wrote:

Looks like svn ate "Changes:" line in the commit message, sorry about that. Is it some kind a reserved keyword? Should I use "Changelog" or similar for itemized changes list?

I felt strange after I doubled checked the svn log, I'm not aware about reserved keywords. Usually I use changelog, but we should have no limitations. @tz are you aware of any keywords or similar limitations?

Fri, Sep 27, 9:32 PM

Wed, Sep 25

tz added inline comments to D21793: dns/knot-resolver: Remove redundant lang/go build dependency.
Wed, Sep 25, 10:57 PM

Tue, Sep 24

tz accepted D21780: New port: devel/gllvm: Whole Program LLVM ported to Go.
Tue, Sep 24, 9:23 PM
tz added a comment to D21780: New port: devel/gllvm: Whole Program LLVM ported to Go.

Beside my comment, everything looks fine. Approved :)

Tue, Sep 24, 9:22 PM

Sun, Sep 22

tz added a comment to D21744: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. sysutils-x11).
In D21744#474777, @dmgk wrote:
In D21744#474762, @tz wrote:

Aloha Dmitri,
two short questions:

poudriere bulk -C -j120a: OK

Why only 12? Please always check both versions. Sometimes there are some side effects in building, nobody could foresee.

Hi Torsten,
Given that these ports are building fine now and there's no functional change to the software (no version updates etc) and only changes to the ports, I felt that it would be enough to test these patches only on a single FreeBSD version. I can run the same poudriere bulk builds on say 11.3 i386 and update test plan with results.

Sun, Sep 22, 10:24 PM
tz added a comment to D21744: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. sysutils-x11).

Aloha Dmitri,

Sun, Sep 22, 9:47 PM

Sat, Sep 21

tz committed rP512539: Delete security/php74-hash.
Delete security/php74-hash
Sat, Sep 21, 8:09 PM

Fri, Sep 20

tz committed rP512442: lang/php74: Remove another patch.
lang/php74: Remove another patch
Fri, Sep 20, 8:06 PM
tz committed rP512441: lang/php74: Remove obsolete patches.
lang/php74: Remove obsolete patches
Fri, Sep 20, 8:04 PM
tz committed rP512437: lang/php74: fix the broken patches.
lang/php74: fix the broken patches
Fri, Sep 20, 7:50 PM
tz committed rP512431: Add missing module devel/php74-ffi.
Add missing module devel/php74-ffi
Fri, Sep 20, 7:31 PM
tz added a comment to D21721: USES=go ports: cleanup, make use of the new GO_TARGET tuple syntax.
In D21721#474028, @dmgk wrote:

As you are working on this already for a while, how about ports that you are not a maintainer? Maybe an exp-run following with a portmgr@ approval would be interesting to clean up the rest of the ports.

That was my plan actually, I was just not sure what would be the best way to get something like that reviewed/committed. The complete diff is about 250KB, I was thinking about maybe breaking it to 3-4 parts for easier review. Would that make sense or it would be better to post it in a single review?

Fri, Sep 20, 7:27 PM
tz committed rP512430: lang/php74: add module hash to PHP_EXT_INC.
lang/php74: add module hash to PHP_EXT_INC
Fri, Sep 20, 7:24 PM
tz committed rP512406: Welcome PHP 7.4 RC 1 in the ports-tree..
Welcome PHP 7.4 RC 1 in the ports-tree.
Fri, Sep 20, 12:21 PM
tz closed D21349: PHP 7.4.
Fri, Sep 20, 12:21 PM
tz added a comment to D21349: PHP 7.4.

There a wrong MAINTAINER lines, for example www/mod_php74:
MAINTAINER= ports@FreeBSD.org
I think, this Lines are needless?

Fri, Sep 20, 9:11 AM
tz added a comment to D21721: USES=go ports: cleanup, make use of the new GO_TARGET tuple syntax.
In D21721#473887, @dmgk wrote:
In D21721#473870, @tz wrote:

Since i am very unfamiliar with the go ports, i have problems to understand this diff.
In devel/awless only do-build and do-install is removed, but i do not see any usage of GO_TARGET. Same for some other ports.

r505321 converted all ports to USES=go which already provides do-build and do-install targets. During that conversion, ports that were defining their own build/install targets were left alone to be cleaned up later. This commit does this cleanup for the ports that I maintain.

Is there any reason why removing the unneeded build-steps and the switch to GO_TARGET are in the same commit?

Removing targets doesn't remove any build steps, just switches the port to use default targets that go.mk provides.
GO_TARGET is used by go.mk in do-build and do-install, it doesn't make sense to set it with custom targets and removing custom targets w/o setting GO_TARGET would break the build.

Fri, Sep 20, 9:05 AM

Thu, Sep 19

tz updated the diff for D21349: PHP 7.4.

Changed like requested by ale :)

Thu, Sep 19, 9:40 PM
tz added a comment to D21721: USES=go ports: cleanup, make use of the new GO_TARGET tuple syntax.

Since i am very unfamiliar with the go ports, i have problems to understand this diff.
In devel/awless only do-build and do-install is removed, but i do not see any usage of GO_TARGET. Same for some other ports.

Thu, Sep 19, 8:48 PM
tz committed rP512351: devel/aphpunit: Update from 1.8 to 1.9.
devel/aphpunit: Update from 1.8 to 1.9
Thu, Sep 19, 3:34 PM

Wed, Sep 18

tz added a comment to D21349: PHP 7.4.

I'm sorry to bother you @ale , but without your approval i am not allowed to commit the needed change to php.mk. Can you please have a look at it?

Wed, Sep 18, 9:15 PM

Sep 16 2019

tz added a comment to D14152: Name change of all phpunit ports.

This revision is from last year and i'm pretty sure you already fixed the issue @joneum , right?
In this case let us close the review.

Sep 16 2019, 8:02 PM
tz added a comment to D10181: Build PHP hash and session modules by default.

Please notice: the hash module is gone in PHP 7.4. Its part of the core and can't be disabled anymore. You find details here:
https://reviews.freebsd.org/D21349

Sep 16 2019, 8:00 PM
tz accepted D21677: Change dmgk ports MAINTAINER email.

Approved!

Sep 16 2019, 7:43 PM
tz accepted D21675: Add dmgk to calendar.freebsd.

Approved _=

Sep 16 2019, 7:37 PM
tz accepted D21674: Add dmgk to xearth locations.

Approved

Sep 16 2019, 7:36 PM
tz accepted D21672: Add dmgk as a new ports committer (mentor/mentee info).

Approved

Sep 16 2019, 7:36 PM
tz accepted D21671: Add dmgk as a new ports committer.

Approved! Please go ahead a commit the news about you! :)

Sep 16 2019, 7:35 PM

Sep 10 2019

tz updated the diff for D21349: PHP 7.4.
Sep 10 2019, 7:07 PM
tz updated the diff for D21349: PHP 7.4.

Add new module devel/php74-ffi and fix net-mgmt Makefile.

Sep 10 2019, 7:05 PM
tz updated the diff for D21349: PHP 7.4.

Fix another plist issue with the php-fpm config

Sep 10 2019, 8:19 AM

Sep 9 2019

tz updated the diff for D21349: PHP 7.4.

Found and fix plist-issue for FPM

Sep 9 2019, 7:34 AM

Sep 8 2019

tz updated the diff for D21349: PHP 7.4.

Thank you @tobik , this works! And it was the last piece. So everything is compiling and running now! :)

Sep 8 2019, 8:32 PM

Sep 7 2019

tz updated the diff for D21349: PHP 7.4.

@tobik Thank you, this works with RC 1 too! :)

Sep 7 2019, 9:22 PM

Sep 6 2019

tz added a comment to D21349: PHP 7.4.

@ale Can you please review the changes of php.mk?
I would like to commit the RC1 without the broken modules imap and gd. I do not want to wait until the end and miss the interval to have runtime testing with an RC.

Sep 6 2019, 11:02 AM
tz updated the diff for D21349: PHP 7.4.

Update to RC 1.

Sep 6 2019, 11:00 AM

Sep 5 2019

tz committed rP511167: MFH: r511036.
MFH: r511036
Sep 5 2019, 10:17 AM
tz committed rP511166: MFH: r511035.
MFH: r511035
Sep 5 2019, 10:14 AM
tz committed rP511165: MFH: r511034.
MFH: r511034
Sep 5 2019, 10:09 AM

Sep 3 2019

tz committed rP511040: net/phpldapadmin: fix search button in PHP 7.3.
net/phpldapadmin: fix search button in PHP 7.3
Sep 3 2019, 9:09 PM
tz committed rP511036: lang/php73: Update from 7.3.8 to 7.3.9.
lang/php73: Update from 7.3.8 to 7.3.9
Sep 3 2019, 8:24 PM
tz committed rP511035: lang/php72: Update from 7.2.21 to 7.2.22.
lang/php72: Update from 7.2.21 to 7.2.22
Sep 3 2019, 8:23 PM
tz committed rP511034: lang/php71: Upgrade from 7.1.31 to 7.1.32.
lang/php71: Upgrade from 7.1.31 to 7.1.32
Sep 3 2019, 8:22 PM

Sep 2 2019

tz committed rP510848: MFH: r510422.
MFH: r510422
Sep 2 2019, 8:38 PM
tz committed rP510847: MFH: r510421.
MFH: r510421
Sep 2 2019, 8:35 PM
tz committed rP510846: MFH: r510420.
MFH: r510420
Sep 2 2019, 8:32 PM
tz committed rP510843: MFH: r510419.
MFH: r510419
Sep 2 2019, 8:28 PM
tz committed rP510781: MFH: r510418.
MFH: r510418
Sep 2 2019, 12:33 PM
tz added a comment to D21349: PHP 7.4.

You can find the diff with --copy-as-ads here:
http://www.meisterderspiele.de/freebsd/php-7.4.diff

Sep 2 2019, 8:45 AM

Sep 1 2019

tz added inline comments to D21349: PHP 7.4.
Sep 1 2019, 9:58 PM
tz added a comment to D21349: PHP 7.4.

I updated the review to contain the diff only, like requested. Hopefully you can work with this better now.

Sep 1 2019, 6:02 PM

Aug 31 2019

tz committed rP510422: databases/pgpool-II-40: Upgrade from 4.0.5 to 4.0.6.
databases/pgpool-II-40: Upgrade from 4.0.5 to 4.0.6
Aug 31 2019, 9:30 PM
tz committed rP510421: databases/pgpool-II-37: Upgrade from 3.7.10 to 3.7.11.
databases/pgpool-II-37: Upgrade from 3.7.10 to 3.7.11
Aug 31 2019, 9:26 PM
tz committed rP510420: databases/pgpool-II-36: Upgrade from 3.6.17 to 3.6.18.
databases/pgpool-II-36: Upgrade from 3.6.17 to 3.6.18
Aug 31 2019, 9:21 PM
tz committed rP510419: databases/pgpool-II-35: Update from 3.5.21 to 3.5.22.
databases/pgpool-II-35: Update from 3.5.21 to 3.5.22
Aug 31 2019, 9:16 PM
tz committed rP510418: databases/pgpool: Update from 3.4.24 to 3.4.25.
databases/pgpool: Update from 3.4.24 to 3.4.25
Aug 31 2019, 9:12 PM

Aug 30 2019

tz committed rP510244: UPDATING: Correct and improve wording of PostgreSQL update.
UPDATING: Correct and improve wording of PostgreSQL update
Aug 30 2019, 7:30 AM

Aug 29 2019

tz committed rP510189: Switch default version of PostgreSQL from 9.5 to 11.
Switch default version of PostgreSQL from 9.5 to 11
Aug 29 2019, 9:29 PM

Aug 23 2019

tz added a comment to D21349: PHP 7.4.
In D21349#464775, @ale wrote:

As you said, this is useful for testing, but a standard diff might be useful, too, to see what actually changed from php 7.2

Aug 23 2019, 11:07 PM

Aug 20 2019

tz added a comment to D21349: PHP 7.4.

Before you asked: yes, all is a repo-copy. I used --show-copy-as-ads in order to let you use the review for your own build-tests.

Aug 20 2019, 11:07 PM
tz created D21349: PHP 7.4.
Aug 20 2019, 11:06 PM

Aug 3 2019

tz committed rP507985: MFH: r507979.
MFH: r507979
Aug 3 2019, 7:16 PM
tz committed rP507984: MFH: r507977 r507983.
MFH: r507977 r507983
Aug 3 2019, 7:13 PM
tz committed rP507983: PHP 7.1: Put missing mail header patch back.
PHP 7.1: Put missing mail header patch back
Aug 3 2019, 7:09 PM
tz committed rP507981: MFH: r507978.
MFH: r507978
Aug 3 2019, 7:04 PM
tz committed rP507979: Update PHP 7.3 from 7.3.7 to 7.3.8.
Update PHP 7.3 from 7.3.7 to 7.3.8
Aug 3 2019, 6:30 PM
tz committed rP507978: Update PHP 7.2 from 7.2.20 to 7.2.21.
Update PHP 7.2 from 7.2.20 to 7.2.21
Aug 3 2019, 6:28 PM
tz committed rP507977: Update PHP 7.1 from 7.1.30 to 7.1.31.
Update PHP 7.1 from 7.1.30 to 7.1.31
Aug 3 2019, 6:26 PM

Jul 16 2019

tz committed rP506781: MFH: r506578.
MFH: r506578
Jul 16 2019, 7:59 PM
tz committed rP506780: MFH: r506579.
MFH: r506579
Jul 16 2019, 7:57 PM

Jul 13 2019

tz committed rP506579: lang/php73: Update from 7.3.6 to 7.3.7.
lang/php73: Update from 7.3.6 to 7.3.7
Jul 13 2019, 9:27 PM
tz committed rP506578: lang/php72: Upgrade from 7.2.19 to 7.2.20.
lang/php72: Upgrade from 7.2.19 to 7.2.20
Jul 13 2019, 9:25 PM

Jun 11 2019

tz committed rP503944: MFH: r503194.
MFH: r503194
Jun 11 2019, 8:37 AM

Jun 7 2019

tz committed rP503627: MFH: r503195.
MFH: r503195
Jun 7 2019, 9:24 AM
tz committed rP503626: MFH: r503193.
MFH: r503193
Jun 7 2019, 9:21 AM

May 31 2019

tz committed rP503195: lang/php73: Update from 7.3.5 to 7.3.6.
lang/php73: Update from 7.3.5 to 7.3.6
May 31 2019, 10:02 PM
tz committed rP503194: lang/php72: Upgrade from 7.2.18 7.2.19.
lang/php72: Upgrade from 7.2.18 7.2.19
May 31 2019, 9:58 PM
tz committed rP503193: lang/php71: Update from 7.1.29 to 7.1.30.
lang/php71: Update from 7.1.29 to 7.1.30
May 31 2019, 9:56 PM

May 23 2019

tz committed rP502326: MFH: r501845.
MFH: r501845
May 23 2019, 8:43 AM
tz committed rP502325: MFH: r501844.
MFH: r501844
May 23 2019, 8:42 AM
tz committed rP502324: MFH: r501843.
MFH: r501843
May 23 2019, 8:41 AM
tz committed rP502323: MFH: r501842.
MFH: r501842
May 23 2019, 8:40 AM