No? Maybe we should lift the embargo for approval of flavors? :D

In this case approved :)

You could also include the "Reported by:" header, if some reports the issue to you. Its not needed for me, just want to point it out.

Please update after requested changes ;)

Why did you remove the patches? If you do so you should mention the reason in the commit log. Most times upstream incorporated them, but not always.

Just another ping. @mat maybe? ;)

Just a short ping to portmgr. Since adding flavors to a port currently needs approval by portmgr.

Looks fine to me :)

Looks fine to me! :)

Changes are fine. Your plan for 2 commits also, please proceed :)

Besides the notes it looks fine to me.

Aloha Bernard,
i will take a look at it next week. I'm currently on very low time, but will try to through all your PHP reviews (i'm assigned to) next week.
Thanks,
Torsten

Approved with requested change to commit log.

Can you please update to 10.5.7 since it fixes new security issues?

Sorry for missing this error

Please go with the partial patch and discuss the remaining issue further with the maintainer.

In D14870#312892, @idefix_fechner.net wrote:

Thanks, I will commit it with the requested change, even if make validate now complains with:
... see above
Consider using /usr/home/idefix/svn/ports/security/vuxml/vuln.xml.unexpanded for final commit

which wants everything in one line...

Approved after the requested change

Way to go :) Its fine for me, please commit.

In D14840#312222, @idefix_fechner.net wrote:

Should I undo the TIMESTAMP modification? I prepared the diffs long time ago I had access to SVN.

Added the new ports to the ../Makefile.
Fixed the Makefile (including error messages shown by "portlint -ACN"), added myself as maintainer, added PORTSCOUT line and if required a CONFLICTS_INSTALL.

Next step would be then to do a "svn commit".

In D14840#312169, @idefix_fechner.net wrote:

What I did was (e.g. for port security/rubygem-doorkeeper-openid_connect12):
svn copy security/rubygem-doorkeeper-openid_connect security/rubygem-doorkeeper-openid_connect12

and then updated the files in the new directory.
Added in the ../Makefile this new port.

I also removed and changed some lines that porlint -ACN is fine.

Is this ok?

Since its not possible to see it in the git diffs:
Did you create the ports with an svn repo-copy?

You are right. I changed SUFFIX to PREFIX in order to get names like php70-aphunit-1.4, which are much clearer.

Provide more context for review