- User Since
- Jul 5 2015, 3:06 PM (154 w, 4 d)
Tue, Jun 12
Mon, Jun 11
Fri, Jun 8
Tue, Jun 5
Mon, Jun 4
Wed, May 30
Tue, May 29
Fri, May 25
Wed, May 23
No? Maybe we should lift the embargo for approval of flavors? :D
May 17 2018
May 16 2018
In this case approved :)
You could also include the "Reported by:" header, if some reports the issue to you. Its not needed for me, just want to point it out.
Please update after requested changes ;)
May 15 2018
May 14 2018
Why did you remove the patches? If you do so you should mention the reason in the commit log. Most times upstream incorporated them, but not always.
May 11 2018
Just another ping. @mat maybe? ;)
May 9 2018
May 2 2018
Apr 30 2018
Apr 27 2018
Just a short ping to portmgr. Since adding flavors to a port currently needs approval by portmgr.
Apr 26 2018
Apr 25 2018
Apr 23 2018
Looks fine to me :)
Changes are fine. Your plan for 2 commits also, please proceed :)
Besides the notes it looks fine to me.
Apr 18 2018
Apr 17 2018
Apr 12 2018
i will take a look at it next week. I'm currently on very low time, but will try to through all your PHP reviews (i'm assigned to) next week.
Apr 9 2018
Approved with requested change to commit log.
Apr 6 2018
Apr 5 2018
Can you please update to 10.5.7 since it fixes new security issues?
Sorry for missing this error
Apr 4 2018
Apr 3 2018
Please go with the partial patch and discuss the remaining issue further with the maintainer.
Mar 29 2018
Mar 28 2018
Mar 27 2018
Mar 26 2018
Way to go :) Its fine for me, please commit.
Added the new ports to the ../Makefile.
Fixed the Makefile (including error messages shown by "portlint -ACN"), added myself as maintainer, added PORTSCOUT line and if required a CONFLICTS_INSTALL.
Next step would be then to do a "svn commit".
Since its not possible to see it in the git diffs:
Did you create the ports with an svn repo-copy?
Mar 23 2018
You are right. I changed SUFFIX to PREFIX in order to get names like php70-aphunit-1.4, which are much clearer.
Provide more context for review