- User Since
- Jul 5 2015, 3:06 PM (141 w, 2 d)
Looks fine to me
This was already committed and could now be abandoned?
Fri, Mar 16
Thu, Mar 15
Wed, Mar 14
Tue, Mar 13
I'm not fine with this!
Mon, Mar 12
Sun, Mar 4
Fri, Mar 2
Tue, Feb 27
Mon, Feb 26
Issues were addressed, looks fine to me! :)
Besides the 2 cosmetic issues i'm fine with it (as far as i understand it).
Thu, Feb 22
Wed, Feb 21
Fine - this is only a rough review. I found some issues, have some questions and many entries reflecting that i'm unsure what you do. :D But hopefully this helps.
Great - i will try to find some time within the next days for review :)
Tue, Feb 20
So whats the current status here? When will it land?
Mon, Feb 19
Feb 16 2018
Feb 15 2018
Feb 8 2018
Feb 7 2018
Feb 6 2018
this patch is huge and its possible that it conflics with another patch: https://reviews.freebsd.org/D14208
I really would like to prefer seeing the second patch to be committed before your one. This will safe some confusion.
Beside this it looks good at first glance, but i didn't do a deeper test.
Abadon Revision in favor of https://reviews.freebsd.org/D14208
It looks fine too me. I'm glad that i wasn't too far away from the Flavor code. :)
Feb 2 2018
Jan 24 2018
Now its buildable and seems to be fine :)
Sorry - my bad. Its another error:
This patch also doesn't work:
/wrkdirs/usr/ports/www/nginx/work/nginx-gridfs-0.8/ngx_http_gridfs_module.c:527:14: error: use of undeclared identifier 'mongo_conn_bad_set_name' case mongo_conn_bad_set_name: ^ /wrkdirs/usr/ports/www/nginx/work/nginx-gridfs-0.8/ngx_http_gridfs_module.c:531:14: error: use of undeclared identifier 'mongo_conn_cannot_find_primary' case mongo_conn_cannot_find_primary: ^ /wrkdirs/usr/ports/www/nginx/work/nginx-gridfs-0.8/ngx_http_gridfs_module.c:568:14: error: unknown type name 'mongo_conn_return' volatile mongo_conn_return status = mongo_conn_fail; ^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 11 warnings and 20 errors generated. *** Error code 1
=> Attempting to fetch https://codeload.github.com/openresty/memc-nginx-module/tar.gz/v0.18?dummy=/openresty-memc-nginx-module-v0.18_GH0.tar.gz openresty-memc-nginx-module-v0.18_GH0.tar.gz 100% of 36 kB 399 kBps 00m00s => SpiderLabs-ModSecurity-v3.0.0_GH0.tar.gz is not in /usr/ports/www/nginx/distinfo. => Either /usr/ports/www/nginx/distinfo is out of date, or => SpiderLabs-ModSecurity-v3.0.0_GH0.tar.gz is spelled incorrectly. *** Error code 1
Jan 22 2018
Committed! Thanks to all of you for your help, time and feedback! :)
I think its ready for an exp-run. What do you think?
Fix indentation problem :)
Jan 19 2018
I fixed the "type" problem. When redirecting the output it works fine :)