- User Since
- Jul 5 2015, 3:06 PM (124 w, 9 h)
Fri, Nov 17
Also like with the other ports i highly doubt that this is a useful addition!
Did somebody evaluate a slave-port, using /etc/make.conf or a flavor? This would be nice instead of just adding the port.
Thu, Nov 16
The log message should contain the full pkg-descr text!
sorry i took so long to respond. But finally :)
General your change looks good to me. But there is one catch for me: i try to stay as near as possible to the file provided by GitLab itself. Changes of this values are very time-consuming to migrate. Therefore it would be better to get your change into upstream (or did you take it from a newer version?) and than get it afterwards into the port.
There is currently a update to 10.1.3 ready and just waits for some dependencies to be committed :)
Tue, Nov 14
Fri, Nov 10
Update Diff for RC 6. This will be the last RC.
I added @ale because of the needed approval for changes of Mk/Uses/php.mk
Thu, Nov 9
Tue, Nov 7
Thu, Nov 2
Mon, Oct 30
Fri, Oct 27
Thu, Oct 26
Wed, Oct 25
Tue, Oct 24
Sat, Oct 21
Oct 18 2017
Add mbstring to build this port fine. Bevore, there was an
fatal error, they tell, the mbstring is missing
As a further comment to the DISTVERSION comment, have a look at 5.2.2 VERSIONS:
Oct 12 2017
Sep 28 2017
Sep 27 2017
Sep 22 2017
Sep 21 2017
Sep 20 2017
did you check if the dependencies break?
Sep 19 2017
Sep 15 2017
Sep 14 2017
Sep 13 2017
Sep 11 2017
I'm still confused about all your pear-Updates. At first: it removes the usage of pear. Okay, PEAR was gone and resurrected and many projects went away. Fine.
- pear is still in the package name even if its not used
- When read correct (i'm unsure): you add the pear-channel as RUN/BUILD dependency for the script itself without using any pear-functionality at all?
- Downloading it plainly from GitHub and executing it and the test-cases is just fine So: why even bother with the depends?
Sep 7 2017
Since PR and Review are nearly identical and you are not the author: did you check everything the patch should do? And i do not mean just a build-test. I mean "try to reproduce the error, test the patch, is it gone and everything else works still fine"?
Also the long list of portlint output is quite frightening :D
I change the status of the review to make clear, that changes are needed
Sep 1 2017
pkg-static: Warning: @exec is deprecated, please use @[pre|post][un]exec
pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:11:i386" -- no architecture specific files found:
- could this package use a wildcard architecture?
Aug 31 2017
Aug 28 2017
Aug 25 2017
exp-run requested in: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221792
Change check for bundle according to mat's suggestion