- User Since
- May 9 2014, 10:23 AM (333 w, 4 d)
Fri, Sep 25
Assuming this was tested on all our supported releases.
Assuming you have tested it and it works.
Thu, Sep 24
Wed, Sep 23
Tue, Sep 15
Mon, Sep 14
I am not sure if it is the correct way to fix this either, but note that the src component has a special treatment, for some reason, and also, if you install FreeBSD without the src component from the installer, the resulting freebsd-update.conf file still has the src component,
Wed, Sep 9
Well, the bureaucrat in me thinks "open a PR, wait 14 days, commit". ;-)
Mon, Sep 7
Tue, Sep 1
Mon, Aug 31
Why is it quoted in the first place, and why is it broken now?
Aug 28 2020
Aug 27 2020
Aug 26 2020
Aug 25 2020
Aug 24 2020
The port is missing a DOCS option, also, can you regenerate the pkg-plist file with make makeplist? It is strangely ordered.
Aug 21 2020
Aug 20 2020
Aug 17 2020
Aug 14 2020
The options block is badly ordered, See https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-options.html for the correct ordering of the variables.
Aug 7 2020
Ah, sorry, I should have added that patch files need to have a small comment at the top explaining they why of what they are doing, for example, like https://reviews.freebsd.org/source/ports/browse/head/lang/perl5.32/files/patch-Makefile.SH.
Aug 6 2020
Aug 5 2020
Aug 4 2020
There should be some place where you document why you rename the Object.php file to _Object.php. Because I cannot figure out why myself.
Aug 3 2020
Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.
Jul 30 2020
Jul 27 2020
Accepting as portmgr for the Mk bits.
Jul 24 2020
Jul 23 2020
This needs to get a PORTREVISION bump.
Please make sure that when committed, this is done by first copying lang/lua53 to lang/lua54.
Jul 21 2020
I am accepting this as portmgr, I assume it works ;-)
accept wrt flavors.
Looks ok. Could you indent the inside of the here documents one step so the only lines that begin with text are ucl?
Jul 20 2020
It looks like you are emulating moving PHPDaemon/Config/Object.php to PHPDaemon/Config/_Object by a rm and a patch adding the file.
I wonder about the design choices behind having "magic" strings everywhere, those %1, %@ and all.