Page MenuHomeFreeBSD

mat (Mathieu Arnold)
EngineeringAdministrator

Projects (9)

User Details

User Since
May 9 2014, 10:23 AM (270 w, 5 d)
Roles
Administrator

Recent Activity

Yesterday

mat added inline comments to D20597: [new port] devel/appmenu-gtk-module: GTK+ application menu module.
Wed, Jul 17, 7:07 PM

Mon, Jul 15

D20951: Use keyword to simplify ldconfig code is now accepted and ready to land.
Mon, Jul 15, 2:12 PM
mat added inline comments to D20951: Use keyword to simplify ldconfig code.
Mon, Jul 15, 1:19 PM
mat added inline comments to D20885: Porter's Handbook: deprecate use of -march=native.
Mon, Jul 15, 1:05 PM
mat committed rP506661: Update to 0.6.3..
Update to 0.6.3.
Mon, Jul 15, 1:01 PM
mat committed rP506659: Update to v5.31.1-148-gdc9ac3ee56..
Update to v5.31.1-148-gdc9ac3ee56.
Mon, Jul 15, 1:01 PM
mat committed rP506660: Update to latest commit..
Update to latest commit.
Mon, Jul 15, 1:01 PM
mat added inline comments to D20951: Use keyword to simplify ldconfig code.
Mon, Jul 15, 12:58 PM
mat added inline comments to D20951: Use keyword to simplify ldconfig code.
Mon, Jul 15, 12:08 PM

Fri, Jul 12

mat added inline comments to D20927: New port: textproc/py-ocrmypdf: Adds an OCR test layer to scanned PDF files.
Fri, Jul 12, 4:21 PM

Tue, Jul 9

mat added inline comments to D20885: Porter's Handbook: deprecate use of -march=native.
Tue, Jul 9, 2:16 PM
mat added a comment to D20885: Porter's Handbook: deprecate use of -march=native.
In D20885#452740, @mat wrote:

As you added a list, maybe add another point about excluding -msse* extensions

I do intend to add more information to this section based on the rework I am doing to accomodate "powerpc64 no longer implies gcc by default". Fortunately most of those do not require a policy decision, but this one does, so I would like to address it separately. Thanks.

Tue, Jul 9, 12:17 PM
mat added a comment to D20885: Porter's Handbook: deprecate use of -march=native.

As you added a list, maybe add another point about excluding -msse* extensions from any non amd64 arch as it limits where the software can run on i386, and it breaks on other architectures. (grep'ing for sse in the tree, it seems there also is -mfpmath=sse.)

Tue, Jul 9, 11:38 AM

Mon, Jul 8

mat added inline comments to D20732: Update porter's handbook for USES=xorg.
Mon, Jul 8, 2:57 PM
D20819: sysutils/minipro: fix build with GCC-based architectures is now accepted and ready to land.
Mon, Jul 8, 2:44 PM
mat committed rP506227: Update to latest commit..
Update to latest commit.
Mon, Jul 8, 2:23 PM
mat committed rP506226: Update to 4.1.0..
Update to 4.1.0.
Mon, Jul 8, 2:23 PM
mat committed rP506225: Update to latest commit..
Update to latest commit.
Mon, Jul 8, 2:23 PM
mat committed rP506224: Update to v5.31.1-138-g256dda502e..
Update to v5.31.1-138-g256dda502e.
Mon, Jul 8, 2:22 PM

Sun, Jul 7

mat committed rP506196: Fix..
Fix.
Sun, Jul 7, 9:32 PM
mat added inline comments to D20856: graphics/xsane: Update MASTER_SITES.
Sun, Jul 7, 9:31 PM

Fri, Jul 5

D20861: audio/zam-plugins-lv2: fix build on non-x86 is now accepted and ready to land.
Fri, Jul 5, 4:51 PM
D20823: multimedia/oggvideotools: fix build with GCC-based architectures is now accepted and ready to land.
Fri, Jul 5, 4:49 PM
mat added inline comments to D20819: sysutils/minipro: fix build with GCC-based architectures.
Fri, Jul 5, 4:45 PM

Wed, Jul 3

mat committed rP505746: lint..
lint.
Wed, Jul 3, 11:31 AM
mat committed rP505740: Remove www/palemoon, it is not maintained and full of security holes..
Remove www/palemoon, it is not maintained and full of security holes.
Wed, Jul 3, 9:44 AM

Mon, Jul 1

mat added inline comments to D20823: multimedia/oggvideotools: fix build with GCC-based architectures.
Mon, Jul 1, 7:24 PM
D20822: x11-wm/gcompmgr: fix build with GCC-based architectures is now accepted and ready to land.
Mon, Jul 1, 7:24 PM
D20821: science/PETSc: fix build with non-x86 is now accepted and ready to land.
Mon, Jul 1, 7:23 PM
mat added inline comments to D20819: sysutils/minipro: fix build with GCC-based architectures.
Mon, Jul 1, 7:23 PM
mat committed rD53207: Document qt-dist.
Document qt-dist
Mon, Jul 1, 7:22 PM
mat closed D20802: porters handbook: Document qt-dist.
Mon, Jul 1, 7:22 PM
D20819: sysutils/minipro: fix build with GCC-based architectures is now accepted and ready to land.
Mon, Jul 1, 7:19 PM
D20816: xen-{kernel/tools}: switch back to LLVM toolchain is now accepted and ready to land.
Mon, Jul 1, 7:18 PM
D20807: graphics/caffe: respect CXX is now accepted and ready to land.
Mon, Jul 1, 7:13 PM
mat committed rP505616: Update to latest commit..
Update to latest commit.
Mon, Jul 1, 4:21 PM
mat committed rP505615: Update to v5.31.1-120-g0087236851..
Update to v5.31.1-120-g0087236851.
Mon, Jul 1, 4:21 PM
mat committed rP505614: Make a note about expiration here..
Make a note about expiration here.
Mon, Jul 1, 4:21 PM
mat added a comment to D20734: pkgbase: differentiate package versions for ALPHA/BETA/PRERELEASE/RC phases (part 2).

This is quite similar to D8943.

Mon, Jul 1, 8:40 AM · pkgbase

Sat, Jun 29

mat added a comment to D20802: porters handbook: Document qt-dist.
  • feedback.
Sat, Jun 29, 5:54 PM
mat committed rP505361: Make sure we don't clobber slave ports' PORTREVISION..
Make sure we don't clobber slave ports' PORTREVISION.
Sat, Jun 29, 5:35 PM
mat added a comment to D20802: porters handbook: Document qt-dist.
  • Add a note in the Qt chapter.
Sat, Jun 29, 3:58 PM
Herald added 1 blocking reviewer(s) for D20802: porters handbook: Document qt-dist: mat.
  • Rework.
Sat, Jun 29, 3:39 PM
mat added a comment to D20802: porters handbook: Document qt-dist.

I don't think the <sect2> are needed, the section is not long, and having examples in a separate subsection does not make a lot of sense (to me at least).

Sat, Jun 29, 1:00 PM

Fri, Jun 28

mat committed rP505313: Remove noflavors when it does not make sense..
Remove noflavors when it does not make sense.
Fri, Jun 28, 10:01 PM
mat committed rP505268: Remove dupplicate port..
Remove dupplicate port.
Fri, Jun 28, 6:57 AM

Thu, Jun 27

D20777: math/openblas: fix build on powerpc64 is now accepted and ready to land.
Thu, Jun 27, 3:20 PM
D20778: lang/python35: Fix packaging on GCC architectures is now accepted and ready to land.

make sure the commit message contains every bit of information that was requested in the PR.

Thu, Jun 27, 3:19 PM

Wed, Jun 26

mat committed rP505184: Regular categories Makefile sorting..
Regular categories Makefile sorting.
Wed, Jun 26, 8:16 PM
mat added a comment to D20746: Convert all Go ports to USES=go.

Ok, so, I am not going to go through the whole patch again. Only use USES=go:no_targets when the targets are added by the framework, like with cmake.
If the port has a do-build and a do-install target use USES=go, do not add the :no_targets.

Wed, Jun 26, 6:09 PM
mat added inline comments to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.
Wed, Jun 26, 4:31 PM
mat added inline comments to D20746: Convert all Go ports to USES=go.
Wed, Jun 26, 4:27 PM
D20736: The porter's handbook Go chapter: document no_targets/run args and GO_PORT variable is now accepted and ready to land.
Wed, Jun 26, 4:24 PM
mat added a comment to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.
In D20724#449059, @mat wrote:

I think you are trying to put really too much magic in xorg-cat.

I am merely replicating the functionality that was in bsd.xorg.mk. All of this is in the old bsd.xorg.mk, and there it works. bsd.xorg.mk is only pulled in from bsd.ports.mk if USE_XORG or XORG_CAT is defined, perhaps it is better left this way, rather than converted to USES?

Wed, Jun 26, 11:52 AM
mat added inline comments to D20736: The porter's handbook Go chapter: document no_targets/run args and GO_PORT variable.
Wed, Jun 26, 11:46 AM
mat added a comment to D20732: Update porter's handbook for USES=xorg.

I thought the porter's handbook was for external facing things, so to speak. xorg-cat is meant to be only for xorg ports (ports coming from freedesktop.org), and not for general consumption. I have no problem adding it to the handbook, but since other similar things, such as qt-dist.mk, wasn't documented, I thought this was the way to do it. the previous XORG_CAT isn't documented anywhere, as far as I can tell.

Wed, Jun 26, 11:40 AM

Tue, Jun 25

mat added a comment to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.

I think you are trying to put really too much magic in xorg-cat.

Tue, Jun 25, 9:37 PM
mat committed rD53188: Add another rule to the list, and reformat the list as a list..
Add another rule to the list, and reformat the list as a list.
Tue, Jun 25, 3:25 PM
mat added inline comments to D20736: The porter's handbook Go chapter: document no_targets/run args and GO_PORT variable.
Tue, Jun 25, 2:59 PM
mat added a comment to D20732: Update porter's handbook for USES=xorg.
In D20732#448815, @mat wrote:

Could you also add documentation for USES=xorg-cat?

I purposefully omitted it, since it is supposed to be internal to xorg ports, not used by other ports, similar to qt-dist.mk.

Tue, Jun 25, 2:56 PM
mat added a comment to D20735: Mk/Uses/go.mk: Add no_targets and run args.

Is there any port that would USES=go:run ? Because there is none in the other review, and we really do not like to add code that is never used.

Tue, Jun 25, 2:51 PM
mat added a comment to D20746: Convert all Go ports to USES=go.

This probably needs an exp-run to make sure nothing breaks.

Tue, Jun 25, 2:42 PM
mat added a comment to D20725: Clean up final QT4 leftovers.

if make index passes, it's ok by me.

Tue, Jun 25, 2:40 PM
mat added a comment to D20457: update x11-wm/herbstluftwm 0.7.2.

I don't understand the change you made to the pkg-message file. I asked to choose either install or upgrade, looking at this, it is only needed the first time you install the port, so the second bit about upgrade is not required.

Tue, Jun 25, 2:39 PM
mat added a comment to D20732: Update porter's handbook for USES=xorg.

Could you also add documentation for USES=xorg-cat?

Tue, Jun 25, 2:34 PM
mat committed rP505086: Update to latest commit..
Update to latest commit.
Tue, Jun 25, 12:52 PM
mat committed rP505085: Update to v5.31.1-101-g5c696bd319..
Update to v5.31.1-101-g5c696bd319.
Tue, Jun 25, 12:52 PM
mat added a comment to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.

Also, to be consistent with the rest of the Ports framework, do not quote words in tests.

Tue, Jun 25, 12:39 PM
mat added a comment to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.

Also, could you please run both new mk files through Tools/scripts/indent_make_if.pl so that the indentations is consistent with other files in that directory?

Tue, Jun 25, 12:27 PM

Mon, Jun 24

mat added inline comments to D20725: Clean up final QT4 leftovers.
Mon, Jun 24, 6:58 PM
mat added a comment to D20725: Clean up final QT4 leftovers.

The sanity bits need to stay, we don't remove them.

Mon, Jun 24, 6:57 PM

Sat, Jun 22

mat committed rP504862: Update to 2.9a.
Update to 2.9a
Sat, Jun 22, 12:51 PM
mat committed rD53177: Update UCL examples of short and multiline strings.
Update UCL examples of short and multiline strings
Sat, Jun 22, 11:35 AM
mat closed D20666: porters-handbook: Update UCL examples of short and multiline strings.
Sat, Jun 22, 11:35 AM
mat added a comment to D16457: Subpackages. (deal with it.).

rebase

Sat, Jun 22, 11:13 AM
mat added a comment to D16457: Subpackages. (deal with it.).

rebase

Sat, Jun 22, 9:31 AM
mat added inline comments to D17766: [new port] [WIP] sysutils/nix: Purely functional package manager.
Sat, Jun 22, 8:18 AM
mat added inline comments to D20457: update x11-wm/herbstluftwm 0.7.2.
Sat, Jun 22, 8:16 AM

Fri, Jun 21

D20717: biology/abyss: fix build on big-endian architectures is now accepted and ready to land.
Fri, Jun 21, 10:38 AM
D20707: mail/dcc-dccd: reroll tarball, bump PORTREVISION is now accepted and ready to land.

Do include the explanation in the commit message.

Fri, Jun 21, 10:35 AM

Thu, Jun 20

mat updated the summary of D8943: Enhance the PKG_VERSION versioning sheme..
Thu, Jun 20, 2:38 PM
mat committed rD53173: Make it clear that using sed(1) to patch files is only to be used when.
Make it clear that using sed(1) to patch files is only to be used when
Thu, Jun 20, 2:36 PM
mat closed D20679: Cleanup patching of static content with sed..
Thu, Jun 20, 2:36 PM
mat added inline comments to D20698: Make it possible not to send MFH emails.
Thu, Jun 20, 2:31 PM
mat added a comment to D20679: Cleanup patching of static content with sed..
  • Be consistent.
Thu, Jun 20, 10:57 AM
mat added inline comments to D20679: Cleanup patching of static content with sed..
Thu, Jun 20, 10:56 AM
D20707: mail/dcc-dccd: reroll tarball, bump PORTREVISION now requires changes to proceed.
Thu, Jun 20, 10:49 AM
mat added a comment to D20707: mail/dcc-dccd: reroll tarball, bump PORTREVISION.

https://www.freebsd.org/doc/en/articles/committers-guide/ports.html#ports-qa-misc-updated-distfile

Thu, Jun 20, 10:48 AM
mat added a comment to D20656: Add new port: net/tcprtt: reliably measure the TCP handshake round trip time using stats(9).

The source files should not be put in the "files" directory, if one day you need to add support files, like *.in files, it will clutter everything. It would be preferable to put them in a src directory.

Thu, Jun 20, 10:48 AM
D20706: emulators/xen-kernel: use binutils to workaround LLD 8 bug is now accepted and ready to land.
Thu, Jun 20, 10:45 AM
mat added a comment to D20698: Make it possible not to send MFH emails.
In D20698#447300, @mat wrote:

Then if the MFH line contains anything else than a branch name, say:

MFH: 2019Q2 (security update blanket approval)

There is no need to send an email because it will already have gotten committed.

That's what the above patch does.

Thu, Jun 20, 10:44 AM
mat added inline comments to D17766: [new port] [WIP] sysutils/nix: Purely functional package manager.
Thu, Jun 20, 10:43 AM
mat committed rP504619: Fixup make index WITH=HTTP..
Fixup make index WITH=HTTP.
Thu, Jun 20, 7:46 AM
mat added a comment to D20394: Ports Tree Base Packages.
In D20394#447314, @imp wrote:
In D20394#444436, @mat wrote:

Anyway, open to suggestions on where to next take this conversation to reach some consensus around these topics.

The consensus is that this does not belong in the ports tree.

I want to piggyback on this. The ports tree needs to be about ports, and it just doesn't make sense to mix src and ports in the same tree.
If I were you(pl.), I'd make a new tree for building src packages. It can piggyback ports/Mk, and with the addition of some src-tree Mk/Uses files you should be in business. The process and resources are identical, but it should live in its own tree.
To build pkgs out of src, I would have suggested calling it /usr/pkgsrc but that name means something else :-)

I'm having trouble understanding how this is materially different than all the kmod ports relying on /usr/src for their builds, and that's not verified at all either. Also, in the future, we may have a src git repo, and we're looking at having signed commits so we'll know that a tree has integrity.

Thu, Jun 20, 7:35 AM
mat committed rP504618: Regular USE_GITHUB cleanup..
Regular USE_GITHUB cleanup.
Thu, Jun 20, 7:12 AM

Wed, Jun 19

mat committed rP504599: MFH: r503380.
MFH: r503380
Wed, Jun 19, 10:59 PM
mat committed rP504598: Update to 9.11.8 and 9.14.3..
Update to 9.11.8 and 9.14.3.
Wed, Jun 19, 10:47 PM
mat committed rP504595: Update to 9.11.8..
Update to 9.11.8.
Wed, Jun 19, 10:43 PM
mat committed rP504596: Update to 9.14.3..
Update to 9.14.3.
Wed, Jun 19, 10:43 PM
mat committed rP504594: Fix build with Perl 5.31+.
Fix build with Perl 5.31+
Wed, Jun 19, 10:42 PM