Page MenuHomeFreeBSD

mat (Mathieu Arnold)
EngineeringAdministrator

Projects (9)

User Details

User Since
May 9 2014, 10:23 AM (349 w, 2 d)
Roles
Administrator

Recent Activity

Tue, Jan 5

mat added a comment to D27954: BUGFIX: Only call sed_checked.sh if REINPLACE_ARGS hasn't been altered.
In D27954#624718, @mat wrote:

I don't think this is a good idea. Having REINPLACE_ARGS overridable was probably a bad idea, and the ability to change -i is also something that needs to go away.

@mat Well, why don't we commit this to fix what was actually broken in r522484 (this one-line patch is absolutely non-intrusive and doesn't make anything worse) to stop people from running into the problem now and you come up with and execute a plan to retire overriding REINPLACE_ARGS as a separate effort?

Tue, Jan 5, 2:03 PM
mat added a comment to D27954: BUGFIX: Only call sed_checked.sh if REINPLACE_ARGS hasn't been altered.

I don't think this is a good idea. Having REINPLACE_ARGS overridable was probably a bad idea, and the ability to change -i is also something that needs to go away.

Tue, Jan 5, 11:41 AM

Mon, Jan 4

mat committed rP560295: Update to v5.33.5-127-gb52b12abf8.
Update to v5.33.5-127-gb52b12abf8
Mon, Jan 4, 1:56 PM
mat committed rP560294: Update to latest commit..
Update to latest commit.
Mon, Jan 4, 1:56 PM
mat committed R9:f632a3691edd: Expand changes possible without maintainer approval a bit. (authored by mat).
Expand changes possible without maintainer approval a bit.
Mon, Jan 4, 11:42 AM

Thu, Dec 31

mat added inline comments to D27863: Move Mk/bsd.ruby.mk to Mk/Uses/ruby.mk..
Thu, Dec 31, 9:26 AM
mat added inline comments to D27863: Move Mk/bsd.ruby.mk to Mk/Uses/ruby.mk..
Thu, Dec 31, 9:26 AM

Dec 17 2020

mat committed rP558278: Update to 2.3..
Update to 2.3.
Dec 17 2020, 10:28 AM

Dec 16 2020

mat committed rP558243: MFH: r556981 r558241 r558242.
MFH: r556981 r558241 r558242
Dec 16 2020, 9:38 PM
mat committed rP558242: Update to 9.16.10.
Update to 9.16.10
Dec 16 2020, 9:36 PM
mat committed rP558241: Update to 9.11.26..
Update to 9.11.26.
Dec 16 2020, 9:36 PM

Dec 13 2020

mat committed R9:634058547b55: Add my entity, and move myself from contributors to commiters (authored by mat).
Add my entity, and move myself from contributors to commiters
Dec 13 2020, 7:00 PM
mat committed R9:197413eaf73f: Add myself to the news (authored by mat).
Add myself to the news
Dec 13 2020, 7:00 PM
mat committed R9:b4818c6fcff0: Add my key (authored by mat).
Add my key
Dec 13 2020, 6:59 PM
mat committed R9:5ce339addb4e: Add Lars Thegler <lars@thegler.dk> to the contributors (authored by mat).
Add Lars Thegler <lars@thegler.dk> to the contributors
Dec 13 2020, 6:59 PM
mat committed R9:ab9801e9dab2: Update my key (authored by mat).
Update my key
Dec 13 2020, 6:52 PM
mat committed R9:367297ca1b24: Add some subkeys which are not Elgamal (authored by mat).
Add some subkeys which are not Elgamal
Dec 13 2020, 6:52 PM
mat committed R9:3f9a4c90a783: Add anoncvs.fr.freebsd.org to the list. (authored by mat).
Add anoncvs.fr.freebsd.org to the list.
Dec 13 2020, 6:49 PM
mat committed R9:2261e01306b7: Add a not on the use of the ports/Tools/scripts/plist script (authored by mat).
Add a not on the use of the ports/Tools/scripts/plist script
Dec 13 2020, 6:43 PM
mat committed R9:caeb22373237: MFen: (authored by mat).
MFen:
Dec 13 2020, 6:43 PM
mat committed R9:e549f4b23e74: Add an entry for a notbook, mine has been dead for too long, and I don't see (authored by mat).
Add an entry for a notbook, mine has been dead for too long, and I don't see
Dec 13 2020, 6:40 PM
mat committed R9:9edad9ecec95: Add the nice company who paid my entrance fee to EuroBSDCon 2004. (authored by mat).
Add the nice company who paid my entrance fee to EuroBSDCon 2004.
Dec 13 2020, 6:38 PM
mat committed R9:9b37676e2647: RIP my old key, welcome to the new one (authored by mat).
RIP my old key, welcome to the new one
Dec 13 2020, 6:30 PM
mat committed R9:d8f5dd5a01cb: Remove that, I already bough a powerbook, and I just received my workstation (authored by mat).
Remove that, I already bough a powerbook, and I just received my workstation
Dec 13 2020, 6:28 PM
mat committed R9:f98a64b5e87d: Update my key (authored by mat).
Update my key
Dec 13 2020, 6:01 PM

Dec 7 2020

mat added a comment to D27494: Mk/Uses/ninja.mk: Fix build error when both 'emacs' and 'ninja' are added to USES.

I don't understand why so many ports are changed.

Dec 7 2020, 1:12 PM

Dec 4 2020

mat committed rP556981: Fix BIND9 9.11.25's manpages..
Fix BIND9 9.11.25's manpages.
Dec 4 2020, 1:26 PM

Dec 3 2020

mat accepted D27340: Add "education" virtual category to Porter's Handbook..
Dec 3 2020, 6:05 PM

Nov 30 2020

mat committed rP556627: Update to v5.33.4-81-gadd0fa5884..
Update to v5.33.4-81-gadd0fa5884.
Nov 30 2020, 11:35 AM
mat committed rP556628: Update to latest commit..
Update to latest commit.
Nov 30 2020, 11:35 AM
mat committed rP556626: Do not require approval for merging commits to the quarterly branches..
Do not require approval for merging commits to the quarterly branches.
Nov 30 2020, 11:16 AM

Nov 29 2020

mat committed rP556563: MFH: r556502 r556504.
MFH: r556502 r556504
Nov 29 2020, 11:16 AM

Nov 28 2020

mat committed rP556504: Update to 9.16.9..
Update to 9.16.9.
Nov 28 2020, 3:04 PM
mat committed rP556502: Update to 9.11.25..
Update to 9.11.25.
Nov 28 2020, 3:03 PM

Nov 25 2020

mat added a comment to D27340: Add "education" virtual category to Porter's Handbook..

The "Any of:" part doesn't feel right to me, because it's restrictive. Can you maybe flip it around? "Applications, utilities, or games primarily[...] or study in general, such as: course-writing or course-delivery applications[...]". Something like that gives context and hints as to what belongs without restricting its ability to grow over time.

Nov 25 2020, 9:47 AM

Nov 16 2020

mat committed rP555465: Update to latest commit..
Update to latest commit.
Nov 16 2020, 11:02 AM
mat committed rP555464: Update to v5.33.3-141-gab307de390..
Update to v5.33.3-141-gab307de390.
Nov 16 2020, 11:02 AM
mat committed rP555463: Ignore readelf's return value..
Ignore readelf's return value.
Nov 16 2020, 10:51 AM

Nov 11 2020

mat committed rP554894: Ignore grep return value..
Ignore grep return value.
Nov 11 2020, 1:30 PM
mat closed D27007: Add set pipefail in most framework scripts..
Nov 11 2020, 1:30 PM
mat committed rP554893: Add set pipefail in most framework scripts..
Add set pipefail in most framework scripts.
Nov 11 2020, 1:30 PM

Nov 9 2020

mat committed rP554710: Remove references to non existent patches..
Remove references to non existent patches.
Nov 9 2020, 11:42 AM
mat committed rP554709: Update to latest commit..
Update to latest commit.
Nov 9 2020, 11:42 AM
mat committed rP554708: Update to v5.33.3-110-g09e51a9507..
Update to v5.33.3-110-g09e51a9507.
Nov 9 2020, 11:42 AM

Nov 5 2020

mat committed rP554142: Backout r554139..
Backout r554139.
Nov 5 2020, 8:09 PM
mat committed rP554140: Remove non existing patch..
Remove non existing patch.
Nov 5 2020, 8:09 PM
mat committed rP554139: Add set pipefail in most framework scripts..
Add set pipefail in most framework scripts.
Nov 5 2020, 8:09 PM

Nov 2 2020

mat updated the diff for D27007: Add set pipefail in most framework scripts..
  • Ignore grep return value.
Nov 2 2020, 9:57 AM
mat updated the diff for D27007: Add set pipefail in most framework scripts..
  • fixup! Add set pipefail in most framework scripts.
Nov 2 2020, 8:31 AM

Oct 30 2020

mat committed rP553691: Update to 2.0.65..
Update to 2.0.65.
Oct 30 2020, 1:37 PM
mat committed rP553690: Update to 3.1c..
Update to 3.1c.
Oct 30 2020, 1:37 PM

Oct 29 2020

mat requested review of D27007: Add set pipefail in most framework scripts..
Oct 29 2020, 3:00 PM

Oct 26 2020

mat committed rP553342: MFH: r553338 r553339.
MFH: r553338 r553339
Oct 26 2020, 11:42 AM
mat committed rP553341: Update to latest commit..
Update to latest commit.
Oct 26 2020, 11:41 AM
mat committed rP553340: Update to v5.33.3-26-gbb58640a40..
Update to v5.33.3-26-gbb58640a40.
Oct 26 2020, 11:41 AM
mat committed rP553339: Update to 9.16.8..
Update to 9.16.8.
Oct 26 2020, 11:41 AM
mat committed rP553338: Update to 9.11.24.
Update to 9.11.24
Oct 26 2020, 11:41 AM

Oct 21 2020

mat accepted D26640: Lua version of @shell.
Oct 21 2020, 3:59 PM
mat accepted D26633: Add @rmempty keyword.

Can you also convert a few ports to this after you add the keyword?

Oct 21 2020, 3:58 PM

Oct 19 2020

mat committed rP552752: Update to latest commit..
Update to latest commit.
Oct 19 2020, 5:02 PM
mat committed rP552751: Update to v5.33.2-204-ge6b76f1d3a..
Update to v5.33.2-204-ge6b76f1d3a.
Oct 19 2020, 5:01 PM
mat accepted D24430: Update porters handbook for Lua changes.

ok by me.

Oct 19 2020, 11:17 AM

Oct 14 2020

mat added inline comments to D26640: Lua version of @shell.
Oct 14 2020, 4:37 PM
mat added inline comments to D26640: Lua version of @shell.
Oct 14 2020, 4:02 PM
mat added inline comments to D26640: Lua version of @shell.
Oct 14 2020, 2:30 PM
mat added a comment to D26633: Add @rmempty keyword.

I am sure there are examples of ports doing that, but listing a few here would be nice.

Oct 14 2020, 2:19 PM
mat added inline comments to D26640: Lua version of @shell.
Oct 14 2020, 2:16 PM

Sep 30 2020

mat added a comment to D26558: bsd.port.mk: make sure REINPLACE_ARGS is factored into REINPLACE_CMD.
In D26558#592593, @mat wrote:
In D26558#592498, @mat wrote:

I disagree with those changes, x11/gnome-pie is not using REINPLACE_ARGS correctly. That variable can only be used to set the -i argument.

Sure. Do we document this somewhere? We should, at or around fixing that particular usage.

REINPLACE_ARGS is purposefully not documented in the porter's handbook.
An extra comment in Mk/bsd.port.mk would not hurt though.

Sure, I can get behind that, maybe:

# REINPLACE_ARGS may only be used to set or override the -i argument.  Any other use is considered
# invalid.

?

Sep 30 2020, 12:58 PM
mat added a comment to D26558: bsd.port.mk: make sure REINPLACE_ARGS is factored into REINPLACE_CMD.
In D26558#592498, @mat wrote:

I disagree with those changes, x11/gnome-pie is not using REINPLACE_ARGS correctly. That variable can only be used to set the -i argument.

Sure. Do we document this somewhere? We should, at or around fixing that particular usage.

Sep 30 2020, 12:44 PM
mat committed rP550694: REINPLACE_ARGS can only contain the -i argument..
REINPLACE_ARGS can only contain the -i argument.
Sep 30 2020, 12:44 PM
mat added a comment to D26558: bsd.port.mk: make sure REINPLACE_ARGS is factored into REINPLACE_CMD.

I disagree with those changes, x11/gnome-pie is not using REINPLACE_ARGS correctly. That variable can only be used to set the -i argument.

Sep 30 2020, 9:32 AM
mat added a comment to D24240: Improve and extend sed_checked.sh.

No more complaints received in a month, can I commit?

Sep 30 2020, 8:40 AM

Sep 25 2020

mat accepted D26551: bsd.port.mk: Handle incorrect binary aliases gracefully.

Assuming this was tested on all our supported releases.

Sep 25 2020, 1:00 PM
mat accepted D25178: bsd.port.mk: print the name of the problematic archive on failed extraction.

Assuming you have tested it and it works.

Sep 25 2020, 12:57 PM

Sep 24 2020

mat added reviewers for D26529: Remove Python 2.x support from ports: portmgr, mat.
Sep 24 2020, 5:20 PM

Sep 23 2020

mat committed rD54516: Rewrite symlink handling..
Rewrite symlink handling.
Sep 23 2020, 3:14 PM
mat committed rP549733: MFH: r549731 r549732.
MFH: r549731 r549732
Sep 23 2020, 2:44 PM
mat committed rP549732: Update to 9.16.7..
Update to 9.16.7.
Sep 23 2020, 2:43 PM
mat committed rP549731: Update to 9.11.23..
Update to 9.11.23.
Sep 23 2020, 2:42 PM
mat added inline comments to D17766: [New port] sysutils/nix: Purely functional package manager.
Sep 23 2020, 12:51 PM

Sep 15 2020

mat committed rP548722: Regular USE_GITHUB cleanup..
Regular USE_GITHUB cleanup.
Sep 15 2020, 9:22 AM

Sep 14 2020

mat committed rP548619: Update to latest commit..
Update to latest commit.
Sep 14 2020, 3:11 PM
mat committed rP548618: Update to v5.33.1-201-gb1de2493b5..
Update to v5.33.1-201-gb1de2493b5.
Sep 14 2020, 3:11 PM
mat added a comment to D3527: Suppress harmless warning if running in 'cron' mode.

I am not sure if it is the correct way to fix this either, but note that the src component has a special treatment, for some reason, and also, if you install FreeBSD without the src component from the installer, the resulting freebsd-update.conf file still has the src component,

Sep 14 2020, 12:43 PM

Sep 9 2020

mat committed rP548098: Fixup qat..
Fixup qat.
Sep 9 2020, 2:48 PM
mat added a comment to D26362: Move some gnome@ ports to desktop@.

Well, the bureaucrat in me thinks "open a PR, wait 14 days, commit". ;-)

Sep 9 2020, 2:32 PM

Sep 7 2020

mat committed rP547896: Update to latest commit..
Update to latest commit.
Sep 7 2020, 3:14 PM
mat committed rP547895: Update to v5.33.1-184-g2bd36f42f4..
Update to v5.33.1-184-g2bd36f42f4.
Sep 7 2020, 3:13 PM

Sep 1 2020

mat accepted D26221: Mk/Uses/python.mk: Do not surround plist entries in quotes.
Sep 1 2020, 12:37 PM
mat added a comment to D26221: Mk/Uses/python.mk: Do not surround plist entries in quotes.
In D26221#583669, @jrm wrote:
In D26221#583268, @mat wrote:

Why is it quoted in the first place, and why is it broken now?

It looks like it's quoted because in Mk/Uses/python.mk the package list is generated using PYDISTUTILS_INSTALLARGS:= --record ${_PYTHONPKGLIST}. It's broken because different things under Mk/ do not expect a quote, e.g., ${SED} -e 's|^${PREFIX}/||' ${_PYTHONPKGLIST} ${TMPPLIST} or when doing stage-qa.

Sep 1 2020, 5:18 AM

Aug 31 2020

mat committed rP547196: QAT fixes..
QAT fixes.
Aug 31 2020, 4:01 PM
mat committed rP547195: QAT fixes..
QAT fixes.
Aug 31 2020, 4:01 PM
mat committed rP547194: QAT fixes..
QAT fixes.
Aug 31 2020, 4:01 PM
mat committed rP547179: Cleanup a few of my ports..
Cleanup a few of my ports.
Aug 31 2020, 1:12 PM
mat committed rP547178: Fix shebangs on a few scripts..
Fix shebangs on a few scripts.
Aug 31 2020, 1:12 PM
mat committed rP547174: Fix check_dig when it uses drill and when changing the port..
Fix check_dig when it uses drill and when changing the port.
Aug 31 2020, 12:40 PM
mat committed rP547175: Cleanup, no functionnal change..
Cleanup, no functionnal change.
Aug 31 2020, 12:40 PM
mat committed rP547173: Update to latest commit..
Update to latest commit.
Aug 31 2020, 12:40 PM
mat committed rP547172: Update to v5.33.1-58-g682d991d28..
Update to v5.33.1-58-g682d991d28.
Aug 31 2020, 12:40 PM
mat added a comment to D26221: Mk/Uses/python.mk: Do not surround plist entries in quotes.

Why is it quoted in the first place, and why is it broken now?

Aug 31 2020, 10:56 AM