mat (Mathieu Arnold)Administrator
Engineering

Projects (9)

User Details

User Since
May 9 2014, 10:23 AM (210 w, 6 d)
Roles
Administrator

Recent Activity

Yesterday

mat added a comment to D15555: audio/idjc audio/shout-idjc.

audio/idjc/pkg-plist seems badly sorted, could you run make makeplist and make sure you do not sort the output again?

Thu, May 24, 9:10 PM
mat added inline comments to D15544: audio/clementine-player -- sync to github.
Thu, May 24, 9:07 PM
mat committed rD51718: Rewrite that bit, and make it more clear and more correct..
Rewrite that bit, and make it more clear and more correct.
Thu, May 24, 3:08 PM
mat updated the diff for D13970: Run shellcheck through Mk/Scripts/.

Fix regressions and rebase.

Thu, May 24, 12:02 PM
mat added a comment to D15540: Replace bsd.qt.mk by qt.mk and qt-dist.mk.

Mmmm, phabricator does not seem to want to show the files here 😑
Could you maybe only add the Mk changes to the review, as all the ports changes seem to be pretty mechanical.

Thu, May 24, 7:46 AM
mat added a comment to D15471: Document cargo.mk in the Porter's Handbook.

There are a few other whitespace inconsistencies, I think installing textproc/igor and running it on the file igor -R en_US.ISO8859-1/books/porters-handbook/special/chapter.xml (and maybe also run igor -yR en_US.ISO8859-1/books/porters-handbook/special/chapter.xml to get style corrections.)

Thu, May 24, 7:42 AM
mat added a comment to D15544: audio/clementine-player -- sync to github.

Please read Using USE_GITHUB to Access a Commit Between Two Versions to see how your change should be done better.

Thu, May 24, 7:25 AM
mat added inline comments to D15524: sysutils/neofetch: update to 4.0.2.
Thu, May 24, 7:20 AM
mat added inline comments to D13581: www/py-graphite-api: clean up rc.d script - fix ordering in rc.d script - ensure rc.d script returns on startup - ensure working directories are re-created on startup if required submitted by Horst Kapfenberger via BZ223264 https://bugs.freebsd..
Thu, May 24, 7:17 AM
mat added a comment to D15192: devel/aphpbreakdown: flavorize PHP port and update it.

The embargo is on adding FLAVORS to a new port, so that it is not done badly, or not abused. Here, you are using the automatic PHP flavors, which already works correctly, no need to ask for permission. The only thing that you need to think about is on using PKGNAMESUFFIX or PKGNAMEPREFIX, as described in the Porter's Handbook, which we can't help you with as we have no idea what this is.

Thu, May 24, 7:03 AM

Wed, May 23

mat added a comment to D15532: mail/mailsync: Fix build with Clang 6.0.0.

This probably needs a PORTREVISION bump, no?

Wed, May 23, 2:44 PM
mat added inline comments to D15524: sysutils/neofetch: update to 4.0.2.
Wed, May 23, 2:42 PM
mat added a comment to D14899: devel/py-gitpython: Update to 2.1.9.
In D14899#327870, @ygy wrote:
In D14899#326603, @mat wrote:

I am not sure what the "3 consecutive times" adds here, could you explain?

From https://www.freebsd.org/doc/en/books/porters-handbook/makefile-maintainer.html:

If the maintainer does not respond within three months, or if there have been three consecutive timeouts, then that maintainer is considered absent without leave, and can be replaced as the maintainer of the particular port in question.

I realized that the statement could probably be omitted here, but I just wanted to address that. Do you have a better suggestion for this circumstance?

Wed, May 23, 2:35 PM

Tue, May 22

mat committed rP470615: Don't tell people to use @${FLAVOR} in that case, it's bad practice..
Don't tell people to use @${FLAVOR} in that case, it's bad practice.
Tue, May 22, 1:58 PM
mat committed rP470610: Add PY_FLAVOR to Python module dependencies..
Add PY_FLAVOR to Python module dependencies.
Tue, May 22, 1:15 PM
mat committed rP470609: Add Python flavors..
Add Python flavors.
Tue, May 22, 1:15 PM
mat committed rP470604: Update to 4.0.4..
Update to 4.0.4.
Tue, May 22, 11:22 AM

Mon, May 21

mat added inline comments to D15480: textproc/tkdiff: Improve port and give up maintainership.
Mon, May 21, 3:26 PM
mat added inline comments to D15471: Document cargo.mk in the Porter's Handbook.
Mon, May 21, 3:24 PM
mat added a comment to D15460: math/rapid: Fix build on FreeBSD 12, clean up license info, remove dead mirror.

Well, all the variables like RESTRICTED are the "old" way of doing things, the license framework usually covers all the possible cases.

Mon, May 21, 3:11 PM
mat committed rD51691: use an entity there..
use an entity there.
Mon, May 21, 3:05 PM
mat committed rD51690: Stop telling people they cannot do things that work just fine..
Stop telling people they cannot do things that work just fine.
Mon, May 21, 3:03 PM
mat added inline comments to D15079: Update sysutils/hared to 1.0-45.
Mon, May 21, 2:59 PM · Contributor Reviewers (ports)
mat committed rP470540: Add Perl 5.28.0-RC1..
Add Perl 5.28.0-RC1.
Mon, May 21, 1:50 PM
mat committed rP470534: Update to latest commit..
Update to latest commit.
Mon, May 21, 12:33 PM
mat committed rP470533: Update to v5.27.11-44-g22806e5aea..
Update to v5.27.11-44-g22806e5aea.
Mon, May 21, 12:33 PM

Fri, May 18

mat added inline comments to D15471: Document cargo.mk in the Porter's Handbook.
Fri, May 18, 1:33 PM
mat added inline comments to D15133: net/zerotier: update to 1.2.8.
Fri, May 18, 1:30 PM
mat added inline comments to D15460: math/rapid: Fix build on FreeBSD 12, clean up license info, remove dead mirror.
Fri, May 18, 1:28 PM
mat added a comment to D15464: www/fabio: upgrade to 1.5.9.

Is there a PR with this, one the maintainer sent, or approved?

Fri, May 18, 1:24 PM
mat committed rP470291: Note seanc is being mentored..
Note seanc is being mentored.
Fri, May 18, 1:24 PM
mat accepted D15464: www/fabio: upgrade to 1.5.9.
Fri, May 18, 1:24 PM
mat added inline comments to D15463: Mk/Uses/cargo.mk: Encode more crate build dependencies.
Fri, May 18, 1:20 PM
mat added inline comments to D15079: Update sysutils/hared to 1.0-45.
Fri, May 18, 1:14 PM · Contributor Reviewers (ports)
mat added a comment to D14899: devel/py-gitpython: Update to 2.1.9.

I am not sure what the "3 consecutive times" adds here, could you explain?

Fri, May 18, 1:04 PM

Thu, May 17

mat committed rP470199: Those ports have been broken a while now..
Those ports have been broken a while now.
Thu, May 17, 6:32 AM

Wed, May 16

mat added inline comments to D15416: games/cockatrice: Add server component.
Wed, May 16, 10:31 AM
mat added a comment to D15311: Improve security/teleport build.

Mmmm, right, but I really do not feel this edge case needs to be addressed, packages are supposed to be built in a clean environment in poudriere/synth, or as root, I think it's safe to assume that there will not be a ~root/.../go.

Wed, May 16, 10:06 AM
mat added inline comments to D14453: rc.subr: Support loading environmental variables from a file.
Wed, May 16, 6:36 AM

Tue, May 15

mat added a comment to D15311: Improve security/teleport build.

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Tue, May 15, 6:23 PM
mat added a comment to D15434: Mark ports as deprecated which are not required by gitlab 10.7.x anymore.

I wonder if ports that are repocopied only for gitlab should not be marked as DEPRECATED when they are added, so that there is not one that passes through the cracks and gets forgotten.

Tue, May 15, 3:26 PM
mat committed rP469999: lint..
lint.
Tue, May 15, 8:29 AM
mat committed rP469997: On FreeBSD 10, sh handles ${foo:-} differently, and creates an empty.
On FreeBSD 10, sh handles ${foo:-} differently, and creates an empty
Tue, May 15, 7:38 AM
mat requested changes to D15425: databases/ruby-bdb: Allow building as a user on ZFS.

As I cannot reproduce, I definitively think this is the wrong fix for another problem.

Tue, May 15, 7:13 AM
mat added a comment to D15425: databases/ruby-bdb: Allow building as a user on ZFS.

I think by:

Tue, May 15, 6:57 AM
mat added a comment to D15426: devel/py-setuptools : Update to 39.2.0.

Yes, please, request an exp-run.

Tue, May 15, 6:48 AM
mat added inline comments to D15311: Improve security/teleport build.
Tue, May 15, 6:16 AM

Mon, May 14

mat added inline comments to D14798: Add science/dlib-cpp and science/py-dlib ports..
Mon, May 14, 10:49 PM
mat added inline comments to D14576: New port: security/teleport.
Mon, May 14, 10:46 PM
mat added inline comments to D15063: Update multimedia/handbrake to 1.1.0.
Mon, May 14, 10:26 PM
mat added inline comments to D15023: Update editors/texstudio to 2.12.8.
Mon, May 14, 10:23 PM
mat accepted D15407: [New Port] sysutils/dwatch-gource.
Mon, May 14, 10:02 PM
mat committed rP469974: Fix build with Python != 2.7..
Fix build with Python != 2.7.
Mon, May 14, 9:40 PM
mat committed rP469883: Update to latest commit..
Update to latest commit.
Mon, May 14, 12:19 PM
mat committed rP469882: Update to v5.27.11-38-g64a9c78095..
Update to v5.27.11-38-g64a9c78095.
Mon, May 14, 12:18 PM

Sun, May 13

mat added inline comments to D15415: [New Port] sysutils/dwatch-pwsnoop.
Sun, May 13, 8:26 PM
mat added inline comments to D15416: games/cockatrice: Add server component.
Sun, May 13, 8:13 PM
mat added inline comments to D15407: [New Port] sysutils/dwatch-gource.
Sun, May 13, 7:01 PM
mat added inline comments to D15407: [New Port] sysutils/dwatch-gource.
Sun, May 13, 3:52 PM

Wed, May 9

mat added inline comments to D15327: New port: sysutils/gomplate.
Wed, May 9, 10:16 AM
mat added inline comments to D15179: Update sysutils/circonus-agent to 0.13.0.
Wed, May 9, 10:14 AM
mat added inline comments to D14570: New port: sysutils/sockaddr.
Wed, May 9, 10:12 AM
mat added a comment to D15311: Improve security/teleport build.

You need to bump PORTREVISION.

Wed, May 9, 10:11 AM

Mon, May 7

mat committed rP469286: Update to latest commit..
Update to latest commit.
Mon, May 7, 12:42 PM
mat committed rP469285: Update to v5.27.11-30-g38c84d6ad1..
Update to v5.27.11-30-g38c84d6ad1.
Mon, May 7, 12:42 PM
mat committed rP469283: MFH: r468923.
MFH: r468923
Mon, May 7, 10:47 AM

Fri, May 4

mat added inline comments to D15265: Mk/Uses/Emacs: Add noflavors argument to USES=emacs.
Fri, May 4, 7:28 PM

Thu, May 3

mat committed rP468929: Update to 2.0.15..
Update to 2.0.15.
Thu, May 3, 2:06 PM
mat committed rP468923: Update to 20180404..
Update to 20180404.
Thu, May 3, 12:43 PM
mat committed rP468924: flavorize squirrelmail*.
flavorize squirrelmail*
Thu, May 3, 12:43 PM
mat committed rP468917: Add a warning about setting DISTNAME and USE_GITHUB=yes.
Add a warning about setting DISTNAME and USE_GITHUB=yes
Thu, May 3, 9:16 AM
mat committed rP468916: Don't use DISTNAME when using USE_GITHUB..
Don't use DISTNAME when using USE_GITHUB.
Thu, May 3, 9:16 AM

Wed, May 2

mat committed rP468851: flavorize mail/roundcube and plugins..
flavorize mail/roundcube and plugins.
Wed, May 2, 4:16 PM
mat committed rP468843: Note that 10.3 is not supported any more..
Note that 10.3 is not supported any more.
Wed, May 2, 3:00 PM

Mon, Apr 30

mat accepted D15235: www/nextcloud: PHP-flavorize.

Looks ok.

Mon, Apr 30, 3:29 PM
mat committed rD51604: Add a note about PHP_FLAVOR..
Add a note about PHP_FLAVOR.
Mon, Apr 30, 3:14 PM
mat committed rD51602: Flatten the Flavor chapter by removing the encapsulating "Flavors.
Flatten the Flavor chapter by removing the encapsulating "Flavors
Mon, Apr 30, 3:14 PM
mat committed rD51603: Expand a bit the start of the chapter..
Expand a bit the start of the chapter.
Mon, Apr 30, 3:14 PM
mat added a comment to D15235: www/nextcloud: PHP-flavorize.

Don't pass @${FLAVOR} directly, use @${PHP_FLAVOR}.

Mon, Apr 30, 12:24 PM
mat committed rP468689: Update to latest commit..
Update to latest commit.
Mon, Apr 30, 10:50 AM
mat committed rP468688: Update to v5.27.11-23-ga161cde74a..
Update to v5.27.11-23-ga161cde74a.
Mon, Apr 30, 10:50 AM
mat requested changes to D15235: www/nextcloud: PHP-flavorize.

This will break all package depending on nextcloud.

Mon, Apr 30, 10:36 AM

Wed, Apr 25

mat committed rP468307: Only sleep in ports if BATCH/PACKAGE_BUILDING are not defined..
Only sleep in ports if BATCH/PACKAGE_BUILDING are not defined.
Wed, Apr 25, 10:00 PM

Apr 23 2018

mat committed rP468104: Update to 2018.3.0.
Update to 2018.3.0
Apr 23 2018, 4:54 PM
mat committed rP468103: Remove dupplicate port..
Remove dupplicate port.
Apr 23 2018, 4:53 PM
mat committed rP468089: Update to latest commit..
Update to latest commit.
Apr 23 2018, 9:31 AM
mat committed rP468088: Update to v5.27.11-13-g7c07b4b..
Update to v5.27.11-13-g7c07b4b.
Apr 23 2018, 9:30 AM
mat added inline comments to D15159: New Port: devel/mage.
Apr 23 2018, 7:55 AM

Apr 20 2018

mat committed rP467833: Fix with Subversion 1.10. (required is 1.3, so remove the test.).
Fix with Subversion 1.10. (required is 1.3, so remove the test.)
Apr 20 2018, 3:12 PM
mat committed rP467831: flavorize arcanist, libphutil and phabricator..
flavorize arcanist, libphutil and phabricator.
Apr 20 2018, 2:56 PM
mat committed rD51578: Typo in URL..
Typo in URL.
Apr 20 2018, 12:16 PM
mat committed rD51577: Add a missing xml:id on the Phabricator section..
Add a missing xml:id on the Phabricator section.
Apr 20 2018, 12:09 PM
mat committed rD51576: whitespace fixes..
whitespace fixes.
Apr 20 2018, 12:08 PM
mat committed rD51575: Add a procedure for new committers with existing Phabricator account..
Add a procedure for new committers with existing Phabricator account.
Apr 20 2018, 12:08 PM

Apr 18 2018

mat committed rD51570: Add a not on how to use @desktop-file-utils..
Add a not on how to use @desktop-file-utils.
Apr 18 2018, 4:28 PM
mat accepted D14660: deskutils/znotes: Add Qt5 OPTION and support.

accept as portmgr for the flavors part.

Apr 18 2018, 11:12 AM

Apr 17 2018

mat committed rD51564: whitespace..
whitespace.
Apr 17 2018, 11:24 AM
mat committed rD51563: Add missing xml:id to sectx elements..
Add missing xml:id to sectx elements.
Apr 17 2018, 11:20 AM
mat committed rD51561: Split this into substeps..
Split this into substeps.
Apr 17 2018, 11:06 AM
mat committed rD51560: Add a substeps example for the procedure..
Add a substeps example for the procedure.
Apr 17 2018, 11:05 AM