Assuming this was tested on all our supported releases.

Assuming you have tested it and it works.

I am not sure if it is the correct way to fix this either, but note that the src component has a special treatment, for some reason, and also, if you install FreeBSD without the src component from the installer, the resulting freebsd-update.conf file still has the src component,

Well, the bureaucrat in me thinks "open a PR, wait 14 days, commit". ;-)

In D26221#583669, @jrm wrote:

In D26221#583268, @mat wrote:

Why is it quoted in the first place, and why is it broken now?

It looks like it's quoted because in Mk/Uses/python.mk the package list is generated using PYDISTUTILS_INSTALLARGS:= --record ${_PYTHONPKGLIST}. It's broken because different things under Mk/ do not expect a quote, e.g., ${SED} -e 's|^${PREFIX}/||' ${_PYTHONPKGLIST} ${TMPPLIST} or when doing stage-qa.

Why is it quoted in the first place, and why is it broken now?

In D25964#581352, @sbruno wrote:

In D25964#581321, @mat wrote:

The port is missing a DOCS option, also, can you regenerate the pkg-plist file with make makeplist? It is strangely ordered.

I'll regenerate the plist in a sec. With regards to the DOCS option, the CMakeLists.txt has the following, which I think means I can't chose to NOT install docs, right?

install(TARGETS sdltrs          DESTINATION ${CMAKE_INSTALL_BINDIR}/)
install(FILES src/sdltrs.1      DESTINATION ${CMAKE_INSTALL_MANDIR}/man1/)
install(FILES LICENSE           DESTINATION ${CMAKE_INSTALL_DOCDIR}/)
install(DIRECTORY html          DESTINATION ${CMAKE_INSTALL_DOCDIR}/)
install(DIRECTORY diskimages/   DESTINATION ${CMAKE_INSTALL_DATADIR}/sdltrs/)
install(FILES sdltrs.desktop    DESTINATION ${CMAKE_INSTALL_DATADIR}/applications/)
install(FILES icons/sdltrs.png  DESTINATION ${CMAKE_INSTALL_DATADIR}/icons/hicolor/48x48/apps/)
install(FILES icons/sdltrs.svg  DESTINATION ${CMAKE_INSTALL_DATADIR}/icons/hicolor/scalable/apps/)
install(FILES icons/sdltrs.xpm  DESTINATION ${CMAKE_INSTALL_DATADIR}/pixmaps/)

The port is missing a DOCS option, also, can you regenerate the pkg-plist file with make makeplist? It is strangely ordered.

In D26118#579726, @erj wrote:

Output from portlint -AC:

WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: "IGNORE_DragonFly" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS" has to appear earlier.
WARN: Makefile: "ONLY_FOR_ARCHS_REASON" has to appear earlier.
0 fatal errors and 4 warnings found.

The options block is badly ordered, See https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-options.html for the correct ordering of the variables.

Ah, sorry, I should have added that patch files need to have a small comment at the top explaining they why of what they are doing, for example, like https://reviews.freebsd.org/source/ports/browse/head/lang/perl5.32/files/patch-Makefile.SH.

There should be some place where you document why you rename the Object.php file to _Object.php. Because I cannot figure out why myself.

In D25857#573058, @0mp wrote:

I wasn't sure what's the sorting order here but now I get it. LGTM

yeah, looks good.

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Accepting as portmgr for the Mk bits.

This needs to get a PORTREVISION bump.

Please make sure that when committed, this is done by first copying lang/lua53 to lang/lua54.

I am accepting this as portmgr, I assume it works ;-)

accept wrt flavors.

Looks ok. Could you indent the inside of the here documents one step so the only lines that begin with text are ucl?

It looks like you are emulating moving PHPDaemon/Config/Object.php to PHPDaemon/Config/_Object by a rm and a patch adding the file.

I wonder about the design choices behind having "magic" strings everywhere, those %1, %@ and all.