- User Since
- May 9 2014, 10:23 AM (270 w, 5 d)
Mon, Jul 15
Fri, Jul 12
Tue, Jul 9
As you added a list, maybe add another point about excluding -msse* extensions from any non amd64 arch as it limits where the software can run on i386, and it breaks on other architectures. (grep'ing for sse in the tree, it seems there also is -mfpmath=sse.)
Mon, Jul 8
Sun, Jul 7
Fri, Jul 5
Wed, Jul 3
Mon, Jul 1
This is quite similar to D8943.
Sat, Jun 29
- Add a note in the Qt chapter.
I don't think the <sect2> are needed, the section is not long, and having examples in a separate subsection does not make a lot of sense (to me at least).
Fri, Jun 28
Thu, Jun 27
make sure the commit message contains every bit of information that was requested in the PR.
Wed, Jun 26
Ok, so, I am not going to go through the whole patch again. Only use USES=go:no_targets when the targets are added by the framework, like with cmake.
If the port has a do-build and a do-install target use USES=go, do not add the :no_targets.
Tue, Jun 25
I think you are trying to put really too much magic in xorg-cat.
Is there any port that would USES=go:run ? Because there is none in the other review, and we really do not like to add code that is never used.
This probably needs an exp-run to make sure nothing breaks.
if make index passes, it's ok by me.
I don't understand the change you made to the pkg-message file. I asked to choose either install or upgrade, looking at this, it is only needed the first time you install the port, so the second bit about upgrade is not required.
Could you also add documentation for USES=xorg-cat?
Also, to be consistent with the rest of the Ports framework, do not quote words in tests.
Also, could you please run both new mk files through Tools/scripts/indent_make_if.pl so that the indentations is consistent with other files in that directory?
Mon, Jun 24
The sanity bits need to stay, we don't remove them.
Sat, Jun 22
Fri, Jun 21
Do include the explanation in the commit message.
Thu, Jun 20
- Be consistent.
The source files should not be put in the "files" directory, if one day you need to add support files, like *.in files, it will clutter everything. It would be preferable to put them in a src directory.