Also, could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

In D23579#518962, @arrowd wrote:

In D23579#518954, @mat wrote:

Is the sddm.conf file just gone?

Yes. Should I mention it somewhere?

What is gained by this port? Doesn't net-mgmt/unifi5 just work?

Is the sddm.conf file just gone?

Mmmm, I'm sorry, but how is this better?
It add like 15 lines to the file, and now I absolutely cannot read what it does.

The "Created by" lines are the new way of doing things, all the Makefiles were converted a really long while back.

From pkg-lua-script(5):

The following function has been added:
out pkg.prefixed_path(in)
        prepend pkg_prefix to in if needed and returns it as out.

Is there a docuentation of the pkg API for LUA ?

You are missing a PORTREVISION bump.

Fine by me.

Has this been committed yet?

As this surfaces, record my request for changes.

Side note, nobody approved what you committed.

I do not fully understand what this is fixing. It looks like you are just moving things around to use a pipe instead of a temporary variable.

I thought this line caused it to be installed? Could you check the changes I've made to see if they're better/worse please?

why?

• Ajouter une variable PKGNAME.<subpkg>.
• Add PKGNAMES that has the main package name, and subpackage names.

• Ajouter une variable PKGNAME.<subpkg>.

Rebase & remove php.

• Sanitize environment here, sometime, stuff leaks from qa.sh and breaks
• fixup! Add automatic metapkg support for Python flavors.

What I read from the PR is that the example port should be removed instead of being changed.

In D22372#513436, @woodsb02 wrote:

Example port: math/cvc4/Makefile

post-patch:
      @${REINPLACE_CMD} -e "s|sed -i 's|sed -i '' 's|g" \
      ${WRKSRC}/src/fix-install-headers.sh

REINPLACE does not exist.

Please regenerate the patch with make makepatch.

I prefer the current version, it is readable, the new is more like magic and harder to understand.
If I were pedantic I'd say it goes against lessons 1, 2, 5 and probably others of https://en.wikipedia.org/wiki/The_Elements_of_Programming_Style.

The *_DEPENDS are out of order, they have to happen earlier.

Side not, you should not use USE_GITHUB, upstream is providing distfiles, see https://github.com/premake/premake-core/releases

• fixup! Add automatic metapkg support for Python flavors.
• fixup! Add automatic metapkg support for Python flavors.

• Add automatic metapkg support for Python flavors.

rebase

Accept as portmgr.

In D23307#511526, @bcr wrote:

Looks good to me, I think I understand what you mean.

Also, GENTOO is only a cache, and cannot be used as a primary source.

Looks ok to me.