Looks ok to me.

Fixup in

• Start getting php72 to use subpackages.

• Use sed instead of grep here, grep exists if it does not output

Small fix in:

• Strip subpackage markers from the plist. (May not be correct.)

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

In D22279#488628, @cy wrote:

I would start by running portlint, committing a "make portlint happy" commit, then the libpaper commit.

Your git submodule to gh_tuple looks interesting, it should probably be added to the framework and not to a specific port.

rebase.

Isn't there some place where this value can come from? Because it feels a bit silly to have to update that every couple of years.

devel/binutils could use a bit of love wrt https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html to make it more readable.

In D22210#485892, @zeising wrote:

Is it possible to get blanket approval for adding USES=xorg, gl as needed throughout the ports tree?

In D22210#485892, @zeising wrote:

In D22210#485882, @mat wrote:

It would be much simpler to just add xorg to USES instead of sharing private variables everywhere.

Yes, however, that requires walking through the entire ports tree, which is a huge task.

In D21974#485929, @rene wrote:

In D21974#485928, @mat wrote:

IMHO, the only thing that should be merged to 2019Q4 is line 1165 of bsd.port.mk.

OK. That might be easier if that line is committed first in its own commit.

IMHO, the only thing that should be merged to 2019Q4 is line 1165 of bsd.port.mk.

Could you please also remove it from the porter's handbook? And maybe check if it is not referenced somewhere else in the doc tree before proceeding?

Or the DEV_WARNING should only be added to if xorg-cat, gl, motif... are not part of USES either.

It would be much simpler to just add xorg to USES instead of sharing private variables everywhere.

Should't this be a USES instead of some new code in bsd.port.mk?

• Rework a bit.

• Expand a bit.

Well, it looks ok to me.

Remove portmgr, no more flavors.