In D20329#438589, @cem wrote:

In D20329#438578, @mat wrote:

(NO_PACKAGE does not do what you think it does.)

Can you elaborate? What does it do, and why do you think that's different from what I think?

$ make -C net/dpdk package
===>  dpdk-18.05.1 may not be packaged: ignores cflags.

So please remove the PORTREVISION bump.

Are those build fixes or runtime fixes ? Because if they are build fixes, you do not need to bump PORTREVISION as their is no previous package of that version.

Looks ok, pending maintainer's approval.

Wondering if this needs an exp-run.

Accept as your mentor, you still need to have approval from the maintainer, @hrs.

Adding USES=gssapi's maintainer.

Looks good.

I don't think adding all these tests to make sure you only add it in the specific case where it will happen is a great idea.

Wait, no, this does not work.

I think it would probably be best to ignore it in bsd.sanity.mk, rather than patch it here.

Though, the last two patches should be excluded, nothing in them changes really.

no flavors any more.

I agree with @wblock, V=1 seems arbitrary, it should probably be in either a subsection or an example, explaining in which case it works.

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

It only supports AND, all versions comparison you put must match.

It has been supported ever since we switched to pkg years ago.

Other than my last small comment, the part in Mk looks ok to me.

In D20092#434630, @emaste wrote:

In D20092#433030, @tijl wrote:

This isn't about having my own rules. It's about being practical. The further PORTVERSION and RPMVERSION are apart the more difficult it is to check the current version of the port. Now, RPMVERSION is really a leftover from before Uses/linux.mk. It is only used to set DISTVERSIONSUFFIX nowadays so perhaps it is time to eliminate it and set DISTVERSIONSUFFIX directly (right after PORTVERSION).

@mat, should @trasz make that change? I hope this change is not held up too long for an issue that has no clear resolution - i.e., what's the next thing to do here?

rebase.

Cleanup fixes.

• Fix a small bug in the USE_GITLAB extra distfile naming.
• Fix Ports affected by previous fix.

It's only taken me a year to see an obvious bug in the code. (I'm working on cleaning things up a bit in D20140, and it'll be fixed there.)

• Fix the a ports that were broken but did not know it.

• Bit more correct way.