(approving this as portmgr so that phabricator does not gives you grief.)

You don't need to bump PORTREVISION if you only remove a build-time dependency.

The comments apply to the three Makefiles.

I don't think the %%VER%% is a good idea, through the life of the port it does not change. It only changes when there is a new major version, and it's as simple to handle as to run make makeplist.

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

What happened to all the html files in DOCSDIR?

• llvm is in devel, not lang.

In D19562#419088, @mat wrote:

Also, it is somewhat impossible to do it with a variable set in a dependency, because their Makefile is not read when a port is installed, or they could already be installed.

Maybe ports that USES=metaport should get a warning when they are being depended upon, but it's a somewhat different subject.

• Reword error message.

In D19562#419048, @adamw wrote:

It seems to me that most meta-ports should not be direct dependencies. Why not generalize this? DEPEND_ALTERNATIVE= USES=python:xy with a specific version

Requiring a change in qa.sh might deter people from using this behaviour in other ports when they probably should.

• Add a comment about why this is for.

In D19569#418889, @tobik wrote:

# Port				bogus args
games/ski			3.2+:run
net-mgmt/librenms-agent		2.7:run
sysutils/py-python-consul	2.7-3.6+
sysutils/xen-guest-tools	configure

All the USES that validate their arguments set IGNORE so that the mistake is found out early. I think this should also be setting IGNORE. Also, could you check that the arguments to USES=python:xxx are also validated?

Yes please.

This looks good, let me just have a closer look at it this week.

Looks ok to me, maybe s/:4/:5/ as Tobias said as :4 is already half gone.

Thank you.

The manpages should not be behind the DOCS option, they should either always be installed, or be behind a MANPAGES option (that defaults to on).

In D19318#416607, @rigoletto wrote:

@mat

Several of ocaml-* ports have this license: LGPL[v2+] with linking exception. What would be the best way to handle them, just set

LICENSE=LGPL20+

or

LICENSE=LGPL20+
LICENSE_NAME=LGPL with linking exception

or other?

Thank you.

• little comment.
• Add lang/llvm.

• lang/python can depend on lang/pythonX.

I am not sure /usr/local/tests is the right place to put these files, it should probably more be something like /usr/local/share/tests.

In D19338#416053, @rigoletto wrote:

@mat GNOMESHELL_PORTDOCS isn't working. The file isn't added to PORTDOCS.

In D19244#414408, @arrowd wrote:

I'm not going to mark 500 ports as deprecated manually, nor I want to write/search for a script to do that. I'll just let them decay naturally, then.

• Remove now useless newlines.
• This too should be ucl.
• The file is never empty now, but with no messages, it is ok.
• Don't use echo flags.
• Put the deprecation date message with the deprecation message.