Looks ok to me

cleanup

cleanup

fix a couple of usage of WITHOUT_*

updated comment

cleanup a bit

In D44487#1014655, @arrowd wrote:

we want users to stop using ports and use packages

Who "we"? I don't want that and will keep working in the direction I deem useful.

An interactive thing is nice and all, but we want users to stop using ports and use packages, so the sponsorship information should end up in the package's metadata, you should talk with @bapt to see how this could be done best.

Can you re-upload the diff with arcanist or by generating the diff with more context, like arcanist does (git diff -U9999)

I don't think LEGAL is used anywhere anyway.

This seems ok, if you have actually tested things still work after the conversion, go ahead.

As for portmgr approval, the conversion seems straightforward, if you have actually tested things still work after the conversion, go ahead.

In D43515#994013, @emaste wrote:

The current approach creates multiple .debug directories, while @bapt suggested to use ${LOCALBASE}/lib/debug to mirror /usr/lib/debug.

Note that debuggers will not search in ${LOCALBASE}/lib/debug/ by default, so although I think that's the "nicer" option I'd say using .debug to start is better.

Bear in mind that make has no local variables, every variable is global.

In D43587#994067, @pizzamig wrote:

The idea is that every time a USES is included, it generates a USES_*_DEPENDS
Those prefixed depends are going to be copied to the appropriate *_DEPENDS (without suffix main package, with suffixes for the subpackages)

USES= gnome=libxml2

It will set USES_LIB_DEPENDS= libxml2.so:textproc/libxml2and it will be added to LIB_DEPENDS

USES.gtk3= gnome=gtk30

It will set USES_LIB_DEPENDS= libgtk-3.so:x11-toolkits/gtk30and it will be added to LIB_DEPENDS.gtk3

And so on.

So, if I have:

The guimantrans seems to be a bit overboard, just put all the translated man pages into mantrans.

One enhancements you could add is enable MANTRANS by default and put those files in a mantrans subpackage.

This looks ok to me, but with the missing context, it's a bit hard to see if it could be made even better.

This looks good to me, but maybe someone else should have a look too.

devel/appstream-qt should probably be moved to devel/appstream-qt5.

What about adding the qt6 bits to the main port and only keep the qt5 as the slave port without flavors ?