It builds fine at my side with pudriere: build of sysutils/uefi-edk2-qemu | uefi-edk2-qemu-x86_64-g20190307_1 ended at Wed Sep 11 09:26:10 CST 2019
Wed, Sep 11
Tue, Sep 10
USE_GCC will set build-time and run-time dependency, if we need only build-time dependency the patch looks good to me.
Mon, Sep 9
Mon, Sep 2
Wed, Aug 28
Tue, Aug 27
Aug 2 2019
I worry this might be a bit premature. New features for bhyve are often developed without capsicum because capsicum is a pain to work with. The debug server didn't use it at first, save/restore currently disables it as does the 9p patch. Removing WITHOUT_CAPSICUM makes coordinating that existing work harder. It also adds a pretty good barrier to entry when trying to add new things that add new ioctls, etc.
It's not much more work to add a new right in a driver that already works under capsicum than it is to add -DWITHOUT_CAPSICUM to the build flags.
Aug 1 2019
I wonder if it makes more sense to do this in vmrun.sh? OTOH, it's probably fine to do this. We should also probably do it in bhyverun.c since bhyveload isn't used in the UEFI case. Another option would be to do this in the vm_create() wrapper in libvmmapi in which case that would fix bhyveload, grub2-bhyve, and bhyve all in one place.
Jul 30 2019
Committed already at r349335
I'm commandeer this revision because this patch were committed already by @scottl: https://svnweb.freebsd.org/base?view=revision&sortby=date&revision=349335
@jhb Perhaps do the same with bhyverun.c?
Jul 28 2019
Ok, I'm gonna do it tomorrow!!!
Jul 25 2019
Jul 24 2019
@jhb Any objection if I proceed to commit this patch? I just hit the same situation "forgot to load vmm" and this patch does fix it.
The problem here is that you will not be able to build this code on other platforms like Solaris.
I'm not sure if this is applicaple for bhyve, if not then the change looks good to me.
Remove CASPER from Makefile as we don't use any service.
Jul 16 2019
Jul 3 2019
Jun 25 2019
Jun 22 2019
Jun 17 2019
May 23 2019
Apr 28 2019
Apr 24 2019
LGTM! Thank you!
Apr 19 2019
double accept this revision!
Apr 15 2019
Any news about this patch?
I'm fine with that too! We can have it as it is and later evolve it.
Apr 14 2019
- Also remove SHEBANGFIX not needed.
- Update ONLY_FOR_ARCHS that was replaced wrong.
Address @bcran suggestions!
Apr 10 2019
I did only smoke tests!! Do you mind do additional tests with different guests?
Apr 3 2019
It looks good! Thanks again @chuck
Mar 26 2019
Sooooooooo. Is anybody going to help me fix this or approve this? ;-) I am still waiting.
Mar 23 2019
Mar 15 2019
Feb 22 2019
If anybody else is interested on this patch, ping me and I can share my latest changes. However I'm not interested on it anymore.
I have added @mav as a reviewer, I know he has worked with the hda drivers before.
Feb 8 2019
I still feel locked out of usr.sbin/bhyve, mostly of the commits made there in the past year were made by myself or reviewed by myself. Would be fair have my name explicit in that area, I don't want bypass reviews, it is more about the effort I have put in that area and appreciation of it, otherwise doesn't make sense for me to keep contributing with bhyve.
Feb 3 2019
Please, reopen the review, when I'm back from holidays I will help you.
Feb 1 2019
Jan 31 2019
It is basically a cosmetic change, so I have committed it already: r343634.