User Details
- User Since
- Mar 1 2018, 4:23 AM (150 w, 6 d)
Nov 17 2020
There is some code style should be fixed.
Sep 18 2020
Sep 11 2020
Yes, New update solves my problem. As the previous patch, when Host reboot, it got stalled at BIOS logo, and I had to unplug the power cord.
Now it works flawless.
Sep 4 2020
Thank you!
I follow your instructions, and it works.
Thank you for your update.
I want to test this patch. Currently, I am using a Lenovo M920Q with i5 8400T, 16G RAM, and 2 SSDs.
Great.
Definitely my fault. I forgot checking the build with SNAPSHOT while doing the modification of ata_ident in D24174
Aug 12 2020
I am sorry, I am new to this review system.
@chuck Do I need to do any action now or just wait?
Aug 6 2020
- Create handle_smart() and copy_identify() function.
Aug 2 2020
Update manpage and comments.
Add CAPSICUM ability to current patch.
Thank you chuck.
I am bring back and update this patch as your comments.
Update code sytle and comments.
Jul 31 2020
When I am using NVMe device as cache for XPEnology guest, it shows that NVMe device is not healthy, cannot be used. because these two fields are 0.
Jul 29 2020
Jun 28 2020
Normally Controller SN/MODEL/REV are the one set informations to identify the device by human.
Currently initial the SN in pci_nvme_parse_opts already.
Jun 24 2020
Drop ahci_checksum() from handle_identify() and handle_atapi_identify(),
The checksum caculation will happen at the end of ata_identify_init() function.
Also drop local variables which only use one time.
- Update code as comment suggested.
- Update comment as suggested.
- Set default Firmware Revision to __FreeBSD_version
Jun 23 2020
- Fix code style as suggested.
- Fix code style as suggested.
Jun 22 2020
When parse opts, single config can also be accepted.
Should have a better way to initial health log.
Fix a manpage typo in bhyve.8
Setting serial number in command line should be ser instead of serial.
May 31 2020
We have ahci-cd and ahci-hd, because cd and hdd are different a lot. while hdd and ssd, just only a little difference.
I am fine with ahci-ssd, but 'Nominal Media Rotation Rate' can also benefit when user try to specify the rotation rate, such as 5400/7200/15000 etc. since I can't image why user specify such value for vm.
May 20 2020
Please give me any suggestion on this patch? good to go or not?
Mar 27 2020
- Update bhyve manpage
- Update bhyve manpage
- Fix a code style.
- Inital serial/rev/model first.
- deal with feedback.
Mar 25 2020
- fix coding style.
fix a unfree memory.
restore unused0 varible.
replace fix value defined in ata.h
fix comment.
Mar 24 2020
Since this is modification also affect block_if.c, to narrow down the change. this revision is abandoned.