Page MenuHomeFreeBSD

wanpengqian_gmail.com (Wanpeng Qian)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 1 2018, 4:23 AM (133 w, 3 d)

Recent Activity

Fri, Sep 18

wanpengqian_gmail.com updated the test plan for D26472: bhyve: Fix language id of String Descriptors in usb mouse..
Fri, Sep 18, 1:02 AM
wanpengqian_gmail.com requested review of D26472: bhyve: Fix language id of String Descriptors in usb mouse..
Fri, Sep 18, 1:00 AM

Fri, Sep 11

wanpengqian_gmail.com added a comment to D26209: GVT-d support for bhyve.

Fixed Issues:

  1. register_bar and unregister_bar functions doesn't handle MSI-X BAR properly

Yes, New update solves my problem. As the previous patch, when Host reboot, it got stalled at BIOS logo, and I had to unplug the power cord.
Now it works flawless.

Fri, Sep 11, 11:33 AM · bhyve

Fri, Sep 4

wanpengqian_gmail.com added a comment to D26209: GVT-d support for bhyve.

Thanks you!
I follow your instructions, and it works.

Fri, Sep 4, 11:06 PM · bhyve
wanpengqian_gmail.com added a comment to D26209: GVT-d support for bhyve.

Thank you for your update.

Fri, Sep 4, 1:12 PM · bhyve
wanpengqian_gmail.com added a comment to D26209: GVT-d support for bhyve.

I want to test this patch. Currently, I am using a Lenovo M920Q with i5 8400T, 16G RAM, and 2 SSDs.

Fri, Sep 4, 1:44 AM · bhyve
wanpengqian_gmail.com added a comment to D26263: bhyve: Fix build with option BHYVE_SNAPSHOT.

Great.
Definitely my fault. I forgot checking the build with SNAPSHOT while doing the modification of ata_ident in D24174

Fri, Sep 4, 12:53 AM · bhyve

Aug 12 2020

wanpengqian_gmail.com added inline comments to D26035: Refactor configuration management in bhyve..
Aug 12 2020, 7:35 AM
wanpengqian_gmail.com accepted D24202: bhyve: Initial some NVMe controller health log data..

I am sorry, I am new to this review system.
@chuck Do I need to do any action now or just wait?

Aug 12 2020, 5:25 AM
wanpengqian_gmail.com added a comment to D26035: Refactor configuration management in bhyve..

Maybe you are not familiar enough with the bhyve configuration fie attempt implementations!!!
I will drop these slides here: https://docs.google.com/presentation/d/15s9rWCe8ILJB-wTP_cZFFWZrAPI0IzG3jKvi_2zHgss/edit?usp=sharing

Aug 12 2020, 5:05 AM
wanpengqian_gmail.com added a comment to D26035: Refactor configuration management in bhyve..

The configuration file is not intuitive at all, how I will know what pci slot my virtio-blk shall live?
Why not simplify it instead of complicate more? The configuration file supposed to be something to simplify the command line, and instead is getting more complex than bhyve cli itself. Perhaps we will need another io<something> wrapper to simplify the creation of bhyve configuration files.

Could we use a similar approach of the configuration file syntax like everybody else is using? I know make things simple is hard.

Aug 12 2020, 2:26 AM
wanpengqian_gmail.com added inline comments to D26035: Refactor configuration management in bhyve..
Aug 12 2020, 2:15 AM

Aug 6 2020

wanpengqian_gmail.com updated the summary of D25975: bhyve: Passthrough SMART from host device to virtual AHCI disk..
Aug 6 2020, 3:43 PM
wanpengqian_gmail.com updated the diff for D25975: bhyve: Passthrough SMART from host device to virtual AHCI disk..
  • Create handle_smart() and copy_identify() function.
Aug 6 2020, 3:41 PM
wanpengqian_gmail.com requested review of D25975: bhyve: Passthrough SMART from host device to virtual AHCI disk..
Aug 6 2020, 3:11 PM

Aug 2 2020

wanpengqian_gmail.com requested review of D25919: bhyve: NVMe controller can clone identify of host's NVMe device.
Aug 2 2020, 2:24 PM
wanpengqian_gmail.com updated the diff for D25876: bhyve: Passthrough host's NVMe device health logpage to guests..

Update manpage and comments.

Aug 2 2020, 4:45 AM
wanpengqian_gmail.com updated the diff for D25876: bhyve: Passthrough host's NVMe device health logpage to guests..

Add CAPSICUM ability to current patch.

Aug 2 2020, 4:29 AM
wanpengqian_gmail.com added a comment to D25876: bhyve: Passthrough host's NVMe device health logpage to guests..

Having written code to read Health data from SCSI, ATA, and NVMe devices and present it in a common format, I experienced first hand the complexities this entails. And even after adding this complexity, it would not cover use cases like file or ZVol backing storage. Instead, it might be better to use pptdevs if the VM requires more realistic data.

Aug 2 2020, 12:33 AM
wanpengqian_gmail.com added a comment to D24202: bhyve: Initial some NVMe controller health log data..

Thank you chuck.
I am bring back and update this patch as your comments.

Aug 2 2020, 12:05 AM
wanpengqian_gmail.com updated the diff for D24202: bhyve: Initial some NVMe controller health log data..

Update code sytle and comments.

Aug 2 2020, 12:03 AM

Jul 31 2020

wanpengqian_gmail.com added a comment to D25876: bhyve: Passthrough host's NVMe device health logpage to guests..

When I am using NVMe device as cache for XPEnology guest, it shows that NVMe device is not healthy, cannot be used. because these two fields are 0.

Jul 31 2020, 11:58 PM

Jul 29 2020

wanpengqian_gmail.com updated the summary of D25876: bhyve: Passthrough host's NVMe device health logpage to guests..
Jul 29 2020, 8:54 AM
wanpengqian_gmail.com requested review of D25876: bhyve: Passthrough host's NVMe device health logpage to guests..
Jul 29 2020, 8:49 AM

Jun 28 2020

wanpengqian_gmail.com added a comment to D25396: bhyve nvme controller will pass unknown config if using blockif backend.

I like your suggestion of explicitly specifying devpath but need to think about the implications especially with regards to backwards compatibility.

Jun 28 2020, 11:02 PM
wanpengqian_gmail.com added a comment to D25399: bhyve NVMe controller will accept model/rev config..

Normally Controller SN/MODEL/REV are the one set informations to identify the device by human.
Currently initial the SN in pci_nvme_parse_opts already.

Jun 28 2020, 10:59 PM

Jun 24 2020

wanpengqian_gmail.com added inline comments to D24889: bhyve: implement NVMe Format NVM command.
Jun 24 2020, 7:36 AM
wanpengqian_gmail.com added a comment to D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.

Drop ahci_checksum() from handle_identify() and handle_atapi_identify(),
The checksum caculation will happen at the end of ata_identify_init() function.
Also drop local variables which only use one time.

Jun 24 2020, 4:28 AM
wanpengqian_gmail.com updated the diff for D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.
  • Update code as comment suggested.
Jun 24 2020, 4:21 AM
wanpengqian_gmail.com updated the diff for D25396: bhyve nvme controller will pass unknown config if using blockif backend.
  • Update comment as suggested.
Jun 24 2020, 1:24 AM
wanpengqian_gmail.com updated the diff for D25399: bhyve NVMe controller will accept model/rev config..
  • Set default Firmware Revision to __FreeBSD_version
Jun 24 2020, 1:18 AM
wanpengqian_gmail.com added a comment to D25396: bhyve nvme controller will pass unknown config if using blockif backend.

I think it is reasonable to require the blockif options immediately follow the block device name/path such that blockif_open() can parse its optional parameters. This has the added benefit of simplifying the changes made here. For this to work, the easiest option would be to require the user to specify devpath and any options last. For example:

-s 0:4:0,nvme,maxq=256,/dev/zvol/zroot/vol0,nocache,sectorsize=512

In an ideal world, the user should be able to specify devpath and its options anywhere within the configuration, but that would require teaching blockif_open() a) to stop processing options when it reaches one it doesn't recognize instead of returning an error and b) returning an indication of where it stopped processing.

Jun 24 2020, 12:43 AM
wanpengqian_gmail.com added inline comments to D25399: bhyve NVMe controller will accept model/rev config..
Jun 24 2020, 12:06 AM

Jun 23 2020

wanpengqian_gmail.com updated the diff for D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.
  • Fix code style as suggested.
Jun 23 2020, 1:26 AM
wanpengqian_gmail.com updated the diff for D25399: bhyve NVMe controller will accept model/rev config..
  • Fix code style as suggested.
Jun 23 2020, 1:22 AM
wanpengqian_gmail.com added inline comments to D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.
Jun 23 2020, 12:48 AM

Jun 22 2020

wanpengqian_gmail.com updated the summary of D25396: bhyve nvme controller will pass unknown config if using blockif backend.
Jun 22 2020, 8:57 PM
wanpengqian_gmail.com requested review of D25399: bhyve NVMe controller will accept model/rev config..
Jun 22 2020, 8:13 AM
wanpengqian_gmail.com added a reviewer for D25396: bhyve nvme controller will pass unknown config if using blockif backend: jhb.
Jun 22 2020, 6:25 AM
wanpengqian_gmail.com updated the diff for D25396: bhyve nvme controller will pass unknown config if using blockif backend.

When parse opts, single config can also be accepted.

Jun 22 2020, 6:19 AM
wanpengqian_gmail.com updated the summary of D25396: bhyve nvme controller will pass unknown config if using blockif backend.
Jun 22 2020, 4:34 AM
wanpengqian_gmail.com requested review of D25396: bhyve nvme controller will pass unknown config if using blockif backend.
Jun 22 2020, 4:25 AM
wanpengqian_gmail.com abandoned D24202: bhyve: Initial some NVMe controller health log data..

Should have a better way to initial health log.

Jun 22 2020, 2:15 AM
wanpengqian_gmail.com updated the diff for D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.

Fix a manpage typo in bhyve.8
Setting serial number in command line should be ser instead of serial.

Jun 22 2020, 2:06 AM

May 31 2020

wanpengqian_gmail.com added a comment to D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.

We have ahci-cd and ahci-hd, because cd and hdd are different a lot. while hdd and ssd, just only a little difference.
I am fine with ahci-ssd, but 'Nominal Media Rotation Rate' can also benefit when user try to specify the rotation rate, such as 5400/7200/15000 etc. since I can't image why user specify such value for vm.

May 31 2020, 3:03 PM

May 20 2020

wanpengqian_gmail.com added reviewers for D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config: jhb, grehan.

Please give me any suggestion on this patch? good to go or not?

May 20 2020, 1:14 AM

Mar 27 2020

wanpengqian_gmail.com updated the summary of D24202: bhyve: Initial some NVMe controller health log data..
Mar 27 2020, 12:58 PM
wanpengqian_gmail.com created D24202: bhyve: Initial some NVMe controller health log data..
Mar 27 2020, 12:49 PM
wanpengqian_gmail.com abandoned D24201: Initial some bhyve NVMe controller health log data.
Mar 27 2020, 12:41 PM
wanpengqian_gmail.com created D24201: Initial some bhyve NVMe controller health log data.
Mar 27 2020, 12:40 PM
wanpengqian_gmail.com updated the diff for D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.
  • Update bhyve manpage
Mar 27 2020, 12:14 PM
wanpengqian_gmail.com updated the diff for D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.
  • Update bhyve manpage
Mar 27 2020, 12:13 PM
wanpengqian_gmail.com updated the diff for D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.
  • Fix a code style.
  • Inital serial/rev/model first.
Mar 27 2020, 11:38 AM
wanpengqian_gmail.com added inline comments to D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.
Mar 27 2020, 11:26 AM
wanpengqian_gmail.com updated the diff for D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.
  • deal with feedback.
Mar 27 2020, 11:15 AM

Mar 25 2020

wanpengqian_gmail.com retitled D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config from bhyve AHCI controller will accept ser/rev/model/nmrr config. to bhyve AHCI controller will accept ser/rev/model/nmrr config.
Mar 25 2020, 1:28 AM
wanpengqian_gmail.com updated the diff for D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.
  • fix coding style.
Mar 25 2020, 12:48 AM
wanpengqian_gmail.com updated the diff for D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.

fix a unfree memory.
restore unused0 varible.
replace fix value defined in ata.h
fix comment.

Mar 25 2020, 12:42 AM

Mar 24 2020

wanpengqian_gmail.com added inline comments to D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.
Mar 24 2020, 12:41 PM
wanpengqian_gmail.com added inline comments to D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.
Mar 24 2020, 11:56 AM
wanpengqian_gmail.com abandoned D24084: bhyve ahci controller report Nominal Media Rotation Rate field.

Since this is modification also affect block_if.c, to narrow down the change. this revision is abandoned.

Mar 24 2020, 11:19 AM
wanpengqian_gmail.com created D24174: bhyve AHCI controller will accept ser/rev/model/nmrr config.
Mar 24 2020, 11:08 AM

Mar 16 2020

wanpengqian_gmail.com added a reviewer for D24084: bhyve ahci controller report Nominal Media Rotation Rate field: grehan.
Mar 16 2020, 2:01 AM
wanpengqian_gmail.com created D24084: bhyve ahci controller report Nominal Media Rotation Rate field.
Mar 16 2020, 1:57 AM

Mar 11 2020

wanpengqian_gmail.com added a watcher for bhyve: wanpengqian_gmail.com.
Mar 11 2020, 8:55 AM