- User Since
- Mar 1 2018, 4:23 AM (290 w, 3 d)
Nov 17 2022
Nov 14 2022
Nov 11 2022
address reviewer feedback.
drop init value of report_crit
I agree with chuck. fw_num_slots can't be zero. If it's zero, your controller will be broken and you can't rely on any of these values. So, I think it makes no sense to keep the if.
unconditionly print fw_slot1_ro.
I think Chuck is right. output fw_num_slots unconditionally, but for Firmware Slot 1 Read-Only, we have to make sure the fw_num_slots is bigger than zero. othersize it is meaningless. Although the NVMe controller should at least have one firmware slot.
unconditionally print fw_num_slots.
Nov 10 2022
All right, I think for unimplemented features, always return FEATURE NOT CHANGEABLE is compliant to the spec. and for implemented features, it is up to the implementation.so I am reclaiming this patch. thanks.
@corvink Can you please help me verify if this patch solve the issue? it needs an Intel SSD for verifying.
Address reviewers' feedback.
Address reviews' feedback.
Nov 9 2022
Oct 28 2022
- remove a unnecessary include
- fix typo
- fix code style of switch
- combine all changes to one commit.
- build check with CURRENT source.
- correct manpages
Oct 21 2022
I have built a test ISO and it works as expected within the BHYVE virtual machine with following conditions
Oct 20 2022
Update as reviewer suggested.
Oct 19 2022
@imp I am sorry for the previous samsung patch that I didn't compile on the i386 platform to have checked.
@kevans I am sorry I just picked up the latest commiter from bsdinstall history,
maybe you can take a look for this patch. I have been suffering from this issue for many years.
Rollback to previous diff.
Update code as requested.
Can we give a go for this patch?
catch up with the latest source.
- Fix code style, match style(9) as @imp requested.
- Fix typo and uppercase vendor‘s name as @pauamma requested.
- Commit new files(by miss).
- Update manpage, fix typo and uppercase vendor's name.
- Fix code style, match style(9)
Oct 17 2022
I tested with 14.0-CURRENT Oct 10 2022, and it works. Is it the right direction for dynamically changing the disk size after hosts resize the disk?
Oct 7 2022
Update to match the latest source.
Sep 30 2022
Sep 5 2022
Can we have a universal PCI vendor/subvendor setting for all PCI devices instead of for particular PCI devices? other pci devices may want to change the ID/subID too. For example, if I want to fake the NVMe controller as an Intel one.
Aug 31 2022
Aug 29 2022
Here is the compare result with smartctl, for a intel optane 16GB nvme drive
Aug 26 2022
Aug 25 2022
Although I insist on adding the calculation of PowerOnHours. For now, this patch only adds the init value of PowerCycles.
As reviewer suggested, only init PowerCycles value for now.
@imp Can we give a go for this?
Apr 6 2022
I got a intel Xe DG1 dedicated graphics adapter. I will try it later.
Mar 29 2022
remove incorrect oacs setting.
Mar 28 2022
Can we merge this patch to HEAD?
Mar 25 2022
Any comments on this?
Obviously guest OS will work properly without this patch, but we can make the simulation more real.