There is some code style should be fixed.

In D26209#587138, @c.koehne_beckhoff.com wrote:

Fixed Issues:

1. register_bar and unregister_bar functions doesn't handle MSI-X BAR properly

Yes, New update solves my problem. As the previous patch, when Host reboot, it got stalled at BIOS logo, and I had to unplug the power cord.
Now it works flawless.

Thank you!
I follow your instructions, and it works.

Thank you for your update.

I want to test this patch. Currently, I am using a Lenovo M920Q with i5 8400T, 16G RAM, and 2 SSDs.

Great.
Definitely my fault. I forgot checking the build with SNAPSHOT while doing the modification of ata_ident in D24174

I am sorry, I am new to this review system.
@chuck Do I need to do any action now or just wait?

In D26035#577645, @araujo wrote:

Maybe you are not familiar enough with the bhyve configuration fie attempt implementations!!!
I will drop these slides here: https://docs.google.com/presentation/d/15s9rWCe8ILJB-wTP_cZFFWZrAPI0IzG3jKvi_2zHgss/edit?usp=sharing

In D26035#577636, @araujo wrote:

The configuration file is not intuitive at all, how I will know what pci slot my virtio-blk shall live?
Why not simplify it instead of complicate more? The configuration file supposed to be something to simplify the command line, and instead is getting more complex than bhyve cli itself. Perhaps we will need another io<something> wrapper to simplify the creation of bhyve configuration files.

Could we use a similar approach of the configuration file syntax like everybody else is using? I know make things simple is hard.

• Create handle_smart() and copy_identify() function.

Update manpage and comments.

Add CAPSICUM ability to current patch.

In D25876#574103, @chuck wrote:

Having written code to read Health data from SCSI, ATA, and NVMe devices and present it in a common format, I experienced first hand the complexities this entails. And even after adding this complexity, it would not cover use cases like file or ZVol backing storage. Instead, it might be better to use pptdevs if the VM requires more realistic data.

Thank you chuck.
I am bring back and update this patch as your comments.

Update code sytle and comments.

When I am using NVMe device as cache for XPEnology guest, it shows that NVMe device is not healthy, cannot be used. because these two fields are 0.

In D25396#561806, @chuck wrote:

I like your suggestion of explicitly specifying devpath but need to think about the implications especially with regards to backwards compatibility.

Normally Controller SN/MODEL/REV are the one set informations to identify the device by human.
Currently initial the SN in pci_nvme_parse_opts already.

Drop ahci_checksum() from handle_identify() and handle_atapi_identify(),
The checksum caculation will happen at the end of ata_identify_init() function.
Also drop local variables which only use one time.

• Update code as comment suggested.

• Update comment as suggested.

• Set default Firmware Revision to __FreeBSD_version

In D25396#560854, @chuck wrote:

I think it is reasonable to require the blockif options immediately follow the block device name/path such that blockif_open() can parse its optional parameters. This has the added benefit of simplifying the changes made here. For this to work, the easiest option would be to require the user to specify devpath and any options last. For example:

-s 0:4:0,nvme,maxq=256,/dev/zvol/zroot/vol0,nocache,sectorsize=512

In an ideal world, the user should be able to specify devpath and its options anywhere within the configuration, but that would require teaching blockif_open() a) to stop processing options when it reaches one it doesn't recognize instead of returning an error and b) returning an indication of where it stopped processing.

• Fix code style as suggested.

• Fix code style as suggested.

When parse opts, single config can also be accepted.

Should have a better way to initial health log.

Fix a manpage typo in bhyve.8
Setting serial number in command line should be ser instead of serial.

We have ahci-cd and ahci-hd, because cd and hdd are different a lot. while hdd and ssd, just only a little difference.
I am fine with ahci-ssd, but 'Nominal Media Rotation Rate' can also benefit when user try to specify the rotation rate, such as 5400/7200/15000 etc. since I can't image why user specify such value for vm.

Please give me any suggestion on this patch? good to go or not?

• Update bhyve manpage

• Update bhyve manpage

• Fix a code style.
• Inital serial/rev/model first.

• deal with feedback.

• fix coding style.

fix a unfree memory.
restore unused0 varible.
replace fix value defined in ata.h
fix comment.

Since this is modification also affect block_if.c, to narrow down the change. this revision is abandoned.