Page MenuHomeFreeBSD

wanpengqian_gmail.com (Wanpeng Qian)
Software Engineer

Projects

User does not belong to any projects.

User Details

User Since
Mar 1 2018, 4:23 AM (196 w, 6 d)

Recent Activity

Sat, Dec 4

wanpengqian_gmail.com updated the summary of D32657: bhyve: Fix the wrong Number of Power States Support value also set a reasonable Max Power for NVMe controller.
Sat, Dec 4, 12:51 AM
wanpengqian_gmail.com updated the summary of D32558: bhyve: initial PowerCycles value and implement PowerOnHours caculation.
Sat, Dec 4, 12:50 AM
wanpengqian_gmail.com updated the summary of D32659: bhyve: fix Number of Firmware Slot and Slot1 ReadOnly advertise are ignored..
Sat, Dec 4, 12:50 AM
wanpengqian_gmail.com updated the summary of D32844: nvme: move nested result struct out of nvme_device_self_test_page for further reference..
Sat, Dec 4, 12:50 AM
wanpengqian_gmail.com added a comment to D32957: nvmecontrol: improve namespace size unit of devlist command output.

I have added the 'Signed-off-by:' line.

Sat, Dec 4, 12:49 AM
wanpengqian_gmail.com updated the summary of D32957: nvmecontrol: improve namespace size unit of devlist command output.
Sat, Dec 4, 12:36 AM

Thu, Dec 2

wanpengqian_gmail.com updated the summary of D33032: nvme: nvd/nda call disk_resize() when namespace changed async event happened.
Thu, Dec 2, 1:15 PM
wanpengqian_gmail.com updated the diff for D33032: nvme: nvd/nda call disk_resize() when namespace changed async event happened.

after NVME_PROBE_IDENTIFY_NS is done, fire a AC_GETDEV_CHANGED async event.

Thu, Dec 2, 1:13 PM
wanpengqian_gmail.com added inline comments to D33032: nvme: nvd/nda call disk_resize() when namespace changed async event happened.
Thu, Dec 2, 1:36 AM

Wed, Dec 1

wanpengqian_gmail.com added a reviewer for D32831: bhyve: implement SELF-TEST feature for NVMe controller: c.koehne_beckhoff.com.
Wed, Dec 1, 10:19 AM
wanpengqian_gmail.com added a comment to D32903: bhyve: implement Timestamp get/set feature for NVMe controller.

Thank you!

Wed, Dec 1, 10:14 AM
wanpengqian_gmail.com updated the diff for D32903: bhyve: implement Timestamp get/set feature for NVMe controller.

update as reviewer suggested.

Wed, Dec 1, 10:11 AM
wanpengqian_gmail.com updated the summary of D32903: bhyve: implement Timestamp get/set feature for NVMe controller.
Wed, Dec 1, 9:01 AM
wanpengqian_gmail.com retitled D33032: nvme: nvd/nda call disk_resize() when namespace changed async event happened from nvme: nda call disk_resize() when namespace changed async event happened to nvme: nvd/nda call disk_resize() when namespace changed async event happened.
Wed, Dec 1, 8:38 AM
wanpengqian_gmail.com abandoned D33028: nvme: nvd call disk_resize() when namespace changed async event happened.
Wed, Dec 1, 8:37 AM
wanpengqian_gmail.com updated the diff for D33032: nvme: nvd/nda call disk_resize() when namespace changed async event happened.

fix unrelated change.

Wed, Dec 1, 8:35 AM
wanpengqian_gmail.com updated the summary of D33032: nvme: nvd/nda call disk_resize() when namespace changed async event happened.
Wed, Dec 1, 8:29 AM
wanpengqian_gmail.com updated the diff for D33032: nvme: nvd/nda call disk_resize() when namespace changed async event happened.

rebase as reviewer suggested.

Wed, Dec 1, 8:23 AM

Mon, Nov 29

wanpengqian_gmail.com added a comment to D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..

Any chance to get some notice? everytime I install a new machine, I have to modify fstab manually to avoid this issue.

Mon, Nov 29, 10:20 PM
wanpengqian_gmail.com added a reviewer for D32658: bhyve: initial Active Firmware Info for NVMe controller: markj.
Mon, Nov 29, 10:14 PM
wanpengqian_gmail.com added a comment to D32657: bhyve: Fix the wrong Number of Power States Support value also set a reasonable Max Power for NVMe controller.

Yes, please commit this for me. thank you.

Mon, Nov 29, 10:00 PM
wanpengqian_gmail.com updated the diff for D32657: bhyve: Fix the wrong Number of Power States Support value also set a reasonable Max Power for NVMe controller.

update comment as suggested.

Mon, Nov 29, 9:59 PM
wanpengqian_gmail.com added a comment to D32657: bhyve: Fix the wrong Number of Power States Support value also set a reasonable Max Power for NVMe controller.

explicitly initialize MXPS and NOPS to zero as well

Mon, Nov 29, 9:29 PM
wanpengqian_gmail.com updated the diff for D32657: bhyve: Fix the wrong Number of Power States Support value also set a reasonable Max Power for NVMe controller.

explicitly initialize MXPS and NOPS to zero as well

Mon, Nov 29, 9:26 PM

Fri, Nov 26

wanpengqian_gmail.com updated the diff for D32957: nvmecontrol: improve namespace size unit of devlist command output.

Add a B suffix to match the default one.

Fri, Nov 26, 8:09 AM
wanpengqian_gmail.com updated the diff for D32957: nvmecontrol: improve namespace size unit of devlist command output.

fix typo and modify words as comment suggested.

Fri, Nov 26, 6:40 AM

Thu, Nov 25

wanpengqian_gmail.com retitled D32657: bhyve: Fix the wrong Number of Power States Support value also set a reasonable Max Power for NVMe controller from bhyve: correct the Number of Power States Support and set a reasonable Max Power for NVMe controller to bhyve: Fix the wrong Number of Power States Support value also set a reasonable Max Power for NVMe controller.
Thu, Nov 25, 8:57 AM
wanpengqian_gmail.com updated the summary of D32957: nvmecontrol: improve namespace size unit of devlist command output.
Thu, Nov 25, 8:28 AM
wanpengqian_gmail.com updated the diff for D32957: nvmecontrol: improve namespace size unit of devlist command output.

use humanize_number() instead of new wheel.

Thu, Nov 25, 8:27 AM

Fri, Nov 19

wanpengqian_gmail.com added a comment to D32953: bhyve nvme: Inform guests of namespace resize.

I don't think we need the namespace info before interrupts are enabled, so I don't think we need a kthread for this. At most, we may need a workqueue to run job...

Fri, Nov 19, 4:52 AM

Thu, Nov 18

wanpengqian_gmail.com added a comment to D32953: bhyve nvme: Inform guests of namespace resize.

Yes. Normally we only query namespaces while we're starting up (hence the poll complete). We
should let this be event driven instead.

Thu, Nov 18, 5:36 AM
wanpengqian_gmail.com added a reviewer for D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab.: allanjude.
Thu, Nov 18, 2:33 AM

Wed, Nov 17

wanpengqian_gmail.com added a comment to D32953: bhyve nvme: Inform guests of namespace resize.
panic: sleepq_add: td 0xfffffe00e228b020 to sleep on wchan 0xffffffff81684b85 with sleeping pro
cpuid = 5
time = 1637052864
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00e21e7b00
vpanic() at vpanic+0x181/frame 0xfffffe00e21e7b50
panic() at panic+0x43/frame 0xfffffe00e21e7bb0
sleepq_add() at sleepq_add+0x359/frame 0xfffffe00e21e7c00
_sleep() at _sleep+0x1f5/frame 0xfffffe00e21e7ca0
pause_sbt() at pause_sbt+0xfe/frame 0xfffffe00e21e7cd0
nvme_ns_construct() at nvme_ns_construct+0xd3/frame 0xfffffe00e21e7d70
nvme_notify_ns() at nvme_notify_ns+0x50/frame 0xfffffe00e21e7da0
nvme_ctrlr_async_event_log_page_cb() at nvme_ctrlr_async_event_log_page_cb+0xf6/frame 0xfffffe0
nvme_qpair_complete_tracker() at nvme_qpair_complete_tracker+0x20f/frame 0xfffffe00e21e7e10
nvme_qpair_process_completions() at nvme_qpair_process_completions+0x19f/frame 0xfffffe00e21e7e
ithread_loop() at ithread_loop+0x279/frame 0xfffffe00e21e7ef0
fork_exit() at fork_exit+0x80/frame 0xfffffe00e21e7f30
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00e21e7f30
--- trap 0, rip = 0, rsp = 0, rbp = 0 ---
KDB: enter: panic
[ thread pid 12 tid 100098 ]
Stopped at      kdb_enter+0x37: movq    $0,0x1276e2e(%rip)
Wed, Nov 17, 1:09 PM
wanpengqian_gmail.com updated the diff for D33032: nvme: nvd/nda call disk_resize() when namespace changed async event happened.

remove nvd modification.

Wed, Nov 17, 10:12 AM
wanpengqian_gmail.com requested review of D33032: nvme: nvd/nda call disk_resize() when namespace changed async event happened.
Wed, Nov 17, 9:03 AM
wanpengqian_gmail.com added inline comments to D33028: nvme: nvd call disk_resize() when namespace changed async event happened.
Wed, Nov 17, 12:57 AM
wanpengqian_gmail.com added inline comments to D33028: nvme: nvd call disk_resize() when namespace changed async event happened.
Wed, Nov 17, 12:22 AM
wanpengqian_gmail.com updated the diff for D33028: nvme: nvd call disk_resize() when namespace changed async event happened.

filter out all the non NMVE_LOG_CHANGED_NAMESPACE

Wed, Nov 17, 12:14 AM

Tue, Nov 16

wanpengqian_gmail.com added a comment to D32953: bhyve nvme: Inform guests of namespace resize.
In D32953#745698, @imp wrote:

So if I take these patches, how do I change the namespace size in bhyve? I can fix nvd and nda

Tue, Nov 16, 10:29 PM
wanpengqian_gmail.com requested review of D33028: nvme: nvd call disk_resize() when namespace changed async event happened.
Tue, Nov 16, 10:26 PM
wanpengqian_gmail.com added a comment to D32953: bhyve nvme: Inform guests of namespace resize.

Yea, they need to be notified when the size changes, though, and only the nvme driver knows that.
There's a nvme_sim_ns_change callback that's currently registered for nda. This is the same as nvd_new_disk,
but I'm not sure that nvd_new_disk handles the change case well.
I'll have to thread this through. My current ns enhancement work is incomplete and doesn't handle this deatail.

https://reviews.freebsd.org/D32963 is the current state of things, but I don't see any calls to disk_resize() in it.
scsi and ata disks work,but nvme doesn't. I've not worked through all the details of that review, btw, since it
is a work in progress that had other things take priority over and I've not returned to it

Tue, Nov 16, 8:58 AM
wanpengqian_gmail.com added a comment to D32953: bhyve nvme: Inform guests of namespace resize.
Tue, Nov 16, 7:17 AM

Sat, Nov 13

wanpengqian_gmail.com updated the diff for D32831: bhyve: implement SELF-TEST feature for NVMe controller.

add/correct comments and output DPRINTF log more detail.

Sat, Nov 13, 3:10 AM
wanpengqian_gmail.com updated the diff for D32831: bhyve: implement SELF-TEST feature for NVMe controller.

Use more properly function name, update sytle.

Sat, Nov 13, 2:40 AM

Fri, Nov 12

wanpengqian_gmail.com added inline comments to D32957: nvmecontrol: improve namespace size unit of devlist command output.
Fri, Nov 12, 6:57 AM
wanpengqian_gmail.com added a comment to D32953: bhyve nvme: Inform guests of namespace resize.
In D32953#744004, @imp wrote:

The nvmecontrol of FreeBSD guest can output the changed size. but gpart still reports the original size. how can we let kernel reload this change? nvme reset seems no a fix.

rewrite the partition table?

what disk diskinfo ndaX or nvdX say?

Fri, Nov 12, 6:24 AM
wanpengqian_gmail.com added a comment to D32953: bhyve nvme: Inform guests of namespace resize.

The nvmecontrol of FreeBSD guest can output the changed size. but gpart still reports the original size. how can we let kernel reload this change? nvme reset seems no a fix.

Fri, Nov 12, 6:12 AM
wanpengqian_gmail.com updated the diff for D32957: nvmecontrol: improve namespace size unit of devlist command output.

kill goto.

Fri, Nov 12, 5:48 AM
wanpengqian_gmail.com updated the diff for D32957: nvmecontrol: improve namespace size unit of devlist command output.

fix typo.

Fri, Nov 12, 5:31 AM
wanpengqian_gmail.com requested review of D32957: nvmecontrol: improve namespace size unit of devlist command output.
Fri, Nov 12, 5:26 AM
wanpengqian_gmail.com added inline comments to D32953: bhyve nvme: Inform guests of namespace resize.
Fri, Nov 12, 4:04 AM
wanpengqian_gmail.com updated the summary of D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..
Fri, Nov 12, 12:46 AM

Thu, Nov 11

wanpengqian_gmail.com added a reviewer for D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab.: gjb.
Thu, Nov 11, 11:01 AM
wanpengqian_gmail.com added a reviewer for D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab.: dteske.
Thu, Nov 11, 11:00 AM
wanpengqian_gmail.com requested review of D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..
Thu, Nov 11, 10:50 AM
wanpengqian_gmail.com updated the diff for D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.

correct the timestamp output.

Thu, Nov 11, 1:56 AM

Wed, Nov 10

wanpengqian_gmail.com updated the diff for D32558: bhyve: initial PowerCycles value and implement PowerOnHours caculation.

use a more suitable name for macro.

Wed, Nov 10, 10:14 PM
wanpengqian_gmail.com updated the diff for D32903: bhyve: implement Timestamp get/set feature for NVMe controller.

fix the timestamp caculation.

Wed, Nov 10, 11:25 AM
wanpengqian_gmail.com added inline comments to D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.
Wed, Nov 10, 3:18 AM
wanpengqian_gmail.com updated the diff for D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.

update manpage as comments suggested.
also add print Timestamp for details.

Wed, Nov 10, 3:17 AM

Tue, Nov 9

wanpengqian_gmail.com updated the diff for D32798: bhyve: implement get-feature of LBA range type of NVMe controller.

create struct for each feature object

Tue, Nov 9, 2:41 PM
wanpengqian_gmail.com updated the diff for D32688: bhyve: implement Temperature Threshold set/get feature for NVMe controller.

create struct for each feature object

Tue, Nov 9, 12:44 PM
wanpengqian_gmail.com updated the diff for D32903: bhyve: implement Timestamp get/set feature for NVMe controller.

create struct for each feature object

Tue, Nov 9, 12:17 PM
wanpengqian_gmail.com requested review of D32903: bhyve: implement Timestamp get/set feature for NVMe controller.
Tue, Nov 9, 8:57 AM
wanpengqian_gmail.com updated the diff for D32688: bhyve: implement Temperature Threshold set/get feature for NVMe controller.

use function-like macro.

Tue, Nov 9, 12:37 AM
wanpengqian_gmail.com updated the diff for D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with save flag..

use function-like macro.

Tue, Nov 9, 12:31 AM

Mon, Nov 8

wanpengqian_gmail.com updated the diff for D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.

update manpage.

Mon, Nov 8, 1:06 PM

Nov 8 2021

wanpengqian_gmail.com updated the diff for D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.

Add command examples.

Nov 8 2021, 7:54 AM
wanpengqian_gmail.com updated the diff for D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.

fix typo.

Nov 8 2021, 7:37 AM
wanpengqian_gmail.com updated the diff for D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.

update manpage

Nov 8 2021, 7:33 AM
wanpengqian_gmail.com updated the summary of D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.
Nov 8 2021, 6:26 AM
wanpengqian_gmail.com updated the diff for D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.

copy code from sys/dev/nvme/nvme_qpair.c,
move _SHIFT _MASK difinition to sys/dev/nvme/nvme.h, seperate ticket: D32885
remove these difinitions when D32885 is accepted.

Nov 8 2021, 6:22 AM
wanpengqian_gmail.com updated the diff for D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.

use #define instead of numbers.

Nov 8 2021, 5:22 AM
wanpengqian_gmail.com added inline comments to D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.
Nov 8 2021, 5:02 AM
wanpengqian_gmail.com requested review of D32885: nvme: Add some definitions for Features.
Nov 8 2021, 4:44 AM

Nov 6 2021

wanpengqian_gmail.com updated the diff for D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.

define more define and other updates.

Nov 6 2021, 2:20 PM
wanpengqian_gmail.com updated the summary of D32845: nvme: fix wrong temperature unit for INTEL SSDs..
Nov 6 2021, 12:27 AM

Nov 5 2021

wanpengqian_gmail.com updated the summary of D32845: nvme: fix wrong temperature unit for INTEL SSDs..
Nov 5 2021, 5:15 AM
wanpengqian_gmail.com requested review of D32845: nvme: fix wrong temperature unit for INTEL SSDs..
Nov 5 2021, 5:13 AM
wanpengqian_gmail.com updated the diff for D32832: nvme: improve selftest option for nvmecontrol.

update others too. (An nsid)

Nov 5 2021, 3:19 AM
wanpengqian_gmail.com updated the diff for D32832: nvme: improve selftest option for nvmecontrol.

Fix grammer/comments as reviewer suggested.

Nov 5 2021, 3:16 AM
wanpengqian_gmail.com added inline comments to D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.
Nov 5 2021, 1:13 AM
wanpengqian_gmail.com requested review of D32844: nvme: move nested result struct out of nvme_device_self_test_page for further reference..
Nov 5 2021, 1:00 AM
wanpengqian_gmail.com updated the diff for D32558: bhyve: initial PowerCycles value and implement PowerOnHours caculation.

create a macro to calculate power_on_hours. it can be shared with others.

Nov 5 2021, 12:48 AM
wanpengqian_gmail.com added a comment to D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.
In D32700#741111, @imp wrote:

One other question: Are there vendor specific features that might benefit from the extensible module loading we do for commands and mode pages?

Nov 5 2021, 12:30 AM
wanpengqian_gmail.com added inline comments to D32832: nvme: improve selftest option for nvmecontrol.
Nov 5 2021, 12:09 AM
wanpengqian_gmail.com updated the diff for D32832: nvme: improve selftest option for nvmecontrol.

Fix grammer/comments as reviewer suggested.

Nov 5 2021, 12:06 AM

Nov 4 2021

wanpengqian_gmail.com updated the diff for D32832: nvme: improve selftest option for nvmecontrol.

fix a typo.

Nov 4 2021, 3:20 PM
wanpengqian_gmail.com requested review of D32832: nvme: improve selftest option for nvmecontrol.
Nov 4 2021, 3:16 PM
wanpengqian_gmail.com requested review of D32831: bhyve: implement SELF-TEST feature for NVMe controller.
Nov 4 2021, 11:51 AM
wanpengqian_gmail.com updated the diff for D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.

rename function name to match other files's code style.

Nov 4 2021, 12:24 AM

Nov 2 2021

wanpengqian_gmail.com requested review of D32802: bhyve: return FEATURE_NOT_CHANGEABLE for unimplemented feature of NVMe controller.
Nov 2 2021, 1:33 PM
wanpengqian_gmail.com updated the diff for D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.

Print detail error message when failure.

Nov 2 2021, 1:21 PM
wanpengqian_gmail.com requested review of D32798: bhyve: implement get-feature of LBA range type of NVMe controller.
Nov 2 2021, 8:38 AM
wanpengqian_gmail.com updated the diff for D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.

add more print functions.

Nov 2 2021, 7:34 AM

Nov 1 2021

wanpengqian_gmail.com updated the diff for D32700: nvme: [WIP] implement Get/Set Feature for nvmecontrol.

Add more print functions.

Nov 1 2021, 12:53 PM
wanpengqian_gmail.com updated the diff for D32688: bhyve: implement Temperature Threshold set/get feature for NVMe controller.

fix condition value.

Nov 1 2021, 7:57 AM
wanpengqian_gmail.com retitled D32688: bhyve: implement Temperature Threshold set/get feature for NVMe controller from bhyve: implement Temperature Threshold get feature for NVMe controller to bhyve: implement Temperature Threshold set/get feature for NVMe controller.
Nov 1 2021, 7:46 AM
wanpengqian_gmail.com updated the diff for D32688: bhyve: implement Temperature Threshold set/get feature for NVMe controller.

Implement Set Feature for Temperature Threshold.

Nov 1 2021, 7:45 AM
wanpengqian_gmail.com requested review of D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with save flag..
Nov 1 2021, 4:23 AM