Page MenuHomeFreeBSD

wanpengqian_gmail.com (Wanpeng Qian)
Software Engineer

Projects

User does not belong to any projects.

User Details

User Since
Mar 1 2018, 4:23 AM (248 w, 1 d)

Recent Activity

Thu, Nov 17

wanpengqian_gmail.com updated the summary of D37356: bhyve: fix the number of queue feature setting timing for nvme controller..
Thu, Nov 17, 2:05 AM
wanpengqian_gmail.com added inline comments to D37356: bhyve: fix the number of queue feature setting timing for nvme controller..
Thu, Nov 17, 2:04 AM

Mon, Nov 14

wanpengqian_gmail.com added inline comments to D37356: bhyve: fix the number of queue feature setting timing for nvme controller..
Mon, Nov 14, 11:18 AM

Fri, Nov 11

wanpengqian_gmail.com added a comment to D37356: bhyve: fix the number of queue feature setting timing for nvme controller..

You've just renamed the variable and inverted the logic from is_set to is_setable. That's unneccessary. Please keep the old name.

The only thing which really changed is that the reset of the variable is done in nvme_init_queues instead of nvme_reset.

So, the question is: Do we have to reset the variable on nvme_reset. I don't know. Your quote of the specification isn't clear on that.

Fri, Nov 11, 3:55 PM
wanpengqian_gmail.com updated the diff for D37356: bhyve: fix the number of queue feature setting timing for nvme controller..

address reviewer feedback.

Fri, Nov 11, 3:45 PM
wanpengqian_gmail.com added a comment to D37355: bhyve: nvme controller obey async event setting when reporting critical temperature.

address feedback

Fri, Nov 11, 3:31 PM
wanpengqian_gmail.com updated the diff for D37355: bhyve: nvme controller obey async event setting when reporting critical temperature.

drop init value of report_crit

Fri, Nov 11, 3:28 PM
wanpengqian_gmail.com added a comment to D34700: nvmecontrol: Fix condition when print number of Firmware Slots and Firmware Slot1 Readonly..

I agree with chuck. fw_num_slots can't be zero. If it's zero, your controller will be broken and you can't rely on any of these values. So, I think it makes no sense to keep the if.

Fri, Nov 11, 3:24 PM
wanpengqian_gmail.com updated the diff for D34700: nvmecontrol: Fix condition when print number of Firmware Slots and Firmware Slot1 Readonly..

unconditionly print fw_slot1_ro.

Fri, Nov 11, 3:22 PM
wanpengqian_gmail.com requested review of D37356: bhyve: fix the number of queue feature setting timing for nvme controller..
Fri, Nov 11, 9:12 AM
wanpengqian_gmail.com requested review of D37355: bhyve: nvme controller obey async event setting when reporting critical temperature.
Fri, Nov 11, 7:59 AM
wanpengqian_gmail.com added a comment to D34700: nvmecontrol: Fix condition when print number of Firmware Slots and Firmware Slot1 Readonly..

I think Chuck is right. output fw_num_slots unconditionally, but for Firmware Slot 1 Read-Only, we have to make sure the fw_num_slots is bigger than zero. othersize it is meaningless. Although the NVMe controller should at least have one firmware slot.

Fri, Nov 11, 4:23 AM
wanpengqian_gmail.com updated the diff for D34700: nvmecontrol: Fix condition when print number of Firmware Slots and Firmware Slot1 Readonly..

unconditionally print fw_num_slots.

Fri, Nov 11, 4:19 AM

Thu, Nov 10

wanpengqian_gmail.com requested review of D32802: bhyve: return FEATURE_NOT_CHANGEABLE for unimplemented feature of NVMe controller.
Thu, Nov 10, 9:55 PM
wanpengqian_gmail.com reclaimed D32802: bhyve: return FEATURE_NOT_CHANGEABLE for unimplemented feature of NVMe controller.

All right, I think for unimplemented features, always return FEATURE NOT CHANGEABLE is compliant to the spec. and for implemented features, it is up to the implementation.so I am reclaiming this patch. thanks.

Thu, Nov 10, 9:53 PM
wanpengqian_gmail.com added a comment to D32845: nvme: fix wrong temperature unit for INTEL SSDs..

@corvink Can you please help me verify if this patch solve the issue? it needs an Intel SSD for verifying.

Thu, Nov 10, 10:34 AM
wanpengqian_gmail.com added a reviewer for D32845: nvme: fix wrong temperature unit for INTEL SSDs.: corvink.
Thu, Nov 10, 10:32 AM
wanpengqian_gmail.com added inline comments to D32802: bhyve: return FEATURE_NOT_CHANGEABLE for unimplemented feature of NVMe controller.
Thu, Nov 10, 7:45 AM
wanpengqian_gmail.com added a reviewer for D34700: nvmecontrol: Fix condition when print number of Firmware Slots and Firmware Slot1 Readonly.: corvink.
Thu, Nov 10, 2:18 AM
wanpengqian_gmail.com abandoned D32802: bhyve: return FEATURE_NOT_CHANGEABLE for unimplemented feature of NVMe controller.
Thu, Nov 10, 2:16 AM
wanpengqian_gmail.com added a comment to D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..

Address reviewers' feedback.

Thu, Nov 10, 12:56 AM
wanpengqian_gmail.com updated the diff for D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..

Address reviews' feedback.

Thu, Nov 10, 12:47 AM

Wed, Nov 9

wanpengqian_gmail.com added inline comments to D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..
Wed, Nov 9, 1:55 PM

Oct 28 2022

wanpengqian_gmail.com updated the diff for D32700: nvmecontrol: Implement Get/Set Feature for nvmecontrol.
  • remove a unnecessary include
  • fix typo
  • fix code style of switch
Oct 28 2022, 5:03 AM
wanpengqian_gmail.com updated the summary of D32700: nvmecontrol: Implement Get/Set Feature for nvmecontrol.
Oct 28 2022, 4:45 AM
wanpengqian_gmail.com updated the diff for D32700: nvmecontrol: Implement Get/Set Feature for nvmecontrol.
  • combine all changes to one commit.
  • build check with CURRENT source.
  • correct manpages
Oct 28 2022, 4:43 AM
wanpengqian_gmail.com abandoned D33860: nvmecontrol: Implement feature command for intel.
Oct 28 2022, 4:27 AM

Oct 21 2022

wanpengqian_gmail.com added a comment to D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..

I have built a test ISO and it works as expected within the BHYVE virtual machine with following conditions

Oct 21 2022, 1:23 AM

Oct 20 2022

wanpengqian_gmail.com added inline comments to D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..
Oct 20 2022, 2:30 AM
wanpengqian_gmail.com updated the diff for D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..

Update as reviewer suggested.

Oct 20 2022, 2:27 AM

Oct 19 2022

wanpengqian_gmail.com added a comment to D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.

@imp I am sorry for the previous samsung patch that I didn't compile on the i386 platform to have checked.

Oct 19 2022, 8:27 AM
wanpengqian_gmail.com added a comment to D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..

@kevans I am sorry I just picked up the latest commiter from bsdinstall history,
maybe you can take a look for this patch. I have been suffering from this issue for many years.

Oct 19 2022, 8:06 AM
wanpengqian_gmail.com added a reviewer for D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab.: kevans.
Oct 19 2022, 7:37 AM
wanpengqian_gmail.com added a comment to D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..

The code changes do not match the title or summary. Did you update the wrong review?

Oct 19 2022, 6:59 AM
wanpengqian_gmail.com updated the diff for D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..

Rollback to previous diff.

Oct 19 2022, 6:57 AM
wanpengqian_gmail.com abandoned D32885: nvme: Add some definitions for Features.
Oct 19 2022, 6:52 AM
wanpengqian_gmail.com updated the summary of D32802: bhyve: return FEATURE_NOT_CHANGEABLE for unimplemented feature of NVMe controller.
Oct 19 2022, 6:45 AM
wanpengqian_gmail.com added inline comments to D32802: bhyve: return FEATURE_NOT_CHANGEABLE for unimplemented feature of NVMe controller.
Oct 19 2022, 6:41 AM
wanpengqian_gmail.com updated the diff for D32802: bhyve: return FEATURE_NOT_CHANGEABLE for unimplemented feature of NVMe controller.

Update code as requested.

Oct 19 2022, 6:40 AM
wanpengqian_gmail.com abandoned D32831: bhyve: implement SELF-TEST feature for NVMe controller.
Oct 19 2022, 6:27 AM
wanpengqian_gmail.com abandoned D32798: bhyve: implement get-feature of LBA range type of NVMe controller.
Oct 19 2022, 6:27 AM
wanpengqian_gmail.com abandoned D32688: bhyve: implement Temperature Threshold set/get feature for NVMe controller.
Oct 19 2022, 6:26 AM
wanpengqian_gmail.com abandoned D32678: bhyve: Implement some Namespace Management commands for NVMe controller.
Oct 19 2022, 6:25 AM
wanpengqian_gmail.com abandoned D32903: bhyve: implement Timestamp get/set feature for NVMe controller.
Oct 19 2022, 6:25 AM
wanpengqian_gmail.com added a comment to D32558: bhyve: initial PowerCycles value.

Can we give a go for this patch?

Oct 19 2022, 6:07 AM
wanpengqian_gmail.com updated the summary of D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..
Oct 19 2022, 6:00 AM
wanpengqian_gmail.com updated the diff for D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..

catch up with the latest source.

Oct 19 2022, 5:56 AM
wanpengqian_gmail.com requested review of D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..
Oct 19 2022, 5:49 AM
wanpengqian_gmail.com retitled D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller. from bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with save flag. to bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..
Oct 19 2022, 5:48 AM
wanpengqian_gmail.com added a comment to D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.
In D33866#838287, @imp wrote:

Just some minor style cleanup, and I'll commit.
I'll use the author name of:
Wanpeng Qian <wanpengqian@gmail.com>

Oct 19 2022, 2:47 AM
wanpengqian_gmail.com added a comment to D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.
  • Fix code style, match style(9) as @imp requested.
  • Fix typo and uppercase vendor‘s name as @pauamma requested.
Oct 19 2022, 1:50 AM
wanpengqian_gmail.com updated the diff for D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.
  • Commit new files(by miss).
Oct 19 2022, 1:48 AM
wanpengqian_gmail.com updated the diff for D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.
  • Update manpage, fix typo and uppercase vendor's name.
  • Fix code style, match style(9)
Oct 19 2022, 1:44 AM

Oct 17 2022

wanpengqian_gmail.com added a comment to D33032: nvme: nvd/nda call disk_resize() when namespace changed async event happened.

I tested with 14.0-CURRENT Oct 10 2022, and it works. Is it the right direction for dynamically changing the disk size after hosts resize the disk?

Oct 17 2022, 7:41 AM

Oct 7 2022

wanpengqian_gmail.com added reviewers for D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support: manpages, pauamma.
Oct 7 2022, 9:00 AM
wanpengqian_gmail.com updated the diff for D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.

Update to match the latest source.
Update manpage.

Oct 7 2022, 8:58 AM

Sep 30 2022

wanpengqian_gmail.com added a comment to D33749: nvmecontrol: Add Samsung Extended SMART Information logpage support..
In D33749#835893, @bcr wrote:

Who's going to commit this? Seems like it's as complete as it can get.

Sep 30 2022, 8:50 AM

Sep 5 2022

wanpengqian_gmail.com added a comment to D36450: bhyve/virtio: add config option to change the subvendor.

Can we have a universal PCI vendor/subvendor setting for all PCI devices instead of for particular PCI devices? other pci devices may want to change the ID/subID too. For example, if I want to fake the NVMe controller as an Intel one.

Sep 5 2022, 8:43 AM · bhyve

Aug 31 2022

wanpengqian_gmail.com updated the diff for D36345: bhyve: nvme set Abort Command Limit (ACL) and Asynchronous Event Request Limit (AERL) values as specfication suggested.

remove comments.

Aug 31 2022, 1:46 AM
wanpengqian_gmail.com planned changes to D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..
Aug 31 2022, 1:44 AM
wanpengqian_gmail.com updated the diff for D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..

remove comments

Aug 31 2022, 1:43 AM
wanpengqian_gmail.com requested review of D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..
Aug 31 2022, 1:39 AM
wanpengqian_gmail.com added inline comments to D36345: bhyve: nvme set Abort Command Limit (ACL) and Asynchronous Event Request Limit (AERL) values as specfication suggested.
Aug 31 2022, 1:35 AM

Aug 29 2022

wanpengqian_gmail.com added a comment to D33856: nvmecontrol: Fix IEEE OUI Identifier output..

Here is the compare result with smartctl, for a intel optane 16GB nvme drive

Aug 29 2022, 4:59 AM

Aug 26 2022

wanpengqian_gmail.com planned changes to D32700: nvmecontrol: Implement Get/Set Feature for nvmecontrol.
Aug 26 2022, 12:08 AM
wanpengqian_gmail.com planned changes to D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..
Aug 26 2022, 12:08 AM
wanpengqian_gmail.com planned changes to D32798: bhyve: implement get-feature of LBA range type of NVMe controller.
Aug 26 2022, 12:08 AM
wanpengqian_gmail.com planned changes to D32802: bhyve: return FEATURE_NOT_CHANGEABLE for unimplemented feature of NVMe controller.
Aug 26 2022, 12:08 AM
wanpengqian_gmail.com planned changes to D32831: bhyve: implement SELF-TEST feature for NVMe controller.
Aug 26 2022, 12:07 AM
wanpengqian_gmail.com planned changes to D32832: nvme: improve selftest option for nvmecontrol.
Aug 26 2022, 12:07 AM
wanpengqian_gmail.com planned changes to D32885: nvme: Add some definitions for Features.
Aug 26 2022, 12:07 AM
wanpengqian_gmail.com planned changes to D32903: bhyve: implement Timestamp get/set feature for NVMe controller.
Aug 26 2022, 12:07 AM
wanpengqian_gmail.com planned changes to D32936: bsdinstall: use gpt label instead of swap partition name when updating fstab..
Aug 26 2022, 12:07 AM
wanpengqian_gmail.com planned changes to D33032: nvme: nvd/nda call disk_resize() when namespace changed async event happened.
Aug 26 2022, 12:07 AM
wanpengqian_gmail.com planned changes to D33765: nvmecontrol: logpage fallback to hex when vendor opt is not specified..
Aug 26 2022, 12:07 AM
wanpengqian_gmail.com planned changes to D33779: nvmecontrol: logpage will use the controller's vid to choose the formatting function when the vendor name is not provided..
Aug 26 2022, 12:07 AM
wanpengqian_gmail.com planned changes to D32688: bhyve: implement Temperature Threshold set/get feature for NVMe controller.
Aug 26 2022, 12:06 AM
wanpengqian_gmail.com planned changes to D32678: bhyve: Implement some Namespace Management commands for NVMe controller.
Aug 26 2022, 12:05 AM

Aug 25 2022

wanpengqian_gmail.com retitled D36345: bhyve: nvme set Abort Command Limit (ACL) and Asynchronous Event Request Limit (AERL) values as specfication suggested from Set Abort Command Limit (ACL) and Asynchronous Event Request Limit (AERL) values as specfica ton suggested. to bhyve: nvme set Abort Command Limit (ACL) and Asynchronous Event Request Limit (AERL) values as specfication suggested.
Aug 25 2022, 5:06 AM
wanpengqian_gmail.com requested review of D36345: bhyve: nvme set Abort Command Limit (ACL) and Asynchronous Event Request Limit (AERL) values as specfication suggested.
Aug 25 2022, 5:04 AM
wanpengqian_gmail.com added a comment to D32558: bhyve: initial PowerCycles value.

Although I insist on adding the calculation of PowerOnHours.  For now, this patch only adds the init value of PowerCycles.

Aug 25 2022, 4:11 AM
wanpengqian_gmail.com retitled D32558: bhyve: initial PowerCycles value from bhyve: initial PowerCycles value and implement PowerOnHours caculation to bhyve: initial PowerCycles value.
Aug 25 2022, 4:08 AM
wanpengqian_gmail.com updated the diff for D32558: bhyve: initial PowerCycles value.

As reviewer suggested, only init PowerCycles value for now.

Aug 25 2022, 4:07 AM
wanpengqian_gmail.com added a comment to D33856: nvmecontrol: Fix IEEE OUI Identifier output..

@imp Can we give a go for this?

Aug 25 2022, 2:49 AM
wanpengqian_gmail.com added a comment to D34700: nvmecontrol: Fix condition when print number of Firmware Slots and Firmware Slot1 Readonly..

Since D32659 is committed. Can we give a go for this? @imp

Aug 25 2022, 2:45 AM

Apr 6 2022

wanpengqian_gmail.com added a comment to D26209: GVT-d support for bhyve.

I got a intel Xe DG1 dedicated graphics adapter. I will try it later.

Apr 6 2022, 2:31 PM · bhyve

Mar 29 2022

wanpengqian_gmail.com updated the test plan for D34700: nvmecontrol: Fix condition when print number of Firmware Slots and Firmware Slot1 Readonly..
Mar 29 2022, 7:21 AM
wanpengqian_gmail.com retitled D32659: bhyve: fix incorrect Slot1 Read Only setting in NVMe controller. from bhyve: fix Number of Firmware Slot and Slot1 ReadOnly advertise are ignored. to bhyve: fix incorrect Slot1 Read Only setting in NVMe controller..
Mar 29 2022, 6:49 AM
wanpengqian_gmail.com added a comment to D33856: nvmecontrol: Fix IEEE OUI Identifier output..

Any comments?

Mar 29 2022, 2:37 AM
wanpengqian_gmail.com added a reviewer for D33856: nvmecontrol: Fix IEEE OUI Identifier output.: chuck.
Mar 29 2022, 2:36 AM
wanpengqian_gmail.com requested review of D34700: nvmecontrol: Fix condition when print number of Firmware Slots and Firmware Slot1 Readonly..
Mar 29 2022, 2:27 AM
wanpengqian_gmail.com added a comment to D32831: bhyve: implement SELF-TEST feature for NVMe controller.

While I agree that using emulated hardware to test drivers and system tools is useful, I'm concerned about adding synthetic functionality to the core code.

Mar 29 2022, 1:59 AM
wanpengqian_gmail.com added a comment to D32798: bhyve: implement get-feature of LBA range type of NVMe controller.

What is the long term plan for this functionality? Applications can use LBA Range Type to provide usage hints to the Controller such that it can optimize its performance characteristics. Are there kernels / applications out there that use this functionality? If so, is the goal to use these hints to modify the emulation's behavior?

Mar 29 2022, 1:39 AM
wanpengqian_gmail.com added a comment to D32767: bhyve: abort and return FEATURE_NOT_SAVEABLE while set feature with a save flag for NVMe controller..

Any comments?

Mar 29 2022, 1:26 AM
wanpengqian_gmail.com added a comment to D32903: bhyve: implement Timestamp get/set feature for NVMe controller.

This does not appear to implement either Set or Get correctly. For example, it does not use the Timestamp Origin field on Get's.

Mar 29 2022, 1:17 AM
wanpengqian_gmail.com added a comment to D32558: bhyve: initial PowerCycles value.

After some further thought, I've changed my mind and don't believe it makes sense to include the "power on hours" calculation. The goal of this value in actual hardware is to provide a (weak) heuristic to predict when to replace the drive. But this doesn't make sense for an emulated drive. Correcting the initialization of power on count seems like a good change, but the addition of a synthetic hours doesn't.

Mar 29 2022, 12:23 AM
wanpengqian_gmail.com updated the diff for D32659: bhyve: fix incorrect Slot1 Read Only setting in NVMe controller..

remove incorrect oacs setting.

Mar 29 2022, 12:09 AM

Mar 28 2022

wanpengqian_gmail.com added a comment to D32657: bhyve: Fix the wrong Number of Power States Support value also set a reasonable Max Power for NVMe controller.

Can we merge this patch to HEAD?

Mar 28 2022, 1:11 AM
wanpengqian_gmail.com added inline comments to D32659: bhyve: fix incorrect Slot1 Read Only setting in NVMe controller..
Mar 28 2022, 1:05 AM

Mar 25 2022

wanpengqian_gmail.com added a comment to D32658: bhyve: initial Active Firmware Info for NVMe controller.

Any comments on this?
Obviously guest OS will work properly without this patch, but we can make the simulation more real.

Mar 25 2022, 4:10 AM