Page MenuHomeFreeBSD

sysutils/busybox: update to the 1.31.0 version
ClosedPublic

Authored by samm on Oct 14 2019, 3:53 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

samm created this revision.Oct 14 2019, 3:53 PM
araujo accepted this revision.Oct 14 2019, 4:11 PM

Do you use poudriere?
https://www.freebsd.org/doc/handbook/ports-poudriere.html

You must always test the changes using it, also when you open a review, you should fullfil the test area saying at least something like:

poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r348350 amd64 + i386) -> OK
portlint and portclippy -> OK
Runtime tests -> OK

If you are not using these tools, please start to use from now on.

Best regards,

This revision is now accepted and ready to land.Oct 14 2019, 4:11 PM
samm added a comment.Oct 14 2019, 4:16 PM

Thank you for feedback!

Yes, i am using it already

You must always test the changes using it, also when you open a review, you should fullfil the test area saying at least something like:
poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r348350 amd64 + i386) -> OK
portlint and portclippy -> OK
Runtime tests -> OK

Ok, was not aware of this, will do from the next submission. Only problem is that host for the poudriere is now running on 11.3, so 12+ tests will fail.

And will think how to automate all the process...

Probably will setup bhyve vm on 12+ to do the tests or will upgrade this host.

In D22022#481030, @samm wrote:

Thank you for feedback!

Yes, i am using it already

You must always test the changes using it, also when you open a review, you should fullfil the test area saying at least something like:
poudriere (11.2-, 12.0-RELEASE, 13.0-CURRENT@r348350 amd64 + i386) -> OK
portlint and portclippy -> OK
Runtime tests -> OK

Ok, was not aware of this, will do from the next submission. Only problem is that host for the poudriere is now running on 11.3, so 12+ tests will fail.
And will think how to automate all the process...
Probably will setup bhyve vm on 12+ to do the tests or will upgrade this host.

Vms are ok, specially if you use bhyve :)

Forgot to commit? Is there anything left to be reviewed?

This revision was automatically updated to reflect the committed changes.