Page MenuHomeFreeBSD

sysutils/iocage - Fix git/git-lite dependencies as well as leftover EGG files.
ClosedPublic

Authored by araujo on Tue, Oct 8, 2:14 AM.

Details

Summary

Add conditionals for git/git-lite and fix the leftover EGG files that always failed on poudriere testport.
The original patch: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240959

NOTE: A similar patch will be applied for iocage-devel too.
Test Plan

poudriere testport -j 120amd64 -p local sysutils/iocage
poudriere bulk -j 120amd64 -p local -z work -c -f /tmp/ports.txt

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

araujo created this revision.Tue, Oct 8, 2:14 AM
araujo edited the summary of this revision. (Show Details)Tue, Oct 8, 3:07 AM
araujo added reviewers: romain, adamw, dvl.
romain accepted this revision.Tue, Oct 8, 7:06 AM

This solves my problem as far as I am concerned. Maybe it's worth thinking about this tuning globally since we have more than 50 ports depending on devel/git and I am pretty sure most of these ports would be functional with devel/git-lite. By defaulting to devel/git-lite, you make it impossible to use both one of there 50+ ports and sysutils/iocage, which might be a problem? I am not sure about what is the best solution, so I will stick to a LGTM for now :-)

This revision is now accepted and ready to land.Tue, Oct 8, 7:06 AM
araujo added a comment.Tue, Oct 8, 7:40 AM

This solves my problem as far as I am concerned. Maybe it's worth thinking about this tuning globally since we have more than 50 ports depending on devel/git and I am pretty sure most of these ports would be functional with devel/git-lite. By defaulting to devel/git-lite, you make it impossible to use both one of there 50+ ports and sysutils/iocage, which might be a problem? I am not sure about what is the best solution, so I will stick to a LGTM for now :-)

I think the best solution would be to make git-lite a flavor and not a slave port of git.
I will think in something better for git later as now I'm traveling without purpose in north of Japan (Vacation).

Thanks @romain for the review.

Best Regards,

This revision was automatically updated to reflect the committed changes.