Page MenuHomeFreeBSD

sysutils/iocage - Fix git/git-lite dependencies as well as leftover EGG files.
ClosedPublic

Authored by araujo on Oct 8 2019, 2:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 9:50 AM
Unknown Object (File)
Feb 9 2024, 7:55 AM
Unknown Object (File)
Feb 9 2024, 7:51 AM
Unknown Object (File)
Feb 8 2024, 9:03 PM
Unknown Object (File)
Feb 8 2024, 8:51 PM
Unknown Object (File)
Jan 13 2024, 4:23 AM
Unknown Object (File)
Jan 12 2024, 4:24 PM
Unknown Object (File)
Dec 20 2023, 12:59 AM
Subscribers

Details

Summary

Add conditionals for git/git-lite and fix the leftover EGG files that always failed on poudriere testport.
The original patch: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240959

NOTE: A similar patch will be applied for iocage-devel too.
Test Plan

poudriere testport -j 120amd64 -p local sysutils/iocage
poudriere bulk -j 120amd64 -p local -z work -c -f /tmp/ports.txt

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

araujo added reviewers: romain, adamw, dvl.

This solves my problem as far as I am concerned. Maybe it's worth thinking about this tuning globally since we have more than 50 ports depending on devel/git and I am pretty sure most of these ports would be functional with devel/git-lite. By defaulting to devel/git-lite, you make it impossible to use both one of there 50+ ports and sysutils/iocage, which might be a problem? I am not sure about what is the best solution, so I will stick to a LGTM for now :-)

This revision is now accepted and ready to land.Oct 8 2019, 7:06 AM

This solves my problem as far as I am concerned. Maybe it's worth thinking about this tuning globally since we have more than 50 ports depending on devel/git and I am pretty sure most of these ports would be functional with devel/git-lite. By defaulting to devel/git-lite, you make it impossible to use both one of there 50+ ports and sysutils/iocage, which might be a problem? I am not sure about what is the best solution, so I will stick to a LGTM for now :-)

I think the best solution would be to make git-lite a flavor and not a slave port of git.
I will think in something better for git later as now I'm traveling without purpose in north of Japan (Vacation).

Thanks @romain for the review.

Best Regards,