I got nothing from #mongoengine on FreeNode regarding tests. Proceeding.

Talking to the project via IRC, waiting for a reply.

In D18519#396278, @mat wrote:

If having an invalid value in LICENSE_FILE does not make your test builds fails, you may have DISABLE_LICENSES set somewhere.

added >0 to a DEPENDS
setprop on pkg-descr and distinfo

I am confused by zero tests run

ran:
svn propset fbsd:nokeywords yes distinfo pkg-descr
svn propset svn:eol-style native distinfo pkg-descr
svn propset svn:mime-type text/plain distinfo pkg-descr

I'll fix those properties next. 'make test' is progressing.

Move devel/py-mongoengine to databases/py-mongoengine
Update dependent ports

Current status:

Add LICENSEFILE
Change BUILD_DEPENDS to TEST_DEPENDS
Add missing TEST_DEPENDS and RUN_DEPENDS
Add do-test target

1. Updating D18479: Adjust mail/p5-Email-Sender to use p5-Email-Address-XS and p5-Email-Address-UseXS

Replaced by https://reviews.freebsd.org/D18479

There is upstream history and issues. I am abandoning this.

OH damn. Sorry, wrong review. :)

There is upstream history and issues. I am abandoning this.

1. Updating D18053: Patch mail/p5-Email-Sender to use https://github.com/dlangille/Email-Sender

Overtaken by events. See https://svnweb.freebsd.org/ports?view=revision&revision=474806 which removes this dependency.

I should have referenced this review in the commit.

LibreNMS 1.45 has since been released. Update patch for that.

In D17086#364678, @bapt wrote:

I think there is absolutely no POLA here as this is a configuration, there should be some warning in the release Release note about it and that is all imho.
Considering the option to only blacklist certain patterns: dotfiles, .pkgnew etc the problem is one would need to do more than that:
remove patch leftovers: .orig, .rej, .bak
editors leftovers file~ file.bak, etc

There are too many patterns to consider

I support the newsyslog.conf changes. Nice.

The proposed change makes newsyslog.conf consistent with syslog.conf

Ready to commit now, after removing PORTREVISION

Fix up USES
rearange Makefile according to proper order

Not sure

Add UPDATING entry

Not sure what changed this time.

Patch for installing from packages vs git

Add .env.example & patch it for simple use
Patch includes/common.php so the about has a valid version and date
Remove :librenms from DISTFILES and MASTER_SITES because GH fixes that.

Use variables for DISTFILES

Do multiple MASTER_SITES

This builds cleanly on my servers.

The patches here did not apply cleanly against head for me, specifically, against Makefile. I manually applied the changes and built. It runs well on my box. Thank you.