Page MenuHomeFreeBSD

adamw (Adam Weinberger)
User

Projects

User Details

User Since
Mar 10 2015, 3:53 PM (245 w, 2 d)

Recent Activity

Today

adamw added a comment to D22492: security/gnupg: don't install man pages when DOCS is off.

Sorry Alan, this was breaking the build on 11 so I committed it.

Fri, Nov 22, 3:48 AM
adamw closed D22492: security/gnupg: don't install man pages when DOCS is off.
Fri, Nov 22, 3:47 AM
adamw committed rP518122: gnupg: Fix building on 11.3.
gnupg: Fix building on 11.3
Fri, Nov 22, 3:47 AM
adamw added a comment to D22492: security/gnupg: don't install man pages when DOCS is off.

Normally I push hard against avoidable dependencies, but I think the right thing to do here is to make makeinfo non-optional. Major gnupg dependencies (like gnutls, libgcrypt, m4, nettle, and autoconf) depend on texinfo, so there's really nothing to gain from hiding it behind a MANPAGES option (which is normally used when dependencies are ludicrous, like pandoc or whatever nonsense python thing cmake uses).

Fri, Nov 22, 2:55 AM

Yesterday

adamw added a comment to D22492: security/gnupg: don't install man pages when DOCS is off.

This isn't the right approach. Manpages aren't docs like FAQ and HACKING and DETAILS; they're manpages and their existence shouldn't be controlled by the DOCS option.

Thu, Nov 21, 11:09 PM
adamw added a comment to D22473: security/gnupg: add the --shared-access option to scdaemon.

I guess I should add to please make sure that make -C ${WRKSRC} check completes successfully.

Thu, Nov 21, 6:23 PM
adamw accepted D22473: security/gnupg: add the --shared-access option to scdaemon.

I haven't tested this (I have no way of actually testing it), so I'm relying on you there. You definitely have my approval to commit this whenever you're ready.

Thu, Nov 21, 6:21 PM
adamw accepted D22471: security/gnupg: rebuild man pages.

After updating the DOCS_BUILD_DEPENDS (and also bumping PORTREVISION please), feel free to commit this anytime.

Thu, Nov 21, 1:00 AM
adamw added a comment to D22471: security/gnupg: rebuild man pages.

I'm fine with a date change in that context.

Thu, Nov 21, 12:16 AM

Wed, Nov 20

adamw added a comment to D22471: security/gnupg: rebuild man pages.

This seems tremendously fragile. Unless I'm misunderstanding, these massive patches would have to be regenerated for every update (assuming changes), which---while I appreciate the patch coming down the pipeline---I don't relish the thought of being responsible for.

Wed, Nov 20, 11:39 PM
adamw added a comment to D22450: Permit multiple packing list files to be listed in PLIST..
In D22450#491430, @jhb wrote:

I think this probably warrants an exp-run before committing?

Wed, Nov 20, 10:25 PM
adamw committed rP518007: p5-EV: Update to 4.28.
p5-EV: Update to 4.28
Wed, Nov 20, 1:13 PM

Tue, Nov 19

adamw created D22449: Recommend against portmaster/portupgrade.
Tue, Nov 19, 11:22 PM

Mon, Nov 18

adamw committed rP517922: roda: Update to 3.26.0.
roda: Update to 3.26.0
Mon, Nov 18, 6:39 PM

Fri, Nov 15

adamw added a comment to D22389: Create desktop@ as maintainer of some shared desktop ports.

I applaud this move. It sets a great example of where individual maintainership should head: shared responsibility across the consumers who need to leverage it.

Fri, Nov 15, 10:19 PM

Fri, Nov 8

adamw committed rP517020: geoipupdate: Update to 4.1.4.
geoipupdate: Update to 4.1.4
Fri, Nov 8, 12:14 AM

Thu, Nov 7

adamw committed rP517013: geoipupdate: Update to 4.1.0.
geoipupdate: Update to 4.1.0
Thu, Nov 7, 9:05 PM
adamw committed rP516971: neovim: Update to 0.4.3.
neovim: Update to 0.4.3
Thu, Nov 7, 1:27 PM

Wed, Nov 6

adamw committed rP516879: neomutt: NLS=off no longer requires gettext during build.
neomutt: NLS=off no longer requires gettext during build
Wed, Nov 6, 12:22 PM

Tue, Nov 5

adamw committed rP516755: calc: Bump PORTREVISION for cscript path changes (to libexec).
calc: Bump PORTREVISION for cscript path changes (to libexec)
Tue, Nov 5, 12:15 AM
adamw committed rP516754: calc: Simplify and take maintainership.
calc: Simplify and take maintainership
Tue, Nov 5, 12:09 AM

Mon, Nov 4

adamw committed rP516750: links: Improve COMMENT and descr to be more useful.
links: Improve COMMENT and descr to be more useful
Mon, Nov 4, 10:57 PM
adamw committed rP516749: lynx-current: Update to 2.9.0.dev4 and take maintainership.
lynx-current: Update to 2.9.0.dev4 and take maintainership
Mon, Nov 4, 10:43 PM
adamw committed rP516726: mojolicious: Update to 8.26.
mojolicious: Update to 8.26
Mon, Nov 4, 5:08 PM

Fri, Nov 1

adamw committed rP516234: vim: Update to patchlevel 2237.
vim: Update to patchlevel 2237
Fri, Nov 1, 4:32 PM

Oct 17 2019

adamw committed rP514687: RSpec: Update to 3.9.0.
RSpec: Update to 3.9.0
Oct 17 2019, 8:48 PM
adamw committed rP514684: roda: Update to 3.25.0.
roda: Update to 3.25.0
Oct 17 2019, 8:41 PM

Oct 12 2019

adamw committed rP514343: antibody: Update to 4.2.0.
antibody: Update to 4.2.0
Oct 12 2019, 4:20 PM

Oct 7 2019

adamw committed rP513968: neovim: Update to 0.4.2.
neovim: Update to 0.4.2
Oct 7 2019, 3:45 PM
adamw committed rP513964: Add devel/luv: libuv bindings for Lua.
Add devel/luv: libuv bindings for Lua
Oct 7 2019, 3:40 PM
adamw committed rP513963: libvterm: Update to 0.1.1 and change upstream source.
libvterm: Update to 0.1.1 and change upstream source
Oct 7 2019, 3:33 PM

Oct 4 2019

adamw added a comment to D21717: Make it clear that a port's dependencies should not be minimal..

The committed version is a little weird. Sometimes the minimal dependency set is the ideal set, so saying it should never be it is misleading. Also, the last sentence isn't a sentence.

Oct 4 2019, 12:38 AM

Oct 1 2019

adamw committed rP513538: vim: Update to patchlevel 2108.
vim: Update to patchlevel 2108
Oct 1 2019, 10:35 PM

Sep 29 2019

adamw added a comment to D21744: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. sysutils-x11).

> Thanks. Some time ago @tobik wrote 6.5.8. Building Go Applications section that covers this process in details. It is tailored for Go modules, but I doubt that there will be much new Go software written that don't use them.

Sep 29 2019, 8:56 PM
adamw accepted D21744: Go ports: cleanup, finish transition to USES=go started with r505321 (cat. sysutils-x11).

I'll approve it.

Sep 29 2019, 7:37 PM
adamw committed rP513250: mojolicious: Update to 8.25.
mojolicious: Update to 8.25
Sep 29 2019, 5:03 PM

Sep 26 2019

adamw added a comment to D21511: Mk/bsd.default-versions.mk: Update MySQL versions.

bsd.default-versions.mk is maintained by ports@. There’s no approval needed from our end on it.

Sep 26 2019, 10:31 PM

Sep 24 2019

adamw added a comment to D21717: Make it clear that a port's dependencies should not be minimal..

Ah okay. I thought this was separate from OPTIONS.Then maybe:

Sep 24 2019, 10:57 PM

Sep 20 2019

adamw added a comment to D21717: Make it clear that a port's dependencies should not be minimal..

Ok. So, my concern here is that (a) I don't know what an "extra dependency" looks like, and (b) sometimes the configuration that would benefit the most people is the minimal or maximal set.

Sep 20 2019, 1:00 PM

Sep 16 2019

adamw added a comment to D21677: Change dmgk ports MAINTAINER email.

This automatically flagged @portmgr because of go.mk. It's a formality, but you certainly have our approval for it.

Sep 16 2019, 6:30 PM

Sep 14 2019

adamw committed rP511997: roda: Update to 3.24.0.
roda: Update to 3.24.0
Sep 14 2019, 4:58 AM

Sep 13 2019

adamw committed rP511975: geoipupdate: Update to 4.0.5.
geoipupdate: Update to 4.0.5
Sep 13 2019, 3:11 PM

Sep 12 2019

adamw committed rP511844: mojolicious: Update to 8.24.
mojolicious: Update to 8.24
Sep 12 2019, 12:30 AM

Sep 10 2019

adamw committed rP511728: Fix string typos.
Fix string typos
Sep 10 2019, 1:58 AM

Sep 6 2019

adamw committed rP511310: Return Mark Dixon's ports to the heap..
Return Mark Dixon's ports to the heap.
Sep 6 2019, 12:38 PM

Sep 3 2019

adamw added a comment to D21468: Overlay support for the ports tree.

It would be nice to put a note in CHANGES about this with a quick blurb on how to use it.

Sep 3 2019, 3:23 PM

Sep 1 2019

adamw committed rP510677: vim: Update to patchlevel 1954.
vim: Update to patchlevel 1954
Sep 1 2019, 5:29 AM

Aug 31 2019

adamw committed rP510313: geoipupdate: Update to 4.0.4.
geoipupdate: Update to 4.0.4
Aug 31 2019, 4:29 AM

Aug 26 2019

adamw committed rP509954: gnupg: Spell "_DESC" correctly. It was missing 5 characters..
gnupg: Spell "_DESC" correctly. It was missing 5 characters.
Aug 26 2019, 3:06 PM
adamw committed rP509952: gnupg: Add WKS_SERVER option.
gnupg: Add WKS_SERVER option
Aug 26 2019, 3:01 PM
adamw committed rP509948: gnupg: enable the WKS server.
gnupg: enable the WKS server
Aug 26 2019, 2:41 PM

Aug 25 2019

adamw committed rP509813: acts: Update to 1.4.1.
acts: Update to 1.4.1
Aug 25 2019, 6:09 PM

Aug 17 2019

adamw committed rP509159: Add an XML option to postgresql12-contrib.
Add an XML option to postgresql12-contrib
Aug 17 2019, 4:56 PM

Aug 14 2019

adamw committed rP508973: Fix packaging.
Fix packaging
Aug 14 2019, 9:17 PM
adamw added inline comments to D21262: If pkg-message is not a UCL file, assume the message is "install" only..
Aug 14 2019, 5:48 PM
adamw committed rP508921: roda: Update to 3.23.0.
roda: Update to 3.23.0
Aug 14 2019, 1:50 PM

Aug 13 2019

adamw committed rP508823: mojolicious: Update to 8.23.
mojolicious: Update to 8.23
Aug 13 2019, 1:38 PM

Aug 4 2019

adamw added a comment to D21158: Remove blanket exception for teams.

This is a good idea. The ability to continually improve FreeBSD shouldn't be blocked by the possibility of fixing a few small merge conflicts. We want people working together and helping each other out, not treating team ports as siloed and immutable.

Aug 4 2019, 1:50 PM

Aug 3 2019

adamw committed rP507974: vim: Simplify patch.
vim: Simplify patch
Aug 3 2019, 5:33 PM

Aug 2 2019

adamw committed rP507873: vim: Update to patchlevel 1790.
vim: Update to patchlevel 1790
Aug 2 2019, 12:14 PM

Jul 27 2019

adamw committed rP507396: acts: Fix excessive message spewing.
acts: Fix excessive message spewing
Jul 27 2019, 11:41 AM

Jul 26 2019

adamw added inline comments to D17459: Mk/bsd.options.desc.mk: Add version control systems OPTION descriptions.
Jul 26 2019, 12:00 PM

Jul 22 2019

adamw added a comment to D17459: Mk/bsd.options.desc.mk: Add version control systems OPTION descriptions.

Perhaps these could say Git repository support or, even better, Git code repository support.

Jul 22 2019, 12:07 PM

Jul 20 2019

adamw committed rP507023: Remove weblint (and august).
Remove weblint (and august)
Jul 20 2019, 9:46 PM

Jul 19 2019

adamw committed rP506904: sshguard: Fix rc(8) script, broken in update and then broken further in….
sshguard: Fix rc(8) script, broken in update and then broken further in…
Jul 19 2019, 2:09 AM

Jul 18 2019

adamw committed rP506851: mojolicious: Update to 8.22.
mojolicious: Update to 8.22
Jul 18 2019, 12:34 PM

Jul 15 2019

adamw committed rP506634: mojolicious: Update to 8.21.
mojolicious: Update to 8.21
Jul 15 2019, 2:32 AM

Jul 13 2019

adamw committed rP506547: rubygem-roda: Update to 3.22.0.
rubygem-roda: Update to 3.22.0
Jul 13 2019, 4:50 PM

Jul 12 2019

adamw committed rP506459: sysutils/acts: Update to 1.4.0.
sysutils/acts: Update to 1.4.0
Jul 12 2019, 12:47 PM

Jul 10 2019

adamw committed rP506332: mojolicious: Update to 8.20.
mojolicious: Update to 8.20
Jul 10 2019, 1:50 AM

Jul 9 2019

adamw committed rP506283: MFH: r506281.
MFH: r506281
Jul 9 2019, 3:57 PM
adamw committed rP506282: Add vuxml entry for gnupg < 2.2.17.
Add vuxml entry for gnupg < 2.2.17
Jul 9 2019, 3:55 PM
adamw committed rP506281: gnupg: Update to 2.2.17, with security fixes.
gnupg: Update to 2.2.17, with security fixes
Jul 9 2019, 3:54 PM
adamw committed rP506280: mojolicious: Update to 8.19.
mojolicious: Update to 8.19
Jul 9 2019, 12:21 PM

Jul 8 2019

adamw added a comment to D20881: Add "boringssl" to the list of possible SSL implementations.

I suspect that it's not been listed mainly because we haven't had a userbase segment express interest in widespread testing of it.

Jul 8 2019, 8:26 PM

Jul 6 2019

adamw committed rP505999: sshguard: Update to 2.4.0 and fix rc(8) script.
sshguard: Update to 2.4.0 and fix rc(8) script
Jul 6 2019, 3:33 PM
adamw added a comment to D20394: Ports Tree Base Packages.

By the way, SUBDIR in ports/Makefile and VALID_CATEGORIES in Mk/bsd.port.mk are both defined with += from the start, so you can define additions in /etc/make.conf and they won't be overridden.

Jul 6 2019, 2:56 PM
adamw added a comment to D20394: Ports Tree Base Packages.

I'll be happy to back out that bit if its a huge concern, but let me first lay out the scenario we're trying to solve, and I'm curious to know if there's some better way to solve this that we've been unaware of for years.

Jul 6 2019, 2:50 PM

Jul 5 2019

adamw added a comment to D20394: Ports Tree Base Packages.

I appreciate the work there, Kris, but a ports tree package is simply counterproductive. I am 100% opposed to a ports tree being in the release images in the first place; giving users another way to install a stale version of the tree is setting users up for failure. We do not support stale ports trees in any way; we shouldn't make it possible for users to get them in the first place.

Jul 5 2019, 2:09 PM

Jul 4 2019

adamw committed rP505843: MFH: r505842.
MFH: r505842
Jul 4 2019, 4:35 PM
adamw committed rP505842: neovim: Update to 0.3.8.
neovim: Update to 0.3.8
Jul 4 2019, 4:34 PM
adamw added a comment to D20394: Ports Tree Base Packages.

I should add here:

Jul 4 2019, 4:22 PM
adamw added a comment to D20394: Ports Tree Base Packages.

Thanks, those new categories make more sense to me.

Jul 4 2019, 4:07 PM

Jul 1 2019

adamw committed rP505626: Back out r505456. sshguard 2.4.0 misbehaves.
Back out r505456. sshguard 2.4.0 misbehaves
Jul 1 2019, 5:57 PM
adamw committed rP505533: Fix rc(8) script process detection.
Fix rc(8) script process detection
Jul 1 2019, 12:57 AM

Jun 30 2019

adamw committed rP505424: MFH r502589:.
MFH r502589:
Jun 30 2019, 2:44 PM
adamw committed rP505423: h2o{,-devel}: Improve rc.d/h2o, freshen h2o.conf.
h2o{,-devel}: Improve rc.d/h2o, freshen h2o.conf
Jun 30 2019, 2:41 PM

Jun 29 2019

adamw committed rP505317: mojolicious: Update to 8.18.
mojolicious: Update to 8.18
Jun 29 2019, 12:45 AM

Jun 26 2019

adamw added a comment to D20394: Ports Tree Base Packages.
In D20394#449271, @imp wrote:

The usual worry here is overwhelming the user with options because we have so many...

Jun 26 2019, 7:12 PM
adamw added a comment to D20394: Ports Tree Base Packages.

So, I'm just going to throw this out here. This is just a neat feature of the ports tree that the src framework might choose to leverage.

Jun 26 2019, 12:08 PM

Jun 25 2019

adamw added inline comments to D20394: Ports Tree Base Packages.
Jun 25 2019, 2:27 PM

Jun 20 2019

adamw updated the summary of D20698: Make it possible not to send MFH emails.

I see what you mean. Here it takes anything between parentheses as a sign to exit.

Jun 20 2019, 12:27 PM
adamw added inline comments to D20679: Cleanup patching of static content with sed..
Jun 20 2019, 12:22 PM

Jun 19 2019

adamw added a comment to D20698: Make it possible not to send MFH emails.
In D20698#447300, @mat wrote:

Then if the MFH line contains anything else than a branch name, say:

MFH: 2019Q2 (security update blanket approval)

There is no need to send an email because it will already have gotten committed.

Jun 19 2019, 10:13 PM
adamw added a comment to D20394: Ports Tree Base Packages.

I'm having trouble understanding how this is materially different than all the kmod ports relying on /usr/src for their builds, and that's not verified at all either. Also, in the future, we may have a src git repo, and we're looking at having signed commits so we'll know that a tree has integrity.

Jun 19 2019, 10:06 PM
adamw added a comment to D20698: Make it possible not to send MFH emails.

Oops, there was a typo there.

Jun 19 2019, 12:26 PM
adamw created D20698: Make it possible not to send MFH emails.
Jun 19 2019, 12:25 PM

Jun 17 2019

adamw added inline comments to D20679: Cleanup patching of static content with sed..
Jun 17 2019, 9:02 PM

Jun 15 2019

adamw committed rP504269: roda: Update to 3.21.0.
roda: Update to 3.21.0
Jun 15 2019, 10:13 PM

Jun 14 2019

adamw committed rP504195: msgpack: Don't build examples.
msgpack: Don't build examples
Jun 14 2019, 2:16 PM