Page MenuHomeFreeBSD

lang/janet: Update to 1.42.0
Needs ReviewPublic

Authored by dave_freedave.net on Thu, Sep 3, 3:07 PM.
Tags
None
Referenced Files
F170204885: D59342.id.diff
Thu, Sep 3, 9:03 PM
F170193468: fbsd15-janet-1.42.0.log
Thu, Sep 3, 7:46 PM
F170193442: fbsd14-janet-1.42.0.log
Thu, Sep 3, 7:46 PM
F170184840: D59342.diff
Thu, Sep 3, 6:53 PM
Subscribers
None

Details

Summary

I noticed on Janet zulip that they added filewatch via kqueue(2) to janet when creating this version.

I thought (but was wrong) that we had inotify(2) on all supported FreeBSD versions but that wont be true until next year. Anyway you get better file watch support for all the reasons given here.

But that requires patching here instead of upstream. sigh.

Test Plan

Manually run testport with -i and check that for stable/14 it does not have inotify_init1 symbol and that it does have it for stable/15:

poudriere testport -j FreeBSD14 -p local -i lang/janet
nm /wrkdirs/usr/ports/lang/janet/work/janet-1.42.0/_build/libjanet.so | grep inotify_init1
poudriere testport -j FreeBSD14 -p local -i lang/janet
nm /wrkdirs/usr/ports/lang/janet/work/janet-1.42.0/_build/libjanet.so | grep inotify_init1
                 U inotify_init1

logs for stable/14:

logs for stable/15:

And of course make test passes for both.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dave_freedave.net created this revision.
dave_freedave.net edited the test plan for this revision. (Show Details)

have to use bsd.port.pre.mk and bsd.port.post.mk or it doesn't have INOTIFY_PORT set.