- Upgrade to 1.18
- Change github org name to netdata
- Add FreeBSD specific patch for the megacli plugin (already accepted by upstream)
- Tested builds on FreeBSD 11.2, 11.3 and 12.0, see https://bsd.samm.cz/data/latest-per-pkg/netdata/1.18.1/
- Tested with portlint (few old warnings)
- Tested on 12.0 box
- Upgrade to 1.18.1
- Remove patches already accepted by upstream
- Remove linefeed to make portlint happy
I'm not sure which one to merge as I also have a patch https://reviews.freebsd.org/D21969
They're pretty similar with a few differences
Removal of USE_LDCONFIG is missing (not needed)
Make use of LTO selectable rather than having configure script using autodetection
pkg-plist isn't sorted alphabetical
Mine doesn't have pkg-descr updated and keeps the GH_ACCOUNT which I can of change if needed
...and I almost forgot, then sample configuration is also substantially simplified and updated.
Hi, my suggestion is to disable LTO option for a 2 reasons:
- It is automatically enabled if supported
- It breaks the build on 11.2
@samm Could you double check with @daniel.engberg.lists_pyret.net the changes that he is proposing and perhaps after that we can close the D21969 review?
A single place makes more sense, however @daniel.engberg.lists_pyret.net opened the review first, so technically he will receive the credits for the patch submission. I just want a single review for this port update.
Hi, i am perfectly fine to give him credits and merge the patches. Main problem is that there is no feedback from the maintainer. What should we do to get this done?
At PORTS HANDBOOK there is a section maintainer where it explains the TIMEOUT, the maintainer timeout is 14 days(2 weeks), in this case, as soon as one of your mentors approve this REVIEW you can commit and add this in the commit log:
Approved by: <nick> (mentor), maintainer (timeout 14 days)
So please, proceed to merge these two reviews and incorporate the submitter suggestions.
I am apologize for the delay, was very busy on recent GIMP release. I will take care of this today @daniel.engberg.lists_pyret.net
Hi, I think this should fix all known "issues"
@mmokhi ping, you wanted to go through this patch couple of weeks ago, something changed?
Since this seems to have stalled, can you commit my patch found here (https://reviews.freebsd.org/D22045#485880) which addresses all known issues so we can get this out the door?
mmokhi@ pinged me on twitter and told he's no access to internet at this moment and gave an approval for this patch, @samm could you commit your or @daniel.engberg.lists_pyret.net changes which are pretty similar anyway. Thanks.